net: sfp: improve Huawei MA5671a fixup

PATCH RESEND Superseded Álvaro Fernández Rojas 1 participant 1 message Mar 5

Subsystems (4)

Networking Network drivers Ethernet PHY SFF/SFP/SFP+ module support

lore

Share & tools

lore

Álvaro Fernández Rojas

author

2026-03-05 12:25 UTC #0 lore raw

PATCH RESEND 1/1 net: sfp: improve Huawei MA5671a fixup

With the current sfp_fixup_ignore_tx_fault() fixup we ignore the TX_FAULT signal, but we also need to apply sfp_fixup_ignore_los() in order to be able to communicate with the module even if the fiber isn't connected for configuration purposes.
This is needed for all the MA5671a firmwares, excluding the FS modded firmware.

Fixes 2069624dac19 ("net: sfp: Add tx-fault workaround for Huawei MA5671A SFP ONT")

Signed-off-by Álvaro Fernández Rojas <[email protected]>

---
 drivers/net/phy/sfp.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

drivers/net/phy/sfp.c +7 -1

index 347c1e0e94d9..bcea137ad5f9 100644
@@ -361,6 +361,12 @@ static void sfp_fixup_ignore_tx_fault(struct sfp *sfp)
 	sfp->state_ignore_mask |= SFP_F_TX_FAULT;
 }
 
+static void sfp_fixup_huawei(struct sfp *sfp)
+{
+	sfp_fixup_ignore_tx_fault(sfp);
+	sfp_fixup_ignore_los(sfp);
+}
+
 static void sfp_fixup_nokia(struct sfp *sfp)
 {
 	sfp_fixup_long_startup(sfp);

@@ -499,7 +505,7 @@ static const struct sfp_quirk sfp_quirks[] = {
 	// Huawei MA5671A can operate at 2500base-X, but report 1.2GBd NRZ in
 	// their EEPROM
 	SFP_QUIRK("HUAWEI", "MA5671A", sfp_quirk_2500basex,
-		  sfp_fixup_ignore_tx_fault),
+		  sfp_fixup_huawei),
 
 	// Lantech 8330-262D-E can operate at 2500base-X, but incorrectly report
 	// 2500MBd NRZ in their EEPROM

Signature · 1 line

2.47.3