leds: syscon: Add tristate option
v2 cover leds: syscon: Add tristate option
Quoted 1 line
My first submission to a linux-kernel list, so apologies for any errors.
Apologies, that didn't age well, I should have looked at the file history. It looks like the module=>builtin was done before, so this change reverts that.
It also adds MODULE_DESCRIPTION and MODULE_LICENSE along with the tristate Kconfig.
In OpenWrt, this allows leds-syscon to be .config'd as a module in subtargets, and then included / excluded from rootfs filesystems as required for specific boards. Without this, every board would need to have leds-syscon compiled as builtin just to provide it for one specific board. And OpenWrt devices are often space-constrained, where this is a significant concern.
Bevan Weiss (1):
leds: syscon: Add tristate option
drivers/leds/Kconfig | 4 ++-- drivers/leds/leds-syscon.c | 20 +++++++++++++++++--- 2 files changed, 19 insertions(+), 5 deletions(-)
Signature · 1 line
2.43.0
PATCH v2 1/1 leds: syscon: Add tristate option
This reverts commit f7d98a65d031 ("leds: syscon: Make the driver explicitly non-modular").
OpenWrt builds with a single .config for a given subtarget, whilst boards below that subtarget may not want to carry the disk usage of all options. So there is a preference to have all functionality not required on all boards as modules that can simply not be included in a given board rootfs to reduce disk usage.
Additional changes:
- (int)(struct platform_device *pdev) => void return
- Add MODULE_DESCRIPTION and MODULE_LICENSE macros
- Add tristate option to Kconfig
--- drivers/leds/Kconfig | 4 ++-- drivers/leds/leds-syscon.c | 20 +++++++++++++++++--- 2 files changed, 19 insertions(+), 5 deletions(-)
drivers/leds/Kconfig +2 -2
@@ -903,8 +903,8 @@ config LEDS_POWERNV will be called leds-powernv. config LEDS_SYSCON - bool "LED support for LEDs on system controllers" - depends on LEDS_CLASS=y + tristate "LED support for LEDs on system controllers" + depends on LEDS_CLASS depends on MFD_SYSCON depends on OF help
drivers/leds/leds-syscon.c +17 -3
@@ -6,7 +6,7 @@* Author: Linus Walleij <[email protected]> */ #include <linux/io.h> -#include <linux/init.h> +#include <linux/module.h> #include <linux/of.h> #include <linux/platform_device.h> #include <linux/stat.h>
@@ -121,17 +121,31 @@ static int syscon_led_probe(struct platform_device *pdev)return 0 ; } +static void syscon_led_remove (struct platform_device *pdev) +{ +struct syscon_led *sled =platform_get_drvdata (pdev); + +led_classdev_unregister (&sled->cdev); +/* Turn it off */ +regmap_update_bits (sled->map, sled->offset, sled->mask,0 ); +} +static const struct of_device_id of_syscon_leds_match[] = { { .compatible ="register-bit-led" , }, {}, }; +MODULE_DEVICE_TABLE (of, of_syscon_leds_match); +static struct platform_driver syscon_led_driver = { .probe = syscon_led_probe, + .remove = syscon_led_remove, .driver = { .name ="leds-syscon" , .of_match_table = of_syscon_leds_match, - .suppress_bind_attrs = true, }, }; -builtin_platform_driver (syscon_led_driver); +module_platform_driver (syscon_led_driver); + +MODULE_DESCRIPTION ("SYSCON LED driver" ); +MODULE_LICENSE ("GPL" );
Signature · 1 line
2.43.0