staging: axis-fifo: remove redundant goto end
PATCH 1/1 staging: axis-fifo: remove redundant goto end
--- drivers/staging/axis-fifo/axis-fifo.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-)
drivers/staging/axis-fifo/axis-fifo.c +8 -9
@@ -395,22 +395,22 @@ static int axis_fifo_parse_dt(struct axis_fifo *fifo) &value);if (ret) {dev_err (fifo->dt_device,"missing xlnx,axi-str-rxd-tdata-width property\n" ); - goto end; +return ret; }else if (value !=32 ) {dev_err (fifo->dt_device,"xlnx,axi-str-rxd-tdata-width only supports 32 bits\n" ); ret = -EIO ; - goto end; +return ret; } ret =of_property_read_u32 (node,"xlnx,axi-str-txd-tdata-width" , &value);if (ret) {dev_err (fifo->dt_device,"missing xlnx,axi-str-txd-tdata-width property\n" ); - goto end; +return ret; }else if (value !=32 ) {dev_err (fifo->dt_device,"xlnx,axi-str-txd-tdata-width only supports 32 bits\n" ); ret = -EIO ; - goto end; +return ret; } ret = of_property_read_u32(node, "xlnx,rx-fifo-depth",
@@ -418,7 +418,7 @@ static int axis_fifo_parse_dt(struct axis_fifo *fifo)if (ret) {dev_err (fifo->dt_device,"missing xlnx,rx-fifo-depth property\n" ); ret = -EIO ; - goto end; +return ret; } ret = of_property_read_u32(node, "xlnx,tx-fifo-depth",
@@ -426,7 +426,7 @@ static int axis_fifo_parse_dt(struct axis_fifo *fifo)if (ret) {dev_err (fifo->dt_device,"missing xlnx,tx-fifo-depth property\n" ); ret = -EIO ; - goto end; +return ret; } ret = of_property_read_u32(node, "xlnx,use-rx-data",
@@ -434,7 +434,7 @@ static int axis_fifo_parse_dt(struct axis_fifo *fifo)if (ret) {dev_err (fifo->dt_device,"missing xlnx,use-rx-data property\n" ); ret = -EIO ; - goto end; +return ret; } ret = of_property_read_u32(node, "xlnx,use-tx-data",
@@ -442,10 +442,9 @@ static int axis_fifo_parse_dt(struct axis_fifo *fifo)if (ret) {dev_err (fifo->dt_device,"missing xlnx,use-tx-data property\n" ); ret = -EIO ; - goto end; +return ret; } -end:return ret; }
Signature · 1 line
2.43.0
Quoted 10 lines · Josh Law
Signed-off-by Josh Law <[email protected]>--- drivers/staging/axis-fifo/axis-fifo.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-)drivers/staging/axis-fifo/axis-fifo.c +0
-0
drivers/staging/axis-fifo/axis-fifo.c static int axis_fifo_parse_dt(struct axis_fifo *fifo) · line 402
Quoted 10 lines
drivers/staging/axis-fifo/axis-fifo.c +2
-2@@ -395,22 +395,22 @@ static int axis_fifo_parse_dt(struct axis_fifo *fifo) &value);if (ret) {dev_err (fifo->dt_device,"missing xlnx,axi-str-rxd-tdata-width property\n" ); - goto end; +return ret; }else if (value !=32 ) {dev_err (fifo->dt_device,"xlnx,axi-str-rxd-tdata-width only supports 32 bits\n" ); ret = -EIO ; - goto end; +return ret;
Just return -EIO.
regards,
dan carpenter
Greg Kroah-Hartman
maintainerQuoted 1 line · Josh Law
Signed-off-by Josh Law <[email protected]>
No changelog and your From: line does not match your signed-off-by:
line, as others have pointed out :(
thanks,
greg k-h
9 Mar 2026 16:09:27 Greg Kroah-Hartman <[email protected]>:
Quoted 9 lines · Josh Law
Quoted 1 line
Signed-off-by Josh Law <[email protected]>No changelog and your From: line does not match your signed-off-by:
line, as others have pointed out :(thanks,
greg k-h
I think I made V2s.
9 Mar 2026 16:12:17 Josh Law <[email protected]>:
Quoted 5 lines
9 Mar 2026 16:09:27 Greg Kroah-Hartman <[email protected]>:
Quoted 3 lines · Josh Law
Quoted 1 line
Signed-off-by Josh Law <[email protected]>
Quoted 8 lines
Quoted 6 lines
No changelog and your From: line does not match your signed-off-by:
line, as others have pointed out :(thanks,
greg k-h
I think I made V2s.
Oh and also I made 10 V2 patches, come on.. atleast ONE is useful for you
Greg Kroah-Hartman
maintainerQuoted 10 lines · Josh Law
9 Mar 2026 16:12:17 Josh Law <[email protected]>:
Quoted 8 lines
9 Mar 2026 16:09:27 Greg Kroah-Hartman <[email protected]>:
Quoted 6 lines · Josh Law
Quoted 1 line
Signed-off-by Josh Law <[email protected]>No changelog and your From: line does not match your signed-off-by:
line, as others have pointed out :(
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
thanks,
greg k-h
I think I made V2s.
Oh and also I made 10 V2 patches, come on.. atleast ONE is useful for you
I have processed all pending staging patches now.
thanks,
greg k-h
9 Mar 2026 16:57:19 Greg Kroah-Hartman <[email protected]>:
Quoted 17 lines · Josh Law
Quoted 16 lines
9 Mar 2026 16:12:17 Josh Law <[email protected]>:
Quoted 13 lines
9 Mar 2026 16:09:27 Greg Kroah-Hartman <[email protected]>:
Quoted 9 lines · Josh Law
Quoted 1 line
Signed-off-by Josh Law <[email protected]>No changelog and your From: line does not match your signed-off-by:
line, as others have pointed out :(thanks,
greg k-h
I think I made V2s.
Quoted 7 lines
Quoted 1 line
Oh and also I made 10 V2 patches, come on.. atleast ONE is useful for you
I have processed all pending staging patches now.
thanks,
greg k-h
You've NAKed all 10 of my patches....?
Greg Kroah-Hartman
maintainerQuoted 21 lines · Josh Law
9 Mar 2026 16:57:19 Greg Kroah-Hartman <[email protected]>:
Quoted 19 lines · Josh Law
Quoted 17 lines
9 Mar 2026 16:12:17 Josh Law <[email protected]>:
Quoted 5 lines
9 Mar 2026 16:09:27 Greg Kroah-Hartman <[email protected]>:
Quoted 3 lines · Josh Law
Quoted 1 line
Signed-off-by Josh Law <[email protected]>Quoted 8 lines
Quoted 6 lines
No changelog and your From: line does not match your signed-off-by:
line, as others have pointed out :(thanks,
greg k-h
I think I made V2s.
Oh and also I made 10 V2 patches, come on.. atleast ONE is useful for you
Quoted 7 lines
Quoted 5 lines
I have processed all pending staging patches now.
thanks,
greg k-h
You've NAKed all 10 of my patches....?
You have had review comments on all patches sent that I can see, did I miss any?
thanks,
greg k-h
9 Mar 2026 17:02:10 Greg Kroah-Hartman <[email protected]>:
Quoted 20 lines · Josh Law
Quoted 19 lines
9 Mar 2026 16:57:19 Greg Kroah-Hartman <[email protected]>:
Quoted 16 lines · Josh Law
Quoted 9 lines
9 Mar 2026 16:12:17 Josh Law <[email protected]>:
Quoted 5 lines
9 Mar 2026 16:09:27 Greg Kroah-Hartman <[email protected]>:
Quoted 1 line
…
I think I made V2s.
Oh and also I made 10 V2 patches, come on.. atleast ONE is useful for you
I have processed all pending staging patches now.
thanks,
greg k-h
Quoted 8 lines
Quoted 1 line
You've NAKed all 10 of my patches....?
You have had review comments on all patches sent that I can see, did I miss any?
thanks,
greg k-h
You missed about 10 of my V2s
V/R
Greg Kroah-Hartman
maintainerQuoted 24 lines · Josh Law
9 Mar 2026 17:02:10 Greg Kroah-Hartman <[email protected]>:
Quoted 22 lines · Josh Law
Quoted 20 lines
9 Mar 2026 16:57:19 Greg Kroah-Hartman <[email protected]>:
Quoted 9 lines · Josh Law
Quoted 8 lines
9 Mar 2026 16:12:17 Josh Law <[email protected]>:
Quoted 5 lines
9 Mar 2026 16:09:27 Greg Kroah-Hartman <[email protected]>:
Quoted 1 line
…
I think I made V2s.
Quoted 7 lines
Quoted 1 line
Oh and also I made 10 V2 patches, come on.. atleast ONE is useful for you
I have processed all pending staging patches now.
thanks,
greg k-h
You've NAKed all 10 of my patches....?
Quoted 8 lines
Quoted 6 lines
You have had review comments on all patches sent that I can see, did I miss any?
thanks,
greg k-h
You missed about 10 of my V2s
What is the lore.kernel.org link of the patches I missed?
I see Dan's response to your v2 series of 10 patches, which I agree with, you need to address that before I can look at that again. Please don't ignore his comments.
thanks,
greg k-h
9 Mar 2026 17:06:48 Greg Kroah-Hartman <[email protected]>:
Quoted 28 lines · Josh Law
Quoted 16 lines
9 Mar 2026 17:02:10 Greg Kroah-Hartman <[email protected]>:
Quoted 14 lines · Josh Law
Quoted 12 lines
9 Mar 2026 16:57:19 Greg Kroah-Hartman <[email protected]>:
Quoted 8 lines · Josh Law
Quoted 1 line
…
I have processed all pending staging patches now.
thanks,
greg k-h
You've NAKed all 10 of my patches....?
Quoted 8 lines
Quoted 6 lines
You have had review comments on all patches sent that I can see, did I miss any?
thanks,
greg k-h
You missed about 10 of my V2s
What is the lore.kernel.org link of the patches I missed?
Quoted 7 lines
I see Dan's response to your v2 series of 10 patches, which I agree with, you need to address that before I can look at that again. Please don't ignore his comments.
thanks,
greg k-h
https://lore.kernel.org/all/[email protected]/
https://lore.kernel.org/all/[email protected]/
https://lore.kernel.org/all/[email protected]/
https://lore.kernel.org/all/[email protected]/
https://lore.kernel.org/all/[email protected]/
https://lore.kernel.org/all/[email protected]/
https://lore.kernel.org/all/[email protected]/
https://lore.kernel.org/all/[email protected]/
https://lore.kernel.org/all/[email protected]/
https://lore.kernel.org/all/[email protected]/
V/R
Also, I am responding to Dan's comments, but I am focusing on lib/ at the moment, since I'm a reviewer, and I've had more time to fix lib/
Later, the patches that Dan NAKed, I will go ahead and fix them for you
9 Mar 2026 17:09:53 Josh Law <[email protected]>:
Quoted 43 lines
9 Mar 2026 17:06:48 Greg Kroah-Hartman <[email protected]>:
Quoted 21 lines · Josh Law
Quoted 9 lines
9 Mar 2026 17:02:10 Greg Kroah-Hartman <[email protected]>:
Quoted 7 lines · Josh Law
Quoted 5 lines
9 Mar 2026 16:57:19 Greg Kroah-Hartman <[email protected]>:
Quoted 1 line
…
You've NAKed all 10 of my patches....?
Quoted 8 lines
Quoted 6 lines
You have had review comments on all patches sent that I can see, did I miss any?
thanks,
greg k-h
You missed about 10 of my V2s
What is the lore.kernel.org link of the patches I missed?
Quoted 7 lines
I see Dan's response to your v2 series of 10 patches, which I agree with, you need to address that before I can look at that again. Please don't ignore his comments.
thanks,
greg k-h
https://lore.kernel.org/all/[email protected]/
https://lore.kernel.org/all/[email protected]/
https://lore.kernel.org/all/[email protected]/
https://lore.kernel.org/all/[email protected]/
https://lore.kernel.org/all/[email protected]/
https://lore.kernel.org/all/[email protected]/
https://lore.kernel.org/all/[email protected]/
https://lore.kernel.org/all/[email protected]/
https://lore.kernel.org/all/[email protected]/
https://lore.kernel.org/all/[email protected]/
Quoted 8 lines
V/R
Also, I am responding to Dan's comments, but I am focusing on
lib/at the moment, since I'm a reviewer, and I've had more time to fixlib/Later, the patches that Dan NAKed, I will go ahead and fix them for you
If it's convenient for you you can ignore one and two since they have no descriptions, patch 5 is worth looking at maybe.
Quoted 3 lines · Josh Law
If it's convenient for you you can ignore one and two since they have no descriptions, patch 5 is worth looking at maybe.
I was predicting that patch 5 wouldn't make a measurable difference but I didn't know you owned the hardware. Could you try measure it?
regards,
dan carpenter
9 Mar 2026 22:00:17 Dan Carpenter <[email protected]>:
Quoted 10 lines · Josh Law
Quoted 3 lines
If it's convenient for you you can ignore one and two since they have no descriptions, patch 5 is worth looking at maybe.
I was predicting that patch 5 wouldn't make a measurable difference but I didn't know you owned the hardware. Could you try measure it?
regards,
dan carpenter
LMAO of course I own axis-fifo, that's why I'm doing it.
It just makes code run better to be honest, unclutters it, hopefully moves it out of staging (wink)
Only one or two of my changes are for performance.....
I've measured them in another thread