Skip to contentSkip to conversation

Kontron i.MX8MP OSM Devicetree Fixups

PATCH Applied Frieder Schrempf 4 participants 7 messages Mar 9 – Mar 23

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

v3 cover Kontron i.MX8MP OSM Devicetree Fixups

From: Frieder Schrempf <[email protected]>

This contains three fixes and one cosmetic change for the Kontron i.MX8MP OSM devices.

Changes for v3:
* Drop applied patches
* Add missing bindings patch for RV3028 RTC

Changes for v2:
* Add Frank's R-b tags (thanks)
* Enhance commit message of patch 2

Annette Kobou (1):
arm64: dts: imx8mp-kontron: Fix boot order for PMIC and RTC

Frieder Schrempf (1):
dt-bindings: rtc: microcrystal,rv3028: Allow to specify vdd-supply

 .../devicetree/bindings/rtc/microcrystal,rv3028.yaml        | 2 ++
 arch/arm64/boot/dts/freescale/imx8mp-kontron-osm-s.dtsi     | 6 ++++++
 2 files changed, 8 insertions(+)
Signature · 1 line
2.53.0
#1 lore raw

PATCH v3 1/2 dt-bindings: rtc: microcrystal,rv3028: Allow to specify vdd-supply

From: Frieder Schrempf <[email protected]>

In case the VDD supply voltage regulator of the RTC needs to be specified explicitly, allow to set vdd-supply.

---
 Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/rtc/microcrystal,rv3028.yaml +2 -0
index cda8ad7c12037..2ea3b40419530 100644
@@ -32,6 +32,8 @@ properties:
       - 9000
       - 15000
 
+  vdd-supply: true
+
 required:
   - compatible
   - reg
Signature · 1 line
2.53.0
#3 lore raw

PATCH v3 2/2 arm64: dts: imx8mp-kontron: Fix boot order for PMIC and RTC

In reply to Frieder Schrempf

From: Annette Kobou <[email protected]>

The PMIC provides a level-shifter for the I2C lines to the RTC. As the level shifter needs to be enabled before the RTC can be accessed, we need to make sure that the PMIC driver is probed first.

As the PMIC also provides the supply voltage for the RTC through the 3.3V regulator, we can simply express this in the DT to create the required dependency.

This fixes sporadic boot hangs that occurred when the RTC was accessed before the level-shifter was enabled.

Fixes 946ab10e3f40f ("arm64: dts: Add support for Kontron OSM-S i.MX8MP SoM and BL carrier board")
---
 arch/arm64/boot/dts/freescale/imx8mp-kontron-osm-s.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)
arch/arm64/boot/dts/freescale/imx8mp-kontron-osm-s.dtsi +6 -0
index b97bfeb1c30f8..bc1a261bb000e 100644
@@ -330,6 +330,12 @@ rv3028: rtc@52 {
 		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_rtc>;
 		interrupts-extended = <&gpio3 24 IRQ_TYPE_LEVEL_LOW>;
+		/*
+		 * While specifying the vdd-supply is normally not strictly necessary,
+		 * here it also makes sure that the PMIC driver enables the level-
+		 * shifter for the RTC before the RTC is probed.
+		 */
+		vdd-supply = <&reg_vdd_3v3>;
 	};
 };
 
Signature · 1 line
2.53.0
maintainer
#4 lore raw
In reply to Frieder Schrempf
Quoted 13 lines · Frieder Schrempf

From: Frieder Schrempf <[email protected]>

This contains three fixes and one cosmetic change for the Kontron i.MX8MP OSM devices.

Changes for v3:
* Drop applied patches
* Add missing bindings patch for RV3028 RTC

Changes for v2:
* Add Frank's R-b tags (thanks)
* Enhance commit message of patch 2

Quoted 5 lines

Annette Kobou (1):
arm64: dts: imx8mp-kontron: Fix boot order for PMIC and RTC

Frieder Schrempf (1):
dt-bindings: rtc: microcrystal,rv3028: Allow to specify vdd-supply

Please include this patch in [email protected] next time. I will not track this patches status. If it Acked or applied, let me know.

Frank

Quoted 8 lines
 .../devicetree/bindings/rtc/microcrystal,rv3028.yaml        | 2 ++
 arch/arm64/boot/dts/freescale/imx8mp-kontron-osm-s.dtsi     | 6 ++++++
 2 files changed, 8 insertions(+)

--
2.53.0

maintainer Applied
#5 lore raw

Re: (subset) [PATCH v3 0/2] Kontron i.MX8MP OSM Devicetree Fixups

In reply to Frieder Schrempf
Quoted 8 lines · Frieder Schrempf

Kontron i.MX8MP OSM Devicetree Fixups

From: Frieder Schrempf <[email protected]>

This contains three fixes and one cosmetic change for the Kontron i.MX8MP OSM devices.

[...]

Applied, thanks!

[1/2] dt-bindings: rtc: microcrystal,rv3028: Allow to specify vdd-supply

      https://git.kernel.org/abelloni/c/10663044bee5

Best regards,

maintainer Applied
#6 lore raw

Re: (subset) [PATCH v3 0/2] Kontron i.MX8MP OSM Devicetree Fixups

In reply to Frieder Schrempf
Quoted 10 lines · Frieder Schrempf

From: Frieder Schrempf <[email protected]>

This contains three fixes and one cosmetic change for the Kontron i.MX8MP OSM devices.

Changes for v3:
* Drop applied patches
* Add missing bindings patch for RV3028 RTC

[...]

Applied, thanks!

[2/2] arm64: dts: imx8mp-kontron: Fix boot order for PMIC and RTC

      commit: 0f02852af55591d6a8609347890cc348f86fdac9

Update commit messsage, adjust wrap at 75 char. Change "this fixes" to avoid. Remove "We can ..."

Best regards,
--
Frank Li <[email protected]>