Skip to contentSkip to conversation

Addadd FALLOC_FL_WRITE_ZEROES support to xfs

PATCH In review Lukas Herbolt 2 participants 3 messages Mar 9 – Mar 10 XFS filesystem

lore
Share & tools
lore
#0 lore raw

cover Addadd FALLOC_FL_WRITE_ZEROES support to xfs

This is addtion of the FALLOC_FL_WRITE_ZEROES into the XFS.

As suggested this is split into two patches firts one introduce the bmapi_flags for xfs_alloc_file_space. Second patch implements the FALLOC_FL_WRITE_ZEROES doing it in two steps, first preallocates and then converts it to zeroed. Sending first patch as v0 and second as v11 to make the changes visible.

The first patch is just changes to
Doing the tho phase allocation t
Lukas Herbolt (2):
xfs: Introduce 'bmapi_flags' parameter to xfs_alloc_file_space()
xfs: add FALLOC_FL_WRITE_ZEROES to XFS code base

 fs/xfs/xfs_bmap_util.c |  5 +++--
 fs/xfs/xfs_bmap_util.h |  2 +-
 fs/xfs/xfs_file.c      | 47 ++++++++++++++++++++++++++++++------------
 3 files changed, 38 insertions(+), 16 deletions(-)
Signature · 1 line
2.53.0
#1 lore raw

PATCH 1/2 xfs: Introduce 'bmapi_flags' parameter to xfs_alloc_file_space()

Add bmapi_flags to xfs_alloc_file_space for future use with FALLOC_FL_WRITE_ZEROES new fallocate mode. This allows callers to explicitly pass the required XFS_BMAPI_* allocation flags.

Update all existing callers to pass XFS_BMAPI_PREALLOC to maintain the current behavior. No functional changes intended.

---
 fs/xfs/xfs_bmap_util.c | 5 +++--
 fs/xfs/xfs_bmap_util.h | 2 +-
 fs/xfs/xfs_file.c      | 9 ++++++---
 3 files changed, 10 insertions(+), 6 deletions(-)
fs/xfs/xfs_bmap_util.c +3 -2
index 2208a720ec3f..e92f9cd05f52 100644
@@ -646,7 +646,8 @@ int
 xfs_alloc_file_space(
 	struct xfs_inode	*ip,
 	xfs_off_t		offset,
-	xfs_off_t		len)
+	xfs_off_t		len,
+	uint32_t                bmapi_flags)
 {
 	xfs_mount_t		*mp = ip->i_mount;
 	xfs_off_t		count;
@@ -748,7 +749,7 @@ xfs_alloc_file_space(
 		 * will eventually reach the requested range.
 		 */
 		error = xfs_bmapi_write(tp, ip, startoffset_fsb,
-				allocatesize_fsb, XFS_BMAPI_PREALLOC, 0, imapp,
+				allocatesize_fsb, bmapi_flags, 0, imapp,
 				&nimaps);
 		if (error) {
 			if (error != -ENOSR)
fs/xfs/xfs_bmap_util.h +1 -1
index c477b3361630..2895cc97a572 100644
@@ -56,7 +56,7 @@ int	xfs_bmap_last_extent(struct xfs_trans *tp, struct xfs_inode *ip,
 
 /* preallocation and hole punch interface */
 int	xfs_alloc_file_space(struct xfs_inode *ip, xfs_off_t offset,
-		xfs_off_t len);
+		xfs_off_t len, uint32_t bmapi_flags);
 int	xfs_free_file_space(struct xfs_inode *ip, xfs_off_t offset,
 		xfs_off_t len, struct xfs_zone_alloc_ctx *ac);
 int	xfs_collapse_file_space(struct xfs_inode *, xfs_off_t offset,
fs/xfs/xfs_file.c +6 -3
index 7874cf745af3..fd049a1fc9c6 100644
@@ -1310,7 +1310,8 @@ xfs_falloc_zero_range(
 		len = round_up(offset + len, blksize) -
 			round_down(offset, blksize);
 		offset = round_down(offset, blksize);
-		error = xfs_alloc_file_space(ip, offset, len);
+		error = xfs_alloc_file_space(ip, offset, len,
+				XFS_BMAPI_PREALLOC);
 	}
 	if (error)
 		return error;
@@ -1336,7 +1337,8 @@ xfs_falloc_unshare_range(
 	if (error)
 		return error;
 
-	error = xfs_alloc_file_space(XFS_I(inode), offset, len);
+	error = xfs_alloc_file_space(XFS_I(inode), offset, len,
+			XFS_BMAPI_PREALLOC);
 	if (error)
 		return error;
 	return xfs_falloc_setsize(file, new_size);
@@ -1364,7 +1366,8 @@ xfs_falloc_allocate_range(
 	if (error)
 		return error;
 
-	error = xfs_alloc_file_space(XFS_I(inode), offset, len);
+	error = xfs_alloc_file_space(XFS_I(inode), offset, len,
+			XFS_BMAPI_PREALLOC);
 	if (error)
 		return error;
 	return xfs_falloc_setsize(file, new_size);
Signature · 1 line
2.53.0
Reviewed-by on v1 1/2
#2 lore raw

Re: [PATCH 1/2] xfs: Introduce 'bmapi_flags' parameter to xfs_alloc_file_space()

Quoted 10 lines · Lukas Herbolt

Add bmapi_flags to xfs_alloc_file_space for future use with FALLOC_FL_WRITE_ZEROES new fallocate mode. This allows callers to explicitly pass the required XFS_BMAPI_* allocation flags.

Update all existing callers to pass XFS_BMAPI_PREALLOC to maintain the current behavior. No functional changes intended.

Looks ok,

--D

Quoted 81 lines
---
 fs/xfs/xfs_bmap_util.c | 5 +++--
 fs/xfs/xfs_bmap_util.h | 2 +-
 fs/xfs/xfs_file.c      | 9 ++++++---
 3 files changed, 10 insertions(+), 6 deletions(-)
fs/xfs/xfs_bmap_util.c +3 -2
index 2208a720ec3f..e92f9cd05f52 100644
@@ -646,7 +646,8 @@ int
 xfs_alloc_file_space(
 	struct xfs_inode	*ip,
 	xfs_off_t		offset,
-	xfs_off_t		len)
+	xfs_off_t		len,
+	uint32_t                bmapi_flags)
 {
 	xfs_mount_t		*mp = ip->i_mount;
 	xfs_off_t		count;
@@ -748,7 +749,7 @@ xfs_alloc_file_space(
 		 * will eventually reach the requested range.
 		 */
 		error = xfs_bmapi_write(tp, ip, startoffset_fsb,
-				allocatesize_fsb, XFS_BMAPI_PREALLOC, 0, imapp,
+				allocatesize_fsb, bmapi_flags, 0, imapp,
 				&nimaps);
 		if (error) {
 			if (error != -ENOSR)
fs/xfs/xfs_bmap_util.h +1 -1
index c477b3361630..2895cc97a572 100644
@@ -56,7 +56,7 @@ int	xfs_bmap_last_extent(struct xfs_trans *tp, struct xfs_inode *ip,
 
 /* preallocation and hole punch interface */
 int	xfs_alloc_file_space(struct xfs_inode *ip, xfs_off_t offset,
-		xfs_off_t len);
+		xfs_off_t len, uint32_t bmapi_flags);
 int	xfs_free_file_space(struct xfs_inode *ip, xfs_off_t offset,
 		xfs_off_t len, struct xfs_zone_alloc_ctx *ac);
 int	xfs_collapse_file_space(struct xfs_inode *, xfs_off_t offset,
fs/xfs/xfs_file.c +6 -3
index 7874cf745af3..fd049a1fc9c6 100644
@@ -1310,7 +1310,8 @@ xfs_falloc_zero_range(
 		len = round_up(offset + len, blksize) -
 			round_down(offset, blksize);
 		offset = round_down(offset, blksize);
-		error = xfs_alloc_file_space(ip, offset, len);
+		error = xfs_alloc_file_space(ip, offset, len,
+				XFS_BMAPI_PREALLOC);
 	}
 	if (error)
 		return error;
@@ -1336,7 +1337,8 @@ xfs_falloc_unshare_range(
 	if (error)
 		return error;
 
-	error = xfs_alloc_file_space(XFS_I(inode), offset, len);
+	error = xfs_alloc_file_space(XFS_I(inode), offset, len,
+			XFS_BMAPI_PREALLOC);
 	if (error)
 		return error;
 	return xfs_falloc_setsize(file, new_size);
@@ -1364,7 +1366,8 @@ xfs_falloc_allocate_range(
 	if (error)
 		return error;
 
-	error = xfs_alloc_file_space(XFS_I(inode), offset, len);
+	error = xfs_alloc_file_space(XFS_I(inode), offset, len,
+			XFS_BMAPI_PREALLOC);
 	if (error)
 		return error;
 	return xfs_falloc_setsize(file, new_size);
Signature · 1 line
2.53.0