staging: atomisp: fix block comment style in circbuf.c
Subsystems (4)
PATCH 1/1 staging: atomisp: fix block comment style in circbuf.c
--- .../media/atomisp/pci/base/circbuf/src/circbuf.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-)
drivers/staging/media/atomisp/pci/base/circbuf/src/circbuf.c +9 -6
@@ -192,9 +192,9 @@ uint32_t ia_css_circbuf_peek_from_start(ia_css_circbuf_t *cb, int offset)* Please refer to "ia_css_circbuf.h" for details. */ bool ia_css_circbuf_increase_size ( -ia_css_circbuf_t *cb, -unsigned int sz_delta, -ia_css_circbuf_elem_t *elems) +ia_css_circbuf_t *cb, +unsigned int sz_delta, +ia_css_circbuf_elem_t *elems) {u8 curr_size;u8 curr_end;
@@ -206,7 +206,8 @@ bool ia_css_circbuf_increase_size( curr_size = cb->desc->size; curr_end = cb->desc->end;/* We assume cb was pre defined as global to allow -* increase in size */ +* increase in size +*/ /* FM: are we sure this cannot cause size to become too big? */ if (((uint8_t )(cb->desc->size + (uint8_t )sz_delta) > cb->desc->size) && ((uint8_t )sz_delta == sz_delta))
@@ -215,12 +216,14 @@ bool ia_css_circbuf_increase_size(return false;/* overflow in size */ /* If elems are passed update them else we assume its been taken -* care before calling this function */ +* care before calling this function +*/ if (elems) {/* cb element array size will not be increased dynamically, * but pointers to new elements can be added at the end * of existing pre defined cb element array of -* size >= new size if not already added */ +* size >= new size if not already added +*/ for (i = curr_size; i < cb->desc->size; i++) cb->elems[i] = elems[i - curr_size]; }
Signature · 1 line
2.43.0
Sakari Ailus
reviewerHi Oskar,
On Mon, Mar 09, 2026 at 10:30:24PM +0100, Oskar Ray-Frayssinet wrote:
A more elaborate description of the patch goes here.
Quoted 10 lines
Signed-off-by Oskar Ray-Frayssinet <[email protected]>--- .../media/atomisp/pci/base/circbuf/src/circbuf.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-)drivers/staging/media/atomisp/pci/base/circbuf/src/circbuf.c +0
-0
drivers/staging/media/atomisp/pci/base/circbuf/src/circbuf.c uint32_t ia_css_circbuf_peek_from_start(ia_css_circbuf_t *cb, int offset) · line 197
Quoted 9 lines
drivers/staging/media/atomisp/pci/base/circbuf/src/circbuf.c +3
-3@@ -192,9 +192,9 @@ uint32_t ia_css_circbuf_peek_from_start(ia_css_circbuf_t *cb, int offset)* Please refer to "ia_css_circbuf.h" for details. */ bool ia_css_circbuf_increase_size ( -ia_css_circbuf_t *cb, -unsigned int sz_delta, -ia_css_circbuf_elem_t *elems) +ia_css_circbuf_t *cb, +unsigned int sz_delta, +ia_css_circbuf_elem_t *elems)
You could improve this more.
Quoted 14 lines
drivers/staging/media/atomisp/pci/base/circbuf/src/circbuf.c +2
-1{u8 curr_size;u8 curr_end;@@ -206,7 +206,8 @@ bool ia_css_circbuf_increase_size( curr_size = cb->desc->size; curr_end = cb->desc->end;/* We assume cb was pre defined as global to allow -* increase in size */ +* increase in size +*/ /* FM: are we sure this cannot cause size to become too big? */ if (((uint8_t )(cb->desc->size + (uint8_t )sz_delta) > cb->desc->size) && ((uint8_t )sz_delta == sz_delta))
drivers/staging/media/atomisp/pci/base/circbuf/src/circbuf.c bool ia_css_circbuf_increase_size( · line 218
Quoted 3 lines
drivers/staging/media/atomisp/pci/base/circbuf/src/circbuf.c +0
-0@@ -215,12 +216,14 @@ bool ia_css_circbuf_increase_size(return false;/* overflow in size */ /* If elems are passed update them else we assume its been taken
/*
* Multi-line
* comment.
*/
Quoted 13 lines
drivers/staging/media/atomisp/pci/base/circbuf/src/circbuf.c +4
-2-* care before calling this function */ +* care before calling this function +*/ if (elems) {/* cb element array size will not be increased dynamically, * but pointers to new elements can be added at the end * of existing pre defined cb element array of -* size >= new size if not already added */ +* size >= new size if not already added +*/ for (i = curr_size; i < cb->desc->size; i++) cb->elems[i] = elems[i - curr_size]; }
Signature · 3 lines
Regards, Sakari Ailus
PATCH v2 1/1 staging: media: atomisp: fix block comment style in circbuf.c
In reply to Oskar Ray-FrayssinetFix block comment formatting to comply with kernel coding style:
- Add leading '*' on continuation lines
- Move trailing '*/' to a separate line
--- .../media/atomisp/pci/base/circbuf/src/circbuf.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-)
drivers/staging/media/atomisp/pci/base/circbuf/src/circbuf.c +9 -6
@@ -192,9 +192,9 @@ uint32_t ia_css_circbuf_peek_from_start(ia_css_circbuf_t *cb, int offset)* Please refer to "ia_css_circbuf.h" for details. */ bool ia_css_circbuf_increase_size ( -ia_css_circbuf_t *cb, -unsigned int sz_delta, -ia_css_circbuf_elem_t *elems) +ia_css_circbuf_t *cb, +unsigned int sz_delta, +ia_css_circbuf_elem_t *elems) {u8 curr_size;u8 curr_end;
@@ -206,7 +206,8 @@ bool ia_css_circbuf_increase_size( curr_size = cb->desc->size; curr_end = cb->desc->end;/* We assume cb was pre defined as global to allow -* increase in size */ +* increase in size +*/ /* FM: are we sure this cannot cause size to become too big? */ if (((uint8_t )(cb->desc->size + (uint8_t )sz_delta) > cb->desc->size) && ((uint8_t )sz_delta == sz_delta))
@@ -215,12 +216,14 @@ bool ia_css_circbuf_increase_size(return false;/* overflow in size */ /* If elems are passed update them else we assume its been taken -* care before calling this function */ +* care before calling this function +*/ if (elems) {/* cb element array size will not be increased dynamically, * but pointers to new elements can be added at the end * of existing pre defined cb element array of -* size >= new size if not already added */ +* size >= new size if not already added +*/ for (i = curr_size; i < cb->desc->size; i++) cb->elems[i] = elems[i - curr_size]; }
Signature · 1 line
2.43.0
Re: [PATCH v2] staging: media: atomisp: fix block comment style in circbuf.c
Quoted 3 lines · Oskar Ray-Frayssinet
Fix block comment formatting to comply with kernel coding style:
- Add leading '*' on continuation lines
- Move trailing '*/' to a separate line
You fixed something new I haven't asked for in v1 and you missed completely my point in v1 review.
Try again.
Signature · 2 lines
With Best Regards, Andy Shevchenko
PATCH v3 1/1 staging: media: atomisp: fix block comment style in circbuf.c
In reply to Oskar Ray-FrayssinetFix block comment formatting to comply with kernel coding style:
- Move text from opening '/*' line to a separate continuation line
- Add leading '*' on continuation lines
- Move trailing '*/' to a separate line
--- .../media/atomisp/pci/base/circbuf/src/circbuf.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-)
drivers/staging/media/atomisp/pci/base/circbuf/src/circbuf.c +8 -4
@@ -186,7 +186,8 @@ uint32_t ia_css_circbuf_peek_from_start(ia_css_circbuf_t *cb, int offset)return cb->elems[pos].val; } -/* @brief increase size of a circular buffer. +/* +* @brief increase size of a circular buffer. * Use 'CAUTION' before using this function. This was added to * support / fix issue with increasing size for tagger only * Please refer to "ia_css_circbuf.h" for details.
@@ -205,7 +206,8 @@ bool ia_css_circbuf_increase_size( curr_size = cb->desc->size; curr_end = cb->desc->end; -/* We assume cb was pre defined as global to allow +/* +* We assume cb was pre defined as global to allow * increase in size */ /* FM: are we sure this cannot cause size to become too big? */
@@ -215,11 +217,13 @@ bool ia_css_circbuf_increase_size(else return false;/* overflow in size */ -/* If elems are passed update them else we assume its been taken +/* +* If elems are passed update them else we assume its been taken * care before calling this function */ if (elems) { -/* cb element array size will not be increased dynamically, +/* +* cb element array size will not be increased dynamically, * but pointers to new elements can be added at the end * of existing pre defined cb element array of * size >= new size if not already added
Signature · 1 line
2.43.0
Re: [PATCH v3] staging: media: atomisp: fix block comment style in circbuf.c
Hi Oskar,
Thanks for the patch.
Quoted 8 lines · Oskar Ray-Frayssinet
Fix block comment formatting to comply with kernel coding style:
- Move text from opening '/*' line to a separate continuation line
- Add leading '*' on continuation lines
- Move trailing '*/' to a separate lineSigned-off-by Oskar Ray-Frayssinet <[email protected]>--- .../media/atomisp/pci/base/circbuf/src/circbuf.c | 12 ++++++++----
This no longer applies to my atomisp branch <URL:https://git.linuxtv.org/sailus/media_tree.git/log/?h=atomisp>. :-(
Signature · 3 lines
Kind regards, Sakari Ailus