spi: rockchip-sfc: Fix double-free in remove() callback
Subsystems (2)
PATCH v2 1/1 spi: rockchip-sfc: Fix double-free in remove() callback
The driver uses devm_spi_register_controller() for registration, which automatically unregisters the controller via devm cleanup when the device is removed. The manual call to spi_unregister_controller() in the remove() callback can lead to a double-free.
And to make sure controller is unregistered before DMA buffer is unmapped, switch to use spi_register_controller() in probe().
---
Changes in v2:
- Fix Mark's comment.
- Link to v1: https://lore.kernel.org/r/[email protected]
--- drivers/spi/spi-rockchip-sfc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/spi/spi-rockchip-sfc.c +1 -1
@@ -711,7 +711,7 @@ static int rockchip_sfc_probe(struct platform_device *pdev) } } - ret =devm_spi_register_controller (dev, host); + ret =spi_register_controller (host);if (ret) goto err_register;
---
base-commit: 3f9cd19e764b782706dbaacc69e502099cb014ba
change-id: 20260305-sfc-307708e9dc67
Best regards,
Signature · 1 line
Felix Gu <[email protected]>
Mark Brown
maintainerQuoted 9 lines · Felix Gu
The driver uses
devm_spi_register_controller()for registration, which automatically unregisters the controller via devm cleanup when the device is removed. The manual call tospi_unregister_controller()in theremove()callback can lead to a double-free.And to make sure controller is unregistered before DMA buffer is unmapped, switch to use
spi_register_controller()inprobe().[...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
Thanks!
[1/1] spi: rockchip-sfc: Fix double-free in remove() callback
commit: 111e2863372c322e836e0c896f6dd9cf4ee08c71
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark