Skip to contentSkip to conversation

coverity: fix coverity issues related to confidential guest reset

PATCH Superseded Ani Sinha 2 participants 2 messages Mar 11 KVM

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Ani Sinha

author
#0 lore raw

PATCH 1/1 coverity: fix coverity issues related to confidential guest reset

Fix issues reported by Peter.

---
 system/runstate.c | 5 ++++-
 target/i386/sev.c | 4 ----
 2 files changed, 4 insertions(+), 5 deletions(-)
system/runstate.c +4 -1
index eca722b43c..ca6730d111 100644
@@ -512,9 +512,12 @@ void qemu_system_reset(ShutdownCause reason)
     ResetType type;
     AccelClass *ac = ACCEL_GET_CLASS(current_accel());
     bool guest_state_rebuilt = false;
+    bool force_vmfd_change = false;
     int ret;
 
     mc = current_machine ? MACHINE_GET_CLASS(current_machine) : NULL;
+    force_vmfd_change = current_machine ?
+        current_machine->new_accel_vmfd_on_reset : false;
 
     cpu_synchronize_all_states();
 
@@ -528,7 +531,7 @@ void qemu_system_reset(ShutdownCause reason)
 
     if ((reason == SHUTDOWN_CAUSE_GUEST_RESET ||
          reason == SHUTDOWN_CAUSE_HOST_QMP_SYSTEM_RESET) &&
-        (current_machine->new_accel_vmfd_on_reset || !cpus_are_resettable())) {
+        (force_vmfd_change || !cpus_are_resettable())) {
         if (ac->rebuild_guest) {
             ret = ac->rebuild_guest(current_machine);
             if (ret < 0) {
target/i386/sev.c +0 -4
index cddffe0da8..9dde972c11 100644
@@ -2011,10 +2011,6 @@ static void sev_handle_reset(Object *obj, ResetType type)
     SevCommonState *sev_common = SEV_COMMON(MACHINE(qdev_get_machine())->cgs);
     SevCommonStateClass *klass = SEV_COMMON_GET_CLASS(sev_common);
 
-    if (!sev_common) {
-        return;
-    }
-
     if (!runstate_is_running()) {
         return;
     }
Signature · 1 line
2.42.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Ani Sinha

Date: Wed, 11 Mar 2026 09:16:53 +0530
From: Ani Sinha <[email protected]>
Subject: [PATCH] coverity: fix coverity issues related to confidential
guest reset
X-Mailer: git-send-email 2.42.0

Quoted 8 lines

Fix issues reported by Peter.

---
 system/runstate.c | 5 ++++-
 target/i386/sev.c | 4 ----
 2 files changed, 4 insertions(+), 5 deletions(-)

It's better to add Fixes tag or links.

Otherwise,