Skip to contentSkip to conversation

staging: media: atomisp: split long line in sh_css_sp.c

PATCH In review Muhammad Shadab Khan 2 participants 2 messages Mar 11

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: media: atomisp: split long line in sh_css_sp.c

Split a long line exceeding 100 characters to comply with Linux kernel coding style guidelines.

---
 drivers/staging/media/atomisp/pci/sh_css_sp.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/staging/media/atomisp/pci/sh_css_sp.c +3 -1
index 6da151e7a873..c38a7c69728b 100644
@@ -983,7 +983,9 @@ sh_css_sp_init_stage(struct ia_css_binary *binary,
 						    IA_CSS_BUFFER_TYPE_DIS_STATISTICS);
 	}
 	ia_css_query_internal_queue_id(IA_CSS_BUFFER_TYPE_METADATA, thread_id, &queue_id);
-	sh_css_copy_buffer_attr_to_spbuffer(&sh_css_sp_stage.frames.metadata_buf, queue_id, mmgr_EXCEPTION, IA_CSS_BUFFER_TYPE_METADATA);
+	sh_css_copy_buffer_attr_to_spbuffer(&sh_css_sp_stage.frames.metadata_buf, queue_id,
+					    mmgr_EXCEPTION,
+					    IA_CSS_BUFFER_TYPE_METADATA);
 	if (err)
 		return err;
 
Signature · 1 line
2.43.0
reviewer
#1 lore raw

Hi Huhammad,

Quoted 13 lines · Muhammad Shadab Khan

Split a long line exceeding 100 characters to comply with Linux kernel coding style guidelines.

---
 drivers/staging/media/atomisp/pci/sh_css_sp.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/staging/media/atomisp/pci/sh_css_sp.c +0 -0
index 6da151e7a873..c38a7c69728b 100644

drivers/staging/media/atomisp/pci/sh_css_sp.c sh_css_sp_init_stage(struct ia_css_binary *binary, · line 986

Quoted 5 lines
drivers/staging/media/atomisp/pci/sh_css_sp.c +1 -1
@@ -983,7 +983,9 @@ sh_css_sp_init_stage(struct ia_css_binary *binary,
 						    IA_CSS_BUFFER_TYPE_DIS_STATISTICS);
 	}
 	ia_css_query_internal_queue_id(IA_CSS_BUFFER_TYPE_METADATA, thread_id, &queue_id);
-	sh_css_copy_buffer_attr_to_spbuffer(&sh_css_sp_stage.frames.metadata_buf, queue_id, mmgr_EXCEPTION, IA_CSS_BUFFER_TYPE_METADATA);
+	sh_css_copy_buffer_attr_to_spbuffer(&sh_css_sp_stage.frames.metadata_buf, queue_id,

That limit is actually 80... so you could wrap at a different location.

Are there no other such cases in the driver?

Quoted 5 lines
drivers/staging/media/atomisp/pci/sh_css_sp.c +2 -0
+					    mmgr_EXCEPTION,
+					    IA_CSS_BUFFER_TYPE_METADATA);
 	if (err)
 		return err;
 
Signature · 3 lines
Regards,

Sakari Ailus