Skip to contentSkip to conversation

staging: atomisp: fix brace style and trailing whitespace in isp_param.c

PATCH In review Kalyani Patra 3 participants 6 messages Mar 11 – Mar 17 1 message not in the archive

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 staging: atomisp: fix brace style and trailing whitespace in isp_param.c

Fix checkpatch errors related to brace placement and remove trailing whitespace in isp_param.c.

Reported by scripts/checkpatch.pl.

---
 .../atomisp/pci/runtime/isp_param/src/isp_param.c    | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
drivers/staging/media/atomisp/pci/runtime/isp_param/src/isp_param.c +6 -6
index 251dd75a7613..f21797598cd5 100644
@@ -97,13 +97,13 @@ int
 ia_css_isp_param_allocate_isp_parameters(
     struct ia_css_isp_param_host_segments *mem_params,
     struct ia_css_isp_param_css_segments *css_params,
-    const struct ia_css_isp_param_isp_segments *mem_initializers) {
+    const struct ia_css_isp_param_isp_segments *mem_initializers)
+{
 	int err = 0;
 	unsigned int mem, pclass;
 
 	pclass = IA_CSS_PARAM_CLASS_PARAM;
-	for (mem = 0; mem < IA_CSS_NUM_MEMORIES; mem++)
-	{
+	for (mem = 0; mem < IA_CSS_NUM_MEMORIES; mem++) {
 		for (pclass = 0; pclass < IA_CSS_NUM_PARAM_CLASSES; pclass++) {
 			u32 size = 0;
 
@@ -175,11 +175,11 @@ int
 ia_css_isp_param_copy_isp_mem_if_to_ddr(
     struct ia_css_isp_param_css_segments *ddr,
     const struct ia_css_isp_param_host_segments *host,
-    enum ia_css_param_class pclass) {
+    enum ia_css_param_class pclass)
+{
 	unsigned int mem;
 
-	for (mem = 0; mem < N_IA_CSS_ISP_MEMORIES; mem++)
-	{
+	for (mem = 0; mem < N_IA_CSS_ISP_MEMORIES; mem++) {
 		size_t       size	  = host->params[pclass][mem].size;
 		ia_css_ptr ddr_mem_ptr  = ddr->params[pclass][mem].address;
 		char	    *host_mem_ptr = host->params[pclass][mem].address;
Signature · 1 line
2.43.0
Reviewed-by on v2 1/1
#1 lore raw
Quoted 7 lines · Kalyani Patra

Fix checkpatch errors related to brace placement and remove trailing whitespace in isp_param.c.

Reported by scripts/checkpatch.pl.

---

Please keep in mint that when submitting a patch you need to start with version 1, saying [PATCH]... it is enough for people to understand is v1.

Now, even if we did an internal review until v2 community doesn't know that and you need

to reset your counting.

Otherwise, people will ask you where is v1 (plus where is the changelog for v1->v2).

As now this is clear, I hope community can ignore [PATCH v2] in the subject as git tools will do

when applying the patch.

With that,

#2 lore raw

Hi Daniel,
Thank you for the review and for the clarification about patch versioning. I will keep that in mind for future submissions.

Thanks,
Kalyani

Quoted 28 lines · Daniel Baluta
Quoted 7 lines · Kalyani Patra

Fix checkpatch errors related to brace placement and remove trailing whitespace in isp_param.c.

Reported by scripts/checkpatch.pl.

---

Please keep in mint that when submitting a patch you need to start with version 1, saying [PATCH]... it is enough for people to understand is v1.

Now, even if we did an internal review until v2 community doesn't know that and you need

to reset your counting.

Otherwise, people will ask you where is v1 (plus where is the changelog for v1->v2).

As now this is clear, I hope community can ignore [PATCH v2] in the subject as git tools will do

when applying the patch.

With that,

reviewer
#3 lore raw

Hi Kalyani,

Quoted 3 lines · Kalyani patra

Hi Daniel,
Thank you for the review and for the clarification about patch versioning. I will keep that in mind for future submissions.

Applied this one... please use "media: staging: atomisp: " prefix in the future. It's usually a good idea to check what others have used in git log.

Signature · 3 lines
Regards,

Sakari Ailus

A message that is not in the archive (sent off-list or not yet received): CACjYBvir9vnXqH4HVXKqMs-pmqTWjs3wA92WH9_KUpwSr3KD8Q@mail.gmail.com

reviewer
#5 lore raw

Hi Kalyani,

Quoted 3 lines · Kalyani patra

Hi Sakari,
Noted. I’ll keep both of that in kind going forward. Thanks!

I first applied the patch to a different branch and it seems the issue the patch addressed was already fixed by another patch in the atomisp branch.

Thanks.

Signature · 3 lines
Kind regards,

Sakari Ailus
#6 lore raw
Quoted 3 lines · Sakari Ailus

I first applied the patch to a different branch and it seems the issue the patch addressed was already fixed by another patch in the atomisp branch.

Understood, thank you for checking.

Signature · 3 lines
Kalyani Patra

On Tue, Mar 17, 2026 at 3:03 PM Sakari Ailus
Quoted 17 lines · <[email protected]> wrote:

Hi Kalyani,

Quoted 3 lines · Kalyani patra

Hi Sakari,
Noted. I’ll keep both of that in kind going forward. Thanks!

I first applied the patch to a different branch and it seems the issue the patch addressed was already fixed by another patch in the atomisp branch.

Thanks.

--
Kind regards,

Sakari Ailus