Skip to contentSkip to conversation

btrfs: tree-checker: fix misleading root drop_level error message

PATCH In review ZhengYuan Huang 2 participants 2 messages Mar 12 Btrfs file system

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 btrfs: tree-checker: fix misleading root drop_level error message

Fix tree-checker error message to report "invalid root drop_level" instead of the misleading "invalid root level".

Fixes 259ee7754b67 ("btrfs: tree-checker: Add ROOT_ITEM check")

---
[CHANGELOG]
v2:
- Split out the error message fix from the previous patch, as requested during review.

---
 fs/btrfs/tree-checker.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/btrfs/tree-checker.c +1 -1
index 1e052c3303b3..a8c568b10432 100644
@@ -1256,7 +1256,7 @@ static int check_root_item(struct extent_buffer *leaf, struct btrfs_key *key,
 	}
 	if (unlikely(btrfs_root_drop_level(&ri) >= BTRFS_MAX_LEVEL)) {
 		generic_err(leaf, slot,
-			    "invalid root level, have %u expect [0, %u]",
+			    "invalid root drop_level, have %u expect [0, %u]",
 			    btrfs_root_drop_level(&ri), BTRFS_MAX_LEVEL - 1);
 		return -EUCLEAN;
 	}
Signature · 1 line
2.43.0
Reviewed-by on v2 1/1
#1 lore raw
Quoted 5 lines · ZhengYuan Huang

Fix tree-checker error message to report "invalid root drop_level" instead of the misleading "invalid root level".

Fixes 259ee7754b67 ("btrfs: tree-checker: Add ROOT_ITEM check")

Thanks,
Qu

Quoted 22 lines

---
[CHANGELOG]
v2:
- Split out the error message fix from the previous patch, as requested during review.

---
  fs/btrfs/tree-checker.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
fs/btrfs/tree-checker.c +1 -1
index 1e052c3303b3..a8c568b10432 100644
@@ -1256,7 +1256,7 @@ static int check_root_item(struct extent_buffer *leaf, struct btrfs_key *key,
  	}
  	if (unlikely(btrfs_root_drop_level(&ri) >= BTRFS_MAX_LEVEL)) {
  		generic_err(leaf, slot,
-			    "invalid root level, have %u expect [0, %u]",
+			    "invalid root drop_level, have %u expect [0, %u]",
  			    btrfs_root_drop_level(&ri), BTRFS_MAX_LEVEL - 1);
  		return -EUCLEAN;
  	}