staging: rtl8723bs: Remove dead code
PATCH 1/1 staging: rtl8723bs: Remove dead code
Clean up the dm_odm_t structure by removing commented-out members and related legacy comments.
Signed-off-by Bera Yüzlü <[email protected]>
--- drivers/staging/rtl8723bs/hal/odm.h | 33 ----------------------------- 1 file changed, 33 deletions(-)
drivers/staging/rtl8723bs/hal/odm.h +0 -33
@@ -650,10 +650,6 @@ struct ant_detected_info {/* 2011/09/22 MH Copy from SD4 defined structure. We use to support PHY DM integration. */ /* */ struct dm_odm_t {/* DM_Out_Source_Dynamic_Mechanism_Structure */ -/* struct timer_list FastAntTrainingTimer; */ -/* */ -/* Add for different team use temporarily */ -/* */ struct adapter *Adapter;/* For CE/NIC team */ /* WHen you use Adapter or priv pointer, you must make sure the pointer is ready. */ bool odm_ready;
@@ -673,17 +669,6 @@ struct dm_odm_t { /* DM_Out_Source_Dynamic_Mechanism_Structure */u8 ControlChannel;/* ODM HANDLE, DRIVER NEEDS NOT TO HOOK------ */ -/* REMOVED COMMON INFO---------- */ -/* u8 PseudoMacPhyMode; */ -/* bool *BTCoexist; */ -/* bool PseudoBtCoexist; */ -/* u8 OPMode; */ -/* bool bAPMode; */ -/* bool bClientMode; */ -/* bool bAdHocMode; */ -/* bool bSlaveOfDMSP; */ -/* REMOVED COMMON INFO---------- */ -/* 1 COMMON INFORMATION */ /* */
@@ -871,13 +856,6 @@ struct dm_odm_t { /* DM_Out_Source_Dynamic_Mechanism_Structure */struct odm_mac_status_info *pMacInfo;/* MAC_INFO_88E MacInfo; */ -/* Different Team independent structure?? */ - -/* */ -/* TX_RTP_CMN TX_retrpo; */ -/* TX_RTP_88E TX_retrpo; */ -/* TX_RTP_8195 TX_retrpo; */ -/* */ /* ODM Structure */ /* */
@@ -901,17 +879,6 @@ struct dm_odm_t { /* DM_Out_Source_Dynamic_Mechanism_Structure *//* ================================================== */ /* */ -/* common */ -/* u8 DM_Type; */ -/* u8 PSD_Report_RXHP[80]; Add By Gary */ -/* u8 PSD_func_flag; Add By Gary */ -/* for DIG */ -/* u8 bDMInitialGainEnable; */ -/* u8 binitialized; for dm_initial_gain_Multi_STA use. */ -/* for Antenna diversity */ -/* u8 AntDivCfg; 0:OFF , 1:ON, 2:by efuse */ -/* PSTA_INFO_T RSSI_target; */ -bool *pbDriverStopped;bool *pbDriverIsGoingToPnpSetPowerSleep;bool *pinit_adpt_in_progress;
Signature · 1 line
2.43.0
Quoted 5 lines · Bera Yüzlü
Clean up the
dm_odm_tstructure by removing commented-out members and related legacy comments.Signed-off-by Bera Yüzlü <[email protected]>---
LGTM.
Reviewed-by Ethan Tidmore <[email protected]>
Thanks,
ET
Greg KH
maintainerQuoted 56 lines · Bera Yüzlü
Clean up the
dm_odm_tstructure by removing commented-out members and related legacy comments.Signed-off-by Bera Yüzlü <[email protected]>--- drivers/staging/rtl8723bs/hal/odm.h | 33 ----------------------------- 1 file changed, 33 deletions(-)drivers/staging/rtl8723bs/hal/odm.h +0
-22@@ -650,10 +650,6 @@ struct ant_detected_info {/* 2011/09/22 MH Copy from SD4 defined structure. We use to support PHY DM integration. */ /* */ struct dm_odm_t {/* DM_Out_Source_Dynamic_Mechanism_Structure */ -/* struct timer_list FastAntTrainingTimer; */ -/* */ -/* Add for different team use temporarily */ -/* */ struct adapter *Adapter;/* For CE/NIC team */ /* WHen you use Adapter or priv pointer, you must make sure the pointer is ready. */ bool odm_ready;@@ -673,17 +669,6 @@ struct dm_odm_t { /* DM_Out_Source_Dynamic_Mechanism_Structure */u8 ControlChannel;/* ODM HANDLE, DRIVER NEEDS NOT TO HOOK------ */ -/* REMOVED COMMON INFO---------- */ -/* u8 PseudoMacPhyMode; */ -/* bool *BTCoexist; */ -/* bool PseudoBtCoexist; */ -/* u8 OPMode; */ -/* bool bAPMode; */ -/* bool bClientMode; */ -/* bool bAdHocMode; */ -/* bool bSlaveOfDMSP; */ -/* REMOVED COMMON INFO---------- */ -/* 1 COMMON INFORMATION */ /* */ @@ -871,13 +856,6 @@ struct dm_odm_t { /* DM_Out_Source_Dynamic_Mechanism_Structure */struct odm_mac_status_info *pMacInfo;/* MAC_INFO_88E MacInfo; */ -/* Different Team independent structure?? */ - -/* */ -/* TX_RTP_CMN TX_retrpo; */ -/* TX_RTP_88E TX_retrpo; */ -/* TX_RTP_8195 TX_retrpo; */ -/* */ /* ODM Structure */ /* */
drivers/staging/rtl8723bs/hal/odm.h struct dm_odm_t { /* DM_Out_Source_Dynamic_Mechanism_Structure */ · line 904
Quoted 4 lines
drivers/staging/rtl8723bs/hal/odm.h +0
-1@@ -901,17 +879,6 @@ struct dm_odm_t { /* DM_Out_Source_Dynamic_Mechanism_Structure *//* ================================================== */ /* */ -/* common */
This line should not have been removed, right?
thanks,
greg k-h