Skip to contentSkip to conversation

platform/x86/intel: Add ACPI PMT discovery support and enable NVL PMC telemetry

PATCH In review David E. Box 4 participants 39 messages Mar 13 – Mar 17

Subsystems (8)
lore
Share & tools
lore

David E. Box

author maintainer
#0 lore raw

cover platform/x86/intel: Add ACPI PMT discovery support and enable NVL PMC telemetry

This series adds ACPI-based PMT discovery support and wires it into the Intel PMC telemetry stack for Nova Lake S.

Today, PMT discovery flow is primarily PCI-oriented. Some platforms expose PMT discovery via ACPI _DSD, and PMC telemetry needs to consume that path for both standalone and companion-device cases. This series addresses that in three logical steps:

1. Prepare intel_vsec for ACPI-backed discovery
2. Refactor PMT class handling so discovery source is abstracted (PCI or ACPI)
3. Add/enable PMC consumers using ACPI discovery, including NVL SSRAM support

Patches 1–6 were previously posted here:
https://lore.kernel.org/all/[email protected]/

Series layout

01-06: intel_vsec cleanup/generalization for ACPI-capable discovery
plumbing. Previous changelog up to V7 included. Major patches:
Patch 6 - adds ACPI support in VSEC driver

07-12: PMT class refactor and ACPI discovery-source support
Major patches:
Patch 12 - adds ACPI support in PMT driver

13-22: PMC driver integration
Major patches:
Patch 14 - adds new ACPI platform driver Patch 20 - adds ACPI discovery support in ssram driver Patch 22 - adds NVL IDs for SSRAM discovery

David E. Box (20):
platform/x86/intel/vsec: Refactor base_addr handling platform/x86/intel/vsec: Make driver_data info const platform/x86/intel/vsec: Decouple add/link helpers from PCI platform/x86/intel/vsec: Switch exported helpers from pci_dev to
device
platform/x86/intel/vsec: Return real error codes from registration
path
platform/x86/intel/vsec: Plumb ACPI PMT discovery tables through vsec platform/x86/intel/pmt: Add pre/post decode hooks around header
parsing
platform/x86/intel/pmt/crashlog: Split init into pre-decode platform/x86/intel/pmt/telemetry: Move overlap check to post-decode
hook
platform/x86/intel/pmt: Move header decode into common helper platform/x86/intel/pmt: Pass discovery index instead of resource platform/x86/intel/pmt: Unify header fetch and add ACPI source platform/x86/intel/pmc: Add PMC SSRAM Kconfig description platform/x86/intel/pmc: Add ACPI PWRM telemetry driver for Nova Lake S platform/x86/intel/pmc/ssram: Rename probe and PCI ID table for
consistency
platform/x86/intel/pmc/ssram: Refactor DEVID/PWRMBASE extraction into
helper
platform/x86/intel/pmc/ssram: Add PCI platform data platform/x86/intel/pmc/ssram: Add ACPI discovery scaffolding platform/x86/intel/pmc/ssram: Make PMT registration optional platform/x86/intel/pmc: Add NVL PCI IDs for SSRAM telemetry discovery

Xi Pardee (2):
platform/x86/intel/pmc/ssram: Use fixed-size static pmc array platform/x86/intel/pmc/ssram: Refactor memory barrier for reentrant
probe

 drivers/gpu/drm/xe/xe_debugfs.c               |   2 +-
 drivers/gpu/drm/xe/xe_hwmon.c                 |   2 +-
 drivers/gpu/drm/xe/xe_vsec.c                  |   7 +-
 drivers/gpu/drm/xe/xe_vsec.h                  |   4 +-
 drivers/platform/x86/intel/pmc/Kconfig        |  25 ++
 drivers/platform/x86/intel/pmc/Makefile       |   2 +
 drivers/platform/x86/intel/pmc/core.c         |   4 +-
 drivers/platform/x86/intel/pmc/core.h         |  17 ++
 .../platform/x86/intel/pmc/pwrm_telemetry.c   | 227 ++++++++++++++++
 .../platform/x86/intel/pmc/ssram_telemetry.c  | 254 ++++++++++++++----
 drivers/platform/x86/intel/pmt/class.c        | 170 ++++++++++--
 drivers/platform/x86/intel/pmt/class.h        |  25 +-
 drivers/platform/x86/intel/pmt/crashlog.c     |  16 +-
 drivers/platform/x86/intel/pmt/discovery.c    |   4 +-
 drivers/platform/x86/intel/pmt/telemetry.c    |  45 +---
 drivers/platform/x86/intel/pmt/telemetry.h    |  12 +-
 drivers/platform/x86/intel/sdsi.c             |   5 +-
 drivers/platform/x86/intel/vsec.c             | 121 +++++----
 drivers/platform/x86/intel/vsec_tpmi.c        |   8 +-
 include/linux/intel_vsec.h                    |  39 ++-
 20 files changed, 784 insertions(+), 205 deletions(-)
 create mode 100644 drivers/platform/x86/intel/pmc/pwrm_telemetry.c

base-commit: 11439c4635edd669ae435eec308f4ab8a0804808

Signature · 1 line
2.43.0
author maintainer
#1 lore raw

PATCH 1/22 platform/x86/intel/vsec: Refactor base_addr handling

The base_addr field in intel_vsec_platform_info was originally added to support devices that emulate PCI VSEC capabilities in MMIO. Previously, the code would check at registration time whether base_addr was set, falling back to the PCI BAR if not.

Refactor this by making base_addr an explicit function parameter. This clarifies ownership of the value and removes conditional logic from intel_vsec_add_dev(). It also enables making intel_vsec_platform_info const in a later patch, since the function no longer needs to write to info->base_addr.

No functional change intended.

---

Previous change log:
Changes in v7:
- No change

Changes in v6:
- No change

Changes in v5:
- No change

Changes in v4:
- No change

Changes in v3:
- No change

Changes in v2:
- Use pci_resource_start() macro instead of direct pdev->resource array access (suggested by Ilpo)

 drivers/platform/x86/intel/vsec.c | 23 ++++++++++-------------
 1 file changed, 10 insertions(+), 13 deletions(-)
drivers/platform/x86/intel/vsec.c +10 -13
index 5059d320edf8..46966edca03b 100644
@@ -271,14 +271,13 @@ EXPORT_SYMBOL_NS_GPL(intel_vsec_add_aux, "INTEL_VSEC");
 
 static int intel_vsec_add_dev(struct pci_dev *pdev, struct intel_vsec_header *header,
 			      struct intel_vsec_platform_info *info,
-			      unsigned long cap_id)
+			      unsigned long cap_id, u64 base_addr)
 {
 	struct intel_vsec_device __free(kfree) *intel_vsec_dev = NULL;
 	struct resource __free(kfree) *res = NULL;
 	struct resource *tmp;
 	struct device *parent;
 	unsigned long quirks = info->quirks;
-	u64 base_addr;
 	int i;
 
 	if (info->parent)
@@ -310,11 +309,6 @@ static int intel_vsec_add_dev(struct pci_dev *pdev, struct intel_vsec_header *he
 	if (quirks & VSEC_QUIRK_TABLE_SHIFT)
 		header->offset >>= TABLE_OFFSET_SHIFT;
 
-	if (info->base_addr)
-		base_addr = info->base_addr;
-	else
-		base_addr = pdev->resource[header->tbir].start;
-
 	/*
 	 * The DVSEC/VSEC contains the starting offset and count for a block of
 	 * discovery tables. Create a resource array of these tables to the
@@ -412,7 +406,8 @@ static int get_cap_id(u32 header_id, unsigned long *cap_id)
 
 static int intel_vsec_register_device(struct pci_dev *pdev,
 				      struct intel_vsec_header *header,
-				      struct intel_vsec_platform_info *info)
+				      struct intel_vsec_platform_info *info,
+				      u64 base_addr)
 {
 	const struct vsec_feature_dependency *consumer_deps;
 	struct vsec_priv *priv;
@@ -428,7 +423,7 @@ static int intel_vsec_register_device(struct pci_dev *pdev,
 	 * For others using the exported APIs, add the device directly.
 	 */
 	if (!pci_match_id(intel_vsec_pci_ids, pdev))
-		return intel_vsec_add_dev(pdev, header, info, cap_id);
+		return intel_vsec_add_dev(pdev, header, info, cap_id, base_addr);
 
 	priv = pci_get_drvdata(pdev);
 	if (priv->state[cap_id] == STATE_REGISTERED ||
@@ -444,7 +439,7 @@ static int intel_vsec_register_device(struct pci_dev *pdev,
 
 	consumer_deps = get_consumer_dependencies(priv, cap_id);
 	if (!consumer_deps || suppliers_ready(priv, consumer_deps, cap_id)) {
-		ret = intel_vsec_add_dev(pdev, header, info, cap_id);
+		ret = intel_vsec_add_dev(pdev, header, info, cap_id, base_addr);
 		if (ret)
 			priv->state[cap_id] = STATE_SKIP;
 		else
@@ -464,7 +459,7 @@ static bool intel_vsec_walk_header(struct pci_dev *pdev,
 	int ret;
 
 	for ( ; *header; header++) {
-		ret = intel_vsec_register_device(pdev, *header, info);
+		ret = intel_vsec_register_device(pdev, *header, info, info->base_addr);
 		if (!ret)
 			have_devices = true;
 	}
@@ -512,7 +507,8 @@ static bool intel_vsec_walk_dvsec(struct pci_dev *pdev,
 		pci_read_config_dword(pdev, pos + PCI_DVSEC_HEADER2, &hdr);
 		header.id = PCI_DVSEC_HEADER2_ID(hdr);
 
-		ret = intel_vsec_register_device(pdev, &header, info);
+		ret = intel_vsec_register_device(pdev, &header, info,
+						 pci_resource_start(pdev, header.tbir));
 		if (ret)
 			continue;
 
@@ -557,7 +553,8 @@ static bool intel_vsec_walk_vsec(struct pci_dev *pdev,
 		header.tbir = INTEL_DVSEC_TABLE_BAR(table);
 		header.offset = INTEL_DVSEC_TABLE_OFFSET(table);
 
-		ret = intel_vsec_register_device(pdev, &header, info);
+		ret = intel_vsec_register_device(pdev, &header, info,
+						 pci_resource_start(pdev, header.tbir));
 		if (ret)
 			continue;
 
Signature · 1 line
2.43.0
author maintainer
#2 lore raw

PATCH 2/22 platform/x86/intel/vsec: Make driver_data info const

In reply to David E. Box

Treat PCI id->driver_data (intel_vsec_platform_info) as read-only by making vsec_priv->info a const pointer and updating all function signatures to accept const intel_vsec_platform_info *.

This improves const-correctness and clarifies that the platform info data from the driver_data table is not meant to be modified at runtime.

No functional changes intended.

---

Previous changelog:
Changes in v7:
- No change

Changes in v6:
- No change

Changes in v5:
- No change

Changes in v4:
- No change

Changes in v3:
- No change

Changes in v2:
- New patch

 drivers/platform/x86/intel/vsec.c | 20 ++++++++++----------
 include/linux/intel_vsec.h        |  4 ++--
 2 files changed, 12 insertions(+), 12 deletions(-)
drivers/platform/x86/intel/vsec.c +10 -10
index 46966edca03b..e0096be605d9 100644
@@ -42,7 +42,7 @@ enum vsec_device_state {
 };
 
 struct vsec_priv {
-	struct intel_vsec_platform_info *info;
+	const struct intel_vsec_platform_info *info;
 	struct device *suppliers[VSEC_FEATURE_COUNT];
 	struct oobmsm_plat_info plat_info;
 	enum vsec_device_state state[VSEC_FEATURE_COUNT];
@@ -270,7 +270,7 @@ int intel_vsec_add_aux(struct pci_dev *pdev, struct device *parent,
 EXPORT_SYMBOL_NS_GPL(intel_vsec_add_aux, "INTEL_VSEC");
 
 static int intel_vsec_add_dev(struct pci_dev *pdev, struct intel_vsec_header *header,
-			      struct intel_vsec_platform_info *info,
+			      const struct intel_vsec_platform_info *info,
 			      unsigned long cap_id, u64 base_addr)
 {
 	struct intel_vsec_device __free(kfree) *intel_vsec_dev = NULL;
@@ -406,7 +406,7 @@ static int get_cap_id(u32 header_id, unsigned long *cap_id)
 
 static int intel_vsec_register_device(struct pci_dev *pdev,
 				      struct intel_vsec_header *header,
-				      struct intel_vsec_platform_info *info,
+				      const struct intel_vsec_platform_info *info,
 				      u64 base_addr)
 {
 	const struct vsec_feature_dependency *consumer_deps;
@@ -452,7 +452,7 @@ static int intel_vsec_register_device(struct pci_dev *pdev,
 }
 
 static bool intel_vsec_walk_header(struct pci_dev *pdev,
-				   struct intel_vsec_platform_info *info)
+				   const struct intel_vsec_platform_info *info)
 {
 	struct intel_vsec_header **header = info->headers;
 	bool have_devices = false;
@@ -468,7 +468,7 @@ static bool intel_vsec_walk_header(struct pci_dev *pdev,
 }
 
 static bool intel_vsec_walk_dvsec(struct pci_dev *pdev,
-				  struct intel_vsec_platform_info *info)
+				  const struct intel_vsec_platform_info *info)
 {
 	bool have_devices = false;
 	int pos = 0;
@@ -519,7 +519,7 @@ static bool intel_vsec_walk_dvsec(struct pci_dev *pdev,
 }
 
 static bool intel_vsec_walk_vsec(struct pci_dev *pdev,
-				 struct intel_vsec_platform_info *info)
+				 const struct intel_vsec_platform_info *info)
 {
 	bool have_devices = false;
 	int pos = 0;
@@ -565,7 +565,7 @@ static bool intel_vsec_walk_vsec(struct pci_dev *pdev,
 }
 
 int intel_vsec_register(struct pci_dev *pdev,
-			 struct intel_vsec_platform_info *info)
+			const struct intel_vsec_platform_info *info)
 {
 	if (!pdev || !info || !info->headers)
 		return -EINVAL;
@@ -578,7 +578,7 @@ int intel_vsec_register(struct pci_dev *pdev,
 EXPORT_SYMBOL_NS_GPL(intel_vsec_register, "INTEL_VSEC");
 
 static bool intel_vsec_get_features(struct pci_dev *pdev,
-				    struct intel_vsec_platform_info *info)
+				    const struct intel_vsec_platform_info *info)
 {
 	bool found = false;
 
@@ -622,7 +622,7 @@ static void intel_vsec_skip_missing_dependencies(struct pci_dev *pdev)
 
 static int intel_vsec_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
 {
-	struct intel_vsec_platform_info *info;
+	const struct intel_vsec_platform_info *info;
 	struct vsec_priv *priv;
 	int num_caps, ret;
 	int run_once = 0;
@@ -633,7 +633,7 @@ static int intel_vsec_pci_probe(struct pci_dev *pdev, const struct pci_device_id
 		return ret;
 
 	pci_save_state(pdev);
-	info = (struct intel_vsec_platform_info *)id->driver_data;
+	info = (const struct intel_vsec_platform_info *)id->driver_data;
 	if (!info)
 		return -EINVAL;
 
include/linux/intel_vsec.h +2 -2
index 1a0f357c2427..d551174b0049 100644
@@ -200,13 +200,13 @@ static inline struct intel_vsec_device *auxdev_to_ivdev(struct auxiliary_device
 
 #if IS_ENABLED(CONFIG_INTEL_VSEC)
 int intel_vsec_register(struct pci_dev *pdev,
-			 struct intel_vsec_platform_info *info);
+			const struct intel_vsec_platform_info *info);
 int intel_vsec_set_mapping(struct oobmsm_plat_info *plat_info,
 			   struct intel_vsec_device *vsec_dev);
 struct oobmsm_plat_info *intel_vsec_get_mapping(struct pci_dev *pdev);
 #else
 static inline int intel_vsec_register(struct pci_dev *pdev,
-				       struct intel_vsec_platform_info *info)
+				      const struct intel_vsec_platform_info *info)
 {
 	return -ENODEV;
 }
Signature · 1 line
2.43.0
author maintainer
#3 lore raw

PATCH 3/22 platform/x86/intel/vsec: Decouple add/link helpers from PCI

In reply to David E. Box

This refactor prepares for adding ACPI-enumerated PMT endpoints. While intel_vsec is bound to PCI today, some helpers are used by code that will also register PMT endpoints from non-PCI (ACPI) paths. Clean up PCI-specific plumbing where it isn’t strictly required and rely on generic struct device where possible.

---

Previous changelog:
Changes in v7:
- Correct the remaining struct device * argument to intel_vsec_add_aux(). When dropping the unused first argument in v6, the device parameter was inadvertently changed from &vsec_dev->auxdev.dev to the PCI device. Restore the aux device.

Changes in v6:
- No change

Changes in v5:
- No change

Changes in v4:
- No change

Changes in v3:
- No change

Changes in v2:
- No change (previous patch 1)

 drivers/platform/x86/intel/vsec.c      | 13 +++++++++----
 drivers/platform/x86/intel/vsec_tpmi.c |  2 +-
 include/linux/intel_vsec.h             |  2 +-
 3 files changed, 11 insertions(+), 6 deletions(-)
drivers/platform/x86/intel/vsec.c +9 -4
index e0096be605d9..938648b9ef09 100644
@@ -158,18 +158,23 @@ static bool vsec_driver_present(int cap_id)
  */
 static const struct pci_device_id intel_vsec_pci_ids[];
 
-static int intel_vsec_link_devices(struct pci_dev *pdev, struct device *dev,
+static int intel_vsec_link_devices(struct device *parent, struct device *dev,
 				   int consumer_id)
 {
 	const struct vsec_feature_dependency *deps;
 	enum vsec_device_state *state;
 	struct device **suppliers;
 	struct vsec_priv *priv;
+	struct pci_dev *pdev;
 	int supplier_id;
 
 	if (!consumer_id)
 		return 0;
 
+	if (!dev_is_pci(parent))
+		return 0;
+
+	pdev = to_pci_dev(parent);
 	if (!pci_match_id(intel_vsec_pci_ids, pdev))
 		return 0;
 
@@ -204,7 +209,7 @@ static int intel_vsec_link_devices(struct pci_dev *pdev, struct device *dev,
 	return 0;
 }
 
-int intel_vsec_add_aux(struct pci_dev *pdev, struct device *parent,
+int intel_vsec_add_aux(struct device *parent,
 		       struct intel_vsec_device *intel_vsec_dev,
 		       const char *name)
 {
@@ -252,7 +257,7 @@ int intel_vsec_add_aux(struct pci_dev *pdev, struct device *parent,
 	if (ret)
 		goto cleanup_aux;
 
-	ret = intel_vsec_link_devices(pdev, &auxdev->dev, intel_vsec_dev->cap_id);
+	ret = intel_vsec_link_devices(parent, &auxdev->dev, intel_vsec_dev->cap_id);
 	if (ret)
 		goto cleanup_aux;
 
@@ -343,7 +348,7 @@ static int intel_vsec_add_dev(struct pci_dev *pdev, struct intel_vsec_header *he
 	 * Pass the ownership of intel_vsec_dev and resource within it to
 	 * intel_vsec_add_aux()
 	 */
-	return intel_vsec_add_aux(pdev, parent, no_free_ptr(intel_vsec_dev),
+	return intel_vsec_add_aux(parent, no_free_ptr(intel_vsec_dev),
 				  intel_vsec_name(header->id));
 }
 
drivers/platform/x86/intel/vsec_tpmi.c +1 -1
index 98846e88d3d0..2298b6361094 100644
@@ -655,7 +655,7 @@ static int tpmi_create_device(struct intel_tpmi_info *tpmi_info,
 	 * feature_vsec_dev and res memory are also freed as part of
 	 * device deletion.
 	 */
-	return intel_vsec_add_aux(vsec_dev->pcidev, &vsec_dev->auxdev.dev,
+	return intel_vsec_add_aux(&vsec_dev->auxdev.dev,
 				  feature_vsec_dev, feature_id_name);
 }
 
include/linux/intel_vsec.h +1 -1
index d551174b0049..49a746ec0128 100644
@@ -184,7 +184,7 @@ struct pmt_feature_group {
 	struct telemetry_region	regions[];
 };
 
-int intel_vsec_add_aux(struct pci_dev *pdev, struct device *parent,
+int intel_vsec_add_aux(struct device *parent,
 		       struct intel_vsec_device *intel_vsec_dev,
 		       const char *name);
 
Signature · 1 line
2.43.0
author maintainer
#4 lore raw

PATCH 4/22 platform/x86/intel/vsec: Switch exported helpers from pci_dev to device

In reply to David E. Box

Preparatory refactor for ACPI-enumerated PMT endpoints. Several exported PMT/VSEC interfaces and structs carried struct pci_dev * even though callers only need a generic struct device. Move those to struct device * so the same APIs work for PCI and ACPI parents.

---

Previous changelog:
Changes in v7:
- Drop the change in this patch that converted the intel_vsec_add_aux()

    device argument to vsec_dev->dev (PCI device). Patch 3 fixes a prior
    regression where the argument was mistakenly changed from the auxdev
    device to the PCI device. Keep the auxdev (&vsec_dev->auxdev.dev) as
    intended.

Changes in v6:
- No change

Changes in v5:
- xe_vsec.h: Remove forward declaration for pci_dev and add for device

Changes in v4:
- No change

Changes in v3:
- No change

Changes in v2:
- Add forward declarations for struct device in class.h, telemetry.h
- Restore struct pci_dev forward declaration in intel_vsec.h that was removed
- Remove base_addr parameter changes (moved to separate patch)
- Remove erroneous hunk in intel_vsec_pci_probe()
(review comments by Ilpo Järvinen)

 drivers/gpu/drm/xe/xe_debugfs.c               |  2 +-
 drivers/gpu/drm/xe/xe_hwmon.c                 |  2 +-
 drivers/gpu/drm/xe/xe_vsec.c                  |  7 ++-
 drivers/gpu/drm/xe/xe_vsec.h                  |  4 +-
 drivers/platform/x86/intel/pmc/core.c         |  4 +-
 .../platform/x86/intel/pmc/ssram_telemetry.c  |  2 +-
 drivers/platform/x86/intel/pmt/class.c        |  8 ++--
 drivers/platform/x86/intel/pmt/class.h        |  5 ++-
 drivers/platform/x86/intel/pmt/discovery.c    |  4 +-
 drivers/platform/x86/intel/pmt/telemetry.c    | 13 +++---
 drivers/platform/x86/intel/pmt/telemetry.h    | 12 ++---
 drivers/platform/x86/intel/sdsi.c             |  5 ++-
 drivers/platform/x86/intel/vsec.c             | 44 +++++++++++--------
 drivers/platform/x86/intel/vsec_tpmi.c        |  6 +--
 include/linux/intel_vsec.h                    | 13 +++---
 15 files changed, 71 insertions(+), 60 deletions(-)
drivers/gpu/drm/xe/xe_debugfs.c +1 -1
index 844cfafe1ec7..ad2d8f179eb6 100644
@@ -45,7 +45,7 @@ static void read_residency_counter(struct xe_device *xe, struct xe_mmio *mmio,
 	u64 residency = 0;
 	int ret;
 
-	ret = xe_pmt_telem_read(to_pci_dev(xe->drm.dev),
+	ret = xe_pmt_telem_read(xe->drm.dev,
 				xe_mmio_read32(mmio, PUNIT_TELEMETRY_GUID),
 				&residency, offset, sizeof(residency));
 	if (ret != sizeof(residency)) {
drivers/gpu/drm/xe/xe_hwmon.c +1 -1
index 0fd4d4f1014a..92e423a339f1 100644
@@ -506,7 +506,7 @@ xe_hwmon_energy_get(struct xe_hwmon *hwmon, int channel, long *energy)
 	if (hwmon->xe->info.platform == XE_BATTLEMAGE) {
 		u64 pmt_val;
 
-		ret = xe_pmt_telem_read(to_pci_dev(hwmon->xe->drm.dev),
+		ret = xe_pmt_telem_read(hwmon->xe->drm.dev,
 					xe_mmio_read32(mmio, PUNIT_TELEMETRY_GUID),
 					&pmt_val, BMG_ENERGY_STATUS_PMT_OFFSET,	sizeof(pmt_val));
 		if (ret != sizeof(pmt_val)) {
drivers/gpu/drm/xe/xe_vsec.c +3 -4
index 4ebb4dbe1c9b..a9baf0bfe572 100644
@@ -140,10 +140,10 @@ static int xe_guid_decode(u32 guid, int *index, u32 *offset)
 	return 0;
 }
 
-int xe_pmt_telem_read(struct pci_dev *pdev, u32 guid, u64 *data, loff_t user_offset,
+int xe_pmt_telem_read(struct device *dev, u32 guid, u64 *data, loff_t user_offset,
 		      u32 count)
 {
-	struct xe_device *xe = pdev_to_xe_device(pdev);
+	struct xe_device *xe = kdev_to_xe_device(dev);
 	void __iomem *telem_addr = xe->mmio.regs + BMG_TELEMETRY_OFFSET;
 	u32 mem_region;
 	u32 offset;
@@ -198,7 +198,6 @@ void xe_vsec_init(struct xe_device *xe)
 {
 	struct intel_vsec_platform_info *info;
 	struct device *dev = xe->drm.dev;
-	struct pci_dev *pdev = to_pci_dev(dev);
 	enum xe_vsec platform;
 
 	platform = get_platform_info(xe);
@@ -221,6 +220,6 @@ void xe_vsec_init(struct xe_device *xe)
 	 * Register a VSEC. Cleanup is handled using device managed
 	 * resources.
 	 */
-	intel_vsec_register(pdev, info);
+	intel_vsec_register(dev, info);
 }
 MODULE_IMPORT_NS("INTEL_VSEC");
drivers/gpu/drm/xe/xe_vsec.h +2 -2
index dabfb4e02d70..a25b4e6e681b 100644
@@ -6,10 +6,10 @@
 
 #include <linux/types.h>
 
-struct pci_dev;
+struct device;
 struct xe_device;
 
 void xe_vsec_init(struct xe_device *xe);
-int xe_pmt_telem_read(struct pci_dev *pdev, u32 guid, u64 *data, loff_t user_offset, u32 count);
+int xe_pmt_telem_read(struct device *dev, u32 guid, u64 *data, loff_t user_offset, u32 count);
 
 #endif
drivers/platform/x86/intel/pmc/core.c +2 -2
index 02b303418d18..d91e1ab842d6 100644
@@ -1315,7 +1315,7 @@ static struct telem_endpoint *pmc_core_register_endpoint(struct pci_dev *pcidev,
 	unsigned int i;
 
 	for (i = 0; guids[i]; i++) {
-		ep = pmt_telem_find_and_register_endpoint(pcidev, guids[i], 0);
+		ep = pmt_telem_find_and_register_endpoint(&pcidev->dev, guids[i], 0);
 		if (!IS_ERR(ep))
 			return ep;
 	}
@@ -1600,7 +1600,7 @@ static int pmc_core_get_telem_info(struct pmc_dev *pmcdev, struct pmc_dev_info *
 		if (!pmc->map->lpm_req_guid)
 			return -ENXIO;
 
-		ep = pmt_telem_find_and_register_endpoint(pcidev, pmc->map->lpm_req_guid, 0);
+		ep = pmt_telem_find_and_register_endpoint(&pcidev->dev, pmc->map->lpm_req_guid, 0);
 		if (IS_ERR(ep)) {
 			dev_dbg(&pmcdev->pdev->dev, "couldn't get telem endpoint %pe", ep);
 			return -EPROBE_DEFER;
drivers/platform/x86/intel/pmc/ssram_telemetry.c +1 -1
index 03fad9331fc0..6f6e83e70fc5 100644
@@ -60,7 +60,7 @@ pmc_ssram_telemetry_add_pmt(struct pci_dev *pcidev, u64 ssram_base, void __iomem
 	info.base_addr = ssram_base;
 	info.parent = &pcidev->dev;
 
-	return intel_vsec_register(pcidev, &info);
+	return intel_vsec_register(&pcidev->dev, &info);
 }
 
 static inline u64 get_base(void __iomem *addr, u32 offset)
drivers/platform/x86/intel/pmt/class.c +4 -4
index be3c8d9e4fff..b4c9964df807 100644
@@ -60,11 +60,11 @@ pmt_memcpy64_fromio(void *to, const u64 __iomem *from, size_t count)
 	return count;
 }
 
-int pmt_telem_read_mmio(struct pci_dev *pdev, struct pmt_callbacks *cb, u32 guid, void *buf,
+int pmt_telem_read_mmio(struct device *dev, struct pmt_callbacks *cb, u32 guid, void *buf,
 			void __iomem *addr, loff_t off, u32 count)
 {
 	if (cb && cb->read_telem)
-		return cb->read_telem(pdev, guid, buf, off, count);
+		return cb->read_telem(dev, guid, buf, off, count);
 
 	addr += off;
 
@@ -99,7 +99,7 @@ intel_pmt_read(struct file *filp, struct kobject *kobj,
 	if (count > entry->size - off)
 		count = entry->size - off;
 
-	count = pmt_telem_read_mmio(entry->pcidev, entry->cb, entry->header.guid, buf,
+	count = pmt_telem_read_mmio(entry->ep->dev, entry->cb, entry->header.guid, buf,
 				    entry->base, off, count);
 
 	return count;
@@ -208,7 +208,7 @@ static int intel_pmt_populate_entry(struct intel_pmt_entry *entry,
 				    struct intel_vsec_device *ivdev,
 				    struct resource *disc_res)
 {
-	struct pci_dev *pci_dev = ivdev->pcidev;
+	struct pci_dev *pci_dev = to_pci_dev(ivdev->dev);
 	struct device *dev = &ivdev->auxdev.dev;
 	struct intel_pmt_header *header = &entry->header;
 	u8 bir;
drivers/platform/x86/intel/pmt/class.h +3 -2
index 3c5ad5f52bca..1ae56a5baad2 100644
@@ -19,11 +19,12 @@
 #define GET_BIR(v)		((v) & GENMASK(2, 0))
 #define GET_ADDRESS(v)		((v) & GENMASK(31, 3))
 
+struct device;
 struct pci_dev;
 extern struct class intel_pmt_class;
 
 struct telem_endpoint {
-	struct pci_dev		*pcidev;
+	struct device		*dev;
 	struct telem_header	header;
 	struct pmt_callbacks	*cb;
 	void __iomem		*base;
@@ -65,7 +66,7 @@ struct intel_pmt_namespace {
 				struct intel_pmt_entry *entry);
 };
 
-int pmt_telem_read_mmio(struct pci_dev *pdev, struct pmt_callbacks *cb, u32 guid, void *buf,
+int pmt_telem_read_mmio(struct device *dev, struct pmt_callbacks *cb, u32 guid, void *buf,
 			void __iomem *addr, loff_t off, u32 count);
 bool intel_pmt_is_early_client_hw(struct device *dev);
 int intel_pmt_dev_create(struct intel_pmt_entry *entry,
drivers/platform/x86/intel/pmt/discovery.c +2 -2
index e500aa327d23..c482368bfaae 100644
@@ -542,7 +542,7 @@ static int pmt_features_probe(struct auxiliary_device *auxdev, const struct auxi
 	if (!priv)
 		return -ENOMEM;
 
-	priv->parent = &ivdev->pcidev->dev;
+	priv->parent = ivdev->dev;
 	auxiliary_set_drvdata(auxdev, priv);
 
 	priv->dev = device_create(&intel_pmt_class, &auxdev->dev, MKDEV(0, 0), priv,
@@ -609,7 +609,7 @@ void intel_pmt_get_features(struct intel_pmt_entry *entry)
 
 	mutex_lock(&feature_list_lock);
 	list_for_each_entry(feature, &pmt_feature_list, list) {
-		if (feature->priv->parent != &entry->ep->pcidev->dev)
+		if (feature->priv->parent != entry->ep->dev)
 			continue;
 
 		pmt_get_features(entry, feature);
drivers/platform/x86/intel/pmt/telemetry.c +7 -6
index a52803bfe124..bdc7c24a3678 100644
@@ -112,7 +112,7 @@ static int pmt_telem_add_endpoint(struct intel_vsec_device *ivdev,
 		return -ENOMEM;
 
 	ep = entry->ep;
-	ep->pcidev = ivdev->pcidev;
+	ep->dev = ivdev->dev;
 	ep->header.access_type = entry->header.access_type;
 	ep->header.guid = entry->header.guid;
 	ep->header.base_offset = entry->header.base_offset;
@@ -204,7 +204,7 @@ int pmt_telem_get_endpoint_info(int devid, struct telem_endpoint_info *info)
 		goto unlock;
 	}
 
-	info->pdev = entry->ep->pcidev;
+	info->dev = entry->ep->dev;
 	info->header = entry->ep->header;
 
 unlock:
@@ -218,9 +218,10 @@ static int pmt_copy_region(struct telemetry_region *region,
 			   struct intel_pmt_entry *entry)
 {
 
+	struct pci_dev *pdev = to_pci_dev(entry->ep->dev);
 	struct oobmsm_plat_info *plat_info;
 
-	plat_info = intel_vsec_get_mapping(entry->ep->pcidev);
+	plat_info = intel_vsec_get_mapping(pdev);
 	if (IS_ERR(plat_info))
 		return PTR_ERR(plat_info);
 
@@ -308,7 +309,7 @@ int pmt_telem_read(struct telem_endpoint *ep, u32 id, u64 *data, u32 count)
 	if (offset + NUM_BYTES_QWORD(count) > size)
 		return -EINVAL;
 
-	pmt_telem_read_mmio(ep->pcidev, ep->cb, ep->header.guid, data, ep->base, offset,
+	pmt_telem_read_mmio(ep->dev, ep->cb, ep->header.guid, data, ep->base, offset,
 			    NUM_BYTES_QWORD(count));
 
 	return ep->present ? 0 : -EPIPE;
@@ -335,7 +336,7 @@ int pmt_telem_read32(struct telem_endpoint *ep, u32 id, u32 *data, u32 count)
 EXPORT_SYMBOL_NS_GPL(pmt_telem_read32, "INTEL_PMT_TELEMETRY");
 
 struct telem_endpoint *
-pmt_telem_find_and_register_endpoint(struct pci_dev *pcidev, u32 guid, u16 pos)
+pmt_telem_find_and_register_endpoint(struct device *dev, u32 guid, u16 pos)
 {
 	int devid = 0;
 	int inst = 0;
@@ -348,7 +349,7 @@ pmt_telem_find_and_register_endpoint(struct pci_dev *pcidev, u32 guid, u16 pos)
 		if (err)
 			return ERR_PTR(err);
 
-		if (ep_info.header.guid == guid && ep_info.pdev == pcidev) {
+		if (ep_info.header.guid == guid && ep_info.dev == dev) {
 			if (inst == pos)
 				return pmt_telem_register_endpoint(devid);
 			++inst;
drivers/platform/x86/intel/pmt/telemetry.h +6 -6
index d45af5512b4e..0f88c5e7d90e 100644
@@ -6,8 +6,8 @@
 #define PMT_TELEM_TELEMETRY	0
 #define PMT_TELEM_CRASHLOG	1
 
+struct device;
 struct telem_endpoint;
-struct pci_dev;
 
 struct telem_header {
 	u8	access_type;
@@ -17,7 +17,7 @@ struct telem_header {
 };
 
 struct telem_endpoint_info {
-	struct pci_dev		*pdev;
+	struct device		*dev;
 	struct telem_header	header;
 };
 
@@ -71,8 +71,8 @@ int pmt_telem_get_endpoint_info(int devid, struct telem_endpoint_info *info);
 
 /**
  * pmt_telem_find_and_register_endpoint() - Get a telemetry endpoint from
- * pci_dev device, guid and pos
- * @pdev:   PCI device inside the Intel vsec
+ * device, guid and pos
+ * @dev:    device inside the Intel vsec
  * @guid:   GUID of the telemetry space
  * @pos:    Instance of the guid
  *
@@ -80,8 +80,8 @@ int pmt_telem_get_endpoint_info(int devid, struct telem_endpoint_info *info);
  * * endpoint    - On success returns pointer to the telemetry endpoint
  * * -ENXIO      - telemetry endpoint not found
  */
-struct telem_endpoint *pmt_telem_find_and_register_endpoint(struct pci_dev *pcidev,
-				u32 guid, u16 pos);
+struct telem_endpoint *
+pmt_telem_find_and_register_endpoint(struct device *dev, u32 guid, u16 pos);
 
 /**
  * pmt_telem_read() - Read qwords from counter sram using sample id
drivers/platform/x86/intel/sdsi.c +3 -2
index da75f53d0bcc..d7e37d4ace23 100644
@@ -599,13 +599,14 @@ static int sdsi_get_layout(struct sdsi_priv *priv, struct disc_table *table)
 	return 0;
 }
 
-static int sdsi_map_mbox_registers(struct sdsi_priv *priv, struct pci_dev *parent,
+static int sdsi_map_mbox_registers(struct sdsi_priv *priv, struct device *dev,
 				   struct disc_table *disc_table, struct resource *disc_res)
 {
 	u32 access_type = FIELD_GET(DT_ACCESS_TYPE, disc_table->access_info);
 	u32 size = FIELD_GET(DT_SIZE, disc_table->access_info);
 	u32 tbir = FIELD_GET(DT_TBIR, disc_table->offset);
 	u32 offset = DT_OFFSET(disc_table->offset);
+	struct pci_dev *parent = to_pci_dev(dev);
 	struct resource res = {};
 
 	/* Starting location of SDSi MMIO region based on access type */
@@ -681,7 +682,7 @@ static int sdsi_probe(struct auxiliary_device *auxdev, const struct auxiliary_de
 		return ret;
 
 	/* Map the SDSi mailbox registers */
-	ret = sdsi_map_mbox_registers(priv, intel_cap_dev->pcidev, &disc_table, disc_res);
+	ret = sdsi_map_mbox_registers(priv, intel_cap_dev->dev, &disc_table, disc_res);
 	if (ret)
 		return ret;
 
drivers/platform/x86/intel/vsec.c +26 -18

148 lines not on this page · raw message

drivers/platform/x86/intel/vsec_tpmi.c +3 -3
index 2298b6361094..9dddf4e5863e 100644
@@ -530,7 +530,7 @@ static const struct file_operations mem_write_ops = {
 	.release        = single_release,
 };
 
-#define tpmi_to_dev(info)	(&info->vsec_dev->pcidev->dev)
+#define tpmi_to_dev(info)	((info)->vsec_dev->dev)
 
 static void tpmi_dbgfs_register(struct intel_tpmi_info *tpmi_info)
 {
@@ -642,7 +642,7 @@ static int tpmi_create_device(struct intel_tpmi_info *tpmi_info,
 		tmp->flags = IORESOURCE_MEM;
 	}
 
-	feature_vsec_dev->pcidev = vsec_dev->pcidev;
+	feature_vsec_dev->dev = vsec_dev->dev;
 	feature_vsec_dev->resource = res;
 	feature_vsec_dev->num_resources = pfs->pfs_header.num_entries;
 	feature_vsec_dev->priv_data = &tpmi_info->plat_info;
@@ -742,7 +742,7 @@ static int tpmi_fetch_pfs_header(struct intel_tpmi_pm_feature *pfs, u64 start, i
 static int intel_vsec_tpmi_init(struct auxiliary_device *auxdev)
 {
 	struct intel_vsec_device *vsec_dev = auxdev_to_ivdev(auxdev);
-	struct pci_dev *pci_dev = vsec_dev->pcidev;
+	struct pci_dev *pci_dev = to_pci_dev(vsec_dev->dev);
 	struct intel_tpmi_info *tpmi_info;
 	u64 pfs_start = 0;
 	int ret, i;
include/linux/intel_vsec.h +7 -6
index 49a746ec0128..4eecb2a6bac4 100644
@@ -29,6 +29,7 @@
 #define INTEL_DVSEC_TABLE_OFFSET(x)	((x) & GENMASK(31, 3))
 #define TABLE_OFFSET_SHIFT		3
 
+struct device;
 struct pci_dev;
 struct resource;
 
@@ -82,14 +83,14 @@ enum intel_vsec_quirks {
  * struct pmt_callbacks - Callback infrastructure for PMT devices
  * @read_telem: when specified, called by client driver to access PMT
  * data (instead of direct copy).
- * * pdev:  PCI device reference for the callback's use
+ * * dev:   device reference for the callback's use
  * * guid:  ID of data to acccss
  * * data:  buffer for the data to be copied
  * * off:   offset into the requested buffer
  * * count: size of buffer
  */
 struct pmt_callbacks {
-	int (*read_telem)(struct pci_dev *pdev, u32 guid, u64 *data, loff_t off, u32 count);
+	int (*read_telem)(struct device *dev, u32 guid, u64 *data, loff_t off, u32 count);
 };
 
 struct vsec_feature_dependency {
@@ -122,7 +123,7 @@ struct intel_vsec_platform_info {
 /**
  * struct intel_vsec_device - Auxbus specific device information
  * @auxdev:        auxbus device struct for auxbus access
- * @pcidev:        pci device associated with the device
+ * @dev:           struct device associated with the device
  * @resource:      any resources shared by the parent
  * @ida:           id reference
  * @num_resources: number of resources
@@ -135,7 +136,7 @@ struct intel_vsec_platform_info {
  */
 struct intel_vsec_device {
 	struct auxiliary_device auxdev;
-	struct pci_dev *pcidev;
+	struct device *dev;
 	struct resource *resource;
 	struct ida *ida;
 	int num_resources;
@@ -199,13 +200,13 @@ static inline struct intel_vsec_device *auxdev_to_ivdev(struct auxiliary_device
 }
 
 #if IS_ENABLED(CONFIG_INTEL_VSEC)
-int intel_vsec_register(struct pci_dev *pdev,
+int intel_vsec_register(struct device *dev,
 			const struct intel_vsec_platform_info *info);
 int intel_vsec_set_mapping(struct oobmsm_plat_info *plat_info,
 			   struct intel_vsec_device *vsec_dev);
 struct oobmsm_plat_info *intel_vsec_get_mapping(struct pci_dev *pdev);
 #else
-static inline int intel_vsec_register(struct pci_dev *pdev,
+static inline int intel_vsec_register(struct device *dev,
 				      const struct intel_vsec_platform_info *info)
 {
 	return -ENODEV;
Signature · 1 line
2.43.0
author maintainer
#5 lore raw

PATCH 5/22 platform/x86/intel/vsec: Return real error codes from registration path

In reply to David E. Box

Stop collapsing registration results into booleans. Make intel_vsec_walk_header() return int and propagate the first non-zero error from intel_vsec_register_device(). intel_vsec_register() now returns that error directly and 0 on success.

This preserves success behavior while surfacing meaningful errors instead of hiding them behind a bool/-ENODEV, which makes debugging and probe ordering issues clearer.

---

Previous changelog:
Changes in v7:
- No change

Changes in v6:
- No change

Changes in v5:
- No change

Changes in v4:
- No change

Changes in v3:
- No change

Changes in v2:
- No change (previous patch 3)

 drivers/platform/x86/intel/vsec.c | 16 ++++++----------
 1 file changed, 6 insertions(+), 10 deletions(-)
drivers/platform/x86/intel/vsec.c +6 -10
index a547e4b98245..34b2c19ecff0 100644
@@ -461,20 +461,19 @@ static int intel_vsec_register_device(struct device *dev,
 	return -EAGAIN;
 }
 
-static bool intel_vsec_walk_header(struct device *dev,
-				   const struct intel_vsec_platform_info *info)
+static int intel_vsec_walk_header(struct device *dev,
+				  const struct intel_vsec_platform_info *info)
 {
 	struct intel_vsec_header **header = info->headers;
-	bool have_devices = false;
 	int ret;
 
 	for ( ; *header; header++) {
 		ret = intel_vsec_register_device(dev, *header, info, info->base_addr);
-		if (!ret)
-			have_devices = true;
+		if (ret)
+			return ret;
 	}
 
-	return have_devices;
+	return 0;
 }
 
 static bool intel_vsec_walk_dvsec(struct pci_dev *pdev,
@@ -580,10 +579,7 @@ int intel_vsec_register(struct device *dev,
 	if (!dev || !info || !info->headers)
 		return -EINVAL;
 
-	if (!intel_vsec_walk_header(dev, info))
-		return -ENODEV;
-	else
-		return 0;
+	return intel_vsec_walk_header(dev, info);
 }
 EXPORT_SYMBOL_NS_GPL(intel_vsec_register, "INTEL_VSEC");
 
Signature · 1 line
2.43.0
author maintainer
#6 lore raw

PATCH 6/22 platform/x86/intel/vsec: Plumb ACPI PMT discovery tables through vsec

In reply to David E. Box

Some platforms expose PMT discovery via ACPI instead of PCI BARs. Add a generic discovery source flag and carry ACPI discovery entries alongside the existing PCI resource path so PMT clients can consume either.

Changes:
- Add enum intel_vsec_disc_source { _PCI, _ACPI }.
- Extend intel_vsec_platform_info and intel_vsec_device with source enum and ACPI discovery table pointer/
- When src==ACPI, skip BAR resource setup and copy the ACPI discovery entries into the aux device.

No user-visible behavior change yet; this only wires ACPI data through vsec in preparation for ACPI-enumerated PMT clients.

---

Previous changelog:
Changes in v7:
- No change

Changes in v6:
- Fix checkpatch parens alignment warning

Changes in v5:
- No change

Changes in v4:
- Use check_mul_overflow() instead of array_size() which was incorrectly checking for 0 anyway.

Changes in v3:
- Re-send with all changes intended for v2 which was sent without them being applied.

Changes in v2:
- Improve comment to clarify BAR resource setup doesn't apply to ACPI discovery
- Add missing #include for kmemdup()
- Use array_size() for overflow protection
(review comments by Ilpo Järvinen)

 drivers/platform/x86/intel/vsec.c | 23 +++++++++++++++++++++++
 include/linux/intel_vsec.h        | 20 +++++++++++++++++++-
 2 files changed, 42 insertions(+), 1 deletion(-)
drivers/platform/x86/intel/vsec.c +23 -0
index 34b2c19ecff0..7d5dbc1c1d05 100644
@@ -24,7 +24,9 @@
 #include <linux/intel_vsec.h>
 #include <linux/kernel.h>
 #include <linux/module.h>
+#include <linux/overflow.h>
 #include <linux/pci.h>
+#include <linux/string.h>
 #include <linux/types.h>
 
 #define PMT_XA_START			0
@@ -109,6 +111,7 @@ static void intel_vsec_dev_release(struct device *dev)
 
 	ida_free(intel_vsec_dev->ida, intel_vsec_dev->auxdev.id);
 
+	kfree(intel_vsec_dev->acpi_disc);
 	kfree(intel_vsec_dev->resource);
 	kfree(intel_vsec_dev);
 }
@@ -320,6 +323,13 @@ static int intel_vsec_add_dev(struct device *dev, struct intel_vsec_header *head
 	 * auxiliary device driver.
 	 */
 	for (i = 0, tmp = res; i < header->num_entries; i++, tmp++) {
+		/*
+		 * Skip resource mapping check for ACPI-based discovery
+		 * since those tables are read from _DSD, not MMIO.
+		 */
+		if (info->src == INTEL_VSEC_DISC_ACPI)
+			break;
+
 		tmp->start = base_addr + header->offset + i * (header->entry_size * sizeof(u32));
 		tmp->end = tmp->start + (header->entry_size * sizeof(u32)) - 1;
 		tmp->flags = IORESOURCE_MEM;
@@ -338,6 +348,19 @@ static int intel_vsec_add_dev(struct device *dev, struct intel_vsec_header *head
 	intel_vsec_dev->base_addr = info->base_addr;
 	intel_vsec_dev->priv_data = info->priv_data;
 	intel_vsec_dev->cap_id = cap_id;
+	intel_vsec_dev->src = info->src;
+
+	if (info->src == INTEL_VSEC_DISC_ACPI) {
+		size_t bytes;
+
+		if (check_mul_overflow(intel_vsec_dev->num_resources,
+				       sizeof(*info->acpi_disc), &bytes))
+			return -EOVERFLOW;
+
+		intel_vsec_dev->acpi_disc = kmemdup(info->acpi_disc, bytes, GFP_KERNEL);
+		if (!intel_vsec_dev->acpi_disc)
+			return -ENOMEM;
+	}
 
 	if (header->id == VSEC_ID_SDSI)
 		intel_vsec_dev->ida = &intel_vsec_sdsi_ida;
include/linux/intel_vsec.h +19 -1
index 4eecb2a6bac4..1fe5665a9d02 100644
@@ -33,6 +33,11 @@ struct device;
 struct pci_dev;
 struct resource;
 
+enum intel_vsec_disc_source {
+	INTEL_VSEC_DISC_PCI,	/* PCI, default */
+	INTEL_VSEC_DISC_ACPI,	/* ACPI */
+};
+
 enum intel_vsec_id {
 	VSEC_ID_TELEMETRY	= 2,
 	VSEC_ID_WATCHER		= 3,
@@ -103,6 +108,10 @@ struct vsec_feature_dependency {
  * @parent:    parent device in the auxbus chain
  * @headers:   list of headers to define the PMT client devices to create
  * @deps:      array of feature dependencies
+ * @acpi_disc: ACPI discovery tables, each entry is two QWORDs
+ *             in little-endian format as defined by the PMT ACPI spec.
+ *             Valid only when @provider == INTEL_VSEC_DISC_ACPI.
+ * @src:       source of discovery table data
  * @priv_data: private data, usable by parent devices, currently a callback
  * @caps:      bitmask of PMT capabilities for the given headers
  * @quirks:    bitmask of VSEC device quirks
@@ -113,6 +122,8 @@ struct intel_vsec_platform_info {
 	struct device *parent;
 	struct intel_vsec_header **headers;
 	const struct vsec_feature_dependency *deps;
+	u32 (*acpi_disc)[4];
+	enum intel_vsec_disc_source src;
 	void *priv_data;
 	unsigned long caps;
 	unsigned long quirks;
@@ -124,7 +135,12 @@ struct intel_vsec_platform_info {
  * struct intel_vsec_device - Auxbus specific device information
  * @auxdev:        auxbus device struct for auxbus access
  * @dev:           struct device associated with the device
- * @resource:      any resources shared by the parent
+ * @resource:      PCI discovery resources (BAR windows), one per discovery
+ *                 instance. Valid only when @src == INTEL_VSEC_DISC_PCI
+ * @acpi_disc:     ACPI discovery tables, each entry is two QWORDs
+ *                 in little-endian format as defined by the PMT ACPI spec.
+ *                 Valid only when @src == INTEL_VSEC_DISC_ACPI.
+ * @src:           source of discovery table data
  * @ida:           id reference
  * @num_resources: number of resources
  * @id:            xarray id
@@ -138,6 +154,8 @@ struct intel_vsec_device {
 	struct auxiliary_device auxdev;
 	struct device *dev;
 	struct resource *resource;
+	u32 (*acpi_disc)[4];
+	enum intel_vsec_disc_source src;
 	struct ida *ida;
 	int num_resources;
 	int id; /* xa */
Signature · 1 line
2.43.0
maintainer
#7 lore raw

Re: [PATCH 06/22] platform/x86/intel/vsec: Plumb ACPI PMT discovery tables through vsec

Quoted 11 lines · David E. Box

Some platforms expose PMT discovery via ACPI instead of PCI BARs. Add a generic discovery source flag and carry ACPI discovery entries alongside the existing PCI resource path so PMT clients can consume either.

Changes:
- Add enum intel_vsec_disc_source { _PCI, _ACPI }.
- Extend intel_vsec_platform_info and intel_vsec_device with source enum and ACPI discovery table pointer/
- When src==ACPI, skip BAR resource setup and copy the ACPI discovery entries into the aux device.

Quoted 5 lines

No user-visible behavior change yet; this only wires ACPI data through vsec in preparation for ACPI-enumerated PMT clients.

---

I took patches up to this one to the review-ilpo-next branch as those are basically ready and have seen enough version by now.

Signature · 1 line
 i.
author maintainer
#8 lore raw

PATCH 7/22 platform/x86/intel/pmt: Add pre/post decode hooks around header parsing

In reply to David E. Box

Add optional pre- and post-decode callbacks to the PMT class so namespaces can perform setup and cleanup steps around header parsing.

- Add pmt_pre_decode() and pmt_post_decode() to struct intel_pmt_namespace.
- Update intel_pmt_dev_create() to invoke, in order:
pre → header_decode() → post.
- Keep the existing pmt_header_decode() callback unchanged.

No functional changes. This adds flexibility for upcoming decoders while preserving current behavior.

---
 drivers/platform/x86/intel/pmt/class.c | 12 ++++++++++++
 drivers/platform/x86/intel/pmt/class.h |  4 ++++
 2 files changed, 16 insertions(+)
drivers/platform/x86/intel/pmt/class.c +12 -0
index b4c9964df807..9b315334a69b 100644
@@ -381,10 +381,22 @@ int intel_pmt_dev_create(struct intel_pmt_entry *entry, struct intel_pmt_namespa
 	if (IS_ERR(entry->disc_table))
 		return PTR_ERR(entry->disc_table);
 
+	if (ns->pmt_pre_decode) {
+		ret = ns->pmt_pre_decode(intel_vsec_dev, entry);
+		if (ret)
+			return ret;
+	}
+
 	ret = ns->pmt_header_decode(entry, dev);
 	if (ret)
 		return ret;
 
+	if (ns->pmt_post_decode) {
+		ret = ns->pmt_post_decode(intel_vsec_dev, entry);
+		if (ret)
+			return ret;
+	}
+
 	ret = intel_pmt_populate_entry(entry, intel_vsec_dev, disc_res);
 	if (ret)
 		return ret;
drivers/platform/x86/intel/pmt/class.h +4 -0
index 1ae56a5baad2..ff39014b208c 100644
@@ -62,6 +62,10 @@ struct intel_pmt_namespace {
 	struct xarray *xa;
 	int (*pmt_header_decode)(struct intel_pmt_entry *entry,
 				 struct device *dev);
+	int (*pmt_pre_decode)(struct intel_vsec_device *ivdev,
+			      struct intel_pmt_entry *entry);
+	int (*pmt_post_decode)(struct intel_vsec_device *ivdev,
+			       struct intel_pmt_entry *entry);
 	int (*pmt_add_endpoint)(struct intel_vsec_device *ivdev,
 				struct intel_pmt_entry *entry);
 };
Signature · 1 line
2.43.0
author maintainer
#9 lore raw

PATCH 8/22 platform/x86/intel/pmt/crashlog: Split init into pre-decode

In reply to David E. Box

Refactor crashlog initialization to use the PMT namespace pre-decode hook:

- Add pmt_crashlog_pre_decode() to parse type/version, select the

    crashlog_info, initialize the control mutex, and set entry->attr_grp.

- Simplify pmt_crashlog_header_decode() to only read header fields from the discovery table.
- Wire the namespace with .pmt_pre_decode = pmt_crashlog_pre_decode.

This separates structural initialization from header parsing, aligning crashlog with the PMT class pre/post decode flow.

---
 drivers/platform/x86/intel/pmt/crashlog.c | 19 +++++++++++++------
 1 file changed, 13 insertions(+), 6 deletions(-)
drivers/platform/x86/intel/pmt/crashlog.c +13 -6
index b0393c9c5b4b..f936daf99e4d 100644
@@ -496,11 +496,9 @@ static const struct crashlog_info *select_crashlog_info(u32 type, u32 version)
 	return &crashlog_type1_ver2;
 }
 
-static int pmt_crashlog_header_decode(struct intel_pmt_entry *entry,
-				      struct device *dev)
+static int pmt_crashlog_pre_decode(struct intel_vsec_device *ivdev,
+				   struct intel_pmt_entry *entry)
 {
-	void __iomem *disc_table = entry->disc_table;
-	struct intel_pmt_header *header = &entry->header;
 	struct crashlog_entry *crashlog;
 	u32 version;
 	u32 type;
@@ -513,6 +511,16 @@ static int pmt_crashlog_header_decode(struct intel_pmt_entry *entry,
 	mutex_init(&crashlog->control_mutex);
 
 	crashlog->info = select_crashlog_info(type, version);
+	entry->attr_grp = crashlog->info->attr_grp;
+
+	return 0;
+}
+
+static int pmt_crashlog_header_decode(struct intel_pmt_entry *entry,
+				      struct device *dev)
+{
+	void __iomem *disc_table = entry->disc_table;
+	struct intel_pmt_header *header = &entry->header;
 
 	header->access_type = GET_ACCESS(readl(disc_table));
 	header->guid = readl(disc_table + GUID_OFFSET);
@@ -521,8 +529,6 @@ static int pmt_crashlog_header_decode(struct intel_pmt_entry *entry,
 	/* Size is measured in DWORDS, but accessor returns bytes */
 	header->size = GET_SIZE(readl(disc_table + SIZE_OFFSET));
 
-	entry->attr_grp = crashlog->info->attr_grp;
-
 	return 0;
 }
 
@@ -530,6 +536,7 @@ static DEFINE_XARRAY_ALLOC(crashlog_array);
 static struct intel_pmt_namespace pmt_crashlog_ns = {
 	.name = "crashlog",
 	.xa = &crashlog_array,
+	.pmt_pre_decode = pmt_crashlog_pre_decode,
 	.pmt_header_decode = pmt_crashlog_header_decode,
 };
 
Signature · 1 line
2.43.0
author maintainer
#10 lore raw

PATCH 9/22 platform/x86/intel/pmt/telemetry: Move overlap check to post-decode hook

In reply to David E. Box

Update the telemetry namespace to use the new PMT class pre/post decode interface. The overlap check, which previously occurred during header decode, is now performed in the post-decode hook once header fields are populated. This preserves existing behavior while reusing the same header decode logic across PMT drivers.

---
 drivers/platform/x86/intel/pmt/class.h     |  1 +
 drivers/platform/x86/intel/pmt/telemetry.c | 24 ++++++++++++++--------
 2 files changed, 16 insertions(+), 9 deletions(-)
drivers/platform/x86/intel/pmt/class.h +1 -0
index ff39014b208c..8a0db0ef58c1 100644
@@ -37,6 +37,7 @@ struct intel_pmt_header {
 	u32	size;
 	u32	guid;
 	u8	access_type;
+	u8	telem_type;
 };
 
 struct intel_pmt_entry {
drivers/platform/x86/intel/pmt/telemetry.c +15 -9
index bdc7c24a3678..d22f633638be 100644
@@ -58,14 +58,9 @@ struct pmt_telem_priv {
 	struct intel_pmt_entry		entry[];
 };
 
-static bool pmt_telem_region_overlaps(struct intel_pmt_entry *entry,
-				      struct device *dev)
+static bool pmt_telem_region_overlaps(struct device *dev, u32 guid, u32 type)
 {
-	u32 guid = readl(entry->disc_table + TELEM_GUID_OFFSET);
-
 	if (intel_pmt_is_early_client_hw(dev)) {
-		u32 type = TELEM_TYPE(readl(entry->disc_table));
-
 		if ((type == TELEM_TYPE_PUNIT_FIXED) ||
 		    (guid == TELEM_CLIENT_FIXED_BLOCK_GUID))
 			return true;
@@ -80,15 +75,25 @@ static int pmt_telem_header_decode(struct intel_pmt_entry *entry,
 	void __iomem *disc_table = entry->disc_table;
 	struct intel_pmt_header *header = &entry->header;
 
-	if (pmt_telem_region_overlaps(entry, dev))
-		return 1;
-
 	header->access_type = TELEM_ACCESS(readl(disc_table));
 	header->guid = readl(disc_table + TELEM_GUID_OFFSET);
 	header->base_offset = readl(disc_table + TELEM_BASE_OFFSET);
 
 	/* Size is measured in DWORDS, but accessor returns bytes */
 	header->size = TELEM_SIZE(readl(disc_table));
+	header->telem_type = TELEM_TYPE(readl(entry->disc_table));
+
+	return 0;
+}
+
+static int pmt_telem_post_decode(struct intel_vsec_device *ivdev,
+				 struct intel_pmt_entry *entry)
+{
+	struct intel_pmt_header *header = &entry->header;
+	struct device *dev = &ivdev->auxdev.dev;
+
+	if (pmt_telem_region_overlaps(dev, header->guid, header->telem_type))
+		return 1;
 
 	/*
 	 * Some devices may expose non-functioning entries that are
@@ -131,6 +136,7 @@ static struct intel_pmt_namespace pmt_telem_ns = {
 	.name = "telem",
 	.xa = &telem_array,
 	.pmt_header_decode = pmt_telem_header_decode,
+	.pmt_post_decode = pmt_telem_post_decode,
 	.pmt_add_endpoint = pmt_telem_add_endpoint,
 };
 
Signature · 1 line
2.43.0
author maintainer
#11 lore raw

PATCH 10/22 platform/x86/intel/pmt: Move header decode into common helper

In reply to David E. Box

Unify PMT discovery table parsing by moving header decode logic into the class driver. A new helper, pmt_read_header(), now fills in the standard header fields from the discovery table, replacing the per-namespace pmt_header_decode callbacks in telemetry and crashlog.

This centralizes the discovery table bit-field definitions in class.h, removes duplicate decode code from telemetry and crashlog, and prepares the PMT class for additional discovery sources.

---
 drivers/platform/x86/intel/pmt/class.c     | 38 +++++++++++++++-------
 drivers/platform/x86/intel/pmt/class.h     | 15 +++++++--
 drivers/platform/x86/intel/pmt/crashlog.c  | 17 ----------
 drivers/platform/x86/intel/pmt/telemetry.c | 26 ---------------
 4 files changed, 40 insertions(+), 56 deletions(-)
drivers/platform/x86/intel/pmt/class.c +27 -11
index 9b315334a69b..a4d6ffed2fed 100644
@@ -8,6 +8,7 @@
  * Author: "Alexander Duyck" <[email protected]>
  */
 
+#include <linux/bitfield.h>
 #include <linux/kernel.h>
 #include <linux/log2.h>
 #include <linux/intel_vsec.h>
@@ -368,26 +369,41 @@ static int intel_pmt_dev_register(struct intel_pmt_entry *entry,
 	return ret;
 }
 
-int intel_pmt_dev_create(struct intel_pmt_entry *entry, struct intel_pmt_namespace *ns,
-			 struct intel_vsec_device *intel_vsec_dev, int idx)
+static int pmt_read_header(struct intel_vsec_device *ivdev, int idx,
+			   struct intel_pmt_entry *entry)
 {
-	struct device *dev = &intel_vsec_dev->auxdev.dev;
-	struct resource	*disc_res;
-	int ret;
+	struct intel_pmt_header *header = &entry->header;
+	struct device *dev = &ivdev->auxdev.dev;
+	u64 headers[2];
 
-	disc_res = &intel_vsec_dev->resource[idx];
-
-	entry->disc_table = devm_ioremap_resource(dev, disc_res);
+	entry->disc_table = devm_ioremap_resource(dev, &ivdev->resource[idx]);
 	if (IS_ERR(entry->disc_table))
 		return PTR_ERR(entry->disc_table);
 
+	memcpy_fromio(headers, entry->disc_table, 2 * sizeof(u64));
+
+	header->access_type = FIELD_GET(PMT_ACCESS_TYPE, headers[0]);
+	header->telem_type = FIELD_GET(PMT_TELEM_TYPE, headers[0]);
+	/* Size is measured in DWORDS, but accessor returns bytes */
+	header->size = PMT_GET_SIZE(FIELD_GET(PMT_SIZE, headers[0]));
+	header->guid = FIELD_GET(PMT_GUID32, headers[0]);
+	header->base_offset = FIELD_GET(PMT_BASE_OFFSET, headers[1]);
+
+	return 0;
+}
+
+int intel_pmt_dev_create(struct intel_pmt_entry *entry, struct intel_pmt_namespace *ns,
+			 struct intel_vsec_device *intel_vsec_dev, int idx)
+{
+	int ret;
+
 	if (ns->pmt_pre_decode) {
 		ret = ns->pmt_pre_decode(intel_vsec_dev, entry);
 		if (ret)
 			return ret;
 	}
 
-	ret = ns->pmt_header_decode(entry, dev);
+	ret = pmt_read_header(intel_vsec_dev, idx, entry);
 	if (ret)
 		return ret;
 
@@ -397,11 +413,11 @@ int intel_pmt_dev_create(struct intel_pmt_entry *entry, struct intel_pmt_namespa
 			return ret;
 	}
 
-	ret = intel_pmt_populate_entry(entry, intel_vsec_dev, disc_res);
+	ret = intel_pmt_populate_entry(entry, intel_vsec_dev, &intel_vsec_dev->resource[idx]);
 	if (ret)
 		return ret;
 
-	return intel_pmt_dev_register(entry, ns, dev);
+	return intel_pmt_dev_register(entry, ns, &intel_vsec_dev->auxdev.dev);
 }
 EXPORT_SYMBOL_NS_GPL(intel_pmt_dev_create, "INTEL_PMT");
 
drivers/platform/x86/intel/pmt/class.h +13 -2
index 8a0db0ef58c1..06f90c7ce6b3 100644
@@ -11,6 +11,19 @@
 
 #include "telemetry.h"
 
+/* PMT Discovery Table DWORD 1 */
+#define PMT_ACCESS_TYPE		GENMASK_ULL(3, 0)
+#define PMT_TELEM_TYPE		GENMASK_ULL(7, 4)
+#define PMT_SIZE		GENMASK_ULL(27, 12)
+#define PMT_GUID32		GENMASK_ULL(63, 32)
+
+/* PMT Discovery Table DWORD 2 */
+#define PMT_BASE_OFFSET		GENMASK_ULL(31, 0)
+#define PMT_TELE_ID		GENMASK_ULL(63, 32)
+
+/* Get size bytes from DWORDs */
+#define PMT_GET_SIZE(v)		((v) << 2)
+
 /* PMT access types */
 #define ACCESS_BARID		2
 #define ACCESS_LOCAL		3
@@ -61,8 +74,6 @@ struct intel_pmt_entry {
 struct intel_pmt_namespace {
 	const char *name;
 	struct xarray *xa;
-	int (*pmt_header_decode)(struct intel_pmt_entry *entry,
-				 struct device *dev);
 	int (*pmt_pre_decode)(struct intel_vsec_device *ivdev,
 			      struct intel_pmt_entry *entry);
 	int (*pmt_post_decode)(struct intel_vsec_device *ivdev,
drivers/platform/x86/intel/pmt/crashlog.c +0 -17
index f936daf99e4d..67795e2cb1ed 100644
@@ -516,28 +516,11 @@ static int pmt_crashlog_pre_decode(struct intel_vsec_device *ivdev,
 	return 0;
 }
 
-static int pmt_crashlog_header_decode(struct intel_pmt_entry *entry,
-				      struct device *dev)
-{
-	void __iomem *disc_table = entry->disc_table;
-	struct intel_pmt_header *header = &entry->header;
-
-	header->access_type = GET_ACCESS(readl(disc_table));
-	header->guid = readl(disc_table + GUID_OFFSET);
-	header->base_offset = readl(disc_table + BASE_OFFSET);
-
-	/* Size is measured in DWORDS, but accessor returns bytes */
-	header->size = GET_SIZE(readl(disc_table + SIZE_OFFSET));
-
-	return 0;
-}
-
 static DEFINE_XARRAY_ALLOC(crashlog_array);
 static struct intel_pmt_namespace pmt_crashlog_ns = {
 	.name = "crashlog",
 	.xa = &crashlog_array,
 	.pmt_pre_decode = pmt_crashlog_pre_decode,
-	.pmt_header_decode = pmt_crashlog_header_decode,
 };
 
 /*
drivers/platform/x86/intel/pmt/telemetry.c +0 -26
index d22f633638be..80773e3c3efa 100644
@@ -27,14 +27,6 @@
 
 #include "class.h"
 
-#define TELEM_SIZE_OFFSET	0x0
-#define TELEM_GUID_OFFSET	0x4
-#define TELEM_BASE_OFFSET	0x8
-#define TELEM_ACCESS(v)		((v) & GENMASK(3, 0))
-#define TELEM_TYPE(v)		(((v) & GENMASK(7, 4)) >> 4)
-/* size is in bytes */
-#define TELEM_SIZE(v)		(((v) & GENMASK(27, 12)) >> 10)
-
 /* Used by client hardware to identify a fixed telemetry entry*/
 #define TELEM_CLIENT_FIXED_BLOCK_GUID	0x10000000
 
@@ -69,23 +61,6 @@ static bool pmt_telem_region_overlaps(struct device *dev, u32 guid, u32 type)
 	return false;
 }
 
-static int pmt_telem_header_decode(struct intel_pmt_entry *entry,
-				   struct device *dev)
-{
-	void __iomem *disc_table = entry->disc_table;
-	struct intel_pmt_header *header = &entry->header;
-
-	header->access_type = TELEM_ACCESS(readl(disc_table));
-	header->guid = readl(disc_table + TELEM_GUID_OFFSET);
-	header->base_offset = readl(disc_table + TELEM_BASE_OFFSET);
-
-	/* Size is measured in DWORDS, but accessor returns bytes */
-	header->size = TELEM_SIZE(readl(disc_table));
-	header->telem_type = TELEM_TYPE(readl(entry->disc_table));
-
-	return 0;
-}
-
 static int pmt_telem_post_decode(struct intel_vsec_device *ivdev,
 				 struct intel_pmt_entry *entry)
 {
@@ -135,7 +110,6 @@ static DEFINE_XARRAY_ALLOC(telem_array);
 static struct intel_pmt_namespace pmt_telem_ns = {
 	.name = "telem",
 	.xa = &telem_array,
-	.pmt_header_decode = pmt_telem_header_decode,
 	.pmt_post_decode = pmt_telem_post_decode,
 	.pmt_add_endpoint = pmt_telem_add_endpoint,
 };
Signature · 1 line
2.43.0
maintainer
#12 lore raw

Re: [PATCH 10/22] platform/x86/intel/pmt: Move header decode into common helper

Quoted 48 lines · David E. Box

Unify PMT discovery table parsing by moving header decode logic into the class driver. A new helper, pmt_read_header(), now fills in the standard header fields from the discovery table, replacing the per-namespace pmt_header_decode callbacks in telemetry and crashlog.

This centralizes the discovery table bit-field definitions in class.h, removes duplicate decode code from telemetry and crashlog, and prepares the PMT class for additional discovery sources.

---
 drivers/platform/x86/intel/pmt/class.c     | 38 +++++++++++++++-------
 drivers/platform/x86/intel/pmt/class.h     | 15 +++++++--
 drivers/platform/x86/intel/pmt/crashlog.c  | 17 ----------
 drivers/platform/x86/intel/pmt/telemetry.c | 26 ---------------
 4 files changed, 40 insertions(+), 56 deletions(-)
drivers/platform/x86/intel/pmt/class.c +6 -8
index 9b315334a69b..a4d6ffed2fed 100644
@@ -8,6 +8,7 @@
  * Author: "Alexander Duyck" <[email protected]>
  */
 
+#include <linux/bitfield.h>
 #include <linux/kernel.h>
 #include <linux/log2.h>
 #include <linux/intel_vsec.h>
@@ -368,26 +369,41 @@ static int intel_pmt_dev_register(struct intel_pmt_entry *entry,
 	return ret;
 }
 
-int intel_pmt_dev_create(struct intel_pmt_entry *entry, struct intel_pmt_namespace *ns,
-			 struct intel_vsec_device *intel_vsec_dev, int idx)
+static int pmt_read_header(struct intel_vsec_device *ivdev, int idx,
+			   struct intel_pmt_entry *entry)
 {
-	struct device *dev = &intel_vsec_dev->auxdev.dev;
-	struct resource	*disc_res;
-	int ret;
+	struct intel_pmt_header *header = &entry->header;
+	struct device *dev = &ivdev->auxdev.dev;
+	u64 headers[2];
 
-	disc_res = &intel_vsec_dev->resource[idx];
-
-	entry->disc_table = devm_ioremap_resource(dev, disc_res);

drivers/platform/x86/intel/pmt/class.c static int intel_pmt_dev_register(struct intel_pmt_entry *entry, · line 388

Quoted 10 lines
drivers/platform/x86/intel/pmt/class.c +7 -0
+	entry->disc_table = devm_ioremap_resource(dev, &ivdev->resource[idx]);
 	if (IS_ERR(entry->disc_table))
 		return PTR_ERR(entry->disc_table);
 
+	memcpy_fromio(headers, entry->disc_table, 2 * sizeof(u64));
+
+	header->access_type = FIELD_GET(PMT_ACCESS_TYPE, headers[0]);
+	header->telem_type = FIELD_GET(PMT_TELEM_TYPE, headers[0]);
+	/* Size is measured in DWORDS, but accessor returns bytes */
+	header->size = PMT_GET_SIZE(FIELD_GET(PMT_SIZE, headers[0]));

IMO, the FIELD_GET() could be done within the macro as the macro itself is PMT SIZE specific.

Perhaps name it such that the name indicates unit as you currently end up using comments to explain that.

Quoted 46 lines
drivers/platform/x86/intel/pmt/class.c +14 -3
+	header->guid = FIELD_GET(PMT_GUID32, headers[0]);
+	header->base_offset = FIELD_GET(PMT_BASE_OFFSET, headers[1]);
+
+	return 0;
+}
+
+int intel_pmt_dev_create(struct intel_pmt_entry *entry, struct intel_pmt_namespace *ns,
+			 struct intel_vsec_device *intel_vsec_dev, int idx)
+{
+	int ret;
+
 	if (ns->pmt_pre_decode) {
 		ret = ns->pmt_pre_decode(intel_vsec_dev, entry);
 		if (ret)
 			return ret;
 	}
 
-	ret = ns->pmt_header_decode(entry, dev);
+	ret = pmt_read_header(intel_vsec_dev, idx, entry);
 	if (ret)
 		return ret;
 
@@ -397,11 +413,11 @@ int intel_pmt_dev_create(struct intel_pmt_entry *entry, struct intel_pmt_namespa
 			return ret;
 	}
 
-	ret = intel_pmt_populate_entry(entry, intel_vsec_dev, disc_res);
+	ret = intel_pmt_populate_entry(entry, intel_vsec_dev, &intel_vsec_dev->resource[idx]);
 	if (ret)
 		return ret;
 
-	return intel_pmt_dev_register(entry, ns, dev);
+	return intel_pmt_dev_register(entry, ns, &intel_vsec_dev->auxdev.dev);
 }
 EXPORT_SYMBOL_NS_GPL(intel_pmt_dev_create, "INTEL_PMT");
 
drivers/platform/x86/intel/pmt/class.h +2 -0
index 8a0db0ef58c1..06f90c7ce6b3 100644
@@ -11,6 +11,19 @@
 
 #include "telemetry.h"
 
+/* PMT Discovery Table DWORD 1 */
+#define PMT_ACCESS_TYPE		GENMASK_ULL(3, 0)

drivers/platform/x86/intel/pmt/class.h line 25

Quoted 10 lines
drivers/platform/x86/intel/pmt/class.h +10 -0
+#define PMT_TELEM_TYPE		GENMASK_ULL(7, 4)
+#define PMT_SIZE		GENMASK_ULL(27, 12)
+#define PMT_GUID32		GENMASK_ULL(63, 32)
+
+/* PMT Discovery Table DWORD 2 */
+#define PMT_BASE_OFFSET		GENMASK_ULL(31, 0)
+#define PMT_TELE_ID		GENMASK_ULL(63, 32)
+
+/* Get size bytes from DWORDs */
+#define PMT_GET_SIZE(v)		((v) << 2)

Use (v) * sizeof(u32) or something along those lines.

Quoted 23 lines
drivers/platform/x86/intel/pmt/class.h +1 -2
+
 /* PMT access types */
 #define ACCESS_BARID		2
 #define ACCESS_LOCAL		3
@@ -61,8 +74,6 @@ struct intel_pmt_entry {
 struct intel_pmt_namespace {
 	const char *name;
 	struct xarray *xa;
-	int (*pmt_header_decode)(struct intel_pmt_entry *entry,
-				 struct device *dev);
 	int (*pmt_pre_decode)(struct intel_vsec_device *ivdev,
 			      struct intel_pmt_entry *entry);
 	int (*pmt_post_decode)(struct intel_vsec_device *ivdev,
drivers/platform/x86/intel/pmt/crashlog.c +0 -2
index f936daf99e4d..67795e2cb1ed 100644
@@ -516,28 +516,11 @@ static int pmt_crashlog_pre_decode(struct intel_vsec_device *ivdev,
 	return 0;
 }
 
-static int pmt_crashlog_header_decode(struct intel_pmt_entry *entry,
-				      struct device *dev)

drivers/platform/x86/intel/pmt/crashlog.c static int pmt_crashlog_pre_decode(struct intel_vsec_device *ivdev, · line 530

Quoted 10 lines
drivers/platform/x86/intel/pmt/crashlog.c +0 -10
-{
-	void __iomem *disc_table = entry->disc_table;
-	struct intel_pmt_header *header = &entry->header;
-
-	header->access_type = GET_ACCESS(readl(disc_table));
-	header->guid = readl(disc_table + GUID_OFFSET);
-	header->base_offset = readl(disc_table + BASE_OFFSET);
-
-	/* Size is measured in DWORDS, but accessor returns bytes */
-	header->size = GET_SIZE(readl(disc_table + SIZE_OFFSET));

The macros become unused after this but were not removed?

Overall, this change is nice consolidation. :-)

Signature · 1 line
 i.
Quoted 65 lines
drivers/platform/x86/intel/pmt/crashlog.c +0 -5
-
-	return 0;
-}
-
 static DEFINE_XARRAY_ALLOC(crashlog_array);
 static struct intel_pmt_namespace pmt_crashlog_ns = {
 	.name = "crashlog",
 	.xa = &crashlog_array,
 	.pmt_pre_decode = pmt_crashlog_pre_decode,
-	.pmt_header_decode = pmt_crashlog_header_decode,
 };
 
 /*
drivers/platform/x86/intel/pmt/telemetry.c +0 -26
index d22f633638be..80773e3c3efa 100644
@@ -27,14 +27,6 @@
 
 #include "class.h"
 
-#define TELEM_SIZE_OFFSET	0x0
-#define TELEM_GUID_OFFSET	0x4
-#define TELEM_BASE_OFFSET	0x8
-#define TELEM_ACCESS(v)		((v) & GENMASK(3, 0))
-#define TELEM_TYPE(v)		(((v) & GENMASK(7, 4)) >> 4)
-/* size is in bytes */
-#define TELEM_SIZE(v)		(((v) & GENMASK(27, 12)) >> 10)
-
 /* Used by client hardware to identify a fixed telemetry entry*/
 #define TELEM_CLIENT_FIXED_BLOCK_GUID	0x10000000
 
@@ -69,23 +61,6 @@ static bool pmt_telem_region_overlaps(struct device *dev, u32 guid, u32 type)
 	return false;
 }
 
-static int pmt_telem_header_decode(struct intel_pmt_entry *entry,
-				   struct device *dev)
-{
-	void __iomem *disc_table = entry->disc_table;
-	struct intel_pmt_header *header = &entry->header;
-
-	header->access_type = TELEM_ACCESS(readl(disc_table));
-	header->guid = readl(disc_table + TELEM_GUID_OFFSET);
-	header->base_offset = readl(disc_table + TELEM_BASE_OFFSET);
-
-	/* Size is measured in DWORDS, but accessor returns bytes */
-	header->size = TELEM_SIZE(readl(disc_table));
-	header->telem_type = TELEM_TYPE(readl(entry->disc_table));
-
-	return 0;
-}
-
 static int pmt_telem_post_decode(struct intel_vsec_device *ivdev,
 				 struct intel_pmt_entry *entry)
 {
@@ -135,7 +110,6 @@ static DEFINE_XARRAY_ALLOC(telem_array);
 static struct intel_pmt_namespace pmt_telem_ns = {
 	.name = "telem",
 	.xa = &telem_array,
-	.pmt_header_decode = pmt_telem_header_decode,
 	.pmt_post_decode = pmt_telem_post_decode,
 	.pmt_add_endpoint = pmt_telem_add_endpoint,
 };
author maintainer
#13 lore raw

PATCH 11/22 platform/x86/intel/pmt: Pass discovery index instead of resource

In reply to David E. Box

Change PMT class code to pass a discovery index rather than a direct struct resource when creating entries. This allows the class to identify the discovery source generically without assuming PCI BAR resources. For PCI devices, the index still resolves to a resource in the intel_vsec_device. Other discovery sources, such as ACPI, can use the same index without needing a struct resource.

---
 drivers/platform/x86/intel/pmt/class.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/platform/x86/intel/pmt/class.c +4 -2
index a4d6ffed2fed..f94f51178043 100644
@@ -207,11 +207,12 @@ EXPORT_SYMBOL_GPL(intel_pmt_class);
 
 static int intel_pmt_populate_entry(struct intel_pmt_entry *entry,
 				    struct intel_vsec_device *ivdev,
-				    struct resource *disc_res)
+				    int idx)
 {
 	struct pci_dev *pci_dev = to_pci_dev(ivdev->dev);
 	struct device *dev = &ivdev->auxdev.dev;
 	struct intel_pmt_header *header = &entry->header;
+	struct resource *disc_res;
 	u8 bir;
 
 	/*
@@ -236,6 +237,7 @@ static int intel_pmt_populate_entry(struct intel_pmt_entry *entry,
 		 * For access_type LOCAL, the base address is as follows:
 		 * base address = end of discovery region + base offset
 		 */
+		disc_res = &ivdev->resource[idx];
 		entry->base_addr = disc_res->end + 1 + header->base_offset;
 
 		/*
@@ -413,7 +415,7 @@ int intel_pmt_dev_create(struct intel_pmt_entry *entry, struct intel_pmt_namespa
 			return ret;
 	}
 
-	ret = intel_pmt_populate_entry(entry, intel_vsec_dev, &intel_vsec_dev->resource[idx]);
+	ret = intel_pmt_populate_entry(entry, intel_vsec_dev, idx);
 	if (ret)
 		return ret;
 
Signature · 1 line
2.43.0
author maintainer
#14 lore raw

PATCH 12/22 platform/x86/intel/pmt: Unify header fetch and add ACPI source

In reply to David E. Box

Allow the PMT class to read discovery headers from either PCI MMIO or ACPI-provided entries, depending on the discovery source. The new source-aware fetch helper retrieves the first two QWORDs for both paths while keeping the mapped discovery table available for users such as crashlog.

Split intel_pmt_populate_entry() into source-specific resolvers:
- pmt_resolve_access_pci(): handles both ACCESS_LOCAL and ACCESS_BARID

    for PCI-backed devices and sets entry->pcidev. Same existing
    functionality.

- pmt_resolve_access_acpi(): handles only ACCESS_BARID for ACPI-backed devices, rejecting ACCESS_LOCAL which has no valid semantics without a physical discovery resource.

This maintains existing PCI behavior and makes no functional changes for PCI devices.

---
 drivers/platform/x86/intel/pmt/class.c | 124 +++++++++++++++++++++++--
 1 file changed, 115 insertions(+), 9 deletions(-)
drivers/platform/x86/intel/pmt/class.c +115 -9
index f94f51178043..ddd9c4bf7323 100644
@@ -205,9 +205,9 @@ struct class intel_pmt_class = {
 };
 EXPORT_SYMBOL_GPL(intel_pmt_class);
 
-static int intel_pmt_populate_entry(struct intel_pmt_entry *entry,
-				    struct intel_vsec_device *ivdev,
-				    int idx)
+static int pmt_resolve_access_pci(struct intel_pmt_entry *entry,
+				  struct intel_vsec_device *ivdev,
+				  int idx)
 {
 	struct pci_dev *pci_dev = to_pci_dev(ivdev->dev);
 	struct device *dev = &ivdev->auxdev.dev;
@@ -287,6 +287,82 @@ static int intel_pmt_populate_entry(struct intel_pmt_entry *entry,
 	}
 
 	entry->pcidev = pci_dev;
+
+	return 0;
+}
+
+static int pmt_resolve_access_acpi(struct intel_pmt_entry *entry,
+				   struct intel_vsec_device *ivdev)
+{
+	struct pci_dev *pci_dev = NULL;
+	struct device *dev = &ivdev->auxdev.dev;
+	struct intel_pmt_header *header = &entry->header;
+	u8 bir;
+
+	if (dev_is_pci(ivdev->dev))
+		pci_dev = to_pci_dev(ivdev->dev);
+
+	/*
+	 * The base offset should always be 8 byte aligned.
+	 *
+	 * For non-local access types the lower 3 bits of base offset
+	 * contains the index of the base address register where the
+	 * telemetry can be found.
+	 */
+	bir = GET_BIR(header->base_offset);
+
+	switch (header->access_type) {
+	case ACCESS_BARID:
+		/* ACPI platform drivers use base_addr */
+		if (ivdev->base_addr) {
+			entry->base_addr = ivdev->base_addr +
+					   GET_ADDRESS(header->base_offset);
+			break;
+		}
+
+		/* If base_addr is not provided, then this is an ACPI companion device */
+		if (!pci_dev) {
+			dev_err(dev,
+				"ACCESS_BARID requires PCI BAR resources or base_addr\n");
+			return -EINVAL;
+		}
+
+		entry->base_addr = pci_resource_start(pci_dev, bir) +
+			GET_ADDRESS(header->base_offset);
+		break;
+	default:
+		dev_err(dev, "Unsupported access type %d for ACPI based PMT\n",
+			header->access_type);
+		return -EINVAL;
+	}
+
+	return 0;
+}
+
+static int intel_pmt_populate_entry(struct intel_pmt_entry *entry,
+				    struct intel_vsec_device *ivdev,
+				    int idx)
+{
+	struct intel_pmt_header *header = &entry->header;
+	struct device *dev = &ivdev->auxdev.dev;
+	int ret;
+
+	switch (ivdev->src) {
+	case INTEL_VSEC_DISC_PCI:
+		ret = pmt_resolve_access_pci(entry, ivdev, idx);
+		break;
+	case INTEL_VSEC_DISC_ACPI:
+		ret = pmt_resolve_access_acpi(entry, ivdev);
+		break;
+	default:
+		dev_err(dev, "Unknown discovery source: %d\n", ivdev->src);
+		ret = -EINVAL;
+		break;
+	}
+
+	if (ret)
+		return ret;
+
 	entry->guid = header->guid;
 	entry->size = header->size;
 	entry->cb = ivdev->priv_data;
@@ -371,18 +447,48 @@ static int intel_pmt_dev_register(struct intel_pmt_entry *entry,
 	return ret;
 }
 
+static int pmt_get_headers(struct intel_vsec_device *ivdev, int idx,
+			   struct intel_pmt_entry *entry, u64 headers[2])
+{
+	struct device *dev = &ivdev->auxdev.dev;
+
+	switch (ivdev->src) {
+	case INTEL_VSEC_DISC_PCI: {
+		void __iomem *disc_table;
+
+		disc_table = devm_ioremap_resource(dev, &ivdev->resource[idx]);
+		if (IS_ERR(disc_table))
+			return PTR_ERR(disc_table);
+
+		memcpy_fromio(headers, disc_table, 2 * sizeof(u64));
+
+		/* Used by crashlog driver */
+		entry->disc_table = disc_table;
+
+		return 0;
+	}
+	case INTEL_VSEC_DISC_ACPI:
+		memcpy(headers, &ivdev->acpi_disc[idx][0], 2 * sizeof(u64));
+
+		return 0;
+	default:
+		dev_err(dev, "Unknown discovery source type: %d\n", ivdev->src);
+		break;
+	}
+
+	return -EINVAL;
+}
+
 static int pmt_read_header(struct intel_vsec_device *ivdev, int idx,
 			   struct intel_pmt_entry *entry)
 {
 	struct intel_pmt_header *header = &entry->header;
-	struct device *dev = &ivdev->auxdev.dev;
 	u64 headers[2];
+	int ret;
 
-	entry->disc_table = devm_ioremap_resource(dev, &ivdev->resource[idx]);
-	if (IS_ERR(entry->disc_table))
-		return PTR_ERR(entry->disc_table);
-
-	memcpy_fromio(headers, entry->disc_table, 2 * sizeof(u64));
+	ret = pmt_get_headers(ivdev, idx, entry, headers);
+	if (ret)
+		return ret;
 
 	header->access_type = FIELD_GET(PMT_ACCESS_TYPE, headers[0]);
 	header->telem_type = FIELD_GET(PMT_TELEM_TYPE, headers[0]);
Signature · 1 line
2.43.0
maintainer
#15 lore raw

Re: [PATCH 12/22] platform/x86/intel/pmt: Unify header fetch and add ACPI source

Quoted 70 lines · David E. Box

Allow the PMT class to read discovery headers from either PCI MMIO or ACPI-provided entries, depending on the discovery source. The new source-aware fetch helper retrieves the first two QWORDs for both paths while keeping the mapped discovery table available for users such as crashlog.

Split intel_pmt_populate_entry() into source-specific resolvers:
- pmt_resolve_access_pci(): handles both ACCESS_LOCAL and ACCESS_BARID

    for PCI-backed devices and sets entry->pcidev. Same existing
    functionality.

- pmt_resolve_access_acpi(): handles only ACCESS_BARID for ACPI-backed devices, rejecting ACCESS_LOCAL which has no valid semantics without a physical discovery resource.

This maintains existing PCI behavior and makes no functional changes for PCI devices.

---
 drivers/platform/x86/intel/pmt/class.c | 124 +++++++++++++++++++++++--
 1 file changed, 115 insertions(+), 9 deletions(-)
drivers/platform/x86/intel/pmt/class.c +30 -3
index f94f51178043..ddd9c4bf7323 100644
@@ -205,9 +205,9 @@ struct class intel_pmt_class = {
 };
 EXPORT_SYMBOL_GPL(intel_pmt_class);
 
-static int intel_pmt_populate_entry(struct intel_pmt_entry *entry,
-				    struct intel_vsec_device *ivdev,
-				    int idx)
+static int pmt_resolve_access_pci(struct intel_pmt_entry *entry,
+				  struct intel_vsec_device *ivdev,
+				  int idx)
 {
 	struct pci_dev *pci_dev = to_pci_dev(ivdev->dev);
 	struct device *dev = &ivdev->auxdev.dev;
@@ -287,6 +287,82 @@ static int intel_pmt_populate_entry(struct intel_pmt_entry *entry,
 	}
 
 	entry->pcidev = pci_dev;
+
+	return 0;
+}
+
+static int pmt_resolve_access_acpi(struct intel_pmt_entry *entry,
+				   struct intel_vsec_device *ivdev)
+{
+	struct pci_dev *pci_dev = NULL;
+	struct device *dev = &ivdev->auxdev.dev;
+	struct intel_pmt_header *header = &entry->header;
+	u8 bir;
+
+	if (dev_is_pci(ivdev->dev))
+		pci_dev = to_pci_dev(ivdev->dev);
+
+	/*
+	 * The base offset should always be 8 byte aligned.
+	 *
+	 * For non-local access types the lower 3 bits of base offset
+	 * contains the index of the base address register where the
+	 * telemetry can be found.
+	 */
+	bir = GET_BIR(header->base_offset);
+
+	switch (header->access_type) {
+	case ACCESS_BARID:
+		/* ACPI platform drivers use base_addr */

drivers/platform/x86/intel/pmt/class.c static int intel_pmt_populate_entry(struct intel_pmt_entry *entry, · line 326

Quoted 10 lines
drivers/platform/x86/intel/pmt/class.c +10 -0
+		if (ivdev->base_addr) {
+			entry->base_addr = ivdev->base_addr +
+					   GET_ADDRESS(header->base_offset);
+			break;
+		}
+
+		/* If base_addr is not provided, then this is an ACPI companion device */
+		if (!pci_dev) {
+			dev_err(dev,
+				"ACCESS_BARID requires PCI BAR resources or base_addr\n");

IMO the extra line is not very useful here.

Quoted 28 lines
drivers/platform/x86/intel/pmt/class.c +28 -0
+			return -EINVAL;
+		}
+
+		entry->base_addr = pci_resource_start(pci_dev, bir) +
+			GET_ADDRESS(header->base_offset);
+		break;
+	default:
+		dev_err(dev, "Unsupported access type %d for ACPI based PMT\n",
+			header->access_type);
+		return -EINVAL;
+	}
+
+	return 0;
+}
+
+static int intel_pmt_populate_entry(struct intel_pmt_entry *entry,
+				    struct intel_vsec_device *ivdev,
+				    int idx)
+{
+	struct intel_pmt_header *header = &entry->header;
+	struct device *dev = &ivdev->auxdev.dev;
+	int ret;
+
+	switch (ivdev->src) {
+	case INTEL_VSEC_DISC_PCI:
+		ret = pmt_resolve_access_pci(entry, ivdev, idx);
+		break;
+	case INTEL_VSEC_DISC_ACPI:

drivers/platform/x86/intel/pmt/class.c static int intel_pmt_populate_entry(struct intel_pmt_entry *entry, · line 364

Quoted 10 lines
drivers/platform/x86/intel/pmt/class.c +10 -0
+		ret = pmt_resolve_access_acpi(entry, ivdev);
+		break;
+	default:
+		dev_err(dev, "Unknown discovery source: %d\n", ivdev->src);
+		ret = -EINVAL;
+		break;
+	}
+
+	if (ret)
+		return ret;

Instead of deferring to after the switch/case, I'd prefer you handle the errors within the cases as it, while longer by a few lines, makes following the logic easier.

Quoted 60 lines
drivers/platform/x86/intel/pmt/class.c +37 -6
+
 	entry->guid = header->guid;
 	entry->size = header->size;
 	entry->cb = ivdev->priv_data;
@@ -371,18 +447,48 @@ static int intel_pmt_dev_register(struct intel_pmt_entry *entry,
 	return ret;
 }
 
+static int pmt_get_headers(struct intel_vsec_device *ivdev, int idx,
+			   struct intel_pmt_entry *entry, u64 headers[2])
+{
+	struct device *dev = &ivdev->auxdev.dev;
+
+	switch (ivdev->src) {
+	case INTEL_VSEC_DISC_PCI: {
+		void __iomem *disc_table;
+
+		disc_table = devm_ioremap_resource(dev, &ivdev->resource[idx]);
+		if (IS_ERR(disc_table))
+			return PTR_ERR(disc_table);
+
+		memcpy_fromio(headers, disc_table, 2 * sizeof(u64));
+
+		/* Used by crashlog driver */
+		entry->disc_table = disc_table;
+
+		return 0;
+	}
+	case INTEL_VSEC_DISC_ACPI:
+		memcpy(headers, &ivdev->acpi_disc[idx][0], 2 * sizeof(u64));
+
+		return 0;
+	default:
+		dev_err(dev, "Unknown discovery source type: %d\n", ivdev->src);
+		break;
+	}
+
+	return -EINVAL;
+}
+
 static int pmt_read_header(struct intel_vsec_device *ivdev, int idx,
 			   struct intel_pmt_entry *entry)
 {
 	struct intel_pmt_header *header = &entry->header;
-	struct device *dev = &ivdev->auxdev.dev;
 	u64 headers[2];
+	int ret;
 
-	entry->disc_table = devm_ioremap_resource(dev, &ivdev->resource[idx]);
-	if (IS_ERR(entry->disc_table))
-		return PTR_ERR(entry->disc_table);
-
-	memcpy_fromio(headers, entry->disc_table, 2 * sizeof(u64));
+	ret = pmt_get_headers(ivdev, idx, entry, headers);
+	if (ret)
+		return ret;
 
 	header->access_type = FIELD_GET(PMT_ACCESS_TYPE, headers[0]);
 	header->telem_type = FIELD_GET(PMT_TELEM_TYPE, headers[0]);
Signature · 1 line
 i.
author maintainer
#16 lore raw

PATCH 13/22 platform/x86/intel/pmc: Add PMC SSRAM Kconfig description

In reply to David E. Box

Add a proper description for the intel_pmc_ssram driver.

---
 drivers/platform/x86/intel/pmc/Kconfig | 11 +++++++++++
 1 file changed, 11 insertions(+)
drivers/platform/x86/intel/pmc/Kconfig +11 -0
index c6ef0bcf76af..0f19dc7edcf9 100644
@@ -28,3 +28,14 @@ config INTEL_PMC_CORE
 
 config INTEL_PMC_SSRAM_TELEMETRY
 	tristate
+	help
+	  This PCI driver discovers PMC SSRAM telemetry regions through the
+	  PMC's MMIO interface and registers them with the Intel VSEC framework
+	  as Intel PMT telemetry devices.
+
+	  It probes the PMC SSRAM device, extracts DVSEC information from MMIO,
+	  reads device IDs and base addresses for multiple PMCs (main, IOE, PCH),
+	  and exposes the discovered telemetry through Intel PMT interfaces
+	  (including sysfs).
+
+	  This option is selected by INTEL_PMC_CORE.
Signature · 1 line
2.43.0
author maintainer
#17 lore raw

PATCH 14/22 platform/x86/intel/pmc: Add ACPI PWRM telemetry driver for Nova Lake S

In reply to David E. Box

Add an ACPI-based PMC PWRM telemetry driver for Nova Lake S. The driver locates PMT discovery data in _DSD under the Intel VSEC UUID, parses it, and registers telemetry regions with the PMT/VSEC framework so PMC telemetry is exposed via existing PMT interfaces.

Export pmc_parse_telem_dsd() and pmc_find_telem_guid() to support ACPI discovery in other PMC drivers (e.g., ssram_telemetry) without duplicating ACPI parsing logic. Also export acpi_disc_t typedef from core.h for callers to properly declare discovery table arrays.

Selected by INTEL_PMC_CORE. Existing PCI functionality is preserved.

---
 drivers/platform/x86/intel/pmc/Kconfig        |  14 ++
 drivers/platform/x86/intel/pmc/Makefile       |   2 +
 drivers/platform/x86/intel/pmc/core.h         |  12 +
 .../platform/x86/intel/pmc/pwrm_telemetry.c   | 227 ++++++++++++++++++
 4 files changed, 255 insertions(+)
 create mode 100644 drivers/platform/x86/intel/pmc/pwrm_telemetry.c
drivers/platform/x86/intel/pmc/Kconfig +14 -0
index 0f19dc7edcf9..937186b0b5dd 100644
@@ -9,6 +9,7 @@ config INTEL_PMC_CORE
 	depends on ACPI
 	depends on INTEL_PMT_TELEMETRY
 	select INTEL_PMC_SSRAM_TELEMETRY
+	select INTEL_PMC_PWRM_TELEMETRY
 	help
 	  The Intel Platform Controller Hub for Intel Core SoCs provides access
 	  to Power Management Controller registers via various interfaces. This
@@ -39,3 +40,16 @@ config INTEL_PMC_SSRAM_TELEMETRY
 	  (including sysfs).
 
 	  This option is selected by INTEL_PMC_CORE.
+
+config INTEL_PMC_PWRM_TELEMETRY
+	tristate
+	help
+	  This driver discovers PMC PWRM telemetry regions described in ACPI
+	  _DSD and registers them with the Intel VSEC framework as Intel PMT
+	  telemetry devices.
+
+	  It validates the ACPI discovery data and publishes the discovered
+	  regions so they can be accessed through the Intel PMT telemetry
+	  interfaces (including sysfs).
+
+	  This option is selected by INTEL_PMC_CORE.
drivers/platform/x86/intel/pmc/Makefile +2 -0
index bb960c8721d7..fdbb768f7b09 100644
@@ -12,3 +12,5 @@ obj-$(CONFIG_INTEL_PMC_CORE)		+= intel_pmc_core_pltdrv.o
 # Intel PMC SSRAM driver
 intel_pmc_ssram_telemetry-y		+= ssram_telemetry.o
 obj-$(CONFIG_INTEL_PMC_SSRAM_TELEMETRY)	+= intel_pmc_ssram_telemetry.o
+intel_pmc_pwrm_telemetry-y		+= pwrm_telemetry.o
+obj-$(CONFIG_INTEL_PMC_PWRM_TELEMETRY)	+= intel_pmc_pwrm_telemetry.o
drivers/platform/x86/intel/pmc/core.h +12 -0
index 118c8740ad3a..284aced99f72 100644
@@ -562,6 +562,8 @@ int pmc_core_pmt_get_blk_sub_req(struct pmc_dev *pmcdev, struct pmc *pmc,
 extern const struct file_operations pmc_core_substate_req_regs_fops;
 extern const struct file_operations pmc_core_substate_blk_req_fops;
 
+extern const guid_t intel_vsec_guid;
+
 #define pmc_for_each_mode(mode, pmc)						\
 	for (unsigned int __i = 0, __cond;					\
 	     __cond = __i < (pmc)->num_lpm_modes,				\
@@ -583,4 +585,14 @@ static const struct file_operations __name ## _fops = {			\
 	.release	= single_release,				\
 }
 
+struct intel_vsec_header;
+union acpi_object;
+
+/* Avoid checkpatch warning */
+typedef u32 (*acpi_disc_t)[4];
+
+int pmc_parse_telem_dsd(union acpi_object *obj,
+			struct intel_vsec_header *header,
+			acpi_disc_t *acpi_disc);
+union acpi_object *pmc_find_telem_guid(union acpi_object *dsd);
 #endif /* PMC_CORE_H */
drivers/platform/x86/intel/pmc/pwrm_telemetry.c new file +227 -0

227 lines not on this page · raw message

Signature · 1 line
2.43.0
maintainer
#18 lore raw

Re: [PATCH 14/22] platform/x86/intel/pmc: Add ACPI PWRM telemetry driver for Nova Lake S

Quoted 65 lines · David E. Box

Add an ACPI-based PMC PWRM telemetry driver for Nova Lake S. The driver locates PMT discovery data in _DSD under the Intel VSEC UUID, parses it, and registers telemetry regions with the PMT/VSEC framework so PMC telemetry is exposed via existing PMT interfaces.

Export pmc_parse_telem_dsd() and pmc_find_telem_guid() to support ACPI discovery in other PMC drivers (e.g., ssram_telemetry) without duplicating ACPI parsing logic. Also export acpi_disc_t typedef from core.h for callers to properly declare discovery table arrays.

Selected by INTEL_PMC_CORE. Existing PCI functionality is preserved.

---
 drivers/platform/x86/intel/pmc/Kconfig        |  14 ++
 drivers/platform/x86/intel/pmc/Makefile       |   2 +
 drivers/platform/x86/intel/pmc/core.h         |  12 +
 .../platform/x86/intel/pmc/pwrm_telemetry.c   | 227 ++++++++++++++++++
 4 files changed, 255 insertions(+)
 create mode 100644 drivers/platform/x86/intel/pmc/pwrm_telemetry.c
drivers/platform/x86/intel/pmc/Kconfig +14 -0
index 0f19dc7edcf9..937186b0b5dd 100644
@@ -9,6 +9,7 @@ config INTEL_PMC_CORE
 	depends on ACPI
 	depends on INTEL_PMT_TELEMETRY
 	select INTEL_PMC_SSRAM_TELEMETRY
+	select INTEL_PMC_PWRM_TELEMETRY
 	help
 	  The Intel Platform Controller Hub for Intel Core SoCs provides access
 	  to Power Management Controller registers via various interfaces. This
@@ -39,3 +40,16 @@ config INTEL_PMC_SSRAM_TELEMETRY
 	  (including sysfs).
 
 	  This option is selected by INTEL_PMC_CORE.
+
+config INTEL_PMC_PWRM_TELEMETRY
+	tristate
+	help
+	  This driver discovers PMC PWRM telemetry regions described in ACPI
+	  _DSD and registers them with the Intel VSEC framework as Intel PMT
+	  telemetry devices.
+
+	  It validates the ACPI discovery data and publishes the discovered
+	  regions so they can be accessed through the Intel PMT telemetry
+	  interfaces (including sysfs).
+
+	  This option is selected by INTEL_PMC_CORE.
drivers/platform/x86/intel/pmc/Makefile +2 -0
index bb960c8721d7..fdbb768f7b09 100644
@@ -12,3 +12,5 @@ obj-$(CONFIG_INTEL_PMC_CORE)		+= intel_pmc_core_pltdrv.o
 # Intel PMC SSRAM driver
 intel_pmc_ssram_telemetry-y		+= ssram_telemetry.o
 obj-$(CONFIG_INTEL_PMC_SSRAM_TELEMETRY)	+= intel_pmc_ssram_telemetry.o
+intel_pmc_pwrm_telemetry-y		+= pwrm_telemetry.o
+obj-$(CONFIG_INTEL_PMC_PWRM_TELEMETRY)	+= intel_pmc_pwrm_telemetry.o
drivers/platform/x86/intel/pmc/core.h +0 -0
index 118c8740ad3a..284aced99f72 100644

drivers/platform/x86/intel/pmc/core.h int pmc_core_pmt_get_blk_sub_req(struct pmc_dev *pmcdev, struct pmc *pmc, · line 565

Quoted 4 lines
drivers/platform/x86/intel/pmc/core.h +1 -0
@@ -562,6 +562,8 @@ int pmc_core_pmt_get_blk_sub_req(struct pmc_dev *pmcdev, struct pmc *pmc,
 extern const struct file_operations pmc_core_substate_req_regs_fops;
 extern const struct file_operations pmc_core_substate_blk_req_fops;
 
+extern const guid_t intel_vsec_guid;

Please make sure type is available in this file, not only throught the C file includes.

Quoted 42 lines
drivers/platform/x86/intel/pmc/core.h +11 -0
+
 #define pmc_for_each_mode(mode, pmc)						\
 	for (unsigned int __i = 0, __cond;					\
 	     __cond = __i < (pmc)->num_lpm_modes,				\
@@ -583,4 +585,14 @@ static const struct file_operations __name ## _fops = {			\
 	.release	= single_release,				\
 }
 
+struct intel_vsec_header;
+union acpi_object;
+
+/* Avoid checkpatch warning */
+typedef u32 (*acpi_disc_t)[4];
+
+int pmc_parse_telem_dsd(union acpi_object *obj,
+			struct intel_vsec_header *header,
+			acpi_disc_t *acpi_disc);
+union acpi_object *pmc_find_telem_guid(union acpi_object *dsd);
 #endif /* PMC_CORE_H */
drivers/platform/x86/intel/pmc/pwrm_telemetry.c new file +17 -0
new file mode 100644
index 000000000000..25ca6979c214
@@ -0,0 +1,227 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * Intel PMC PWRM ACPI driver
+ *
+ * Copyright (C) 2025, Intel Corporation
+ */
+
+#include <linux/acpi.h>
+#include <linux/bitfield.h>
+#include <linux/device.h>
+#include <linux/err.h>
+#include <linux/errno.h>
+#include <linux/intel_vsec.h>
+#include <linux/mod_devicetable.h>
+#include <linux/module.h>
+#include <linux/platform_device.h>
+#include <linux/resource.h>

drivers/platform/x86/intel/pmc/pwrm_telemetry.c line 27

Quoted 10 lines
drivers/platform/x86/intel/pmc/pwrm_telemetry.c new file +10 -0
+#include <linux/slab.h>
+#include <linux/types.h>
+#include <linux/uuid.h>
+
+#include "core.h"
+
+#define ENTRY_LEN		5
+
+/* DWORD2 */
+#define DVSEC_ID_MASK		GENMASK(15, 0)

GENMASK() needs include too.

Quoted 26 lines
drivers/platform/x86/intel/pmc/pwrm_telemetry.c new file +26 -0
+#define NUM_ENTRIES_MASK	GENMASK(23, 16)
+#define ENTRY_SIZE_MASK		GENMASK(31, 24)
+
+/* DWORD3 */
+#define TBIR_MASK		GENMASK(2, 0)
+#define DISC_TBL_OFF_MASK	GENMASK(31, 3)
+
+const guid_t intel_vsec_guid =
+	GUID_INIT(0x294903fb, 0x634d, 0x4fc7, 0xaf, 0x1f, 0x0f, 0xb9,
+		  0x56, 0xb0, 0x4f, 0xc1);
+
+static bool is_valid_entry(union acpi_object *pkg)
+{
+	int i;
+
+	if (!pkg || pkg->type != ACPI_TYPE_PACKAGE || pkg->package.count != ENTRY_LEN)
+		return false;
+
+	if (pkg->package.elements[0].type != ACPI_TYPE_STRING)
+		return false;
+
+	for (i = 1; i < ENTRY_LEN; i++)
+		if (pkg->package.elements[i].type != ACPI_TYPE_INTEGER)
+			return false;
+
+	return true;

drivers/platform/x86/intel/pmc/pwrm_telemetry.c line 63

Quoted 10 lines
drivers/platform/x86/intel/pmc/pwrm_telemetry.c new file +10 -0
+}
+
+int pmc_parse_telem_dsd(union acpi_object *obj,
+			struct intel_vsec_header *header,
+			u32 (**acpi_disc)[4])
+{
+	union acpi_object *vsec_pkg;
+	union acpi_object *disc_pkg;
+	u64 hdr0;
+	u64 hdr1;

u64 hdr0, hdr1;

Quoted 50 lines
drivers/platform/x86/intel/pmc/pwrm_telemetry.c new file +50 -0
+	int num_regions;
+	int i;
+
+	if (!header)
+		return -EINVAL;
+
+	if (!obj || obj->type != ACPI_TYPE_PACKAGE || obj->package.count != 2)
+		return -EINVAL;
+
+	/* First Package is DVSEC info */
+	vsec_pkg = &obj->package.elements[0];
+	if (!is_valid_entry(vsec_pkg))
+		return -EINVAL;
+
+	hdr0 = vsec_pkg->package.elements[3].integer.value;
+	hdr1 = vsec_pkg->package.elements[4].integer.value;
+
+	header->id          = FIELD_GET(DVSEC_ID_MASK, hdr0);
+	header->num_entries = FIELD_GET(NUM_ENTRIES_MASK, hdr0);
+	header->entry_size  = FIELD_GET(ENTRY_SIZE_MASK, hdr0);
+	header->tbir        = FIELD_GET(TBIR_MASK, hdr1);
+	header->offset      = FIELD_GET(DISC_TBL_OFF_MASK, hdr1);
+
+	/* Second Package contains the discovery tables */
+	disc_pkg = &obj->package.elements[1];
+	if (disc_pkg->type != ACPI_TYPE_PACKAGE || disc_pkg->package.count < 1)
+		return -EINVAL;
+
+	num_regions = disc_pkg->package.count;
+	if (header->num_entries != num_regions)
+		return -EINVAL;
+
+	*acpi_disc = kmalloc_array(num_regions, sizeof(**acpi_disc), GFP_KERNEL);
+	if (!*acpi_disc)
+		return -ENOMEM;
+
+	for (i = 0; i < num_regions; i++) {
+		union acpi_object *pkg;
+		u64 value;
+		int j;
+
+		pkg = &disc_pkg->package.elements[i];
+		if (!is_valid_entry(pkg)) {
+			kfree(*acpi_disc);
+			return -EINVAL;
+		}
+
+		/* Element 0 is a descriptive string; DWORD values start at index 1. */
+		for (j = 1; j < ENTRY_LEN; j++) {
+			value = pkg->package.elements[j].integer.value;

drivers/platform/x86/intel/pmc/pwrm_telemetry.c line 123

Quoted 10 lines
drivers/platform/x86/intel/pmc/pwrm_telemetry.c new file +10 -0
+			if (value > U32_MAX) {
+				kfree(*acpi_disc);
+				return -ERANGE;
+			}
+
+			(*acpi_disc)[i][j - 1] = value;
+		}
+	}
+
+	return 0;

Should this function return err ptrs instead?

Consider also using __free() + no_free_ptr().

Quoted 41 lines
drivers/platform/x86/intel/pmc/pwrm_telemetry.c new file +41 -0
+}
+EXPORT_SYMBOL_NS_GPL(pmc_parse_telem_dsd, "INTEL_PMC_CORE");
+
+union acpi_object *pmc_find_telem_guid(union acpi_object *dsd)
+{
+	int i;
+
+	if (!dsd || dsd->type != ACPI_TYPE_PACKAGE)
+		return NULL;
+
+	for (i = 0; i + 1 < dsd->package.count; i += 2) {
+		union acpi_object *uuid_obj, *data_obj;
+		guid_t uuid;
+
+		uuid_obj = &dsd->package.elements[i];
+		data_obj = &dsd->package.elements[i + 1];
+
+		if (uuid_obj->type != ACPI_TYPE_BUFFER ||
+		    uuid_obj->buffer.length != 16)
+			continue;
+
+		memcpy(&uuid, uuid_obj->buffer.pointer, 16);
+		if (guid_equal(&uuid, &intel_vsec_guid))
+			return data_obj;
+	}
+
+	return NULL;
+}
+EXPORT_SYMBOL_NS_GPL(pmc_find_telem_guid, "INTEL_PMC_CORE");
+
+static int pmc_pwrm_acpi_probe(struct platform_device *pdev)
+{
+	struct acpi_buffer buf = { ACPI_ALLOCATE_BUFFER, NULL };
+	acpi_handle handle = ACPI_HANDLE(&pdev->dev);
+	struct intel_vsec_header header;
+	struct intel_vsec_header *headers[2] = { &header, NULL };
+	struct intel_vsec_platform_info info = { };
+	struct device *dev = &pdev->dev;
+	struct resource *res;
+	u32 (*acpi_disc)[4];
+	union acpi_object *dsd;

drivers/platform/x86/intel/pmc/pwrm_telemetry.c line 174

Quoted 10 lines
drivers/platform/x86/intel/pmc/pwrm_telemetry.c new file +10 -0
+	acpi_status status;
+	int ret;
+
+	if (!handle)
+		return -ENODEV;
+
+	status = acpi_evaluate_object(handle, "_DSD", NULL, &buf);
+	if (ACPI_FAILURE(status))
+		return dev_err_probe(dev, -ENODEV, "Could not evaluate _DSD: %s\n",
+				     acpi_format_exception(status));

Braces.

Quoted 19 lines
drivers/platform/x86/intel/pmc/pwrm_telemetry.c new file +19 -0
+
+	dsd = pmc_find_telem_guid(buf.pointer);
+	if (!dsd) {
+		ret = -ENODEV;
+		goto cleanup_acpi_buf;
+	}
+
+	ret = pmc_parse_telem_dsd(dsd, &header, &acpi_disc);
+	if (ret)
+		goto cleanup_acpi_buf;
+
+	res = platform_get_resource(pdev, IORESOURCE_MEM, header.tbir);
+	if (!res) {
+		ret = -EINVAL;
+		goto cleanup_acpi_disc;
+	}
+
+	info.headers = headers;
+	info.caps = VSEC_CAP_TELEMETRY;

drivers/platform/x86/intel/pmc/pwrm_telemetry.c line 203

Quoted 10 lines
drivers/platform/x86/intel/pmc/pwrm_telemetry.c new file +10 -0
+	info.acpi_disc = acpi_disc;
+	info.src = INTEL_VSEC_DISC_ACPI;
+	info.base_addr = res->start;
+
+	ret = intel_vsec_register(&pdev->dev, &info);
+
+cleanup_acpi_disc:
+	kfree(acpi_disc);
+cleanup_acpi_buf:
+	ACPI_FREE(buf.pointer);

My impression is that these days kfree() is used directly.

Both look like they could use __free().

Quoted 25 lines
drivers/platform/x86/intel/pmc/pwrm_telemetry.c new file +24 -0
+
+	return ret;
+}
+
+static const struct acpi_device_id pmc_pwrm_acpi_ids[] = {
+	{ "INTC1122", 0 }, /* Nova Lake */
+	{ "INTC1129", 0 }, /* Nova Lake */
+	{ }
+};
+MODULE_DEVICE_TABLE(acpi, pmc_pwrm_acpi_ids);
+
+static struct platform_driver pmc_pwrm_acpi_driver = {
+	.probe = pmc_pwrm_acpi_probe,
+	.driver = {
+		.name = "intel_pmc_pwrm_acpi",
+		.acpi_match_table = ACPI_PTR(pmc_pwrm_acpi_ids),
+	},
+};
+module_platform_driver(pmc_pwrm_acpi_driver);
+
+MODULE_AUTHOR("David E. Box <[email protected]>");
+MODULE_DESCRIPTION("Intel PMC PWRM ACPI driver");
+MODULE_LICENSE("GPL");
+MODULE_IMPORT_NS("INTEL_VSEC");
Signature · 1 line
 i.
author maintainer
#19 lore raw

PATCH 15/22 platform/x86/intel/pmc/ssram: Rename probe and PCI ID table for consistency

In reply to David E. Box

Rename intel_pmc_ssram_telemetry_probe() to pmc_ssram_telemetry_probe() and intel_pmc_ssram_telemetry_pci_ids[] to pmc_ssram_telemetry_pci_ids[], updating the MODULE_DEVICE_TABLE() and pci_driver wiring accordingly.

This aligns the symbol names with the driver filename and module name, reduces redundant intel_ prefixes, and improves readability. No functional behavior changes are intended.

---
 drivers/platform/x86/intel/pmc/ssram_telemetry.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
drivers/platform/x86/intel/pmc/ssram_telemetry.c +7 -7
index 6f6e83e70fc5..1deb4d71da3f 100644
@@ -149,7 +149,7 @@ int pmc_ssram_telemetry_get_pmc_info(unsigned int pmc_idx,
 }
 EXPORT_SYMBOL_GPL(pmc_ssram_telemetry_get_pmc_info);
 
-static int intel_pmc_ssram_telemetry_probe(struct pci_dev *pcidev, const struct pci_device_id *id)
+static int pmc_ssram_telemetry_probe(struct pci_dev *pcidev, const struct pci_device_id *id)
 {
 	int ret;
 
@@ -183,7 +183,7 @@ static int intel_pmc_ssram_telemetry_probe(struct pci_dev *pcidev, const struct
 	return ret;
 }
 
-static const struct pci_device_id intel_pmc_ssram_telemetry_pci_ids[] = {
+static const struct pci_device_id pmc_ssram_telemetry_pci_ids[] = {
 	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PMC_DEVID_MTL_SOCM) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PMC_DEVID_ARL_SOCS) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PMC_DEVID_ARL_SOCM) },
@@ -193,14 +193,14 @@ static const struct pci_device_id intel_pmc_ssram_telemetry_pci_ids[] = {
 	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PMC_DEVID_WCL_PCDN) },
 	{ }
 };
-MODULE_DEVICE_TABLE(pci, intel_pmc_ssram_telemetry_pci_ids);
+MODULE_DEVICE_TABLE(pci, pmc_ssram_telemetry_pci_ids);
 
-static struct pci_driver intel_pmc_ssram_telemetry_driver = {
+static struct pci_driver pmc_ssram_telemetry_driver = {
 	.name = "intel_pmc_ssram_telemetry",
-	.id_table = intel_pmc_ssram_telemetry_pci_ids,
-	.probe = intel_pmc_ssram_telemetry_probe,
+	.id_table = pmc_ssram_telemetry_pci_ids,
+	.probe = pmc_ssram_telemetry_probe,
 };
-module_pci_driver(intel_pmc_ssram_telemetry_driver);
+module_pci_driver(pmc_ssram_telemetry_driver);
 
 MODULE_IMPORT_NS("INTEL_VSEC");
 MODULE_AUTHOR("Xi Pardee <[email protected]>");
Signature · 1 line
2.43.0
maintainer Reviewed-by on v1 15/22
#20 lore raw

Re: [PATCH 15/22] platform/x86/intel/pmc/ssram: Rename probe and PCI ID table for consistency

Quoted 46 lines · David E. Box

Rename intel_pmc_ssram_telemetry_probe() to pmc_ssram_telemetry_probe() and intel_pmc_ssram_telemetry_pci_ids[] to pmc_ssram_telemetry_pci_ids[], updating the MODULE_DEVICE_TABLE() and pci_driver wiring accordingly.

This aligns the symbol names with the driver filename and module name, reduces redundant intel_ prefixes, and improves readability. No functional behavior changes are intended.

---
 drivers/platform/x86/intel/pmc/ssram_telemetry.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
drivers/platform/x86/intel/pmc/ssram_telemetry.c +4 -4
index 6f6e83e70fc5..1deb4d71da3f 100644
@@ -149,7 +149,7 @@ int pmc_ssram_telemetry_get_pmc_info(unsigned int pmc_idx,
 }
 EXPORT_SYMBOL_GPL(pmc_ssram_telemetry_get_pmc_info);
 
-static int intel_pmc_ssram_telemetry_probe(struct pci_dev *pcidev, const struct pci_device_id *id)
+static int pmc_ssram_telemetry_probe(struct pci_dev *pcidev, const struct pci_device_id *id)
 {
 	int ret;
 
@@ -183,7 +183,7 @@ static int intel_pmc_ssram_telemetry_probe(struct pci_dev *pcidev, const struct
 	return ret;
 }
 
-static const struct pci_device_id intel_pmc_ssram_telemetry_pci_ids[] = {
+static const struct pci_device_id pmc_ssram_telemetry_pci_ids[] = {
 	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PMC_DEVID_MTL_SOCM) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PMC_DEVID_ARL_SOCS) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PMC_DEVID_ARL_SOCM) },
@@ -193,14 +193,14 @@ static const struct pci_device_id intel_pmc_ssram_telemetry_pci_ids[] = {
 	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PMC_DEVID_WCL_PCDN) },
 	{ }
 };
-MODULE_DEVICE_TABLE(pci, intel_pmc_ssram_telemetry_pci_ids);
+MODULE_DEVICE_TABLE(pci, pmc_ssram_telemetry_pci_ids);
 
-static struct pci_driver intel_pmc_ssram_telemetry_driver = {
+static struct pci_driver pmc_ssram_telemetry_driver = {
 	.name = "intel_pmc_ssram_telemetry",

drivers/platform/x86/intel/pmc/ssram_telemetry.c static const struct pci_device_id intel_pmc_ssram_telemetry_pci_ids[] = { · line 206

Quoted 10 lines
drivers/platform/x86/intel/pmc/ssram_telemetry.c +3 -3
-	.id_table = intel_pmc_ssram_telemetry_pci_ids,
-	.probe = intel_pmc_ssram_telemetry_probe,
+	.id_table = pmc_ssram_telemetry_pci_ids,
+	.probe = pmc_ssram_telemetry_probe,
 };
-module_pci_driver(intel_pmc_ssram_telemetry_driver);
+module_pci_driver(pmc_ssram_telemetry_driver);
 
 MODULE_IMPORT_NS("INTEL_VSEC");
 MODULE_AUTHOR("Xi Pardee <[email protected]>");
Signature · 1 line
 i.
author maintainer
#21 lore raw

PATCH 16/22 platform/x86/intel/pmc/ssram: Use fixed-size static pmc array

In reply to David E. Box

From: Xi Pardee <[email protected]>

Switch pmc_ssram_telems from a devm-allocated pointer to a fixed-size static array, eliminating per-probe allocation overhead and simplifying lifetime management.

Correspondingly simplify pmc_ssram_telemetry_get_pmc_info() validation to check devid availability and tighten input bounds checking. Drop null-pointer checks now that the storage is static.

---
 drivers/platform/x86/intel/pmc/ssram_telemetry.c | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)
drivers/platform/x86/intel/pmc/ssram_telemetry.c +2 -8
index 1deb4d71da3f..9c3d7ba2fd52 100644
@@ -24,7 +24,7 @@
 
 DEFINE_FREE(pmc_ssram_telemetry_iounmap, void __iomem *, if (_T) iounmap(_T))
 
-static struct pmc_ssram_telemetry *pmc_ssram_telems;
+static struct pmc_ssram_telemetry pmc_ssram_telems[3];
 static bool device_probed;
 
 static int
@@ -140,7 +140,7 @@ int pmc_ssram_telemetry_get_pmc_info(unsigned int pmc_idx,
 	if (pmc_idx >= MAX_NUM_PMC)
 		return -EINVAL;
 
-	if (!pmc_ssram_telems || !pmc_ssram_telems[pmc_idx].devid)
+	if (!pmc_ssram_telems[pmc_idx].devid)
 		return -ENODEV;
 
 	pmc_ssram_telemetry->devid = pmc_ssram_telems[pmc_idx].devid;
@@ -153,12 +153,6 @@ static int pmc_ssram_telemetry_probe(struct pci_dev *pcidev, const struct pci_de
 {
 	int ret;
 
-	pmc_ssram_telems = devm_kzalloc(&pcidev->dev, sizeof(*pmc_ssram_telems) * MAX_NUM_PMC,
-					GFP_KERNEL);
-	if (!pmc_ssram_telems) {
-		ret = -ENOMEM;
-		goto probe_finish;
-	}
 
 	ret = pcim_enable_device(pcidev);
 	if (ret) {
Signature · 1 line
2.43.0
author maintainer
#22 lore raw

PATCH 17/22 platform/x86/intel/pmc/ssram: Refactor DEVID/PWRMBASE extraction into helper

In reply to David E. Box

Move DEVID/PWRMBASE extraction into pmc_ssram_get_devid_pwrmbase().

This is a preparatory refactor to place functionality in a common helper for reuse by a subsequent patch, while keeping behavior unchanged in this step.

---
 .../platform/x86/intel/pmc/ssram_telemetry.c  | 31 ++++++++++++-------
 1 file changed, 19 insertions(+), 12 deletions(-)
drivers/platform/x86/intel/pmc/ssram_telemetry.c +19 -12
index 9c3d7ba2fd52..75a80a74a069 100644
@@ -27,6 +27,23 @@ DEFINE_FREE(pmc_ssram_telemetry_iounmap, void __iomem *, if (_T) iounmap(_T))
 static struct pmc_ssram_telemetry pmc_ssram_telems[3];
 static bool device_probed;
 
+static inline u64 get_base(void __iomem *addr, u32 offset)
+{
+	return lo_hi_readq(addr + offset) & GENMASK_ULL(63, 3);
+}
+
+static void pmc_ssram_get_devid_pwrmbase(void __iomem *ssram, unsigned int pmc_idx)
+{
+	u64 pwrm_base;
+	u16 devid;
+
+	pwrm_base = get_base(ssram, SSRAM_PWRM_OFFSET);
+	devid = readw(ssram + SSRAM_DEVID_OFFSET);
+
+	pmc_ssram_telems[pmc_idx].devid = devid;
+	pmc_ssram_telems[pmc_idx].base_addr = pwrm_base;
+}
+
 static int
 pmc_ssram_telemetry_add_pmt(struct pci_dev *pcidev, u64 ssram_base, void __iomem *ssram)
 {
@@ -63,18 +80,12 @@ pmc_ssram_telemetry_add_pmt(struct pci_dev *pcidev, u64 ssram_base, void __iomem
 	return intel_vsec_register(&pcidev->dev, &info);
 }
 
-static inline u64 get_base(void __iomem *addr, u32 offset)
-{
-	return lo_hi_readq(addr + offset) & GENMASK_ULL(63, 3);
-}
-
 static int
 pmc_ssram_telemetry_get_pmc(struct pci_dev *pcidev, unsigned int pmc_idx, u32 offset)
 {
 	void __iomem __free(pmc_ssram_telemetry_iounmap) *tmp_ssram = NULL;
 	void __iomem __free(pmc_ssram_telemetry_iounmap) *ssram = NULL;
-	u64 ssram_base, pwrm_base;
-	u16 devid;
+	u64 ssram_base;
 
 	ssram_base = pci_resource_start(pcidev, 0);
 	tmp_ssram = ioremap(ssram_base, SSRAM_HDR_SIZE);
@@ -99,11 +110,7 @@ pmc_ssram_telemetry_get_pmc(struct pci_dev *pcidev, unsigned int pmc_idx, u32 of
 		ssram = no_free_ptr(tmp_ssram);
 	}
 
-	pwrm_base = get_base(ssram, SSRAM_PWRM_OFFSET);
-	devid = readw(ssram + SSRAM_DEVID_OFFSET);
-
-	pmc_ssram_telems[pmc_idx].devid = devid;
-	pmc_ssram_telems[pmc_idx].base_addr = pwrm_base;
+	pmc_ssram_get_devid_pwrmbase(ssram, pmc_idx);
 
 	/* Find and register and PMC telemetry entries */
 	return pmc_ssram_telemetry_add_pmt(pcidev, ssram_base, ssram);
Signature · 1 line
2.43.0
maintainer
#23 lore raw

Re: [PATCH 17/22] platform/x86/intel/pmc/ssram: Refactor DEVID/PWRMBASE extraction into helper

Quoted 16 lines · David E. Box

Move DEVID/PWRMBASE extraction into pmc_ssram_get_devid_pwrmbase().

This is a preparatory refactor to place functionality in a common helper for reuse by a subsequent patch, while keeping behavior unchanged in this step.

---
 .../platform/x86/intel/pmc/ssram_telemetry.c  | 31 ++++++++++++-------
 1 file changed, 19 insertions(+), 12 deletions(-)
drivers/platform/x86/intel/pmc/ssram_telemetry.c +0 -0
index 9c3d7ba2fd52..75a80a74a069 100644

drivers/platform/x86/intel/pmc/ssram_telemetry.c DEFINE_FREE(pmc_ssram_telemetry_iounmap, void __iomem *, if (_T) iounmap(_T)) · line 32

Quoted 6 lines
drivers/platform/x86/intel/pmc/ssram_telemetry.c +3 -0
@@ -27,6 +27,23 @@ DEFINE_FREE(pmc_ssram_telemetry_iounmap, void __iomem *, if (_T) iounmap(_T))
 static struct pmc_ssram_telemetry pmc_ssram_telems[3];
 static bool device_probed;
 
+static inline u64 get_base(void __iomem *addr, u32 offset)
+{
+	return lo_hi_readq(addr + offset) & GENMASK_ULL(63, 3);

A pre-existing problem: Header for GENMASK_ULL() is missing from this file.

I also would prefer having that field named with define but that too is a pre-existing thing.

Signature · 1 line
 i.
Quoted 51 lines
drivers/platform/x86/intel/pmc/ssram_telemetry.c +16 -12
+}
+
+static void pmc_ssram_get_devid_pwrmbase(void __iomem *ssram, unsigned int pmc_idx)
+{
+	u64 pwrm_base;
+	u16 devid;
+
+	pwrm_base = get_base(ssram, SSRAM_PWRM_OFFSET);
+	devid = readw(ssram + SSRAM_DEVID_OFFSET);
+
+	pmc_ssram_telems[pmc_idx].devid = devid;
+	pmc_ssram_telems[pmc_idx].base_addr = pwrm_base;
+}
+
 static int
 pmc_ssram_telemetry_add_pmt(struct pci_dev *pcidev, u64 ssram_base, void __iomem *ssram)
 {
@@ -63,18 +80,12 @@ pmc_ssram_telemetry_add_pmt(struct pci_dev *pcidev, u64 ssram_base, void __iomem
 	return intel_vsec_register(&pcidev->dev, &info);
 }
 
-static inline u64 get_base(void __iomem *addr, u32 offset)
-{
-	return lo_hi_readq(addr + offset) & GENMASK_ULL(63, 3);
-}
-
 static int
 pmc_ssram_telemetry_get_pmc(struct pci_dev *pcidev, unsigned int pmc_idx, u32 offset)
 {
 	void __iomem __free(pmc_ssram_telemetry_iounmap) *tmp_ssram = NULL;
 	void __iomem __free(pmc_ssram_telemetry_iounmap) *ssram = NULL;
-	u64 ssram_base, pwrm_base;
-	u16 devid;
+	u64 ssram_base;
 
 	ssram_base = pci_resource_start(pcidev, 0);
 	tmp_ssram = ioremap(ssram_base, SSRAM_HDR_SIZE);
@@ -99,11 +110,7 @@ pmc_ssram_telemetry_get_pmc(struct pci_dev *pcidev, unsigned int pmc_idx, u32 of
 		ssram = no_free_ptr(tmp_ssram);
 	}
 
-	pwrm_base = get_base(ssram, SSRAM_PWRM_OFFSET);
-	devid = readw(ssram + SSRAM_DEVID_OFFSET);
-
-	pmc_ssram_telems[pmc_idx].devid = devid;
-	pmc_ssram_telems[pmc_idx].base_addr = pwrm_base;
+	pmc_ssram_get_devid_pwrmbase(ssram, pmc_idx);
 
 	/* Find and register and PMC telemetry entries */
 	return pmc_ssram_telemetry_add_pmt(pcidev, ssram_base, ssram);
author maintainer
#24 lore raw

PATCH 18/22 platform/x86/intel/pmc/ssram: Add PCI platform data

In reply to David E. Box

Add per-device platform data for SSRAM telemetry PCI IDs and route probe through a method selector driven by id->driver_data.

This is a preparatory refactor for follow-on discovery methods while preserving current behavior: all supported IDs continue to use the PCI initialization path.

---
 .../platform/x86/intel/pmc/ssram_telemetry.c  | 69 +++++++++++++++----
 1 file changed, 55 insertions(+), 14 deletions(-)
drivers/platform/x86/intel/pmc/ssram_telemetry.c +55 -14
index 75a80a74a069..7db98037c521 100644
@@ -24,6 +24,18 @@
 
 DEFINE_FREE(pmc_ssram_telemetry_iounmap, void __iomem *, if (_T) iounmap(_T))
 
+enum resource_method {
+	RES_METHOD_PCI,
+};
+
+struct ssram_type {
+	enum resource_method method;
+};
+
+static const struct ssram_type pci_main = {
+	.method = RES_METHOD_PCI,
+};
+
 static struct pmc_ssram_telemetry pmc_ssram_telems[3];
 static bool device_probed;
 
@@ -81,7 +93,7 @@ pmc_ssram_telemetry_add_pmt(struct pci_dev *pcidev, u64 ssram_base, void __iomem
 }
 
 static int
-pmc_ssram_telemetry_get_pmc(struct pci_dev *pcidev, unsigned int pmc_idx, u32 offset)
+pmc_ssram_telemetry_get_pmc_pci(struct pci_dev *pcidev, unsigned int pmc_idx, u32 offset)
 {
 	void __iomem __free(pmc_ssram_telemetry_iounmap) *tmp_ssram = NULL;
 	void __iomem __free(pmc_ssram_telemetry_iounmap) *ssram = NULL;
@@ -116,6 +128,20 @@ pmc_ssram_telemetry_get_pmc(struct pci_dev *pcidev, unsigned int pmc_idx, u32 of
 	return pmc_ssram_telemetry_add_pmt(pcidev, ssram_base, ssram);
 }
 
+static int pmc_ssram_telemetry_pci_init(struct pci_dev *pcidev)
+{
+	int ret;
+
+	ret = pmc_ssram_telemetry_get_pmc_pci(pcidev, PMC_IDX_MAIN, 0);
+	if (ret)
+		return ret;
+
+	pmc_ssram_telemetry_get_pmc_pci(pcidev, PMC_IDX_IOE, SSRAM_IOE_OFFSET);
+	pmc_ssram_telemetry_get_pmc_pci(pcidev, PMC_IDX_PCH, SSRAM_PCH_OFFSET);
+
+	return ret;
+}
+
 /**
  * pmc_ssram_telemetry_get_pmc_info() - Get a PMC devid and base_addr information
  * @pmc_idx:               Index of the PMC
@@ -158,8 +184,18 @@ EXPORT_SYMBOL_GPL(pmc_ssram_telemetry_get_pmc_info);
 
 static int pmc_ssram_telemetry_probe(struct pci_dev *pcidev, const struct pci_device_id *id)
 {
+	const struct ssram_type *ssram_type;
+	enum resource_method method;
 	int ret;
 
+	ssram_type = (const struct ssram_type *)id->driver_data;
+	if (!ssram_type) {
+		dev_dbg(&pcidev->dev, "missing driver data\n");
+		ret = -EINVAL;
+		goto probe_finish;
+	}
+
+	method = ssram_type->method;
 
 	ret = pcim_enable_device(pcidev);
 	if (ret) {
@@ -167,12 +203,10 @@ static int pmc_ssram_telemetry_probe(struct pci_dev *pcidev, const struct pci_de
 		goto probe_finish;
 	}
 
-	ret = pmc_ssram_telemetry_get_pmc(pcidev, PMC_IDX_MAIN, 0);
-	if (ret)
-		goto probe_finish;
-
-	pmc_ssram_telemetry_get_pmc(pcidev, PMC_IDX_IOE, SSRAM_IOE_OFFSET);
-	pmc_ssram_telemetry_get_pmc(pcidev, PMC_IDX_PCH, SSRAM_PCH_OFFSET);
+	if (method == RES_METHOD_PCI)
+		ret = pmc_ssram_telemetry_pci_init(pcidev);
+	else
+		ret = -EINVAL;
 
 probe_finish:
 	/*
@@ -185,13 +219,20 @@ static int pmc_ssram_telemetry_probe(struct pci_dev *pcidev, const struct pci_de
 }
 
 static const struct pci_device_id pmc_ssram_telemetry_pci_ids[] = {
-	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PMC_DEVID_MTL_SOCM) },
-	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PMC_DEVID_ARL_SOCS) },
-	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PMC_DEVID_ARL_SOCM) },
-	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PMC_DEVID_LNL_SOCM) },
-	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PMC_DEVID_PTL_PCDH) },
-	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PMC_DEVID_PTL_PCDP) },
-	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PMC_DEVID_WCL_PCDN) },
+	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PMC_DEVID_MTL_SOCM),
+		.driver_data = (kernel_ulong_t)&pci_main },
+	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PMC_DEVID_ARL_SOCS),
+		.driver_data = (kernel_ulong_t)&pci_main },
+	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PMC_DEVID_ARL_SOCM),
+		.driver_data = (kernel_ulong_t)&pci_main },
+	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PMC_DEVID_LNL_SOCM),
+		.driver_data = (kernel_ulong_t)&pci_main },
+	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PMC_DEVID_PTL_PCDH),
+		.driver_data = (kernel_ulong_t)&pci_main },
+	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PMC_DEVID_PTL_PCDP),
+		.driver_data = (kernel_ulong_t)&pci_main },
+	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PMC_DEVID_WCL_PCDN),
+		.driver_data = (kernel_ulong_t)&pci_main },
 	{ }
 };
 MODULE_DEVICE_TABLE(pci, pmc_ssram_telemetry_pci_ids);
Signature · 1 line
2.43.0
maintainer
#25 lore raw

Re: [PATCH 18/22] platform/x86/intel/pmc/ssram: Add PCI platform data

Quoted 66 lines · David E. Box

Add per-device platform data for SSRAM telemetry PCI IDs and route probe through a method selector driven by id->driver_data.

This is a preparatory refactor for follow-on discovery methods while preserving current behavior: all supported IDs continue to use the PCI initialization path.

---
 .../platform/x86/intel/pmc/ssram_telemetry.c  | 69 +++++++++++++++----
 1 file changed, 55 insertions(+), 14 deletions(-)
drivers/platform/x86/intel/pmc/ssram_telemetry.c +27 -1
index 75a80a74a069..7db98037c521 100644
@@ -24,6 +24,18 @@
 
 DEFINE_FREE(pmc_ssram_telemetry_iounmap, void __iomem *, if (_T) iounmap(_T))
 
+enum resource_method {
+	RES_METHOD_PCI,
+};
+
+struct ssram_type {
+	enum resource_method method;
+};
+
+static const struct ssram_type pci_main = {
+	.method = RES_METHOD_PCI,
+};
+
 static struct pmc_ssram_telemetry pmc_ssram_telems[3];
 static bool device_probed;
 
@@ -81,7 +93,7 @@ pmc_ssram_telemetry_add_pmt(struct pci_dev *pcidev, u64 ssram_base, void __iomem
 }
 
 static int
-pmc_ssram_telemetry_get_pmc(struct pci_dev *pcidev, unsigned int pmc_idx, u32 offset)
+pmc_ssram_telemetry_get_pmc_pci(struct pci_dev *pcidev, unsigned int pmc_idx, u32 offset)
 {
 	void __iomem __free(pmc_ssram_telemetry_iounmap) *tmp_ssram = NULL;
 	void __iomem __free(pmc_ssram_telemetry_iounmap) *ssram = NULL;
@@ -116,6 +128,20 @@ pmc_ssram_telemetry_get_pmc(struct pci_dev *pcidev, unsigned int pmc_idx, u32 of
 	return pmc_ssram_telemetry_add_pmt(pcidev, ssram_base, ssram);
 }
 
+static int pmc_ssram_telemetry_pci_init(struct pci_dev *pcidev)
+{
+	int ret;
+
+	ret = pmc_ssram_telemetry_get_pmc_pci(pcidev, PMC_IDX_MAIN, 0);
+	if (ret)
+		return ret;
+
+	pmc_ssram_telemetry_get_pmc_pci(pcidev, PMC_IDX_IOE, SSRAM_IOE_OFFSET);
+	pmc_ssram_telemetry_get_pmc_pci(pcidev, PMC_IDX_PCH, SSRAM_PCH_OFFSET);
+
+	return ret;
+}
+
 /**
  * pmc_ssram_telemetry_get_pmc_info() - Get a PMC devid and base_addr information
  * @pmc_idx:               Index of the PMC

drivers/platform/x86/intel/pmc/ssram_telemetry.c EXPORT_SYMBOL_GPL(pmc_ssram_telemetry_get_pmc_info); · line 193

Quoted 10 lines
drivers/platform/x86/intel/pmc/ssram_telemetry.c +5 -0
@@ -158,8 +184,18 @@ EXPORT_SYMBOL_GPL(pmc_ssram_telemetry_get_pmc_info);
 
 static int pmc_ssram_telemetry_probe(struct pci_dev *pcidev, const struct pci_device_id *id)
 {
+	const struct ssram_type *ssram_type;
+	enum resource_method method;
 	int ret;
 
+	ssram_type = (const struct ssram_type *)id->driver_data;
+	if (!ssram_type) {
+		dev_dbg(&pcidev->dev, "missing driver data\n");

Add #include.

Quoted 54 lines
drivers/platform/x86/intel/pmc/ssram_telemetry.c +23 -13
+		ret = -EINVAL;
+		goto probe_finish;
+	}
+
+	method = ssram_type->method;
 
 	ret = pcim_enable_device(pcidev);
 	if (ret) {
@@ -167,12 +203,10 @@ static int pmc_ssram_telemetry_probe(struct pci_dev *pcidev, const struct pci_de
 		goto probe_finish;
 	}
 
-	ret = pmc_ssram_telemetry_get_pmc(pcidev, PMC_IDX_MAIN, 0);
-	if (ret)
-		goto probe_finish;
-
-	pmc_ssram_telemetry_get_pmc(pcidev, PMC_IDX_IOE, SSRAM_IOE_OFFSET);
-	pmc_ssram_telemetry_get_pmc(pcidev, PMC_IDX_PCH, SSRAM_PCH_OFFSET);
+	if (method == RES_METHOD_PCI)
+		ret = pmc_ssram_telemetry_pci_init(pcidev);
+	else
+		ret = -EINVAL;
 
 probe_finish:
 	/*
@@ -185,13 +219,20 @@ static int pmc_ssram_telemetry_probe(struct pci_dev *pcidev, const struct pci_de
 }
 
 static const struct pci_device_id pmc_ssram_telemetry_pci_ids[] = {
-	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PMC_DEVID_MTL_SOCM) },
-	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PMC_DEVID_ARL_SOCS) },
-	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PMC_DEVID_ARL_SOCM) },
-	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PMC_DEVID_LNL_SOCM) },
-	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PMC_DEVID_PTL_PCDH) },
-	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PMC_DEVID_PTL_PCDP) },
-	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PMC_DEVID_WCL_PCDN) },
+	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PMC_DEVID_MTL_SOCM),
+		.driver_data = (kernel_ulong_t)&pci_main },
+	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PMC_DEVID_ARL_SOCS),
+		.driver_data = (kernel_ulong_t)&pci_main },
+	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PMC_DEVID_ARL_SOCM),
+		.driver_data = (kernel_ulong_t)&pci_main },
+	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PMC_DEVID_LNL_SOCM),
+		.driver_data = (kernel_ulong_t)&pci_main },
+	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PMC_DEVID_PTL_PCDH),
+		.driver_data = (kernel_ulong_t)&pci_main },
+	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PMC_DEVID_PTL_PCDP),
+		.driver_data = (kernel_ulong_t)&pci_main },
+	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PMC_DEVID_WCL_PCDN),
+		.driver_data = (kernel_ulong_t)&pci_main },
 	{ }
 };
 MODULE_DEVICE_TABLE(pci, pmc_ssram_telemetry_pci_ids);
Signature · 1 line
 i.
author maintainer
#26 lore raw

PATCH 19/22 platform/x86/intel/pmc/ssram: Refactor memory barrier for reentrant probe

In reply to David E. Box

From: Xi Pardee <[email protected]>

Switch the readiness synchronization from a global device_probed flag to per-index devid publication. This is required because a subsequent patch makes probe reentrant, so a single global flag can no longer reliably signal completion.

---
 .../platform/x86/intel/pmc/ssram_telemetry.c  | 34 ++++++++-----------
 1 file changed, 14 insertions(+), 20 deletions(-)
drivers/platform/x86/intel/pmc/ssram_telemetry.c +14 -20
index 7db98037c521..246efdcf6950 100644
@@ -37,7 +37,6 @@ static const struct ssram_type pci_main = {
 };
 
 static struct pmc_ssram_telemetry pmc_ssram_telems[3];
-static bool device_probed;
 
 static inline u64 get_base(void __iomem *addr, u32 offset)
 {
@@ -52,8 +51,13 @@ static void pmc_ssram_get_devid_pwrmbase(void __iomem *ssram, unsigned int pmc_i
 	pwrm_base = get_base(ssram, SSRAM_PWRM_OFFSET);
 	devid = readw(ssram + SSRAM_DEVID_OFFSET);
 
-	pmc_ssram_telems[pmc_idx].devid = devid;
 	pmc_ssram_telems[pmc_idx].base_addr = pwrm_base;
+	/*
+	 * Memory barrier is used to ensure the correct write order between base_addr
+	 * and devid.
+	 */
+	smp_wmb();
+	pmc_ssram_telems[pmc_idx].devid = devid;
 }
 
 static int
@@ -151,32 +155,28 @@ static int pmc_ssram_telemetry_pci_init(struct pci_dev *pcidev)
  * * 0           - Success
  * * -EAGAIN     - Probe function has not finished yet. Try again.
  * * -EINVAL     - Invalid pmc_idx
- * * -ENODEV     - PMC device is not available
  */
 int pmc_ssram_telemetry_get_pmc_info(unsigned int pmc_idx,
 				     struct pmc_ssram_telemetry *pmc_ssram_telemetry)
 {
+	if (pmc_idx >= MAX_NUM_PMC)
+		return -EINVAL;
+
 	/*
 	 * PMCs are discovered in probe function. If this function is called before
-	 * probe function complete, the result would be invalid. Use device_probed
-	 * variable to avoid this case. Return -EAGAIN to inform the consumer to call
+	 * probe function complete, the result would be invalid. Use devid to avoid
+	 * this case. Return -EAGAIN to inform the consumer to call
 	 * again later.
 	 */
-	if (!device_probed)
+	if (!pmc_ssram_telems[pmc_idx].devid)
 		return -EAGAIN;
 
+	pmc_ssram_telemetry->devid = pmc_ssram_telems[pmc_idx].devid;
 	/*
 	 * Memory barrier is used to ensure the correct read order between
-	 * device_probed variable and PMC info.
+	 * devid variable and base_addr.
 	 */
 	smp_rmb();
-	if (pmc_idx >= MAX_NUM_PMC)
-		return -EINVAL;
-
-	if (!pmc_ssram_telems[pmc_idx].devid)
-		return -ENODEV;
-
-	pmc_ssram_telemetry->devid = pmc_ssram_telems[pmc_idx].devid;
 	pmc_ssram_telemetry->base_addr = pmc_ssram_telems[pmc_idx].base_addr;
 	return 0;
 }
@@ -209,12 +209,6 @@ static int pmc_ssram_telemetry_probe(struct pci_dev *pcidev, const struct pci_de
 		ret = -EINVAL;
 
 probe_finish:
-	/*
-	 * Memory barrier is used to ensure the correct write order between PMC info
-	 * and device_probed variable.
-	 */
-	smp_wmb();
-	device_probed = true;
 	return ret;
 }
 
Signature · 1 line
2.43.0
maintainer
#27 lore raw

Re: [PATCH 19/22] platform/x86/intel/pmc/ssram: Refactor memory barrier for reentrant probe

Quoted 4 lines · David E. Box

From: Xi Pardee <[email protected]>

Switch the readiness synchronization from a global device_probed flag to per-index devid publication.

It would be nice if you could expand the synchronization explanation a bit. It's mostly in the comments below but it wouldn't hurt to add it here as well.

Quoted 79 lines

This is required because a subsequent patch
makes probe reentrant, so a single global flag can no longer reliably signal completion.

---
 .../platform/x86/intel/pmc/ssram_telemetry.c  | 34 ++++++++-----------
 1 file changed, 14 insertions(+), 20 deletions(-)
drivers/platform/x86/intel/pmc/ssram_telemetry.c +14 -14
index 7db98037c521..246efdcf6950 100644
@@ -37,7 +37,6 @@ static const struct ssram_type pci_main = {
 };
 
 static struct pmc_ssram_telemetry pmc_ssram_telems[3];
-static bool device_probed;
 
 static inline u64 get_base(void __iomem *addr, u32 offset)
 {
@@ -52,8 +51,13 @@ static void pmc_ssram_get_devid_pwrmbase(void __iomem *ssram, unsigned int pmc_i
 	pwrm_base = get_base(ssram, SSRAM_PWRM_OFFSET);
 	devid = readw(ssram + SSRAM_DEVID_OFFSET);
 
-	pmc_ssram_telems[pmc_idx].devid = devid;
 	pmc_ssram_telems[pmc_idx].base_addr = pwrm_base;
+	/*
+	 * Memory barrier is used to ensure the correct write order between base_addr
+	 * and devid.
+	 */
+	smp_wmb();
+	pmc_ssram_telems[pmc_idx].devid = devid;
 }
 
 static int
@@ -151,32 +155,28 @@ static int pmc_ssram_telemetry_pci_init(struct pci_dev *pcidev)
  * * 0           - Success
  * * -EAGAIN     - Probe function has not finished yet. Try again.
  * * -EINVAL     - Invalid pmc_idx
- * * -ENODEV     - PMC device is not available
  */
 int pmc_ssram_telemetry_get_pmc_info(unsigned int pmc_idx,
 				     struct pmc_ssram_telemetry *pmc_ssram_telemetry)
 {
+	if (pmc_idx >= MAX_NUM_PMC)
+		return -EINVAL;
+
 	/*
 	 * PMCs are discovered in probe function. If this function is called before
-	 * probe function complete, the result would be invalid. Use device_probed
-	 * variable to avoid this case. Return -EAGAIN to inform the consumer to call
+	 * probe function complete, the result would be invalid. Use devid to avoid
+	 * this case. Return -EAGAIN to inform the consumer to call
 	 * again later.
 	 */
-	if (!device_probed)
+	if (!pmc_ssram_telems[pmc_idx].devid)
 		return -EAGAIN;
 
+	pmc_ssram_telemetry->devid = pmc_ssram_telems[pmc_idx].devid;
 	/*
 	 * Memory barrier is used to ensure the correct read order between
-	 * device_probed variable and PMC info.
+	 * devid variable and base_addr.
 	 */
 	smp_rmb();
-	if (pmc_idx >= MAX_NUM_PMC)
-		return -EINVAL;
-
-	if (!pmc_ssram_telems[pmc_idx].devid)
-		return -ENODEV;
-
-	pmc_ssram_telemetry->devid = pmc_ssram_telems[pmc_idx].devid;
 	pmc_ssram_telemetry->base_addr = pmc_ssram_telems[pmc_idx].base_addr;
 	return 0;
 }

drivers/platform/x86/intel/pmc/ssram_telemetry.c static int pmc_ssram_telemetry_probe(struct pci_dev *pcidev, const struct pci_de · line 211

Quoted 3 lines
drivers/platform/x86/intel/pmc/ssram_telemetry.c +0 -0
@@ -209,12 +209,6 @@ static int pmc_ssram_telemetry_probe(struct pci_dev *pcidev, const struct pci_de
 		ret = -EINVAL;
 
 probe_finish:

This label becomes pointless after the removal and the gotoers should just return directly.

Quoted 7 lines
drivers/platform/x86/intel/pmc/ssram_telemetry.c +0 -6
-	/*
-	 * Memory barrier is used to ensure the correct write order between PMC info
-	 * and device_probed variable.
-	 */
-	smp_wmb();
-	device_probed = true;
 	return ret;
Signature · 1 line
 i.
author maintainer
#28 lore raw

PATCH 20/22 platform/x86/intel/pmc/ssram: Add ACPI discovery scaffolding

In reply to David E. Box

Prepare the SSRAM telemetry driver for ACPI-based discovery by adding the common initialization path and selection framework needed for resource discovery from the ACPI companion device.

At this stage, existing supported devices continue to use the PCI path. This change lays the groundwork for follow-on patches that wire platform IDs to the ACPI policy path.

---
 .../platform/x86/intel/pmc/ssram_telemetry.c  | 79 +++++++++++++++++++
 1 file changed, 79 insertions(+)
drivers/platform/x86/intel/pmc/ssram_telemetry.c +79 -0
index 246efdcf6950..b937ebb2322f 100644
@@ -5,6 +5,7 @@
  * Copyright (c) 2023, Intel Corporation.
  */
 
+#include <linux/acpi.h>
 #include <linux/cleanup.h>
 #include <linux/intel_vsec.h>
 #include <linux/pci.h>
@@ -26,14 +27,17 @@ DEFINE_FREE(pmc_ssram_telemetry_iounmap, void __iomem *, if (_T) iounmap(_T))
 
 enum resource_method {
 	RES_METHOD_PCI,
+	RES_METHOD_ACPI,
 };
 
 struct ssram_type {
 	enum resource_method method;
+	enum pmc_index p_index;
 };
 
 static const struct ssram_type pci_main = {
 	.method = RES_METHOD_PCI,
+	.p_index = PMC_IDX_MAIN,
 };
 
 static struct pmc_ssram_telemetry pmc_ssram_telems[3];
@@ -146,6 +150,76 @@ static int pmc_ssram_telemetry_pci_init(struct pci_dev *pcidev)
 	return ret;
 }
 
+static int pmc_ssram_telemetry_get_pmc_acpi(struct pci_dev *pcidev,  unsigned int pmc_idx)
+{
+	void __iomem __free(pmc_ssram_telemetry_iounmap) * ssram = NULL;
+	u64 ssram_base;
+
+	ssram_base = pci_resource_start(pcidev, 0);
+	if (!ssram_base)
+		return -ENODEV;
+
+	ssram = ioremap(ssram_base, SSRAM_HDR_SIZE);
+	if (!ssram)
+		return -ENOMEM;
+
+	pmc_ssram_get_devid_pwrmbase(ssram, pmc_idx);
+
+	return 0;
+}
+
+static int pmc_ssram_telemetry_acpi_init(struct pci_dev *pcidev,
+					 enum pmc_index index)
+{
+	struct acpi_buffer buf = { ACPI_ALLOCATE_BUFFER, NULL };
+	acpi_handle handle = ACPI_HANDLE(&pcidev->dev);
+	struct intel_vsec_header header;
+	struct intel_vsec_header *headers[2] = { &header, NULL };
+	struct intel_vsec_platform_info info = { };
+	union acpi_object *dsd;
+	u32 (*acpi_disc)[4];
+	acpi_status status;
+	int ret;
+
+	if (!handle)
+		return -ENODEV;
+
+	status = acpi_evaluate_object(handle, "_DSD", NULL, &buf);
+	if (ACPI_FAILURE(status))
+		return -ENODEV;
+
+	dsd = pmc_find_telem_guid(buf.pointer);
+	if (!dsd) {
+		ret = -ENODEV;
+		goto cleanup_acpi_buf;
+	}
+
+	ret = pmc_parse_telem_dsd(dsd, &header, &acpi_disc);
+	if (ret)
+		goto cleanup_acpi_buf;
+
+	info.headers = headers;
+	info.caps = VSEC_CAP_TELEMETRY;
+	info.acpi_disc = acpi_disc;
+	info.src = INTEL_VSEC_DISC_ACPI;
+
+	/* This is an ACPI companion device. PCI BAR will be used for base addr. */
+	info.base_addr = 0;
+
+	ret = intel_vsec_register(&pcidev->dev, &info);
+	if (ret)
+		goto cleanup_acpi_disc;
+
+	ret = pmc_ssram_telemetry_get_pmc_acpi(pcidev, index);
+
+cleanup_acpi_disc:
+	kfree(acpi_disc);
+cleanup_acpi_buf:
+	ACPI_FREE(buf.pointer);
+
+	return ret;
+}
+
 /**
  * pmc_ssram_telemetry_get_pmc_info() - Get a PMC devid and base_addr information
  * @pmc_idx:               Index of the PMC
@@ -186,6 +260,7 @@ static int pmc_ssram_telemetry_probe(struct pci_dev *pcidev, const struct pci_de
 {
 	const struct ssram_type *ssram_type;
 	enum resource_method method;
+	enum pmc_index index;
 	int ret;
 
 	ssram_type = (const struct ssram_type *)id->driver_data;
@@ -196,6 +271,7 @@ static int pmc_ssram_telemetry_probe(struct pci_dev *pcidev, const struct pci_de
 	}
 
 	method = ssram_type->method;
+	index = ssram_type->p_index;
 
 	ret = pcim_enable_device(pcidev);
 	if (ret) {
@@ -205,6 +281,8 @@ static int pmc_ssram_telemetry_probe(struct pci_dev *pcidev, const struct pci_de
 
 	if (method == RES_METHOD_PCI)
 		ret = pmc_ssram_telemetry_pci_init(pcidev);
+	else if (method == RES_METHOD_ACPI)
+		ret = pmc_ssram_telemetry_acpi_init(pcidev, index);
 	else
 		ret = -EINVAL;
 
@@ -238,6 +316,7 @@ static struct pci_driver pmc_ssram_telemetry_driver = {
 };
 module_pci_driver(pmc_ssram_telemetry_driver);
 
+MODULE_IMPORT_NS("INTEL_PMC_CORE");
 MODULE_IMPORT_NS("INTEL_VSEC");
 MODULE_AUTHOR("Xi Pardee <[email protected]>");
 MODULE_DESCRIPTION("Intel PMC SSRAM Telemetry driver");
Signature · 1 line
2.43.0
maintainer
#29 lore raw

Re: [PATCH 20/22] platform/x86/intel/pmc/ssram: Add ACPI discovery scaffolding

Quoted 45 lines · David E. Box

Prepare the SSRAM telemetry driver for ACPI-based discovery by adding the common initialization path and selection framework needed for resource discovery from the ACPI companion device.

At this stage, existing supported devices continue to use the PCI path. This change lays the groundwork for follow-on patches that wire platform IDs to the ACPI policy path.

---
 .../platform/x86/intel/pmc/ssram_telemetry.c  | 79 +++++++++++++++++++
 1 file changed, 79 insertions(+)
drivers/platform/x86/intel/pmc/ssram_telemetry.c +4 -0
index 246efdcf6950..b937ebb2322f 100644
@@ -5,6 +5,7 @@
  * Copyright (c) 2023, Intel Corporation.
  */
 
+#include <linux/acpi.h>
 #include <linux/cleanup.h>
 #include <linux/intel_vsec.h>
 #include <linux/pci.h>
@@ -26,14 +27,17 @@ DEFINE_FREE(pmc_ssram_telemetry_iounmap, void __iomem *, if (_T) iounmap(_T))
 
 enum resource_method {
 	RES_METHOD_PCI,
+	RES_METHOD_ACPI,
 };
 
 struct ssram_type {
 	enum resource_method method;
+	enum pmc_index p_index;
 };
 
 static const struct ssram_type pci_main = {
 	.method = RES_METHOD_PCI,
+	.p_index = PMC_IDX_MAIN,
 };
 
 static struct pmc_ssram_telemetry pmc_ssram_telems[3];

drivers/platform/x86/intel/pmc/ssram_telemetry.c static int pmc_ssram_telemetry_pci_init(struct pci_dev *pcidev) · line 155

Quoted 6 lines
drivers/platform/x86/intel/pmc/ssram_telemetry.c +3 -0
@@ -146,6 +150,76 @@ static int pmc_ssram_telemetry_pci_init(struct pci_dev *pcidev)
 	return ret;
 }
 
+static int pmc_ssram_telemetry_get_pmc_acpi(struct pci_dev *pcidev,  unsigned int pmc_idx)
+{
+	void __iomem __free(pmc_ssram_telemetry_iounmap) * ssram = NULL;

__free() ... = NULL is a bad pattern as explained in the long comment in cleanup.h. The variable should be declared right at site of assignment.

It's not problem in this case but it is stick to the safer pattern.

Quoted 53 lines
drivers/platform/x86/intel/pmc/ssram_telemetry.c +53 -0
+	u64 ssram_base;
+
+	ssram_base = pci_resource_start(pcidev, 0);
+	if (!ssram_base)
+		return -ENODEV;
+
+	ssram = ioremap(ssram_base, SSRAM_HDR_SIZE);
+	if (!ssram)
+		return -ENOMEM;
+
+	pmc_ssram_get_devid_pwrmbase(ssram, pmc_idx);
+
+	return 0;
+}
+
+static int pmc_ssram_telemetry_acpi_init(struct pci_dev *pcidev,
+					 enum pmc_index index)
+{
+	struct acpi_buffer buf = { ACPI_ALLOCATE_BUFFER, NULL };
+	acpi_handle handle = ACPI_HANDLE(&pcidev->dev);
+	struct intel_vsec_header header;
+	struct intel_vsec_header *headers[2] = { &header, NULL };
+	struct intel_vsec_platform_info info = { };
+	union acpi_object *dsd;
+	u32 (*acpi_disc)[4];
+	acpi_status status;
+	int ret;
+
+	if (!handle)
+		return -ENODEV;
+
+	status = acpi_evaluate_object(handle, "_DSD", NULL, &buf);
+	if (ACPI_FAILURE(status))
+		return -ENODEV;
+
+	dsd = pmc_find_telem_guid(buf.pointer);
+	if (!dsd) {
+		ret = -ENODEV;
+		goto cleanup_acpi_buf;
+	}
+
+	ret = pmc_parse_telem_dsd(dsd, &header, &acpi_disc);
+	if (ret)
+		goto cleanup_acpi_buf;
+
+	info.headers = headers;
+	info.caps = VSEC_CAP_TELEMETRY;
+	info.acpi_disc = acpi_disc;
+	info.src = INTEL_VSEC_DISC_ACPI;
+
+	/* This is an ACPI companion device. PCI BAR will be used for base addr. */
+	info.base_addr = 0;
+

drivers/platform/x86/intel/pmc/ssram_telemetry.c static int pmc_ssram_telemetry_pci_init(struct pci_dev *pcidev) · line 218

Quoted 10 lines
drivers/platform/x86/intel/pmc/ssram_telemetry.c +10 -0
+	ret = intel_vsec_register(&pcidev->dev, &info);
+	if (ret)
+		goto cleanup_acpi_disc;
+
+	ret = pmc_ssram_telemetry_get_pmc_acpi(pcidev, index);
+
+cleanup_acpi_disc:
+	kfree(acpi_disc);
+cleanup_acpi_buf:
+	ACPI_FREE(buf.pointer);

kfree() + __free() as mentioned to some other patch.

Quoted 41 lines
drivers/platform/x86/intel/pmc/ssram_telemetry.c +9 -0
+
+	return ret;
+}
+
 /**
  * pmc_ssram_telemetry_get_pmc_info() - Get a PMC devid and base_addr information
  * @pmc_idx:               Index of the PMC
@@ -186,6 +260,7 @@ static int pmc_ssram_telemetry_probe(struct pci_dev *pcidev, const struct pci_de
 {
 	const struct ssram_type *ssram_type;
 	enum resource_method method;
+	enum pmc_index index;
 	int ret;
 
 	ssram_type = (const struct ssram_type *)id->driver_data;
@@ -196,6 +271,7 @@ static int pmc_ssram_telemetry_probe(struct pci_dev *pcidev, const struct pci_de
 	}
 
 	method = ssram_type->method;
+	index = ssram_type->p_index;
 
 	ret = pcim_enable_device(pcidev);
 	if (ret) {
@@ -205,6 +281,8 @@ static int pmc_ssram_telemetry_probe(struct pci_dev *pcidev, const struct pci_de
 
 	if (method == RES_METHOD_PCI)
 		ret = pmc_ssram_telemetry_pci_init(pcidev);
+	else if (method == RES_METHOD_ACPI)
+		ret = pmc_ssram_telemetry_acpi_init(pcidev, index);
 	else
 		ret = -EINVAL;
 
@@ -238,6 +316,7 @@ static struct pci_driver pmc_ssram_telemetry_driver = {
 };
 module_pci_driver(pmc_ssram_telemetry_driver);
 
+MODULE_IMPORT_NS("INTEL_PMC_CORE");
 MODULE_IMPORT_NS("INTEL_VSEC");
 MODULE_AUTHOR("Xi Pardee <[email protected]>");
 MODULE_DESCRIPTION("Intel PMC SSRAM Telemetry driver");
Signature · 1 line
 i.
author maintainer
#30 lore raw

PATCH 21/22 platform/x86/intel/pmc/ssram: Make PMT registration optional

In reply to David E. Box

The SSRAM telemetry driver extracts essential PMC device ID and power management base address information that intel_pmc_core depends on for core functionality. PMT registration failure should not prevent this critical data from being available, as it would break intel_pmc_core operation entirely.

Change the behavior to log a warning when PMT registration fails but continue with successful driver initialization, ensuring the primary telemetry data remains accessible to dependent drivers.

---
 drivers/platform/x86/intel/pmc/ssram_telemetry.c | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)
drivers/platform/x86/intel/pmc/ssram_telemetry.c +8 -3
index b937ebb2322f..12b7c1299c2f 100644
@@ -106,6 +106,7 @@ pmc_ssram_telemetry_get_pmc_pci(struct pci_dev *pcidev, unsigned int pmc_idx, u3
 	void __iomem __free(pmc_ssram_telemetry_iounmap) *tmp_ssram = NULL;
 	void __iomem __free(pmc_ssram_telemetry_iounmap) *ssram = NULL;
 	u64 ssram_base;
+	int ret;
 
 	ssram_base = pci_resource_start(pcidev, 0);
 	tmp_ssram = ioremap(ssram_base, SSRAM_HDR_SIZE);
@@ -133,7 +134,11 @@ pmc_ssram_telemetry_get_pmc_pci(struct pci_dev *pcidev, unsigned int pmc_idx, u3
 	pmc_ssram_get_devid_pwrmbase(ssram, pmc_idx);
 
 	/* Find and register and PMC telemetry entries */
-	return pmc_ssram_telemetry_add_pmt(pcidev, ssram_base, ssram);
+	ret = pmc_ssram_telemetry_add_pmt(pcidev, ssram_base, ssram);
+	if (ret)
+		dev_warn(&pcidev->dev, "could not register PMT\n");
+
+	return 0;
 }
 
 static int pmc_ssram_telemetry_pci_init(struct pci_dev *pcidev)
@@ -208,12 +213,12 @@ static int pmc_ssram_telemetry_acpi_init(struct pci_dev *pcidev,
 
 	ret = intel_vsec_register(&pcidev->dev, &info);
 	if (ret)
-		goto cleanup_acpi_disc;
+		dev_warn(&pcidev->dev, "could not register PMT\n");
 
 	ret = pmc_ssram_telemetry_get_pmc_acpi(pcidev, index);
 
-cleanup_acpi_disc:
 	kfree(acpi_disc);
+
 cleanup_acpi_buf:
 	ACPI_FREE(buf.pointer);
 
Signature · 1 line
2.43.0
maintainer
#31 lore raw

Re: [PATCH 21/22] platform/x86/intel/pmc/ssram: Make PMT registration optional

Quoted 4 lines · David E. Box

The SSRAM telemetry driver extracts essential PMC device ID and power management base address information that intel_pmc_core depends on for core functionality. PMT registration failure should not prevent this critical data from being available, as it would break intel_pmc_core operation

Are you missing a "not" here? I find the entire sentence hard to understand.

Quoted 52 lines

entirely.

Change the behavior to log a warning when PMT registration fails but continue with successful driver initialization, ensuring the primary telemetry data remains accessible to dependent drivers.

---
 drivers/platform/x86/intel/pmc/ssram_telemetry.c | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)
drivers/platform/x86/intel/pmc/ssram_telemetry.c +8 -3
index b937ebb2322f..12b7c1299c2f 100644
@@ -106,6 +106,7 @@ pmc_ssram_telemetry_get_pmc_pci(struct pci_dev *pcidev, unsigned int pmc_idx, u3
 	void __iomem __free(pmc_ssram_telemetry_iounmap) *tmp_ssram = NULL;
 	void __iomem __free(pmc_ssram_telemetry_iounmap) *ssram = NULL;
 	u64 ssram_base;
+	int ret;
 
 	ssram_base = pci_resource_start(pcidev, 0);
 	tmp_ssram = ioremap(ssram_base, SSRAM_HDR_SIZE);
@@ -133,7 +134,11 @@ pmc_ssram_telemetry_get_pmc_pci(struct pci_dev *pcidev, unsigned int pmc_idx, u3
 	pmc_ssram_get_devid_pwrmbase(ssram, pmc_idx);
 
 	/* Find and register and PMC telemetry entries */
-	return pmc_ssram_telemetry_add_pmt(pcidev, ssram_base, ssram);
+	ret = pmc_ssram_telemetry_add_pmt(pcidev, ssram_base, ssram);
+	if (ret)
+		dev_warn(&pcidev->dev, "could not register PMT\n");
+
+	return 0;
 }
 
 static int pmc_ssram_telemetry_pci_init(struct pci_dev *pcidev)
@@ -208,12 +213,12 @@ static int pmc_ssram_telemetry_acpi_init(struct pci_dev *pcidev,
 
 	ret = intel_vsec_register(&pcidev->dev, &info);
 	if (ret)
-		goto cleanup_acpi_disc;
+		dev_warn(&pcidev->dev, "could not register PMT\n");
 
 	ret = pmc_ssram_telemetry_get_pmc_acpi(pcidev, index);
 
-cleanup_acpi_disc:
 	kfree(acpi_disc);
+
 cleanup_acpi_buf:
 	ACPI_FREE(buf.pointer);
 
Signature · 1 line
 i.
author maintainer
#32 lore raw

PATCH 22/22 platform/x86/intel/pmc: Add NVL PCI IDs for SSRAM telemetry discovery

In reply to David E. Box

Add Nova Lake S PMC device IDs to enable binding of the SSRAM telemetry driver on NVL platforms, and map them to the ACPI-based discovery policy.

---
 drivers/platform/x86/intel/pmc/core.h            |  5 +++++
 drivers/platform/x86/intel/pmc/ssram_telemetry.c | 16 ++++++++++++++++
 2 files changed, 21 insertions(+)
drivers/platform/x86/intel/pmc/core.h +5 -0
index 284aced99f72..57557ad7d43b 100644
@@ -329,6 +329,11 @@ enum ppfear_regs {
 #define PMC_DEVID_MTL_IOEP	0x7ecf
 #define PMC_DEVID_MTL_IOEM	0x7ebf
 
+/* NVL */
+#define PMC_DEVID_NVL_PCDH	0xd37e
+#define PMC_DEVID_NVL_PCDS	0xd47e
+#define PMC_DEVID_NVL_PCHS	0x6e27
+
 extern const char *pmc_lpm_modes[];
 
 struct pmc_bit_map {
drivers/platform/x86/intel/pmc/ssram_telemetry.c +16 -0
index 12b7c1299c2f..930b4a510c71 100644
@@ -40,6 +40,16 @@ static const struct ssram_type pci_main = {
 	.p_index = PMC_IDX_MAIN,
 };
 
+static const struct ssram_type acpi_main = {
+	.method = RES_METHOD_ACPI,
+	.p_index = PMC_IDX_MAIN,
+};
+
+static const struct ssram_type acpi_pch = {
+	.method = RES_METHOD_ACPI,
+	.p_index = PMC_IDX_PCH,
+};
+
 static struct pmc_ssram_telemetry pmc_ssram_telems[3];
 
 static inline u64 get_base(void __iomem *addr, u32 offset)
@@ -310,6 +320,12 @@ static const struct pci_device_id pmc_ssram_telemetry_pci_ids[] = {
 		.driver_data = (kernel_ulong_t)&pci_main },
 	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PMC_DEVID_WCL_PCDN),
 		.driver_data = (kernel_ulong_t)&pci_main },
+	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PMC_DEVID_NVL_PCDH),
+		.driver_data = (kernel_ulong_t)&acpi_main },
+	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PMC_DEVID_NVL_PCDS),
+		.driver_data = (kernel_ulong_t)&acpi_main },
+	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PMC_DEVID_NVL_PCHS),
+		.driver_data = (kernel_ulong_t)&acpi_pch },
 	{ }
 };
 MODULE_DEVICE_TABLE(pci, pmc_ssram_telemetry_pci_ids);
Signature · 1 line
2.43.0
#33 lore raw

✗ CI.checkpatch: warning for platform/x86/intel: Add ACPI PMT discovery support and enable NVL PMC telemetry

In reply to David E. Box
== Series Details ==

== Series Details ==

Series: platform/x86/intel: Add ACPI PMT discovery support and enable NVL PMC telemetry
URL : https://patchwork.freedesktop.org/series/163153/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master 1f57ba1afceae32108bd24770069f764d940a0e4
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit c6ad9fd2741bc94906ee853fc5bfcf93dd14a75b

Author: David E. Box <[email protected]>
Date:   Thu Mar 12 18:52:01 2026 -0700

platform/x86/intel/pmc: Add NVL PCI IDs for SSRAM telemetry discovery

Add Nova Lake S PMC device IDs to enable binding of the SSRAM telemetry driver on NVL platforms, and map them to the ACPI-based discovery policy.

+ /mt/dim checkpatch 29044d219ec91738869fef9d445adce5e31df374 drm-intel
66e85e74d93e platform/x86/intel/vsec: Refactor base_addr handling
b8ee9c75b28d platform/x86/intel/vsec: Make driver_data info const
8fe8d86c72aa platform/x86/intel/vsec: Decouple add/link helpers from PCI
-:12: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?) #12:
PCI-specific plumbing where it isn’t strictly required and rely on generic

total: 0 errors, 1 warnings, 0 checks, 64 lines checked
d6e7abba3f2d platform/x86/intel/vsec: Switch exported helpers from pci_dev to device 27a4e3ef33ea platform/x86/intel/vsec: Return real error codes from registration path ca083ee2b965 platform/x86/intel/vsec: Plumb ACPI PMT discovery tables through vsec 421a6832ed25 platform/x86/intel/pmt: Add pre/post decode hooks around header parsing bf475653263d platform/x86/intel/pmt/crashlog: Split init into pre-decode d4bb24f76133 platform/x86/intel/pmt/telemetry: Move overlap check to post-decode hook 3e6ec039cb06 platform/x86/intel/pmt: Move header decode into common helper a9a00c4f3404 platform/x86/intel/pmt: Pass discovery index instead of resource 4e5e6947e71e platform/x86/intel/pmt: Unify header fetch and add ACPI source e741fe7b4d3e platform/x86/intel/pmc: Add PMC SSRAM Kconfig description a62480cf193c platform/x86/intel/pmc: Add ACPI PWRM telemetry driver for Nova Lake S -:89: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #89:
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 277 lines checked
42c264b9edc0 platform/x86/intel/pmc/ssram: Rename probe and PCI ID table for consistency -:35: ERROR:MISSING_SENTINEL: missing sentinel in ID array
#35: FILE: drivers/platform/x86/intel/pmc/ssram_telemetry.c:186:
+static const struct pci_device_id pmc_ssram_telemetry_pci_ids[] = {
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PMC_DEVID_MTL_SOCM) },
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PMC_DEVID_ARL_SOCS) },
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PMC_DEVID_ARL_SOCM) },

total: 1 errors, 0 warnings, 0 checks, 35 lines checked
d3fe316e2ff2 platform/x86/intel/pmc/ssram: Use fixed-size static pmc array -:23: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0) #23: FILE: drivers/platform/x86/intel/pmc/ssram_telemetry.c:25:
DEFINE_FREE(pmc_ssram_telemetry_iounmap, void __iomem *, if (_T) iounmap(_T))
[...]
+static struct pmc_ssram_telemetry pmc_ssram_telems[3];

total: 0 errors, 1 warnings, 0 checks, 28 lines checked
d34f0306fb4b platform/x86/intel/pmc/ssram: Refactor DEVID/PWRMBASE extraction into helper 0fe34022f206 platform/x86/intel/pmc/ssram: Add PCI platform data
-:21: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0) #21: FILE: drivers/platform/x86/intel/pmc/ssram_telemetry.c:25:
DEFINE_FREE(pmc_ssram_telemetry_iounmap, void __iomem *, if (_T) iounmap(_T))
[...]
+enum resource_method {

total: 0 errors, 1 warnings, 0 checks, 107 lines checked
d199b85a74eb platform/x86/intel/pmc/ssram: Refactor memory barrier for reentrant probe 46cbd20ea62e platform/x86/intel/pmc/ssram: Add ACPI discovery scaffolding b4539a12438d platform/x86/intel/pmc/ssram: Make PMT registration optional c6ad9fd2741b platform/x86/intel/pmc: Add NVL PCI IDs for SSRAM telemetry discovery

#34 lore raw

✓ CI.KUnit: success for platform/x86/intel: Add ACPI PMT discovery support and enable NVL PMC telemetry

In reply to David E. Box
== Series Details ==

== Series Details ==

Series: platform/x86/intel: Add ACPI PMT discovery support and enable NVL PMC telemetry
URL : https://patchwork.freedesktop.org/series/163153/
State : success

== Summary ==

+ trap cleanup EXIT
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/xe/.kunitconfig [02:03:00] Configuring KUnit Kernel ...
Generating .config ...
Populating config with:

$ make ARCH=um O=.kunit olddefconfig
[02:03:05] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48
[02:03:35] Starting KUnit Kernel (1/1)...
[02:03:35] ============================================================
Running tests with:
$ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt
[02:03:35] ================== guc_buf (11 subtests) ===================
[02:03:35] [PASSED] test_smallest
[02:03:35] [PASSED] test_largest
[02:03:35] [PASSED] test_granular
[02:03:35] [PASSED] test_unique
[02:03:35] [PASSED] test_overlap
[02:03:35] [PASSED] test_reusable
[02:03:35] [PASSED] test_too_big
[02:03:35] [PASSED] test_flush
[02:03:35] [PASSED] test_lookup
[02:03:35] [PASSED] test_data
[02:03:35] [PASSED] test_class
[02:03:35] ===================== [PASSED] guc_buf =====================
[02:03:35] =================== guc_dbm (7 subtests) ===================
[02:03:35] [PASSED] test_empty
[02:03:35] [PASSED] test_default
[02:03:35] ======================== test_size  ========================
[02:03:35] [PASSED] 4
[02:03:35] [PASSED] 8
[02:03:35] [PASSED] 32
[02:03:35] [PASSED] 256
[02:03:35] ==================== [PASSED] test_size ====================
[02:03:35] ======================= test_reuse  ========================
[02:03:35] [PASSED] 4
[02:03:35] [PASSED] 8
[02:03:35] [PASSED] 32
[02:03:35] [PASSED] 256
[02:03:35] =================== [PASSED] test_reuse ====================
[02:03:35] =================== test_range_overlap  ====================
[02:03:35] [PASSED] 4
[02:03:35] [PASSED] 8
[02:03:35] [PASSED] 32
[02:03:35] [PASSED] 256
[02:03:35] =============== [PASSED] test_range_overlap ================
[02:03:35] =================== test_range_compact  ====================
[02:03:35] [PASSED] 4
[02:03:35] [PASSED] 8
[02:03:35] [PASSED] 32
[02:03:35] [PASSED] 256
[02:03:35] =============== [PASSED] test_range_compact ================
[02:03:35] ==================== test_range_spare  =====================
[02:03:35] [PASSED] 4
[02:03:35] [PASSED] 8
[02:03:35] [PASSED] 32
[02:03:35] [PASSED] 256
[02:03:35] ================ [PASSED] test_range_spare =================
[02:03:35] ===================== [PASSED] guc_dbm =====================
[02:03:35] =================== guc_idm (6 subtests) ===================
[02:03:35] [PASSED] bad_init
[02:03:35] [PASSED] no_init
[02:03:35] [PASSED] init_fini
[02:03:35] [PASSED] check_used
[02:03:35] [PASSED] check_quota
[02:03:35] [PASSED] check_all
[02:03:35] ===================== [PASSED] guc_idm =====================
[02:03:35] ================== no_relay (3 subtests) ===================
[02:03:35] [PASSED] xe_drops_guc2pf_if_not_ready
[02:03:35] [PASSED] xe_drops_guc2vf_if_not_ready
[02:03:35] [PASSED] xe_rejects_send_if_not_ready
[02:03:35] ==================== [PASSED] no_relay =====================
[02:03:35] ================== pf_relay (14 subtests) ==================
[02:03:35] [PASSED] pf_rejects_guc2pf_too_short
[02:03:35] [PASSED] pf_rejects_guc2pf_too_long
[02:03:35] [PASSED] pf_rejects_guc2pf_no_payload
[02:03:35] [PASSED] pf_fails_no_payload
[02:03:35] [PASSED] pf_fails_bad_origin
[02:03:35] [PASSED] pf_fails_bad_type
[02:03:35] [PASSED] pf_txn_reports_error
[02:03:35] [PASSED] pf_txn_sends_pf2guc
[02:03:35] [PASSED] pf_sends_pf2guc
[02:03:35] [SKIPPED] pf_loopback_nop
[02:03:35] [SKIPPED] pf_loopback_echo
[02:03:35] [SKIPPED] pf_loopback_fail
[02:03:35] [SKIPPED] pf_loopback_busy
[02:03:35] [SKIPPED] pf_loopback_retry
[02:03:35] ==================== [PASSED] pf_relay =====================
[02:03:35] ================== vf_relay (3 subtests) ===================
[02:03:35] [PASSED] vf_rejects_guc2vf_too_short
[02:03:35] [PASSED] vf_rejects_guc2vf_too_long
[02:03:35] [PASSED] vf_rejects_guc2vf_no_payload
[02:03:35] ==================== [PASSED] vf_relay =====================
[02:03:35] ================ pf_gt_config (9 subtests) =================
[02:03:35] [PASSED] fair_contexts_1vf
[02:03:35] [PASSED] fair_doorbells_1vf
[02:03:35] [PASSED] fair_ggtt_1vf
[02:03:35] ====================== fair_vram_1vf  ======================
[02:03:35] [PASSED] 3.50 GiB
[02:03:35] [PASSED] 11.5 GiB
[02:03:35] [PASSED] 15.5 GiB
[02:03:35] [PASSED] 31.5 GiB
[02:03:35] [PASSED] 63.5 GiB
[02:03:35] [PASSED] 1.91 GiB
[02:03:35] ================== [PASSED] fair_vram_1vf ==================
[02:03:35] ================ fair_vram_1vf_admin_only  =================
[02:03:35] [PASSED] 3.50 GiB
[02:03:35] [PASSED] 11.5 GiB
[02:03:35] [PASSED] 15.5 GiB
[02:03:35] [PASSED] 31.5 GiB
[02:03:35] [PASSED] 63.5 GiB
[02:03:35] [PASSED] 1.91 GiB
[02:03:35] ============ [PASSED] fair_vram_1vf_admin_only =============
[02:03:35] ====================== fair_contexts  ======================
[02:03:35] [PASSED] 1 VF
[02:03:35] [PASSED] 2 VFs
[02:03:35] [PASSED] 3 VFs
[02:03:35] [PASSED] 4 VFs
[02:03:35] [PASSED] 5 VFs
[02:03:35] [PASSED] 6 VFs
[02:03:35] [PASSED] 7 VFs
[02:03:35] [PASSED] 8 VFs
[02:03:35] [PASSED] 9 VFs
[02:03:35] [PASSED] 10 VFs
[02:03:35] [PASSED] 11 VFs
[02:03:35] [PASSED] 12 VFs
[02:03:35] [PASSED] 13 VFs
[02:03:35] [PASSED] 14 VFs
[02:03:35] [PASSED] 15 VFs
[02:03:35] [PASSED] 16 VFs
[02:03:35] [PASSED] 17 VFs
[02:03:35] [PASSED] 18 VFs
[02:03:35] [PASSED] 19 VFs
[02:03:35] [PASSED] 20 VFs
[02:03:35] [PASSED] 21 VFs
[02:03:35] [PASSED] 22 VFs
[02:03:35] [PASSED] 23 VFs
[02:03:35] [PASSED] 24 VFs
[02:03:35] [PASSED] 25 VFs
[02:03:35] [PASSED] 26 VFs
[02:03:35] [PASSED] 27 VFs
[02:03:35] [PASSED] 28 VFs
[02:03:35] [PASSED] 29 VFs
[02:03:35] [PASSED] 30 VFs
[02:03:35] [PASSED] 31 VFs
[02:03:35] [PASSED] 32 VFs
[02:03:35] [PASSED] 33 VFs
[02:03:35] [PASSED] 34 VFs
[02:03:35] [PASSED] 35 VFs
[02:03:35] [PASSED] 36 VFs
[02:03:35] [PASSED] 37 VFs
[02:03:35] [PASSED] 38 VFs
[02:03:35] [PASSED] 39 VFs
[02:03:35] [PASSED] 40 VFs
[02:03:35] [PASSED] 41 VFs
[02:03:35] [PASSED] 42 VFs
[02:03:35] [PASSED] 43 VFs
[02:03:35] [PASSED] 44 VFs
[02:03:35] [PASSED] 45 VFs
[02:03:35] [PASSED] 46 VFs
[02:03:35] [PASSED] 47 VFs
[02:03:35] [PASSED] 48 VFs
[02:03:35] [PASSED] 49 VFs
[02:03:35] [PASSED] 50 VFs
[02:03:35] [PASSED] 51 VFs
[02:03:35] [PASSED] 52 VFs
[02:03:35] [PASSED] 53 VFs
[02:03:35] [PASSED] 54 VFs
[02:03:35] [PASSED] 55 VFs
[02:03:35] [PASSED] 56 VFs
[02:03:35] [PASSED] 57 VFs
[02:03:35] [PASSED] 58 VFs
[02:03:35] [PASSED] 59 VFs
[02:03:35] [PASSED] 60 VFs
[02:03:35] [PASSED] 61 VFs
[02:03:35] [PASSED] 62 VFs
[02:03:35] [PASSED] 63 VFs
[02:03:35] ================== [PASSED] fair_contexts ==================
[02:03:35] ===================== fair_doorbells  ======================
[02:03:35] [PASSED] 1 VF
[02:03:35] [PASSED] 2 VFs
[02:03:35] [PASSED] 3 VFs
[02:03:35] [PASSED] 4 VFs
[02:03:35] [PASSED] 5 VFs
[02:03:35] [PASSED] 6 VFs
[02:03:35] [PASSED] 7 VFs
[02:03:35] [PASSED] 8 VFs
[02:03:35] [PASSED] 9 VFs
[02:03:35] [PASSED] 10 VFs
[02:03:35] [PASSED] 11 VFs
[02:03:35] [PASSED] 12 VFs
[02:03:35] [PASSED] 13 VFs
[02:03:35] [PASSED] 14 VFs
[02:03:35] [PASSED] 15 VFs
[02:03:35] [PASSED] 16 VFs
[02:03:35] [PASSED] 17 VFs
[02:03:35] [PASSED] 18 VFs
[02:03:35] [PASSED] 19 VFs
[02:03:35] [PASSED] 20 VFs
[02:03:35] [PASSED] 21 VFs
[02:03:35] [PASSED] 22 VFs
[02:03:35] [PASSED] 23 VFs
[02:03:35] [PASSED] 24 VFs
[02:03:35] [PASSED] 25 VFs
[02:03:35] [PASSED] 26 VFs
[02:03:35] [PASSED] 27 VFs
[02:03:35] [PASSED] 28 VFs
[02:03:35] [PASSED] 29 VFs
[02:03:35] [PASSED] 30 VFs
[02:03:35] [PASSED] 31 VFs
[02:03:35] [PASSED] 32 VFs
[02:03:35] [PASSED] 33 VFs
[02:03:35] [PASSED] 34 VFs
[02:03:35] [PASSED] 35 VFs
[02:03:35] [PASSED] 36 VFs
[02:03:35] [PASSED] 37 VFs
[02:03:35] [PASSED] 38 VFs
[02:03:35] [PASSED] 39 VFs
[02:03:35] [PASSED] 40 VFs
[02:03:35] [PASSED] 41 VFs
[02:03:35] [PASSED] 42 VFs
[02:03:35] [PASSED] 43 VFs
[02:03:35] [PASSED] 44 VFs
[02:03:35] [PASSED] 45 VFs
[02:03:35] [PASSED] 46 VFs
[02:03:35] [PASSED] 47 VFs
[02:03:35] [PASSED] 48 VFs
[02:03:35] [PASSED] 49 VFs
[02:03:35] [PASSED] 50 VFs
[02:03:35] [PASSED] 51 VFs
[02:03:35] [PASSED] 52 VFs
[02:03:35] [PASSED] 53 VFs
[02:03:35] [PASSED] 54 VFs
[02:03:35] [PASSED] 55 VFs
[02:03:35] [PASSED] 56 VFs
[02:03:35] [PASSED] 57 VFs
[02:03:35] [PASSED] 58 VFs
[02:03:35] [PASSED] 59 VFs
[02:03:35] [PASSED] 60 VFs
[02:03:35] [PASSED] 61 VFs
[02:03:35] [PASSED] 62 VFs
[02:03:35] [PASSED] 63 VFs
[02:03:35] ================= [PASSED] fair_doorbells ==================
[02:03:35] ======================== fair_ggtt  ========================
[02:03:35] [PASSED] 1 VF
[02:03:35] [PASSED] 2 VFs
[02:03:35] [PASSED] 3 VFs
[02:03:35] [PASSED] 4 VFs
[02:03:35] [PASSED] 5 VFs
[02:03:35] [PASSED] 6 VFs
[02:03:35] [PASSED] 7 VFs
[02:03:35] [PASSED] 8 VFs
[02:03:35] [PASSED] 9 VFs
[02:03:35] [PASSED] 10 VFs
[02:03:35] [PASSED] 11 VFs
[02:03:35] [PASSED] 12 VFs
[02:03:35] [PASSED] 13 VFs
[02:03:35] [PASSED] 14 VFs
[02:03:35] [PASSED] 15 VFs
[02:03:35] [PASSED] 16 VFs
[02:03:35] [PASSED] 17 VFs
[02:03:36] [PASSED] 18 VFs
[02:03:36] [PASSED] 19 VFs
[02:03:36] [PASSED] 20 VFs
[02:03:36] [PASSED] 21 VFs
[02:03:36] [PASSED] 22 VFs
[02:03:36] [PASSED] 23 VFs
[02:03:36] [PASSED] 24 VFs
[02:03:36] [PASSED] 25 VFs
[02:03:36] [PASSED] 26 VFs
[02:03:36] [PASSED] 27 VFs
[02:03:36] [PASSED] 28 VFs
[02:03:36] [PASSED] 29 VFs
[02:03:36] [PASSED] 30 VFs
[02:03:36] [PASSED] 31 VFs
[02:03:36] [PASSED] 32 VFs
[02:03:36] [PASSED] 33 VFs
[02:03:36] [PASSED] 34 VFs
[02:03:36] [PASSED] 35 VFs
[02:03:36] [PASSED] 36 VFs
[02:03:36] [PASSED] 37 VFs
[02:03:36] [PASSED] 38 VFs
[02:03:36] [PASSED] 39 VFs
[02:03:36] [PASSED] 40 VFs
[02:03:36] [PASSED] 41 VFs
[02:03:36] [PASSED] 42 VFs
[02:03:36] [PASSED] 43 VFs
[02:03:36] [PASSED] 44 VFs
[02:03:36] [PASSED] 45 VFs
[02:03:36] [PASSED] 46 VFs
[02:03:36] [PASSED] 47 VFs
[02:03:36] [PASSED] 48 VFs
[02:03:36] [PASSED] 49 VFs
[02:03:36] [PASSED] 50 VFs
[02:03:36] [PASSED] 51 VFs
[02:03:36] [PASSED] 52 VFs
[02:03:36] [PASSED] 53 VFs
[02:03:36] [PASSED] 54 VFs
[02:03:36] [PASSED] 55 VFs
[02:03:36] [PASSED] 56 VFs
[02:03:36] [PASSED] 57 VFs
[02:03:36] [PASSED] 58 VFs
[02:03:36] [PASSED] 59 VFs
[02:03:36] [PASSED] 60 VFs
[02:03:36] [PASSED] 61 VFs
[02:03:36] [PASSED] 62 VFs
[02:03:36] [PASSED] 63 VFs
[02:03:36] ==================== [PASSED] fair_ggtt ====================
[02:03:36] ======================== fair_vram  ========================
[02:03:36] [PASSED] 1 VF
[02:03:36] [PASSED] 2 VFs
[02:03:36] [PASSED] 3 VFs
[02:03:36] [PASSED] 4 VFs
[02:03:36] [PASSED] 5 VFs
[02:03:36] [PASSED] 6 VFs
[02:03:36] [PASSED] 7 VFs
[02:03:36] [PASSED] 8 VFs
[02:03:36] [PASSED] 9 VFs
[02:03:36] [PASSED] 10 VFs
[02:03:36] [PASSED] 11 VFs
[02:03:36] [PASSED] 12 VFs
[02:03:36] [PASSED] 13 VFs
[02:03:36] [PASSED] 14 VFs
[02:03:36] [PASSED] 15 VFs
[02:03:36] [PASSED] 16 VFs
[02:03:36] [PASSED] 17 VFs
[02:03:36] [PASSED] 18 VFs
[02:03:36] [PASSED] 19 VFs
[02:03:36] [PASSED] 20 VFs
[02:03:36] [PASSED] 21 VFs
[02:03:36] [PASSED] 22 VFs
[02:03:36] [PASSED] 23 VFs
[02:03:36] [PASSED] 24 VFs
[02:03:36] [PASSED] 25 VFs
[02:03:36] [PASSED] 26 VFs
[02:03:36] [PASSED] 27 VFs
[02:03:36] [PASSED] 28 VFs
[02:03:36] [PASSED] 29 VFs
[02:03:36] [PASSED] 30 VFs
[02:03:36] [PASSED] 31 VFs
[02:03:36] [PASSED] 32 VFs
[02:03:36] [PASSED] 33 VFs
[02:03:36] [PASSED] 34 VFs
[02:03:36] [PASSED] 35 VFs
[02:03:36] [PASSED] 36 VFs
[02:03:36] [PASSED] 37 VFs
[02:03:36] [PASSED] 38 VFs
[02:03:36] [PASSED] 39 VFs
[02:03:36] [PASSED] 40 VFs
[02:03:36] [PASSED] 41 VFs
[02:03:36] [PASSED] 42 VFs
[02:03:36] [PASSED] 43 VFs
[02:03:36] [PASSED] 44 VFs
[02:03:36] [PASSED] 45 VFs
[02:03:36] [PASSED] 46 VFs
[02:03:36] [PASSED] 47 VFs
[02:03:36] [PASSED] 48 VFs
[02:03:36] [PASSED] 49 VFs
[02:03:36] [PASSED] 50 VFs
[02:03:36] [PASSED] 51 VFs
[02:03:36] [PASSED] 52 VFs
[02:03:36] [PASSED] 53 VFs
[02:03:36] [PASSED] 54 VFs
[02:03:36] [PASSED] 55 VFs
[02:03:36] [PASSED] 56 VFs
[02:03:36] [PASSED] 57 VFs
[02:03:36] [PASSED] 58 VFs
[02:03:36] [PASSED] 59 VFs
[02:03:36] [PASSED] 60 VFs
[02:03:36] [PASSED] 61 VFs
[02:03:36] [PASSED] 62 VFs
[02:03:36] [PASSED] 63 VFs
[02:03:36] ==================== [PASSED] fair_vram ====================
[02:03:36] ================== [PASSED] pf_gt_config ===================
[02:03:36] ===================== lmtt (1 subtest) =====================
[02:03:36] ======================== test_ops  =========================
[02:03:36] [PASSED] 2-level
[02:03:36] [PASSED] multi-level
[02:03:36] ==================== [PASSED] test_ops =====================
[02:03:36] ====================== [PASSED] lmtt =======================
[02:03:36] ================= pf_service (11 subtests) =================
[02:03:36] [PASSED] pf_negotiate_any
[02:03:36] [PASSED] pf_negotiate_base_match
[02:03:36] [PASSED] pf_negotiate_base_newer
[02:03:36] [PASSED] pf_negotiate_base_next
[02:03:36] [SKIPPED] pf_negotiate_base_older
[02:03:36] [PASSED] pf_negotiate_base_prev
[02:03:36] [PASSED] pf_negotiate_latest_match
[02:03:36] [PASSED] pf_negotiate_latest_newer
[02:03:36] [PASSED] pf_negotiate_latest_next
[02:03:36] [SKIPPED] pf_negotiate_latest_older
[02:03:36] [SKIPPED] pf_negotiate_latest_prev
[02:03:36] =================== [PASSED] pf_service ====================
[02:03:36] ================= xe_guc_g2g (2 subtests) ==================
[02:03:36] ============== xe_live_guc_g2g_kunit_default  ==============
[02:03:36] ========= [SKIPPED] xe_live_guc_g2g_kunit_default ==========
[02:03:36] ============== xe_live_guc_g2g_kunit_allmem  ===============
[02:03:36] ========== [SKIPPED] xe_live_guc_g2g_kunit_allmem ==========
[02:03:36] =================== [SKIPPED] xe_guc_g2g ===================
[02:03:36] =================== xe_mocs (2 subtests) ===================
[02:03:36] ================ xe_live_mocs_kernel_kunit  ================
[02:03:36] =========== [SKIPPED] xe_live_mocs_kernel_kunit ============
[02:03:36] ================ xe_live_mocs_reset_kunit  =================
[02:03:36] ============ [SKIPPED] xe_live_mocs_reset_kunit ============
[02:03:36] ==================== [SKIPPED] xe_mocs =====================
[02:03:36] ================= xe_migrate (2 subtests) ==================
[02:03:36] ================= xe_migrate_sanity_kunit  =================
[02:03:36] ============ [SKIPPED] xe_migrate_sanity_kunit =============
[02:03:36] ================== xe_validate_ccs_kunit  ==================
[02:03:36] ============= [SKIPPED] xe_validate_ccs_kunit ==============
[02:03:36] =================== [SKIPPED] xe_migrate ===================
[02:03:36] ================== xe_dma_buf (1 subtest) ==================
[02:03:36] ==================== xe_dma_buf_kunit  =====================
[02:03:36] ================ [SKIPPED] xe_dma_buf_kunit ================
[02:03:36] =================== [SKIPPED] xe_dma_buf ===================
[02:03:36] ================= xe_bo_shrink (1 subtest) =================
[02:03:36] =================== xe_bo_shrink_kunit  ====================
[02:03:36] =============== [SKIPPED] xe_bo_shrink_kunit ===============
[02:03:36] ================== [SKIPPED] xe_bo_shrink ==================
[02:03:36] ==================== xe_bo (2 subtests) ====================
[02:03:36] ================== xe_ccs_migrate_kunit  ===================
[02:03:36] ============== [SKIPPED] xe_ccs_migrate_kunit ==============
[02:03:36] ==================== xe_bo_evict_kunit  ====================
[02:03:36] =============== [SKIPPED] xe_bo_evict_kunit ================
[02:03:36] ===================== [SKIPPED] xe_bo ======================
[02:03:36] ==================== args (13 subtests) ====================
[02:03:36] [PASSED] count_args_test
[02:03:36] [PASSED] call_args_example
[02:03:36] [PASSED] call_args_test
[02:03:36] [PASSED] drop_first_arg_example
[02:03:36] [PASSED] drop_first_arg_test
[02:03:36] [PASSED] first_arg_example
[02:03:36] [PASSED] first_arg_test
[02:03:36] [PASSED] last_arg_example
[02:03:36] [PASSED] last_arg_test
[02:03:36] [PASSED] pick_arg_example
[02:03:36] [PASSED] if_args_example
[02:03:36] [PASSED] if_args_test
[02:03:36] [PASSED] sep_comma_example
[02:03:36] ====================== [PASSED] args =======================
[02:03:36] =================== xe_pci (3 subtests) ====================
[02:03:36] ==================== check_graphics_ip  ====================
[02:03:36] [PASSED] 12.00 Xe_LP
[02:03:36] [PASSED] 12.10 Xe_LP+
[02:03:36] [PASSED] 12.55 Xe_HPG
[02:03:36] [PASSED] 12.60 Xe_HPC
[02:03:36] [PASSED] 12.70 Xe_LPG
[02:03:36] [PASSED] 12.71 Xe_LPG
[02:03:36] [PASSED] 12.74 Xe_LPG+
[02:03:36] [PASSED] 20.01 Xe2_HPG
[02:03:36] [PASSED] 20.02 Xe2_HPG
[02:03:36] [PASSED] 20.04 Xe2_LPG
[02:03:36] [PASSED] 30.00 Xe3_LPG
[02:03:36] [PASSED] 30.01 Xe3_LPG
[02:03:36] [PASSED] 30.03 Xe3_LPG
[02:03:36] [PASSED] 30.04 Xe3_LPG
[02:03:36] [PASSED] 30.05 Xe3_LPG
[02:03:36] [PASSED] 35.10 Xe3p_LPG
[02:03:36] [PASSED] 35.11 Xe3p_XPC
[02:03:36] ================ [PASSED] check_graphics_ip ================
[02:03:36] ===================== check_media_ip  ======================
[02:03:36] [PASSED] 12.00 Xe_M
[02:03:36] [PASSED] 12.55 Xe_HPM
[02:03:36] [PASSED] 13.00 Xe_LPM+
[02:03:36] [PASSED] 13.01 Xe2_HPM
[02:03:36] [PASSED] 20.00 Xe2_LPM
[02:03:36] [PASSED] 30.00 Xe3_LPM
[02:03:36] [PASSED] 30.02 Xe3_LPM
[02:03:36] [PASSED] 35.00 Xe3p_LPM
[02:03:36] [PASSED] 35.03 Xe3p_HPM
[02:03:36] ================= [PASSED] check_media_ip ==================
[02:03:36] =================== check_platform_desc  ===================
[02:03:36] [PASSED] 0x9A60 (TIGERLAKE)
[02:03:36] [PASSED] 0x9A68 (TIGERLAKE)
[02:03:36] [PASSED] 0x9A70 (TIGERLAKE)
[02:03:36] [PASSED] 0x9A40 (TIGERLAKE)
[02:03:36] [PASSED] 0x9A49 (TIGERLAKE)
[02:03:36] [PASSED] 0x9A59 (TIGERLAKE)
[02:03:36] [PASSED] 0x9A78 (TIGERLAKE)
[02:03:36] [PASSED] 0x9AC0 (TIGERLAKE)
[02:03:36] [PASSED] 0x9AC9 (TIGERLAKE)
[02:03:36] [PASSED] 0x9AD9 (TIGERLAKE)
[02:03:36] [PASSED] 0x9AF8 (TIGERLAKE)
[02:03:36] [PASSED] 0x4C80 (ROCKETLAKE)
[02:03:36] [PASSED] 0x4C8A (ROCKETLAKE)
[02:03:36] [PASSED] 0x4C8B (ROCKETLAKE)
[02:03:36] [PASSED] 0x4C8C (ROCKETLAKE)
[02:03:36] [PASSED] 0x4C90 (ROCKETLAKE)
[02:03:36] [PASSED] 0x4C9A (ROCKETLAKE)
[02:03:36] [PASSED] 0x4680 (ALDERLAKE_S)
[02:03:36] [PASSED] 0x4682 (ALDERLAKE_S)
[02:03:36] [PASSED] 0x4688 (ALDERLAKE_S)
[02:03:36] [PASSED] 0x468A (ALDERLAKE_S)
[02:03:36] [PASSED] 0x468B (ALDERLAKE_S)
[02:03:36] [PASSED] 0x4690 (ALDERLAKE_S)
[02:03:36] [PASSED] 0x4692 (ALDERLAKE_S)
[02:03:36] [PASSED] 0x4693 (ALDERLAKE_S)
[02:03:36] [PASSED] 0x46A0 (ALDERLAKE_P)
[02:03:36] [PASSED] 0x46A1 (ALDERLAKE_P)
[02:03:36] [PASSED] 0x46A2 (ALDERLAKE_P)
[02:03:36] [PASSED] 0x46A3 (ALDERLAKE_P)
[02:03:36] [PASSED] 0x46A6 (ALDERLAKE_P)
[02:03:36] [PASSED] 0x46A8 (ALDERLAKE_P)
[02:03:36] [PASSED] 0x46AA (ALDERLAKE_P)
[02:03:36] [PASSED] 0x462A (ALDERLAKE_P)
[02:03:36] [PASSED] 0x4626 (ALDERLAKE_P)
[02:03:36] [PASSED] 0x4628 (ALDERLAKE_P)
[02:03:36] [PASSED] 0x46B0 (ALDERLAKE_P)
[02:03:36] [PASSED] 0x46B1 (ALDERLAKE_P)
[02:03:36] [PASSED] 0x46B2 (ALDERLAKE_P)
[02:03:36] [PASSED] 0x46B3 (ALDERLAKE_P)
[02:03:36] [PASSED] 0x46C0 (ALDERLAKE_P)
[02:03:36] [PASSED] 0x46C1 (ALDERLAKE_P)
[02:03:36] [PASSED] 0x46C2 (ALDERLAKE_P)
[02:03:36] [PASSED] 0x46C3 (ALDERLAKE_P)
[02:03:36] [PASSED] 0x46D0 (ALDERLAKE_N)
[02:03:36] [PASSED] 0x46D1 (ALDERLAKE_N)
[02:03:36] [PASSED] 0x46D2 (ALDERLAKE_N)
[02:03:36] [PASSED] 0x46D3 (ALDERLAKE_N)
[02:03:36] [PASSED] 0x46D4 (ALDERLAKE_N)
[02:03:36] [PASSED] 0xA721 (ALDERLAKE_P)
[02:03:36] [PASSED] 0xA7A1 (ALDERLAKE_P)
[02:03:36] [PASSED] 0xA7A9 (ALDERLAKE_P)
[02:03:36] [PASSED] 0xA7AC (ALDERLAKE_P)
[02:03:36] [PASSED] 0xA7AD (ALDERLAKE_P)
[02:03:36] [PASSED] 0xA720 (ALDERLAKE_P)
[02:03:36] [PASSED] 0xA7A0 (ALDERLAKE_P)
[02:03:36] [PASSED] 0xA7A8 (ALDERLAKE_P)
[02:03:36] [PASSED] 0xA7AA (ALDERLAKE_P)
[02:03:36] [PASSED] 0xA7AB (ALDERLAKE_P)
[02:03:36] [PASSED] 0xA780 (ALDERLAKE_S)
[02:03:36] [PASSED] 0xA781 (ALDERLAKE_S)
[02:03:36] [PASSED] 0xA782 (ALDERLAKE_S)
[02:03:36] [PASSED] 0xA783 (ALDERLAKE_S)
[02:03:36] [PASSED] 0xA788 (ALDERLAKE_S)
[02:03:36] [PASSED] 0xA789 (ALDERLAKE_S)
[02:03:36] [PASSED] 0xA78A (ALDERLAKE_S)
[02:03:36] [PASSED] 0xA78B (ALDERLAKE_S)
[02:03:36] [PASSED] 0x4905 (DG1)
[02:03:36] [PASSED] 0x4906 (DG1)
[02:03:36] [PASSED] 0x4907 (DG1)
[02:03:36] [PASSED] 0x4908 (DG1)
[02:03:36] [PASSED] 0x4909 (DG1)
[02:03:36] [PASSED] 0x56C0 (DG2)
[02:03:36] [PASSED] 0x56C2 (DG2)
[02:03:36] [PASSED] 0x56C1 (DG2)
[02:03:36] [PASSED] 0x7D51 (METEORLAKE)
[02:03:36] [PASSED] 0x7DD1 (METEORLAKE)
[02:03:36] [PASSED] 0x7D41 (METEORLAKE)
[02:03:36] [PASSED] 0x7D67 (METEORLAKE)
[02:03:36] [PASSED] 0xB640 (METEORLAKE)
[02:03:36] [PASSED] 0x56A0 (DG2)
[02:03:36] [PASSED] 0x56A1 (DG2)
[02:03:36] [PASSED] 0x56A2 (DG2)
[02:03:36] [PASSED] 0x56BE (DG2)
[02:03:36] [PASSED] 0x56BF (DG2)
[02:03:36] [PASSED] 0x5690 (DG2)
[02:03:36] [PASSED] 0x5691 (DG2)
[02:03:36] [PASSED] 0x5692 (DG2)
[02:03:36] [PASSED] 0x56A5 (DG2)
[02:03:36] [PASSED] 0x56A6 (DG2)
[02:03:36] [PASSED] 0x56B0 (DG2)
[02:03:36] [PASSED] 0x56B1 (DG2)
[02:03:36] [PASSED] 0x56BA (DG2)
[02:03:36] [PASSED] 0x56BB (DG2)
[02:03:36] [PASSED] 0x56BC (DG2)
[02:03:36] [PASSED] 0x56BD (DG2)
[02:03:36] [PASSED] 0x5693 (DG2)
[02:03:36] [PASSED] 0x5694 (DG2)
[02:03:36] [PASSED] 0x5695 (DG2)
[02:03:36] [PASSED] 0x56A3 (DG2)
[02:03:36] [PASSED] 0x56A4 (DG2)
[02:03:36] [PASSED] 0x56B2 (DG2)
[02:03:36] [PASSED] 0x56B3 (DG2)
[02:03:36] [PASSED] 0x5696 (DG2)
[02:03:36] [PASSED] 0x5697 (DG2)
[02:03:36] [PASSED] 0xB69 (PVC)
[02:03:36] [PASSED] 0xB6E (PVC)
[02:03:36] [PASSED] 0xBD4 (PVC)
[02:03:36] [PASSED] 0xBD5 (PVC)
[02:03:36] [PASSED] 0xBD6 (PVC)
[02:03:36] [PASSED] 0xBD7 (PVC)
[02:03:36] [PASSED] 0xBD8 (PVC)
[02:03:36] [PASSED] 0xBD9 (PVC)
[02:03:36] [PASSED] 0xBDA (PVC)
[02:03:36] [PASSED] 0xBDB (PVC)
[02:03:36] [PASSED] 0xBE0 (PVC)
[02:03:36] [PASSED] 0xBE1 (PVC)
[02:03:36] [PASSED] 0xBE5 (PVC)
[02:03:36] [PASSED] 0x7D40 (METEORLAKE)
[02:03:36] [PASSED] 0x7D45 (METEORLAKE)
[02:03:36] [PASSED] 0x7D55 (METEORLAKE)
[02:03:36] [PASSED] 0x7D60 (METEORLAKE)
[02:03:36] [PASSED] 0x7DD5 (METEORLAKE)
[02:03:36] [PASSED] 0x6420 (LUNARLAKE)
[02:03:36] [PASSED] 0x64A0 (LUNARLAKE)
[02:03:36] [PASSED] 0x64B0 (LUNARLAKE)
[02:03:36] [PASSED] 0xE202 (BATTLEMAGE)
[02:03:36] [PASSED] 0xE209 (BATTLEMAGE)
[02:03:36] [PASSED] 0xE20B (BATTLEMAGE)
[02:03:36] [PASSED] 0xE20C (BATTLEMAGE)
[02:03:36] [PASSED] 0xE20D (BATTLEMAGE)
[02:03:36] [PASSED] 0xE210 (BATTLEMAGE)
[02:03:36] [PASSED] 0xE211 (BATTLEMAGE)
[02:03:36] [PASSED] 0xE212 (BATTLEMAGE)
[02:03:36] [PASSED] 0xE216 (BATTLEMAGE)
[02:03:36] [PASSED] 0xE220 (BATTLEMAGE)
[02:03:36] [PASSED] 0xE221 (BATTLEMAGE)
[02:03:36] [PASSED] 0xE222 (BATTLEMAGE)
[02:03:36] [PASSED] 0xE223 (BATTLEMAGE)
[02:03:36] [PASSED] 0xB080 (PANTHERLAKE)
[02:03:36] [PASSED] 0xB081 (PANTHERLAKE)
[02:03:36] [PASSED] 0xB082 (PANTHERLAKE)
[02:03:36] [PASSED] 0xB083 (PANTHERLAKE)
[02:03:36] [PASSED] 0xB084 (PANTHERLAKE)
[02:03:36] [PASSED] 0xB085 (PANTHERLAKE)
[02:03:36] [PASSED] 0xB086 (PANTHERLAKE)
[02:03:36] [PASSED] 0xB087 (PANTHERLAKE)
[02:03:36] [PASSED] 0xB08F (PANTHERLAKE)
[02:03:36] [PASSED] 0xB090 (PANTHERLAKE)
[02:03:36] [PASSED] 0xB0A0 (PANTHERLAKE)
[02:03:36] [PASSED] 0xB0B0 (PANTHERLAKE)
[02:03:36] [PASSED] 0xFD80 (PANTHERLAKE)
[02:03:36] [PASSED] 0xFD81 (PANTHERLAKE)
[02:03:36] [PASSED] 0xD740 (NOVALAKE_S)
[02:03:36] [PASSED] 0xD741 (NOVALAKE_S)
[02:03:36] [PASSED] 0xD742 (NOVALAKE_S)
[02:03:36] [PASSED] 0xD743 (NOVALAKE_S)
[02:03:36] [PASSED] 0xD744 (NOVALAKE_S)
[02:03:36] [PASSED] 0xD745 (NOVALAKE_S)
[02:03:36] [PASSED] 0x674C (CRESCENTISLAND)
[02:03:36] [PASSED] 0xD750 (NOVALAKE_P)
[02:03:36] [PASSED] 0xD751 (NOVALAKE_P)
[02:03:36] [PASSED] 0xD752 (NOVALAKE_P)
[02:03:36] [PASSED] 0xD753 (NOVALAKE_P)
[02:03:36] [PASSED] 0xD754 (NOVALAKE_P)
[02:03:36] [PASSED] 0xD755 (NOVALAKE_P)
[02:03:36] [PASSED] 0xD756 (NOVALAKE_P)
[02:03:36] [PASSED] 0xD757 (NOVALAKE_P)
[02:03:36] [PASSED] 0xD75F (NOVALAKE_P)
[02:03:36] =============== [PASSED] check_platform_desc ===============
[02:03:36] ===================== [PASSED] xe_pci ======================
[02:03:36] =================== xe_rtp (2 subtests) ====================
[02:03:36] =============== xe_rtp_process_to_sr_tests  ================
[02:03:36] [PASSED] coalesce-same-reg
[02:03:36] [PASSED] no-match-no-add
[02:03:36] [PASSED] match-or
[02:03:36] [PASSED] match-or-xfail
[02:03:36] [PASSED] no-match-no-add-multiple-rules
[02:03:36] [PASSED] two-regs-two-entries
[02:03:36] [PASSED] clr-one-set-other
[02:03:36] [PASSED] set-field
[02:03:36] [PASSED] conflict-duplicate
stty: 'standard input': Inappropriate ioctl for device
[02:03:36] [PASSED] conflict-not-disjoint
[02:03:36] [PASSED] conflict-reg-type
[02:03:36] =========== [PASSED] xe_rtp_process_to_sr_tests ============
[02:03:36] ================== xe_rtp_process_tests  ===================
[02:03:36] [PASSED] active1
[02:03:36] [PASSED] active2
[02:03:36] [PASSED] active-inactive
[02:03:36] [PASSED] inactive-active
[02:03:36] [PASSED] inactive-1st_or_active-inactive
[02:03:36] [PASSED] inactive-2nd_or_active-inactive
[02:03:36] [PASSED] inactive-last_or_active-inactive
[02:03:36] [PASSED] inactive-no_or_active-inactive
[02:03:36] ============== [PASSED] xe_rtp_process_tests ===============
[02:03:36] ===================== [PASSED] xe_rtp ======================
[02:03:36] ==================== xe_wa (1 subtest) =====================
[02:03:36] ======================== xe_wa_gt  =========================
[02:03:36] [PASSED] TIGERLAKE B0
[02:03:36] [PASSED] DG1 A0
[02:03:36] [PASSED] DG1 B0
[02:03:36] [PASSED] ALDERLAKE_S A0
[02:03:36] [PASSED] ALDERLAKE_S B0
[02:03:36] [PASSED] ALDERLAKE_S C0
[02:03:36] [PASSED] ALDERLAKE_S D0
[02:03:36] [PASSED] ALDERLAKE_P A0
[02:03:36] [PASSED] ALDERLAKE_P B0
[02:03:36] [PASSED] ALDERLAKE_P C0
[02:03:36] [PASSED] ALDERLAKE_S RPLS D0
[02:03:36] [PASSED] ALDERLAKE_P RPLU E0
[02:03:36] [PASSED] DG2 G10 C0
[02:03:36] [PASSED] DG2 G11 B1
[02:03:36] [PASSED] DG2 G12 A1
[02:03:36] [PASSED] METEORLAKE 12.70(Xe_LPG) A0 13.00(Xe_LPM+) A0
[02:03:36] [PASSED] METEORLAKE 12.71(Xe_LPG) A0 13.00(Xe_LPM+) A0
[02:03:36] [PASSED] METEORLAKE 12.74(Xe_LPG+) A0 13.00(Xe_LPM+) A0
[02:03:36] [PASSED] LUNARLAKE 20.04(Xe2_LPG) A0 20.00(Xe2_LPM) A0
[02:03:36] [PASSED] LUNARLAKE 20.04(Xe2_LPG) B0 20.00(Xe2_LPM) A0
[02:03:36] [PASSED] BATTLEMAGE 20.01(Xe2_HPG) A0 13.01(Xe2_HPM) A1
[02:03:36] [PASSED] PANTHERLAKE 30.00(Xe3_LPG) A0 30.00(Xe3_LPM) A0
[02:03:36] ==================== [PASSED] xe_wa_gt =====================
[02:03:36] ====================== [PASSED] xe_wa ======================
[02:03:36] ============================================================
[02:03:36] Testing complete. Ran 597 tests: passed: 579, skipped: 18
[02:03:36] Elapsed time: 35.300s total, 4.192s configuring, 30.485s building, 0.605s running

+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/tests/.kunitconfig [02:03:36] Configuring KUnit Kernel ...
Regenerating .config ...
Populating config with:

$ make ARCH=um O=.kunit olddefconfig
[02:03:38] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48
[02:04:02] Starting KUnit Kernel (1/1)...
[02:04:02] ============================================================
Running tests with:
$ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt
[02:04:02] ============ drm_test_pick_cmdline (2 subtests) ============
[02:04:02] [PASSED] drm_test_pick_cmdline_res_1920_1080_60
[02:04:02] =============== drm_test_pick_cmdline_named  ===============
[02:04:02] [PASSED] NTSC
[02:04:02] [PASSED] NTSC-J
[02:04:02] [PASSED] PAL
[02:04:02] [PASSED] PAL-M
[02:04:02] =========== [PASSED] drm_test_pick_cmdline_named ===========
[02:04:02] ============== [PASSED] drm_test_pick_cmdline ==============
[02:04:02] == drm_test_atomic_get_connector_for_encoder (1 subtest) ===
[02:04:02] [PASSED] drm_test_drm_atomic_get_connector_for_encoder
[02:04:02] ==== [PASSED] drm_test_atomic_get_connector_for_encoder ====
[02:04:02] =========== drm_validate_clone_mode (2 subtests) ===========
[02:04:02] ============== drm_test_check_in_clone_mode  ===============
[02:04:02] [PASSED] in_clone_mode
[02:04:02] [PASSED] not_in_clone_mode
[02:04:02] ========== [PASSED] drm_test_check_in_clone_mode ===========
[02:04:02] =============== drm_test_check_valid_clones  ===============
[02:04:02] [PASSED] not_in_clone_mode
[02:04:02] [PASSED] valid_clone
[02:04:02] [PASSED] invalid_clone
[02:04:02] =========== [PASSED] drm_test_check_valid_clones ===========
[02:04:02] ============= [PASSED] drm_validate_clone_mode =============
[02:04:02] ============= drm_validate_modeset (1 subtest) =============
[02:04:02] [PASSED] drm_test_check_connector_changed_modeset
[02:04:02] ============== [PASSED] drm_validate_modeset ===============
[02:04:02] ====== drm_test_bridge_get_current_state (2 subtests) ======
[02:04:02] [PASSED] drm_test_drm_bridge_get_current_state_atomic
[02:04:02] [PASSED] drm_test_drm_bridge_get_current_state_legacy
[02:04:02] ======== [PASSED] drm_test_bridge_get_current_state ========
[02:04:02] ====== drm_test_bridge_helper_reset_crtc (3 subtests) ======
[02:04:02] [PASSED] drm_test_drm_bridge_helper_reset_crtc_atomic
[02:04:02] [PASSED] drm_test_drm_bridge_helper_reset_crtc_atomic_disabled
[02:04:02] [PASSED] drm_test_drm_bridge_helper_reset_crtc_legacy
[02:04:02] ======== [PASSED] drm_test_bridge_helper_reset_crtc ========
[02:04:02] ============== drm_bridge_alloc (2 subtests) ===============
[02:04:02] [PASSED] drm_test_drm_bridge_alloc_basic
[02:04:02] [PASSED] drm_test_drm_bridge_alloc_get_put
[02:04:02] ================ [PASSED] drm_bridge_alloc =================
[02:04:02] ============= drm_cmdline_parser (40 subtests) =============
[02:04:02] [PASSED] drm_test_cmdline_force_d_only
[02:04:02] [PASSED] drm_test_cmdline_force_D_only_dvi
[02:04:02] [PASSED] drm_test_cmdline_force_D_only_hdmi
[02:04:02] [PASSED] drm_test_cmdline_force_D_only_not_digital
[02:04:02] [PASSED] drm_test_cmdline_force_e_only
[02:04:02] [PASSED] drm_test_cmdline_res
[02:04:02] [PASSED] drm_test_cmdline_res_vesa
[02:04:02] [PASSED] drm_test_cmdline_res_vesa_rblank
[02:04:02] [PASSED] drm_test_cmdline_res_rblank
[02:04:02] [PASSED] drm_test_cmdline_res_bpp
[02:04:02] [PASSED] drm_test_cmdline_res_refresh
[02:04:02] [PASSED] drm_test_cmdline_res_bpp_refresh
[02:04:02] [PASSED] drm_test_cmdline_res_bpp_refresh_interlaced
[02:04:02] [PASSED] drm_test_cmdline_res_bpp_refresh_margins
[02:04:02] [PASSED] drm_test_cmdline_res_bpp_refresh_force_off
[02:04:02] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on
[02:04:02] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on_analog
[02:04:02] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on_digital
[02:04:02] [PASSED] drm_test_cmdline_res_bpp_refresh_interlaced_margins_force_on
[02:04:02] [PASSED] drm_test_cmdline_res_margins_force_on
[02:04:02] [PASSED] drm_test_cmdline_res_vesa_margins
[02:04:02] [PASSED] drm_test_cmdline_name
[02:04:02] [PASSED] drm_test_cmdline_name_bpp
[02:04:02] [PASSED] drm_test_cmdline_name_option
[02:04:02] [PASSED] drm_test_cmdline_name_bpp_option
[02:04:02] [PASSED] drm_test_cmdline_rotate_0
[02:04:02] [PASSED] drm_test_cmdline_rotate_90
[02:04:02] [PASSED] drm_test_cmdline_rotate_180
[02:04:02] [PASSED] drm_test_cmdline_rotate_270
[02:04:02] [PASSED] drm_test_cmdline_hmirror
[02:04:02] [PASSED] drm_test_cmdline_vmirror
[02:04:02] [PASSED] drm_test_cmdline_margin_options
[02:04:02] [PASSED] drm_test_cmdline_multiple_options
[02:04:02] [PASSED] drm_test_cmdline_bpp_extra_and_option
[02:04:02] [PASSED] drm_test_cmdline_extra_and_option
[02:04:02] [PASSED] drm_test_cmdline_freestanding_options
[02:04:02] [PASSED] drm_test_cmdline_freestanding_force_e_and_options
[02:04:02] [PASSED] drm_test_cmdline_panel_orientation
[02:04:02] ================ drm_test_cmdline_invalid  =================
[02:04:02] [PASSED] margin_only
[02:04:02] [PASSED] interlace_only
[02:04:02] [PASSED] res_missing_x
[02:04:02] [PASSED] res_missing_y
[02:04:02] [PASSED] res_bad_y
[02:04:02] [PASSED] res_missing_y_bpp
[02:04:02] [PASSED] res_bad_bpp
[02:04:02] [PASSED] res_bad_refresh
[02:04:02] [PASSED] res_bpp_refresh_force_on_off
[02:04:02] [PASSED] res_invalid_mode
[02:04:02] [PASSED] res_bpp_wrong_place_mode
[02:04:02] [PASSED] name_bpp_refresh
[02:04:02] [PASSED] name_refresh
[02:04:02] [PASSED] name_refresh_wrong_mode
[02:04:02] [PASSED] name_refresh_invalid_mode
[02:04:02] [PASSED] rotate_multiple
[02:04:02] [PASSED] rotate_invalid_val
[02:04:02] [PASSED] rotate_truncated
[02:04:02] [PASSED] invalid_option
[02:04:02] [PASSED] invalid_tv_option
[02:04:02] [PASSED] truncated_tv_option
[02:04:02] ============ [PASSED] drm_test_cmdline_invalid =============
[02:04:02] =============== drm_test_cmdline_tv_options  ===============
[02:04:02] [PASSED] NTSC
[02:04:02] [PASSED] NTSC_443
[02:04:02] [PASSED] NTSC_J
[02:04:02] [PASSED] PAL
[02:04:02] [PASSED] PAL_M
[02:04:02] [PASSED] PAL_N
[02:04:02] [PASSED] SECAM
[02:04:02] [PASSED] MONO_525
[02:04:02] [PASSED] MONO_625
[02:04:02] =========== [PASSED] drm_test_cmdline_tv_options ===========
[02:04:02] =============== [PASSED] drm_cmdline_parser ================
[02:04:02] ========== drmm_connector_hdmi_init (20 subtests) ==========
[02:04:02] [PASSED] drm_test_connector_hdmi_init_valid
[02:04:02] [PASSED] drm_test_connector_hdmi_init_bpc_8
[02:04:02] [PASSED] drm_test_connector_hdmi_init_bpc_10
[02:04:02] [PASSED] drm_test_connector_hdmi_init_bpc_12
[02:04:02] [PASSED] drm_test_connector_hdmi_init_bpc_invalid
[02:04:02] [PASSED] drm_test_connector_hdmi_init_bpc_null
[02:04:02] [PASSED] drm_test_connector_hdmi_init_formats_empty
[02:04:02] [PASSED] drm_test_connector_hdmi_init_formats_no_rgb
[02:04:02] === drm_test_connector_hdmi_init_formats_yuv420_allowed  ===
[02:04:02] [PASSED] supported_formats=0x9 yuv420_allowed=1
[02:04:02] [PASSED] supported_formats=0x9 yuv420_allowed=0
[02:04:02] [PASSED] supported_formats=0x3 yuv420_allowed=1
[02:04:02] [PASSED] supported_formats=0x3 yuv420_allowed=0
[02:04:02] === [PASSED] drm_test_connector_hdmi_init_formats_yuv420_allowed ===
[02:04:02] [PASSED] drm_test_connector_hdmi_init_null_ddc
[02:04:02] [PASSED] drm_test_connector_hdmi_init_null_product
[02:04:02] [PASSED] drm_test_connector_hdmi_init_null_vendor
[02:04:02] [PASSED] drm_test_connector_hdmi_init_product_length_exact
[02:04:02] [PASSED] drm_test_connector_hdmi_init_product_length_too_long
[02:04:02] [PASSED] drm_test_connector_hdmi_init_product_valid
[02:04:02] [PASSED] drm_test_connector_hdmi_init_vendor_length_exact
[02:04:02] [PASSED] drm_test_connector_hdmi_init_vendor_length_too_long
[02:04:02] [PASSED] drm_test_connector_hdmi_init_vendor_valid
[02:04:02] ========= drm_test_connector_hdmi_init_type_valid  =========
[02:04:02] [PASSED] HDMI-A
[02:04:02] [PASSED] HDMI-B
[02:04:02] ===== [PASSED] drm_test_connector_hdmi_init_type_valid =====
[02:04:02] ======== drm_test_connector_hdmi_init_type_invalid  ========
[02:04:02] [PASSED] Unknown
[02:04:02] [PASSED] VGA
[02:04:02] [PASSED] DVI-I
[02:04:02] [PASSED] DVI-D
[02:04:02] [PASSED] DVI-A
[02:04:02] [PASSED] Composite
[02:04:02] [PASSED] SVIDEO
[02:04:02] [PASSED] LVDS
[02:04:02] [PASSED] Component
[02:04:02] [PASSED] DIN
[02:04:02] [PASSED] DP
[02:04:02] [PASSED] TV
[02:04:02] [PASSED] eDP
[02:04:02] [PASSED] Virtual
[02:04:02] [PASSED] DSI
[02:04:02] [PASSED] DPI
[02:04:02] [PASSED] Writeback
[02:04:02] [PASSED] SPI
[02:04:02] [PASSED] USB
[02:04:02] ==== [PASSED] drm_test_connector_hdmi_init_type_invalid ====
[02:04:02] ============ [PASSED] drmm_connector_hdmi_init =============
[02:04:02] ============= drmm_connector_init (3 subtests) =============
[02:04:02] [PASSED] drm_test_drmm_connector_init
[02:04:02] [PASSED] drm_test_drmm_connector_init_null_ddc
[02:04:02] ========= drm_test_drmm_connector_init_type_valid  =========
[02:04:02] [PASSED] Unknown
[02:04:02] [PASSED] VGA
[02:04:02] [PASSED] DVI-I
[02:04:02] [PASSED] DVI-D
[02:04:02] [PASSED] DVI-A
[02:04:02] [PASSED] Composite
[02:04:02] [PASSED] SVIDEO
[02:04:02] [PASSED] LVDS
[02:04:02] [PASSED] Component
[02:04:02] [PASSED] DIN
[02:04:02] [PASSED] DP
[02:04:02] [PASSED] HDMI-A
[02:04:02] [PASSED] HDMI-B
[02:04:02] [PASSED] TV
[02:04:02] [PASSED] eDP
[02:04:02] [PASSED] Virtual
[02:04:02] [PASSED] DSI
[02:04:02] [PASSED] DPI
[02:04:02] [PASSED] Writeback
[02:04:02] [PASSED] SPI
[02:04:02] [PASSED] USB
[02:04:02] ===== [PASSED] drm_test_drmm_connector_init_type_valid =====
[02:04:02] =============== [PASSED] drmm_connector_init ===============
[02:04:02] ========= drm_connector_dynamic_init (6 subtests) ==========
[02:04:02] [PASSED] drm_test_drm_connector_dynamic_init
[02:04:02] [PASSED] drm_test_drm_connector_dynamic_init_null_ddc
[02:04:02] [PASSED] drm_test_drm_connector_dynamic_init_not_added
[02:04:02] [PASSED] drm_test_drm_connector_dynamic_init_properties
[02:04:02] ===== drm_test_drm_connector_dynamic_init_type_valid  ======
[02:04:02] [PASSED] Unknown
[02:04:02] [PASSED] VGA
[02:04:02] [PASSED] DVI-I
[02:04:02] [PASSED] DVI-D
[02:04:02] [PASSED] DVI-A
[02:04:02] [PASSED] Composite
[02:04:02] [PASSED] SVIDEO
[02:04:02] [PASSED] LVDS
[02:04:02] [PASSED] Component
[02:04:02] [PASSED] DIN
[02:04:02] [PASSED] DP
[02:04:02] [PASSED] HDMI-A
[02:04:02] [PASSED] HDMI-B
[02:04:02] [PASSED] TV
[02:04:02] [PASSED] eDP
[02:04:02] [PASSED] Virtual
[02:04:02] [PASSED] DSI
[02:04:02] [PASSED] DPI
[02:04:02] [PASSED] Writeback
[02:04:02] [PASSED] SPI
[02:04:02] [PASSED] USB
[02:04:02] = [PASSED] drm_test_drm_connector_dynamic_init_type_valid ==
[02:04:02] ======== drm_test_drm_connector_dynamic_init_name  =========
[02:04:02] [PASSED] Unknown
[02:04:02] [PASSED] VGA
[02:04:02] [PASSED] DVI-I
[02:04:02] [PASSED] DVI-D
[02:04:02] [PASSED] DVI-A
[02:04:02] [PASSED] Composite
[02:04:02] [PASSED] SVIDEO
[02:04:02] [PASSED] LVDS
[02:04:02] [PASSED] Component
[02:04:02] [PASSED] DIN
[02:04:02] [PASSED] DP
[02:04:02] [PASSED] HDMI-A
[02:04:02] [PASSED] HDMI-B
[02:04:02] [PASSED] TV
[02:04:02] [PASSED] eDP
[02:04:02] [PASSED] Virtual
[02:04:02] [PASSED] DSI
[02:04:02] [PASSED] DPI
[02:04:02] [PASSED] Writeback
[02:04:02] [PASSED] SPI
[02:04:02] [PASSED] USB
[02:04:02] ==== [PASSED] drm_test_drm_connector_dynamic_init_name =====
[02:04:02] =========== [PASSED] drm_connector_dynamic_init ============
[02:04:02] ==== drm_connector_dynamic_register_early (4 subtests) =====
[02:04:02] [PASSED] drm_test_drm_connector_dynamic_register_early_on_list
[02:04:02] [PASSED] drm_test_drm_connector_dynamic_register_early_defer
[02:04:02] [PASSED] drm_test_drm_connector_dynamic_register_early_no_init
[02:04:02] [PASSED] drm_test_drm_connector_dynamic_register_early_no_mode_object
[02:04:02] ====== [PASSED] drm_connector_dynamic_register_early =======
[02:04:02] ======= drm_connector_dynamic_register (7 subtests) ========
[02:04:02] [PASSED] drm_test_drm_connector_dynamic_register_on_list
[02:04:02] [PASSED] drm_test_drm_connector_dynamic_register_no_defer
[02:04:02] [PASSED] drm_test_drm_connector_dynamic_register_no_init
[02:04:02] [PASSED] drm_test_drm_connector_dynamic_register_mode_object
[02:04:02] [PASSED] drm_test_drm_connector_dynamic_register_sysfs
[02:04:02] [PASSED] drm_test_drm_connector_dynamic_register_sysfs_name
[02:04:02] [PASSED] drm_test_drm_connector_dynamic_register_debugfs
[02:04:02] ========= [PASSED] drm_connector_dynamic_register ==========
[02:04:02] = drm_connector_attach_broadcast_rgb_property (2 subtests) =
[02:04:02] [PASSED] drm_test_drm_connector_attach_broadcast_rgb_property
[02:04:02] [PASSED] drm_test_drm_connector_attach_broadcast_rgb_property_hdmi_connector
[02:04:02] === [PASSED] drm_connector_attach_broadcast_rgb_property ===
[02:04:02] ========== drm_get_tv_mode_from_name (2 subtests) ==========
[02:04:02] ========== drm_test_get_tv_mode_from_name_valid  ===========
[02:04:02] [PASSED] NTSC
[02:04:02] [PASSED] NTSC-443
[02:04:02] [PASSED] NTSC-J
[02:04:02] [PASSED] PAL
[02:04:02] [PASSED] PAL-M
[02:04:02] [PASSED] PAL-N
[02:04:02] [PASSED] SECAM
[02:04:02] [PASSED] Mono
[02:04:02] ====== [PASSED] drm_test_get_tv_mode_from_name_valid =======
[02:04:02] [PASSED] drm_test_get_tv_mode_from_name_truncated
[02:04:02] ============ [PASSED] drm_get_tv_mode_from_name ============
[02:04:02] = drm_test_connector_hdmi_compute_mode_clock (12 subtests) =
[02:04:02] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb
[02:04:02] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_10bpc
[02:04:02] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_10bpc_vic_1
[02:04:02] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_12bpc
[02:04:02] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_12bpc_vic_1
[02:04:02] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_double
[02:04:02] = drm_test_connector_hdmi_compute_mode_clock_yuv420_valid  =
[02:04:02] [PASSED] VIC 96
[02:04:02] [PASSED] VIC 97
[02:04:02] [PASSED] VIC 101
[02:04:02] [PASSED] VIC 102
[02:04:02] [PASSED] VIC 106
[02:04:02] [PASSED] VIC 107
[02:04:02] === [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_valid ===
[02:04:02] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_10_bpc
[02:04:02] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_12_bpc
[02:04:02] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_8_bpc
[02:04:02] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_10_bpc
[02:04:02] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_12_bpc
[02:04:02] === [PASSED] drm_test_connector_hdmi_compute_mode_clock ====
[02:04:02] == drm_hdmi_connector_get_broadcast_rgb_name (2 subtests) ==
[02:04:02] === drm_test_drm_hdmi_connector_get_broadcast_rgb_name  ====
[02:04:02] [PASSED] Automatic
[02:04:02] [PASSED] Full
[02:04:02] [PASSED] Limited 16:235
[02:04:02] === [PASSED] drm_test_drm_hdmi_connector_get_broadcast_rgb_name ===
[02:04:02] [PASSED] drm_test_drm_hdmi_connector_get_broadcast_rgb_name_invalid
[02:04:02] ==== [PASSED] drm_hdmi_connector_get_broadcast_rgb_name ====
[02:04:02] == drm_hdmi_connector_get_output_format_name (2 subtests) ==
[02:04:02] === drm_test_drm_hdmi_connector_get_output_format_name  ====
[02:04:02] [PASSED] RGB
[02:04:02] [PASSED] YUV 4:2:0
[02:04:02] [PASSED] YUV 4:2:2
[02:04:02] [PASSED] YUV 4:4:4
[02:04:02] === [PASSED] drm_test_drm_hdmi_connector_get_output_format_name ===
[02:04:02] [PASSED] drm_test_drm_hdmi_connector_get_output_format_name_invalid
[02:04:02] ==== [PASSED] drm_hdmi_connector_get_output_format_name ====
[02:04:02] ============= drm_damage_helper (21 subtests) ==============
[02:04:02] [PASSED] drm_test_damage_iter_no_damage
[02:04:02] [PASSED] drm_test_damage_iter_no_damage_fractional_src
[02:04:02] [PASSED] drm_test_damage_iter_no_damage_src_moved
[02:04:02] [PASSED] drm_test_damage_iter_no_damage_fractional_src_moved
[02:04:02] [PASSED] drm_test_damage_iter_no_damage_not_visible
[02:04:02] [PASSED] drm_test_damage_iter_no_damage_no_crtc
[02:04:02] [PASSED] drm_test_damage_iter_no_damage_no_fb
[02:04:02] [PASSED] drm_test_damage_iter_simple_damage
[02:04:02] [PASSED] drm_test_damage_iter_single_damage
[02:04:02] [PASSED] drm_test_damage_iter_single_damage_intersect_src
[02:04:02] [PASSED] drm_test_damage_iter_single_damage_outside_src
[02:04:02] [PASSED] drm_test_damage_iter_single_damage_fractional_src
[02:04:02] [PASSED] drm_test_damage_iter_single_damage_intersect_fractional_src
[02:04:02] [PASSED] drm_test_damage_iter_single_damage_outside_fractional_src
[02:04:02] [PASSED] drm_test_damage_iter_single_damage_src_moved
[02:04:02] [PASSED] drm_test_damage_iter_single_damage_fractional_src_moved
[02:04:02] [PASSED] drm_test_damage_iter_damage
[02:04:02] [PASSED] drm_test_damage_iter_damage_one_intersect
[02:04:02] [PASSED] drm_test_damage_iter_damage_one_outside
[02:04:02] [PASSED] drm_test_damage_iter_damage_src_moved
[02:04:02] [PASSED] drm_test_damage_iter_damage_not_visible
[02:04:02] ================ [PASSED] drm_damage_helper ================
[02:04:02] ============== drm_dp_mst_helper (3 subtests) ==============
[02:04:02] ============== drm_test_dp_mst_calc_pbn_mode  ==============
[02:04:02] [PASSED] Clock 154000 BPP 30 DSC disabled
[02:04:02] [PASSED] Clock 234000 BPP 30 DSC disabled
[02:04:02] [PASSED] Clock 297000 BPP 24 DSC disabled
[02:04:02] [PASSED] Clock 332880 BPP 24 DSC enabled
[02:04:02] [PASSED] Clock 324540 BPP 24 DSC enabled
[02:04:02] ========== [PASSED] drm_test_dp_mst_calc_pbn_mode ==========
[02:04:02] ============== drm_test_dp_mst_calc_pbn_div  ===============
[02:04:02] [PASSED] Link rate 2000000 lane count 4
[02:04:02] [PASSED] Link rate 2000000 lane count 2
[02:04:02] [PASSED] Link rate 2000000 lane count 1
[02:04:02] [PASSED] Link rate 1350000 lane count 4
[02:04:02] [PASSED] Link rate 1350000 lane count 2
[02:04:02] [PASSED] Link rate 1350000 lane count 1
[02:04:02] [PASSED] Link rate 1000000 lane count 4
[02:04:02] [PASSED] Link rate 1000000 lane count 2
[02:04:02] [PASSED] Link rate 1000000 lane count 1
[02:04:02] [PASSED] Link rate 810000 lane count 4
[02:04:02] [PASSED] Link rate 810000 lane count 2
[02:04:02] [PASSED] Link rate 810000 lane count 1
[02:04:02] [PASSED] Link rate 540000 lane count 4
[02:04:02] [PASSED] Link rate 540000 lane count 2
[02:04:02] [PASSED] Link rate 540000 lane count 1
[02:04:02] [PASSED] Link rate 270000 lane count 4
[02:04:02] [PASSED] Link rate 270000 lane count 2
[02:04:02] [PASSED] Link rate 270000 lane count 1
[02:04:02] [PASSED] Link rate 162000 lane count 4
[02:04:02] [PASSED] Link rate 162000 lane count 2
[02:04:02] [PASSED] Link rate 162000 lane count 1
[02:04:02] ========== [PASSED] drm_test_dp_mst_calc_pbn_div ===========
[02:04:02] ========= drm_test_dp_mst_sideband_msg_req_decode  =========
[02:04:02] [PASSED] DP_ENUM_PATH_RESOURCES with port number
[02:04:02] [PASSED] DP_POWER_UP_PHY with port number
[02:04:02] [PASSED] DP_POWER_DOWN_PHY with port number
[02:04:02] [PASSED] DP_ALLOCATE_PAYLOAD with SDP stream sinks
[02:04:02] [PASSED] DP_ALLOCATE_PAYLOAD with port number
[02:04:02] [PASSED] DP_ALLOCATE_PAYLOAD with VCPI
[02:04:02] [PASSED] DP_ALLOCATE_PAYLOAD with PBN
[02:04:02] [PASSED] DP_QUERY_PAYLOAD with port number
[02:04:02] [PASSED] DP_QUERY_PAYLOAD with VCPI
[02:04:02] [PASSED] DP_REMOTE_DPCD_READ with port number
[02:04:02] [PASSED] DP_REMOTE_DPCD_READ with DPCD address
[02:04:02] [PASSED] DP_REMOTE_DPCD_READ with max number of bytes
[02:04:02] [PASSED] DP_REMOTE_DPCD_WRITE with port number
[02:04:02] [PASSED] DP_REMOTE_DPCD_WRITE with DPCD address
[02:04:02] [PASSED] DP_REMOTE_DPCD_WRITE with data array
[02:04:02] [PASSED] DP_REMOTE_I2C_READ with port number
[02:04:02] [PASSED] DP_REMOTE_I2C_READ with I2C device ID
[02:04:02] [PASSED] DP_REMOTE_I2C_READ with transactions array
[02:04:02] [PASSED] DP_REMOTE_I2C_WRITE with port number
[02:04:02] [PASSED] DP_REMOTE_I2C_WRITE with I2C device ID
[02:04:02] [PASSED] DP_REMOTE_I2C_WRITE with data array
[02:04:02] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream ID
[02:04:02] [PASSED] DP_QUERY_STREAM_ENC_STATUS with client ID
[02:04:02] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream event
[02:04:02] [PASSED] DP_QUERY_STREAM_ENC_STATUS with valid stream event
[02:04:02] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream behavior
[02:04:02] [PASSED] DP_QUERY_STREAM_ENC_STATUS with a valid stream behavior
[02:04:02] ===== [PASSED] drm_test_dp_mst_sideband_msg_req_decode =====
[02:04:02] ================ [PASSED] drm_dp_mst_helper ================
[02:04:02] ================== drm_exec (7 subtests) ===================
[02:04:02] [PASSED] sanitycheck
[02:04:02] [PASSED] test_lock
[02:04:02] [PASSED] test_lock_unlock
[02:04:02] [PASSED] test_duplicates
[02:04:02] [PASSED] test_prepare
[02:04:02] [PASSED] test_prepare_array
[02:04:02] [PASSED] test_multiple_loops
[02:04:02] ==================== [PASSED] drm_exec =====================
[02:04:02] =========== drm_format_helper_test (17 subtests) ===========
[02:04:02] ============== drm_test_fb_xrgb8888_to_gray8  ==============
[02:04:02] [PASSED] single_pixel_source_buffer
[02:04:02] [PASSED] single_pixel_clip_rectangle
[02:04:02] [PASSED] well_known_colors
[02:04:02] [PASSED] destination_pitch
[02:04:02] ========== [PASSED] drm_test_fb_xrgb8888_to_gray8 ==========
[02:04:02] ============= drm_test_fb_xrgb8888_to_rgb332  ==============
[02:04:02] [PASSED] single_pixel_source_buffer
[02:04:02] [PASSED] single_pixel_clip_rectangle
[02:04:02] [PASSED] well_known_colors
[02:04:02] [PASSED] destination_pitch
[02:04:02] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb332 ==========
[02:04:02] ============= drm_test_fb_xrgb8888_to_rgb565  ==============
[02:04:02] [PASSED] single_pixel_source_buffer
[02:04:02] [PASSED] single_pixel_clip_rectangle
[02:04:02] [PASSED] well_known_colors
[02:04:02] [PASSED] destination_pitch
[02:04:02] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb565 ==========
[02:04:02] ============ drm_test_fb_xrgb8888_to_xrgb1555  =============
[02:04:02] [PASSED] single_pixel_source_buffer
[02:04:02] [PASSED] single_pixel_clip_rectangle
[02:04:02] [PASSED] well_known_colors
[02:04:02] [PASSED] destination_pitch
[02:04:02] ======== [PASSED] drm_test_fb_xrgb8888_to_xrgb1555 =========
[02:04:02] ============ drm_test_fb_xrgb8888_to_argb1555  =============
[02:04:02] [PASSED] single_pixel_source_buffer
[02:04:02] [PASSED] single_pixel_clip_rectangle
[02:04:02] [PASSED] well_known_colors
[02:04:02] [PASSED] destination_pitch
[02:04:02] ======== [PASSED] drm_test_fb_xrgb8888_to_argb1555 =========
[02:04:02] ============ drm_test_fb_xrgb8888_to_rgba5551  =============
[02:04:02] [PASSED] single_pixel_source_buffer
[02:04:02] [PASSED] single_pixel_clip_rectangle
[02:04:02] [PASSED] well_known_colors
[02:04:02] [PASSED] destination_pitch
[02:04:02] ======== [PASSED] drm_test_fb_xrgb8888_to_rgba5551 =========
[02:04:02] ============= drm_test_fb_xrgb8888_to_rgb888  ==============
[02:04:02] [PASSED] single_pixel_source_buffer
[02:04:02] [PASSED] single_pixel_clip_rectangle
[02:04:02] [PASSED] well_known_colors
[02:04:02] [PASSED] destination_pitch
[02:04:02] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb888 ==========
[02:04:02] ============= drm_test_fb_xrgb8888_to_bgr888  ==============
[02:04:02] [PASSED] single_pixel_source_buffer
[02:04:02] [PASSED] single_pixel_clip_rectangle
[02:04:02] [PASSED] well_known_colors
[02:04:02] [PASSED] destination_pitch
[02:04:02] ========= [PASSED] drm_test_fb_xrgb8888_to_bgr888 ==========
[02:04:02] ============ drm_test_fb_xrgb8888_to_argb8888  =============
[02:04:02] [PASSED] single_pixel_source_buffer
[02:04:02] [PASSED] single_pixel_clip_rectangle
[02:04:02] [PASSED] well_known_colors
[02:04:02] [PASSED] destination_pitch
[02:04:02] ======== [PASSED] drm_test_fb_xrgb8888_to_argb8888 =========
[02:04:02] =========== drm_test_fb_xrgb8888_to_xrgb2101010  ===========
[02:04:02] [PASSED] single_pixel_source_buffer
[02:04:02] [PASSED] single_pixel_clip_rectangle
[02:04:02] [PASSED] well_known_colors
[02:04:02] [PASSED] destination_pitch
[02:04:02] ======= [PASSED] drm_test_fb_xrgb8888_to_xrgb2101010 =======
[02:04:02] =========== drm_test_fb_xrgb8888_to_argb2101010  ===========
[02:04:02] [PASSED] single_pixel_source_buffer
[02:04:02] [PASSED] single_pixel_clip_rectangle
[02:04:02] [PASSED] well_known_colors
[02:04:02] [PASSED] destination_pitch
[02:04:02] ======= [PASSED] drm_test_fb_xrgb8888_to_argb2101010 =======
[02:04:02] ============== drm_test_fb_xrgb8888_to_mono  ===============
[02:04:02] [PASSED] single_pixel_source_buffer
[02:04:02] [PASSED] single_pixel_clip_rectangle
[02:04:02] [PASSED] well_known_colors
[02:04:02] [PASSED] destination_pitch
[02:04:02] ========== [PASSED] drm_test_fb_xrgb8888_to_mono ===========
[02:04:02] ==================== drm_test_fb_swab  =====================
[02:04:02] [PASSED] single_pixel_source_buffer
[02:04:02] [PASSED] single_pixel_clip_rectangle
[02:04:02] [PASSED] well_known_colors
[02:04:02] [PASSED] destination_pitch
[02:04:02] ================ [PASSED] drm_test_fb_swab =================
[02:04:02] ============ drm_test_fb_xrgb8888_to_xbgr8888  =============
[02:04:02] [PASSED] single_pixel_source_buffer
[02:04:02] [PASSED] single_pixel_clip_rectangle
[02:04:02] [PASSED] well_known_colors
[02:04:02] [PASSED] destination_pitch
[02:04:02] ======== [PASSED] drm_test_fb_xrgb8888_to_xbgr8888 =========
[02:04:02] ============ drm_test_fb_xrgb8888_to_abgr8888  =============
[02:04:02] [PASSED] single_pixel_source_buffer
[02:04:02] [PASSED] single_pixel_clip_rectangle
[02:04:02] [PASSED] well_known_colors
[02:04:02] [PASSED] destination_pitch
[02:04:02] ======== [PASSED] drm_test_fb_xrgb8888_to_abgr8888 =========
[02:04:02] ================= drm_test_fb_clip_offset  =================
[02:04:02] [PASSED] pass through
[02:04:02] [PASSED] horizontal offset
[02:04:02] [PASSED] vertical offset
[02:04:02] [PASSED] horizontal and vertical offset
[02:04:02] [PASSED] horizontal offset (custom pitch)
[02:04:02] [PASSED] vertical offset (custom pitch)
[02:04:02] [PASSED] horizontal and vertical offset (custom pitch)
[02:04:02] ============= [PASSED] drm_test_fb_clip_offset =============
[02:04:02] =================== drm_test_fb_memcpy  ====================
[02:04:02] [PASSED] single_pixel_source_buffer: XR24 little-endian (0x34325258)
[02:04:02] [PASSED] single_pixel_source_buffer: XRA8 little-endian (0x38415258)
[02:04:02] [PASSED] single_pixel_source_buffer: YU24 little-endian (0x34325559)
[02:04:02] [PASSED] single_pixel_clip_rectangle: XB24 little-endian (0x34324258)
[02:04:02] [PASSED] single_pixel_clip_rectangle: XRA8 little-endian (0x38415258)
[02:04:02] [PASSED] single_pixel_clip_rectangle: YU24 little-endian (0x34325559)
[02:04:02] [PASSED] well_known_colors: XB24 little-endian (0x34324258)
[02:04:02] [PASSED] well_known_colors: XRA8 little-endian (0x38415258)
[02:04:02] [PASSED] well_known_colors: YU24 little-endian (0x34325559)
[02:04:02] [PASSED] destination_pitch: XB24 little-endian (0x34324258)
[02:04:02] [PASSED] destination_pitch: XRA8 little-endian (0x38415258)
[02:04:02] [PASSED] destination_pitch: YU24 little-endian (0x34325559)
[02:04:02] =============== [PASSED] drm_test_fb_memcpy ================
[02:04:02] ============= [PASSED] drm_format_helper_test ==============
[02:04:02] ================= drm_format (18 subtests) =================
[02:04:02] [PASSED] drm_test_format_block_width_invalid
[02:04:02] [PASSED] drm_test_format_block_width_one_plane
[02:04:02] [PASSED] drm_test_format_block_width_two_plane
[02:04:02] [PASSED] drm_test_format_block_width_three_plane
[02:04:02] [PASSED] drm_test_format_block_width_tiled
[02:04:02] [PASSED] drm_test_format_block_height_invalid
[02:04:02] [PASSED] drm_test_format_block_height_one_plane
[02:04:02] [PASSED] drm_test_format_block_height_two_plane
[02:04:02] [PASSED] drm_test_format_block_height_three_plane
[02:04:02] [PASSED] drm_test_format_block_height_tiled
[02:04:02] [PASSED] drm_test_format_min_pitch_invalid
[02:04:02] [PASSED] drm_test_format_min_pitch_one_plane_8bpp
[02:04:02] [PASSED] drm_test_format_min_pitch_one_plane_16bpp
[02:04:02] [PASSED] drm_test_format_min_pitch_one_plane_24bpp
[02:04:02] [PASSED] drm_test_format_min_pitch_one_plane_32bpp
[02:04:02] [PASSED] drm_test_format_min_pitch_two_plane
[02:04:02] [PASSED] drm_test_format_min_pitch_three_plane_8bpp
[02:04:02] [PASSED] drm_test_format_min_pitch_tiled
[02:04:02] =================== [PASSED] drm_format ====================
[02:04:02] ============== drm_framebuffer (10 subtests) ===============
[02:04:02] ========== drm_test_framebuffer_check_src_coords  ==========
[02:04:02] [PASSED] Success: source fits into fb
[02:04:02] [PASSED] Fail: overflowing fb with x-axis coordinate
[02:04:02] [PASSED] Fail: overflowing fb with y-axis coordinate
[02:04:02] [PASSED] Fail: overflowing fb with source width
[02:04:02] [PASSED] Fail: overflowing fb with source height
[02:04:02] ====== [PASSED] drm_test_framebuffer_check_src_coords ======
[02:04:02] [PASSED] drm_test_framebuffer_cleanup
[02:04:02] =============== drm_test_framebuffer_create  ===============
[02:04:02] [PASSED] ABGR8888 normal sizes
[02:04:02] [PASSED] ABGR8888 max sizes
[02:04:02] [PASSED] ABGR8888 pitch greater than min required
[02:04:02] [PASSED] ABGR8888 pitch less than min required
[02:04:02] [PASSED] ABGR8888 Invalid width
[02:04:02] [PASSED] ABGR8888 Invalid buffer handle
[02:04:02] [PASSED] No pixel format
[02:04:02] [PASSED] ABGR8888 Width 0
[02:04:02] [PASSED] ABGR8888 Height 0
[02:04:02] [PASSED] ABGR8888 Out of bound height * pitch combination
[02:04:02] [PASSED] ABGR8888 Large buffer offset
[02:04:02] [PASSED] ABGR8888 Buffer offset for inexistent plane
[02:04:02] [PASSED] ABGR8888 Invalid flag
[02:04:02] [PASSED] ABGR8888 Set DRM_MODE_FB_MODIFIERS without modifiers
[02:04:02] [PASSED] ABGR8888 Valid buffer modifier
[02:04:02] [PASSED] ABGR8888 Invalid buffer modifier(DRM_FORMAT_MOD_SAMSUNG_64_32_TILE)
[02:04:02] [PASSED] ABGR8888 Extra pitches without DRM_MODE_FB_MODIFIERS
[02:04:02] [PASSED] ABGR8888 Extra pitches with DRM_MODE_FB_MODIFIERS
[02:04:02] [PASSED] NV12 Normal sizes
[02:04:02] [PASSED] NV12 Max sizes
[02:04:02] [PASSED] NV12 Invalid pitch
[02:04:02] [PASSED] NV12 Invalid modifier/missing DRM_MODE_FB_MODIFIERS flag
[02:04:02] [PASSED] NV12 different  modifier per-plane
[02:04:02] [PASSED] NV12 with DRM_FORMAT_MOD_SAMSUNG_64_32_TILE
[02:04:02] [PASSED] NV12 Valid modifiers without DRM_MODE_FB_MODIFIERS
[02:04:02] [PASSED] NV12 Modifier for inexistent plane
[02:04:02] [PASSED] NV12 Handle for inexistent plane
[02:04:02] [PASSED] NV12 Handle for inexistent plane without DRM_MODE_FB_MODIFIERS
[02:04:02] [PASSED] YVU420 DRM_MODE_FB_MODIFIERS set without modifier
[02:04:02] [PASSED] YVU420 Normal sizes
[02:04:02] [PASSED] YVU420 Max sizes
[02:04:02] [PASSED] YVU420 Invalid pitch
[02:04:02] [PASSED] YVU420 Different pitches
[02:04:02] [PASSED] YVU420 Different buffer offsets/pitches
[02:04:02] [PASSED] YVU420 Modifier set just for plane 0, without DRM_MODE_FB_MODIFIERS
[02:04:02] [PASSED] YVU420 Modifier set just for planes 0, 1, without DRM_MODE_FB_MODIFIERS
[02:04:02] [PASSED] YVU420 Modifier set just for plane 0, 1, with DRM_MODE_FB_MODIFIERS
[02:04:02] [PASSED] YVU420 Valid modifier
[02:04:02] [PASSED] YVU420 Different modifiers per plane
[02:04:02] [PASSED] YVU420 Modifier for inexistent plane
[02:04:02] [PASSED] YUV420_10BIT Invalid modifier(DRM_FORMAT_MOD_LINEAR)
[02:04:02] [PASSED] X0L2 Normal sizes
[02:04:02] [PASSED] X0L2 Max sizes
[02:04:02] [PASSED] X0L2 Invalid pitch
[02:04:02] [PASSED] X0L2 Pitch greater than minimum required
[02:04:02] [PASSED] X0L2 Handle for inexistent plane
[02:04:02] [PASSED] X0L2 Offset for inexistent plane, without DRM_MODE_FB_MODIFIERS set
[02:04:02] [PASSED] X0L2 Modifier without DRM_MODE_FB_MODIFIERS set
[02:04:02] [PASSED] X0L2 Valid modifier
[02:04:02] [PASSED] X0L2 Modifier for inexistent plane
[02:04:02] =========== [PASSED] drm_test_framebuffer_create ===========
[02:04:02] [PASSED] drm_test_framebuffer_free
[02:04:02] [PASSED] drm_test_framebuffer_init
[02:04:02] [PASSED] drm_test_framebuffer_init_bad_format
[02:04:02] [PASSED] drm_test_framebuffer_init_dev_mismatch
[02:04:02] [PASSED] drm_test_framebuffer_lookup
[02:04:02] [PASSED] drm_test_framebuffer_lookup_inexistent
[02:04:02] [PASSED] drm_test_framebuffer_modifiers_not_supported
[02:04:02] ================= [PASSED] drm_framebuffer =================
[02:04:02] ================ drm_gem_shmem (8 subtests) ================
[02:04:02] [PASSED] drm_gem_shmem_test_obj_create
[02:04:02] [PASSED] drm_gem_shmem_test_obj_create_private
[02:04:02] [PASSED] drm_gem_shmem_test_pin_pages
[02:04:02] [PASSED] drm_gem_shmem_test_vmap
[02:04:02] [PASSED] drm_gem_shmem_test_get_sg_table
[02:04:02] [PASSED] drm_gem_shmem_test_get_pages_sgt
[02:04:02] [PASSED] drm_gem_shmem_test_madvise
[02:04:02] [PASSED] drm_gem_shmem_test_purge
[02:04:02] ================== [PASSED] drm_gem_shmem ==================
[02:04:02] === drm_atomic_helper_connector_hdmi_check (27 subtests) ===
[02:04:02] [PASSED] drm_test_check_broadcast_rgb_auto_cea_mode
[02:04:02] [PASSED] drm_test_check_broadcast_rgb_auto_cea_mode_vic_1
[02:04:02] [PASSED] drm_test_check_broadcast_rgb_full_cea_mode
[02:04:02] [PASSED] drm_test_check_broadcast_rgb_full_cea_mode_vic_1
[02:04:02] [PASSED] drm_test_check_broadcast_rgb_limited_cea_mode
[02:04:02] [PASSED] drm_test_check_broadcast_rgb_limited_cea_mode_vic_1
[02:04:02] ====== drm_test_check_broadcast_rgb_cea_mode_yuv420  =======
[02:04:02] [PASSED] Automatic
[02:04:02] [PASSED] Full
[02:04:02] [PASSED] Limited 16:235
[02:04:02] == [PASSED] drm_test_check_broadcast_rgb_cea_mode_yuv420 ===
[02:04:02] [PASSED] drm_test_check_broadcast_rgb_crtc_mode_changed
[02:04:02] [PASSED] drm_test_check_broadcast_rgb_crtc_mode_not_changed
[02:04:02] [PASSED] drm_test_check_disable_connector
[02:04:02] [PASSED] drm_test_check_hdmi_funcs_reject_rate
[02:04:02] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_rgb
[02:04:02] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_yuv420
[02:04:02] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_ignore_yuv422
[02:04:02] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_ignore_yuv420
[02:04:02] [PASSED] drm_test_check_driver_unsupported_fallback_yuv420
[02:04:02] [PASSED] drm_test_check_output_bpc_crtc_mode_changed
[02:04:02] [PASSED] drm_test_check_output_bpc_crtc_mode_not_changed
[02:04:02] [PASSED] drm_test_check_output_bpc_dvi
[02:04:02] [PASSED] drm_test_check_output_bpc_format_vic_1
[02:04:02] [PASSED] drm_test_check_output_bpc_format_display_8bpc_only
[02:04:02] [PASSED] drm_test_check_output_bpc_format_display_rgb_only
[02:04:02] [PASSED] drm_test_check_output_bpc_format_driver_8bpc_only
[02:04:02] [PASSED] drm_test_check_output_bpc_format_driver_rgb_only
[02:04:02] [PASSED] drm_test_check_tmds_char_rate_rgb_8bpc
[02:04:02] [PASSED] drm_test_check_tmds_char_rate_rgb_10bpc
[02:04:02] [PASSED] drm_test_check_tmds_char_rate_rgb_12bpc
[02:04:02] ===== [PASSED] drm_atomic_helper_connector_hdmi_check ======
[02:04:02] === drm_atomic_helper_connector_hdmi_reset (6 subtests) ====
[02:04:02] [PASSED] drm_test_check_broadcast_rgb_value
[02:04:02] [PASSED] drm_test_check_bpc_8_value
[02:04:02] [PASSED] drm_test_check_bpc_10_value
[02:04:02] [PASSED] drm_test_check_bpc_12_value
[02:04:02] [PASSED] drm_test_check_format_value
[02:04:02] [PASSED] drm_test_check_tmds_char_value
[02:04:02] ===== [PASSED] drm_atomic_helper_connector_hdmi_reset ======
[02:04:02] = drm_atomic_helper_connector_hdmi_mode_valid (4 subtests) =
[02:04:02] [PASSED] drm_test_check_mode_valid
[02:04:02] [PASSED] drm_test_check_mode_valid_reject
[02:04:02] [PASSED] drm_test_check_mode_valid_reject_rate
[02:04:02] [PASSED] drm_test_check_mode_valid_reject_max_clock
[02:04:02] === [PASSED] drm_atomic_helper_connector_hdmi_mode_valid ===
[02:04:02] = drm_atomic_helper_connector_hdmi_infoframes (5 subtests) =
[02:04:02] [PASSED] drm_test_check_infoframes
[02:04:02] [PASSED] drm_test_check_reject_avi_infoframe
[02:04:02] [PASSED] drm_test_check_reject_hdr_infoframe_bpc_8
[02:04:02] [PASSED] drm_test_check_reject_hdr_infoframe_bpc_10
[02:04:02] [PASSED] drm_test_check_reject_audio_infoframe
[02:04:02] === [PASSED] drm_atomic_helper_connector_hdmi_infoframes ===
[02:04:02] ================= drm_managed (2 subtests) =================
[02:04:02] [PASSED] drm_test_managed_release_action
[02:04:02] [PASSED] drm_test_managed_run_action
[02:04:02] =================== [PASSED] drm_managed ===================
[02:04:02] =================== drm_mm (6 subtests) ====================
[02:04:02] [PASSED] drm_test_mm_init
[02:04:02] [PASSED] drm_test_mm_debug
[02:04:02] [PASSED] drm_test_mm_align32
[02:04:02] [PASSED] drm_test_mm_align64
[02:04:02] [PASSED] drm_test_mm_lowest
[02:04:02] [PASSED] drm_test_mm_highest
[02:04:02] ===================== [PASSED] drm_mm ======================
[02:04:02] ============= drm_modes_analog_tv (5 subtests) =============
[02:04:02] [PASSED] drm_test_modes_analog_tv_mono_576i
[02:04:02] [PASSED] drm_test_modes_analog_tv_ntsc_480i
[02:04:02] [PASSED] drm_test_modes_analog_tv_ntsc_480i_inlined
[02:04:02] [PASSED] drm_test_modes_analog_tv_pal_576i
[02:04:02] [PASSED] drm_test_modes_analog_tv_pal_576i_inlined
[02:04:02] =============== [PASSED] drm_modes_analog_tv ===============
[02:04:02] ============== drm_plane_helper (2 subtests) ===============
[02:04:02] =============== drm_test_check_plane_state  ================
[02:04:02] [PASSED] clipping_simple
[02:04:02] [PASSED] clipping_rotate_reflect
[02:04:02] [PASSED] positioning_simple
[02:04:02] [PASSED] upscaling
[02:04:02] [PASSED] downscaling
[02:04:02] [PASSED] rounding1
[02:04:02] [PASSED] rounding2
[02:04:02] [PASSED] rounding3
[02:04:02] [PASSED] rounding4
[02:04:02] =========== [PASSED] drm_test_check_plane_state ============
[02:04:02] =========== drm_test_check_invalid_plane_state  ============
[02:04:02] [PASSED] positioning_invalid
[02:04:02] [PASSED] upscaling_invalid
[02:04:02] [PASSED] downscaling_invalid
[02:04:02] ======= [PASSED] drm_test_check_invalid_plane_state ========
[02:04:02] ================ [PASSED] drm_plane_helper =================
[02:04:02] ====== drm_connector_helper_tv_get_modes (1 subtest) =======
[02:04:02] ====== drm_test_connector_helper_tv_get_modes_check  =======
[02:04:02] [PASSED] None
[02:04:02] [PASSED] PAL
[02:04:02] [PASSED] NTSC
[02:04:02] [PASSED] Both, NTSC Default
[02:04:02] [PASSED] Both, PAL Default
[02:04:02] [PASSED] Both, NTSC Default, with PAL on command-line
[02:04:02] [PASSED] Both, PAL Default, with NTSC on command-line
[02:04:02] == [PASSED] drm_test_connector_helper_tv_get_modes_check ===
[02:04:02] ======== [PASSED] drm_connector_helper_tv_get_modes ========
[02:04:02] ================== drm_rect (9 subtests) ===================
[02:04:02] [PASSED] drm_test_rect_clip_scaled_div_by_zero
[02:04:02] [PASSED] drm_test_rect_clip_scaled_not_clipped
[02:04:02] [PASSED] drm_test_rect_clip_scaled_clipped
[02:04:02] [PASSED] drm_test_rect_clip_scaled_signed_vs_unsigned
[02:04:02] ================= drm_test_rect_intersect  =================
[02:04:02] [PASSED] top-left x bottom-right: 2x2+1+1 x 2x2+0+0
[02:04:02] [PASSED] top-right x bottom-left: 2x2+0+0 x 2x2+1-1
[02:04:02] [PASSED] bottom-left x top-right: 2x2+1-1 x 2x2+0+0
[02:04:02] [PASSED] bottom-right x top-left: 2x2+0+0 x 2x2+1+1
[02:04:02] [PASSED] right x left: 2x1+0+0 x 3x1+1+0
[02:04:02] [PASSED] left x right: 3x1+1+0 x 2x1+0+0
[02:04:02] [PASSED] up x bottom: 1x2+0+0 x 1x3+0-1
[02:04:02] [PASSED] bottom x up: 1x3+0-1 x 1x2+0+0
[02:04:02] [PASSED] touching corner: 1x1+0+0 x 2x2+1+1
[02:04:02] [PASSED] touching side: 1x1+0+0 x 1x1+1+0
[02:04:02] [PASSED] equal rects: 2x2+0+0 x 2x2+0+0
[02:04:02] [PASSED] inside another: 2x2+0+0 x 1x1+1+1
[02:04:02] [PASSED] far away: 1x1+0+0 x 1x1+3+6
[02:04:02] [PASSED] points intersecting: 0x0+5+10 x 0x0+5+10
[02:04:02] [PASSED] points not intersecting: 0x0+0+0 x 0x0+5+10
[02:04:02] ============= [PASSED] drm_test_rect_intersect =============
[02:04:02] ================ drm_test_rect_calc_hscale  ================
[02:04:02] [PASSED] normal use
[02:04:02] [PASSED] out of max range
[02:04:02] [PASSED] out of min range
[02:04:02] [PASSED] zero dst
[02:04:02] [PASSED] negative src
[02:04:02] [PASSED] negative dst
[02:04:02] ============ [PASSED] drm_test_rect_calc_hscale ============
[02:04:02] ================ drm_test_rect_calc_vscale  ================
[02:04:02] [PASSED] normal use
[02:04:02] [PASSED] out of max range
[02:04:02] [PASSED] out of min range
[02:04:02] [PASSED] zero dst
[02:04:02] [PASSED] negative src
[02:04:02] [PASSED] negative dst
stty: 'standard input': Inappropriate ioctl for device
[02:04:02] ============ [PASSED] drm_test_rect_calc_vscale ============
[02:04:02] ================== drm_test_rect_rotate  ===================
[02:04:02] [PASSED] reflect-x
[02:04:02] [PASSED] reflect-y
[02:04:02] [PASSED] rotate-0
[02:04:02] [PASSED] rotate-90
[02:04:02] [PASSED] rotate-180
[02:04:02] [PASSED] rotate-270
[02:04:02] ============== [PASSED] drm_test_rect_rotate ===============
[02:04:02] ================ drm_test_rect_rotate_inv  =================
[02:04:02] [PASSED] reflect-x
[02:04:02] [PASSED] reflect-y
[02:04:02] [PASSED] rotate-0
[02:04:02] [PASSED] rotate-90
[02:04:02] [PASSED] rotate-180
[02:04:02] [PASSED] rotate-270
[02:04:02] ============ [PASSED] drm_test_rect_rotate_inv =============
[02:04:02] ==================== [PASSED] drm_rect =====================
[02:04:02] ============ drm_sysfb_modeset_test (1 subtest) ============
[02:04:02] ============ drm_test_sysfb_build_fourcc_list  =============
[02:04:02] [PASSED] no native formats
[02:04:02] [PASSED] XRGB8888 as native format
[02:04:02] [PASSED] remove duplicates
[02:04:02] [PASSED] convert alpha formats
[02:04:02] [PASSED] random formats
[02:04:02] ======== [PASSED] drm_test_sysfb_build_fourcc_list =========
[02:04:02] ============= [PASSED] drm_sysfb_modeset_test ==============
[02:04:02] ================== drm_fixp (2 subtests) ===================
[02:04:02] [PASSED] drm_test_int2fixp
[02:04:02] [PASSED] drm_test_sm2fixp
[02:04:02] ==================== [PASSED] drm_fixp =====================
[02:04:02] ============================================================
[02:04:02] Testing complete. Ran 621 tests: passed: 621
[02:04:02] Elapsed time: 26.061s total, 1.730s configuring, 24.163s building, 0.128s running

+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/ttm/tests/.kunitconfig [02:04:02] Configuring KUnit Kernel ...
Regenerating .config ...
Populating config with:

$ make ARCH=um O=.kunit olddefconfig
[02:04:04] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48
[02:04:13] Starting KUnit Kernel (1/1)...
[02:04:13] ============================================================
Running tests with:
$ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt
[02:04:13] ================= ttm_device (5 subtests) ==================
[02:04:13] [PASSED] ttm_device_init_basic
[02:04:13] [PASSED] ttm_device_init_multiple
[02:04:13] [PASSED] ttm_device_fini_basic
[02:04:13] [PASSED] ttm_device_init_no_vma_man
[02:04:13] ================== ttm_device_init_pools  ==================
[02:04:13] [PASSED] No DMA allocations, no DMA32 required
[02:04:13] [PASSED] DMA allocations, DMA32 required
[02:04:13] [PASSED] No DMA allocations, DMA32 required
[02:04:13] [PASSED] DMA allocations, no DMA32 required
[02:04:13] ============== [PASSED] ttm_device_init_pools ==============
[02:04:13] =================== [PASSED] ttm_device ====================
[02:04:13] ================== ttm_pool (8 subtests) ===================
[02:04:13] ================== ttm_pool_alloc_basic  ===================
[02:04:13] [PASSED] One page
[02:04:13] [PASSED] More than one page
[02:04:13] [PASSED] Above the allocation limit
[02:04:13] [PASSED] One page, with coherent DMA mappings enabled
[02:04:13] [PASSED] Above the allocation limit, with coherent DMA mappings enabled
[02:04:13] ============== [PASSED] ttm_pool_alloc_basic ===============
[02:04:13] ============== ttm_pool_alloc_basic_dma_addr  ==============
[02:04:13] [PASSED] One page
[02:04:13] [PASSED] More than one page
[02:04:13] [PASSED] Above the allocation limit
[02:04:13] [PASSED] One page, with coherent DMA mappings enabled
[02:04:13] [PASSED] Above the allocation limit, with coherent DMA mappings enabled
[02:04:13] ========== [PASSED] ttm_pool_alloc_basic_dma_addr ==========
[02:04:13] [PASSED] ttm_pool_alloc_order_caching_match
[02:04:13] [PASSED] ttm_pool_alloc_caching_mismatch
[02:04:13] [PASSED] ttm_pool_alloc_order_mismatch
[02:04:13] [PASSED] ttm_pool_free_dma_alloc
[02:04:13] [PASSED] ttm_pool_free_no_dma_alloc
[02:04:13] [PASSED] ttm_pool_fini_basic
[02:04:13] ==================== [PASSED] ttm_pool =====================
[02:04:13] ================ ttm_resource (8 subtests) =================
[02:04:13] ================= ttm_resource_init_basic  =================
[02:04:13] [PASSED] Init resource in TTM_PL_SYSTEM
[02:04:13] [PASSED] Init resource in TTM_PL_VRAM
[02:04:13] [PASSED] Init resource in a private placement
[02:04:13] [PASSED] Init resource in TTM_PL_SYSTEM, set placement flags
[02:04:13] ============= [PASSED] ttm_resource_init_basic =============
[02:04:13] [PASSED] ttm_resource_init_pinned
[02:04:13] [PASSED] ttm_resource_fini_basic
[02:04:13] [PASSED] ttm_resource_manager_init_basic
[02:04:13] [PASSED] ttm_resource_manager_usage_basic
[02:04:13] [PASSED] ttm_resource_manager_set_used_basic
[02:04:13] [PASSED] ttm_sys_man_alloc_basic
[02:04:13] [PASSED] ttm_sys_man_free_basic
[02:04:13] ================== [PASSED] ttm_resource ===================
[02:04:13] =================== ttm_tt (15 subtests) ===================
[02:04:13] ==================== ttm_tt_init_basic  ====================
[02:04:13] [PASSED] Page-aligned size
[02:04:13] [PASSED] Extra pages requested
[02:04:13] ================ [PASSED] ttm_tt_init_basic ================
[02:04:13] [PASSED] ttm_tt_init_misaligned
[02:04:13] [PASSED] ttm_tt_fini_basic
[02:04:13] [PASSED] ttm_tt_fini_sg
[02:04:13] [PASSED] ttm_tt_fini_shmem
[02:04:13] [PASSED] ttm_tt_create_basic
[02:04:13] [PASSED] ttm_tt_create_invalid_bo_type
[02:04:13] [PASSED] ttm_tt_create_ttm_exists
[02:04:13] [PASSED] ttm_tt_create_failed
[02:04:13] [PASSED] ttm_tt_destroy_basic
[02:04:13] [PASSED] ttm_tt_populate_null_ttm
[02:04:13] [PASSED] ttm_tt_populate_populated_ttm
[02:04:13] [PASSED] ttm_tt_unpopulate_basic
[02:04:13] [PASSED] ttm_tt_unpopulate_empty_ttm
[02:04:13] [PASSED] ttm_tt_swapin_basic
[02:04:13] ===================== [PASSED] ttm_tt ======================
[02:04:13] =================== ttm_bo (14 subtests) ===================
[02:04:13] =========== ttm_bo_reserve_optimistic_no_ticket  ===========
[02:04:13] [PASSED] Cannot be interrupted and sleeps
[02:04:13] [PASSED] Cannot be interrupted, locks straight away
[02:04:13] [PASSED] Can be interrupted, sleeps
[02:04:13] ======= [PASSED] ttm_bo_reserve_optimistic_no_ticket =======
[02:04:13] [PASSED] ttm_bo_reserve_locked_no_sleep
[02:04:13] [PASSED] ttm_bo_reserve_no_wait_ticket
[02:04:13] [PASSED] ttm_bo_reserve_double_resv
[02:04:13] [PASSED] ttm_bo_reserve_interrupted
[02:04:13] [PASSED] ttm_bo_reserve_deadlock
[02:04:13] [PASSED] ttm_bo_unreserve_basic
[02:04:13] [PASSED] ttm_bo_unreserve_pinned
[02:04:13] [PASSED] ttm_bo_unreserve_bulk
[02:04:13] [PASSED] ttm_bo_fini_basic
[02:04:13] [PASSED] ttm_bo_fini_shared_resv
[02:04:13] [PASSED] ttm_bo_pin_basic
[02:04:13] [PASSED] ttm_bo_pin_unpin_resource
[02:04:13] [PASSED] ttm_bo_multiple_pin_one_unpin
[02:04:13] ===================== [PASSED] ttm_bo ======================
[02:04:13] ============== ttm_bo_validate (22 subtests) ===============
[02:04:13] ============== ttm_bo_init_reserved_sys_man  ===============
[02:04:13] [PASSED] Buffer object for userspace
[02:04:13] [PASSED] Kernel buffer object
[02:04:13] [PASSED] Shared buffer object
[02:04:13] ========== [PASSED] ttm_bo_init_reserved_sys_man ===========
[02:04:13] ============== ttm_bo_init_reserved_mock_man  ==============
[02:04:13] [PASSED] Buffer object for userspace
[02:04:13] [PASSED] Kernel buffer object
[02:04:13] [PASSED] Shared buffer object
[02:04:13] ========== [PASSED] ttm_bo_init_reserved_mock_man ==========
[02:04:13] [PASSED] ttm_bo_init_reserved_resv
[02:04:13] ================== ttm_bo_validate_basic  ==================
[02:04:13] [PASSED] Buffer object for userspace
[02:04:13] [PASSED] Kernel buffer object
[02:04:13] [PASSED] Shared buffer object
[02:04:13] ============== [PASSED] ttm_bo_validate_basic ==============
[02:04:13] [PASSED] ttm_bo_validate_invalid_placement
[02:04:13] ============= ttm_bo_validate_same_placement  ==============
[02:04:13] [PASSED] System manager
[02:04:13] [PASSED] VRAM manager
[02:04:13] ========= [PASSED] ttm_bo_validate_same_placement ==========
[02:04:13] [PASSED] ttm_bo_validate_failed_alloc
[02:04:13] [PASSED] ttm_bo_validate_pinned
[02:04:13] [PASSED] ttm_bo_validate_busy_placement
[02:04:13] ================ ttm_bo_validate_multihop  =================
[02:04:13] [PASSED] Buffer object for userspace
[02:04:13] [PASSED] Kernel buffer object
[02:04:13] [PASSED] Shared buffer object
[02:04:13] ============ [PASSED] ttm_bo_validate_multihop =============
[02:04:13] ========== ttm_bo_validate_no_placement_signaled  ==========
[02:04:13] [PASSED] Buffer object in system domain, no page vector
[02:04:13] [PASSED] Buffer object in system domain with an existing page vector
[02:04:13] ====== [PASSED] ttm_bo_validate_no_placement_signaled ======
[02:04:13] ======== ttm_bo_validate_no_placement_not_signaled  ========
[02:04:13] [PASSED] Buffer object for userspace
[02:04:13] [PASSED] Kernel buffer object
[02:04:13] [PASSED] Shared buffer object
[02:04:13] ==== [PASSED] ttm_bo_validate_no_placement_not_signaled ====
[02:04:13] [PASSED] ttm_bo_validate_move_fence_signaled
[02:04:13] ========= ttm_bo_validate_move_fence_not_signaled  =========
[02:04:13] [PASSED] Waits for GPU
[02:04:13] [PASSED] Tries to lock straight away
[02:04:13] ===== [PASSED] ttm_bo_validate_move_fence_not_signaled =====
[02:04:13] [PASSED] ttm_bo_validate_swapout
[02:04:13] [PASSED] ttm_bo_validate_happy_evict
[02:04:13] [PASSED] ttm_bo_validate_all_pinned_evict
[02:04:13] [PASSED] ttm_bo_validate_allowed_only_evict
[02:04:13] [PASSED] ttm_bo_validate_deleted_evict
[02:04:13] [PASSED] ttm_bo_validate_busy_domain_evict
[02:04:13] [PASSED] ttm_bo_validate_evict_gutting
[02:04:13] [PASSED] ttm_bo_validate_recrusive_evict
stty: 'standard input': Inappropriate ioctl for device
[02:04:13] ================= [PASSED] ttm_bo_validate =================
[02:04:13] ============================================================
[02:04:13] Testing complete. Ran 102 tests: passed: 102
[02:04:13] Elapsed time: 11.444s total, 1.681s configuring, 9.546s building, 0.186s running

+ cleanup
++ stat -c %u:%g /kernel
+ chown -R 1003:1003 /kernel

#35 lore raw

✗ CI.checksparse: warning for platform/x86/intel: Add ACPI PMT discovery support and enable NVL PMC telemetry

In reply to David E. Box
== Series Details ==

== Series Details ==

Series: platform/x86/intel: Add ACPI PMT discovery support and enable NVL PMC telemetry
URL : https://patchwork.freedesktop.org/series/163153/
State : warning

== Summary ==

+ trap cleanup EXIT
+ KERNEL=/kernel
+ MT=/root/linux/maintainer-tools
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools /root/linux/maintainer-tools Cloning into '/root/linux/maintainer-tools'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ make -C /root/linux/maintainer-tools
make: Entering directory '/root/linux/maintainer-tools'
cc -O2 -g -Wextra -o remap-log remap-log.c
make: Leaving directory '/root/linux/maintainer-tools'
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ /root/linux/maintainer-tools/dim sparse --fast 29044d219ec91738869fef9d445adce5e31df374 Sparse version: 0.6.4 (Ubuntu: 0.6.4-4ubuntu3)
Fast mode used, each commit won't be checked separately. +/kernel/Makefile:1204: C=1 specified, but sparse is not available or not up to date

+ cleanup
++ stat -c %u:%g /kernel
+ chown -R 1003:1003 /kernel

#36 lore raw

✓ Xe.CI.BAT: success for platform/x86/intel: Add ACPI PMT discovery support and enable NVL PMC telemetry

In reply to David E. Box
== Series Details ==

== Series Details ==

Series: platform/x86/intel: Add ACPI PMT discovery support and enable NVL PMC telemetry
URL : https://patchwork.freedesktop.org/series/163153/
State : success

== Summary ==

CI Bug Log - changes from xe-4710-29044d219ec91738869fef9d445adce5e31df374_BAT -> xe-pw-163153v1_BAT
====================================================

Summary
-------

**SUCCESS**

No regressions found.

Participating hosts (14 -> 14)
------------------------------

No changes in participating hosts

Known issues
------------

Here are the changes found in xe-pw-163153v1_BAT that come from known issues:

### IGT changes ###

#### Possible fixes ####

* igt@xe_waitfence@engine:
- bat-dg2-oem2: [FAIL][1] ([Intel XE#6519]) -> [PASS][2]
[1]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4710-29044d219ec91738869fef9d445adce5e31df374/bat-dg2-oem2/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/bat-dg2-oem2/igt@[email protected]

[Intel XE#6519]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6519

Build changes
-------------

* Linux: xe-4710-29044d219ec91738869fef9d445adce5e31df374 -> xe-pw-163153v1

IGT_8799: 8799
xe-4710-29044d219ec91738869fef9d445adce5e31df374: 29044d219ec91738869fef9d445adce5e31df374
xe-pw-163153v1: 163153v1

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/index.html

#37 lore raw
In reply to David E. Box
Quoted 3 lines · David E. Box

This series adds ACPI-based PMT discovery support and wires it into the
Intel PMC telemetry stack for Nova Lake S.

I think this series is v7, missing patch prefix for versions.

Thanks,
Srinivas

Quoted 99 lines

Today, PMT discovery flow is primarily PCI-oriented. Some platforms expose
PMT discovery via ACPI _DSD, and PMC telemetry needs to consume that path
for both standalone and companion-device cases. This series addresses that
in three logical steps:

    1. Prepare intel_vsec for ACPI-backed discovery
    2. Refactor PMT class handling so discovery source is abstracted (PCI or ACPI)
    3. Add/enable PMC consumers using ACPI discovery, including NVL SSRAM support

Patches 1–6 were previously posted here:
https://lore.kernel.org/all/[email protected]/

Series layout

    01-06: intel_vsec cleanup/generalization for ACPI-capable discovery
           plumbing. Previous changelog up to V7 included. Major patches:
           Patch 6 - adds ACPI support in VSEC driver

    07-12: PMT class refactor and ACPI discovery-source support Major patches:
           Patch 12 - adds ACPI support in PMT driver

    13-22: PMC driver integration
           Major patches:
           Patch 14 - adds new ACPI platform driver Patch 20 - adds ACPI discovery support in ssram driver Patch 22 - adds NVL IDs for SSRAM discovery

David E. Box (20):
  platform/x86/intel/vsec: Refactor base_addr handling platform/x86/intel/vsec: Make driver_data info const platform/x86/intel/vsec: Decouple add/link helpers from PCI platform/x86/intel/vsec: Switch exported helpers from pci_dev to device
  platform/x86/intel/vsec: Return real error codes from registration path
  platform/x86/intel/vsec: Plumb ACPI PMT discovery tables through vsec
  platform/x86/intel/pmt: Add pre/post decode hooks around header parsing
  platform/x86/intel/pmt/crashlog: Split init into pre-decode platform/x86/intel/pmt/telemetry: Move overlap check to post-decode hook
  platform/x86/intel/pmt: Move header decode into common helper platform/x86/intel/pmt: Pass discovery index instead of resource platform/x86/intel/pmt: Unify header fetch and add ACPI source platform/x86/intel/pmc: Add PMC SSRAM Kconfig description platform/x86/intel/pmc: Add ACPI PWRM telemetry driver for Nova Lake S
  platform/x86/intel/pmc/ssram: Rename probe and PCI ID table for consistency
  platform/x86/intel/pmc/ssram: Refactor DEVID/PWRMBASE extraction into
    helper
  platform/x86/intel/pmc/ssram: Add PCI platform data platform/x86/intel/pmc/ssram: Add ACPI discovery scaffolding platform/x86/intel/pmc/ssram: Make PMT registration optional platform/x86/intel/pmc: Add NVL PCI IDs for SSRAM telemetry discovery

Xi Pardee (2):
  platform/x86/intel/pmc/ssram: Use fixed-size static pmc array platform/x86/intel/pmc/ssram: Refactor memory barrier for reentrant probe

 drivers/gpu/drm/xe/xe_debugfs.c               |   2 +- drivers/gpu/drm/xe/xe_hwmon.c                 |   2 +- drivers/gpu/drm/xe/xe_vsec.c                  |   7 +- drivers/gpu/drm/xe/xe_vsec.h                  |   4 +- drivers/platform/x86/intel/pmc/Kconfig        |  25 ++ drivers/platform/x86/intel/pmc/Makefile       |   2 + drivers/platform/x86/intel/pmc/core.c         |   4 +- drivers/platform/x86/intel/pmc/core.h         |  17 ++ .../platform/x86/intel/pmc/pwrm_telemetry.c   | 227 ++++++++++++++++ .../platform/x86/intel/pmc/ssram_telemetry.c  | 254 ++++++++++++++-- --
 drivers/platform/x86/intel/pmt/class.c        | 170 ++++++++++-- drivers/platform/x86/intel/pmt/class.h        |  25 +- drivers/platform/x86/intel/pmt/crashlog.c     |  16 +-

 drivers/platform/x86/intel/pmt/discovery.c    |   4 +-
 drivers/platform/x86/intel/pmt/telemetry.c    |  45 +---
 drivers/platform/x86/intel/pmt/telemetry.h    |  12 +-

 drivers/platform/x86/intel/sdsi.c             |   5 +- drivers/platform/x86/intel/vsec.c             | 121 +++++---- drivers/platform/x86/intel/vsec_tpmi.c        |   8 +- include/linux/intel_vsec.h                    |  39 ++-

 20 files changed, 784 insertions(+), 205 deletions(-)

 create mode 100644 drivers/platform/x86/intel/pmc/pwrm_telemetry.c

base-commit: 11439c4635edd669ae435eec308f4ab8a0804808

#38 lore raw

✓ Xe.CI.FULL: success for platform/x86/intel: Add ACPI PMT discovery support and enable NVL PMC telemetry

In reply to David E. Box
== Series Details ==

== Series Details ==

Series: platform/x86/intel: Add ACPI PMT discovery support and enable NVL PMC telemetry
URL : https://patchwork.freedesktop.org/series/163153/
State : success

== Summary ==

CI Bug Log - changes from xe-4710-29044d219ec91738869fef9d445adce5e31df374_FULL -> xe-pw-163153v1_FULL
====================================================

Summary
-------

**SUCCESS**

No regressions found.

Participating hosts (2 -> 2)
------------------------------

No changes in participating hosts

Known issues
------------

Here are the changes found in xe-pw-163153v1_FULL that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@kms_big_fb@linear-64bpp-rotate-90:
- shard-bmg: NOTRUN -> [SKIP][1] ([Intel XE#2327]) +1 other test skip
[1]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-9/igt@[email protected]

* igt@kms_big_fb@linear-max-hw-stride-64bpp-rotate-0-hflip:
- shard-bmg: NOTRUN -> [SKIP][2] ([Intel XE#7059] / [Intel XE#7085])
[2]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-9/igt@[email protected]

* igt@kms_big_fb@yf-tiled-8bpp-rotate-90:
- shard-bmg: NOTRUN -> [SKIP][3] ([Intel XE#1124]) +3 other tests skip
[3]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-9/igt@[email protected]

* igt@kms_big_fb@yf-tiled-addfb:
- shard-bmg: NOTRUN -> [SKIP][4] ([Intel XE#2328] / [Intel XE#7367])
[4]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-5/igt@[email protected]

* igt@kms_bw@linear-tiling-2-displays-2560x1440p:
- shard-bmg: NOTRUN -> [SKIP][5] ([Intel XE#367] / [Intel XE#7354]) +2 other tests skip
[5]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-9/igt@[email protected]

* igt@kms_ccs@crc-primary-basic-y-tiled-ccs:
- shard-bmg: NOTRUN -> [SKIP][6] ([Intel XE#2887]) +6 other tests skip
[6]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-5/igt@[email protected]

* igt@kms_chamelium_hpd@hdmi-hpd-enable-disable-mode:
- shard-bmg: NOTRUN -> [SKIP][7] ([Intel XE#2252]) +3 other tests skip
[7]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-9/igt@[email protected]

* igt@kms_content_protection@suspend-resume@pipe-a-dp-2:
- shard-bmg: NOTRUN -> [FAIL][8] ([Intel XE#1178] / [Intel XE#3304] / [Intel XE#7374]) +1 other test fail
[8]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-9/igt@kms_content_protection@[email protected]

* igt@kms_content_protection@uevent-hdcp14@pipe-a-dp-2:
- shard-bmg: NOTRUN -> [FAIL][9] ([Intel XE#6707] / [Intel XE#7439]) +1 other test fail
[9]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-2/igt@kms_content_protection@[email protected]

* igt@kms_cursor_crc@cursor-sliding-512x170:
- shard-bmg: NOTRUN -> [SKIP][10] ([Intel XE#2321] / [Intel XE#7355])
[10]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-9/igt@[email protected]

* igt@kms_cursor_crc@cursor-sliding-64x21:
- shard-bmg: NOTRUN -> [SKIP][11] ([Intel XE#2320]) +1 other test skip
[11]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-5/igt@[email protected]

* igt@kms_cursor_legacy@2x-flip-vs-cursor-atomic:
- shard-bmg: [PASS][12] -> [SKIP][13] ([Intel XE#2291]) +1 other test skip
[12]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4710-29044d219ec91738869fef9d445adce5e31df374/shard-bmg-2/igt@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-5/igt@[email protected]

* igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic:
- shard-bmg: NOTRUN -> [SKIP][14] ([Intel XE#2291])
[14]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-5/igt@[email protected]

* igt@kms_cursor_legacy@cursorb-vs-flipb-atomic-transitions:
- shard-bmg: [PASS][15] -> [SKIP][16] ([Intel XE#2291] / [Intel XE#7343])
[15]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4710-29044d219ec91738869fef9d445adce5e31df374/shard-bmg-2/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-5/igt@[email protected]

* igt@kms_cursor_legacy@flip-vs-cursor-legacy:
- shard-bmg: [PASS][17] -> [FAIL][18] ([Intel XE#7571])
[17]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4710-29044d219ec91738869fef9d445adce5e31df374/shard-bmg-4/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-7/igt@[email protected]

* igt@kms_dither@fb-8bpc-vs-panel-6bpc:
- shard-bmg: NOTRUN -> [SKIP][19] ([Intel XE#1340])
[19]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-5/igt@[email protected]

* igt@kms_dither@fb-8bpc-vs-panel-6bpc@pipe-a-hdmi-a-3:
- shard-bmg: NOTRUN -> [SKIP][20] ([Intel XE#1340] / [Intel XE#7435])
[20]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-5/igt@kms_dither@[email protected]

* igt@kms_dsc@dsc-with-formats:
- shard-bmg: NOTRUN -> [SKIP][21] ([Intel XE#2244])
[21]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-9/igt@[email protected]

* igt@kms_fbc_dirty_rect@fbc-dirty-rectangle-dirtyfb-tests:
- shard-bmg: NOTRUN -> [SKIP][22] ([Intel XE#4422] / [Intel XE#7442])
[22]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-9/igt@[email protected]

* igt@kms_flip@2x-flip-vs-absolute-wf_vblank-interruptible:
- shard-bmg: [PASS][23] -> [SKIP][24] ([Intel XE#2316]) +7 other tests skip
[23]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4710-29044d219ec91738869fef9d445adce5e31df374/shard-bmg-7/igt@kms_flip@2x-flip-vs-absolute-wf_vblank-interruptible.html
[24]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-5/igt@kms_flip@2x-flip-vs-absolute-wf_vblank-interruptible.html

* igt@kms_flip@2x-flip-vs-panning:
- shard-bmg: NOTRUN -> [SKIP][25] ([Intel XE#2316])
[25]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-5/igt@[email protected]

* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile-upscaling:
- shard-bmg: NOTRUN -> [SKIP][26] ([Intel XE#7178] / [Intel XE#7351]) +2 other tests skip
[26]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-9/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile-upscaling.html

* igt@kms_frontbuffer_tracking@drrs-abgr161616f-draw-mmap-wc:
- shard-bmg: NOTRUN -> [SKIP][27] ([Intel XE#7061] / [Intel XE#7356])
[27]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-9/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-pgflip-blt:
- shard-bmg: NOTRUN -> [SKIP][28] ([Intel XE#4141]) +5 other tests skip
[28]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-9/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-indfb-msflip-blt:
- shard-bmg: NOTRUN -> [SKIP][29] ([Intel XE#2312]) +3 other tests skip
[29]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-5/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcdrrs-1p-offscreen-pri-shrfb-draw-blt:
- shard-bmg: NOTRUN -> [SKIP][30] ([Intel XE#2311]) +13 other tests skip
[30]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-9/igt@kms_frontbuffer_tracking@fbcdrrs-1p-offscreen-pri-shrfb-draw-blt.html

* igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-render:
- shard-bmg: NOTRUN -> [SKIP][31] ([Intel XE#2313]) +8 other tests skip
[31]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-9/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-render.html

* igt@kms_hdr@brightness-with-hdr:
- shard-bmg: NOTRUN -> [SKIP][32] ([Intel XE#3374] / [Intel XE#3544])
[32]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-5/igt@[email protected]

* igt@kms_joiner@basic-force-big-joiner:
- shard-bmg: [PASS][33] -> [SKIP][34] ([Intel XE#7086])
[33]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4710-29044d219ec91738869fef9d445adce5e31df374/shard-bmg-3/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-5/igt@[email protected]

* igt@kms_plane@pixel-format-yf-tiled-modifier-source-clamping:
- shard-bmg: NOTRUN -> [SKIP][35] ([Intel XE#7283])
[35]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-5/igt@[email protected]

* igt@kms_pm_dc@deep-pkgc:
- shard-bmg: NOTRUN -> [SKIP][36] ([Intel XE#2505] / [Intel XE#7447])
[36]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-5/igt@[email protected]

* igt@kms_psr2_sf@pr-cursor-plane-move-continuous-exceed-sf:
- shard-bmg: NOTRUN -> [SKIP][37] ([Intel XE#1489]) +4 other tests skip
[37]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-5/igt@[email protected]

* igt@kms_psr@fbc-psr2-cursor-plane-move:
- shard-bmg: NOTRUN -> [SKIP][38] ([Intel XE#2234] / [Intel XE#2850]) +6 other tests skip
[38]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-5/igt@[email protected]

* igt@kms_psr@psr2-primary-render:
- shard-bmg: NOTRUN -> [SKIP][39] ([Intel XE#2234])
[39]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-9/igt@[email protected]

* igt@kms_setmode@basic@pipe-b-edp-1:
- shard-lnl: [PASS][40] -> [FAIL][41] ([Intel XE#6361]) +2 other tests fail
[40]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4710-29044d219ec91738869fef9d445adce5e31df374/shard-lnl-3/igt@kms_setmode@[email protected]
[41]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-lnl-4/igt@kms_setmode@[email protected]

* igt@kms_setmode@invalid-clone-single-crtc-stealing:
- shard-bmg: [PASS][42] -> [SKIP][43] ([Intel XE#1435])
[42]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4710-29044d219ec91738869fef9d445adce5e31df374/shard-bmg-3/igt@[email protected]
[43]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-5/igt@[email protected]

* igt@kms_tiled_display@basic-test-pattern:
- shard-bmg: NOTRUN -> [SKIP][44] ([Intel XE#2426] / [Intel XE#5848])
[44]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-5/igt@[email protected]

* igt@kms_vrr@seamless-rr-switch-virtual@pipe-a-edp-1:
- shard-lnl: [PASS][45] -> [FAIL][46] ([Intel XE#2142]) +1 other test fail
[45]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4710-29044d219ec91738869fef9d445adce5e31df374/shard-lnl-2/igt@kms_vrr@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-lnl-5/igt@kms_vrr@[email protected]

* igt@xe_eudebug@basic-vm-bind-metadata-discovery:
- shard-bmg: NOTRUN -> [SKIP][47] ([Intel XE#4837]) +2 other tests skip
[47]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-10/igt@[email protected]

* igt@xe_eudebug_online@pagefault-one-of-many:
- shard-bmg: NOTRUN -> [SKIP][48] ([Intel XE#6665])
[48]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-5/igt@[email protected]

* igt@xe_eudebug_online@preempt-breakpoint:
- shard-bmg: NOTRUN -> [SKIP][49] ([Intel XE#4837] / [Intel XE#6665])
[49]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-9/igt@[email protected]

* igt@xe_exec_basic@multigpu-many-execqueues-many-vm-bindexecqueue:
- shard-bmg: NOTRUN -> [SKIP][50] ([Intel XE#2322] / [Intel XE#7372]) +5 other tests skip
[50]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-9/igt@xe_exec_basic@multigpu-many-execqueues-many-vm-bindexecqueue.html

* igt@xe_exec_fault_mode@twice-multi-queue-imm:
- shard-bmg: NOTRUN -> [SKIP][51] ([Intel XE#7136]) +3 other tests skip
[51]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-5/igt@[email protected]

* igt@xe_exec_multi_queue@two-queues-preempt-mode-fault-priority:
- shard-bmg: NOTRUN -> [SKIP][52] ([Intel XE#6874]) +12 other tests skip
[52]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-9/igt@[email protected]

* igt@xe_exec_threads@threads-multi-queue-mixed-fd-userptr-invalidate:
- shard-bmg: NOTRUN -> [SKIP][53] ([Intel XE#7138]) +3 other tests skip
[53]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-5/igt@xe_exec_threads@threads-multi-queue-mixed-fd-userptr-invalidate.html

* igt@xe_media_fill@media-fill:
- shard-bmg: NOTRUN -> [SKIP][54] ([Intel XE#2459] / [Intel XE#2596] / [Intel XE#7321] / [Intel XE#7453])
[54]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-9/igt@[email protected]

* igt@xe_module_load@load:
- shard-bmg: ([PASS][55], [PASS][56], [PASS][57], [PASS][58], [PASS][59], [PASS][60], [PASS][61], [PASS][62], [PASS][63], [PASS][64], [PASS][65], [PASS][66], [PASS][67], [PASS][68], [PASS][69], [PASS][70], [PASS][71], [PASS][72], [PASS][73], [PASS][74], [PASS][75], [PASS][76], [PASS][77], [PASS][78], [PASS][79]) -> ([PASS][80], [PASS][81], [PASS][82], [PASS][83], [PASS][84], [PASS][85], [PASS][86], [PASS][87], [PASS][88], [PASS][89], [PASS][90], [SKIP][91], [PASS][92], [PASS][93], [PASS][94], [PASS][95], [PASS][96], [PASS][97], [PASS][98], [PASS][99], [PASS][100], [PASS][101], [PASS][102], [PASS][103], [PASS][104], [PASS][105]) ([Intel XE#2457] / [Intel XE#7405])
[55]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4710-29044d219ec91738869fef9d445adce5e31df374/shard-bmg-10/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4710-29044d219ec91738869fef9d445adce5e31df374/shard-bmg-10/igt@[email protected]
[57]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4710-29044d219ec91738869fef9d445adce5e31df374/shard-bmg-3/igt@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4710-29044d219ec91738869fef9d445adce5e31df374/shard-bmg-9/igt@[email protected]
[59]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4710-29044d219ec91738869fef9d445adce5e31df374/shard-bmg-3/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4710-29044d219ec91738869fef9d445adce5e31df374/shard-bmg-5/igt@[email protected]
[61]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4710-29044d219ec91738869fef9d445adce5e31df374/shard-bmg-3/igt@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4710-29044d219ec91738869fef9d445adce5e31df374/shard-bmg-6/igt@[email protected]
[63]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4710-29044d219ec91738869fef9d445adce5e31df374/shard-bmg-6/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4710-29044d219ec91738869fef9d445adce5e31df374/shard-bmg-5/igt@[email protected]
[65]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4710-29044d219ec91738869fef9d445adce5e31df374/shard-bmg-9/igt@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4710-29044d219ec91738869fef9d445adce5e31df374/shard-bmg-2/igt@[email protected]
[67]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4710-29044d219ec91738869fef9d445adce5e31df374/shard-bmg-9/igt@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4710-29044d219ec91738869fef9d445adce5e31df374/shard-bmg-4/igt@[email protected]
[69]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4710-29044d219ec91738869fef9d445adce5e31df374/shard-bmg-4/igt@[email protected]
[70]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4710-29044d219ec91738869fef9d445adce5e31df374/shard-bmg-2/igt@[email protected]
[71]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4710-29044d219ec91738869fef9d445adce5e31df374/shard-bmg-5/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4710-29044d219ec91738869fef9d445adce5e31df374/shard-bmg-7/igt@[email protected]
[73]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4710-29044d219ec91738869fef9d445adce5e31df374/shard-bmg-7/igt@[email protected]
[74]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4710-29044d219ec91738869fef9d445adce5e31df374/shard-bmg-10/igt@[email protected]
[75]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4710-29044d219ec91738869fef9d445adce5e31df374/shard-bmg-7/igt@[email protected]
[76]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4710-29044d219ec91738869fef9d445adce5e31df374/shard-bmg-8/igt@[email protected]
[77]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4710-29044d219ec91738869fef9d445adce5e31df374/shard-bmg-2/igt@[email protected]
[78]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4710-29044d219ec91738869fef9d445adce5e31df374/shard-bmg-8/igt@[email protected]
[79]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4710-29044d219ec91738869fef9d445adce5e31df374/shard-bmg-8/igt@[email protected]
[80]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-7/igt@[email protected]
[81]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-3/igt@[email protected]
[82]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-5/igt@[email protected]
[83]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-2/igt@[email protected]
[84]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-7/igt@[email protected]
[85]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-5/igt@[email protected]
[86]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-5/igt@[email protected]
[87]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-10/igt@[email protected]
[88]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-5/igt@[email protected]
[89]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-4/igt@[email protected]
[90]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-8/igt@[email protected]
[91]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-5/igt@[email protected]
[92]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-7/igt@[email protected]
[93]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-8/igt@[email protected]
[94]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-2/igt@[email protected]
[95]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-8/igt@[email protected]
[96]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-9/igt@[email protected]
[97]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-4/igt@[email protected]
[98]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-4/igt@[email protected]
[99]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-10/igt@[email protected]
[100]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-10/igt@[email protected]
[101]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-3/igt@[email protected]
[102]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-9/igt@[email protected]
[103]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-2/igt@[email protected]
[104]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-6/igt@[email protected]
[105]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-6/igt@[email protected]

* igt@xe_multigpu_svm@mgpu-pagefault-basic:
- shard-bmg: NOTRUN -> [SKIP][106] ([Intel XE#6964]) +2 other tests skip
[106]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-5/igt@[email protected]

* igt@xe_pat@pat-index-xelp:
- shard-bmg: NOTRUN -> [SKIP][107] ([Intel XE#2245])
[107]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-5/igt@[email protected]

* igt@xe_pm@vram-d3cold-threshold:
- shard-bmg: NOTRUN -> [SKIP][108] ([Intel XE#579] / [Intel XE#7329] / [Intel XE#7517])
[108]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-9/igt@[email protected]

* igt@xe_query@multigpu-query-config:
- shard-bmg: NOTRUN -> [SKIP][109] ([Intel XE#944])
[109]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-9/igt@[email protected]

#### Possible fixes ####

* igt@kms_bw@connected-linear-tiling-2-displays-1920x1080p:
- shard-bmg: [SKIP][110] ([Intel XE#2314] / [Intel XE#2894] / [Intel XE#7373]) -> [PASS][111] +1 other test pass
[110]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4710-29044d219ec91738869fef9d445adce5e31df374/shard-bmg-5/igt@[email protected]
[111]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-3/igt@[email protected]

* igt@kms_cursor_legacy@flip-vs-cursor-atomic:
- shard-bmg: [FAIL][112] ([Intel XE#7571]) -> [PASS][113]
[112]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4710-29044d219ec91738869fef9d445adce5e31df374/shard-bmg-4/igt@[email protected]
[113]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-6/igt@[email protected]

* igt@kms_display_modes@extended-mode-basic:
- shard-bmg: [SKIP][114] ([Intel XE#4302]) -> [PASS][115]
[114]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4710-29044d219ec91738869fef9d445adce5e31df374/shard-bmg-5/igt@[email protected]
[115]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-2/igt@[email protected]

* igt@kms_flip@2x-flip-vs-dpms-off-vs-modeset:
- shard-bmg: [SKIP][116] ([Intel XE#2316]) -> [PASS][117] +2 other tests pass
[116]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4710-29044d219ec91738869fef9d445adce5e31df374/shard-bmg-5/igt@[email protected]
[117]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-2/igt@[email protected]

* igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1:
- shard-lnl: [FAIL][118] ([Intel XE#301]) -> [PASS][119] +4 other tests pass
[118]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4710-29044d219ec91738869fef9d445adce5e31df374/shard-lnl-3/igt@kms_flip@[email protected]
[119]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-lnl-2/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-suspend@a-hdmi-a3:
- shard-bmg: [INCOMPLETE][120] ([Intel XE#2049] / [Intel XE#2597]) -> [PASS][121] +1 other test pass
[120]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4710-29044d219ec91738869fef9d445adce5e31df374/shard-bmg-6/igt@kms_flip@[email protected]
[121]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-9/igt@kms_flip@[email protected]

* igt@kms_hdr@invalid-metadata-sizes:
- shard-bmg: [SKIP][122] ([Intel XE#1503]) -> [PASS][123]
[122]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4710-29044d219ec91738869fef9d445adce5e31df374/shard-bmg-5/igt@[email protected]
[123]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-7/igt@[email protected]

* igt@kms_plane@pixel-format-linear-modifier-source-clamping:
- shard-bmg: [INCOMPLETE][124] ([Intel XE#1035]) -> [PASS][125] +1 other test pass
[124]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4710-29044d219ec91738869fef9d445adce5e31df374/shard-bmg-3/igt@[email protected]
[125]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-9/igt@[email protected]

* igt@kms_rotation_crc@multiplane-rotation:
- shard-bmg: [DMESG-WARN][126] ([Intel XE#7129]) -> [PASS][127]
[126]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4710-29044d219ec91738869fef9d445adce5e31df374/shard-bmg-2/igt@[email protected]
[127]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-5/igt@[email protected]

* igt@xe_ccs@large-ctrl-surf-copy:
- shard-bmg: [FAIL][128] -> [PASS][129]
[128]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4710-29044d219ec91738869fef9d445adce5e31df374/shard-bmg-2/igt@[email protected]
[129]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-5/igt@[email protected]

* igt@xe_exec_system_allocator@pat-index-madvise-pat-idx-uc-single-vma:
- shard-lnl: [FAIL][130] ([Intel XE#5625]) -> [PASS][131]
[130]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4710-29044d219ec91738869fef9d445adce5e31df374/shard-lnl-1/igt@xe_exec_system_allocator@pat-index-madvise-pat-idx-uc-single-vma.html
[131]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-lnl-1/igt@xe_exec_system_allocator@pat-index-madvise-pat-idx-uc-single-vma.html

* igt@xe_exec_system_allocator@twice-mmap-new-huge:
- shard-bmg: [ABORT][132] -> [PASS][133]
[132]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4710-29044d219ec91738869fef9d445adce5e31df374/shard-bmg-8/igt@[email protected]
[133]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-10/igt@[email protected]

#### Warnings ####

* igt@kms_content_protection@lic-type-0-hdcp14:
- shard-bmg: [FAIL][134] ([Intel XE#1178] / [Intel XE#3304] / [Intel XE#7374]) -> [SKIP][135] ([Intel XE#7194])
[134]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4710-29044d219ec91738869fef9d445adce5e31df374/shard-bmg-2/igt@[email protected]
[135]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-5/igt@[email protected]

* igt@kms_content_protection@uevent:
- shard-bmg: [SKIP][136] ([Intel XE#2341]) -> [FAIL][137] ([Intel XE#6707] / [Intel XE#7439])
[136]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4710-29044d219ec91738869fef9d445adce5e31df374/shard-bmg-5/igt@[email protected]
[137]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-3/igt@[email protected]

* igt@kms_content_protection@uevent-hdcp14:
- shard-bmg: [SKIP][138] ([Intel XE#7194]) -> [FAIL][139] ([Intel XE#6707] / [Intel XE#7439])
[138]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4710-29044d219ec91738869fef9d445adce5e31df374/shard-bmg-5/igt@[email protected]
[139]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-2/igt@[email protected]

* igt@kms_frontbuffer_tracking@drrs-2p-scndscrn-pri-indfb-draw-mmap-wc:
- shard-bmg: [SKIP][140] ([Intel XE#2311]) -> [SKIP][141] ([Intel XE#2312]) +13 other tests skip
[140]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4710-29044d219ec91738869fef9d445adce5e31df374/shard-bmg-7/igt@kms_frontbuffer_tracking@drrs-2p-scndscrn-pri-indfb-draw-mmap-wc.html
[141]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-5/igt@kms_frontbuffer_tracking@drrs-2p-scndscrn-pri-indfb-draw-mmap-wc.html

* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-move:
- shard-bmg: [SKIP][142] ([Intel XE#2312]) -> [SKIP][143] ([Intel XE#4141]) +5 other tests skip
[142]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4710-29044d219ec91738869fef9d445adce5e31df374/shard-bmg-5/igt@[email protected]
[143]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-2/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-mmap-wc:
- shard-bmg: [SKIP][144] ([Intel XE#4141]) -> [SKIP][145] ([Intel XE#2312]) +6 other tests skip
[144]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4710-29044d219ec91738869fef9d445adce5e31df374/shard-bmg-7/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-mmap-wc.html
[145]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-5/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-mmap-wc.html

* igt@kms_frontbuffer_tracking@fbcdrrs-2p-scndscrn-pri-shrfb-draw-render:
- shard-bmg: [SKIP][146] ([Intel XE#2312]) -> [SKIP][147] ([Intel XE#2311]) +10 other tests skip
[146]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4710-29044d219ec91738869fef9d445adce5e31df374/shard-bmg-5/igt@kms_frontbuffer_tracking@fbcdrrs-2p-scndscrn-pri-shrfb-draw-render.html
[147]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-7/igt@kms_frontbuffer_tracking@fbcdrrs-2p-scndscrn-pri-shrfb-draw-render.html

* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-indfb-msflip-blt:
- shard-bmg: [SKIP][148] ([Intel XE#2313]) -> [SKIP][149] ([Intel XE#2312]) +14 other tests skip
[148]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4710-29044d219ec91738869fef9d445adce5e31df374/shard-bmg-2/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-indfb-msflip-blt.html
[149]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-5/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-indfb-msflip-blt.html

* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-shrfb-pgflip-blt:
- shard-bmg: [SKIP][150] ([Intel XE#2312]) -> [SKIP][151] ([Intel XE#2313]) +11 other tests skip
[150]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4710-29044d219ec91738869fef9d445adce5e31df374/shard-bmg-5/igt@[email protected]
[151]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/shard-bmg-2/igt@[email protected]

[Intel XE#1035]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1035
[Intel XE#1124]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1124
[Intel XE#1178]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1178
[Intel XE#1340]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1340
[Intel XE#1435]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1435
[Intel XE#1489]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1489
[Intel XE#1503]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1503
[Intel XE#2049]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2049
[Intel XE#2142]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2142
[Intel XE#2234]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2234
[Intel XE#2244]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2244
[Intel XE#2245]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2245
[Intel XE#2252]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2252
[Intel XE#2291]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2291
[Intel XE#2311]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2311
[Intel XE#2312]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2312
[Intel XE#2313]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2313
[Intel XE#2314]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2314
[Intel XE#2316]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2316
[Intel XE#2320]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2320
[Intel XE#2321]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2321
[Intel XE#2322]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2322
[Intel XE#2327]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2327
[Intel XE#2328]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2328
[Intel XE#2341]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2341
[Intel XE#2426]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2426
[Intel XE#2457]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2457
[Intel XE#2459]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2459
[Intel XE#2505]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2505
[Intel XE#2596]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2596
[Intel XE#2597]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2597
[Intel XE#2850]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2850
[Intel XE#2887]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2887
[Intel XE#2894]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2894
[Intel XE#301]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/301
[Intel XE#3304]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3304
[Intel XE#3374]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3374
[Intel XE#3544]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3544
[Intel XE#367]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/367
[Intel XE#4141]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4141
[Intel XE#4302]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4302
[Intel XE#4422]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4422
[Intel XE#4837]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4837
[Intel XE#5625]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5625
[Intel XE#579]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/579
[Intel XE#5848]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5848
[Intel XE#6361]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6361
[Intel XE#6665]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6665
[Intel XE#6707]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6707
[Intel XE#6874]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6874
[Intel XE#6964]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6964
[Intel XE#7059]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7059
[Intel XE#7061]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7061
[Intel XE#7085]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7085
[Intel XE#7086]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7086
[Intel XE#7129]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7129
[Intel XE#7136]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7136
[Intel XE#7138]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7138
[Intel XE#7178]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7178
[Intel XE#7194]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7194
[Intel XE#7283]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7283
[Intel XE#7321]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7321
[Intel XE#7329]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7329
[Intel XE#7343]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7343
[Intel XE#7351]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7351
[Intel XE#7354]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7354
[Intel XE#7355]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7355
[Intel XE#7356]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7356
[Intel XE#7367]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7367
[Intel XE#7372]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7372
[Intel XE#7373]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7373
[Intel XE#7374]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7374
[Intel XE#7405]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7405
[Intel XE#7435]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7435
[Intel XE#7439]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7439
[Intel XE#7442]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7442
[Intel XE#7447]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7447
[Intel XE#7453]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7453
[Intel XE#7517]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7517
[Intel XE#7571]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7571
[Intel XE#944]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/944

Build changes
-------------

* Linux: xe-4710-29044d219ec91738869fef9d445adce5e31df374 -> xe-pw-163153v1

IGT_8799: 8799
xe-4710-29044d219ec91738869fef9d445adce5e31df374: 29044d219ec91738869fef9d445adce5e31df374
xe-pw-163153v1: 163153v1

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-163153v1/index.html