staging: rtl8723bs: remove unused rtl8192c_query_rx_desc_status declaration
PATCH 1/2 staging: rtl8723bs: remove unused rtl8192c_query_rx_desc_status declaration
The function rtl8192c_query_rx_desc_status is declared in rtl8192c_recv.h but never defined or called anywhere in the driver.
--- drivers/staging/rtl8723bs/include/rtl8192c_recv.h | 2 -- 1 file changed, 2 deletions(-)
drivers/staging/rtl8723bs/include/rtl8192c_recv.h +0 -2
@@ -34,8 +34,6 @@ struct phy_stat {/* Rx smooth factor */ #define Rx_Smooth_Factor (20) - -void rtl8192c_translate_rx_signal_stuff (union recv_frame *precvframe,struct phy_stat *pphy_status);void rtl8192c_query_rx_desc_status (union recv_frame *precvframe,struct recv_stat *pdesc);#endif
Signature · 1 line
2.43.0
PATCH 2/2 staging: rtl8723bs: remove unused rtl8192c_translate_rx_signal_stuff declaration
The function rtl8192c_translate_rx_signal_stuff is declared in rtl8192c_recv.h but never defined or called anywhere in the driver
--- drivers/staging/rtl8723bs/include/rtl8192c_recv.h | 1 - 1 file changed, 1 deletion(-)
drivers/staging/rtl8723bs/include/rtl8192c_recv.h +0 -1
@@ -34,6 +34,5 @@ struct phy_stat {/* Rx smooth factor */ #define Rx_Smooth_Factor (20) -void rtl8192c_query_rx_desc_status (union recv_frame *precvframe,struct recv_stat *pdesc);#endif
Signature · 1 line
2.43.0
Re: [PATCH 2/2] staging: rtl8723bs: remove unused rtl8192c_translate_rx_signal_stuff declaration
Quoted 13 lines · Azamat Rakhim
The function
rtl8192c_translate_rx_signal_stuffis declared inrtl8192c_recv.hbut never defined or called anywhere in the driverSigned-off-by Azamat Rakhim <[email protected]>--- drivers/staging/rtl8723bs/include/rtl8192c_recv.h | 1 - 1 file changed, 1 deletion(-)drivers/staging/rtl8723bs/include/rtl8192c_recv.h +0
-0
drivers/staging/rtl8723bs/include/rtl8192c_recv.h struct phy_stat { · line 37
Quoted 5 lines
drivers/staging/rtl8723bs/include/rtl8192c_recv.h +0
-1@@ -34,6 +34,5 @@ struct phy_stat {/* Rx smooth factor */ #define Rx_Smooth_Factor (20) -void rtl8192c_query_rx_desc_status (union recv_frame *precvframe,struct recv_stat *pdesc);
Need to delete the blank line as well.
regards,
dan carpenter
Quoted 5 lines · Azamat Rakhim
The function
rtl8192c_query_rx_desc_statusis declared inrtl8192c_recv.hbut never defined or called anywhere in the driver.Signed-off-by Azamat Rakhim <[email protected]>---
Looking at rtl8192c_recv.h, it looks like you can rather easily just delete the entire header file. Just put the things that are used elsewhere in the driver into rtl8723b_recv.h.
Thanks,
ET