staging: rtl8723bs: add missing blank lines after declarations
PATCH 1/1 staging: rtl8723bs: add missing blank lines after declarations
Add missing blank lines after variable declarations in several files throughout the rtl8723bs driver to comply with kernel coding style.
Signed-off-by Oskar Ray-Frayssinet <[email protected]>
--- drivers/staging/rtl8723bs/hal/hal_btcoex.c | 1 + drivers/staging/rtl8723bs/hal/hal_com.c | 2 ++ drivers/staging/rtl8723bs/hal/hal_com_phycfg.c | 5 +++++ drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c | 2 ++ drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 5 +++++ drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c | 1 + drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c | 1 + drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 2 ++ drivers/staging/rtl8723bs/hal/sdio_halinit.c | 3 +++ 9 files changed, 22 insertions(+)
drivers/staging/rtl8723bs/hal/hal_btcoex.c +1 -0
@@ -364,6 +364,7 @@ static u8 halbtcoutsrc_Get(void *pBtcContext, u8 getType, void *pOutBuf)case BTC_GET_U4_WIFI_TRAFFIC_DIRECTION : {struct rt_link_detect_t *plinkinfo; + plinkinfo = &padapter->mlmepriv.link_detect_info;if (plinkinfo->num_tx_ok_in_period > plinkinfo->num_rx_ok_in_period)
drivers/staging/rtl8723bs/hal/hal_com.c +2 -0
@@ -616,6 +616,7 @@ void SetHwReg(struct adapter *adapter, u8 variable, u8 *val)case HW_VAR_DM_FUNC_SET :if (*((u32 *)val) ==DYNAMIC_ALL_FUNC_ENABLE ) {struct dm_priv *dm = &hal_data->dmpriv; + dm->DMFlag = dm->InitDMFlag; odm->SupportAbility = dm->InitODMFlag; }else {
@@ -727,6 +728,7 @@ void SetHalODMVar(case HAL_ODM_STA_INFO : {struct sta_info *psta = pValue1; +if (bSet) {ODM_CmnInfoPtrArrayHook (podmpriv,ODM_CMNINFO_STA_STATUS , psta->mac_id, psta); }else {
drivers/staging/rtl8723bs/hal/hal_com_phycfg.c +5 -0
@@ -423,6 +423,7 @@ void PHY_SetTxPowerIndexByRateSection(if (RateSection ==CCK ) {u8 cckRates[] = {MGN_1M ,MGN_2M ,MGN_5_5M ,MGN_11M }; + PHY_SetTxPowerIndexByRateArray(padapter, RFPath, pHalData->CurrentChannelBW, Channel, cckRates,
@@ -430,6 +431,7 @@ void PHY_SetTxPowerIndexByRateSection( }else if (RateSection ==OFDM ) {u8 ofdmRates[] = {MGN_6M ,MGN_9M ,MGN_12M ,MGN_18M ,MGN_24M ,MGN_36M ,MGN_48M ,MGN_54M }; + PHY_SetTxPowerIndexByRateArray(padapter, RFPath, pHalData->CurrentChannelBW, Channel, ofdmRates,
@@ -437,6 +439,7 @@ void PHY_SetTxPowerIndexByRateSection( }else if (RateSection ==HT_MCS0_MCS7 ) {u8 htRates1T[] = {MGN_MCS0 ,MGN_MCS1 ,MGN_MCS2 ,MGN_MCS3 ,MGN_MCS4 ,MGN_MCS5 ,MGN_MCS6 ,MGN_MCS7 }; + PHY_SetTxPowerIndexByRateArray(padapter, RFPath, pHalData->CurrentChannelBW, Channel, htRates1T,
@@ -500,6 +503,7 @@ s8 PHY_GetTxPowerTrackingOffset(struct adapter *padapter, u8 RFPath, u8 Rate)u8 PHY_GetRateIndexOfTxPowerByRate (u8 Rate) {u8 index =0 ; +switch (Rate) {case MGN_1M : index =0 ;
@@ -856,6 +860,7 @@ void PHY_SetTxPowerLimit(void Hal_ChannelPlanToRegulation (struct adapter *Adapter,u16 ChannelPlan) {struct hal_com_data *pHalData =GET_HAL_DATA (Adapter); + pHalData->Regulation2_4G =TXPWR_LMT_WW ;switch (ChannelPlan) {
drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c +2 -0
@@ -672,6 +672,7 @@ void rtl8723b_download_rsvd_page(struct adapter *padapter, u8 mstatus)if (padapter->bSurpriseRemoved || padapter->bDriverStopped) { }else {struct pwrctrl_priv *pwrctl =adapter_to_pwrctl (padapter); + pwrctl->fw_psmode_iface_id = padapter->iface_id; }
@@ -935,6 +936,7 @@ void rtl8723b_download_BTCoex_AP_mode_rsvd_page(struct adapter *padapter)if (bcn_valid) {struct pwrctrl_priv *pwrctl =adapter_to_pwrctl (padapter); + pwrctl->fw_psmode_iface_id = padapter->iface_id; }
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +5 -0
@@ -1631,6 +1631,7 @@ static void rtl8723b_cal_txdesc_chksum(struct tx_desc *ptxdesc)static u8 fill_txdesc_sectype (struct pkt_attrib *pattrib) {u8 sectype =0 ; +if ((pattrib->encrypt >0 ) && !pattrib->bswenc) {switch (pattrib->encrypt) {/* SEC_TYPE */
@@ -2031,6 +2032,7 @@ static void hw_var_set_bcn_func(struct adapter *padapter, u8 variable, u8 *val)rtw_write8 (padapter, bcn_ctrl_reg, (EN_BCN_FUNCTION |EN_TXBCN_RPT )); else {u8 val8; + val8 =rtw_read8 (padapter, bcn_ctrl_reg); val8 &= ~(EN_BCN_FUNCTION |EN_TXBCN_RPT );
@@ -2225,6 +2227,7 @@ s32 c2h_id_filter_ccx_8723b(u8 *buf) {struct c2h_evt_hdr_88xx *c2h_evt = (struct c2h_evt_hdr_88xx *)buf;s32 ret = false; +if (c2h_evt->id ==C2H_CCX_TX_RPT ) ret = true;
@@ -2314,6 +2317,7 @@ void C2HPacketHandler_8723B(struct adapter *padapter, u8 *pbuffer, u16 length) {struct c2h_evt_hdr_t C2hEvent;u8 *tmpBuf =NULL ; + C2hEvent.CmdID = pbuffer[0 ]; C2hEvent.CmdSeq = pbuffer[1 ]; C2hEvent.CmdLen = length-2 ;
@@ -2397,6 +2401,7 @@ void SetHwReg8723B(struct adapter *padapter, u8 variable, u8 *val)case HW_VAR_CHECK_BSSID : {u32 val32; + val32 =rtw_read32 (padapter,REG_RCR );if (*val) val32 |=RCR_CBSSID_DATA |RCR_CBSSID_BCN ;
drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c +1 -0
@@ -575,6 +575,7 @@ static void phy_SetRegBW_8723B( ) {u16 RegRfMod_BW, u2tmp =0 ; + RegRfMod_BW =rtw_read16 (Adapter,REG_TRXPTCL_CTL_8723B );switch (CurrentBW) {
drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c +1 -0
@@ -143,6 +143,7 @@ static void update_recvframe_phyinfo(union recv_frame *precvframe, } }else if (pkt_info.to_self || pkt_info.is_beacon) {u32 adhoc_state =WIFI_ADHOC_STATE |WIFI_ADHOC_MASTER_STATE ; +if (check_fwstate (&padapter->mlmepriv, adhoc_state))if (psta) precvframe->u.hdr.psta = psta;
drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c +2 -0
@@ -240,6 +240,7 @@ static s32 xmit_xmitframes(struct adapter *padapter, struct xmit_priv *pxmitprivif (pxmitbuf->len >0 && pxmitbuf->priv_data) {struct xmit_frame *pframe; + pframe = (struct xmit_frame *)pxmitbuf->priv_data; pframe->agg_num = k; pxmitbuf->agg_num = k;
@@ -324,6 +325,7 @@ static s32 xmit_xmitframes(struct adapter *padapter, struct xmit_priv *pxmitprivif (pxmitbuf) {if (pxmitbuf->len >0 ) {struct xmit_frame *pframe; + pframe = (struct xmit_frame *)pxmitbuf->priv_data; pframe->agg_num = k; pxmitbuf->agg_num = k;
drivers/staging/rtl8723bs/hal/sdio_halinit.c +3 -0
@@ -214,6 +214,7 @@ static void _InitNormalChipOneOutEpPriority(struct adapter *Adapter)struct hal_com_data *pHalData =GET_HAL_DATA (Adapter);u16 value =0 ; +switch (pHalData->OutEpQueueSel) {case TX_SELE_HQ : value =QUEUE_HIGH ;
@@ -341,6 +342,7 @@ static void _InitTransferPageSize(struct adapter *padapter)/* Tx page size is always 128. */ u8 value8; + value8 =_PSRX (PBP_128 ) |_PSTX (PBP_128 );rtw_write8 (padapter,REG_PBP , value8); }
@@ -1147,6 +1149,7 @@ void SetHwReg8723BS(struct adapter *padapter, u8 variable, u8 *val)case HW_VAR_SET_REQ_FW_PS : {u8 req_fw_ps =0 ; + req_fw_ps =rtw_read8 (padapter,0x8f ); req_fw_ps |=0x10 ;rtw_write8 (padapter,0x8f , req_fw_ps);
Signature · 1 line
2.43.0
Quoted 5 lines · Oskar Ray-Frayssinet
Add missing blank lines after variable declarations in several files throughout the rtl8723bs driver to comply with kernel coding style.
Signed-off-by Oskar Ray-Frayssinet <[email protected]>---
This should be a v2 [1]. However, the patch itself looks fine. So you can include by RB tag for your v3.
"Reviewed-by: Ethan Tidmore <[email protected]>"
Heres a resource on how to make a v2, (this next one will be a v3):
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/
Thanks,
ET