Skip to contentSkip to conversation

Warning: fs/kernfs/dir.c:491 function parameter 'drop_supers' not described in 'kernfs_drain'

PATCH kernel test robot 3 participants 3 messages Mar 13 kernfs

lore
Share & tools
lore

kernel test robot

author build bot
#0 lore raw
tree:   https://git.kernel.org/pub/scm/linux/kernel/git/driver-core/driver-core.git driver-core-testing
head:   e7ccc9e054beb4c366228d24786f67c738206605
commit: eea5d2bb34ba11dccd9c53f392dc50cf060150a9 [3/16] kernfs: Send IN_DELETE_SELF and IN_IGNORED
config: x86_64-kexec (https://download.01.org/0day-ci/archive/20260313/[email protected]/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260313/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

All warnings (new ones prefixed by >>):

>> Warning: fs/kernfs/dir.c:491 function parameter 'drop_supers' not described in 'kernfs_drain'
>> Warning: fs/kernfs/dir.c:491 function parameter 'drop_supers' not described in 'kernfs_drain'
Signature · 2 lines
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
#1 lore raw
Quoted 13 lines · kernel test robot
tree:   https://git.kernel.org/pub/scm/linux/kernel/git/driver-core/driver-core.git driver-core-testing
head:   e7ccc9e054beb4c366228d24786f67c738206605
commit: eea5d2bb34ba11dccd9c53f392dc50cf060150a9 [3/16] kernfs: Send IN_DELETE_SELF and IN_IGNORED
config: x86_64-kexec (https://download.01.org/0day-ci/archive/20260313/[email protected]/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260313/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

Quoted 8 lines

All warnings (new ones prefixed by >>):

Quoted 2 lines
Quoted 2 lines

Warning: fs/kernfs/dir.c:491 function parameter 'drop_supers' not described in 'kernfs_drain'
Warning: fs/kernfs/dir.c:491 function parameter 'drop_supers' not described in 'kernfs_drain'

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Ah, yes. This will fix it. Greg should I resend the patches?

fs/kernfs/dir.c +2 -0
index 715b651e35a0..7f355316704c 100644
@@ -481,6 +481,8 @@ void kernfs_put_active(struct kernfs_node *kn)
 /**
  * kernfs_drain - drain kernfs_node
  * @kn: kernfs_node to drain
+ * @drop_supers: Set to true if this function is called with the
+ *               kernfs_supers_rwsem locked.
#2 lore raw
Quoted 30 lines · T.J. Mercier
Quoted 13 lines · kernel test robot
tree:   https://git.kernel.org/pub/scm/linux/kernel/git/driver-core/driver-core.git driver-core-testing
head:   e7ccc9e054beb4c366228d24786f67c738206605
commit: eea5d2bb34ba11dccd9c53f392dc50cf060150a9 [3/16] kernfs: Send IN_DELETE_SELF and IN_IGNORED
config: x86_64-kexec (https://download.01.org/0day-ci/archive/20260313/[email protected]/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260313/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

Quoted 8 lines

All warnings (new ones prefixed by >>):

Quoted 2 lines
Quoted 2 lines

Warning: fs/kernfs/dir.c:491 function parameter 'drop_supers' not described in 'kernfs_drain'
Warning: fs/kernfs/dir.c:491 function parameter 'drop_supers' not described in 'kernfs_drain'

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Ah, yes. This will fix it. Greg should I resend the patches?

fs/kernfs/dir.c +0 -0
index 715b651e35a0..7f355316704c 100644

fs/kernfs/dir.c void kernfs_put_active(struct kernfs_node *kn) · line 485

Quoted 5 lines
fs/kernfs/dir.c +2 -0
@@ -481,6 +481,8 @@ void kernfs_put_active(struct kernfs_node *kn)
 /**
  * kernfs_drain - drain kernfs_node
  * @kn: kernfs_node to drain
+ * @drop_supers: Set to true if this function is called with the
+ *               kernfs_supers_rwsem locked.

Just send this as a fix-up, as it is just a documentation update.

thanks,

greg k-h