Skip to contentSkip to conversation

ASoC: amd: Move to GPIO descriptors

PATCH In review Linus Walleij 2 participants 8 messages Mar 14 – Mar 16

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

cover ASoC: amd: Move to GPIO descriptors

After a quick look and test-compile I can determine that all of these drivers include <linux/gpio.h> for no reason whatsoever, so fixing it is low hanging fruit.

---
Linus Walleij (5):
ASoC: amd: acp-da7291-max98357a: Drop unused include
ASoC: amd: acp-es8336: Drop unused include
ASoC: amd: acp-rt5645: Drop unused include
ASoC: amd: acp3x-es83x: Drop unused include
ASoC: amd: acp3x-rt5682-max9836: Drop unused include

 sound/soc/amd/acp-da7219-max98357a.c          | 1 -
 sound/soc/amd/acp-es8336.c                    | 1 -
 sound/soc/amd/acp-rt5645.c                    | 1 -
 sound/soc/amd/acp/acp3x-es83xx/acp3x-es83xx.c | 1 -
 sound/soc/amd/acp3x-rt5682-max9836.c          | 1 -
 5 files changed, 5 deletions(-)

---
base-commit: 6de23f81a5e08be8fbf5e8d7e9febc72a5b5f27f
change-id: 20260314-asoc-amd-61b910b46110

Best regards,

Signature · 1 line
Linus Walleij <[email protected]>
#1 lore raw

PATCH 1/5 ASoC: amd: acp-da7291-max98357a: Drop unused include

This driver includes the legacy header <linux/gpio.h> but does not use any symbols from it. Drop the inclusion.

---
 sound/soc/amd/acp-da7219-max98357a.c | 1 -
 1 file changed, 1 deletion(-)
sound/soc/amd/acp-da7219-max98357a.c +0 -1
index 42aa009c4e13..3c08e6e17e41 100644
@@ -11,7 +11,6 @@
 #include <sound/soc-dapm.h>
 #include <sound/jack.h>
 #include <linux/clk.h>
-#include <linux/gpio.h>
 #include <linux/module.h>
 #include <linux/regulator/machine.h>
 #include <linux/regulator/driver.h>
Signature · 1 line
2.53.0
#2 lore raw

PATCH 2/5 ASoC: amd: acp-es8336: Drop unused include

In reply to Linus Walleij

This driver includes the legacy header <linux/gpio.h> but does not use any symbols from it. Drop the inclusion.

---
 sound/soc/amd/acp-es8336.c | 1 -
 1 file changed, 1 deletion(-)
sound/soc/amd/acp-es8336.c +0 -1
index b16dde0e2987..9f3f11256788 100644
@@ -11,7 +11,6 @@
 #include <sound/pcm_params.h>
 #include <sound/soc-dapm.h>
 #include <sound/jack.h>
-#include <linux/gpio.h>
 #include <linux/device.h>
 #include <linux/dmi.h>
 #include <linux/gpio/consumer.h>
Signature · 1 line
2.53.0
#3 lore raw

PATCH 3/5 ASoC: amd: acp-rt5645: Drop unused include

In reply to Linus Walleij

This driver includes the legacy header <linux/gpio.h> but does not use any symbols from it. Drop the inclusion.

---
 sound/soc/amd/acp-rt5645.c | 1 -
 1 file changed, 1 deletion(-)
sound/soc/amd/acp-rt5645.c +0 -1
index 11d373169380..894f530434da 100644
@@ -32,7 +32,6 @@
 #include <sound/pcm_params.h>
 #include <sound/soc-dapm.h>
 #include <sound/jack.h>
-#include <linux/gpio.h>
 #include <linux/module.h>
 #include <linux/i2c.h>
 #include <linux/acpi.h>
Signature · 1 line
2.53.0
#4 lore raw

PATCH 4/5 ASoC: amd: acp3x-es83x: Drop unused include

In reply to Linus Walleij

This driver includes the legacy header <linux/gpio.h> but does not use any symbols from it. Drop the inclusion.

---
 sound/soc/amd/acp/acp3x-es83xx/acp3x-es83xx.c | 1 -
 1 file changed, 1 deletion(-)
sound/soc/amd/acp/acp3x-es83xx/acp3x-es83xx.c +0 -1
index 141ea4787d99..46fff565d732 100644
@@ -11,7 +11,6 @@
 #include <sound/jack.h>
 #include <sound/soc-acpi.h>
 #include <linux/clk.h>
-#include <linux/gpio.h>
 #include <linux/gpio/consumer.h>
 #include <linux/module.h>
 #include <linux/i2c.h>
Signature · 1 line
2.53.0
#5 lore raw

PATCH 5/5 ASoC: amd: acp3x-rt5682-max9836: Drop unused include

In reply to Linus Walleij

This driver includes the legacy header <linux/gpio.h> but does not use any symbols from it. Drop the inclusion.

---
 sound/soc/amd/acp3x-rt5682-max9836.c | 1 -
 1 file changed, 1 deletion(-)
sound/soc/amd/acp3x-rt5682-max9836.c +0 -1
index 4ca1978020a9..39e1a355e157 100644
@@ -11,7 +11,6 @@
 #include <sound/soc-dapm.h>
 #include <sound/jack.h>
 #include <linux/clk.h>
-#include <linux/gpio.h>
 #include <linux/gpio/consumer.h>
 #include <linux/module.h>
 #include <linux/i2c.h>
Signature · 1 line
2.53.0
maintainer
#6 lore raw
In reply to Linus Walleij
Quoted 8 lines · Linus Walleij

ASoC: amd: Move to GPIO descriptors

After a quick look and test-compile I can determine that all of these drivers include <linux/gpio.h> for no reason whatsoever, so fixing it is low hanging fruit.

[...]

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.1

Thanks!

[1/5] ASoC: amd: acp-da7291-max98357a: Drop unused include

      https://git.kernel.org/broonie/sound/c/6d841b46ec05
[2/5] ASoC: amd: acp-es8336: Drop unused include
      https://git.kernel.org/broonie/sound/c/0a80eff3f53c
[3/5] ASoC: amd: acp-rt5645: Drop unused include
      https://git.kernel.org/broonie/sound/c/d63b722361b8
[4/5] ASoC: amd: acp3x-es83x: Drop unused include
      https://git.kernel.org/broonie/sound/c/70f0a90e718d
[5/5] ASoC: amd: acp3x-rt5682-max9836: Drop unused include
      https://git.kernel.org/broonie/sound/c/c43988dfe25b

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

maintainer
#7 lore raw
In reply to Linus Walleij
Quoted 3 lines · Linus Walleij

After a quick look and test-compile I can determine that all of these drivers include <linux/gpio.h> for no reason whatsoever, so fixing it is low hanging fruit.

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/5] ASoC: amd: acp-da7291-max98357a: Drop unused include

      https://git.kernel.org/broonie/misc/c/6d841b46ec05
[2/5] ASoC: amd: acp-es8336: Drop unused include
      https://git.kernel.org/broonie/misc/c/0a80eff3f53c
[3/5] ASoC: amd: acp-rt5645: Drop unused include
      https://git.kernel.org/broonie/misc/c/d63b722361b8
[4/5] ASoC: amd: acp3x-es83x: Drop unused include
      https://git.kernel.org/broonie/misc/c/70f0a90e718d
[5/5] ASoC: amd: acp3x-rt5682-max9836: Drop unused include
      https://git.kernel.org/broonie/misc/c/c43988dfe25b

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark