thermal: sprd: Use min instead of clamp in sprd_thm_temp_to_rawdata
Subsystems (2)
PATCH RESEND 1/1 thermal: sprd: Use min instead of clamp in sprd_thm_temp_to_rawdata
Clamping 'val' to itself is unnecessary and the expression can be simplified by using min() instead. Casting SPRD_THM_RAW_DATA_HIGH to u32 is also redundant and can be removed.
Reviewed-by Baolin Wang <[email protected]>
Reviewed-by Lukasz Luba <[email protected]>
Signed-off-by Thorsten Blum <[email protected]>
--- drivers/thermal/sprd_thermal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/thermal/sprd_thermal.c +1 -1
@@ -201,7 +201,7 @@ static int sprd_thm_temp_to_rawdata(int temp, struct sprd_thermal_sensor *sen)*/ val = (temp + sen->cal_offset) / sen->cal_slope; -return clamp (val, val, (u32)(SPRD_THM_RAW_DATA_HIGH -1 )); +return min (val,SPRD_THM_RAW_DATA_HIGH -1 ); }static int sprd_thm_read_temp (struct thermal_zone_device *tz,int *temp)
Quoted 8 lines · Thorsten Blum
Clamping 'val' to itself is unnecessary and the expression can be simplified by using
min()instead. CastingSPRD_THM_RAW_DATA_HIGHto u32 is also redundant and can be removed.Reviewed-by Baolin Wang <[email protected]>Reviewed-by Lukasz Luba <[email protected]>Signed-off-by Thorsten Blum <[email protected]>---
You can stop resending, it is already applied :)