LTP: adjust socket xattr tests for kernel 7.1.0+
v2 cover LTP: adjust socket xattr tests for kernel 7.1.0+
Linux 7.1.0 allows user.* xattrs on sockets (dc0876b9846d). Update fsetxattr02/setxattr02 to expect success on 7.1.0+ (instead of -EPERM).
Jan Polensky (2):
fsetxattr02: Adapt test for kernel 7.1.0+ socket xattr support
setxattr02: Adapt test for kernel 7.1.0+ socket xattr support
testcases/kernel/syscalls/fsetxattr/fsetxattr02.c | 7 ++++++- testcases/kernel/syscalls/setxattr/setxattr02.c | 6 +++++- 2 files changed, 11 insertions(+), 2 deletions(-)
Signature · 5 lines
2.53.0 -- Mailing list info: https://lists.linux.it/listinfo/ltp
PATCH v2 1/2 fsetxattr02: Adapt test for kernel 7.1.0+ socket xattr support
Starting with kernel 7.1.0, sockets support extended attributes in the user.* namespace. This behavior was enabled by dc0876b9846d ("xattr: support extended attributes on sockets"), which permits user.* xattrs on S_IFSOCK inodes (previously rejected with -EPERM).
Adapts the test to expect success (exp_err = 0) instead of EPERM when testing fsetxattr(2) on sockets with kernel 7.1.0+.
--- testcases/kernel/syscalls/fsetxattr/fsetxattr02.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
testcases/kernel/syscalls/fsetxattr/fsetxattr02.c +6 -1
@@ -19,7 +19,8 @@* - Set attribute to a block special file, fsetxattr(2) should * return -1 and set errno to EPERM. * - Set attribute to a UNIX domain socket, fsetxattr(2) should -* return -1 and set errno to EPERM. +* return -1 and set errno to EPERM. Will SUCCEED on kernel +* with commit dc0876b9846d. */ /*
@@ -158,6 +159,10 @@ static void verify_fsetxattr(unsigned int i)if (TST_RET ==-1 &&TST_ERR ==EOPNOTSUPP )tst_brk (TCONF ,"fsetxattr(2) not supported" ); +/* consider kernels with commit dc0876b9846d */ +if ((tst_kvercmp (7 ,1 ,0 ) >=0 ) && (strncmp (tc[i].fname,SOCK ,strlen (SOCK )) ==0 )) + tc[i].exp_err =0 ; +/* success */ if (!tc[i].exp_err) {
Signature · 5 lines
2.53.0 -- Mailing list info: https://lists.linux.it/listinfo/ltp
PATCH v2 2/2 setxattr02: Adapt test for kernel 7.1.0+ socket xattr support
In reply to Jan PolenskyStarting with kernel 7.1.0, sockets support extended attributes in the user.* namespace. This behavior was enabled by dc0876b9846d ("xattr:
support extended attributes on sockets"), which permits user.* xattrs on S_IFSOCK inodes (previously rejected with -EPERM).
Adapts the test to expect success (exp_err = 0) instead of EPERM when testing setxattr(2) on sockets with kernel 7.1.0+.
--- testcases/kernel/syscalls/setxattr/setxattr02.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
testcases/kernel/syscalls/setxattr/setxattr02.c +5 -1
@@ -15,7 +15,7 @@* - EPERM - set attribute to a FIFO * - EPERM - set attribute to a char special file * - EPERM - set attribute to a block special file -* - EPERM - set attribute to a UNIX domain socket +* - EPERM/SUCCEED - set attribute to a UNIX domain socket (commit dc0876b9846d) */ #include "config.h"
@@ -132,6 +132,10 @@ static void verify_setxattr(unsigned int i)if (TST_RET ==-1 &&TST_ERR ==EOPNOTSUPP )tst_brk (TCONF ,"setxattr(2) not supported" ); +/* consider kernels with commit dc0876b9846d */ +if ((tst_kvercmp (7 ,1 ,0 ) >=0 ) && (strncmp (tc[i].fname,SOCK ,strlen (SOCK )) ==0 )) + tc[i].exp_err =0 ; +/* success */ if (!tc[i].exp_err) {
Signature · 5 lines
2.53.0 -- Mailing list info: https://lists.linux.it/listinfo/ltp
Re: [LTP] [PATCH v2 2/2] setxattr02: Adapt test for kernel 7.1.0+ socket xattr support
Hi Jan,
Quoted 27 lines
Starting with kernel 7.1.0, sockets support extended attributes in the user.* namespace. This behavior was enabled by
dc0876b9846d("xattr:
support extended attributes on sockets"), which permits user.* xattrs onS_IFSOCKinodes (previously rejected with-EPERM).Adapts the test to expect success (
exp_err= 0) instead of EPERM when testing setxattr(2) on sockets with kernel 7.1.0+.Signed-off-by Jan Polensky <[email protected]>--- testcases/kernel/syscalls/setxattr/setxattr02.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)testcases/kernel/syscalls/setxattr/setxattr02.c +1
-1@@ -15,7 +15,7 @@* - EPERM - set attribute to a FIFO * - EPERM - set attribute to a char special file * - EPERM - set attribute to a block special file -* - EPERM - set attribute to a UNIX domain socket +* - EPERM/SUCCEED - set attribute to a UNIX domain socket (commit dc0876b9846d) */ #include "config.h"
testcases/kernel/syscalls/setxattr/setxattr02.c static void verify_setxattr(unsigned int i) · line 137
Quoted 6 lines
testcases/kernel/syscalls/setxattr/setxattr02.c +3
-0@@ -132,6 +132,10 @@ static void verify_setxattr(unsigned int i)if (TST_RET ==-1 &&TST_ERR ==EOPNOTSUPP )tst_brk (TCONF ,"setxattr(2) not supported" ); +/* consider kernels with commit dc0876b9846d */ +if ((tst_kvercmp (7 ,1 ,0 ) >=0 ) && (strncmp (tc[i].fname,SOCK ,strlen (SOCK )) ==0 )) + tc[i].exp_err =0 ;
I'm sorry I haven't pointed out it on v1.
1) Kernel detection should be in the setup function (otherwise kernel detection is done 7x, but needed only 1x, and when run more times with -i1000 it's even more time wasted), result stored into static variable, see:testcases/kernel/syscalls/userfaultfd/userfaultfd01.c
2) While checking file name works, we usually try to somehow move the check into struct test_case.
testcases/kernel/syscalls/finit_module/finit_module02.c
function pointer to in the test struct, function fixes the errno, code run in the setup.
In this case when a single case requires it, I would combine these 2 approaches:
1) detect kver in the setup
#define BEFORE_7_1 1
#define AFTER_7_1 2
static int kver;
static void setup(void)
{
...
if (tst_kvercmp(7, 1, 0) >= 0)
kver = AFTER_7_1;
else
kver = BEFORE_7_1;
}2) custom function
struct test_case {
...
void (*fix_errno)(struct test_case *tc);
};static void fix_sock(struct tcase *tc)
{
/* dc0876b9846d ("xattr: support extended attributes on sockets") */
if (kver == AFTER_7_1)
tc[i].exp_err = 0;
}static void verify_setxattr(unsigned int i)
{
if (tc[i].fix_errno)
tc[i].fix_errno(&tc[i]);
...
}Also, it helps reviewing when your cover letter contains changelog. On single patch it can be added under --- (so that it's not part of the commit message.
Kind regards,
Petr
Quoted 4 lines
testcases/kernel/syscalls/setxattr/setxattr02.c +1
-0+/* success */ if (!tc[i].exp_err) {
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Re: [LTP] [PATCH v2 2/2] setxattr02: Adapt test for kernel 7.1.0+ socket xattr support
On Mon, Mar 16, 2026 at 08:56:37AM +0100, Petr Vorel wrote:
Hi Petr,
Quoted 58 lines
Hi Jan,
testcases/kernel/syscalls/setxattr/setxattr02.c static void verify_setxattr(unsigned int i) · line 137
Quoted 5 lines
testcases/kernel/syscalls/setxattr/setxattr02.c +3
-0tst_brk (TCONF ,"setxattr(2) not supported" ); +/* consider kernels with commit dc0876b9846d */ +if ((tst_kvercmp (7 ,1 ,0 ) >=0 ) && (strncmp (tc[i].fname,SOCK ,strlen (SOCK )) ==0 )) + tc[i].exp_err =0 ;I'm sorry I haven't pointed out it on v1.
1) Kernel detection should be in the setup function (otherwise kernel detection is done 7x, but needed only 1x, and when run more times with -i1000 it's even more time wasted), result stored into static variable, see:
testcases/kernel/syscalls/userfaultfd/userfaultfd01.c2) While checking file name works, we usually try to somehow move the check into struct
test_case.
testcases/kernel/syscalls/finit_module/finit_module02.c
function pointer to in the test struct, function fixes the errno, code run in the setup.In this case when a single case requires it, I would combine these 2 approaches:
1) detect kver in the setup
#define
BEFORE_7_11
#defineAFTER_7_12
static int kver;static void setup(void)
{ ... if (tst_kvercmp(7, 1, 0) >= 0) kver = AFTER_7_1; else kver = BEFORE_7_1; }2) custom function
struct test_case { ... void (*fix_errno)(struct test_case *tc); };static void
fix_sock(struct tcase *tc){ /* dc0876b9846d ("xattr: support extended attributes on sockets") */ if (kver == AFTER_7_1) tc[i].exp_err = 0; }static void
verify_setxattr(unsigned int i){ if (tc[i].fix_errno) tc[i].fix_errno(&tc[i]); ... }
Quoted 10 lines
Also, it helps reviewing when your cover letter contains changelog. On single patch it can be added under --- (so that it's not part of the commit message.
Kind regards,
PetrQuoted 4 lines
testcases/kernel/syscalls/setxattr/setxattr02.c +1
-0+/* success */ if (!tc[i].exp_err) {
Thank you for the suggestions, I appreciate them and will take them into account. I’ll send an updated version soon.
Kind regards,
Jan
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp