Skip to contentSkip to conversation

ata: libata-core: disable LPM on ADATA SU680 SSD

PATCH Applied Damien Le Moal 3 participants 3 messages Mar 14 – Mar 16 libata

lore
Share & tools
lore

Damien Le Moal

author maintainer
#0 lore raw

PATCH 1/1 ata: libata-core: disable LPM on ADATA SU680 SSD

ADATA SU680 SSDs suffer from NCQ read and write commands timeouts or bus errors when link power management (LPM) is enabled. Flag these devices with the ATA_QUIRK_NOLPM quirk to prevent the use of LPM and avoid these command failures.

---
 drivers/ata/libata-core.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/ata/libata-core.c +3 -0
index 6c4e567b6582..374993031895 100644
@@ -4188,6 +4188,9 @@ static const struct ata_dev_quirks_entry __ata_dev_quirks[] = {
 	{ "ST3320[68]13AS",	"SD1[5-9]",	ATA_QUIRK_NONCQ |
 						ATA_QUIRK_FIRMWARE_WARN },
 
+	/* ADATA devices with LPM issues. */
+	{ "ADATA SU680",	NULL,		ATA_QUIRK_NOLPM },
+
 	/* Seagate disks with LPM issues */
 	{ "ST1000DM010-2EP102",	NULL,		ATA_QUIRK_NOLPM },
 	{ "ST2000DM008-2FR102",	NULL,		ATA_QUIRK_NOLPM },
Signature · 1 line
2.53.0
Reviewed-by on v1 1/1
#1 lore raw

Damien,

Quoted 4 lines

ADATA SU680 SSDs suffer from NCQ read and write commands timeouts or bus errors when link power management (LPM) is enabled. Flag these devices with the ATA_QUIRK_NOLPM quirk to prevent the use of LPM and avoid these command failures.

Looks OK.

Signature · 1 line
Martin K. Petersen
maintainer Applied
#2 lore raw
In reply to Damien Le Moal
Quoted 5 lines · Damien Le Moal

ADATA SU680 SSDs suffer from NCQ read and write commands timeouts or bus errors when link power management (LPM) is enabled. Flag these devices with the ATA_QUIRK_NOLPM quirk to prevent the use of LPM and avoid these command failures.

Applied to libata/linux.git (for-7.0-fixes), thanks!

[1/1] ata: libata-core: disable LPM on ADATA SU680 SSD

      https://git.kernel.org/libata/linux/c/ce5ae93d

Kind regards,
Niklas