Skip to contentSkip to conversation

perf symbol: Add RISCV case in get_plt_sizes

PATCH Applied [email protected] 3 participants 3 messages Mar 17 – Mar 19

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 perf symbol: Add RISCV case in get_plt_sizes

From: Chen Pei <[email protected]>

According to RISC-V psABI specification, the PLT (Program Linkage Table) has the following layout:
- The first PLT entry occupies two 16-byte entries (32 bytes total)
- Subsequent PLT entries take up 16 bytes each

This aligns with the binutils-gdb implementation which defines the same PLT sizes for RISC-V architecture.

Update get_plt_sizes() to set plt_header_size=32 and plt_entry_size=16 for EM_RISCV, matching the architecture's standard ABI.

Since AARCH64, LOONGARCH, and RISCV have the same PLT size definition, they are merged together.

---
 tools/perf/util/symbol-elf.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
tools/perf/util/symbol-elf.c +1 -3
index 76912c62b6a0..806936d95523 100644
@@ -372,10 +372,8 @@ static bool get_plt_sizes(struct dso *dso, GElf_Ehdr *ehdr, GElf_Shdr *shdr_plt,
 		*plt_entry_size = 12;
 		return true;
 	case EM_AARCH64:
-		*plt_header_size = 32;
-		*plt_entry_size = 16;
-		return true;
 	case EM_LOONGARCH:
+	case EM_RISCV:
 		*plt_header_size = 32;
 		*plt_entry_size = 16;
 		return true;
Signature · 1 line
2.50.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 11 lines · On Tue, Mar 17, 2026 at 11:49 AM <[email protected]> wrote:

From: Chen Pei <[email protected]>

According to RISC-V psABI specification, the PLT (Program Linkage Table) has the following layout:
- The first PLT entry occupies two 16-byte entries (32 bytes total)
- Subsequent PLT entries take up 16 bytes each

This aligns with the binutils-gdb implementation which defines the same PLT sizes for RISC-V architecture.

Quoted 8 lines

Update get_plt_sizes() to set plt_header_size=32 and plt_entry_size=16 for EM_RISCV, matching the architecture's standard ABI.

Since AARCH64, LOONGARCH, and RISCV have the same PLT size definition, they are merged together.

I don't think putting Link here is a good idea. Just copy the part of the psabi spec v1.0 here:

8.4.6. Program Linkage Table
...
The first entry in the PLT occupies two 16 byte entries:
...
Subsequent function entry stubs in the PLT take up 16 bytes and load a function pointer from the GOT.

For others:

Quoted 27 lines
---
 tools/perf/util/symbol-elf.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
tools/perf/util/symbol-elf.c +1 -4
index 76912c62b6a0..806936d95523 100644
@@ -372,10 +372,8 @@ static bool get_plt_sizes(struct dso *dso, GElf_Ehdr *ehdr, GElf_Shdr *shdr_plt,
                *plt_entry_size = 12;
                return true;
        case EM_AARCH64:
-               *plt_header_size = 32;
-               *plt_entry_size = 16;
-               return true;
        case EM_LOONGARCH:
+       case EM_RISCV:
                *plt_header_size = 32;
                *plt_entry_size = 16;
                return true;
--

2.50.1

Signature · 2 lines
Best Regards
 Guo Ren
maintainer Applied
#2 lore raw
In reply to [email protected]
Quoted 9 lines · On Tue, 17 Mar 2026 11:48:47 +0800, [email protected] wrote:

According to RISC-V psABI specification, the PLT (Program Linkage Table) has the following layout:
- The first PLT entry occupies two 16-byte entries (32 bytes total)
- Subsequent PLT entries take up 16 bytes each

This aligns with the binutils-gdb implementation which defines the same PLT sizes for RISC-V architecture.

[...]

Applied to perf-tools-next, thanks!

Best regards,
Namhyung