Skip to contentSkip to conversation

platform: int3472: Drop redundant initialisation to 0 and NULL

PATCH In review Sakari Ailus 3 participants 3 messages Mar 17 – Mar 27

Subsystems (4)
lore
Share & tools
lore

Sakari Ailus

author maintainer
#0 lore raw

PATCH 1/1 platform: int3472: Drop redundant initialisation to 0 and NULL

A few fields in structs containing regulator initialisation data for Dell laptops are initialised to 0 and NULL. Drop the explicit initialisation as redundant.

---
 drivers/platform/x86/intel/int3472/tps68470_board_data.c | 8 --------
 1 file changed, 8 deletions(-)
drivers/platform/x86/intel/int3472/tps68470_board_data.c +0 -8
index 6bec5a910396..c1ddbf9a82c0 100644
@@ -151,8 +151,6 @@ static const struct regulator_init_data dell_7212_tps68470_core_reg_init_data =
 		.apply_uV = 1,
 		.valid_ops_mask = REGULATOR_CHANGE_STATUS,
 	},
-	.num_consumer_supplies = 0,
-	.consumer_supplies = NULL,
 };
 
 static const struct regulator_init_data dell_7212_tps68470_ana_reg_init_data = {
@@ -162,8 +160,6 @@ static const struct regulator_init_data dell_7212_tps68470_ana_reg_init_data = {
 		.apply_uV = 1,
 		.valid_ops_mask = REGULATOR_CHANGE_STATUS,
 	},
-	.num_consumer_supplies = 0,
-	.consumer_supplies = NULL,
 };
 
 static const struct regulator_init_data dell_7212_tps68470_vcm_reg_init_data = {
@@ -173,8 +169,6 @@ static const struct regulator_init_data dell_7212_tps68470_vcm_reg_init_data = {
 		.apply_uV = 1,
 		.valid_ops_mask = REGULATOR_CHANGE_STATUS,
 	},
-	.num_consumer_supplies = 0,
-	.consumer_supplies = NULL,
 };
 
 static const struct regulator_init_data dell_7212_tps68470_vio_reg_init_data = {
@@ -184,8 +178,6 @@ static const struct regulator_init_data dell_7212_tps68470_vio_reg_init_data = {
 		.apply_uV = 1,
 		.valid_ops_mask = REGULATOR_CHANGE_STATUS,
 	},
-	.num_consumer_supplies = 0,
-	.consumer_supplies = NULL,
 };
 
 static const struct regulator_init_data dell_7212_tps68470_vsio_reg_init_data = {
Signature · 1 line
2.47.3
Reviewed-by on v1 1/1
#1 lore raw

Hi,

Quoted 5 lines · Sakari Ailus

A few fields in structs containing regulator initialisation data for Dell laptops are initialised to 0 and NULL. Drop the explicit initialisation as redundant.

Thanks, patch looks good to me:

Regards,

Hans

Quoted 44 lines
---
 drivers/platform/x86/intel/int3472/tps68470_board_data.c | 8 --------
 1 file changed, 8 deletions(-)
drivers/platform/x86/intel/int3472/tps68470_board_data.c +0 -8
index 6bec5a910396..c1ddbf9a82c0 100644
@@ -151,8 +151,6 @@ static const struct regulator_init_data dell_7212_tps68470_core_reg_init_data =
 		.apply_uV = 1,
 		.valid_ops_mask = REGULATOR_CHANGE_STATUS,
 	},
-	.num_consumer_supplies = 0,
-	.consumer_supplies = NULL,
 };
 
 static const struct regulator_init_data dell_7212_tps68470_ana_reg_init_data = {
@@ -162,8 +160,6 @@ static const struct regulator_init_data dell_7212_tps68470_ana_reg_init_data = {
 		.apply_uV = 1,
 		.valid_ops_mask = REGULATOR_CHANGE_STATUS,
 	},
-	.num_consumer_supplies = 0,
-	.consumer_supplies = NULL,
 };
 
 static const struct regulator_init_data dell_7212_tps68470_vcm_reg_init_data = {
@@ -173,8 +169,6 @@ static const struct regulator_init_data dell_7212_tps68470_vcm_reg_init_data = {
 		.apply_uV = 1,
 		.valid_ops_mask = REGULATOR_CHANGE_STATUS,
 	},
-	.num_consumer_supplies = 0,
-	.consumer_supplies = NULL,
 };
 
 static const struct regulator_init_data dell_7212_tps68470_vio_reg_init_data = {
@@ -184,8 +178,6 @@ static const struct regulator_init_data dell_7212_tps68470_vio_reg_init_data = {
 		.apply_uV = 1,
 		.valid_ops_mask = REGULATOR_CHANGE_STATUS,
 	},
-	.num_consumer_supplies = 0,
-	.consumer_supplies = NULL,
 };
 
 static const struct regulator_init_data dell_7212_tps68470_vsio_reg_init_data = {
maintainer Reviewed-by on v1 1/1
#2 lore raw
In reply to Sakari Ailus

Hi Sakari

Quoted 6 lines · Sakari Ailus

A few fields in structs containing regulator initialisation data for Dell laptops are initialised to 0 and NULL. Drop the explicit initialisation as redundant.

---

Quoted 43 lines
  drivers/platform/x86/intel/int3472/tps68470_board_data.c | 8 --------
  1 file changed, 8 deletions(-)
drivers/platform/x86/intel/int3472/tps68470_board_data.c +0 -8
index 6bec5a910396..c1ddbf9a82c0 100644
@@ -151,8 +151,6 @@ static const struct regulator_init_data dell_7212_tps68470_core_reg_init_data =
  		.apply_uV = 1,
  		.valid_ops_mask = REGULATOR_CHANGE_STATUS,
  	},
-	.num_consumer_supplies = 0,
-	.consumer_supplies = NULL,
  };
 
  static const struct regulator_init_data dell_7212_tps68470_ana_reg_init_data = {
@@ -162,8 +160,6 @@ static const struct regulator_init_data dell_7212_tps68470_ana_reg_init_data = {
  		.apply_uV = 1,
  		.valid_ops_mask = REGULATOR_CHANGE_STATUS,
  	},
-	.num_consumer_supplies = 0,
-	.consumer_supplies = NULL,
  };
 
  static const struct regulator_init_data dell_7212_tps68470_vcm_reg_init_data = {
@@ -173,8 +169,6 @@ static const struct regulator_init_data dell_7212_tps68470_vcm_reg_init_data = {
  		.apply_uV = 1,
  		.valid_ops_mask = REGULATOR_CHANGE_STATUS,
  	},
-	.num_consumer_supplies = 0,
-	.consumer_supplies = NULL,
  };
 
  static const struct regulator_init_data dell_7212_tps68470_vio_reg_init_data = {
@@ -184,8 +178,6 @@ static const struct regulator_init_data dell_7212_tps68470_vio_reg_init_data = {
  		.apply_uV = 1,
  		.valid_ops_mask = REGULATOR_CHANGE_STATUS,
  	},
-	.num_consumer_supplies = 0,
-	.consumer_supplies = NULL,
  };
 
  static const struct regulator_init_data dell_7212_tps68470_vsio_reg_init_data = {