bus: tegra-aconnect: Use dev_err_probe for probe error paths
PATCH 1/1 bus: tegra-aconnect: Use dev_err_probe for probe error paths
Convert probe error handling to use dev_err_probe() which provides proper handling of -EPROBE_DEFER.
Signed-off-by Sheetal <[email protected]>
--- drivers/bus/tegra-aconnect.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-)
drivers/bus/tegra-aconnect.c +6 -8
@@ -32,16 +32,14 @@ static int tegra_aconnect_probe(struct platform_device *pdev)return -ENOMEM ; aconnect->ape_clk =devm_clk_get (&pdev->dev,"ape" ); -if (IS_ERR (aconnect->ape_clk)) { -dev_err (&pdev->dev,"Can't retrieve ape clock\n" ); -return PTR_ERR (aconnect->ape_clk); - } +if (IS_ERR (aconnect->ape_clk)) +return dev_err_probe (&pdev->dev,PTR_ERR (aconnect->ape_clk), +"can't retrieve ape clock\n" ); aconnect->apb2ape_clk =devm_clk_get (&pdev->dev,"apb2ape" ); -if (IS_ERR (aconnect->apb2ape_clk)) { -dev_err (&pdev->dev,"Can't retrieve apb2ape clock\n" ); -return PTR_ERR (aconnect->apb2ape_clk); - } +if (IS_ERR (aconnect->apb2ape_clk)) +return dev_err_probe (&pdev->dev,PTR_ERR (aconnect->apb2ape_clk), +"can't retrieve apb2ape clock\n" );dev_set_drvdata (&pdev->dev, aconnect);pm_runtime_enable (&pdev->dev);
Signature · 1 line
2.17.1
Quoted 25 lines · Sheetal
Convert probe error handling to use
dev_err_probe()which provides proper handling of -EPROBE_DEFER.Signed-off-by Sheetal <[email protected]>--- drivers/bus/tegra-aconnect.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-)drivers/bus/tegra-aconnect.c +3
-4@@ -32,16 +32,14 @@ static int tegra_aconnect_probe(struct platform_device *pdev)return -ENOMEM ; aconnect->ape_clk =devm_clk_get (&pdev->dev,"ape" ); -if (IS_ERR (aconnect->ape_clk)) { -dev_err (&pdev->dev,"Can't retrieve ape clock\n" ); -return PTR_ERR (aconnect->ape_clk); - } +if (IS_ERR (aconnect->ape_clk)) +return dev_err_probe (&pdev->dev,PTR_ERR (aconnect->ape_clk), +"can't retrieve ape clock\n" ); aconnect->apb2ape_clk =devm_clk_get (&pdev->dev,"apb2ape" );
drivers/bus/tegra-aconnect.c static int tegra_aconnect_probe(struct platform_device *pdev) · line 45
Quoted 10 lines
drivers/bus/tegra-aconnect.c +3
-4-if (IS_ERR (aconnect->apb2ape_clk)) { -dev_err (&pdev->dev,"Can't retrieve apb2ape clock\n" ); -return PTR_ERR (aconnect->apb2ape_clk); - } +if (IS_ERR (aconnect->apb2ape_clk)) +return dev_err_probe (&pdev->dev,PTR_ERR (aconnect->apb2ape_clk), +"can't retrieve apb2ape clock\n" );dev_set_drvdata (&pdev->dev, aconnect);pm_runtime_enable (&pdev->dev);
Reviewed-by Jon Hunter <[email protected]>
Thanks!
Jon
Signature · 1 line
nvpublic
From: Thierry Reding <[email protected]>
Quoted 2 lines · Sheetal
Convert probe error handling to use
dev_err_probe()which provides proper handling of -EPROBE_DEFER.
Applied, thanks!
[1/1] bus: tegra-aconnect: Use dev_err_probe for probe error paths
commit: 36df0ef3b4187c69c271af7a1d56f7abb788655e
Best regards,
Signature · 1 line
Thierry Reding <[email protected]>