Skip to contentSkip to conversation

dt-bindings: input: touchscreen: ti,tsc2005: Add wakeup-source

PATCH Superseded [email protected] 2 participants 3 messages Mar 18 – Apr 3

Subsystems (3)

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 dt-bindings: input: touchscreen: ti,tsc2005: Add wakeup-source

From: bui duc phuc <[email protected]>

Document the "wakeup-source" property for the ti,tsc2005 touchscreen controllers to allow the device to wake the system from suspend.

---

changes:
v3: Remove blank lines
v2: Revise the commit content and remove patch1 related to I2C and SPI wakeup handling

 .../devicetree/bindings/input/touchscreen/ti,tsc2005.yaml    | 5 +++++
 1 file changed, 5 insertions(+)
Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml +5 -0
index 7187c390b2f5..a9842509c1fe 100644
@@ -55,6 +55,9 @@ properties:
   touchscreen-size-x: true
   touchscreen-size-y: true
 
+  wakeup-source:
+    type: boolean
+
 allOf:
   - $ref: touchscreen.yaml#
   - if:
@@ -97,6 +100,7 @@ examples:
 
             ti,x-plate-ohms = <280>;
             ti,esd-recovery-timeout-ms = <8000>;
+            wakeup-source;
         };
     };
   - |
@@ -124,5 +128,6 @@ examples:
 
             ti,x-plate-ohms = <280>;
             ti,esd-recovery-timeout-ms = <8000>;
+            wakeup-source;
         };
     };
Signature · 1 line
2.43.0
maintainer
#1 lore raw
Quoted 21 lines · On Wed, Mar 18, 2026 at 03:31:24PM +0700, [email protected] wrote:

From: bui duc phuc <[email protected]>

Document the "wakeup-source" property for the ti,tsc2005 touchscreen controllers to allow the device to wake the system from suspend.

---

changes:
v3: Remove blank lines
v2: Revise the commit content and remove patch1 related to I2C and SPI wakeup handling

 .../devicetree/bindings/input/touchscreen/ti,tsc2005.yaml    | 5 +++++
 1 file changed, 5 insertions(+)
Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml +0 -0
index 7187c390b2f5..a9842509c1fe 100644

Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml properties: · line 59

Quoted 5 lines
Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml +2 -0
@@ -55,6 +55,9 @@ properties:
   touchscreen-size-x: true
   touchscreen-size-y: true
 
+  wakeup-source:
+    type: boolean

wakeup-source already has a defined type.

wakeup-source: true

Quoted 22 lines
Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml +3 -0
+
 allOf:
   - $ref: touchscreen.yaml#
   - if:
@@ -97,6 +100,7 @@ examples:
 
             ti,x-plate-ohms = <280>;
             ti,esd-recovery-timeout-ms = <8000>;
+            wakeup-source;
         };
     };
   - |
@@ -124,5 +128,6 @@ examples:
 
             ti,x-plate-ohms = <280>;
             ti,esd-recovery-timeout-ms = <8000>;
+            wakeup-source;
         };
     };
Signature · 1 line
2.43.0
#2 lore raw

Hi Rob, Krzysztof, Conor,

Thanks for the discussion.

The core schema already defines "wakeup-source" as a common property (using oneOf for boolean or phandle-array), so defining the type here is redundant.

https://github.com/devicetree-org/dt-schema/blob/main/dtschema/schemas/wakeup-source.yaml

I'll update it to "wakeup-source: true" in v4.

Best regards,
Phuc

Quoted 55 lines · Rob Herring
Quoted 21 lines · On Wed, Mar 18, 2026 at 03:31:24PM +0700, [email protected] wrote:

From: bui duc phuc <[email protected]>

Document the "wakeup-source" property for the ti,tsc2005 touchscreen controllers to allow the device to wake the system from suspend.

---

changes:
v3: Remove blank lines
v2: Revise the commit content and remove patch1 related to I2C and SPI wakeup handling

 .../devicetree/bindings/input/touchscreen/ti,tsc2005.yaml    | 5 +++++
 1 file changed, 5 insertions(+)
Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml +0 -0
index 7187c390b2f5..a9842509c1fe 100644

Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml properties: · line 59

Quoted 5 lines
Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml +2 -0
@@ -55,6 +55,9 @@ properties:
   touchscreen-size-x: true
   touchscreen-size-y: true
 
+  wakeup-source:
+    type: boolean

wakeup-source already has a defined type.

wakeup-source: true

Quoted 22 lines
Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml +3 -1
+
 allOf:
   - $ref: touchscreen.yaml#
   - if:
@@ -97,6 +100,7 @@ examples:
 
             ti,x-plate-ohms = <280>;
             ti,esd-recovery-timeout-ms = <8000>;
+            wakeup-source;
         };
     };
   - |
@@ -124,5 +128,6 @@ examples:
 
             ti,x-plate-ohms = <280>;
             ti,esd-recovery-timeout-ms = <8000>;
+            wakeup-source;
         };
     };
--

2.43.0