Skip to contentSkip to conversation

staging: rtl8723bs: fix line length in rtw_pwrctrl.c

PATCH In review Ayan Mahmood 3 participants 3 messages Mar 9 – Mar 18 Staging

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 staging: rtl8723bs: fix line length in rtw_pwrctrl.c

Refactor lines exceeding 100 characters in rtw_pwrctrl.c to comply with kernel coding style as noted in the driver TODO.

---
v3:
- Move closing ) { to end of the line instead of the next line as suggested by Ethan Tidmore
v2:
- Rebase on staging-testing branch as requested

 drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)
drivers/staging/rtl8723bs/core/rtw_pwrctrl.c +7 -5
index 666e241704d9..1aea9ba4f35a 100644
@@ -331,7 +331,8 @@ static u8 PS_RDY_CHECK(struct adapter *padapter)
 	return true;
 }
 
-void rtw_set_ps_mode(struct adapter *padapter, u8 ps_mode, u8 smart_ps, u8 bcn_ant_mode, const char *msg)
+void rtw_set_ps_mode(struct adapter *padapter, u8 ps_mode,
+		     u8 smart_ps, u8 bcn_ant_mode, const char *msg)
 {
 	struct pwrctrl_priv *pwrpriv = adapter_to_pwrctl(padapter);
 
@@ -359,9 +360,9 @@ void rtw_set_ps_mode(struct adapter *padapter, u8 ps_mode, u8 smart_ps, u8 bcn_a
 			hal_btcoex_LpsNotify(padapter, ps_mode);
 		}
 	} else {
-		if ((PS_RDY_CHECK(padapter) && check_fwstate(&padapter->mlmepriv, WIFI_ASOC_STATE)) ||
-		    ((hal_btcoex_IsBtControlLps(padapter)) && (hal_btcoex_IsLpsOn(padapter)))
-			) {
+		if ((PS_RDY_CHECK(padapter) &&
+		     check_fwstate(&padapter->mlmepriv, WIFI_ASOC_STATE)) ||
+		    ((hal_btcoex_IsBtControlLps(padapter)) && (hal_btcoex_IsLpsOn(padapter)))) {
 			u8 pslv;
 
 			hal_btcoex_LpsNotify(padapter, ps_mode);
@@ -452,7 +453,8 @@ void LPS_Enter(struct adapter *padapter, const char *msg)
 			if (pwrpriv->pwr_mode == PS_MODE_ACTIVE) {
 				scnprintf(buf, sizeof(buf), "WIFI-%s", msg);
 				pwrpriv->bpower_saving = true;
-				rtw_set_ps_mode(padapter, pwrpriv->power_mgnt, padapter->registrypriv.smart_ps, 0, buf);
+				rtw_set_ps_mode(padapter, pwrpriv->power_mgnt,
+						padapter->registrypriv.smart_ps, 0, buf);
 			}
 		} else
 			pwrpriv->LpsIdleCount++;
Signature · 1 line
2.43.0
maintainer
#2 lore raw
In reply to Ayan Mahmood
Quoted 10 lines · Ayan Mahmood

Refactor lines exceeding 100 characters in rtw_pwrctrl.c to comply with kernel coding style as noted in the driver TODO.

---
v3:
- Move closing ) { to end of the line instead of the next line as suggested by Ethan Tidmore
v2:
- Rebase on staging-testing branch as requested

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree.

You are receiving this message because of the following common error(s) as indicated below:

- Your patch did not apply to any known trees that Greg is in control of. Possibly this is because you made it against Linus's tree, not the linux-next tree, which is where all of the development for the next version of the kernel is at. Please refresh your patch against the linux-next tree, or even better yet, the development tree specified in the MAINTAINERS file for the subsystem you are submitting a patch for, and resend it.

If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers.

thanks,

greg k-h's patch email bot