staging: atomisp: gc2235: prefer usleep_range over msleep
Subsystems (4)
PATCH 1/1 staging: atomisp: gc2235: prefer usleep_range over msleep
--- drivers/staging/media/atomisp/i2c/atomisp-gc2235.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/media/atomisp/i2c/atomisp-gc2235.c +1 -1
@@ -433,7 +433,7 @@ static int power_up(struct v4l2_subdev *sd) goto fail_power; } -msleep (5 ); +usleep_range (5000 ,6000 );return 0 ; fail_clk:
Signature · 1 line
2.43.0
PATCH v2 1/1 staging: media: atomisp: gc2235: prefer usleep_range over msleep
The gc2235 driver uses msleep(5) during power-up. msleep() is often imprecise for durations under 20ms. Replace it with usleep_range() to provide better precision.
--- drivers/staging/media/atomisp/i2c/atomisp-gc2235.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/media/atomisp/i2c/atomisp-gc2235.c +1 -1
@@ -433,7 +433,7 @@ static int power_up(struct v4l2_subdev *sd) goto fail_power; } -msleep (5 ); +usleep_range (5000 ,6000 );return 0 ; fail_clk:
Signature · 1 line
2.43.0
Re: [PATCH v2] staging: media: atomisp: gc2235: prefer usleep_range over msleep
Quoted 14 lines · Abhai Kollara
The gc2235 driver uses msleep(5) during power-up.
msleep()is often imprecise for durations under 20ms. Replace it withusleep_range()to provide better precision.Signed-off-by Abhai Kollara <[email protected]>--- drivers/staging/media/atomisp/i2c/atomisp-gc2235.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/media/atomisp/i2c/atomisp-gc2235.c +0
-0
drivers/staging/media/atomisp/i2c/atomisp-gc2235.c static int power_up(struct v4l2_subdev *sd) · line 436
Quoted 5 lines
drivers/staging/media/atomisp/i2c/atomisp-gc2235.c +1
-1@@ -433,7 +433,7 @@ static int power_up(struct v4l2_subdev *sd) goto fail_power; } -msleep (5 ); +usleep_range (5000 ,6000 );
I'd rather use fsleep() here.
Quoted 3 lines
drivers/staging/media/atomisp/i2c/atomisp-gc2235.c +0
-0return 0 ; fail_clk:
Signature · 1 line
Sakari Ailus
PATCH v3 1/1 staging: media: atomisp: gc2235: prefer fsleep over msleep
In reply to Abhai KollaraThe gc2235 driver uses msleep(5) during power-up. msleep() is often imprecise for durations under 20ms. Replace it with fsleep() to provide better precision.
---
v3:
- Use fsleep() instead of usleep_range() per Sakari Ailus's feedback.
v2:
- Replaced msleep() with usleep_range() (Superseded).
v1:
- Initial version.
drivers/staging/media/atomisp/i2c/atomisp-gc2235.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/media/atomisp/i2c/atomisp-gc2235.c +1 -1
@@ -433,7 +433,7 @@ static int power_up(struct v4l2_subdev *sd) goto fail_power; } -msleep (5 ); +fsleep (5000 );return 0 ; fail_clk:
Signature · 1 line
2.43.0
Sakari Ailus
reviewerRe: [PATCH v3] staging: media: atomisp: gc2235: prefer fsleep over msleep
Hi Abhai,
Quoted 8 lines · Abhai Kollara
The gc2235 driver uses msleep(5) during power-up.
msleep()is often imprecise for durations under 20ms. Replace it withfsleep()to provide better precision.Signed-off-by Abhai Kollara <[email protected]>---
v3:
- Usefsleep()instead ofusleep_range()per Sakari Ailus's feedback.
The commit 968d8904c2f86996b0615a08ee4048bccac56758 apparently already does this in my atomisp branch.
Signature · 3 lines
Kind regards, Sakari Ailus