media: qcom: camss: vfe: fix PIX subdev naming on VFE lite
Subsystems (4)
PATCH 1/1 media: qcom: camss: vfe: fix PIX subdev naming on VFE lite
VFE lite hardware does not provide a functional PIX path, but after the per sub-device type resource changes the PIX subdev name is still assigned unconditionally.
Only assign the PIX subdev name on non-lite VFE variants to avoid exposing a misleading device name.
--- drivers/media/platform/qcom/camss/camss-vfe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/platform/qcom/camss/camss-vfe.c +1 -1
@@ -2053,7 +2053,7 @@ int msm_vfe_register_entities(struct vfe_device *vfe,v4l2_subdev_init (sd, &vfe_v4l2_ops); sd->internal_ops = &vfe_v4l2_internal_ops; sd->flags |=V4L2_SUBDEV_FL_HAS_DEVNODE ; -if (i ==VFE_LINE_PIX ) +if (i ==VFE_LINE_PIX && vfe->res->is_lite == false)snprintf (sd->name,ARRAY_SIZE (sd->name),"%s%d_%s" ,MSM_VFE_NAME , vfe->id,"pix" );else
---
base-commit: 8e42d2514a7e8eb8d740d0ba82339dd6c0b6463f
change-id: 20260319-camss_fix-506ae164a5dc
Best regards,
Signature · 1 line
Wenmeng Liu <[email protected]>
Quoted 31 lines · Wenmeng Liu
VFE lite hardware does not provide a functional PIX path, but after the per sub-device type resource changes the PIX subdev name is still assigned unconditionally.
Only assign the PIX subdev name on non-lite VFE variants to avoid exposing a misleading device name.
Fixes ae44829a4a97 ("media: qcom: camss: Add per sub-device type resources")Signed-off-by Wenmeng Liu <[email protected]>--- drivers/media/platform/qcom/camss/camss-vfe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/media/platform/qcom/camss/camss-vfe.c +1
-2@@ -2053,7 +2053,7 @@ int msm_vfe_register_entities(struct vfe_device *vfe,v4l2_subdev_init (sd, &vfe_v4l2_ops); sd->internal_ops = &vfe_v4l2_internal_ops; sd->flags |=V4L2_SUBDEV_FL_HAS_DEVNODE ; -if (i ==VFE_LINE_PIX ) +if (i ==VFE_LINE_PIX && vfe->res->is_lite == false)snprintf (sd->name,ARRAY_SIZE (sd->name),"%s%d_%s" ,MSM_VFE_NAME , vfe->id,"pix" );else ---base-commit:
8e42d2514a7e8eb8d740d0ba82339dd6c0b6463f
change-id: 20260319-camss_fix-506ae164a5dc
Quoted 1 line
Best regards,
Loic Poulain
reviewerQuoted 19 lines · Wenmeng Liu
VFE lite hardware does not provide a functional PIX path, but after the per sub-device type resource changes the PIX subdev name is still assigned unconditionally.
Only assign the PIX subdev name on non-lite VFE variants to avoid exposing a misleading device name.
Fixes ae44829a4a97 ("media: qcom: camss: Add per sub-device type resources")Signed-off-by Wenmeng Liu <[email protected]>--- drivers/media/platform/qcom/camss/camss-vfe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/media/platform/qcom/camss/camss-vfe.c +0
-0
drivers/media/platform/qcom/camss/camss-vfe.c int msm_vfe_register_entities(struct vfe_device *vfe, · line 2058
Quoted 7 lines
drivers/media/platform/qcom/camss/camss-vfe.c +1
-1@@ -2053,7 +2053,7 @@ int msm_vfe_register_entities(struct vfe_device *vfe,v4l2_subdev_init (sd, &vfe_v4l2_ops); sd->internal_ops = &vfe_v4l2_internal_ops; sd->flags |=V4L2_SUBDEV_FL_HAS_DEVNODE ; -if (i ==VFE_LINE_PIX ) +if (i ==VFE_LINE_PIX && vfe->res->is_lite == false)snprintf (sd->name,ARRAY_SIZE (sd->name),"%s%d_%s" ,MSM_VFE_NAME , vfe->id,"pix" );
So the PIX path will be called RDI? Doesn’t that seem misleading as well?
Quoted 11 lines
drivers/media/platform/qcom/camss/camss-vfe.c +0
-1else ---base-commit:
8e42d2514a7e8eb8d740d0ba82339dd6c0b6463f
change-id: 20260319-camss_fix-506ae164a5dcBest regards,
--
Wenmeng Liu <[email protected]>
Quoted 16 lines · Loic Poulain
Quoted 14 lines · Wenmeng Liu
VFE lite hardware does not provide a functional PIX path, but after the per sub-device type resource changes the PIX subdev name is still assigned unconditionally.
Only assign the PIX subdev name on non-lite VFE variants to avoid exposing a misleading device name.
Fixes ae44829a4a97 ("media: qcom: camss: Add per sub-device type resources")Signed-off-by Wenmeng Liu <[email protected]>--- drivers/media/platform/qcom/camss/camss-vfe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 14 lines
drivers/media/platform/qcom/camss/camss-vfe.c int msm_vfe_register_entities(struct vfe_device *vfe, · line 2058
Quoted 12 lines
drivers/media/platform/qcom/camss/camss-vfe.c +1
-1@@ -2053,7 +2053,7 @@ int msm_vfe_register_entities(struct vfe_device *vfe,v4l2_subdev_init (sd, &vfe_v4l2_ops); sd->internal_ops = &vfe_v4l2_internal_ops; sd->flags |=V4L2_SUBDEV_FL_HAS_DEVNODE ; -if (i ==VFE_LINE_PIX ) +if (i ==VFE_LINE_PIX && vfe->res->is_lite == false)snprintf (sd->name,ARRAY_SIZE (sd->name),"%s%d_%s" ,MSM_VFE_NAME , vfe->id,"pix" );So the PIX path will be called RDI? Doesn’t that seem misleading as well?
when i == VFE_LINE_PIX and vfe->res->is_lite == false then vfe name is pix, not rdi.
thanks,
Wenmeng
Loic Poulain
reviewerQuoted 34 lines · Wenmeng Liu
Quoted 16 lines · Loic Poulain
Quoted 14 lines · Wenmeng Liu
VFE lite hardware does not provide a functional PIX path, but after the per sub-device type resource changes the PIX subdev name is still assigned unconditionally.
Only assign the PIX subdev name on non-lite VFE variants to avoid exposing a misleading device name.
Fixes ae44829a4a97 ("media: qcom: camss: Add per sub-device type resources")Signed-off-by Wenmeng Liu <[email protected]>--- drivers/media/platform/qcom/camss/camss-vfe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Quoted 14 lines
drivers/media/platform/qcom/camss/camss-vfe.c int msm_vfe_register_entities(struct vfe_device *vfe, · line 2058
Quoted 12 lines
drivers/media/platform/qcom/camss/camss-vfe.c +1
-1@@ -2053,7 +2053,7 @@ int msm_vfe_register_entities(struct vfe_device *vfe,v4l2_subdev_init (sd, &vfe_v4l2_ops); sd->internal_ops = &vfe_v4l2_internal_ops; sd->flags |=V4L2_SUBDEV_FL_HAS_DEVNODE ; -if (i ==VFE_LINE_PIX ) +if (i ==VFE_LINE_PIX && vfe->res->is_lite == false)snprintf (sd->name,ARRAY_SIZE (sd->name),"%s%d_%s" ,MSM_VFE_NAME , vfe->id,"pix" );So the PIX path will be called RDI? Doesn’t that seem misleading as well?
Quoted 2 lines
when i ==
VFE_LINE_PIXandvfe->res->is_lite== false then vfe name is pix, not rdi.
I mean when is_lite==true, we're going to name the PIX(lite) path RDI, whereas it's not a raw dump interface, I guess pix-lite includes minimal processing engine.
Regards,
Loic
Quoted 36 lines · Loic Poulain
Quoted 34 lines · Wenmeng Liu
Quoted 30 lines · Loic Poulain
Quoted 19 lines · Wenmeng Liu
VFE lite hardware does not provide a functional PIX path, but after the per sub-device type resource changes the PIX subdev name is still assigned unconditionally.
Only assign the PIX subdev name on non-lite VFE variants to avoid exposing a misleading device name.
Fixes ae44829a4a97 ("media: qcom: camss: Add per sub-device type resources")Signed-off-by Wenmeng Liu <[email protected]>--- drivers/media/platform/qcom/camss/camss-vfe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/media/platform/qcom/camss/camss-vfe.c +0
-0drivers/media/platform/qcom/camss/camss-vfe.c int msm_vfe_register_entities(struct vfe_device *vfe, · line 2058
Quoted 7 lines
drivers/media/platform/qcom/camss/camss-vfe.c +1
-1@@ -2053,7 +2053,7 @@ int msm_vfe_register_entities(struct vfe_device *vfe,v4l2_subdev_init (sd, &vfe_v4l2_ops); sd->internal_ops = &vfe_v4l2_internal_ops; sd->flags |=V4L2_SUBDEV_FL_HAS_DEVNODE ; -if (i ==VFE_LINE_PIX ) +if (i ==VFE_LINE_PIX && vfe->res->is_lite == false)snprintf (sd->name,ARRAY_SIZE (sd->name),"%s%d_%s" ,MSM_VFE_NAME , vfe->id,"pix" );So the PIX path will be called RDI? Doesn’t that seem misleading as well?
Quoted 6 lines
Quoted 2 lines
when i ==
VFE_LINE_PIXandvfe->res->is_lite== false then vfe name is pix, not rdi.I mean when is_lite==true, we're going to name the PIX(lite) path RDI, whereas it's not a raw dump interface, I guess pix-lite includes minimal processing engine.
For VFE Lite, only RDI paths are supported. There is no PIX output.
Thanks,
Wenmeng
Loic Poulain
reviewerQuoted 40 lines · Wenmeng Liu
Quoted 36 lines · Loic Poulain
Quoted 34 lines · Wenmeng Liu
Quoted 30 lines · Loic Poulain
Quoted 19 lines · Wenmeng Liu
VFE lite hardware does not provide a functional PIX path, but after the per sub-device type resource changes the PIX subdev name is still assigned unconditionally.
Only assign the PIX subdev name on non-lite VFE variants to avoid exposing a misleading device name.
Fixes ae44829a4a97 ("media: qcom: camss: Add per sub-device type resources")Signed-off-by Wenmeng Liu <[email protected]>--- drivers/media/platform/qcom/camss/camss-vfe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/media/platform/qcom/camss/camss-vfe.c +0
-0drivers/media/platform/qcom/camss/camss-vfe.c int msm_vfe_register_entities(struct vfe_device *vfe, · line 2058
Quoted 7 lines
drivers/media/platform/qcom/camss/camss-vfe.c +1
-1@@ -2053,7 +2053,7 @@ int msm_vfe_register_entities(struct vfe_device *vfe,v4l2_subdev_init (sd, &vfe_v4l2_ops); sd->internal_ops = &vfe_v4l2_internal_ops; sd->flags |=V4L2_SUBDEV_FL_HAS_DEVNODE ; -if (i ==VFE_LINE_PIX ) +if (i ==VFE_LINE_PIX && vfe->res->is_lite == false)snprintf (sd->name,ARRAY_SIZE (sd->name),"%s%d_%s" ,MSM_VFE_NAME , vfe->id,"pix" );So the PIX path will be called RDI? Doesn’t that seem misleading as well?
Quoted 8 lines
Quoted 6 lines
Quoted 2 lines
when i ==
VFE_LINE_PIXandvfe->res->is_lite== false then vfe name is pix, not rdi.I mean when is_lite==true, we're going to name the PIX(lite) path RDI, whereas it's not a raw dump interface, I guess pix-lite includes minimal processing engine.
For VFE Lite, only RDI paths are supported. There is no PIX output.
Ah ok, understood, this is RDI3. At some point we should clean up the code to avoid relying on statically defined RDI/PIX indices.
Regards,
Loic