fixup! runqemu: restore support to run inside SDK
PATCH 1/1 fixup! runqemu: restore support to run inside SDK
From: Chen Qi <[email protected]>
In previous patch[1], the os.path.exists was accidently called twice. This is incorrect.
[1] https://git.openembedded.org/openembedded-core/commit/?id=972155bbee02dd8061fee9c07a40f8e9034b9a3c
--- scripts/runqemu | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/runqemu +1 -1
@@ -1005,7 +1005,7 @@ to your build configuration. # If the STAGING_BINDIR_NATIVE directories from the config file don't exist # and we're in a sourced OE build directory try to extract the paths # from `bitbake -e` - havenative = os.path.exists(os.path.exists(self.get('STAGING_BINDIR_NATIVE'))) + havenative = os.path.exists(self.get('STAGING_BINDIR_NATIVE')) if not havenative: if not self.bitbake_e:
Signature · 1 line
2.49.0
Quoted 17 lines · Chen Qi via lists.openembedded.org
From: Chen Qi <[email protected]>
In previous patch[1], the os.path.exists was accidently called twice. This is incorrect.
[1] https://git.openembedded.org/openembedded-core/commit/?id=972155bbee02dd8061fee9c07a40f8e9034b9a3c
Signed-off-by Chen Qi <[email protected]>--- scripts/runqemu | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)scripts/runqemu +0
-0
scripts/runqemu to your build configuration. · line 1011
Quoted 8 lines
scripts/runqemu +1
-1@@ -1005,7 +1005,7 @@ to your build configuration. # If the STAGING_BINDIR_NATIVE directories from the config file don't exist # and we're in a sourced OE build directory try to extract the paths # from `bitbake -e` - havenative = os.path.exists(os.path.exists(self.get('STAGING_BINDIR_NATIVE'))) + havenative = os.path.exists(self.get('STAGING_BINDIR_NATIVE')) if not havenative: if not self.bitbake_e:
Hi,
The commit title contains "fixup!", please could you re-send with a proper title for this patch?
Best regards,
Signature · 1 line
Paul Barker
Quoted 25 lines · Paul Barker
Quoted 23 lines · Chen Qi via lists.openembedded.org
From: Chen Qi <[email protected]>
In previous patch[1], the os.path.exists was accidently called twice. This is incorrect.
[1] https://git.openembedded.org/openembedded-core/commit/?id=972155bbee02dd8061fee9c07a40f8e9034b9a3c
Signed-off-by Chen Qi <[email protected]>--- scripts/runqemu | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)scripts/runqemu +1
-1@@ -1005,7 +1005,7 @@ to your build configuration. # If the STAGING_BINDIR_NATIVE directories from the config file don't exist # and we're in a sourced OE build directory try to extract the paths # from `bitbake -e` - havenative = os.path.exists(os.path.exists(self.get('STAGING_BINDIR_NATIVE'))) + havenative = os.path.exists(self.get('STAGING_BINDIR_NATIVE'))
Quoted 9 lines
scripts/runqemu to your build configuration. · line 1011
Quoted 2 lines
scripts/runqemu +0
-0if not havenative: if not self.bitbake_e:Hi,
The commit title contains "fixup!", please could you re-send with a proper title for this patch?
Best regards,
Got it. I'll send out V2 with another title.
Regards,
Qi
PATCH v2 1/1 runqemu: fix the checking of STAGING_BINDIR_NATIVE
In reply to [email protected]From: Chen Qi <[email protected]>
In previous patch[1], the os.path.exists was accidently called twice. This is incorrect.
[1] https://git.openembedded.org/openembedded-core/commit/?id=972155bbee02dd8061fee9c07a40f8e9034b9a3c
--- scripts/runqemu | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/runqemu +1 -1
@@ -1004,7 +1004,7 @@ to your build configuration. # If the STAGING_BINDIR_NATIVE directories from the config file don't exist # and we're in a sourced OE build directory try to extract the paths # from `bitbake -e` - havenative = os.path.exists(os.path.exists(self.get('STAGING_BINDIR_NATIVE'))) + havenative = os.path.exists(self.get('STAGING_BINDIR_NATIVE')) if not havenative: if not self.bitbake_e:
Signature · 1 line
2.49.0