media: staging: ipu3: img-mmu: fix sign-to-unsigned conversion
Subsystems (3)
PATCH v2 1/1 media: staging: ipu3: img-mmu: fix sign-to-unsigned conversion
imgu_mmu_unmap() returns size_t (unsigned), representing the number of bytes successfully unmapped. However, when the alignment check fails, it currently returns -EINVAL.
On 64-bit systems, this negative error code is implicitly converted to a very large unsigned value (18446744073709551594). The same happens on 32-bit systems as well, although the resulting value is smaller.
Return 0 when the alignment check fails to correctly indicate that no bytes were unmapped while resolving the following -Wsign-conversion warning:
drivers/staging/media/ipu3/ipu3-mmu.c:393:24: warning: unsigned conversion from 'int' to 'size_t' {aka 'long unsigned int'} changes value from '-22' to '18446744073709551594' [-Wsign-conversion]
393 | return -EINVAL;
All callers ignore the return value, so this change does not affect existing behavior.
--- drivers/staging/media/ipu3/ipu3-mmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/media/ipu3/ipu3-mmu.c +1 -1
@@ -390,7 +390,7 @@ size_t imgu_mmu_unmap(struct imgu_mmu_info *info, unsigned long iova,if (!IS_ALIGNED (iova | size,IPU3_PAGE_SIZE )) {dev_err (mmu->dev,"unaligned: iova 0x%lx size 0x%zx\n" , iova, size); -return -EINVAL ; +return 0 ; }dev_dbg (mmu->dev,"unmap this: iova 0x%lx size 0x%zx\n" , iova, size);
Signature · 1 line
2.51.0