Skip to contentSkip to conversation

net: b44: always select CONFIG_FIXED_PHY

PATCH Applied Arnd Bergmann 2 participants 2 messages Mar 20 – Mar 24

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Arnd Bergmann

author
#0 lore raw

PATCH 1/1 net: b44: always select CONFIG_FIXED_PHY

From: Arnd Bergmann <[email protected]>

When CONFIG_FIXED_PHY=m but CONFIG_B44=y, the kernel fails to link:

ld.lld: error: undefined symbol: fixed_phy_unregister

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

referenced by b44.c
drivers/net/ethernet/broadcom/b44.o:(b44_remove_one) in archive vmlinux.a

ld.lld: error: undefined symbol: fixed_phy_register_100fd

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

referenced by b44.c
drivers/net/ethernet/broadcom/b44.o:(b44_register_phy_one) in archive vmlinux.a

The fixed phy support is small enough that just always enabling it for b44 is the simplest solution, and it avoids adding ugly #ifdef checks.

Fixes 10d2f15afba2 ("net: b44: register a fixed phy using fixed_phy_register_100fd if needed")
Signed-off-by Arnd Bergmann <[email protected]>
---
 drivers/net/ethernet/broadcom/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/broadcom/Kconfig +1 -1
index a8021008eb51..35d68dd99086 100644
@@ -27,7 +27,7 @@ config B44
 	select SSB
 	select MII
 	select PHYLIB
-	select FIXED_PHY if BCM47XX
+	select FIXED_PHY
 	help
 	  If you have a network (Ethernet) controller of this type, say Y
 	  or M here.
Signature · 1 line
2.39.5
CI Applied
#1 lore raw
This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:

Quoted 9 lines · On Fri, 20 Mar 2026 16:49:19 +0100 you wrote:

From: Arnd Bergmann <[email protected]>

When CONFIG_FIXED_PHY=m but CONFIG_B44=y, the kernel fails to link:

ld.lld: error: undefined symbol: fixed_phy_unregister

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

referenced by b44.c
drivers/net/ethernet/broadcom/b44.o:(b44_remove_one) in archive vmlinux.a

[...]

Here is the summary with links:
- net: b44: always select CONFIG_FIXED_PHY

    https://git.kernel.org/netdev/net/c/3f0f591b44b0

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html