pwm: jz4740: Drop unused include
Subsystems (3)
PATCH 1/1 pwm: jz4740: Drop unused include
This driver includes the legacy header <linux/gpio.h> but does not use any symbols from it. Drop the inclusion.
--- drivers/pwm/pwm-jz4740.c | 1 - 1 file changed, 1 deletion(-)
drivers/pwm/pwm-jz4740.c +0 -1
@@ -10,7 +10,6 @@#include <linux/clk.h> #include <linux/err.h> -#include <linux/gpio.h> #include <linux/kernel.h> #include <linux/mfd/ingenic-tcu.h> #include <linux/mfd/syscon.h>
Signature · 1 line
2.50.1
Quoted 2 lines · Andy Shevchenko
This driver includes the legacy header <
linux/gpio.h> but does not use any symbols from it. Drop the inclusion.
Sorry, this is just a 1:1 copy of the previous message sent by a mistake. Use whatever you want, though, they are absolutely identical (body wise).
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 6 lines · Andy Shevchenko
Quoted 2 lines · Andy Shevchenko
This driver includes the legacy header <
linux/gpio.h> but does not use any symbols from it. Drop the inclusion.Sorry, this is just a 1:1 copy of the previous message sent by a mistake. Use whatever you want, though, they are absolutely identical (body wise).
Uwe, can this be applied?
Signature · 2 lines
With Best Regards, Andy Shevchenko
Uwe Kleine-König
maintainerHello Andy,
Quoted 9 lines · Andy Shevchenko
Quoted 6 lines · Andy Shevchenko
Quoted 2 lines · Andy Shevchenko
This driver includes the legacy header <
linux/gpio.h> but does not use any symbols from it. Drop the inclusion.Sorry, this is just a 1:1 copy of the previous message sent by a mistake. Use whatever you want, though, they are absolutely identical (body wise).
Uwe, can this be applied?
No it cannot:
$ git checkout pwm/for-next ...
$ b4 am ...
$ git am ./20260320_andriy_shevchenko_pwm_jz4740_drop_unused_include.mbx Applying: pwm: jz4740: Drop unused include error: patch failed: drivers/pwm/pwm-jz4740.c:10 error: drivers/pwm/pwm-jz4740.c: patch does not apply Patch failed at 0001 pwm: jz4740: Drop unused include hint: Use 'git am --show-current-patch=diff' to see the failed patch hint: When you have resolved this problem, run "git am --continue". hint: If you prefer to skip this patch, run "git am --skip" instead. hint: To restore the original branch and stop patching, run "git am --abort". hint: Disable this message with "git config advice.mergeConflict false"
That is because I applied the patch from the other thread :-D It's commit 8ab1fc910415 ("pwm: jz4740: Drop unused include") and already landed in Linus' tree.
Best regards
Uwe
Quoted 29 lines · Uwe Kleine-König
Quoted 9 lines · Andy Shevchenko
Quoted 6 lines · Andy Shevchenko
Quoted 2 lines · Andy Shevchenko
This driver includes the legacy header <
linux/gpio.h> but does not use any symbols from it. Drop the inclusion.Sorry, this is just a 1:1 copy of the previous message sent by a mistake. Use whatever you want, though, they are absolutely identical (body wise).
Uwe, can this be applied?
No it cannot:
$ git checkout pwm/for-next ...$ b4 am ...$ git am ./20260320_andriy_shevchenko_pwm_jz4740_drop_unused_include.mbx Applying: pwm: jz4740: Drop unused include error: patch failed: drivers/pwm/pwm-jz4740.c:10 error: drivers/pwm/pwm-jz4740.c: patch does not apply Patch failed at 0001 pwm: jz4740: Drop unused include hint: Use 'git am --show-current-patch=diff' to see the failed patch hint: When you have resolved this problem, run "git am --continue". hint: If you prefer to skip this patch, run "git am --skip" instead. hint: To restore the original branch and stop patching, run "git am --abort". hint: Disable this message with "git config advice.mergeConflict false"
Quoted 3 lines
That is because I applied the patch from the other thread :-D It's commit
8ab1fc910415("pwm: jz4740: Drop unused include") and already landed in Linus' tree.
I see, thanks for pointing this out, seems like an outdated email in my pending mailbox. And thanks for applying that!
Signature · 2 lines
With Best Regards, Andy Shevchenko