Skip to contentSkip to conversation

ASoC: dt-bindings: stm32: Fix incorrect compatible string in stm32h7-sai match

PATCH In review Jihed Chaibi 3 participants 5 messages Mar 21 – Mar 24

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: dt-bindings: stm32: Fix incorrect compatible string in stm32h7-sai match

The conditional block that defines clock constraints for the stm32h7-sai variant references "st,stm32mph7-sai", which does not match any compatible string in the enum. As a result, clock validation for the h7 variant is silently skipped. Correct the compatible string to "st,stm32h7-sai".

Fixes 8509bb1f11a1f ("ASoC: dt-bindings: add stm32mp25 support for sai")
---
 Documentation/devicetree/bindings/sound/st,stm32-sai.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/sound/st,stm32-sai.yaml +1 -1
index 4a7129d0b157..551edf39e766 100644
@@ -164,7 +164,7 @@ allOf:
       properties:
         compatible:
           contains:
-            const: st,stm32mph7-sai
+            const: st,stm32h7-sai
     then:
       properties:
         clocks:
Signature · 1 line
2.47.3
maintainer
#1 lore raw
Quoted 4 lines · Jihed Chaibi

The conditional block that defines clock constraints for the stm32h7-sai variant references "st,stm32mph7-sai", which does not match any compatible string in the enum. As a result, clock validation for the h7 variant is silently skipped. Correct the compatible string to "st,stm32h7-sai".

A web search for stm32mph7 appears to show stm32h7 as the correct part number... ST people, any confirmation here? Are both valid?

maintainer
#2 lore raw

Hi,

Quoted 8 lines · Mark Brown
Quoted 4 lines · Jihed Chaibi

The conditional block that defines clock constraints for the stm32h7-sai variant references "st,stm32mph7-sai", which does not match any compatible string in the enum. As a result, clock validation for the h7 variant is silently skipped. Correct the compatible string to "st,stm32h7-sai".

A web search for stm32mph7 appears to show stm32h7 as the correct part number... ST people, any confirmation here? Are both valid?

The right part number is "st,stm32h7-sai" only.
So, the fix is valid. Thanks for it.

BRs
Olivier

maintainer Reviewed-by on v1 1/1
#3 lore raw
In reply to Jihed Chaibi

Hi,

Quoted 16 lines · Jihed Chaibi

The conditional block that defines clock constraints for the stm32h7-sai variant references "st,stm32mph7-sai", which does not match any compatible string in the enum. As a result, clock validation for the h7 variant is silently skipped. Correct the compatible string to "st,stm32h7-sai".

Fixes 8509bb1f11a1f ("ASoC: dt-bindings: add stm32mp25 support for sai")
---
  Documentation/devicetree/bindings/sound/st,stm32-sai.yaml | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/sound/st,stm32-sai.yaml +0 -0
index 4a7129d0b157..551edf39e766 100644

Documentation/devicetree/bindings/sound/st,stm32-sai.yaml allOf: · line 170

Quoted 8 lines
Documentation/devicetree/bindings/sound/st,stm32-sai.yaml +1 -1
@@ -164,7 +164,7 @@ allOf:
        properties:
          compatible:
            contains:
-            const: st,stm32mph7-sai
+            const: st,stm32h7-sai
      then:
        properties:
          clocks:

Thanks

maintainer
#4 lore raw
In reply to Jihed Chaibi
Quoted 1 line · Jihed Chaibi

ASoC: dt-bindings: stm32: Fix incorrect compatible string in stm32h7-sai match

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.0

Thanks!

[1/1] ASoC: dt-bindings: stm32: Fix incorrect compatible string in stm32h7-sai match

      https://git.kernel.org/broonie/sound/c/91049ec2e183

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark