mm/zsmalloc: copy KMSAN metadata in zs_page_migrate()
Subsystems (2)
PATCH 1/1 mm/zsmalloc: copy KMSAN metadata in zs_page_migrate()
zs_page_migrate() uses copy_page() to copy the contents of a zspage page during migration. However, copy_page() is not instrumented by KMSAN, so the shadow and origin metadata of the destination page are not updated.
As a result, subsequent accesses to the migrated page are reported as use-after-free by KMSAN, despite the data being correctly copied.
Add a kmsan_copy_page_meta() call after copy_page() to propagate the KMSAN metadata to the new page, matching what copy_highpage() does internally.
--- mm/zsmalloc.c | 1 + 1 file changed, 1 insertion(+)
mm/zsmalloc.c +1 -0
@@ -1741,6 +1741,7 @@ static int zs_page_migrate(struct page *newpage, struct page *page,*/ d_addr =kmap_local_zpdesc (newzpdesc);copy_page (d_addr, s_addr); +kmsan_copy_page_meta (zpdesc_page (newzpdesc),zpdesc_page (zpdesc));kunmap_local (d_addr); for (addr = s_addr + offset; addr < s_addr + PAGE_SIZE;
Signature · 1 line
2.52.0
Andrew Morton
maintainerQuoted 5 lines · On Sat, 21 Mar 2026 22:29:11 +0900 Shigeru Yoshida <[email protected]> wrote:
zs_page_migrate()usescopy_page()to copy the contents of a zspage page during migration. However,copy_page()is not instrumented by KMSAN, so the shadow and origin metadata of the destination page are not updated.
Quoted 8 lines
As a result, subsequent accesses to the migrated page are reported as use-after-free by KMSAN, despite the data being correctly copied.
Add a
kmsan_copy_page_meta()call aftercopy_page()to propagate the KMSAN metadata to the new page, matching whatcopy_highpage()does internally.Fixes afb2d666d025 ("zsmalloc: use copy_page for full page copy")
That's three years old. Can anyone suggest why this has only now been discovered?
mm/zsmalloc.c static int zs_page_migrate(struct page *newpage, struct page *page, · line 1747
Quoted 13 lines
...
mm/zsmalloc.c +1
-0@@ -1741,6 +1741,7 @@ static int zs_page_migrate(struct page *newpage, struct page *page,*/ d_addr =kmap_local_zpdesc (newzpdesc);copy_page (d_addr, s_addr); +kmsan_copy_page_meta (zpdesc_page (newzpdesc),zpdesc_page (zpdesc));kunmap_local (d_addr); for (addr = s_addr + offset; addr < s_addr + PAGE_SIZE;
I assume we'll want a cc:stable on this.
Quoted 10 lines · Andrew Morton
Quoted 8 lines · On Sat, 21 Mar 2026 22:29:11 +0900 Shigeru Yoshida <[email protected]> wrote:
zs_page_migrate()usescopy_page()to copy the contents of a zspage page during migration. However,copy_page()is not instrumented by KMSAN, so the shadow and origin metadata of the destination page are not updated.As a result, subsequent accesses to the migrated page are reported as use-after-free by KMSAN, despite the data being correctly copied.
Quoted 8 lines
Quoted 5 lines
Add a
kmsan_copy_page_meta()call aftercopy_page()to propagate the KMSAN metadata to the new page, matching whatcopy_highpage()does internally.Fixes afb2d666d025 ("zsmalloc: use copy_page for full page copy")That's three years old. Can anyone suggest why this has only now been discovered?
I think it's because KMSAN is clang and x86-64-only, so very few people run it. Also, this only triggers when compaction actually migrates a zspage page, which needs significant memory pressure.
Shigeru