arm64: dts: qcom: Add support for the Nothing Phone (3a)
v2 cover arm64: dts: qcom: Add support for the Nothing Phone (3a)
This series adds initial support for the Nothing Phone (3a) smartphone, which is based on the on the Milos/SM7635 SoC.
---
Changes in v2:
- Add comment to rmtfs_mem override in milos-fairphone-fp6
- Add missing stdout-path for debug UART in &chosen {}
- Drop dr_mode from usb_1 as it is the default
- Link to v1: https://lore.kernel.org/r/[email protected]
---
Alexander Koskovich (3):
arm64: dts: qcom: milos: Reduce rmtfs_mem size to 2.5MiB
dt-bindings: arm: qcom: Add the Nothing Phone (3a)
arm64: dts: qcom: Add the Nothing Phone (3a)
Documentation/devicetree/bindings/arm/qcom.yaml | 1 + arch/arm64/boot/dts/qcom/Makefile | 1 + arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts | 5 + .../boot/dts/qcom/milos-nothing-asteroids.dts | 964 +++++++++++++++++++++ arch/arm64/boot/dts/qcom/milos.dtsi | 2 +- 5 files changed, 972 insertions(+), 1 deletion(-)
---
base-commit: f338e77383789c0cae23ca3d48adcc5e9e137e3c
change-id: 20260321-asteroids-58f7d0bf56f0
Best regards,
Signature · 1 line
Alexander Koskovich <[email protected]>
PATCH v2 1/3 arm64: dts: qcom: milos: Reduce rmtfs_mem size to 2.5MiB
The rmtfs_mem region is currently sized at 6MiB but the default for milos downstream is 2.5MiB. This causes remoteproc crashes on devices that expect the smaller size:
modem_ac.c:281:Access Control Error: Could not protect the region specified:Start:e1f00000 End:e2180000, PID:1
Reduce the default to 2.5MiB to match the QCOM downstream config, and override the size for FP6.
--- arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts | 5 +++++ arch/arm64/boot/dts/qcom/milos.dtsi | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-)
arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts +5 -0
@@ -724,6 +724,11 @@ &remoteproc_wpss { status = "okay"; }; +&rmtfs_mem { + /* Increase the size from 2.5 MiB to 6 MiB */ + reg = <0x0 0xe1f00000 0x0 0x600000>; +}; + &sdhc_2 { cd-gpios = <&tlmm 65 GPIO_ACTIVE_HIGH>;
arch/arm64/boot/dts/qcom/milos.dtsi +1 -1
@@ -640,7 +640,7 @@ cpusys_vm_mem: cpusys-vm-region@e0600000 { rmtfs_mem: rmtfs@e1f00000 { compatible = "qcom,rmtfs-mem"; - reg = <0x0 0xe1f00000 0x0 0x600000>; + reg = <0x0 0xe1f00000 0x0 0x280000>; no-map; qcom,client-id = <1>;
Signature · 1 line
2.53.0
PATCH v2 2/3 dt-bindings: arm: qcom: Add the Nothing Phone (3a)
In reply to Alexander KoskovichDocument the Milos-based Nothing Phone (3a) smartphone.
--- Documentation/devicetree/bindings/arm/qcom.yaml | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/qcom.yaml +1 -0
@@ -64,6 +64,7 @@ properties: - items: - enum: - fairphone,fp6 + - nothing,asteroids - const: qcom,milos - items:
Signature · 1 line
2.53.0
PATCH v2 3/3 arm64: dts: qcom: Add the Nothing Phone (3a)
In reply to Alexander KoskovichAdd a devicetree for the Nothing Phone (3a) smartphone, which is based on the Milos/SM7635 SoC.
Supported functionality as of this initial submission:
* Camera flash/torch LED
* Debug UART
* Glyph LEDs (AW20036)
* PMIC-GLINK (Charger, Fuel gauge, USB-C mode switching)
* Assistant Key, Power Button, Volume Keys
* Regulators (PM7550, PM8550VS, PMR735B)
* Remoteprocs (ADSP, CDSP, MPSS, WPSS)
* USB (USB2 + FSA4480)
--- arch/arm64/boot/dts/qcom/Makefile | 1 + .../boot/dts/qcom/milos-nothing-asteroids.dts | 964 +++++++++++++++++++++ 2 files changed, 965 insertions(+)
arch/arm64/boot/dts/qcom/Makefile +1 -0
@@ -44,6 +44,7 @@ lemans-evk-el2-dtbs := lemans-evk.dtb lemans-el2.dtbo dtb-$(CONFIG_ARCH_QCOM) += lemans-evk-el2.dtb dtb-$(CONFIG_ARCH_QCOM) += milos-fairphone-fp6.dtb +dtb-$(CONFIG_ARCH_QCOM) += milos-nothing-asteroids.dtb dtb-$(CONFIG_ARCH_QCOM) += monaco-evk.dtb dtb-$(CONFIG_ARCH_QCOM) += msm8216-samsung-fortuna3g.dtb dtb-$(CONFIG_ARCH_QCOM) += msm8916-acer-a1-724.dtb
arch/arm64/boot/dts/qcom/milos-nothing-asteroids.dts new file +964 -0
964 lines not on this page · raw message
Signature · 1 line
2.53.0
Rob Herring
maintainerRe: [PATCH v2 3/3] arm64: dts: qcom: Add the Nothing Phone (3a)
Quoted 76 lines · Alexander Koskovich
Add a devicetree for the Nothing Phone (3a) smartphone, which is based on the Milos/SM7635 SoC.
Supported functionality as of this initial submission:
* Camera flash/torch LED
* Debug UART
* Glyph LEDs (AW20036)
* PMIC-GLINK (Charger, Fuel gauge, USB-C mode switching)
* Assistant Key, Power Button, Volume Keys
* Regulators (PM7550, PM8550VS, PMR735B)
* Remoteprocs (ADSP, CDSP, MPSS, WPSS)
* USB (USB2 + FSA4480)Reviewed-by Konrad Dybcio <[email protected]>Signed-off-by Alexander Koskovich <[email protected]>--- arch/arm64/boot/dts/qcom/Makefile | 1 + .../boot/dts/qcom/milos-nothing-asteroids.dts | 964 +++++++++++++++++++++ 2 files changed, 965 insertions(+)arch/arm64/boot/dts/qcom/Makefile +1
-0@@ -44,6 +44,7 @@ lemans-evk-el2-dtbs := lemans-evk.dtb lemans-el2.dtbo dtb-$(CONFIG_ARCH_QCOM) += lemans-evk-el2.dtb dtb-$(CONFIG_ARCH_QCOM) += milos-fairphone-fp6.dtb +dtb-$(CONFIG_ARCH_QCOM) += milos-nothing-asteroids.dtb dtb-$(CONFIG_ARCH_QCOM) += monaco-evk.dtb dtb-$(CONFIG_ARCH_QCOM) += msm8216-samsung-fortuna3g.dtb dtb-$(CONFIG_ARCH_QCOM) += msm8916-acer-a1-724.dtbarch/arm64/boot/dts/qcom/milos-nothing-asteroids.dts new file +38
-0@@ -0,0 +1,964 @@ +// SPDX-License-Identifier: BSD-3-Clause + +/dts-v1/; + +#define PMIV0104_SID 7 + +#include <dt-bindings/leds/common.h> +#include <dt-bindings/pinctrl/qcom,pmic-gpio.h> +#include <dt-bindings/regulator/qcom,rpmh-regulator.h> + +#include "milos.dtsi" +#include "pm7550.dtsi" +#include "pm8550vs.dtsi" +#include "pmiv0104.dtsi" /* PMIV0102 */ +#include "pmk8550.dtsi" /* PMK7635 */ +#include "pmr735b.dtsi" + +/ { + model = "Nothing Phone (3a)"; + compatible = "nothing,asteroids", "qcom,milos"; + chassis-type = "handset"; + + aliases { + serial0 = &uart5; + }; + + chosen { + #address-cells = <2>; + #size-cells = <2>; + ranges; + + stdout-path = "serial0:115200n8"; + + framebuffer0: framebuffer@e3940000 { + compatible = "simple-framebuffer"; + reg = <0x0 0xe3940000 0x0 (2392 * 1080 * 4)>; + width = <1080>; + height = <2392>;
arch/arm64/boot/dts/qcom/milos-nothing-asteroids.dts line 48
Quoted 10 lines
arch/arm64/boot/dts/qcom/milos-nothing-asteroids.dts new file +10
-0+ stride = <(1080 * 4)>; + format = "a8r8g8b8"; + panel = <&panel>; + interconnects = <&mmss_noc MASTER_MDP QCOM_ICC_TAG_ALWAYS + &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>; + clocks = <&gcc GCC_DISP_HF_AXI_CLK>; + + /* Dummy panel for simple-framebuffer dimension info */ + panel: dummy-panel { + compatible = "boe,bf068mwm-td0";
This is missing documentation and gives a warning. However, having a panel node here is not valid. Either define a complete panel node or none at all. That should throw a warning as well.
Please send fixes for this and any other warnings you didn't check or ignored.
arch/arm64/boot/dts/qcom/milos-nothing-asteroids.dts line 53
Quoted 5 lines
arch/arm64/boot/dts/qcom/milos-nothing-asteroids.dts new file +5
-0+ height-mm = <157>; + width-mm = <71>; + }; + }; + };
Rob
Re: [PATCH v2 3/3] arm64: dts: qcom: Add the Nothing Phone (3a)
Quoted 11 lines · Rob Herring
arch/arm64/boot/dts/qcom/milos-nothing-asteroids.dts line 48
Quoted 2 lines · Alexander Koskovich
arch/arm64/boot/dts/qcom/milos-nothing-asteroids.dts new file +2
-0+ panel: dummy-panel { + compatible = "boe,bf068mwm-td0";This is missing documentation and gives a warning. However, having a panel node here is not valid. Either define a complete panel node or none at all. That should throw a warning as well.
Please send fixes for this and any other warnings you didn't check or ignored.
Sent a change here, though realize I forgot to add 'Fixes:' to it:
https://lore.kernel.org/linux-arm-msm/[email protected]/
Thanks,
Alex
Quoted 4 lines · Alexander Koskovich
This series adds initial support for the Nothing Phone (3a) smartphone, which is based on the on the Milos/SM7635 SoC.
Applied, thanks!
[1/3] arm64: dts: qcom: milos: Reduce rmtfs_mem size to 2.5MiB
commit: 1f820571ca7c64d3fd5bd9bf653b571cb3350703
[2/3] dt-bindings: arm: qcom: Add the Nothing Phone (3a)
commit: 93be926a7f6dc89657d3e8488f353893841039ce
[3/3] arm64: dts: qcom: Add the Nothing Phone (3a)
commit: edbf03c9fb5ff72f8e7974b35f7ee2d9ae7cb371Best regards,
Signature · 1 line
Bjorn Andersson <[email protected]>