btrfs: check remap-tree flags in btrfs_check_chunk_valid()
PATCH 1/1 btrfs: check remap-tree flags in btrfs_check_chunk_valid()
Add a check to btrfs_check_chunk_valid() that the METADATA_REMAP and REMAPPED flags are only set if the REMAP_TREE incompat flag is also set.
Signed-off-by Mark Harmstone <[email protected]>
--- fs/btrfs/tree-checker.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+)
fs/btrfs/tree-checker.c +14 -0
@@ -999,6 +999,20 @@ int btrfs_check_chunk_valid(const struct btrfs_fs_info *fs_info, } } +if (unlikely ((type &BTRFS_BLOCK_GROUP_METADATA_REMAP ) && + !(features &BTRFS_FEATURE_INCOMPAT_REMAP_TREE ))) { +chunk_err (fs_info, leaf, chunk, logical, +"METADATA_REMAP chunk type without REMAP_TREE incompat bit" ); +return -EUCLEAN ; + } + +if (unlikely (remapped && + !(features &BTRFS_FEATURE_INCOMPAT_REMAP_TREE ))) { +chunk_err (fs_info, leaf, chunk, logical, +"REMAPPED chunk flag without REMAP_TREE incompat bit" ); +return -EUCLEAN ; + } +if (!remapped && !valid_stripe_count (type &BTRFS_BLOCK_GROUP_PROFILE_MASK , num_stripes, sub_stripes)) {
Signature · 1 line
2.52.0
Quoted 4 lines · Mark Harmstone
Add a check to
btrfs_check_chunk_valid()that theMETADATA_REMAPand REMAPPED flags are only set if theREMAP_TREEincompat flag is also set.Signed-off-by Mark Harmstone <[email protected]>
Reviewed-by David Sterba <[email protected]>