Skip to contentSkip to conversation

staging: atomisp: pci: remove leading whitespace at the start of the line

PATCH In review Anushka Badhe 3 participants 10 messages Mar 24 – Mar 26

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: atomisp: pci: remove leading whitespace at the start of the line

Removed the whitespace at the start of the line to comply with
linux kernel coding style.

---
 drivers/staging/media/atomisp/pci/system_local.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/media/atomisp/pci/system_local.c +1 -1
index a8a93760d5b1..3cf35678383f 100644
@@ -87,7 +87,7 @@ const hrt_address GP_DEVICE_BASE[N_GP_DEVICE_ID] = {
  * so, having multiple base addresses for
  * different timers does not help*/
 const hrt_address GP_TIMER_BASE =
-    (hrt_address)0x0000000000000600ULL;
+	(hrt_address)0x0000000000000600ULL;
 
 /* GPIO */
 const hrt_address GPIO_BASE[N_GPIO_ID] = {
Signature · 1 line
2.43.0
#1 lore raw
Quoted 2 lines · Anushka Badhe

Removed the whitespace at the start of the line to comply with
linux kernel coding style.

Linux

...

drivers/staging/media/atomisp/pci/system_local.c const hrt_address GP_DEVICE_BASE[N_GP_DEVICE_ID] = { · line 90

Quoted 3 lines

const hrt_address GP_TIMER_BASE =

drivers/staging/media/atomisp/pci/system_local.c +1 -1
-    (hrt_address)0x0000000000000600ULL;
+	(hrt_address)0x0000000000000600ULL;

Always think one or even two steps further. How does your patch add value? For now it's just a warning of a tool or even no warning, just some whitespace shuffling, which is usually the type of patches that are doomed to be ceased.

Compare to

const hrt_address GP_TIMER_BASE = (hrt_address)0x0000000000000600ULL;

which gives the same result + reduces number of LoC for free. This increases the value of the change. Now, you can look at the rest of the code for the indentation problems.

BUT, they are so-o-o-o LOW priority thing, that most likely will be simply NAKed. Can you rather do a real patch instead, please?

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#2 lore raw
Quoted 5 lines · Andy Shevchenko
Quoted 2 lines · Anushka Badhe

Removed the whitespace at the start of the line to comply with
linux kernel coding style.

Linux

Also note, while fixing the above mentioned problem in the code, the commit message suffers from the same issue.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#3 lore raw

PATCH v2 1/1 staging: atomisp: pci: fix block comment style and merge split declaration

---
Changes in v2:
- Fix block comment style (move closing */ to its own line)
- Merge split GP_TIMER_BASE declaration onto a single line

Checked the rest of the file for similar issues; no others found.

Thank you so much for your guidance on improving the patch.

 drivers/staging/media/atomisp/pci/system_local.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/media/atomisp/pci/system_local.c +3 -3
index a8a93760d5b1..1c513ead5300 100644
@@ -85,9 +85,9 @@ const hrt_address GP_DEVICE_BASE[N_GP_DEVICE_ID] = {
 
 /*GP TIMER , all timer registers are inter-twined,
  * so, having multiple base addresses for
- * different timers does not help*/
-const hrt_address GP_TIMER_BASE =
-    (hrt_address)0x0000000000000600ULL;
+ * different timers does not help
+ */
+const hrt_address GP_TIMER_BASE = (hrt_address)0x0000000000000600ULL;
 
 /* GPIO */
 const hrt_address GPIO_BASE[N_GPIO_ID] = {
Signature · 1 line
2.43.0
#4 lore raw

PATCH v3 1/1 staging: media: atomisp: pci: fix block comment style and merge split declaration

The closing */ of a block comment is on the same line as the comment text, violating kernel coding style. GP_TIMER_BASE declaration is also unnecessarily split across two lines. Fix both issues.

---
Changes in v3:
- Add commit description
- Fix subject prefix to staging: media: atomisp:

Changes in v2:
- Fix block comment style (move closing */ to its own line)
- Merge split GP_TIMER_BASE declaration onto a single line

Checked the rest of the file for similar issues; no others found.

 drivers/staging/media/atomisp/pci/system_local.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/media/atomisp/pci/system_local.c +3 -3
index a8a93760d5b1..1c513ead5300 100644
@@ -85,9 +85,9 @@ const hrt_address GP_DEVICE_BASE[N_GP_DEVICE_ID] = {
 
 /*GP TIMER , all timer registers are inter-twined,
  * so, having multiple base addresses for
- * different timers does not help*/
-const hrt_address GP_TIMER_BASE =
-    (hrt_address)0x0000000000000600ULL;
+ * different timers does not help
+ */
+const hrt_address GP_TIMER_BASE = (hrt_address)0x0000000000000600ULL;
 
 /* GPIO */
 const hrt_address GPIO_BASE[N_GPIO_ID] = {
Signature · 1 line
2.43.0
#5 lore raw

Re: [PATCH v3] staging: media: atomisp: pci: fix block comment style and merge split declaration

Quoted 3 lines · Anushka Badhe

The closing */ of a block comment is on the same line as the comment text, violating kernel coding style. GP_TIMER_BASE declaration is also unnecessarily split across two lines. Fix both issues.

You are doing two things in one change. And doing first half-way... NAK.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#6 lore raw

PATCH v4 1/1 staging: media: atomisp: pci: fix split GP_TIMER_BASE declaration

Merge declaration of const GP_TIMER_BASE split across 2 lines to improve readability.

---
Thank you so much for your review and guidance.

Changes in v4:
- Remove unrelated block comment style fixes

Changes in v3:
- Add commit description
- Fix subject prefix to staging: media: atomisp:

Changes in v2:
- Fix block comment style (move closing */ to its own line)
- Merge split GP_TIMER_BASE declaration onto a single line

Note:
* This patch is part of the GSoC2026 application process for device tree binding
s conversions
* https://github.com/LinuxFoundationGSoC/ProjectIdeas/wiki/GSoC-2026-Device-Tree-Bindings

 drivers/staging/media/atomisp/pci/system_local.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/media/atomisp/pci/system_local.c +1 -2
index a8a93760d5b1..69bcd557a821 100644
@@ -86,8 +86,7 @@ const hrt_address GP_DEVICE_BASE[N_GP_DEVICE_ID] = {
 /*GP TIMER , all timer registers are inter-twined,
  * so, having multiple base addresses for
  * different timers does not help*/
-const hrt_address GP_TIMER_BASE =
-    (hrt_address)0x0000000000000600ULL;
+const hrt_address GP_TIMER_BASE = (hrt_address)0x0000000000000600ULL;
 
 /* GPIO */
 const hrt_address GPIO_BASE[N_GPIO_ID] = {
Signature · 1 line
2.43.0
#7 lore raw

Re: [PATCH v4] staging: media: atomisp: pci: fix split GP_TIMER_BASE declaration

Quoted 2 lines · Anushka Badhe

Merge declaration of const GP_TIMER_BASE split across 2 lines to improve readability.

Nice, but this constant is only used in one file, id est gp_timer.c. Just move it there with the (fixed style of the) comment to there and drop the mentioning in the rest of the files. With this being done, the patch gains real value.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
maintainer
#8 lore raw

Re: [PATCH v2] staging: atomisp: pci: fix block comment style and merge split declaration

In reply to Anushka Badhe
Quoted 9 lines · Anushka Badhe

---
Changes in v2:
- Fix block comment style (move closing */ to its own line)
- Merge split GP_TIMER_BASE declaration onto a single line

Checked the rest of the file for similar issues; no others found.

Thank you so much for your guidance on improving the patch.

For obvious reasons, we can't take patches without any changelog text.

thanks,

greg k-h

author
#9 lore raw

Re: [PATCH v2] staging: atomisp: pci: fix block comment style and merge split declaration

Quoted 10 lines · Greg KH
Quoted 8 lines · Anushka Badhe

---
Changes in v2:
- Fix block comment style (move closing */ to its own line)
- Merge split GP_TIMER_BASE declaration onto a single line

Checked the rest of the file for similar issues; no others found.

Quoted 7 lines
Quoted 1 line

Thank you so much for your guidance on improving the patch.

For obvious reasons, we can't take patches without any changelog text.

thanks,

greg k-h

Thank you for your feedback - v3 fixes this issue with a proper changelog description.
https://lore.kernel.org/linux-media/[email protected]/#t