Skip to contentSkip to conversation

staging: rtl8723bs: fix logical continuations in xmit_linux.c

PATCH In review Sajal Gupta 2 participants 2 messages Mar 24 Staging

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 staging: rtl8723bs: fix logical continuations in xmit_linux.c

Simplify the conditional by removing redundant boolean comparisons and fixing the continuation line indentation.

---
Changes in v2:
- compact the condition
- drop == true and == 0 checks
- fix tab alignment

 drivers/staging/rtl8723bs/os_dep/xmit_linux.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)
drivers/staging/rtl8723bs/os_dep/xmit_linux.c +3 -6
index 0be3143fffe5..dc0b77f38b1a 100644
@@ -193,12 +193,9 @@ void _rtw_xmit_entry(struct sk_buff *pkt, struct net_device *pnetdev)
 
 	rtw_check_xmit_resource(padapter, pkt);
 
-	if (!rtw_mc2u_disable
-		&& check_fwstate(pmlmepriv, WIFI_AP_STATE) == true
-		&& (IP_MCAST_MAC(pkt->data)
-			|| ICMPV6_MCAST_MAC(pkt->data)
-			)
-		&& padapter->registrypriv.wifi_spec == 0) {
+	if (!rtw_mc2u_disable && check_fwstate(pmlmepriv, WIFI_AP_STATE) &&
+	    (IP_MCAST_MAC(pkt->data) || ICMPV6_MCAST_MAC(pkt->data)) &&
+	    !padapter->registrypriv.wifi_spec) {
 		if (pxmitpriv->free_xmitframe_cnt > (NR_XMITFRAME / 4)) {
 			res = rtw_mlcst2unicst(padapter, pkt);
 			if (res)

--
2.53.0

Reviewed-by on v2 1/1
#1 lore raw
Quoted 2 lines · Sajal Gupta

Simplify the conditional by removing redundant boolean comparisons and fixing the continuation line indentation.

In case maintainers are happy to take,

Signature · 2 lines
With Best Regards,
Andy Shevchenko