Skip to contentSkip to conversation

arm: mvebu: Drop unnecessary BOARD_EARLY_INIT_F usage

PATCH In review Tom Rini 3 participants 3 messages Mar 25 – Jun 10

lore
Share & tools
lore

Tom Rini

author
#0 lore raw

PATCH 1/1 arm: mvebu: Drop unnecessary BOARD_EARLY_INIT_F usage

All of these platforms enable CONFIG_BOARD_EARLY_INIT_F and then have a do-nothing board_early_init_f function. Change to not enabling the option and so not needing an empty function.

---
Cc: Stefan Roese <[email protected]>
Cc: Robert Marko <[email protected]>
Cc: Konstantin Porotchkin <[email protected]>
Cc: Ben Schneider <[email protected]>

---
 board/Marvell/mvebu_armada-37xx/board.c           | 5 -----
 configs/eDPU_defconfig                            | 1 -
 configs/mvebu_db-88f3720_defconfig                | 1 -
 configs/mvebu_espressobin-88f3720_defconfig       | 1 -
 configs/mvebu_espressobin_ultra-88f3720_defconfig | 1 -
 configs/uDPU_defconfig                            | 1 -
 6 files changed, 10 deletions(-)
board/Marvell/mvebu_armada-37xx/board.c +0 -5
index e44b713f96d7..c30fca6cffd8 100644
@@ -102,11 +102,6 @@ static bool is_edpu_plus(void)
 		return false;
 }
 
-int board_early_init_f(void)
-{
-	return 0;
-}
-
 int board_init(void)
 {
 	/* adress of boot parameters */
configs/eDPU_defconfig +0 -1
index 0b7815c78a30..98ba91aa568f 100644
@@ -23,7 +23,6 @@ CONFIG_SYS_PBSIZE=1048
 # CONFIG_DISPLAY_CPUINFO is not set
 # CONFIG_DISPLAY_BOARDINFO is not set
 CONFIG_DISPLAY_BOARDINFO_LATE=y
-CONFIG_BOARD_EARLY_INIT_F=y
 CONFIG_SYS_PROMPT="eDPU>> "
 CONFIG_SYS_MAXARGS=32
 # CONFIG_CMD_ELF is not set
configs/mvebu_db-88f3720_defconfig +0 -1
index 52ad18e4dd91..b7a2559997fe 100644
@@ -23,7 +23,6 @@ CONFIG_SYS_CONSOLE_INFO_QUIET=y
 # CONFIG_DISPLAY_CPUINFO is not set
 # CONFIG_DISPLAY_BOARDINFO is not set
 CONFIG_DISPLAY_BOARDINFO_LATE=y
-CONFIG_BOARD_EARLY_INIT_F=y
 CONFIG_SYS_MAXARGS=32
 CONFIG_CMD_FUSE=y
 CONFIG_CMD_GPIO=y
configs/mvebu_espressobin-88f3720_defconfig +0 -1
index af3bf1a04fce..c101b342980c 100644
@@ -25,7 +25,6 @@ CONFIG_SYS_CONSOLE_INFO_QUIET=y
 # CONFIG_DISPLAY_CPUINFO is not set
 # CONFIG_DISPLAY_BOARDINFO is not set
 CONFIG_DISPLAY_BOARDINFO_LATE=y
-CONFIG_BOARD_EARLY_INIT_F=y
 CONFIG_BOARD_LATE_INIT=y
 CONFIG_SYS_MAXARGS=32
 CONFIG_CMD_FUSE=y
configs/mvebu_espressobin_ultra-88f3720_defconfig +0 -1
index 69d6f7e34c3b..157bd9696425 100644
@@ -24,7 +24,6 @@ CONFIG_SYS_CONSOLE_INFO_QUIET=y
 # CONFIG_DISPLAY_CPUINFO is not set
 # CONFIG_DISPLAY_BOARDINFO is not set
 CONFIG_DISPLAY_BOARDINFO_LATE=y
-CONFIG_BOARD_EARLY_INIT_F=y
 CONFIG_BOARD_LATE_INIT=y
 CONFIG_SYS_MAXARGS=32
 CONFIG_CMD_FUSE=y
configs/uDPU_defconfig +0 -1
index 851d7bb2cb99..b819e978c3a5 100644
@@ -22,7 +22,6 @@ CONFIG_SYS_PBSIZE=1048
 # CONFIG_DISPLAY_CPUINFO is not set
 # CONFIG_DISPLAY_BOARDINFO is not set
 CONFIG_DISPLAY_BOARDINFO_LATE=y
-CONFIG_BOARD_EARLY_INIT_F=y
 CONFIG_SYS_PROMPT="uDPU>> "
 CONFIG_SYS_MAXARGS=32
 # CONFIG_CMD_ELF is not set
Signature · 1 line
2.43.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Tom Rini

All of these platforms enable CONFIG_BOARD_EARLY_INIT_F and then have a do-nothing board_early_init_f function. Change to not enabling the option and so not needing an empty function.

Quoted 93 lines

---
Cc: Stefan Roese <[email protected]>
Cc: Robert Marko <[email protected]>
Cc: Konstantin Porotchkin <[email protected]>
Cc: Ben Schneider <[email protected]>

---
 board/Marvell/mvebu_armada-37xx/board.c           | 5 -----
 configs/eDPU_defconfig                            | 1 -
 configs/mvebu_db-88f3720_defconfig                | 1 -
 configs/mvebu_espressobin-88f3720_defconfig       | 1 -
 configs/mvebu_espressobin_ultra-88f3720_defconfig | 1 -
 configs/uDPU_defconfig                            | 1 -
 6 files changed, 10 deletions(-)
board/Marvell/mvebu_armada-37xx/board.c +0 -5
index e44b713f96d7..c30fca6cffd8 100644
@@ -102,11 +102,6 @@ static bool is_edpu_plus(void)
                return false;
 }
 
-int board_early_init_f(void)
-{
-       return 0;
-}
-
 int board_init(void)
 {
        /* adress of boot parameters */
configs/eDPU_defconfig +0 -1
index 0b7815c78a30..98ba91aa568f 100644
@@ -23,7 +23,6 @@ CONFIG_SYS_PBSIZE=1048
 # CONFIG_DISPLAY_CPUINFO is not set
 # CONFIG_DISPLAY_BOARDINFO is not set
 CONFIG_DISPLAY_BOARDINFO_LATE=y
-CONFIG_BOARD_EARLY_INIT_F=y
 CONFIG_SYS_PROMPT="eDPU>> "
 CONFIG_SYS_MAXARGS=32
 # CONFIG_CMD_ELF is not set
configs/mvebu_db-88f3720_defconfig +0 -1
index 52ad18e4dd91..b7a2559997fe 100644
@@ -23,7 +23,6 @@ CONFIG_SYS_CONSOLE_INFO_QUIET=y
 # CONFIG_DISPLAY_CPUINFO is not set
 # CONFIG_DISPLAY_BOARDINFO is not set
 CONFIG_DISPLAY_BOARDINFO_LATE=y
-CONFIG_BOARD_EARLY_INIT_F=y
 CONFIG_SYS_MAXARGS=32
 CONFIG_CMD_FUSE=y
 CONFIG_CMD_GPIO=y
configs/mvebu_espressobin-88f3720_defconfig +0 -1
index af3bf1a04fce..c101b342980c 100644
@@ -25,7 +25,6 @@ CONFIG_SYS_CONSOLE_INFO_QUIET=y
 # CONFIG_DISPLAY_CPUINFO is not set
 # CONFIG_DISPLAY_BOARDINFO is not set
 CONFIG_DISPLAY_BOARDINFO_LATE=y
-CONFIG_BOARD_EARLY_INIT_F=y
 CONFIG_BOARD_LATE_INIT=y
 CONFIG_SYS_MAXARGS=32
 CONFIG_CMD_FUSE=y
configs/mvebu_espressobin_ultra-88f3720_defconfig +0 -1
index 69d6f7e34c3b..157bd9696425 100644
@@ -24,7 +24,6 @@ CONFIG_SYS_CONSOLE_INFO_QUIET=y
 # CONFIG_DISPLAY_CPUINFO is not set
 # CONFIG_DISPLAY_BOARDINFO is not set
 CONFIG_DISPLAY_BOARDINFO_LATE=y
-CONFIG_BOARD_EARLY_INIT_F=y
 CONFIG_BOARD_LATE_INIT=y
 CONFIG_SYS_MAXARGS=32
 CONFIG_CMD_FUSE=y
configs/uDPU_defconfig +0 -2
index 851d7bb2cb99..b819e978c3a5 100644
@@ -22,7 +22,6 @@ CONFIG_SYS_PBSIZE=1048
 # CONFIG_DISPLAY_CPUINFO is not set
 # CONFIG_DISPLAY_BOARDINFO is not set
 CONFIG_DISPLAY_BOARDINFO_LATE=y
-CONFIG_BOARD_EARLY_INIT_F=y
 CONFIG_SYS_PROMPT="uDPU>> "
 CONFIG_SYS_MAXARGS=32
 # CONFIG_CMD_ELF is not set
--

2.43.0

Signature · 7 lines
Robert Marko
Staff Embedded Linux Engineer
Sartura d.d.
Lendavska ulica 16a
10000 Zagreb, Croatia
Email: [email protected]
Web: www.sartura.hr
#2 lore raw
In reply to Tom Rini
Quoted 5 lines · Tom Rini

All of these platforms enable CONFIG_BOARD_EARLY_INIT_F and then have a do-nothing board_early_init_f function. Change to not enabling the option and so not needing an empty function.

Applied to u-boot-marvell/next

Thanks,
Stefan