perf symbol: Remove psw_idle() from list of idle symbols
Subsystems (2)
Ian Rogers
reviewerPATCH v10 4/18 perf capstone: Determine architecture from e_machine
In reply to Ian RogersAvoid the use of arch string that is imprecise and use the e_machine. Do more e_machine to capstone machine translations adding MIPS and RISCV. Remove unnecessary maybe_unused annotations.
--- tools/perf/util/capstone.c | 132 ++++++++++++++++++++++++------------- 1 file changed, 88 insertions(+), 44 deletions(-)
tools/perf/util/capstone.c +88 -44
@@ -1,7 +1,19 @@// SPDX-License-Identifier: GPL-2.0 #include "capstone.h" -#include "annotate.h" + +#include <errno.h> +#include <inttypes.h> +#include <string.h> + +#include <dlfcn.h> +#include <elf.h> +#include <fcntl.h> +#include <linux/ctype.h> + +#include <capstone/capstone.h> +#include "addr_location.h" +#include "annotate.h" #include "debug.h" #include "disasm.h" #include "dso.h"
@@ -11,13 +23,6 @@#include "print_insn.h" #include "symbol.h" #include "thread.h" -#include <dlfcn.h> -#include <errno.h> -#include <fcntl.h> -#include <inttypes.h> -#include <string.h> - -#include <capstone/capstone.h> #ifdef LIBCAPSTONE_DLOPEN static void *perf_cs_dll_handle (void )
@@ -137,37 +142,70 @@ static enum cs_err perf_cs_close(csh *handle)#endif } -static int capstone_init (struct machine *machine,csh *cs_handle,bool is64, +static bool e_machine_to_capstone (uint16_t e_machine,bool is64,bool is_big_endian, +enum cs_arch *arch,enum cs_mode *mode) +{ + *mode = is_big_endian ?CS_MODE_BIG_ENDIAN :CS_MODE_LITTLE_ENDIAN ; + +switch (e_machine) { +case EM_X86_64 : +case EM_386 : + *arch =CS_ARCH_X86 ; + *mode |= is64 ?CS_MODE_64 :CS_MODE_32 ; +return true; +case EM_AARCH64 : + *arch =CS_ARCH_ARM64 ; + *mode |=CS_MODE_ARM ; +return true; +case EM_ARM : + *arch =CS_ARCH_ARM ; + *mode |=CS_MODE_ARM |CS_MODE_V8 ; +return true; +case EM_S390 : + *arch =CS_ARCH_SYSZ ; +return true; +case EM_MIPS : + *arch =CS_ARCH_MIPS ; + *mode |= is64 ?CS_MODE_MIPS64 :CS_MODE_MIPS32 ; +return true; +case EM_PPC : + *arch =CS_ARCH_PPC ; +return true; +case EM_PPC64 : + *arch =CS_ARCH_PPC ; + *mode |=CS_MODE_64 ; +return true; +case EM_SPARC : + *arch =CS_ARCH_SPARC ; +return true; +case EM_SPARCV9 : + *arch =CS_ARCH_SPARC ; + *mode |=CS_MODE_V9 ; +return true; +case EM_RISCV : + *arch =CS_ARCH_RISCV ; + *mode |= is64 ?CS_MODE_RISCV64 :CS_MODE_RISCV32 ; +return true; +default : +return false; + } +} + +static int capstone_init (uint16_t e_machine,csh *cs_handle,bool is64,bool is_big_endian,bool disassembler_style) {enum cs_arch arch;enum cs_mode mode; -if (machine__is (machine,"x86_64" ) && is64) { - arch =CS_ARCH_X86 ; - mode =CS_MODE_64 ; - }else if (machine__normalized_is (machine,"x86" )) { - arch =CS_ARCH_X86 ; - mode =CS_MODE_32 ; - }else if (machine__normalized_is (machine,"arm64" )) { - arch =CS_ARCH_ARM64 ; - mode =CS_MODE_ARM ; - }else if (machine__normalized_is (machine,"arm" )) { - arch =CS_ARCH_ARM ; - mode =CS_MODE_ARM +CS_MODE_V8 ; - }else if (machine__normalized_is (machine,"s390" )) { - arch =CS_ARCH_SYSZ ; - mode =CS_MODE_BIG_ENDIAN ; - }else { +if (!e_machine_to_capstone (e_machine, is64, is_big_endian, &arch, &mode))return -1 ; - }if (perf_cs_open (arch, mode, cs_handle) !=CS_ERR_OK ) {pr_warning_once ("cs_open failed\n" );return -1 ; } -if (machine__normalized_is (machine,"x86" )) { +if (arch ==CS_ARCH_X86 ) {/* * In case of using capstone_init while symbol__disassemble * setting CS_OPT_SYNTAX_ATT depends if disassembler_style opts
@@ -211,29 +249,28 @@ static size_t print_insn_x86(struct thread *thread, u8 cpumode, struct cs_insn *return printed; } - -ssize_t capstone__fprintf_insn_asm (struct machine *machine__maybe_unused , -struct thread *thread__maybe_unused , -u8 cpumode__maybe_unused ,bool is64bit__maybe_unused , -const uint8_t *code__maybe_unused , -size_t code_size__maybe_unused , -uint64_t ip__maybe_unused ,int *lenp__maybe_unused , -int print_opts__maybe_unused ,FILE *fp__maybe_unused ) +ssize_t capstone__fprintf_insn_asm (struct machine *machine,struct thread *thread,u8 cpumode, +bool is64bit,const uint8_t *code,size_t code_size,uint64_t ip, +int *lenp,int print_opts,FILE *fp) {size_t printed;struct cs_insn *insn;csh cs_handle;size_t count; +bool is_big_endian = false; +uint16_t e_machine =thread__e_machine_endian (thread, machine, +/*e_flags=*/ NULL , &is_big_endian);int ret;/* TODO: Try to initiate capstone only once but need a proper place. */ - ret =capstone_init (machine, &cs_handle, is64bit, true); + ret =capstone_init (e_machine, &cs_handle, is64bit, is_big_endian, +/*disassembler_style=*/ true);if (ret <0 )return ret; count =perf_cs_disasm (cs_handle, code, code_size, ip,1 , &insn);if (count >0 ) { -if (machine__normalized_is (machine,"x86" )) +if (e_machine ==EM_X86_64 || e_machine ==EM_386 ) printed =print_insn_x86 (thread, cpumode, &insn[0 ], print_opts, fp);else printed =fprintf (fp,"%s %s" , insn[0 ].mnemonic, insn[0 ].op_str);
@@ -322,9 +359,8 @@ static int find_file_offset(u64 start, u64 len, u64 pgoff, void *arg)return 0 ; } -int symbol__disassemble_capstone (const char *filename__maybe_unused , -struct symbol *sym__maybe_unused , -struct annotate_args *args__maybe_unused ) +int symbol__disassemble_capstone (const char *filename,struct symbol *sym, +struct annotate_args *args) {struct annotation *notes =symbol__annotation (sym);struct map *map = args->ms->map;
@@ -344,6 +380,8 @@ int symbol__disassemble_capstone(const char *filename __maybe_unused,char disasm_buf[512 ];struct disasm_line *dl;bool disassembler_style = false; +uint16_t e_machine; +bool is_big_endian = false;if (args->options->objdump_path)return -1 ;
@@ -373,8 +411,10 @@ int symbol__disassemble_capstone(const char *filename __maybe_unused, !strcmp(args->options->disassembler_style, "att")) disassembler_style = true; -if (capstone_init (maps__machine (thread__maps (args->ms->thread)), &handle, is_64bit, - disassembler_style) <0 ) + e_machine =thread__e_machine_endian (args->ms->thread, +/*machine=*/ NULL , +/*e_flags=*/ NULL , &is_big_endian); +if (capstone_init (e_machine, &handle, is_64bit, is_big_endian, disassembler_style) <0 ) goto err; needs_cs_close = true;
@@ -466,6 +506,8 @@ int symbol__disassemble_capstone_powerpc(const char *filename __maybe_unused,struct disasm_line *dl;u32 *line;bool disassembler_style = false; +uint16_t e_machine; +bool is_big_endian = false;if (args->options->objdump_path)return -1 ;
@@ -484,8 +526,10 @@ int symbol__disassemble_capstone_powerpc(const char *filename __maybe_unused, !strcmp(args->options->disassembler_style, "att")) disassembler_style = true; -if (capstone_init (maps__machine (thread__maps (args->ms->thread)), &handle, is_64bit, - disassembler_style) <0 ) + e_machine =thread__e_machine_endian (args->ms->thread, +/*machine=*/ NULL , +/*e_flags=*/ NULL , &is_big_endian); +if (capstone_init (e_machine, &handle, is_64bit, is_big_endian, disassembler_style) <0 ) goto err; needs_cs_close = true;
Signature · 1 line
2.54.0.823.g6e5bcc1fc9-goog
[email protected]
AI reviewRe: [PATCH v10 04/18] perf capstone: Determine architecture from e_machine
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] RISC-V Capstone initialization omits the CS_MODE_RISCVC flag, breaking disassembly of compressed…
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] RISC-V Capstone initialization omits the CS_MODE_RISCVC flag, breaking disassembly of compressed instructions. --
commit 18a82eb3adc97143851fdd5ceee9d79bbd3d188d
Author: Ian Rogers <[email protected]>
perf capstone: Determine architecture from e_machine
This patch updates Capstone initialization to use the ELF e_machine header for architecture detection instead of relying on less precise architecture strings. It also adds new e_machine translations for MIPS and RISC-V.
Quoted 4 lines
tools/perf/util/capstone.c +0
-0
[ ... ]
Quoted 1 line
tools/perf/util/capstone.c +0
-0@@ -137,37 +142,70 @@ static enum cs_err perf_cs_close(csh *handle)
[ ... ]
Quoted 6 lines
tools/perf/util/capstone.c +6
-0+static bool e_machine_to_capstone (uint16_t e_machine,bool is64,bool is_big_endian, +enum cs_arch *arch,enum cs_mode *mode) +{ + *mode = is_big_endian ?CS_MODE_BIG_ENDIAN :CS_MODE_LITTLE_ENDIAN ; + +switch (e_machine) {
[ ... ]
tools/perf/util/capstone.c static enum cs_err perf_cs_close(csh *handle) · line 187
Quoted 3 lines
tools/perf/util/capstone.c +3
-0+case EM_RISCV : + *arch =CS_ARCH_RISCV ; + *mode |= is64 ?CS_MODE_RISCV64 :CS_MODE_RISCV32 ;
[Severity: Medium]
Does this initialization need the CS_MODE_RISCVC flag included in the mode bitmask to decode RISC-V 16-bit compressed instructions?
Since almost all RISC-V Linux code uses the C extension (RV64GC), omitting this flag could cause Capstone to encounter invalid opcodes on the first compressed instruction.
Would this abort disassembly prematurely and force a fallback to objdump?
Quoted 5 lines
tools/perf/util/capstone.c +5
-0+return true; +default : +return false; + } +}
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=4
Ian Rogers
reviewerPATCH v10 5/18 perf print_insn: Use e_machine for fallback IP length check
In reply to Ian RogersAvoid string comparisons with perf_env arch, switch to using the more precise ELF machine.
Sort header files and fix missing definitions.
--- tools/perf/util/print_insn.c | 23 ++++++++++++++--------- tools/perf/util/print_insn.h | 2 ++ 2 files changed, 16 insertions(+), 9 deletions(-)
tools/perf/util/print_insn.c +14 -9
@@ -4,19 +4,24 @@* * Author(s): Changbin Du <[email protected]> */ +#include "print_insn.h" +#include <inttypes.h> -#include <string.h> #include <stdbool.h> +#include <string.h> + +#include <dwarf-regs.h> +#include "capstone.h" #include "debug.h" +#include "dso.h" +#include "dump-insn.h" +#include "env.h" +#include "machine.h" +#include "map.h" #include "sample.h" #include "symbol.h" -#include "machine.h" #include "thread.h" -#include "print_insn.h" -#include "dump-insn.h" -#include "map.h" -#include "dso.h" size_t sample__fprintf_insn_raw (struct perf_sample *sample,FILE *fp) {
@@ -33,13 +38,13 @@ size_t sample__fprintf_insn_raw(struct perf_sample *sample, FILE *fp)static bool is64bitip (struct machine *machine,struct addr_location *al) {const struct dso *dso = al->map ?map__dso (al->map) :NULL ; +uint16_t e_machine;if (dso)return dso__is_64_bit (dso); -return machine__is (machine,"x86_64" ) || -machine__normalized_is (machine,"arm64" ) || -machine__normalized_is (machine,"s390" ); + e_machine =perf_env__e_machine (machine->env,/*e_flags=*/ NULL ); +return e_machine ==EM_X86_64 || e_machine ==EM_AARCH64 || e_machine ==EM_S390 ; } ssize_t fprintf_insn_asm(struct machine *machine, struct thread *thread, u8 cpumode,
tools/perf/util/print_insn.h +2 -0
@@ -5,6 +5,8 @@#include <stddef.h> #include <stdio.h> +#include <linux/types.h> +struct addr_location ;struct machine ;struct perf_insn ;
Signature · 1 line
2.54.0.823.g6e5bcc1fc9-goog
Ian Rogers
reviewerPATCH v10 6/18 perf symbol: Avoid use of machine__is
In reply to Ian RogersSwitch to using the ELF machine from the dso or running machine rather than the machine perf_env arch that may fall back on EM_HOST. This also avoids potentially imprecise string comparisons.
--- tools/perf/util/symbol.c | 28 ++++++++++++++++++++++------ 1 file changed, 22 insertions(+), 6 deletions(-)
tools/perf/util/symbol.c +22 -6
@@ -851,6 +851,23 @@ static int maps__split_kallsyms_for_kcore(struct maps *kmaps, struct dso *dso)return count; } +static uint16_t machine_or_dso_e_machine (struct machine *machine,struct dso *dso) +{ +uint16_t e_machine =EM_NONE ; +/* DSO should be most accurate */ +if (dso) + e_machine =dso__e_machine (dso, machine,/*e_flags=*/ NULL ); + +if (e_machine !=EM_NONE ) +return e_machine; + +/* Check the global environment next. */ +if (machine && machine->env && machine->env->e_machine !=EM_NONE ) +return machine->env->e_machine; + +return perf_env__e_machine (machine ? machine->env :NULL ,/*e_flags=*/ NULL ); +} +/* * Split the symbols into maps, making sure there are no overlaps, i.e. the * kernel range is broken in several maps, named [kernel].N, as we don't have
@@ -866,14 +883,13 @@ static int maps__split_kallsyms(struct maps *kmaps, struct dso *dso, u64 delta,struct rb_root_cached *root =dso__symbols (dso);struct rb_node *next =rb_first_cached (root);int kernel_range =0 ; -bool x86_64; +uint16_t e_machine =EM_NONE ;if (!kmaps)return -1 ; machine =maps__machine (kmaps); - - x86_64 =machine__is (machine,"x86_64" ); + e_machine =machine_or_dso_e_machine (machine, dso);while (next) {char *module;
@@ -925,7 +941,7 @@ static int maps__split_kallsyms(struct maps *kmaps, struct dso *dso, u64 delta,*/ pos->start =map__map_ip (curr_map, pos->start); pos->end =map__map_ip (curr_map, pos->end); - }else if (x86_64 &&is_entry_trampoline (pos->name)) { + }else if (e_machine ==EM_X86_64 &&is_entry_trampoline (pos->name)) {/* * These symbols are not needed anymore since the * trampoline maps refer to the text section and it's
@@ -1428,7 +1444,7 @@ static int dso__load_kcore(struct dso *dso, struct map *map,free (new_node); } -if (machine__is (machine,"x86_64" )) { +if (machine_or_dso_e_machine (machine, dso) ==EM_X86_64 ) {u64 addr;/*
@@ -1716,7 +1732,7 @@ int dso__load(struct dso *dso, struct map *map) ret =dso__load_guest_kernel_sym (dso, map); machine =maps__machine (map__kmaps (map)); -if (machine__is (machine,"x86_64" )) +if (machine &&machine_or_dso_e_machine (machine, dso) ==EM_X86_64 )machine__map_x86_64_entry_trampolines (machine, dso); goto out; }
Signature · 1 line
2.54.0.823.g6e5bcc1fc9-goog
Ian Rogers
reviewerPATCH v10 7/18 perf machine: Use perf_env e_machine rather than arch
In reply to Ian RogersThe arch string is derived from uname and may be normalized causing potential differences meaning the ELF machine can be more precise. Reduce the scope of machine__is as often it is better to use a thread for the e_machine rather than the machine. Switch from string to ELF machine constant comparisons.
--- tools/perf/util/machine.c | 35 ++++++++++++++++++----------------- tools/perf/util/machine.h | 2 -- 2 files changed, 18 insertions(+), 19 deletions(-)
tools/perf/util/machine.c +18 -17
@@ -9,6 +9,7 @@#include "debug.h" #include "dso.h" #include "env.h" +#include "dwarf-regs.h" #include "event.h" #include "evsel.h" #include "hist.h"
@@ -1627,10 +1628,24 @@ static bool machine__uses_kcore(struct machine *machine)return dsos__for_each_dso (&machine->dsos, machine__uses_kcore_cb,NULL ) !=0 ? true : false; } +static bool machine__is (struct machine *machine,uint16_t e_machine) +{ +if (!machine) +return false; + +if (!machine->env) { +if (machine__is_host (machine)) +return e_machine ==EM_HOST ; +return false; + } + +return perf_env__e_machine (machine->env,NULL ) == e_machine; +} +static bool perf_event__is_extra_kernel_mmap (struct machine *machine,struct extra_kernel_map *xm) { -return machine__is (machine,"x86_64" ) && +return machine__is (machine,EM_X86_64 ) &&is_entry_trampoline (xm->name); }
@@ -2786,7 +2801,7 @@ static int find_prev_cpumode(struct ip_callchain *chain, struct thread *thread,static u64 get_leaf_frame_caller (struct perf_sample *sample,struct thread *thread,int usr_idx) { -if (machine__normalized_is (maps__machine (thread__maps (thread)),"arm64" )) +if (thread__e_machine (thread,/*machine=*/ NULL ,/*e_flags=*/ NULL ) ==EM_AARCH64 )return get_leaf_frame_caller_aarch64 (sample, thread, usr_idx);else return 0 ;
@@ -3157,20 +3172,6 @@ int machine__set_current_tid(struct machine *machine, int cpu, pid_t pid,return 0 ; } -/* -* Compares the raw arch string. N.B. see instead perf_env__arch() or -* machine__normalized_is() if a normalized arch is needed. -*/ -bool machine__is (struct machine *machine,const char *arch) -{ -return machine && !strcmp (perf_env__raw_arch (machine->env), arch); -} - -bool machine__normalized_is (struct machine *machine,const char *arch) -{ -return machine && !strcmp (perf_env__arch (machine->env), arch); -} -int machine__nr_cpus_avail (struct machine *machine) {return machine ?perf_env__nr_cpus_avail (machine->env) :0 ;
@@ -3197,7 +3198,7 @@ int machine__get_kernel_start(struct machine *machine)* start of kernel text, but still above 2^63. So leave * kernel_start = 1ULL << 63 for x86_64. */ -if (!err && !machine__is (machine,"x86_64" )) +if (!err && !machine__is (machine,EM_X86_64 )) machine->kernel_start =map__start (map); }return err;
tools/perf/util/machine.h +0 -2
@@ -224,8 +224,6 @@ static inline bool machine__is_host(struct machine *machine) }bool machine__is_lock_function (struct machine *machine,u64 addr); -bool machine__is (struct machine *machine,const char *arch); -bool machine__normalized_is (struct machine *machine,const char *arch);int machine__nr_cpus_avail (struct machine *machine);struct thread *machine__findnew_thread (struct machine *machine,pid_t pid,pid_t tid);
Signature · 1 line
2.54.0.823.g6e5bcc1fc9-goog
Ian Rogers
reviewerPATCH v10 8/18 perf sample-raw: Use perf_env e_machine rather than arch
In reply to Ian RogersUse the e_machine rather than the arch to determine S390 and x86 types.
--- tools/perf/util/sample-raw.c | 21 +++++++++++---------- tools/perf/util/sample-raw.h | 6 +++++- 2 files changed, 16 insertions(+), 11 deletions(-)
tools/perf/util/sample-raw.c +11 -10
@@ -1,11 +1,12 @@/* SPDX-License-Identifier: GPL-2.0 */ +#include "sample-raw.h" -#include <string.h> +#include <elf.h> #include <linux/string.h> -#include "evlist.h" +#include "env.h" +#include "evlist.h" #include "header.h" -#include "sample-raw.h" #include "session.h" /*
@@ -14,14 +15,14 @@*/ void evlist__init_trace_event_sample_raw (struct evlist *evlist,struct perf_env *env) { -const char *arch_pf =perf_env__arch (env); -const char *cpuid =perf_env__cpuid (env); +uint16_t e_machine =perf_env__e_machine (env,/*e_flags=*/ NULL ); -if (arch_pf && !strcmp ("s390" , arch_pf)) +if (e_machine ==EM_S390 ) { evlist->trace_event_sample_raw = evlist__s390_sample_raw; -else if (arch_pf && !strcmp ("x86" , arch_pf) && - cpuid &&strstarts (cpuid,"AuthenticAMD" ) && -evlist__has_amd_ibs (evlist)) { - evlist->trace_event_sample_raw = evlist__amd_sample_raw; + }else if (e_machine ==EM_X86_64 || e_machine ==EM_386 ) { +const char *cpuid =perf_env__cpuid (env); + +if (cpuid &&strstarts (cpuid,"AuthenticAMD" ) &&evlist__has_amd_ibs (evlist)) + evlist->trace_event_sample_raw = evlist__amd_sample_raw; } }
tools/perf/util/sample-raw.h +5 -1
@@ -2,7 +2,10 @@#ifndef __SAMPLE_RAW_H#define __SAMPLE_RAW_H 1 +#include <stdbool.h> +struct evlist ; +struct perf_env ;union perf_event ;struct perf_sample ;
@@ -12,4 +15,5 @@ bool evlist__has_amd_ibs(struct evlist *evlist);void evlist__amd_sample_raw (struct evlist *evlist,union perf_event *event,struct perf_sample *sample);void evlist__init_trace_event_sample_raw (struct evlist *evlist,struct perf_env *env); -#endif /* __PERF_EVLIST_H */ + +#endif /* __SAMPLE_RAW_H */
Signature · 1 line
2.54.0.823.g6e5bcc1fc9-goog
Ian Rogers
reviewerPATCH v10 9/18 perf sort: Use perf_env e_machine rather than arch
In reply to Ian RogersUse the e_machine rather than the arch to determine x86 or PPC types.
--- tools/perf/util/sort.c | 58 +++++++++++++++++++++++------------------- 1 file changed, 32 insertions(+), 26 deletions(-)
tools/perf/util/sort.c +32 -26
@@ -1,40 +1,45 @@// SPDX-License-Identifier: GPL-2.0 +#include "sort.h" +#include <ctype.h> #include <errno.h> #include <inttypes.h> -#include <regex.h> #include <stdlib.h> + +#include <elf.h> +#include <linux/kernel.h> #include <linux/mman.h> +#include <linux/string.h> #include <linux/time64.h> + +#include <regex.h> + +#include "annotate-data.h" +#include "annotate.h" +#include "branch.h" +#include "cacheline.h" +#include "cgroup.h" +#include "comm.h" #include "debug.h" #include "dso.h" -#include "sort.h" +#include "event.h" +#include "evlist.h" +#include "evsel.h" #include "hist.h" -#include "cacheline.h" -#include "comm.h" +#include "machine.h" #include "map.h" -#include "maps.h" -#include "symbol.h" #include "map_symbol.h" -#include "branch.h" -#include "thread.h" -#include "evsel.h" -#include "evlist.h" -#include "srcline.h" -#include "strlist.h" -#include "strbuf.h" +#include "maps.h" #include "mem-events.h" #include "mem-info.h" -#include "annotate.h" -#include "annotate-data.h" -#include "event.h" -#include "time-utils.h" -#include "cgroup.h" -#include "machine.h" #include "session.h" +#include "srcline.h" +#include "strbuf.h" +#include "strlist.h" +#include "symbol.h" +#include "thread.h" +#include "time-utils.h" #include "trace-event.h" -#include <linux/kernel.h> -#include <linux/string.h> #ifdef HAVE_LIBTRACEEVENT #include <event-parse.h>
@@ -2673,9 +2678,10 @@ struct sort_dimension {static int arch_support_sort_key (const char *sort_key,struct perf_env *env) { -const char *arch =perf_env__arch (env); +uint16_t e_machine =perf_env__e_machine (env,/*e_eflags=*/ NULL ); -if (!strcmp ("x86" , arch) || !strcmp ("powerpc" , arch)) { +if (e_machine ==EM_X86_64 || e_machine ==EM_386 || e_machine ==EM_PPC64 || + e_machine ==EM_PPC ) {if (!strcmp (sort_key,"p_stage_cyc" ))return 1 ;if (!strcmp (sort_key,"local_p_stage_cyc" ))
@@ -2686,14 +2692,14 @@ static int arch_support_sort_key(const char *sort_key, struct perf_env *env)static const char *arch_perf_header_entry (const char *se_header,struct perf_env *env) { -const char *arch =perf_env__arch (env); +uint16_t e_machine =perf_env__e_machine (env,/*e_eflags=*/ NULL ); -if (!strcmp ("x86" , arch)) { +if (e_machine ==EM_X86_64 || e_machine ==EM_386 ) {if (!strcmp (se_header,"Local Pipeline Stage Cycle" ))return "Local Retire Latency" ;else if (!strcmp (se_header,"Pipeline Stage Cycle" ))return "Retire Latency" ; - }else if (!strcmp ("powerpc" , arch)) { + }else if (e_machine ==EM_PPC64 || e_machine ==EM_PPC ) {if (!strcmp (se_header,"Local INSTR Latency" ))return "Finish Cyc" ;else if (!strcmp (se_header,"INSTR Latency" ))
Signature · 1 line
2.54.0.823.g6e5bcc1fc9-goog
Ian Rogers
reviewerPATCH v10 10/18 perf arch common: Use perf_env e_machine rather than arch
In reply to Ian RogersUse the e_machine rather than arch string matching.
--- tools/perf/arch/common.c | 92 ++++++++++++++++++++++++++++++---------- 1 file changed, 69 insertions(+), 23 deletions(-)
tools/perf/arch/common.c +69 -23
@@ -1,13 +1,18 @@// SPDX-License-Identifier: GPL-2.0 +#include "common.h" +#include <limits.h> #include <stdio.h> #include <stdlib.h> #include <string.h> + +#include <linux/zalloc.h> #include <unistd.h> -#include "common.h" -#include "../util/env.h" + +#include <dwarf-regs.h> +#include "../util/debug.h" -#include <linux/zalloc.h> +#include "../util/env.h" static const char *const arc_triplets[] = {"arc-linux-" ,
@@ -141,11 +146,40 @@ static int lookup_triplets(const char *const *triplets, const char *name)return -1 ; } +static bool is_native_compatible (struct perf_env *env,uint16_t target,uint16_t host) +{ +if (target != host) { +/* A 64-bit host can natively disassemble its 32-bit compat architecture */ +if (host ==EM_X86_64 && target ==EM_386 ) +return true; +if (host ==EM_AARCH64 && target ==EM_ARM ) +return true; +if (host ==EM_PPC64 && target ==EM_PPC ) +return true; +if (host ==EM_SPARCV9 && target ==EM_SPARC ) +return true; +return false; + } + +/* target == host case */ +if (target ==EM_RISCV ) { +bool target_is_64 =perf_env__kernel_is_64_bit (env); +bool host_is_64 = (sizeof (void *) ==8 ); + +/* 32-bit host cannot natively disassemble 64-bit target */ +if (!host_is_64 && target_is_64) +return false; + } + +return true; +} +static int perf_env__lookup_binutils_path (struct perf_env *env,const char *name,char **path) {int idx; -const char *arch =perf_env__arch (env), *cross_env; +uint16_t e_machine =perf_env__e_machine (env,/*e_flags=*/ NULL ); +const char *cross_env;const char *const *path_list;char *buf =NULL ;
@@ -153,7 +187,7 @@ static int perf_env__lookup_binutils_path(struct perf_env *env,* We don't need to try to find objdump path for native system. * Just use default binutils path (e.g.: "objdump"). */ -if (!strcmp (perf_env__arch (NULL ), arch)) +if (is_native_compatible (env, e_machine,EM_HOST )) goto out; cross_env =getenv ("CROSS_COMPILE" );
@@ -170,30 +204,42 @@ static int perf_env__lookup_binutils_path(struct perf_env *env,zfree (&buf); } -if (!strcmp (arch,"arc" )) +switch (e_machine) { +case EM_ARC : path_list = arc_triplets; -else if (!strcmp (arch,"arm" )) +break ; +case EM_ARM : path_list = arm_triplets; -else if (!strcmp (arch,"arm64" )) +break ; +case EM_AARCH64 : path_list = arm64_triplets; -else if (!strcmp (arch,"powerpc" )) +break ; +case EM_PPC : +case EM_PPC64 : path_list = powerpc_triplets; -else if (!strcmp (arch,"riscv32" )) - path_list = riscv32_triplets; -else if (!strcmp (arch,"riscv64" )) - path_list = riscv64_triplets; -else if (!strcmp (arch,"sh" )) +break ; +case EM_RISCV : + path_list =perf_env__kernel_is_64_bit (env) ? riscv64_triplets : riscv32_triplets; +break ; +case EM_SH : path_list = sh_triplets; -else if (!strcmp (arch,"s390" )) +break ; +case EM_S390 : path_list = s390_triplets; -else if (!strcmp (arch,"sparc" )) +break ; +case EM_SPARC : +case EM_SPARCV9 : path_list = sparc_triplets; -else if (!strcmp (arch,"x86" )) +break ; +case EM_X86_64 : +case EM_386 : path_list = x86_triplets; -else if (!strcmp (arch,"mips" )) +break ; +case EM_MIPS : path_list = mips_triplets; -else { -ui__error ("binutils for %s not supported.\n" , arch); +break ; +default : +ui__error ("binutils for %s not supported.\n" ,perf_env__arch (env)); goto out_error; }
@@ -202,7 +248,7 @@ static int perf_env__lookup_binutils_path(struct perf_env *env,ui__error ("Please install %s for %s.\n" "You can add it to PATH, set CROSS_COMPILE or " "override the default using --%s.\n" , - name, arch, name); + name,perf_env__arch (env), name); goto out_error; }
@@ -237,7 +283,7 @@ int perf_env__lookup_objdump(struct perf_env *env, char **path)*/ bool perf_env__single_address_space (struct perf_env *env) { -const char *arch =perf_env__arch (env); +uint16_t e_machine =perf_env__e_machine (env,/*e_flags=*/ NULL ); -return strcmp (arch,"s390" ) &&strcmp (arch,"sparc" ); +return e_machine !=EM_SPARC && e_machine !=EM_SPARCV9 ; }
Signature · 1 line
2.54.0.823.g6e5bcc1fc9-goog
[email protected]
AI reviewRe: [PATCH v10 10/18] perf arch common: Use perf_env e_machine rather than arch
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [High] `perf_env__single_address_space()` incorrectly drops the `s390` exclusion, returning `true` for…
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] perf_env__single_address_space() incorrectly drops the s390 exclusion, returning true for EM_S390 and breaking s390 address resolution. --
commit c962da7ad2b7e7b1d31d8f31f86699358bb75c4b
Author: Ian Rogers <[email protected]>
perf arch common: Use perf_env e_machine rather than arch
This commit refactors architecture matching in the perf tools to use the ELF machine constant (e_machine) instead of string matching on the architecture name.
Quoted 4 lines
tools/perf/arch/common.c +0
-0
[ ... ]
tools/perf/arch/common.c int perf_env__lookup_objdump(struct perf_env *env, char **path) · line 288
Quoted 9 lines
tools/perf/arch/common.c +2
-2@@ -237,7 +283,7 @@ int perf_env__lookup_objdump(struct perf_env *env, char **path)*/ bool perf_env__single_address_space (struct perf_env *env) { -const char *arch =perf_env__arch (env); +uint16_t e_machine =perf_env__e_machine (env,/*e_flags=*/ NULL ); -return strcmp (arch,"s390" ) &&strcmp (arch,"sparc" ); +return e_machine !=EM_SPARC && e_machine !=EM_SPARCV9 ;
[Severity: High]
Does this unintentionally drop the s390 exclusion?
The original code returned false for both "s390" and "sparc", but the updated logic omits a check for EM_S390, causing it to return true for s390 targets.
Because s390 uses overlapping address spaces for user and kernel space, treating it as a single address space causes machine__addr_cpumode() to misclassify user-space addresses as kernel-space (PERF_RECORD_MISC_KERNEL) if they happen to overlap with kernel memory maps.
Could this break symbol resolution, callchains, and event attribution for s390 workloads?
Quoted 1 line
tools/perf/arch/common.c +0
-0}
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=10
Ian Rogers
reviewerPATCH v10 11/18 perf header: In print_pmu_caps use perf_env e_machine
In reply to Ian RogersSwitch from arch to e_machine in print_pmu_caps.
--- tools/perf/util/header.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
tools/perf/util/header.c +4 -3
@@ -2461,15 +2461,16 @@ static void print_cpu_pmu_caps(struct feat_fd *ff, FILE *fp)static void print_pmu_caps (struct feat_fd *ff,FILE *fp) {struct perf_env *env = &ff->ph->env; -struct pmu_caps *pmu_caps; +uint16_t e_machine =perf_env__e_machine (env,/*e_flags=*/ NULL );for (int i =0 ; i < env->nr_pmus_with_caps; i++) { - pmu_caps = &env->pmu_caps[i]; +struct pmu_caps *pmu_caps = &env->pmu_caps[i]; +__print_pmu_caps (fp, pmu_caps->nr_caps, pmu_caps->caps, pmu_caps->pmu_name); } -if (strcmp (perf_env__arch (env),"x86" ) ==0 && +if ((e_machine ==EM_X86_64 || e_machine ==EM_386 ) &&perf_env__has_pmu_mapping (env,"ibs_op" )) {char *max_precise =perf_env__find_pmu_cap (env,"cpu" ,"max_precise" );
Signature · 1 line
2.54.0.823.g6e5bcc1fc9-goog
Ian Rogers
reviewerPATCH v10 12/18 perf c2c: Use perf_env e_machine rather than arch
In reply to Ian RogersUse the e_machine rather than arch string matching for AARCH64.
Add include of dwarf-regs.h in case the EM_AARCH64 isn't defined, sort the headers given this include.
--- tools/perf/builtin-c2c.c | 40 ++++++++++++++++++++++------------------ 1 file changed, 22 insertions(+), 18 deletions(-)
tools/perf/builtin-c2c.c +22 -18
@@ -12,41 +12,45 @@*/ #include <errno.h> #include <inttypes.h> + +#include <asm/bug.h> #include <linux/compiler.h> #include <linux/err.h> #include <linux/kernel.h> #include <linux/stringify.h> #include <linux/zalloc.h> -#include <asm/bug.h> #include <sys/param.h> -#include "debug.h" -#include "builtin.h" + +#include <dwarf-regs.h> #include <perf/cpumap.h> #include <subcmd/pager.h> #include <subcmd/parse-options.h> -#include "map_symbol.h" -#include "mem-events.h" -#include "session.h" -#include "hist.h" -#include "sort.h" -#include "tool.h" + +#include "builtin.h" #include "cacheline.h" #include "data.h" +#include "debug.h" #include "event.h" #include "evlist.h" #include "evsel.h" -#include "ui/browsers/hists.h" -#include "thread.h" -#include "mem2node.h" +#include "hist.h" +#include "map_symbol.h" +#include "mem-events.h" #include "mem-info.h" -#include "symbol.h" -#include "ui/ui.h" -#include "ui/progress.h" +#include "mem2node.h" #include "pmus.h" +#include "session.h" +#include "sort.h" #include "string2.h" -#include "util/util.h" -#include "util/symbol.h" +#include "symbol.h" +#include "thread.h" +#include "tool.h" +#include "ui/browsers/hists.h" +#include "ui/progress.h" +#include "ui/ui.h" #include "util/annotate.h" +#include "util/symbol.h" +#include "util/util.h" struct c2c_hists {struct hists hists;
@@ -3202,7 +3206,7 @@ static int perf_c2c__report(int argc, const char **argv)* default display type. */ if (!display) { -if (!strcmp (perf_env__arch (env),"arm64" )) +if (perf_env__e_machine (env,/*e_flags=*/ NULL ) ==EM_AARCH64 ) display ="peer" ;else display ="tot" ;
Signature · 1 line
2.54.0.823.g6e5bcc1fc9-goog
Ian Rogers
reviewerPATCH v10 13/18 perf lock-contention: Use perf_env e_machine rather than arch
In reply to Ian RogersUse the e_machine rather than arch string matching for powerpc.
--- tools/perf/util/lock-contention.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
tools/perf/util/lock-contention.c +3 -3
@@ -104,7 +104,8 @@ bool match_callstack_filter(struct machine *machine, u64 *callstack, int max_stastruct map *kmap;struct symbol *sym;u64 ip; -const char *arch =perf_env__arch (machine->env); +uint16_t e_machine =perf_env__e_machine (machine->env,/*e_flags=*/ NULL ); +bool is_powerpc = e_machine ==EM_PPC64 || e_machine ==EM_PPC ;if (list_empty (&callstack_filters))return true;
@@ -125,8 +126,7 @@ bool match_callstack_filter(struct machine *machine, u64 *callstack, int max_sta* incase first or second callstack index entry has 0 * address for powerpc. */ -if (!callstack || (!callstack[i] && (strcmp (arch,"powerpc" ) || - (i !=1 && i !=2 )))) +if (!callstack || (!callstack[i] && (!is_powerpc || (i !=1 && i !=2 ))))break ; ip = callstack[i];
Signature · 1 line
2.54.0.823.g6e5bcc1fc9-goog
Ian Rogers
reviewerPATCH v10 14/18 perf env: Refactor perf_env__arch_strerrno
In reply to Ian Rogersperf_env__arch_strerrno is only available with libtraceevent so hide the declaration if no libtraceevent.
The previous approach maps an architecture string to a function pointer to a function that takes an int errno values and returns a string. The new approach takes an e_machine and an errno value and returns a string.
As the only call site is in builtin-trace.c, the e_machine is already present and potentially more specific than the perf_env arch string that is a single global value.
The major complication in this approach is having the shell script that generates the C code map a linux directory name to the matching ELF machine constants.
--- tools/perf/builtin-trace.c | 7 ++-- tools/perf/trace/beauty/Build | 1 + tools/perf/trace/beauty/arch_errno_names.sh | 41 ++++++++++++++++++--- tools/perf/util/env.c | 15 +++----- tools/perf/util/env.h | 8 ++-- tools/perf/util/libdw.c | 2 +- 6 files changed, 51 insertions(+), 23 deletions(-)
tools/perf/builtin-trace.c +4 -3
@@ -3032,9 +3032,8 @@ static int trace__sys_exit(struct trace *trace, }else if (ret <0 ) { errno_print: {char bf[STRERR_BUFSIZE ]; -struct perf_env *env =evsel__env (evsel) ?: &trace->host_env;const char *emsg =str_error_r (-ret, bf,sizeof (bf)); -const char *e =perf_env__arch_strerrno (env, err); +const char *e =perf_env__arch_strerrno (e_machine, err);fprintf (trace->output,"-1 %s (%s)" , e, emsg); }
@@ -4921,7 +4920,9 @@ static size_t syscall__dump_stats(struct trace *trace, int e_machine, FILE *fp,for (e =0 ; e < stats->max_errno; ++e) {if (stats->errnos[e] !=0 ) -fprintf (fp,"\t\t\t\t%s: %d\n" ,perf_env__arch_strerrno (trace->host->env, e +1 ), stats->errnos[e]); +fprintf (fp,"\t\t\t\t%s: %d\n" , +perf_env__arch_strerrno (e_machine, e +1 ), + stats->errnos[e]); } } lines++;
tools/perf/trace/beauty/Build +1 -0
@@ -36,6 +36,7 @@ perf-y += signum.o perf-y += socket_type.o perf-y += waitid_options.o perf-util-y += arch_errno_names.o + perf-y += tracepoints/ ifdef SHELLCHECK
tools/perf/trace/beauty/arch_errno_names.sh +36 -5
63 lines not on this page · raw message
tools/perf/util/env.c +6 -9
@@ -863,17 +863,14 @@ const char *perf_env__arch(struct perf_env *env)return env->arch ?: arch; } -const char *perf_env__arch_strerrno (struct perf_env *env__maybe_unused ,int err__maybe_unused ) -{ -#if defined(HAVE_LIBTRACEEVENT ) -if (env->arch_strerrno ==NULL ) - env->arch_strerrno =arch_syscalls__strerrno_function (perf_env__arch (env)); +const char *arch_syscalls__strerrno (uint16_t e_machine,int err); -return env->arch_strerrno ? env->arch_strerrno (err) :"no arch specific strerrno function" ; -#else -return "!HAVE_LIBTRACEEVENT" ; -#endif +#if defined(HAVE_LIBTRACEEVENT ) +const char *perf_env__arch_strerrno (uint16_t e_machine,int err) +{ +return arch_syscalls__strerrno (e_machine, err); } +#endif const char *perf_env__cpuid (struct perf_env *env) {
tools/perf/util/env.h +3 -5
@@ -67,8 +67,6 @@ struct cpu_domain_map {struct domain_info **domains; }; -typedef const char *(arch_syscalls__strerrno_t )(int err); -struct perf_env {char *hostname;char *os_release;
@@ -158,7 +156,6 @@ struct perf_env {*/ bool enabled; } clock; -arch_syscalls__strerrno_t *arch_strerrno; };enum perf_compress_type {
@@ -191,8 +188,9 @@ void cpu_cache_level__free(struct cpu_cache_level *cache);uint16_t perf_env__e_machine_nocache (struct perf_env *env,uint32_t *e_flags);uint16_t perf_env__e_machine (struct perf_env *env,uint32_t *e_flags);const char *perf_env__arch (struct perf_env *env); -const char *perf_env__arch_strerrno (struct perf_env *env,int err); -arch_syscalls__strerrno_t *arch_syscalls__strerrno_function (const char *arch); +#if defined(HAVE_LIBTRACEEVENT ) +const char *perf_env__arch_strerrno (uint16_t e_machine,int err); +#endif const char *perf_env__cpuid (struct perf_env *env);const char *perf_env__raw_arch (struct perf_env *env);int perf_env__nr_cpus_avail (struct perf_env *env);
tools/perf/util/libdw.c +1 -1
@@ -130,7 +130,7 @@ static int libdw_a2l_cb(Dwarf_Die *die, void *_args)return 0 ; abort_delete_sym: -if (inline_sym->inlined) +if (symbol__inlined (inline_sym))symbol__delete (inline_sym); abort_enomem: args->err = -ENOMEM ;
Signature · 1 line
2.54.0.823.g6e5bcc1fc9-goog
[email protected]
AI reviewRe: [PATCH v10 14/18] perf env: Refactor perf_env__arch_strerrno
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider: - [Low] Missing dummy inline fallback stub for `perf_env__arch_strerrno` when `HAVE_LIBTRACEEVENT` is…
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] Missing dummy inline fallback stub for perf_env__arch_strerrno when HAVE_LIBTRACEEVENT is absent.
- [Low] Undeclared identifier symbol__inlined in error cleanup path causes a build error. --
commit a93192909b20934ddb15d354806178b9b8b10838
Author: Ian Rogers <[email protected]>
perf env: Refactor perf_env__arch_strerrno
This commit refactors perf_env__arch_strerrno to take an e_machine parameter instead of using a global architecture string function pointer. It also updates the build script to map architecture strings to ELF machine constants.
Quoted 4 lines
tools/perf/util/env.h +0
-0
[ ... ]
tools/perf/util/env.h void cpu_cache_level__free(struct cpu_cache_level *cache); · line 194
Quoted 10 lines
tools/perf/util/env.h +3
-2@@ -191,8 +188,9 @@ void cpu_cache_level__free(struct cpu_cache_level *cache);uint16_t perf_env__e_machine_nocache (struct perf_env *env,uint32_t *e_flags);uint16_t perf_env__e_machine (struct perf_env *env,uint32_t *e_flags);const char *perf_env__arch (struct perf_env *env); -const char *perf_env__arch_strerrno (struct perf_env *env,int err); -arch_syscalls__strerrno_t *arch_syscalls__strerrno_function (const char *arch); +#if defined(HAVE_LIBTRACEEVENT ) +const char *perf_env__arch_strerrno (uint16_t e_machine,int err); +#endif const char *perf_env__cpuid (struct perf_env *env);
[Severity: Low]
Does this code need a fallback dummy inline stub when HAVE_LIBTRACEEVENT is not defined?
According to the subsystem guidelines for build feature detection, header files should provide compatible dummy inline stubs when the feature define is absent. Omitting the stub pushes the ifdef responsibility to the caller, which can cause implicit declaration build errors if the function is used in feature-agnostic code.
tools/perf/util/libdw.c static int libdw_a2l_cb(Dwarf_Die *die, void *_args) · line 136
Quoted 13 lines
tools/perf/util/libdw.c +1
-1@@ -130,7 +130,7 @@ static int libdw_a2l_cb(Dwarf_Die *die, void *_args)return 0 ; abort_delete_sym: -if (inline_sym->inlined) +if (symbol__inlined (inline_sym))symbol__delete (inline_sym); abort_enomem: args->err = -ENOMEM ;
[Severity: Low]
Is symbol__inlined() declared at this point in the series?
It looks like this might cause an implicit declaration build error in libdw_a2l_cb() during the error cleanup path, breaking git bisectability. I notice the fix for this is added later in the series in commit 62331f0aa0a35ba8 ("perf symbol: Add setters for bitfields sharing a byte to avoid concurrent update issues").
Should this change be moved to that later patch?
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=14
Ian Rogers
reviewerPATCH v10 15/18 perf env: Remove unused perf_env__raw_arch
In reply to Ian RogersThe switch to using e_machine has made the perf_env__raw_arch function unused so remove it.
--- tools/perf/util/env.c | 18 ------------------ tools/perf/util/env.h | 1 - 2 files changed, 19 deletions(-)
tools/perf/util/env.c +0 -18
@@ -470,19 +470,6 @@ int perf_env__read_cpuid(struct perf_env *env)return 0 ; } -static int perf_env__read_arch (struct perf_env *env) -{ -struct utsname uts; - -if (env->arch) -return 0 ; - -if (!uname (&uts)) - env->arch =strdup (uts.machine); - -return env->arch ?0 : -ENOMEM ; -} -static int perf_env__read_nr_cpus_avail (struct perf_env *env) {if (env->nr_cpus_avail ==0 )
@@ -601,11 +588,6 @@ int perf_env__read_core_pmu_caps(struct perf_env *env)return ret; } -const char *perf_env__raw_arch (struct perf_env *env) -{ -return env && !perf_env__read_arch (env) ? env->arch :"unknown" ; -} -int perf_env__nr_cpus_avail (struct perf_env *env) {return env && !perf_env__read_nr_cpus_avail (env) ? env->nr_cpus_avail :0 ;
tools/perf/util/env.h +0 -1
@@ -192,7 +192,6 @@ const char *perf_env__arch(struct perf_env *env);const char *perf_env__arch_strerrno (uint16_t e_machine,int err);#endif const char *perf_env__cpuid (struct perf_env *env); -const char *perf_env__raw_arch (struct perf_env *env);int perf_env__nr_cpus_avail (struct perf_env *env);void perf_env__init (struct perf_env *env);
Signature · 1 line
2.54.0.823.g6e5bcc1fc9-goog
Ian Rogers
reviewerPATCH v10 16/18 perf env: Add helper to lazily compute the os_release
In reply to Ian RogersIn live mode the os_release isn't being initialized, make a lazy initialization helper that assumes when the os_release isn't initialized this is live mode.
--- tools/perf/util/data-convert-bt.c | 2 +- tools/perf/util/data-convert-json.c | 6 ++++-- tools/perf/util/env.c | 21 +++++++++++++++++++++ tools/perf/util/env.h | 1 + tools/perf/util/header.c | 16 +++++++++++----- tools/perf/util/symbol.c | 4 ++-- 6 files changed, 40 insertions(+), 10 deletions(-)
tools/perf/util/data-convert-bt.c +1 -1
@@ -1414,7 +1414,7 @@ do { \ADD ("host" , env->hostname);ADD ("sysname" ,"Linux" ); -ADD ("release" , env->os_release); +ADD ("release" ,perf_env__os_release (env));ADD ("version" , env->version);ADD ("machine" , env->arch);ADD ("domain" ,"kernel" );
tools/perf/util/data-convert-json.c +4 -2
@@ -16,6 +16,7 @@#include "linux/err.h" #include "util/auxtrace.h" #include "util/debug.h" +#include "util/env.h" #include "util/dso.h" #include "util/event.h" #include "util/evsel.h"
@@ -272,7 +273,7 @@ static void output_headers(struct perf_session *session, struct convert_json *c) {struct stat st;const struct perf_header *header = &session->header; -const struct perf_env *env =perf_session__env (session); +struct perf_env *env =perf_session__env (session);int ret;int fd =perf_data__fd (session->data);int i;
@@ -296,7 +297,8 @@ static void output_headers(struct perf_session *session, struct convert_json *c)output_json_key_format (out, true,2 ,"feat-offset" ,"%" PRIu64, header->feat_offset);output_json_key_string (out, true,2 ,"hostname" , env->hostname); -output_json_key_string (out, true,2 ,"os-release" , env->os_release); +output_json_key_string (out, true,2 ,"os-release" , +perf_env__os_release (env));output_json_key_string (out, true,2 ,"arch" , env->arch);if (env->cpu_desc)
tools/perf/util/env.c +21 -0
@@ -358,6 +358,27 @@ bool perf_arch_is_big_endian(const char *arch)return false; } +const char *perf_env__os_release (struct perf_env *env) +{ +struct utsname uts; +int ret; + +if (!env) +return perf_version_string; + +if (env->os_release) +return env->os_release; + +/* +* The os_release is being accessed but wasn't initialized from a data +* file, assume this is 'live' mode and use the release from uname. If +* uname or strdup fails then use the current perf tool version. +*/ + ret =uname (&uts); + env->os_release =strdup (ret <0 ? perf_version_string : uts.release); +return env->os_release ?: perf_version_string; +} +int perf_env__set_cmdline (struct perf_env *env,int argc,const char *argv[]) {int i;
tools/perf/util/env.h +1 -0
@@ -173,6 +173,7 @@ void perf_env__exit(struct perf_env *env);int perf_env__kernel_is_64_bit (struct perf_env *env);bool perf_arch_is_big_endian (const char *arch); +const char *perf_env__os_release (struct perf_env *env);int perf_env__set_cmdline (struct perf_env *env,int argc,const char *argv[]);
tools/perf/util/header.c +11 -5
@@ -432,13 +432,19 @@ static int write_osrelease(struct feat_fd *ff, struct evlist *evlist __maybe_unused) {struct utsname uts; -int ret; +const char *release =NULL ; - ret =uname (&uts); -if (ret <0 ) -return -1 ; +if (evlist->session) + release =perf_env__os_release (perf_session__env (evlist->session)); -return do_write_string (ff, uts.release); +if (!release) { +int ret =uname (&uts); + +if (ret <0 ) +return -1 ; + release = uts.release; + } +return do_write_string (ff, release); }static int write_arch (struct feat_fd *ff,struct evlist *evlist)
tools/perf/util/symbol.c +2 -2
@@ -2225,7 +2225,7 @@ static int vmlinux_path__init(struct perf_env *env) {struct utsname uts;char bf[PATH_MAX ]; -char *kernel_version; +const char *kernel_version;unsigned int i; vmlinux_path = malloc(sizeof(char *) * (ARRAY_SIZE(vmlinux_paths) +
@@ -2242,7 +2242,7 @@ static int vmlinux_path__init(struct perf_env *env)return 0 ;if (env) { - kernel_version = env->os_release; + kernel_version =perf_env__os_release (env); }else {if (uname (&uts) <0 ) goto out_fail;
Signature · 1 line
2.54.0.823.g6e5bcc1fc9-goog
[email protected]
AI reviewRe: [PATCH v10 16/18] perf env: Add helper to lazily compute the os_release
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider: - [Medium] The `perf_env__os_release()` helper incorrectly assumes an uninitialized `os_release` implies…
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The perf_env__os_release() helper incorrectly assumes an uninitialized os_release implies 'live mode' and populates the target environment with the host's OS release. This breaks cross-platform analysis of older perf.data files or pipe-mode streams.
- [Medium] Lockless lazy initialization of env->os_release creates a TOCTOU race condition, leading to potential memory leaks and unprotected data races in multi-threaded scenarios.
--
commit 3468e6592e2930724952882eef7d315b977f7343
Author: Ian Rogers <[email protected]>
perf env: Add helper to lazily compute the os_release
This commit introduces a helper to lazily initialize the os_release in perf_env. When the os_release is uninitialized, the helper assumes the tool is running in live mode and populates the field using the host's uname.
Quoted 4 lines
tools/perf/util/env.c +0
-0
[ ... ]
Quoted 4 lines
tools/perf/util/env.c +0
-0@@ -358,6 +358,27 @@ bool perf_arch_is_big_endian(const char *arch)return false; }
tools/perf/util/env.c bool perf_arch_is_big_endian(const char *arch) · line 370
Quoted 10 lines
tools/perf/util/env.c +10
-0+const char *perf_env__os_release (struct perf_env *env) +{ +struct utsname uts; +int ret; + +if (!env) +return perf_version_string; + +if (env->os_release) +return env->os_release;
[Severity: Medium]
Is this safe from concurrent execution in multi-threaded scenarios?
If multiple threads find env->os_release as NULL simultaneously, could they independently call uname(), allocate strings via strdup(), and unconditionally overwrite the shared pointer, leaking the memory allocated by the other racing threads?
tools/perf/util/env.c bool perf_arch_is_big_endian(const char *arch) · line 378
Quoted 8 lines
tools/perf/util/env.c +8
-0+ +/* +* The os_release is being accessed but wasn't initialized from a data +* file, assume this is 'live' mode and use the release from uname. If +* uname or strdup fails then use the current perf tool version. +*/ + ret =uname (&uts); + env->os_release =strdup (ret <0 ? perf_version_string : uts.release);
[Severity: Medium]
Does this break cross-platform and offline analysis for older data files?
When processing a perf.data file from an older tool version that lacks an os_release header, this helper assumes live mode and mutates the target environment with the current host's OS release.
Could this cause offline data converters, like output_headers() in tools/perf/util/data-convert-json.c, to incorrectly export the analysis host's kernel version instead of the target system's version?
Quoted 2 lines
tools/perf/util/env.c +2
-0+return env->os_release ?: perf_version_string; +}
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=16
Ian Rogers
reviewerPATCH v10 17/18 perf symbol: Add setters for bitfields sharing a byte to avoid concurrent update issues
In reply to Ian RogersA problem with putting bitfields into struct symbol is that other bits in the symbol could be updated concurrently and only one update to the underlying storage unit happen, leading to lost updates.
To avoid this, use atomics to atomically read or set part of 16-bits of flags in the symbol. Add accessors to simplify this.
The idle value has 3 values in preparation for a later change that will lazily update it.
--- tools/perf/builtin-inject.c | 2 +- tools/perf/builtin-kwork.c | 2 +- tools/perf/builtin-report.c | 2 +- tools/perf/builtin-sched.c | 4 +- tools/perf/builtin-top.c | 6 +- tools/perf/tests/symbols.c | 2 +- tools/perf/tests/vmlinux-kallsyms.c | 2 +- tools/perf/ui/browsers/annotate.c | 2 +- tools/perf/ui/browsers/map.c | 4 +- tools/perf/util/annotate.c | 5 +- tools/perf/util/auxtrace.c | 6 +- tools/perf/util/callchain.c | 4 +- tools/perf/util/dlfilter.c | 2 +- tools/perf/util/evsel_fprintf.c | 6 +- tools/perf/util/intel-pt.c | 2 +- tools/perf/util/machine.c | 2 +- tools/perf/util/probe-event.c | 4 +- .../util/scripting-engines/trace-event-perl.c | 2 +- .../scripting-engines/trace-event-python.c | 4 +- tools/perf/util/sort.c | 8 +- tools/perf/util/srcline.c | 10 +-- tools/perf/util/symbol-elf.c | 3 +- tools/perf/util/symbol.c | 84 +++++++++++++++---- tools/perf/util/symbol.h | 76 +++++++++++++---- tools/perf/util/symbol_fprintf.c | 4 +- 25 files changed, 175 insertions(+), 73 deletions(-)
tools/perf/builtin-inject.c +1 -1
@@ -552,7 +552,7 @@ static int perf_event__convert_sample_callchain(const struct perf_tool *tool,if (machine->single_address_space &&machine__kernel_ip (machine, node->ip))/* kernel IPs were added already */ ; -else if (node->ms.sym && node->ms.sym->inlined) +else if (node->ms.sym &&symbol__inlined (node->ms.sym))/* we can't handle inlined callchains */ ;else inject->raw_callchain->ips[i++] = node->ip;
tools/perf/builtin-kwork.c +1 -1
@@ -769,7 +769,7 @@ static void timehist_save_callchain(struct perf_kwork *kwork,if (sym) {if (!strcmp (sym->name,"__softirqentry_text_start" ) || !strcmp (sym->name,"__do_softirq" )) - sym->ignore =1 ; +symbol__set_ignore (sym, true); }callchain_cursor_advance (cursor);
tools/perf/builtin-report.c +1 -1
@@ -749,7 +749,7 @@ static int hists__resort_cb(struct hist_entry *he, void *arg)struct report *rep = arg;struct symbol *sym = he->ms.sym; -if (rep->symbol_ipc && sym && !sym->annotate2) { +if (rep->symbol_ipc && sym && !symbol__is_annotate2 (sym)) {struct evsel *evsel =hists_to_evsel (he->hists);symbol__annotate2 (&he->ms, evsel,NULL );
tools/perf/builtin-sched.c +2 -2
@@ -2367,7 +2367,7 @@ static void save_task_callchain(struct perf_sched *sched,if (!strcmp (sym->name,"schedule" ) || !strcmp (sym->name,"__schedule" ) || !strcmp (sym->name,"preempt_schedule" )) - sym->ignore =1 ; +symbol__set_ignore (sym, true); }callchain_cursor_advance (cursor);
@@ -3025,7 +3025,7 @@ static size_t callchain__fprintf_folded(FILE *fp, struct callchain_node *node)list_for_each_entry (chain, &node->val, list) {if (chain->ip >=PERF_CONTEXT_MAX )continue ; -if (chain->ms.sym && chain->ms.sym->ignore) +if (chain->ms.sym &&symbol__ignore (chain->ms.sym))continue ; ret += fprintf(fp, "%s%s", first ? "" : sep, callchain_list__sym_name(chain, bf, sizeof(bf),
tools/perf/builtin-top.c +3 -3
@@ -186,8 +186,8 @@ static void ui__warn_map_erange(struct map *map, struct symbol *sym, u64 ip)"Please report to [email protected]\n" , ip,dso__long_name (dso),dso__symtab_origin (dso),map__start (map),map__end (map), sym->start, sym->end, - sym->binding ==STB_GLOBAL ?'g' : - sym->binding ==STB_LOCAL ?'l' :'w' , sym->name, +symbol__binding (sym) ==STB_GLOBAL ?'g' : +symbol__binding (sym) ==STB_LOCAL ?'l' :'w' , sym->name, err ?"[unknown]" : uts.machine, err ? "[unknown]" : uts.release, perf_version_string);if (use_browser <=0 )
@@ -828,7 +828,7 @@ static void perf_event__process_sample(const struct perf_tool *tool, } } -if (al.sym ==NULL || !al.sym->idle) { +if (al.sym ==NULL || !symbol__is_idle (al.sym, al.map ?map__dso (al.map) :NULL , machine->env)) {struct hists *hists =evsel__hists (sample->evsel);struct hist_entry_iter iter = { .sample = sample,
tools/perf/tests/symbols.c +1 -1
@@ -125,7 +125,7 @@ static int test_dso(struct dso *dso)for (nd =rb_first_cached (dso__symbols (dso)); nd; nd =rb_next (nd)) { struct symbol *sym = rb_entry(nd, struct symbol, rb_node); -if (sym->type !=STT_FUNC && sym->type !=STT_GNU_IFUNC ) +if (symbol__type (sym) !=STT_FUNC &&symbol__type (sym) !=STT_GNU_IFUNC )continue ;/* Check for overlapping function symbols */
tools/perf/tests/vmlinux-kallsyms.c +1 -1
@@ -346,7 +346,7 @@ static int test__vmlinux_matches_kallsyms(struct test_suite *test __maybe_unused* such as __indirect_thunk_end. */ continue ; - }else if (is_ignored_symbol (sym->name, sym->type)) { + }else if (is_ignored_symbol (sym->name,symbol__type (sym))) {/* * Ignore hidden symbols, see scripts/kallsyms.c for the details */
tools/perf/ui/browsers/annotate.c +1 -1
@@ -1185,7 +1185,7 @@ int __hist_entry__tui_annotate(struct hist_entry *he, struct map_symbol *ms,if (dso__annotate_warned (dso))return -1 ; -if (not_annotated || !sym->annotate2) { +if (not_annotated || !symbol__is_annotate2 (sym)) { err =symbol__annotate2 (ms, evsel, &browser.arch);if (err) {annotate_browser__symbol_annotate_error (&browser, err);
tools/perf/ui/browsers/map.c +2 -2
@@ -32,8 +32,8 @@ static void map_browser__write(struct ui_browser *browser, void *nd, int row)ui_browser__set_percent_color (browser,0 , current_entry);ui_browser__printf (browser,"%*" PRIx64" %*" PRIx64" %c " , mb->addrlen, sym->start, mb->addrlen, sym->end, - sym->binding ==STB_GLOBAL ?'g' : - sym->binding ==STB_LOCAL ?'l' :'w' ); +symbol__binding (sym) ==STB_GLOBAL ?'g' : +symbol__binding (sym) ==STB_LOCAL ?'l' :'w' ); width = browser->width - ((mb->addrlen *2 ) +4 );if (width >0 )ui_browser__write_nstring (browser, sym->name, width);
tools/perf/util/annotate.c +3 -2
@@ -236,7 +236,8 @@ static int __symbol__inc_addr_samples(struct map_symbol *ms, h =annotated_source__histogram (src, evsel);if (h ==NULL ) {pr_debug ("%s(%d): ENOMEM! sym->name=%s, start=%#" PRIx64", addr=%#" PRIx64", end=%#" PRIx64", func: %d\n" , - __func__, __LINE__, sym->name, sym->start, addr, sym->end, sym->type ==STT_FUNC ); + __func__, __LINE__, sym->name, sym->start, addr, sym->end, +symbol__type (sym) ==STT_FUNC );return -ENOMEM ; }
@@ -2223,7 +2224,7 @@ int symbol__annotate2(struct map_symbol *ms, struct evsel *evsel,annotation__init_column_widths (notes, sym);annotation__update_column_widths (notes); - sym->annotate2 =1 ; +symbol__set_annotate2 (sym, true);return 0 ; }
tools/perf/util/auxtrace.c +3 -3
@@ -2694,7 +2694,7 @@ static bool dso_sym_match(struct symbol *sym, const char *name, int *cnt, {/* Same name, and global or the n'th found or any */ return !arch__compare_symbol_names (name, sym->name) && - ((!idx && sym->binding ==STB_GLOBAL ) || + ((!idx &&symbol__binding (sym) ==STB_GLOBAL ) || (idx >0 && ++*cnt == idx) || idx <0 ); }
@@ -2712,8 +2712,8 @@ static void print_duplicate_syms(struct dso *dso, const char *sym_name)if (dso_sym_match (sym, sym_name, &cnt,-1 )) {pr_err ("#%d\t0x%" PRIx64"\t%c\t%s\n" , ++cnt, sym->start, - sym->binding ==STB_GLOBAL ?'g' : - sym->binding ==STB_LOCAL ?'l' :'w' , +symbol__binding (sym) ==STB_GLOBAL ?'g' : +symbol__binding (sym) ==STB_LOCAL ?'l' :'w' , sym->name); near = true; }else if (near) {
tools/perf/util/callchain.c +2 -2
@@ -801,7 +801,7 @@ static enum match_result match_chain(struct callchain_cursor_node *node,* symbol start. Otherwise do a faster comparison based * on the symbol start address. */ -if (cnode->ms.sym->inlined || node->ms.sym->inlined) { +if (symbol__inlined (cnode->ms.sym) ||symbol__inlined (node->ms.sym)) { match =match_chain_strings (cnode->ms.sym->name, node->ms.sym->name);if (match !=MATCH_ERROR )
@@ -1245,7 +1245,7 @@ char *callchain_list__sym_name(struct callchain_list *cl,int printed;if (cl->ms.sym) { -const char *inlined = cl->ms.sym->inlined ?" (inlined)" :"" ; +const char *inlined =symbol__inlined (cl->ms.sym) ?" (inlined)" :"" ;if (show_srcline && cl->srcline) printed = scnprintf(bf, bfsize, "%s %s%s",
tools/perf/util/dlfilter.c +1 -1
@@ -56,7 +56,7 @@ static void al_to_d_al(struct addr_location *al, struct perf_dlfilter_al *d_al) d_al->symoff = al->addr -map__start (al->map) - sym->start; else d_al->symoff = 0; - d_al->sym_binding = sym->binding; + d_al->sym_binding =symbol__binding (sym); }else { d_al->sym =NULL ; d_al->sym_start =0 ;
tools/perf/util/evsel_fprintf.c +3 -3
@@ -146,7 +146,7 @@ int sample__fprintf_callchain(struct perf_sample *sample, int left_alignment, sym = node->ms.sym; map = node->ms.map; -if (sym && sym->ignore && print_skip_ignored) +if (sym &&symbol__ignore (sym) && print_skip_ignored) goto next; printed +=fprintf (fp,"%-*.*s" , left_alignment, left_alignment," " );
@@ -182,7 +182,7 @@ int sample__fprintf_callchain(struct perf_sample *sample, int left_alignment,addr_location__exit (&node_al); } -if (print_dso && (!sym || !sym->inlined)) +if (print_dso && (!sym || !symbol__inlined (sym))) printed +=map__fprintf_dsoname_dsoff (map, print_dsoff, addr, fp);if (print_srcline) {
@@ -192,7 +192,7 @@ int sample__fprintf_callchain(struct perf_sample *sample, int left_alignment, printed +=map__fprintf_srcline (map, addr,"\n " , fp); } -if (sym && sym->inlined) +if (sym &&symbol__inlined (sym)) printed +=fprintf (fp," (inlined)" );if (!print_oneline)
tools/perf/util/intel-pt.c +1 -1
@@ -3000,7 +3000,7 @@ static u64 intel_pt_switch_ip(struct intel_pt *pt, u64 *ptss_ip) start =dso__first_symbol (map__dso (map));for (sym = start; sym; sym =dso__next_symbol (sym)) { -if (sym->binding ==STB_GLOBAL && +if (symbol__binding (sym) ==STB_GLOBAL && !strcmp (sym->name,"__switch_to" )) { ip =map__unmap_ip (map, sym->start);if (ip >=map__start (map) && ip <map__end (map)) {
tools/perf/util/machine.c +1 -1
@@ -1095,7 +1095,7 @@ static u64 find_entry_trampoline(struct dso *dso)unsigned int i;for (; sym; sym =dso__next_symbol (sym)) { -if (sym->binding !=STB_GLOBAL ) +if (symbol__binding (sym) !=STB_GLOBAL )continue ;for (i =0 ; i <ARRAY_SIZE (syms); i++) {if (!strcmp (sym->name, syms[i]))
tools/perf/util/probe-event.c +2 -2
@@ -416,7 +416,7 @@ static int find_alternative_probe_point(struct debuginfo *dinfo,map__for_each_symbol_by_name (map, pp->function, sym, idx) {if (uprobes) { address = sym->start; -if (sym->type ==STT_GNU_IFUNC ) +if (symbol__type (sym) ==STT_GNU_IFUNC )pr_warning ("Warning: The probe function (%s) is a GNU indirect function.\n" "Consider identifying the final function used at run time and set the probe directly on that.\n" , pp->function);
@@ -3189,7 +3189,7 @@ static int find_probe_trace_events_from_map(struct perf_probe_event *pev,for (j =0 ; j < num_matched_functions; j++) { sym = syms[j]; -if (sym->type !=STT_FUNC ) +if (symbol__type (sym) !=STT_FUNC )continue ;/* There can be duplicated symbols in the map */
tools/perf/util/scripting-engines/trace-event-perl.c +1 -1
@@ -303,7 +303,7 @@ static SV *perl_process_callchain(struct perf_sample *sample, }if (!hv_stores (sym,"start" ,newSVuv (node->ms.sym->start)) || !hv_stores (sym,"end" ,newSVuv (node->ms.sym->end)) || - !hv_stores (sym,"binding" ,newSVuv (node->ms.sym->binding)) || + !hv_stores (sym,"binding" ,newSVuv (symbol__binding (node->ms.sym))) || !hv_stores (sym,"name" ,newSVpvn (node->ms.sym->name, node->ms.sym->namelen)) || !hv_stores (elem,"sym" ,newRV_noinc ((SV *)sym))) {
tools/perf/util/scripting-engines/trace-event-python.c +2 -2
@@ -436,7 +436,7 @@ static PyObject *python_process_callchain(struct perf_sample *sample,pydict_set_item_string_decref (pysym,"end" ,PyLong_FromUnsignedLongLong (node->ms.sym->end));pydict_set_item_string_decref (pysym,"binding" , -_PyLong_FromLong (node->ms.sym->binding)); +_PyLong_FromLong (symbol__binding (node->ms.sym)));pydict_set_item_string_decref (pysym,"name" ,_PyUnicode_FromStringAndSize (node->ms.sym->name, node->ms.sym->namelen));
@@ -1270,7 +1270,7 @@ static int python_export_symbol(struct db_export *dbe, struct symbol *sym,tuple_set_d64 (t,1 ,dso__db_id (dso));tuple_set_d64 (t,2 , sym->start);tuple_set_d64 (t,3 , sym->end); -tuple_set_s32 (t,4 , sym->binding); +tuple_set_s32 (t,4 ,symbol__binding (sym));tuple_set_string (t,5 , sym->name);call_object (tables->symbol_handler, t,"symbol_table" );
tools/perf/util/sort.c +4 -4
@@ -469,7 +469,7 @@ int64_t _sort__sym_cmp(struct symbol *sym_l, struct symbol *sym_r)if (sym_l == sym_r)return 0 ; -if (sym_l->inlined || sym_r->inlined) { +if (symbol__inlined (sym_l) ||symbol__inlined (sym_r)) {int ret =strcmp (sym_l->name, sym_r->name);if (ret)
@@ -536,7 +536,7 @@ static int _hist_entry__sym_snprintf(struct map_symbol *ms, ret +=repsep_snprintf (bf + ret, size - ret,"[%c] " , level);if (sym && map) { -if (sym->type ==STT_OBJECT ) { +if (symbol__type (sym) ==STT_OBJECT ) { ret +=repsep_snprintf (bf + ret, size - ret,"%s" , sym->name); ret +=repsep_snprintf (bf + ret, size - ret,"+0x%llx" , ip -map__unmap_ip (map, sym->start));
@@ -544,7 +544,7 @@ static int _hist_entry__sym_snprintf(struct map_symbol *ms, ret +=repsep_snprintf (bf + ret, size - ret,"%.*s" , width - ret, sym->name); -if (sym->inlined) +if (symbol__inlined (sym)) ret +=repsep_snprintf (bf + ret, size - ret," (inlined)" ); }
@@ -1483,7 +1483,7 @@ static int _hist_entry__addr_snprintf(struct map_symbol *ms, ret +=repsep_snprintf (bf + ret, size - ret,"[%c] " , level);if (sym && map) { -if (sym->type ==STT_OBJECT ) { +if (symbol__type (sym) ==STT_OBJECT ) { ret +=repsep_snprintf (bf + ret, size - ret,"%s" , sym->name); ret +=repsep_snprintf (bf + ret, size - ret,"+0x%llx" , ip -map__unmap_ip (map, sym->start));
tools/perf/util/srcline.c +5 -5
@@ -113,16 +113,16 @@ struct symbol *new_inline_sym(struct dso *dso,/* ensure that we don't alias an inlined symbol, which could * lead to double frees in inline_node__delete */ -assert (!base_sym->inlined); +assert (!symbol__inlined (base_sym)); }else {/* create a fake symbol for the inline frame */ inline_sym =symbol__new (base_sym ? base_sym->start :0 , base_sym ? (base_sym->end - base_sym->start) :0 , - base_sym ? base_sym->binding :0 , - base_sym ? base_sym->type :0 , + base_sym ?symbol__binding (base_sym) :0 , + base_sym ?symbol__type (base_sym) :0 , funcname);if (inline_sym) - inline_sym->inlined =1 ; +symbol__set_inlined (inline_sym, true); }free (demangled);
@@ -440,7 +440,7 @@ void inline_node__clear_frames(struct inline_node *node)list_del_init (&ilist->list);zfree_srcline (&ilist->srcline);/* only the inlined symbols are owned by the list */ -if (ilist->symbol && ilist->symbol->inlined) +if (ilist->symbol &&symbol__inlined (ilist->symbol))symbol__delete (ilist->symbol);free (ilist); }
tools/perf/util/symbol-elf.c +2 -1
@@ -350,7 +350,8 @@ static bool get_ifunc_name(Elf *elf, struct dso *dso, GElf_Ehdr *ehdr, sym =dso__find_symbol_nocache (dso, addr);/* Expecting the address to be an IFUNC or IFUNC alias */ -if (!sym || sym->start != addr || (sym->type !=STT_GNU_IFUNC && !sym->ifunc_alias)) +if (!sym || sym->start != addr || + (symbol__type (sym) !=STT_GNU_IFUNC && !symbol__ifunc_alias (sym)))return false;snprintf (buf, buf_sz,"%s@plt" , sym->name);
tools/perf/util/symbol.c +68 -16
151 lines not on this page · raw message
tools/perf/util/symbol.h +62 -14
100 lines not on this page · raw message
tools/perf/util/symbol_fprintf.c +2 -2
@@ -11,8 +11,8 @@ size_t symbol__fprintf(struct symbol *sym, FILE *fp) {return fprintf (fp," %" PRIx64"-%" PRIx64" %c %s\n" , sym->start, sym->end, - sym->binding ==STB_GLOBAL ?'g' : - sym->binding ==STB_LOCAL ?'l' :'w' , +symbol__binding (sym) ==STB_GLOBAL ?'g' : +symbol__binding (sym) ==STB_LOCAL ?'l' :'w' , sym->name); }
Signature · 1 line
2.54.0.823.g6e5bcc1fc9-goog
[email protected]
AI reviewRe: [PATCH v10 17/18] perf symbol: Add setters for bitfields sharing a byte to avoid concurrent update issues
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] The patch introduces a fatal compilation error in `builtin-top.c` due to a parameter mismatch in…
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch introduces a fatal compilation error in builtin-top.c due to a parameter mismatch in the symbol__is_idle function call. --
commit 62331f0aa0a35ba8f2806e0464aab89357756f5f
Author: Ian Rogers <[email protected]>
Subject: perf symbol: Add setters for bitfields sharing a byte to avoid concurrent update issues
This commit replaces direct bitfield accesses in struct symbol with atomic operations to prevent lost updates due to concurrency. Accessors and setters are introduced to safely read and update the symbol flags.
Quoted 4 lines
tools/perf/builtin-top.c +0
-0
[ ... ]
tools/perf/builtin-top.c static void perf_event__process_sample(const struct perf_tool *tool, · line 831
Quoted 6 lines
tools/perf/builtin-top.c +1
-1@@ -828,7 +828,7 @@ static void perf_event__process_sample(const struct perf_tool *tool, } } -if (al.sym ==NULL || !al.sym->idle) { +if (al.sym ==NULL || !symbol__is_idle (al.sym, al.map ?map__dso (al.map) :NULL , machine->env)) {
[Severity: Low]
Does this code cause a compilation error?
The function symbol__is_idle() is declared in tools/perf/util/symbol.h as taking only a single argument, but here it is being called with three arguments. It looks like changes from a later patch might have leaked into this commit.
Note that this build failure is fixed later in the series by commit 68dda82c5f09 (perf symbol: Lazily compute idle).
Quoted 7 lines
tools/perf/builtin-top.c +0
-0struct hists *hists =evsel__hists (sample->evsel);struct hist_entry_iter iter = {tools/perf/util/symbol.h +0
-0
[ ... ]
Quoted 1 line
tools/perf/util/symbol.h +0
-0@@ -92,6 +97,49 @@ struct symbol {
[ ... ]
Quoted 1 line
+bool
symbol__is_idle(const struct symbol *sym);
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=17
Ian Rogers
reviewerPATCH v10 18/18 perf symbol: Lazily compute idle
In reply to Ian RogersSwitch from an idle boolean to a helper symbol__is_idle function. In the function lazily compute whether a symbol is an idle function taking into consideration the kernel version and architecture of the machine. As symbols__insert no longer needs to know if a symbol is for the kernel, remove the argument.
To protect against drop-filtering of legitimate setup, online, or hotplug management functions (such as intel_idle_init), x86 matches are strictly constrained to exact known run-loops (intel_idle, intel_idle_irq, mwait_idle, mwait_idle_with_hints).
If the target environment OS release is unresolvable (such as on guest traces), default to treating psw_idle as idle to prevent false negatives and match legacy trace behavior safely.
This change is inspired by mailing list discussion, particularly from Thomas Richter <[email protected]> and Heiko Carstens <[email protected]>:
https://lore.kernel.org/lkml/[email protected]/
--- tools/perf/util/symbol-elf.c | 2 +- tools/perf/util/symbol.c | 141 +++++++++++++++++++++++------------ tools/perf/util/symbol.h | 8 +- 3 files changed, 99 insertions(+), 52 deletions(-)
tools/perf/util/symbol-elf.c +1 -1
@@ -1734,7 +1734,7 @@ dso__load_sym_internal(struct dso *dso, struct map *map, struct symsrc *syms_ss,arch__sym_update (f, &sym); -__symbols__insert (dso__symbols (curr_dso), f,dso__kernel (dso)); +__symbols__insert (dso__symbols (curr_dso), f); nr++; }dso__put (curr_dso);
tools/perf/util/symbol.c +95 -46
210 lines not on this page · raw message
tools/perf/util/symbol.h +3 -5
@@ -28,6 +28,7 @@ struct map;struct maps ;struct option ;struct build_id ; +struct perf_env ;/* * Ignore kernel mapping symbols, matching kernel is_mapping_symbol() logic.
@@ -75,7 +76,6 @@ enum symbol_idle_kind {#define SYMBOL_FLAG_INLINED (1 << 11)#define SYMBOL_FLAG_ANNOTATE2 (1 << 12)#define SYMBOL_FLAG_IFUNC_ALIAS (1 << 13) -/** * A symtab entry. When allocated this may be preceded by an annotation (see * symbol__annotation) and/or a browser_index (see symbol__browser_index).
@@ -133,7 +133,7 @@ static inline bool symbol__ifunc_alias(const struct symbol *sym) SYMBOL_FLAG_IFUNC_ALIAS) != 0; } -bool symbol__is_idle (const struct symbol *sym); +bool symbol__is_idle (struct symbol *sym,const struct dso *dso,struct perf_env *env);void symbol__set_ignore (struct symbol *sym,bool ignore);void symbol__set_annotate2 (struct symbol *sym,bool annotate2);
@@ -217,7 +217,6 @@ int filename__read_debuglink(const char *filename, char *debuglink, size_t size);bool filename__has_section (const char *filename,const char *sec); -struct perf_env ;int symbol__init (struct perf_env *env);void symbol__exit (void );void symbol__elf_init (void );
@@ -257,8 +256,7 @@ int dso__synthesize_plt_symbols(struct dso *dso, struct symsrc *ss);char *dso__demangle_sym (struct dso *dso,int kmodule,const char *elf_name); -void __symbols__insert (struct rb_root_cached *symbols,struct symbol *sym, -bool kernel); +void __symbols__insert (struct rb_root_cached *symbols,struct symbol *sym);void symbols__insert (struct rb_root_cached *symbols,struct symbol *sym);void symbols__fixup_duplicate (struct rb_root_cached *symbols);void symbols__fixup_end (struct rb_root_cached *symbols,bool is_kallsyms);
Signature · 1 line
2.54.0.823.g6e5bcc1fc9-goog
[email protected]
AI reviewRe: [PATCH v10 18/18] perf symbol: Lazily compute idle
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider: - [Medium] The fallback mechanism in `perf_env__os_release()` defeats the unpopulated guest trace…
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The fallback mechanism in perf_env__os_release() defeats the unpopulated guest trace safeguard, poisoning the guest environment with host data and causing false negatives for s390 psw_idle.
- [Medium] The e_machine prioritization bypasses the accurate DSO architecture, breaking cross-platform analysis for unpopulated traces.
--
commit 68dda82c5f091cdbfc3cd5e322eb9f9b77be4637
Author: Ian Rogers <[email protected]>
perf symbol: Lazily compute idle
This patch switches from an idle boolean to a helper symbol__is_idle function. It lazily computes whether a symbol is an idle function by taking the kernel version and architecture of the machine into consideration.
Quoted 3 lines
tools/perf/util/symbol.c +0
-0
[ ... ]
tools/perf/util/symbol.c int modules__parse(const char *filename, void *arg, · line 820
Quoted 2 lines
tools/perf/util/symbol.c +2
-0+ e_machine = env ?perf_env__e_machine (env,NULL ) : + (dso ?dso__e_machine ((struct dso *)dso,NULL ,NULL ) :EM_NONE );
[Severity: Medium]
When analyzing an unpopulated guest trace where the env is present but its arch field is empty, does perf_env__e_machine() fall back to uname() and return the host architecture?
Because the ternary operator prioritizes the environment, this short-circuits and bypasses the more accurate dso__e_machine() check which would read the actual target ELF binary. Could this break cross-platform analysis by evaluating a guest trace against the host's idle routines?
Quoted 2 lines
tools/perf/util/symbol.c +2
-0+ +if (e_machine ==EM_386 || e_machine ==EM_X86_64 ) {
[ ... ]
tools/perf/util/symbol.c int modules__parse(const char *filename, void *arg, · line 846
Quoted 9 lines
tools/perf/util/symbol.c +9
-0+if (e_machine ==EM_S390 &&strstarts (name,"psw_idle" )) { +int major =0 , minor =0 ; +const char *release = env ?perf_env__os_release (env) :NULL ; + +/* +* If we can't determine the release (e.g. unpopulated guest traces), +* default to idle. +*/ +if (!release) {
[Severity: Medium]
If the env os_release is unpopulated, does perf_env__os_release() fall back to calling uname() to get the host's OS release and cache it in the guest's environment?
If so, it appears the !release check becomes dead code for unpopulated guest traces. An old s390 guest trace analyzed on a modern host might incorrectly use the host's version, fail the version check below, and misclassify psw_idle as not idle. Can we prevent the host release from poisoning the guest environment here?
Quoted 11 lines
tools/perf/util/symbol.c +11
-0+symbol__set_idle (sym,/*idle=*/ true); +return true; + } + +/* Before v6.10, s390 used psw_idle. */ +if (sscanf (release,"%d.%d" , &major, &minor) ==2 && + (major <6 || (major ==6 && minor <10 ))) { +symbol__set_idle (sym,/*idle=*/ true); +return true; + } + }
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=18
Ian Rogers
reviewerv11 cover perf: Use e_machine and lazily compute symbols
In reply to Ian RogersAdd a helper to perf_env to compute the e_machine if it is EM_NONE. Derive the value from the arch string if available. Similarly derive the arch string from the ELF machine if available, for consistency. This means perf's arch (machine type) is no longer determined by uname but set to match that of the perf ELF executable.
Migrate code away from strcmp on env->arch to using the e_machine comparisons that are more accurate and not prone to uname and other naming differences. While cleaning this up, also clean up the capstone initialization code to cover more architectures and to set the big endian flag based on ELF header information.
Introduce a mutex in perf_env to safely protect lazy metadata setup, such as os_release or e_machine resolution, preventing concurrent initialization data races and memory leaks during multi-threaded profiling or symbol loading.
Switch the idle computation to the point of use and lazily compute it, rather than computing it for every symbol. The current only user is perf top. At the point of use the perf_env is available and this can be used to make sure the idle function computation correctly accounts for architecture-specific and kernel-version-specific patterns. To prevent concurrent updates to shared symbol bitfield flags, migrate bitfield variables in struct symbol to C11 atomic flags.
Ian Rogers (19):
perf env: Add perf_env__e_machine helper and use in perf_env__arch perf tests topology: Switch env->arch use to env->e_machine perf env, dso, thread: Add _endian variants for e_machine helpers perf capstone: Determine architecture from e_machine perf print_insn: Use e_machine for fallback IP length check perf symbol: Avoid use of machine__is
perf machine: Use perf_env e_machine rather than arch perf sample-raw: Use perf_env e_machine rather than arch perf sort: Use perf_env e_machine rather than arch
perf arch common: Use perf_env e_machine rather than arch perf header: In print_pmu_caps use perf_env e_machine perf c2c: Use perf_env e_machine rather than arch
perf lock-contention: Use perf_env e_machine rather than arch perf env: Refactor perf_env__arch_strerrno
perf env: Remove unused perf_env__raw_arch
perf env: Add mutex to protect lazy environment initialization perf env: Add helper to lazily compute the os_release perf symbol: Add setters for bitfields sharing a byte to avoid
concurrent update issues
perf symbol: Lazily compute idle
tools/perf/arch/common.c | 92 +++-- tools/perf/builtin-c2c.c | 40 +- tools/perf/builtin-inject.c | 10 +- tools/perf/builtin-kwork.c | 2 +- tools/perf/builtin-report.c | 2 +- tools/perf/builtin-sched.c | 4 +- tools/perf/builtin-top.c | 7 +- tools/perf/builtin-trace.c | 7 +- tools/perf/tests/symbols.c | 2 +- tools/perf/tests/topology.c | 8 +- tools/perf/tests/vmlinux-kallsyms.c | 2 +- tools/perf/trace/beauty/Build | 1 + tools/perf/trace/beauty/arch_errno_names.sh | 41 +- tools/perf/ui/browsers/annotate.c | 2 +- tools/perf/ui/browsers/map.c | 4 +- tools/perf/util/annotate.c | 5 +- tools/perf/util/auxtrace.c | 6 +- tools/perf/util/callchain.c | 4 +- tools/perf/util/capstone.c | 132 ++++--- tools/perf/util/data-convert-bt.c | 2 +- tools/perf/util/data-convert-json.c | 6 +- tools/perf/util/dlfilter.c | 2 +- tools/perf/util/dso.c | 19 +- tools/perf/util/dso.h | 14 +- tools/perf/util/env.c | 374 ++++++++++++++---- tools/perf/util/env.h | 14 +- tools/perf/util/evsel_fprintf.c | 6 +- tools/perf/util/header.c | 55 ++- tools/perf/util/intel-pt.c | 2 +- tools/perf/util/libdw.c | 2 +- tools/perf/util/lock-contention.c | 6 +- tools/perf/util/machine.c | 37 +- tools/perf/util/machine.h | 2 - tools/perf/util/print_insn.c | 23 +- tools/perf/util/print_insn.h | 2 + tools/perf/util/probe-event.c | 4 +- tools/perf/util/sample-raw.c | 21 +- tools/perf/util/sample-raw.h | 6 +- .../util/scripting-engines/trace-event-perl.c | 2 +- .../scripting-engines/trace-event-python.c | 4 +- tools/perf/util/session.c | 26 +- tools/perf/util/sort.c | 66 ++-- tools/perf/util/srcline.c | 10 +- tools/perf/util/symbol-elf.c | 5 +- tools/perf/util/symbol.c | 238 ++++++++--- tools/perf/util/symbol.h | 80 +++- tools/perf/util/symbol_fprintf.c | 4 +- tools/perf/util/thread.c | 58 ++- tools/perf/util/thread.h | 23 +- 49 files changed, 1064 insertions(+), 420 deletions(-)
Signature · 1 line
2.54.0.929.g9b7fa37559-goog
Ian Rogers
reviewerPATCH v11 1/19 perf env: Add perf_env__e_machine helper and use in perf_env__arch
Add a helper that lazily computes the e_machine and falls back to EM_HOST. Use the perf_env's arch to compute the e_machine if available, using a binary search for efficiency while handling duplicate rules.
Switch perf_env__arch to be derived from e_machine for consistency. To support 32-bit compat binaries on 64-bit hosts during dynamic local or live operations, unpopulated arch fallback paths query uname() at runtime to dynamically resolve the correct host e_machine, safely preventing bitness misclassification regressions.
Update session and header to use the helper to safely record e_machine and flags without forcing premature thread scanning.
--- tools/perf/util/env.c | 286 ++++++++++++++++++++++++++++++++------ tools/perf/util/env.h | 2 + tools/perf/util/header.c | 32 +++-- tools/perf/util/session.c | 26 ++-- 4 files changed, 282 insertions(+), 64 deletions(-)
tools/perf/util/env.c +243 -43
@@ -1,10 +1,12 @@// SPDX-License-Identifier: GPL-2.0 #include "cpumap.h" +#include "dwarf-regs.h" #include "debug.h" #include "env.h" #include "util/header.h" #include "util/rwsem.h" #include <linux/compiler.h> +#include <linux/kernel.h> #include <linux/ctype.h> #include <linux/rbtree.h> #include <linux/string.h>
@@ -309,15 +311,27 @@ void perf_env__init(struct perf_env *env)static void perf_env__init_kernel_mode (struct perf_env *env) { -const char *arch =perf_env__raw_arch (env); +const char *arch = env->arch; -if (!strncmp (arch,"x86_64" ,6 ) || !strncmp (arch,"aarch64" ,7 ) || - !strncmp (arch,"arm64" ,5 ) || !strncmp (arch,"mips64" ,6 ) || - !strncmp (arch,"parisc64" ,8 ) || !strncmp (arch,"riscv64" ,7 ) || - !strncmp (arch,"s390x" ,5 ) || !strncmp (arch,"sparc64" ,7 )) - env->kernel_is_64_bit =1 ; -else - env->kernel_is_64_bit =0 ; +if (!arch) { +static struct utsname uts = { .machine[0 ] ='\0' , }; + +if (uts.machine[0 ] =='\0' ) +uname (&uts); +if (uts.machine[0 ] !='\0' ) + arch = uts.machine; + } + +if (arch) { +if (strstr (arch,"64" ) ||strstr (arch,"s390x" )) + env->kernel_is_64_bit =1 ; +else + env->kernel_is_64_bit =0 ; +return ; + } + +/* Fallback if completely unresolvable (assume host-bitness) */ + env->kernel_is_64_bit = (sizeof (void *) ==8 ) ?1 :0 ; }int perf_env__kernel_is_64_bit (struct perf_env *env)
@@ -588,51 +602,237 @@ void cpu_cache_level__free(struct cpu_cache_level *cache)zfree (&cache->size); } +struct arch_to_e_machine { +const char *prefix; +uint16_t e_machine; +}; +/* -* Return architecture name in a normalized form. -* The conversion logic comes from the Makefile. +* A mapping from an arch prefix string to an ELF machine that can be used in a +* bsearch. Some arch prefixes are shared an need additional processing as +* marked next to the architecture. The prefixes handle both perf's architecture +* naming and those from uname. */ -static const char *normalize_arch (char *arch) -{ -if (!strcmp (arch,"x86_64" )) -return "x86" ; -if (arch[0 ] =='i' && arch[2 ] =='8' && arch[3 ] =='6' ) -return "x86" ; -if (!strcmp (arch,"sun4u" ) || !strncmp (arch,"sparc" ,5 )) -return "sparc" ; -if (!strncmp (arch,"aarch64" ,7 ) || !strncmp (arch,"arm64" ,5 )) -return "arm64" ; -if (!strncmp (arch,"arm" ,3 ) || !strcmp (arch,"sa110" )) -return "arm" ; -if (!strncmp (arch,"s390" ,4 )) -return "s390" ; -if (!strncmp (arch,"parisc" ,6 )) -return "parisc" ; -if (!strncmp (arch,"powerpc" ,7 ) || !strncmp (arch,"ppc" ,3 )) -return "powerpc" ; -if (!strncmp (arch,"mips" ,4 )) -return "mips" ; -if (!strncmp (arch,"sh" ,2 ) &&isdigit (arch[2 ])) -return "sh" ; -if (!strncmp (arch,"loongarch" ,9 )) -return "loongarch" ; +static const struct arch_to_e_machine prefix_to_e_machine[] = { + {"aarch64" ,EM_AARCH64 }, + {"alpha" ,EM_ALPHA }, + {"arc" ,EM_ARC }, + {"arm" ,EM_ARM },/* Check also for EM_AARCH64. */ + {"avr" ,EM_AVR },/* Check also for EM_AVR32. */ + {"bfin" ,EM_BLACKFIN }, + {"blackfin" ,EM_BLACKFIN }, + {"cris" ,EM_CRIS }, + {"csky" ,EM_CSKY }, + {"hppa" ,EM_PARISC }, + {"i386" ,EM_386 }, + {"i486" ,EM_386 }, + {"i586" ,EM_386 }, + {"i686" ,EM_386 }, + {"loongarch" ,EM_LOONGARCH }, + {"m32r" ,EM_M32R }, + {"m68k" ,EM_68K }, + {"microblaze" ,EM_MICROBLAZE }, + {"mips" ,EM_MIPS }, + {"msp430" ,EM_MSP430 }, + {"parisc" ,EM_PARISC }, + {"powerpc" ,EM_PPC },/* Check also for EM_PPC64. */ + {"ppc" ,EM_PPC },/* Check also for EM_PPC64. */ + {"riscv" ,EM_RISCV }, + {"s390" ,EM_S390 }, + {"sa110" ,EM_ARM }, + {"sh" ,EM_SH }, + {"sparc" ,EM_SPARC },/* Check also for EM_SPARCV9. */ + {"sun4u" ,EM_SPARC }, + {"x86" ,EM_X86_64 },/* Check also for EM_386. */ + {"xtensa" ,EM_XTENSA }, +}; + +static int compare_prefix (const void *key,const void *element) +{ +const char *search_key = key; +const struct arch_to_e_machine *map_element = element; +size_t prefix_len =strlen (map_element->prefix); -return arch; +return strncmp (search_key, map_element->prefix, prefix_len); +} + +static uint16_t perf_arch_to_e_machine (const char *perf_arch,int is_64_bit) +{ +/* Binary search for a matching prefix. */ +const struct arch_to_e_machine *result; + +if (!perf_arch) +return EM_HOST ; + + result =bsearch (perf_arch, + prefix_to_e_machine,ARRAY_SIZE (prefix_to_e_machine), +sizeof (prefix_to_e_machine[0 ]), + compare_prefix); + +if (!result) { +pr_debug ("Unknown perf arch for ELF machine mapping: %s\n" , perf_arch); +return EM_NONE ; + } + +/* +* Handle conflicting prefixes. If the is_64_bit is unknown (-1) then +* assume 64-bit. We can't use perf_env__kernel_is_64_bit as that +* depends on the arch string. +*/ +switch (result->e_machine) { +case EM_ARM : +return !strcmp (perf_arch,"arm64" ) || !strcmp (perf_arch,"aarch64" ) + ?EM_AARCH64 :EM_ARM ; +case EM_AVR : +return !strcmp (perf_arch,"avr32" ) ?EM_AVR32 :EM_AVR ; +case EM_PPC : +if (is_64_bit ==1 ) +return EM_PPC64 ; +if (is_64_bit ==0 ) +return EM_PPC ; +return strstarts (perf_arch,"ppc64" ) ?EM_PPC64 :EM_PPC ; +case EM_SPARC : +if (is_64_bit ==1 ) +return EM_SPARCV9 ; +if (is_64_bit ==0 ) +return EM_SPARC ; +return !strcmp (perf_arch,"sparc64" ) || !strcmp (perf_arch,"sun4u" ) + ?EM_SPARCV9 :EM_SPARC ; +case EM_X86_64 : +if (is_64_bit ==1 ) +return EM_X86_64 ; +if (is_64_bit ==0 ) +return EM_386 ; +return !strcmp (perf_arch,"x86_64" ) || !strcmp (perf_arch,"x86" ) + ?EM_X86_64 :EM_386 ; +default : +return result->e_machine; + } +} + +static const char *e_machine_to_perf_arch (uint16_t e_machine) +{ +/* +* Table for if either the perf arch string differs from uname or there +* are >1 ELF machine with the prefix. +*/ +static const struct arch_to_e_machine extras[] = { + {"arm64" ,EM_AARCH64 }, + {"avr32" ,EM_AVR32 }, + {"powerpc" ,EM_PPC }, + {"powerpc" ,EM_PPC64 }, + {"sparc" ,EM_SPARCV9 }, + {"x86" ,EM_386 }, + {"x86" ,EM_X86_64 }, + {"none" ,EM_NONE }, + }; + +for (size_t i =0 ; i <ARRAY_SIZE (extras); i++) { +if (extras[i].e_machine == e_machine) +return extras[i].prefix; + } + +for (size_t i =0 ; i <ARRAY_SIZE (prefix_to_e_machine); i++) { +if (prefix_to_e_machine[i].e_machine == e_machine) +return prefix_to_e_machine[i].prefix; + + } +return "unknown" ; +} + +uint16_t perf_env__e_machine_nocache (struct perf_env *env,uint32_t *e_flags) +{ +uint16_t e_machine =EM_NONE ; +const char *arch =NULL ; +int is_64_bit =-1 ; + +if (e_flags) + *e_flags =0 ; + +if (env) { + arch = env->arch; + is_64_bit = env->kernel_is_64_bit; + } + +if (!arch) { +static struct utsname uts = { .machine[0 ] ='\0' , }; + +if (uts.machine[0 ] =='\0' ) +uname (&uts); +if (uts.machine[0 ] !='\0' ) + arch = uts.machine; + } + + e_machine =perf_arch_to_e_machine (arch, is_64_bit); + +if (e_flags) + *e_flags = (e_machine ==EM_HOST ) ?EF_HOST :0 ; + +return e_machine; +} + +uint16_t perf_env__e_machine (struct perf_env *env,uint32_t *e_flags) +{ +uint16_t e_machine; +uint32_t local_e_flags =0 ; + +if (env && env->e_machine !=EM_NONE ) { +if (e_flags) + *e_flags = env->e_flags; + +return env->e_machine; + } + e_machine =perf_env__e_machine_nocache (env, &local_e_flags); +/* +* Only cache the e_machine in perf_env if env->arch is not NULL. +* If env->arch is NULL, the e_machine is just a fallback to EM_HOST. +* Caching it permanently would prevent dynamic, more accurate +* thread-based session e_machine scanning later in +* perf_session__e_machine(). +*/ +if (env && env->arch) { + env->e_machine = e_machine; + env->e_flags = local_e_flags; + } +if (e_flags) + *e_flags = local_e_flags; + +return e_machine; }const char *perf_env__arch (struct perf_env *env) { -char *arch_name; +uint16_t e_machine; +const char *arch; -if (!env || !env->arch) {/* Assume local operation */ +if (!env) {static struct utsname uts = { .machine[0 ] ='\0' , }; -if (uts.machine[0 ] =='\0' &&uname (&uts) <0 ) -return NULL ; - arch_name = uts.machine; - }else - arch_name = env->arch; +uint16_t host_e_machine; -return normalize_arch (arch_name); +if (uts.machine[0 ] =='\0' ) +uname (&uts); +if (uts.machine[0 ] !='\0' ) { + host_e_machine =perf_arch_to_e_machine (uts.machine,-1 ); +return e_machine_to_perf_arch (host_e_machine); + } +return e_machine_to_perf_arch (EM_HOST ); + } + +/* +* Lazily compute/allocate arch. The e_machine may have been +* read from a data file and so may not be EM_HOST. +*/ + e_machine =perf_env__e_machine (env,/*e_flags=*/ NULL ); + arch =e_machine_to_perf_arch (e_machine); + +if (e_machine ==EM_RISCV &&perf_env__kernel_is_64_bit (env) ==1 ) + arch ="riscv64" ; +else if (e_machine ==EM_MIPS &&perf_env__kernel_is_64_bit (env) ==1 ) + arch ="mips64" ; +else if (e_machine ==EM_PARISC &&perf_env__kernel_is_64_bit (env) ==1 ) + arch ="parisc64" ; + +return arch; }const char *perf_env__arch_strerrno (struct perf_env *env__maybe_unused ,int err__maybe_unused )
tools/perf/util/env.h +2 -0
@@ -187,6 +187,8 @@ int perf_env__read_cpu_topology_map(struct perf_env *env);void cpu_cache_level__free (struct cpu_cache_level *cache); +uint16_t perf_env__e_machine_nocache (struct perf_env *env,uint32_t *e_flags); +uint16_t perf_env__e_machine (struct perf_env *env,uint32_t *e_flags);const char *perf_env__arch (struct perf_env *env);const char *perf_env__arch_strerrno (struct perf_env *env,int err);arch_syscalls__strerrno_t *arch_syscalls__strerrno_function (const char *arch);
tools/perf/util/header.c +22 -10
@@ -441,21 +441,25 @@ static int write_osrelease(struct feat_fd *ff,return do_write_string (ff, uts.release); } -static int write_arch (struct feat_fd *ff, -struct evlist *evlist__maybe_unused ) +static int write_arch (struct feat_fd *ff,struct evlist *evlist) {struct utsname uts; -int ret; +const char *arch =NULL ; - ret =uname (&uts); -if (ret <0 ) -return -1 ; +if (evlist->session) + arch =perf_env__arch (perf_session__env (evlist->session)); + +if (!arch) { +int ret =uname (&uts); -return do_write_string (ff, uts.machine); +if (ret <0 ) +return -1 ; + arch = uts.machine; + } +return do_write_string (ff, arch); } -static int write_e_machine (struct feat_fd *ff, -struct evlist *evlist__maybe_unused ) +static int write_e_machine (struct feat_fd *ff,struct evlist *evlist) {/* e_machine expanded from 16 to 32-bits for alignment. */ uint32_t e_flags;
@@ -2841,10 +2845,18 @@ static int process_##__feat(struct feat_fd *ff, void *data __maybe_unused) \FEAT_PROCESS_STR_FUN (hostname, hostname);FEAT_PROCESS_STR_FUN (osrelease, os_release);FEAT_PROCESS_STR_FUN (version, version); -FEAT_PROCESS_STR_FUN (arch, arch);FEAT_PROCESS_STR_FUN (cpudesc, cpu_desc);FEAT_PROCESS_STR_FUN (cpuid, cpuid); +static int process_arch (struct feat_fd *ff,void *data__maybe_unused ) +{ +free (ff->ph->env.arch); + ff->ph->env.arch =do_read_string (ff); +if (!ff->ph->env.arch) +return -ENOMEM ; +return 0 ; +} +static int process_e_machine (struct feat_fd *ff,void *data__maybe_unused ) {int ret;
tools/perf/util/session.c +15 -11
@@ -4080,14 +4080,19 @@ uint16_t perf_session__e_machine(struct perf_session *session, uint32_t *e_flagsreturn EM_HOST ; } +/* +* Is the env caching an e_machine? If not we want to compute from the +* more accurate threads. +*/ env =perf_session__env (session); -if (env && env->e_machine !=EM_NONE ) { -if (e_flags) - *e_flags = env->e_flags; - -return env->e_machine; - } +if (env && env->e_machine !=EM_NONE ) +return perf_env__e_machine (env, e_flags); +/* +* Compute from threads, note this is more accurate than +* perf_env__e_machine that falls back on EM_HOST and doesn't consider +* mixed 32-bit and 64-bit threads. +*/ machines__for_each_thread (&session->machines, perf_session__e_machine_cb, &args);
@@ -4105,10 +4110,9 @@ uint16_t perf_session__e_machine(struct perf_session *session, uint32_t *e_flags/* * Couldn't determine from the perf_env or current set of -* threads. Default to the host. +* threads. Potentially use logic that uses the arch string otherwise +* default to the host. Don't cache in the perf_env in case later +* threads indicate a better ELF machine type. */ -if (e_flags) - *e_flags =EF_HOST ; - -return EM_HOST ; +return perf_env__e_machine_nocache (env, e_flags); }
Signature · 1 line
2.54.0.929.g9b7fa37559-goog
[email protected]
AI reviewRe: [PATCH v11 01/19] perf env: Add perf_env__e_machine helper and use in perf_env__arch
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider: - [High] Writing the normalized architecture string instead of the raw host string to HEADER_ARCH breaks…
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [High] Writing the normalized architecture string instead of the raw host string to HEADER_ARCH breaks 64-bit kernel detection.
- [High] Lockless reads and writes of env->e_machine and env->e_flags can cause data tearing and incorrect flag values. --
commit c84846b53351380843f7a9f4a25aa8273e1fb3a5
Author: Ian Rogers <[email protected]>
perf env: Add perf_env__e_machine helper and use in perf_env__arch
Add a helper that lazily computes the e_machine and falls back to EM_HOST. Use the perf_env's arch to compute the e_machine if available, using a binary search for efficiency while handling duplicate rules.
Quoted 4 lines
tools/perf/util/env.c +0
-0
[ ... ]
Quoted 1 line
tools/perf/util/env.c +0
-0@@ -588,51 +602,237 @@ void cpu_cache_level__free(struct cpu_cache_level *cache)
[ ... ]
Quoted 13 lines
tools/perf/util/env.c +13
-0+uint16_t perf_env__e_machine (struct perf_env *env,uint32_t *e_flags) +{ +uint16_t e_machine; +uint32_t local_e_flags =0 ; + +if (env && env->e_machine !=EM_NONE ) { +if (e_flags) + *e_flags = env->e_flags; + +return env->e_machine; + } + e_machine =perf_env__e_machine_nocache (env, &local_e_flags); +/*
tools/perf/util/env.c void cpu_cache_level__free(struct cpu_cache_level *cache) · line 796
Quoted 10 lines
tools/perf/util/env.c +10
-0+* Only cache the e_machine in perf_env if env->arch is not NULL. +* If env->arch is NULL, the e_machine is just a fallback to EM_HOST. +* Caching it permanently would prevent dynamic, more accurate +* thread-based session e_machine scanning later in +* perf_session__e_machine(). +*/ +if (env && env->arch) { + env->e_machine = e_machine; + env->e_flags = local_e_flags; + }
[Severity: High]
Can concurrent lockless updates to env->e_machine and env->e_flags cause a race condition?
If Thread A sets env->e_machine and is about to set env->e_flags, and Thread B concurrently observes env->e_machine != EM_NONE in this function, Thread B might read a stale or zero value for env->e_flags before Thread A finishes writing it.
A similar unprotected update happens in perf_session__e_machine().
This appears to be fixed later in the series by the commit "perf env: Add mutex to protect lazy environment initialization", but could this intermediate state cause problems with per-thread event parsing?
Quoted 22 lines
tools/perf/util/header.c +5
-6@@ -441,21 +441,25 @@ static int write_osrelease(struct feat_fd *ff,return do_write_string (ff, uts.release); } -static int write_arch (struct feat_fd *ff, -struct evlist *evlist__maybe_unused ) +static int write_arch (struct feat_fd *ff,struct evlist *evlist) {struct utsname uts; -int ret; +const char *arch =NULL ; - ret =uname (&uts); -if (ret <0 ) -return -1 ; +if (evlist->session) + arch =perf_env__arch (perf_session__env (evlist->session)); +
tools/perf/util/header.c static int write_osrelease(struct feat_fd *ff, · line 460
Quoted 10 lines
tools/perf/util/header.c +7
-1+if (!arch) { +int ret =uname (&uts); -return do_write_string (ff, uts.machine); +if (ret <0 ) +return -1 ; + arch = uts.machine; + } +return do_write_string (ff, arch); }
[Severity: High]
Does this code inadvertently break 64-bit kernel detection?
Since write_arch() now uses perf_env__arch() which returns a normalized arch string (e.g., "x86" or "s390"), it writes that normalized string to HEADER_ARCH in the perf.data file.
Later, process_arch() reads this back into env->arch. Then, perf_env__init_kernel_mode() checks if env->arch contains "64" or "s390x":
tools/perf/util/env.c:perf_env__init_kernel_mode() {
...
if (arch) {
if (strstr(arch, "64") || strstr(arch, "s390x"))
env->kernel_is_64_bit = 1;...
Because "x86" and "s390" lack these substrings, won't this misclassify 64-bit kernels as 32-bit and break things like VDSO unwinding or BPF contexts?
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
Ian Rogers
reviewerPATCH v11 2/19 perf tests topology: Switch env->arch use to env->e_machine
In reply to Ian RogersSome arch string comparisons weren't normalized. Avoid potential issues with normalized names vs uname values by swtiching to using the e_machine.
--- tools/perf/tests/topology.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
tools/perf/tests/topology.c +6 -2
@@ -11,6 +11,7 @@#include "pmus.h" #include "target.h" #include <linux/err.h> +#include "dwarf-regs.h" #define TEMPL "/tmp/perf-test-XXXXXX"#define DATA_SIZE 10
@@ -74,6 +75,7 @@ static int check_cpu_topology(char *path, struct perf_cpu_map *map)struct aggr_cpu_id id;struct perf_cpu cpu;struct perf_env *env; +uint16_t e_machine; session =perf_session__new (&data,NULL );TEST_ASSERT_VAL ("can't get session" , !IS_ERR (session));
@@ -101,7 +103,9 @@ static int check_cpu_topology(char *path, struct perf_cpu_map *map)* condition is true (see do_core_id_test in header.c). So always * run this test on those platforms. */ -if (!env->cpu &&strncmp (env->arch,"s390" ,4 ) &&strncmp (env->arch,"aarch64" ,7 )) + e_machine =perf_env__e_machine (env,NULL ); + +if (!env->cpu && e_machine !=EM_S390 && e_machine !=EM_AARCH64 )return TEST_SKIP ;/*
@@ -110,7 +114,7 @@ static int check_cpu_topology(char *path, struct perf_cpu_map *map)* physical_package_id will be set to -1. Hence skip this * test if physical_package_id returns -1 for cpu from perf_cpu_map. */ -if (!strncmp (env->arch,"ppc64le" ,7 )) { +if (e_machine ==EM_PPC64 ) {if (cpu__get_socket_id (perf_cpu_map__cpu (map,0 )) ==-1 )return TEST_SKIP ; }
Signature · 1 line
2.54.0.929.g9b7fa37559-goog
Ian Rogers
reviewerPATCH v11 3/19 perf env, dso, thread: Add _endian variants for e_machine helpers
In reply to Ian RogersAdd perf_arch_is_big_endian(), dso__read_e_machine_endian(), dso__e_machine_endian(), and thread__e_machine_endian() to support bi-endianness and cross-architecture analysis without breaking the existing API.
These helpers allow querying the absolute endianness of a DSO or thread, which is required for tools like Capstone that need to set the correct disassembly mode.
--- tools/perf/util/dso.c | 19 ++++++++----- tools/perf/util/dso.h | 14 ++++++++-- tools/perf/util/env.c | 16 +++++++++++ tools/perf/util/env.h | 1 + tools/perf/util/thread.c | 58 ++++++++++++++++++++++++++++++---------- tools/perf/util/thread.h | 23 +++++++++++++++- 6 files changed, 108 insertions(+), 23 deletions(-)
tools/perf/util/dso.c +13 -6
@@ -1220,7 +1220,8 @@ static enum dso_swap_type dso_swap_type__from_elf_data(unsigned char eidata) }/* Reads e_machine from fd, optionally caching data in dso. */ -uint16_t dso__read_e_machine (struct dso *optional_dso,int fd,uint32_t *e_flags) +uint16_t dso__read_e_machine_endian (struct dso *optional_dso,int fd,uint32_t *e_flags, +bool *is_big_endian) {uint16_t e_machine =EM_NONE ;unsigned char e_ident[EI_NIDENT ];
@@ -1250,6 +1251,9 @@ uint16_t dso__read_e_machine(struct dso *optional_dso, int fd, uint32_t *e_flagsif (swap_type ==DSO_SWAP__UNSET )return EM_NONE ;// Bad ELF data encoding. +if (is_big_endian) + *is_big_endian = (e_ident[EI_DATA ] ==ELFDATA2MSB ); +/* Cache the need for swapping. */ if (optional_dso) { assert(dso__needs_swap(optional_dso) == DSO_SWAP__UNSET ||
@@ -1288,7 +1292,8 @@ uint16_t dso__read_e_machine(struct dso *optional_dso, int fd, uint32_t *e_flagsreturn e_machine; } -uint16_t dso__e_machine (struct dso *dso,struct machine *machine,uint32_t *e_flags) +uint16_t dso__e_machine_endian (struct dso *dso,struct machine *machine,uint32_t *e_flags, +bool *is_big_endian) {uint16_t e_machine =EM_NONE ;int fd;
@@ -1308,9 +1313,11 @@ uint16_t dso__e_machine(struct dso *dso, struct machine *machine, uint32_t *e_flcase DSO_BINARY_TYPE__BPF_IMAGE :case DSO_BINARY_TYPE__OOL :case DSO_BINARY_TYPE__JAVA_JIT : -if (e_flags) - *e_flags =EF_HOST ; -return EM_HOST ; +if (is_big_endian) { + *is_big_endian =perf_arch_is_big_endian ( + machine && machine->env ?perf_env__arch (machine->env) :NULL ); + } +return perf_env__e_machine (machine ? machine->env :NULL , e_flags);case DSO_BINARY_TYPE__DEBUGLINK :case DSO_BINARY_TYPE__BUILD_ID_CACHE :case DSO_BINARY_TYPE__BUILD_ID_CACHE_DEBUGINFO :
@@ -1338,7 +1345,7 @@ uint16_t dso__e_machine(struct dso *dso, struct machine *machine, uint32_t *e_fltry_to_open_dso (dso, machine); fd =dso__data (dso)->fd;if (fd >=0 ) - e_machine =dso__read_e_machine (dso, fd, e_flags); + e_machine =dso__read_e_machine_endian (dso, fd, e_flags, is_big_endian);else if (e_flags) *e_flags =0 ;
tools/perf/util/dso.h +12 -2
@@ -866,8 +866,18 @@ int dso__data_file_size(struct dso *dso, struct machine *machine);off_t dso__data_size (struct dso *dso,struct machine *machine);ssize_t dso__data_read_offset (struct dso *dso,struct machine *machine,u64 offset,u8 *data,ssize_t size); -uint16_t dso__read_e_machine (struct dso *optional_dso,int fd,uint32_t *e_flags); -uint16_t dso__e_machine (struct dso *dso,struct machine *machine,uint32_t *e_flags); +uint16_t dso__read_e_machine_endian (struct dso *optional_dso,int fd,uint32_t *e_flags, +bool *is_big_endian); +static inline uint16_t dso__read_e_machine (struct dso *optional_dso,int fd,uint32_t *e_flags) +{ +return dso__read_e_machine_endian (optional_dso, fd, e_flags,NULL ); +} +uint16_t dso__e_machine_endian (struct dso *dso,struct machine *machine,uint32_t *e_flags, +bool *is_big_endian); +static inline uint16_t dso__e_machine (struct dso *dso,struct machine *machine,uint32_t *e_flags) +{ +return dso__e_machine_endian (dso, machine, e_flags,NULL ); +}ssize_t dso__data_read_addr (struct dso *dso,struct map *map,struct machine *machine,u64 addr,u8 *data,ssize_t size);
tools/perf/util/env.c +16 -0
@@ -342,6 +342,22 @@ int perf_env__kernel_is_64_bit(struct perf_env *env)return env->kernel_is_64_bit; } +bool perf_arch_is_big_endian (const char *arch) +{ +if (!arch) +return __BYTE_ORDER__ == __ORDER_BIG_ENDIAN__; + +if (str_ends_with (arch,"_be" ) || !strcmp (arch,"sparc" ) || !strcmp (arch,"sparc64" ) || + !strcmp (arch,"s390" ) || !strcmp (arch,"s390x" ) || !strcmp (arch,"powerpc" ) || + !strcmp (arch,"ppc" ) || !strcmp (arch,"ppc64" ) || + !strcmp (arch,"mips" ) || !strcmp (arch,"mips64" ) || !strcmp (arch,"parisc" ) || + !strcmp (arch,"parisc64" ) || !strcmp (arch,"m68k" ) || + !strcmp (arch,"armeb" ) || !strcmp (arch,"mipseb" ) || !strcmp (arch,"mips64eb" )) +return true; + +return false; +} +int perf_env__set_cmdline (struct perf_env *env,int argc,const char *argv[]) {int i;
tools/perf/util/env.h +1 -0
@@ -175,6 +175,7 @@ void free_cpu_domain_info(struct cpu_domain_map **cd_map, u32 schedstat_version,void perf_env__exit (struct perf_env *env);int perf_env__kernel_is_64_bit (struct perf_env *env); +bool perf_arch_is_big_endian (const char *arch);int perf_env__set_cmdline (struct perf_env *env,int argc,const char *argv[]);
tools/perf/util/thread.c +44 -14
123 lines not on this page · raw message
tools/perf/util/thread.h +22 -1
@@ -69,6 +69,11 @@ DECLARE_RC_STRUCT(thread) {* computed. */ uint16_t e_machine; +/** +* @e_is_big_endian: True if the ELF architecture of the thread is big endian. +* Valid if e_machine != EM_NONE. +*/ +bool e_is_big_endian;/* LBR call stack stitch */ bool lbr_stitch_enable;struct lbr_stitch *lbr_stitch;
@@ -311,7 +316,13 @@ static inline void thread__set_filter_entry_depth(struct thread *thread, int depRC_CHK_ACCESS (thread)->filter_entry_depth = depth; } -uint16_t thread__e_machine (struct thread *thread,struct machine *machine,uint32_t *e_flags); +uint16_t thread__e_machine_endian (struct thread *thread,struct machine *machine,uint32_t *e_flags, +bool *is_big_endian); +static inline uint16_t thread__e_machine (struct thread *thread,struct machine *machine, +uint32_t *e_flags) +{ +return thread__e_machine_endian (thread, machine, e_flags,NULL ); +}static inline void thread__set_e_machine (struct thread *thread,uint16_t e_machine) {
@@ -328,6 +339,16 @@ static inline void thread__set_e_flags(struct thread *thread, uint32_t e_flags)RC_CHK_ACCESS (thread)->e_flags = e_flags; } +static inline bool thread__e_is_big_endian (const struct thread *thread) +{ +return RC_CHK_ACCESS (thread)->e_is_big_endian; +} + +static inline void thread__set_e_is_big_endian (struct thread *thread,bool is_big_endian) +{ +RC_CHK_ACCESS (thread)->e_is_big_endian = is_big_endian; +} +static inline bool thread__lbr_stitch_enable (const struct thread *thread) {
Signature · 1 line
2.54.0.929.g9b7fa37559-goog
[email protected]
AI reviewRe: [PATCH v11 03/19] perf env, dso, thread: Add _endian variants for e_machine helpers
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] Lockless double-checked initialization of `thread->e_is_big_endian` lacks necessary memory…
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Lockless double-checked initialization of thread->e_is_big_endian lacks necessary memory barriers. --
commit 0695e7d47980d268e68f0873d5d1c5a0e48b59c7
Author: Ian Rogers <[email protected]>
perf env, dso, thread: Add _endian variants for e_machine helpers
This commit adds endian-aware variants of the e_machine helpers, including dso__read_e_machine_endian and thread__e_machine_endian. It allows querying the absolute endianness of a DSO or thread to support cross-architecture analysis in tools like Capstone.
Quoted 4 lines
tools/perf/util/thread.c +0
-0
[ ... ]
Quoted 1 line
tools/perf/util/thread.c +0
-0@@ -458,24 +461,38 @@ static int thread__e_machine_callback(struct map *map, void *_args)
[ ... ]
Quoted 7 lines
tools/perf/util/thread.c +3
-2-uint16_t thread__e_machine (struct thread *thread,struct machine *machine,uint32_t *e_flags) +uint16_t thread__e_machine_endian (struct thread *thread,struct machine *machine,uint32_t *e_flags, +bool *is_big_endian) {pid_t tid, pid; -uint16_t e_machine =RC_CHK_ACCESS (thread)->e_machine; +uint16_t e_machine;
[ ... ]
tools/perf/util/thread.c static int thread__e_machine_callback(struct map *map, void *_args) · line 495
Quoted 11 lines
tools/perf/util/thread.c +7
-0+ e_machine =RC_CHK_ACCESS (thread)->e_machine; + args.machine = machine; + args.e_flags =0 ; + args.e_machine =EM_NONE ; + args.is_big_endian = false;if (e_machine !=EM_NONE ) {if (e_flags) *e_flags =thread__e_flags (thread); +if (is_big_endian) + *is_big_endian =thread__e_is_big_endian (thread);
[Severity: Medium]
Since e_machine acts as an initialization guard here in thread__e_machine_endian(), could a concurrent reader observe e_machine != EM_NONE but still read an uninitialized value for e_is_big_endian?
Because this lockless check lacks an acquire barrier like smp_load_acquire(), it might be possible to read stale data if the CPU or compiler reorders the initialization stores.
Quoted 3 lines
tools/perf/util/thread.c +0
-0return e_machine; }
[ ... ]
Quoted 1 line
tools/perf/util/thread.c +0
-0@@ -515,16 +534,27 @@ uint16_t thread__e_machine(struct thread *thread, struct machine *machine, uint3
[ ... ]
tools/perf/util/thread.c uint16_t thread__e_machine(struct thread *thread, struct machine *machine, uint3 · line 550
Quoted 6 lines
out:
tools/perf/util/thread.c +2
-1if (e_machine !=EM_NONE ) { -thread__set_e_machine (thread, e_machine);thread__set_e_flags (thread, local_e_flags); +thread__set_e_is_big_endian (thread, args.is_big_endian); +thread__set_e_machine (thread, e_machine);
[Severity: Medium]
Could we be missing a release barrier here to ensure e_is_big_endian is visible before e_machine is marked as initialized?
If the compiler or CPU reorders these stores, the read side of thread__e_machine_endian() might see e_machine != EM_NONE before the e_is_big_endian update is fully published to memory.
Quoted 5 lines
tools/perf/util/thread.c +2
-0+if (is_big_endian) + *is_big_endian = args.is_big_endian; }else { e_machine =EM_HOST ; local_e_flags =EF_HOST ;
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=3
Ian Rogers
reviewerPATCH v11 4/19 perf capstone: Determine architecture from e_machine
In reply to Ian RogersAvoid the use of arch string that is imprecise and use the e_machine. Do more e_machine to capstone machine translations adding MIPS and RISCV. Remove unnecessary maybe_unused annotations.
--- tools/perf/util/capstone.c | 132 ++++++++++++++++++++++++------------- 1 file changed, 88 insertions(+), 44 deletions(-)
tools/perf/util/capstone.c +88 -44
@@ -1,7 +1,19 @@// SPDX-License-Identifier: GPL-2.0 #include "capstone.h" -#include "annotate.h" + +#include <errno.h> +#include <inttypes.h> +#include <string.h> + +#include <dlfcn.h> +#include <elf.h> +#include <fcntl.h> +#include <linux/ctype.h> + +#include <capstone/capstone.h> +#include "addr_location.h" +#include "annotate.h" #include "debug.h" #include "disasm.h" #include "dso.h"
@@ -11,13 +23,6 @@#include "print_insn.h" #include "symbol.h" #include "thread.h" -#include <dlfcn.h> -#include <errno.h> -#include <fcntl.h> -#include <inttypes.h> -#include <string.h> - -#include <capstone/capstone.h> #ifdef LIBCAPSTONE_DLOPEN static void *perf_cs_dll_handle (void )
@@ -137,37 +142,70 @@ static enum cs_err perf_cs_close(csh *handle)#endif } -static int capstone_init (struct machine *machine,csh *cs_handle,bool is64, +static bool e_machine_to_capstone (uint16_t e_machine,bool is64,bool is_big_endian, +enum cs_arch *arch,enum cs_mode *mode) +{ + *mode = is_big_endian ?CS_MODE_BIG_ENDIAN :CS_MODE_LITTLE_ENDIAN ; + +switch (e_machine) { +case EM_X86_64 : +case EM_386 : + *arch =CS_ARCH_X86 ; + *mode |= is64 ?CS_MODE_64 :CS_MODE_32 ; +return true; +case EM_AARCH64 : + *arch =CS_ARCH_ARM64 ; + *mode |=CS_MODE_ARM ; +return true; +case EM_ARM : + *arch =CS_ARCH_ARM ; + *mode |=CS_MODE_ARM |CS_MODE_V8 ; +return true; +case EM_S390 : + *arch =CS_ARCH_SYSZ ; +return true; +case EM_MIPS : + *arch =CS_ARCH_MIPS ; + *mode |= is64 ?CS_MODE_MIPS64 :CS_MODE_MIPS32 ; +return true; +case EM_PPC : + *arch =CS_ARCH_PPC ; +return true; +case EM_PPC64 : + *arch =CS_ARCH_PPC ; + *mode |=CS_MODE_64 ; +return true; +case EM_SPARC : + *arch =CS_ARCH_SPARC ; +return true; +case EM_SPARCV9 : + *arch =CS_ARCH_SPARC ; + *mode |=CS_MODE_V9 ; +return true; +case EM_RISCV : + *arch =CS_ARCH_RISCV ; + *mode |= (is64 ?CS_MODE_RISCV64 :CS_MODE_RISCV32 ) |CS_MODE_RISCVC ; +return true; +default : +return false; + } +} + +static int capstone_init (uint16_t e_machine,csh *cs_handle,bool is64,bool is_big_endian,bool disassembler_style) {enum cs_arch arch;enum cs_mode mode; -if (machine__is (machine,"x86_64" ) && is64) { - arch =CS_ARCH_X86 ; - mode =CS_MODE_64 ; - }else if (machine__normalized_is (machine,"x86" )) { - arch =CS_ARCH_X86 ; - mode =CS_MODE_32 ; - }else if (machine__normalized_is (machine,"arm64" )) { - arch =CS_ARCH_ARM64 ; - mode =CS_MODE_ARM ; - }else if (machine__normalized_is (machine,"arm" )) { - arch =CS_ARCH_ARM ; - mode =CS_MODE_ARM +CS_MODE_V8 ; - }else if (machine__normalized_is (machine,"s390" )) { - arch =CS_ARCH_SYSZ ; - mode =CS_MODE_BIG_ENDIAN ; - }else { +if (!e_machine_to_capstone (e_machine, is64, is_big_endian, &arch, &mode))return -1 ; - }if (perf_cs_open (arch, mode, cs_handle) !=CS_ERR_OK ) {pr_warning_once ("cs_open failed\n" );return -1 ; } -if (machine__normalized_is (machine,"x86" )) { +if (arch ==CS_ARCH_X86 ) {/* * In case of using capstone_init while symbol__disassemble * setting CS_OPT_SYNTAX_ATT depends if disassembler_style opts
@@ -211,29 +249,28 @@ static size_t print_insn_x86(struct thread *thread, u8 cpumode, struct cs_insn *return printed; } - -ssize_t capstone__fprintf_insn_asm (struct machine *machine__maybe_unused , -struct thread *thread__maybe_unused , -u8 cpumode__maybe_unused ,bool is64bit__maybe_unused , -const uint8_t *code__maybe_unused , -size_t code_size__maybe_unused , -uint64_t ip__maybe_unused ,int *lenp__maybe_unused , -int print_opts__maybe_unused ,FILE *fp__maybe_unused ) +ssize_t capstone__fprintf_insn_asm (struct machine *machine,struct thread *thread,u8 cpumode, +bool is64bit,const uint8_t *code,size_t code_size,uint64_t ip, +int *lenp,int print_opts,FILE *fp) {size_t printed;struct cs_insn *insn;csh cs_handle;size_t count; +bool is_big_endian = false; +uint16_t e_machine =thread__e_machine_endian (thread, machine, +/*e_flags=*/ NULL , &is_big_endian);int ret;/* TODO: Try to initiate capstone only once but need a proper place. */ - ret =capstone_init (machine, &cs_handle, is64bit, true); + ret =capstone_init (e_machine, &cs_handle, is64bit, is_big_endian, +/*disassembler_style=*/ true);if (ret <0 )return ret; count =perf_cs_disasm (cs_handle, code, code_size, ip,1 , &insn);if (count >0 ) { -if (machine__normalized_is (machine,"x86" )) +if (e_machine ==EM_X86_64 || e_machine ==EM_386 ) printed =print_insn_x86 (thread, cpumode, &insn[0 ], print_opts, fp);else printed =fprintf (fp,"%s %s" , insn[0 ].mnemonic, insn[0 ].op_str);
@@ -322,9 +359,8 @@ static int find_file_offset(u64 start, u64 len, u64 pgoff, void *arg)return 0 ; } -int symbol__disassemble_capstone (const char *filename__maybe_unused , -struct symbol *sym__maybe_unused , -struct annotate_args *args__maybe_unused ) +int symbol__disassemble_capstone (const char *filename,struct symbol *sym, +struct annotate_args *args) {struct annotation *notes =symbol__annotation (sym);struct map *map = args->ms->map;
@@ -344,6 +380,8 @@ int symbol__disassemble_capstone(const char *filename __maybe_unused,char disasm_buf[512 ];struct disasm_line *dl;bool disassembler_style = false; +uint16_t e_machine; +bool is_big_endian = false;if (args->options->objdump_path)return -1 ;
@@ -373,8 +411,10 @@ int symbol__disassemble_capstone(const char *filename __maybe_unused, !strcmp(args->options->disassembler_style, "att")) disassembler_style = true; -if (capstone_init (maps__machine (thread__maps (args->ms->thread)), &handle, is_64bit, - disassembler_style) <0 ) + e_machine =thread__e_machine_endian (args->ms->thread, +/*machine=*/ NULL , +/*e_flags=*/ NULL , &is_big_endian); +if (capstone_init (e_machine, &handle, is_64bit, is_big_endian, disassembler_style) <0 ) goto err; needs_cs_close = true;
@@ -466,6 +506,8 @@ int symbol__disassemble_capstone_powerpc(const char *filename __maybe_unused,struct disasm_line *dl;u32 *line;bool disassembler_style = false; +uint16_t e_machine; +bool is_big_endian = false;if (args->options->objdump_path)return -1 ;
@@ -484,8 +526,10 @@ int symbol__disassemble_capstone_powerpc(const char *filename __maybe_unused, !strcmp(args->options->disassembler_style, "att")) disassembler_style = true; -if (capstone_init (maps__machine (thread__maps (args->ms->thread)), &handle, is_64bit, - disassembler_style) <0 ) + e_machine =thread__e_machine_endian (args->ms->thread, +/*machine=*/ NULL , +/*e_flags=*/ NULL , &is_big_endian); +if (capstone_init (e_machine, &handle, is_64bit, is_big_endian, disassembler_style) <0 ) goto err; needs_cs_close = true;
Signature · 1 line
2.54.0.929.g9b7fa37559-goog
[email protected]
AI reviewRe: [PATCH v11 04/19] perf capstone: Determine architecture from e_machine
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] Compiling `perf` with Capstone < 4.0 will fail with undeclared identifiers `CS_ARCH_RISCV` and…
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Compiling perf with Capstone < 4.0 will fail with undeclared identifiers CS_ARCH_RISCV and CS_MODE_RISCV*. --
commit 408e93bdddd7f0b1d7be6fe9fd0af6c070a4e302
Author: Ian Rogers <[email protected]>
perf capstone: Determine architecture from e_machine
Avoid the use of arch string that is imprecise and use the e_machine. Do more e_machine to capstone machine translations adding MIPS and RISCV. Remove unnecessary maybe_unused annotations.
Quoted 4 lines
tools/perf/util/capstone.c +0
-0
[ ... ]
Quoted 6 lines
tools/perf/util/capstone.c +6
-0+static bool e_machine_to_capstone (uint16_t e_machine,bool is64,bool is_big_endian, +enum cs_arch *arch,enum cs_mode *mode) +{ + *mode = is_big_endian ?CS_MODE_BIG_ENDIAN :CS_MODE_LITTLE_ENDIAN ; + +switch (e_machine) {
[ ... ]
tools/perf/util/capstone.c static enum cs_err perf_cs_close(csh *handle) · line 187
Quoted 7 lines
tools/perf/util/capstone.c +7
-0+case EM_SPARCV9 : + *arch =CS_ARCH_SPARC ; + *mode |=CS_MODE_V9 ; +return true; +case EM_RISCV : + *arch =CS_ARCH_RISCV ; + *mode |= (is64 ?CS_MODE_RISCV64 :CS_MODE_RISCV32 ) |CS_MODE_RISCVC ;
[Severity: Low]
Will compiling perf with Capstone versions older than 4.0 fail here?
Capstone introduced RISC-V support in version 4.0. Because the build system feature test for Capstone in tools/build/feature/test-libcapstone.c only checks for x86 support, it seems it will successfully compile with Capstone 3.0 and define HAVE_LIBCAPSTONE_SUPPORT.
If HAVE_LIBCAPSTONE_SUPPORT is defined but the system has Capstone 3.0, using CS_ARCH_RISCV directly will cause a hard compiler error.
Should there be an updated feature test for Capstone 4.0, or version guards around the RISC-V specific code?
Quoted 5 lines
tools/perf/util/capstone.c +5
-0+return true; +default : +return false; + } +}
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=4
Ian Rogers
reviewerPATCH v11 5/19 perf print_insn: Use e_machine for fallback IP length check
In reply to Ian RogersAvoid string comparisons with perf_env arch, switch to using the more precise ELF machine.
Sort header files and fix missing definitions.
--- tools/perf/util/print_insn.c | 23 ++++++++++++++--------- tools/perf/util/print_insn.h | 2 ++ 2 files changed, 16 insertions(+), 9 deletions(-)
tools/perf/util/print_insn.c +14 -9
@@ -4,19 +4,24 @@* * Author(s): Changbin Du <[email protected]> */ +#include "print_insn.h" +#include <inttypes.h> -#include <string.h> #include <stdbool.h> +#include <string.h> + +#include <dwarf-regs.h> +#include "capstone.h" #include "debug.h" +#include "dso.h" +#include "dump-insn.h" +#include "env.h" +#include "machine.h" +#include "map.h" #include "sample.h" #include "symbol.h" -#include "machine.h" #include "thread.h" -#include "print_insn.h" -#include "dump-insn.h" -#include "map.h" -#include "dso.h" size_t sample__fprintf_insn_raw (struct perf_sample *sample,FILE *fp) {
@@ -33,13 +38,13 @@ size_t sample__fprintf_insn_raw(struct perf_sample *sample, FILE *fp)static bool is64bitip (struct machine *machine,struct addr_location *al) {const struct dso *dso = al->map ?map__dso (al->map) :NULL ; +uint16_t e_machine;if (dso)return dso__is_64_bit (dso); -return machine__is (machine,"x86_64" ) || -machine__normalized_is (machine,"arm64" ) || -machine__normalized_is (machine,"s390" ); + e_machine =perf_env__e_machine (machine->env,/*e_flags=*/ NULL ); +return e_machine ==EM_X86_64 || e_machine ==EM_AARCH64 || e_machine ==EM_S390 ; } ssize_t fprintf_insn_asm(struct machine *machine, struct thread *thread, u8 cpumode,
tools/perf/util/print_insn.h +2 -0
@@ -5,6 +5,8 @@#include <stddef.h> #include <stdio.h> +#include <linux/types.h> +struct addr_location ;struct machine ;struct perf_insn ;
Signature · 1 line
2.54.0.929.g9b7fa37559-goog
[email protected]
AI reviewRe: [PATCH v11 05/19] perf print_insn: Use e_machine for fallback IP length check
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] is64bitip() incorrectly falls back to the host architecture via uname() for guest machines…
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] is64bitip() incorrectly falls back to the host architecture via uname() for guest machines, breaking instruction decoding bitness for 32-bit guest analysis on x86_64 hosts. --
commit 57b90f6c4edae48460ac4aff9f63c175178b0004
Author: Ian Rogers <[email protected]>
perf print_insn: Use e_machine for fallback IP length check
This patch avoids string comparisons with perf_env arch, switching to using the more precise ELF machine. It also sorts header files and fixes missing definitions.
Quoted 4 lines
tools/perf/util/print_insn.c +0
-0
[ ... ]
Quoted 4 lines
tools/perf/util/print_insn.c +0
-0@@ -33,13 +38,13 @@ size_t sample__fprintf_insn_raw(struct perf_sample *sample, FILE *fp)static bool is64bitip (struct machine *machine,struct addr_location *al) {const struct dso *dso = al->map ?map__dso (al->map) :NULL ;
tools/perf/util/print_insn.c size_t sample__fprintf_insn_raw(struct perf_sample *sample, FILE *fp) · line 47
Quoted 10 lines
tools/perf/util/print_insn.c +3
-3+uint16_t e_machine;if (dso)return dso__is_64_bit (dso); -return machine__is (machine,"x86_64" ) || -machine__normalized_is (machine,"arm64" ) || -machine__normalized_is (machine,"s390" ); + e_machine =perf_env__e_machine (machine->env,/*e_flags=*/ NULL ); +return e_machine ==EM_X86_64 || e_machine ==EM_AARCH64 || e_machine ==EM_S390 ;
[Severity: Medium]
Does this change break instruction decoding bitness for guest machines?
For guest machines, machine->env is often NULL. The previous code handled this gracefully because machine__is() checks perf_env__raw_arch(), which returns "unknown" when the environment is NULL, safely returning false for the 64-bit check on x86_64 hosts.
With the new logic, passing a NULL env to perf_env__e_machine() delegates to perf_env__e_machine_nocache(), which calls uname() to retrieve the local host architecture.
If analyzing a 32-bit guest trace on a 64-bit x86_64 host without a valid DSO present, this fallback would return EM_X86_64. Could this cause is64bitip() to return true, improperly decoding the 32-bit guest instructions with 64-bit bitness?
Quoted 1 line
tools/perf/util/print_insn.c +0
-0}
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=5
Ian Rogers
reviewerPATCH v11 6/19 perf symbol: Avoid use of machine__is
In reply to Ian RogersSwitch to using the ELF machine from the dso or running machine rather than the machine perf_env arch that may fall back on EM_HOST. This also avoids potentially imprecise string comparisons.
--- tools/perf/util/symbol.c | 28 ++++++++++++++++++++++------ 1 file changed, 22 insertions(+), 6 deletions(-)
tools/perf/util/symbol.c +22 -6
@@ -851,6 +851,23 @@ static int maps__split_kallsyms_for_kcore(struct maps *kmaps, struct dso *dso)return count; } +static uint16_t machine_or_dso_e_machine (struct machine *machine,struct dso *dso) +{ +uint16_t e_machine =EM_NONE ; +/* DSO should be most accurate */ +if (dso) + e_machine =dso__e_machine (dso, machine,/*e_flags=*/ NULL ); + +if (e_machine !=EM_NONE ) +return e_machine; + +/* Check the global environment next. */ +if (machine && machine->env && machine->env->e_machine !=EM_NONE ) +return machine->env->e_machine; + +return perf_env__e_machine (machine ? machine->env :NULL ,/*e_flags=*/ NULL ); +} +/* * Split the symbols into maps, making sure there are no overlaps, i.e. the * kernel range is broken in several maps, named [kernel].N, as we don't have
@@ -866,14 +883,13 @@ static int maps__split_kallsyms(struct maps *kmaps, struct dso *dso, u64 delta,struct rb_root_cached *root =dso__symbols (dso);struct rb_node *next =rb_first_cached (root);int kernel_range =0 ; -bool x86_64; +uint16_t e_machine =EM_NONE ;if (!kmaps)return -1 ; machine =maps__machine (kmaps); - - x86_64 =machine__is (machine,"x86_64" ); + e_machine =machine_or_dso_e_machine (machine, dso);while (next) {char *module;
@@ -925,7 +941,7 @@ static int maps__split_kallsyms(struct maps *kmaps, struct dso *dso, u64 delta,*/ pos->start =map__map_ip (curr_map, pos->start); pos->end =map__map_ip (curr_map, pos->end); - }else if (x86_64 &&is_entry_trampoline (pos->name)) { + }else if (e_machine ==EM_X86_64 &&is_entry_trampoline (pos->name)) {/* * These symbols are not needed anymore since the * trampoline maps refer to the text section and it's
@@ -1428,7 +1444,7 @@ static int dso__load_kcore(struct dso *dso, struct map *map,free (new_node); } -if (machine__is (machine,"x86_64" )) { +if (machine_or_dso_e_machine (machine, dso) ==EM_X86_64 ) {u64 addr;/*
@@ -1716,7 +1732,7 @@ int dso__load(struct dso *dso, struct map *map) ret =dso__load_guest_kernel_sym (dso, map); machine =maps__machine (map__kmaps (map)); -if (machine__is (machine,"x86_64" )) +if (machine &&machine_or_dso_e_machine (machine, dso) ==EM_X86_64 )machine__map_x86_64_entry_trampolines (machine, dso); goto out; }
Signature · 1 line
2.54.0.929.g9b7fa37559-goog
[email protected]
AI reviewRe: [PATCH v11 06/19] perf symbol: Avoid use of machine__is
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [High] Cross-platform analysis regression due to machine_or_dso_e_machine falling back to the host…
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Cross-platform analysis regression due to machine_or_dso_e_machine falling back to the host architecture when perf_env is missing. --
commit 06f9fc725d46994e8315f16f6c305b978381b444
Author: Ian Rogers <[email protected]>
perf symbol: Avoid use of machine__is
This commit switches from string comparisons against the perf_env arch to using the ELF machine value from the dso or running machine.
Quoted 4 lines
tools/perf/util/symbol.c +0
-0
[ ... ]
Quoted 9 lines
tools/perf/util/symbol.c +5
-0@@ -851,6 +851,23 @@ static int maps__split_kallsyms_for_kcore(struct maps *kmaps, struct dso *dso)return count; } +static uint16_t machine_or_dso_e_machine (struct machine *machine,struct dso *dso) +{ +uint16_t e_machine =EM_NONE ; +/* DSO should be most accurate */ +if (dso)
tools/perf/util/symbol.c static int maps__split_kallsyms_for_kcore(struct maps *kmaps, struct dso *dso) · line 868
Quoted 10 lines
tools/perf/util/symbol.c +10
-0+ e_machine =dso__e_machine (dso, machine,/*e_flags=*/ NULL ); + +if (e_machine !=EM_NONE ) +return e_machine; + +/* Check the global environment next. */ +if (machine && machine->env && machine->env->e_machine !=EM_NONE ) +return machine->env->e_machine; + +return perf_env__e_machine (machine ? machine->env :NULL ,/*e_flags=*/ NULL );
[Severity: High]
When machine->env is NULL (such as in pipe mode before perf_env is fully initialized), perf_env__e_machine() falls back to evaluating the host architecture via uname().
If we are on an x86_64 host analyzing a non-x86_64 perf.data file without an environment, will this silently return EM_X86_64 and break cross-platform analysis?
Previously, machine__is() safely returned false if the environment was NULL.
Quoted 5 lines
tools/perf/util/symbol.c +2
-0+} +/* * Split the symbols into maps, making sure there are no overlaps, i.e. the * kernel range is broken in several maps, named [kernel].N, as we don't have
[ ... ]
tools/perf/util/symbol.c static int maps__split_kallsyms(struct maps *kmaps, struct dso *dso, u64 delta, · line 944
Quoted 6 lines
tools/perf/util/symbol.c +1
-1@@ -925,7 +941,7 @@ static int maps__split_kallsyms(struct maps *kmaps, struct dso *dso, u64 delta,*/ pos->start =map__map_ip (curr_map, pos->start); pos->end =map__map_ip (curr_map, pos->end); - }else if (x86_64 &&is_entry_trampoline (pos->name)) { + }else if (e_machine ==EM_X86_64 &&is_entry_trampoline (pos->name)) {
[Severity: High]
Could this erroneously discard symbols resembling entry trampolines on foreign architecture data when parsed on an x86_64 host, due to the host fallback behavior in machine_or_dso_e_machine() described above?
Quoted 3 lines
tools/perf/util/symbol.c +0
-0/* * These symbols are not needed anymore since the * trampoline maps refer to the text section and it's
[ ... ]
tools/perf/util/symbol.c static int dso__load_kcore(struct dso *dso, struct map *map, · line 1447
Quoted 6 lines
tools/perf/util/symbol.c +1
-1@@ -1428,7 +1444,7 @@ static int dso__load_kcore(struct dso *dso, struct map *map,free (new_node); } -if (machine__is (machine,"x86_64" )) { +if (machine_or_dso_e_machine (machine, dso) ==EM_X86_64 ) {
[Severity: High]
Does this similarly risk executing x86_64-specific trampoline logic on non-x86_64 data if run on an x86_64 host without a perf_env?
Quoted 3 lines
tools/perf/util/symbol.c +0
-0u64 addr;/*
[ ... ]
tools/perf/util/symbol.c int dso__load(struct dso *dso, struct map *map) · line 1735
Quoted 6 lines
tools/perf/util/symbol.c +1
-1@@ -1716,7 +1732,7 @@ int dso__load(struct dso *dso, struct map *map) ret =dso__load_guest_kernel_sym (dso, map); machine =maps__machine (map__kmaps (map)); -if (machine__is (machine,"x86_64" )) +if (machine &&machine_or_dso_e_machine (machine, dso) ==EM_X86_64 )
[Severity: High]
Does this incorrectly map x86_64 entry trampolines for foreign architecture data if the machine environment is missing and we fall back to the host arch?
Quoted 3 lines
tools/perf/util/symbol.c +0
-0machine__map_x86_64_entry_trampolines (machine, dso); goto out; }
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=6
Ian Rogers
reviewerPATCH v11 7/19 perf machine: Use perf_env e_machine rather than arch
In reply to Ian RogersThe arch string is derived from uname and may be normalized causing potential differences meaning the ELF machine can be more precise. Reduce the scope of machine__is as often it is better to use a thread for the e_machine rather than the machine. Switch from string to ELF machine constant comparisons.
--- tools/perf/util/machine.c | 35 ++++++++++++++++++----------------- tools/perf/util/machine.h | 2 -- 2 files changed, 18 insertions(+), 19 deletions(-)
tools/perf/util/machine.c +18 -17
@@ -9,6 +9,7 @@#include "debug.h" #include "dso.h" #include "env.h" +#include "dwarf-regs.h" #include "event.h" #include "evsel.h" #include "hist.h"
@@ -1627,10 +1628,24 @@ static bool machine__uses_kcore(struct machine *machine)return dsos__for_each_dso (&machine->dsos, machine__uses_kcore_cb,NULL ) !=0 ? true : false; } +static bool machine__is (struct machine *machine,uint16_t e_machine) +{ +if (!machine) +return false; + +if (!machine->env) { +if (machine__is_host (machine)) +return e_machine ==EM_HOST ; +return false; + } + +return perf_env__e_machine (machine->env,NULL ) == e_machine; +} +static bool perf_event__is_extra_kernel_mmap (struct machine *machine,struct extra_kernel_map *xm) { -return machine__is (machine,"x86_64" ) && +return machine__is (machine,EM_X86_64 ) &&is_entry_trampoline (xm->name); }
@@ -2786,7 +2801,7 @@ static int find_prev_cpumode(struct ip_callchain *chain, struct thread *thread,static u64 get_leaf_frame_caller (struct perf_sample *sample,struct thread *thread,int usr_idx) { -if (machine__normalized_is (maps__machine (thread__maps (thread)),"arm64" )) +if (thread__e_machine (thread,/*machine=*/ NULL ,/*e_flags=*/ NULL ) ==EM_AARCH64 )return get_leaf_frame_caller_aarch64 (sample, thread, usr_idx);else return 0 ;
@@ -3157,20 +3172,6 @@ int machine__set_current_tid(struct machine *machine, int cpu, pid_t pid,return 0 ; } -/* -* Compares the raw arch string. N.B. see instead perf_env__arch() or -* machine__normalized_is() if a normalized arch is needed. -*/ -bool machine__is (struct machine *machine,const char *arch) -{ -return machine && !strcmp (perf_env__raw_arch (machine->env), arch); -} - -bool machine__normalized_is (struct machine *machine,const char *arch) -{ -return machine && !strcmp (perf_env__arch (machine->env), arch); -} -int machine__nr_cpus_avail (struct machine *machine) {return machine ?perf_env__nr_cpus_avail (machine->env) :0 ;
@@ -3197,7 +3198,7 @@ int machine__get_kernel_start(struct machine *machine)* start of kernel text, but still above 2^63. So leave * kernel_start = 1ULL << 63 for x86_64. */ -if (!err && !machine__is (machine,"x86_64" )) +if (!err && !machine__is (machine,EM_X86_64 )) machine->kernel_start =map__start (map); }return err;
tools/perf/util/machine.h +0 -2
@@ -224,8 +224,6 @@ static inline bool machine__is_host(struct machine *machine) }bool machine__is_lock_function (struct machine *machine,u64 addr); -bool machine__is (struct machine *machine,const char *arch); -bool machine__normalized_is (struct machine *machine,const char *arch);int machine__nr_cpus_avail (struct machine *machine);struct thread *machine__findnew_thread (struct machine *machine,pid_t pid,pid_t tid);
Signature · 1 line
2.54.0.929.g9b7fa37559-goog
Ian Rogers
reviewerPATCH v11 8/19 perf sample-raw: Use perf_env e_machine rather than arch
In reply to Ian RogersUse the e_machine rather than the arch to determine S390 and x86 types.
--- tools/perf/util/sample-raw.c | 21 +++++++++++---------- tools/perf/util/sample-raw.h | 6 +++++- 2 files changed, 16 insertions(+), 11 deletions(-)
tools/perf/util/sample-raw.c +11 -10
@@ -1,11 +1,12 @@/* SPDX-License-Identifier: GPL-2.0 */ +#include "sample-raw.h" -#include <string.h> +#include <elf.h> #include <linux/string.h> -#include "evlist.h" +#include "env.h" +#include "evlist.h" #include "header.h" -#include "sample-raw.h" #include "session.h" /*
@@ -14,14 +15,14 @@*/ void evlist__init_trace_event_sample_raw (struct evlist *evlist,struct perf_env *env) { -const char *arch_pf =perf_env__arch (env); -const char *cpuid =perf_env__cpuid (env); +uint16_t e_machine =perf_env__e_machine (env,/*e_flags=*/ NULL ); -if (arch_pf && !strcmp ("s390" , arch_pf)) +if (e_machine ==EM_S390 ) { evlist->trace_event_sample_raw = evlist__s390_sample_raw; -else if (arch_pf && !strcmp ("x86" , arch_pf) && - cpuid &&strstarts (cpuid,"AuthenticAMD" ) && -evlist__has_amd_ibs (evlist)) { - evlist->trace_event_sample_raw = evlist__amd_sample_raw; + }else if (e_machine ==EM_X86_64 || e_machine ==EM_386 ) { +const char *cpuid =perf_env__cpuid (env); + +if (cpuid &&strstarts (cpuid,"AuthenticAMD" ) &&evlist__has_amd_ibs (evlist)) + evlist->trace_event_sample_raw = evlist__amd_sample_raw; } }
tools/perf/util/sample-raw.h +5 -1
@@ -2,7 +2,10 @@#ifndef __SAMPLE_RAW_H#define __SAMPLE_RAW_H 1 +#include <stdbool.h> +struct evlist ; +struct perf_env ;union perf_event ;struct perf_sample ;
@@ -12,4 +15,5 @@ bool evlist__has_amd_ibs(struct evlist *evlist);void evlist__amd_sample_raw (struct evlist *evlist,union perf_event *event,struct perf_sample *sample);void evlist__init_trace_event_sample_raw (struct evlist *evlist,struct perf_env *env); -#endif /* __PERF_EVLIST_H */ + +#endif /* __SAMPLE_RAW_H */
Signature · 1 line
2.54.0.929.g9b7fa37559-goog
Ian Rogers
reviewerPATCH v11 9/19 perf sort: Use perf_env e_machine rather than arch
In reply to Ian RogersUse the e_machine rather than the arch to determine x86 or PPC types.
--- tools/perf/util/sort.c | 58 +++++++++++++++++++++++------------------- 1 file changed, 32 insertions(+), 26 deletions(-)
tools/perf/util/sort.c +32 -26
@@ -1,40 +1,45 @@// SPDX-License-Identifier: GPL-2.0 +#include "sort.h" +#include <ctype.h> #include <errno.h> #include <inttypes.h> -#include <regex.h> #include <stdlib.h> + +#include <elf.h> +#include <linux/kernel.h> #include <linux/mman.h> +#include <linux/string.h> #include <linux/time64.h> + +#include <regex.h> + +#include "annotate-data.h" +#include "annotate.h" +#include "branch.h" +#include "cacheline.h" +#include "cgroup.h" +#include "comm.h" #include "debug.h" #include "dso.h" -#include "sort.h" +#include "event.h" +#include "evlist.h" +#include "evsel.h" #include "hist.h" -#include "cacheline.h" -#include "comm.h" +#include "machine.h" #include "map.h" -#include "maps.h" -#include "symbol.h" #include "map_symbol.h" -#include "branch.h" -#include "thread.h" -#include "evsel.h" -#include "evlist.h" -#include "srcline.h" -#include "strlist.h" -#include "strbuf.h" +#include "maps.h" #include "mem-events.h" #include "mem-info.h" -#include "annotate.h" -#include "annotate-data.h" -#include "event.h" -#include "time-utils.h" -#include "cgroup.h" -#include "machine.h" #include "session.h" +#include "srcline.h" +#include "strbuf.h" +#include "strlist.h" +#include "symbol.h" +#include "thread.h" +#include "time-utils.h" #include "trace-event.h" -#include <linux/kernel.h> -#include <linux/string.h> #ifdef HAVE_LIBTRACEEVENT #include <event-parse.h>
@@ -2673,9 +2678,10 @@ struct sort_dimension {static int arch_support_sort_key (const char *sort_key,struct perf_env *env) { -const char *arch =perf_env__arch (env); +uint16_t e_machine =perf_env__e_machine (env,/*e_eflags=*/ NULL ); -if (!strcmp ("x86" , arch) || !strcmp ("powerpc" , arch)) { +if (e_machine ==EM_X86_64 || e_machine ==EM_386 || e_machine ==EM_PPC64 || + e_machine ==EM_PPC ) {if (!strcmp (sort_key,"p_stage_cyc" ))return 1 ;if (!strcmp (sort_key,"local_p_stage_cyc" ))
@@ -2686,14 +2692,14 @@ static int arch_support_sort_key(const char *sort_key, struct perf_env *env)static const char *arch_perf_header_entry (const char *se_header,struct perf_env *env) { -const char *arch =perf_env__arch (env); +uint16_t e_machine =perf_env__e_machine (env,/*e_eflags=*/ NULL ); -if (!strcmp ("x86" , arch)) { +if (e_machine ==EM_X86_64 || e_machine ==EM_386 ) {if (!strcmp (se_header,"Local Pipeline Stage Cycle" ))return "Local Retire Latency" ;else if (!strcmp (se_header,"Pipeline Stage Cycle" ))return "Retire Latency" ; - }else if (!strcmp ("powerpc" , arch)) { + }else if (e_machine ==EM_PPC64 || e_machine ==EM_PPC ) {if (!strcmp (se_header,"Local INSTR Latency" ))return "Finish Cyc" ;else if (!strcmp (se_header,"INSTR Latency" ))
Signature · 1 line
2.54.0.929.g9b7fa37559-goog
Ian Rogers
reviewerPATCH v11 10/19 perf arch common: Use perf_env e_machine rather than arch
In reply to Ian RogersUse the e_machine rather than arch string matching.
--- tools/perf/arch/common.c | 92 ++++++++++++++++++++++++++++++---------- 1 file changed, 69 insertions(+), 23 deletions(-)
tools/perf/arch/common.c +69 -23
@@ -1,13 +1,18 @@// SPDX-License-Identifier: GPL-2.0 +#include "common.h" +#include <limits.h> #include <stdio.h> #include <stdlib.h> #include <string.h> + +#include <linux/zalloc.h> #include <unistd.h> -#include "common.h" -#include "../util/env.h" + +#include <dwarf-regs.h> +#include "../util/debug.h" -#include <linux/zalloc.h> +#include "../util/env.h" static const char *const arc_triplets[] = {"arc-linux-" ,
@@ -141,11 +146,40 @@ static int lookup_triplets(const char *const *triplets, const char *name)return -1 ; } +static bool is_native_compatible (struct perf_env *env,uint16_t target,uint16_t host) +{ +if (target != host) { +/* A 64-bit host can natively disassemble its 32-bit compat architecture */ +if (host ==EM_X86_64 && target ==EM_386 ) +return true; +if (host ==EM_AARCH64 && target ==EM_ARM ) +return true; +if (host ==EM_PPC64 && target ==EM_PPC ) +return true; +if (host ==EM_SPARCV9 && target ==EM_SPARC ) +return true; +return false; + } + +/* target == host case */ +if (target ==EM_RISCV ) { +bool target_is_64 =perf_env__kernel_is_64_bit (env); +bool host_is_64 = (sizeof (void *) ==8 ); + +/* 32-bit host cannot natively disassemble 64-bit target */ +if (!host_is_64 && target_is_64) +return false; + } + +return true; +} +static int perf_env__lookup_binutils_path (struct perf_env *env,const char *name,char **path) {int idx; -const char *arch =perf_env__arch (env), *cross_env; +uint16_t e_machine =perf_env__e_machine (env,/*e_flags=*/ NULL ); +const char *cross_env;const char *const *path_list;char *buf =NULL ;
@@ -153,7 +187,7 @@ static int perf_env__lookup_binutils_path(struct perf_env *env,* We don't need to try to find objdump path for native system. * Just use default binutils path (e.g.: "objdump"). */ -if (!strcmp (perf_env__arch (NULL ), arch)) +if (is_native_compatible (env, e_machine,EM_HOST )) goto out; cross_env =getenv ("CROSS_COMPILE" );
@@ -170,30 +204,42 @@ static int perf_env__lookup_binutils_path(struct perf_env *env,zfree (&buf); } -if (!strcmp (arch,"arc" )) +switch (e_machine) { +case EM_ARC : path_list = arc_triplets; -else if (!strcmp (arch,"arm" )) +break ; +case EM_ARM : path_list = arm_triplets; -else if (!strcmp (arch,"arm64" )) +break ; +case EM_AARCH64 : path_list = arm64_triplets; -else if (!strcmp (arch,"powerpc" )) +break ; +case EM_PPC : +case EM_PPC64 : path_list = powerpc_triplets; -else if (!strcmp (arch,"riscv32" )) - path_list = riscv32_triplets; -else if (!strcmp (arch,"riscv64" )) - path_list = riscv64_triplets; -else if (!strcmp (arch,"sh" )) +break ; +case EM_RISCV : + path_list =perf_env__kernel_is_64_bit (env) ? riscv64_triplets : riscv32_triplets; +break ; +case EM_SH : path_list = sh_triplets; -else if (!strcmp (arch,"s390" )) +break ; +case EM_S390 : path_list = s390_triplets; -else if (!strcmp (arch,"sparc" )) +break ; +case EM_SPARC : +case EM_SPARCV9 : path_list = sparc_triplets; -else if (!strcmp (arch,"x86" )) +break ; +case EM_X86_64 : +case EM_386 : path_list = x86_triplets; -else if (!strcmp (arch,"mips" )) +break ; +case EM_MIPS : path_list = mips_triplets; -else { -ui__error ("binutils for %s not supported.\n" , arch); +break ; +default : +ui__error ("binutils for %s not supported.\n" ,perf_env__arch (env)); goto out_error; }
@@ -202,7 +248,7 @@ static int perf_env__lookup_binutils_path(struct perf_env *env,ui__error ("Please install %s for %s.\n" "You can add it to PATH, set CROSS_COMPILE or " "override the default using --%s.\n" , - name, arch, name); + name,perf_env__arch (env), name); goto out_error; }
@@ -237,7 +283,7 @@ int perf_env__lookup_objdump(struct perf_env *env, char **path)*/ bool perf_env__single_address_space (struct perf_env *env) { -const char *arch =perf_env__arch (env); +uint16_t e_machine =perf_env__e_machine (env,/*e_flags=*/ NULL ); -return strcmp (arch,"s390" ) &&strcmp (arch,"sparc" ); +return e_machine !=EM_SPARC && e_machine !=EM_SPARCV9 && e_machine !=EM_S390 ; }
Signature · 1 line
2.54.0.929.g9b7fa37559-goog
[email protected]
AI reviewRe: [PATCH v11 10/19] perf arch common: Use perf_env e_machine rather than arch
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider: - [Medium] is_native_compatible() incorrectly skips bitness checks for architectures that share the same…
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] is_native_compatible() incorrectly skips bitness checks for architectures that share the same e_machine (e.g., MIPS, PARISC, S390), causing 32-bit hosts to erroneously attempt native disassembly of 64-bit targets.
- [Medium] Native SPARC64 profiling fails to resolve the system objdump path due to a flawed architecture matching condition.
--
commit 0ccc4649e16f322564aa71d657e01e2dc842077f
Author: Ian Rogers <[email protected]>
perf arch common: Use perf_env e_machine rather than arch
This commit changes the binutils path lookup to use the e_machine ELF constant rather than architecture string matching. It introduces is_native_compatible to determine if the host can natively disassemble the target.
Quoted 3 lines
tools/perf/arch/common.c +0
-0
[ ... ]
Quoted 6 lines
tools/perf/arch/common.c +2
-0@@ -141,11 +146,40 @@ static int lookup_triplets(const char *const *triplets, const char *name)return -1 ; } +static bool is_native_compatible (struct perf_env *env,uint16_t target,uint16_t host) +{
tools/perf/arch/common.c static int lookup_triplets(const char *const *triplets, const char *name) · line 160
Quoted 10 lines
tools/perf/arch/common.c +10
-0+if (target != host) { +/* A 64-bit host can natively disassemble its 32-bit compat architecture */ +if (host ==EM_X86_64 && target ==EM_386 ) +return true; +if (host ==EM_AARCH64 && target ==EM_ARM ) +return true; +if (host ==EM_PPC64 && target ==EM_PPC ) +return true; +if (host ==EM_SPARCV9 && target ==EM_SPARC ) +return true;
[Severity: Medium]
Is this architecture matching condition reversed for SPARC?
When perf is built natively on a 64-bit SPARC system, EM_HOST is defined as EM_SPARC, not EM_SPARCV9. When reading a native 64-bit SPARC perf.data file, the target yields EM_SPARCV9.
Since host evaluates to EM_SPARC and target to EM_SPARCV9, this branch appears unreachable.
Will this cause native SPARC64 profiling to incorrectly evaluate as a cross-compilation environment and fail to resolve the system objdump?
tools/perf/arch/common.c static int lookup_triplets(const char *const *triplets, const char *name) · line 172
Quoted 12 lines
tools/perf/arch/common.c +12
-0+return false; + } + +/* target == host case */ +if (target ==EM_RISCV ) { +bool target_is_64 =perf_env__kernel_is_64_bit (env); +bool host_is_64 = (sizeof (void *) ==8 ); + +/* 32-bit host cannot natively disassemble 64-bit target */ +if (!host_is_64 && target_is_64) +return false; + }
[Severity: Medium]
Does this bitness check need to apply to other architectures?
Architectures like MIPS, PARISC, and S390 also share the same e_machine value across 32-bit and 64-bit binaries.
By restricting this check strictly to EM_RISCV, could a 32-bit host for these other architectures erroneously attempt native disassembly of a 64-bit target and fail to use the proper cross-compiler triplets?
Quoted 3 lines
tools/perf/arch/common.c +3
-0+ +return true; +}
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=10
Ian Rogers
reviewerPATCH v11 11/19 perf header: In print_pmu_caps use perf_env e_machine
In reply to Ian RogersSwitch from arch to e_machine in print_pmu_caps.
--- tools/perf/util/header.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
tools/perf/util/header.c +4 -3
@@ -2461,15 +2461,16 @@ static void print_cpu_pmu_caps(struct feat_fd *ff, FILE *fp)static void print_pmu_caps (struct feat_fd *ff,FILE *fp) {struct perf_env *env = &ff->ph->env; -struct pmu_caps *pmu_caps; +uint16_t e_machine =perf_env__e_machine (env,/*e_flags=*/ NULL );for (int i =0 ; i < env->nr_pmus_with_caps; i++) { - pmu_caps = &env->pmu_caps[i]; +struct pmu_caps *pmu_caps = &env->pmu_caps[i]; +__print_pmu_caps (fp, pmu_caps->nr_caps, pmu_caps->caps, pmu_caps->pmu_name); } -if (strcmp (perf_env__arch (env),"x86" ) ==0 && +if ((e_machine ==EM_X86_64 || e_machine ==EM_386 ) &&perf_env__has_pmu_mapping (env,"ibs_op" )) {char *max_precise =perf_env__find_pmu_cap (env,"cpu" ,"max_precise" );
Signature · 1 line
2.54.0.929.g9b7fa37559-goog
Ian Rogers
reviewerPATCH v11 12/19 perf c2c: Use perf_env e_machine rather than arch
In reply to Ian RogersUse the e_machine rather than arch string matching for AARCH64.
Add include of dwarf-regs.h in case the EM_AARCH64 isn't defined, sort the headers given this include.
--- tools/perf/builtin-c2c.c | 40 ++++++++++++++++++++++------------------ 1 file changed, 22 insertions(+), 18 deletions(-)
tools/perf/builtin-c2c.c +22 -18
@@ -12,41 +12,45 @@*/ #include <errno.h> #include <inttypes.h> + +#include <asm/bug.h> #include <linux/compiler.h> #include <linux/err.h> #include <linux/kernel.h> #include <linux/stringify.h> #include <linux/zalloc.h> -#include <asm/bug.h> #include <sys/param.h> -#include "debug.h" -#include "builtin.h" + +#include <dwarf-regs.h> #include <perf/cpumap.h> #include <subcmd/pager.h> #include <subcmd/parse-options.h> -#include "map_symbol.h" -#include "mem-events.h" -#include "session.h" -#include "hist.h" -#include "sort.h" -#include "tool.h" + +#include "builtin.h" #include "cacheline.h" #include "data.h" +#include "debug.h" #include "event.h" #include "evlist.h" #include "evsel.h" -#include "ui/browsers/hists.h" -#include "thread.h" -#include "mem2node.h" +#include "hist.h" +#include "map_symbol.h" +#include "mem-events.h" #include "mem-info.h" -#include "symbol.h" -#include "ui/ui.h" -#include "ui/progress.h" +#include "mem2node.h" #include "pmus.h" +#include "session.h" +#include "sort.h" #include "string2.h" -#include "util/util.h" -#include "util/symbol.h" +#include "symbol.h" +#include "thread.h" +#include "tool.h" +#include "ui/browsers/hists.h" +#include "ui/progress.h" +#include "ui/ui.h" #include "util/annotate.h" +#include "util/symbol.h" +#include "util/util.h" struct c2c_hists {struct hists hists;
@@ -3202,7 +3206,7 @@ static int perf_c2c__report(int argc, const char **argv)* default display type. */ if (!display) { -if (!strcmp (perf_env__arch (env),"arm64" )) +if (perf_env__e_machine (env,/*e_flags=*/ NULL ) ==EM_AARCH64 ) display ="peer" ;else display ="tot" ;
Signature · 1 line
2.54.0.929.g9b7fa37559-goog
Ian Rogers
reviewerPATCH v11 13/19 perf lock-contention: Use perf_env e_machine rather than arch
In reply to Ian RogersUse the e_machine rather than arch string matching for powerpc.
--- tools/perf/util/lock-contention.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
tools/perf/util/lock-contention.c +3 -3
@@ -104,7 +104,8 @@ bool match_callstack_filter(struct machine *machine, u64 *callstack, int max_stastruct map *kmap;struct symbol *sym;u64 ip; -const char *arch =perf_env__arch (machine->env); +uint16_t e_machine =perf_env__e_machine (machine->env,/*e_flags=*/ NULL ); +bool is_powerpc = e_machine ==EM_PPC64 || e_machine ==EM_PPC ;if (list_empty (&callstack_filters))return true;
@@ -125,8 +126,7 @@ bool match_callstack_filter(struct machine *machine, u64 *callstack, int max_sta* incase first or second callstack index entry has 0 * address for powerpc. */ -if (!callstack || (!callstack[i] && (strcmp (arch,"powerpc" ) || - (i !=1 && i !=2 )))) +if (!callstack || (!callstack[i] && (!is_powerpc || (i !=1 && i !=2 ))))break ; ip = callstack[i];
Signature · 1 line
2.54.0.929.g9b7fa37559-goog
[email protected]
AI reviewRe: [PATCH v11 13/19] perf lock-contention: Use perf_env e_machine rather than arch
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
Pre-existing issues:
- [High] Missing .feature callback in perf_tool initialization for pipe mode cross-platform analysis --
commit 6123af68f287b03d324e8ede7eac36aa4cd98913
Author: Ian Rogers <[email protected]>
perf lock-contention: Use perf_env e_machine rather than arch
Use the e_machine rather than arch string matching for powerpc.
tools/perf/util/lock-contention.c bool match_callstack_filter(struct machine *machine, u64 *callstack, int max_sta · line 107
Quoted 10 lines
tools/perf/util/lock-contention.c +1
-1@@ -104,7 +104,8 @@ bool match_callstack_filter(struct machine *machine, u64 *callstack, int max_stastruct map *kmap;struct symbol *sym;u64 ip; -const char *arch =perf_env__arch (machine->env); +uint16_t e_machine =perf_env__e_machine (machine->env,/*e_flags=*/ NULL );
[Severity: High]
This isn't a bug introduced by this patch, but won't this cross-platform analysis fail when running in pipe mode?
Looking at tools/perf/builtin-lock.c, the perf_tool initialization in both __cmd_contention() and __cmd_report() omits the feature callback:
perf_tool__init(&eops, /*ordered_events=*/true); eops.attr = perf_event__process_attr; eops.event_update = process_event_update; eops.sample = process_sample_event; eops.comm = perf_event__process_comm; eops.mmap = perf_event__process_mmap; eops.mmap2 = perf_event__process_mmap2; eops.tracing_data = perf_event__process_tracing_data; /* missing eops.feature = perf_event__process_feature; */
When reading a perf.data stream from a pipe, dropping the feature callback causes feature events (like HEADER_ARCH) to be silently dropped. This prevents machine->env from being properly populated.
Could this cause perf_env__e_machine() to incorrectly fall back to querying the host architecture via uname(), breaking cross-platform analysis entirely during pipe mode?
Quoted 4 lines
tools/perf/util/lock-contention.c +1
-0+bool is_powerpc = e_machine ==EM_PPC64 || e_machine ==EM_PPC ;if (list_empty (&callstack_filters))return true;
[ ... ]
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=13
Ian Rogers
reviewerPATCH v11 14/19 perf env: Refactor perf_env__arch_strerrno
In reply to Ian Rogersperf_env__arch_strerrno is only available with libtraceevent so hide the declaration if no libtraceevent.
The previous approach maps an architecture string to a function pointer to a function that takes an int errno values and returns a string. The new approach takes an e_machine and an errno value and returns a string.
As the only call site is in builtin-trace.c, the e_machine is already present and potentially more specific than the perf_env arch string that is a single global value.
The major complication in this approach is having the shell script that generates the C code map a linux directory name to the matching ELF machine constants.
--- tools/perf/builtin-trace.c | 7 ++-- tools/perf/trace/beauty/Build | 1 + tools/perf/trace/beauty/arch_errno_names.sh | 41 ++++++++++++++++++--- tools/perf/util/env.c | 13 ++----- tools/perf/util/env.h | 6 +-- 5 files changed, 46 insertions(+), 22 deletions(-)
tools/perf/builtin-trace.c +4 -3
@@ -3032,9 +3032,8 @@ static int trace__sys_exit(struct trace *trace, }else if (ret <0 ) { errno_print: {char bf[STRERR_BUFSIZE ]; -struct perf_env *env =evsel__env (evsel) ?: &trace->host_env;const char *emsg =str_error_r (-ret, bf,sizeof (bf)); -const char *e =perf_env__arch_strerrno (env, err); +const char *e =perf_env__arch_strerrno (e_machine, err);fprintf (trace->output,"-1 %s (%s)" , e, emsg); }
@@ -4921,7 +4920,9 @@ static size_t syscall__dump_stats(struct trace *trace, int e_machine, FILE *fp,for (e =0 ; e < stats->max_errno; ++e) {if (stats->errnos[e] !=0 ) -fprintf (fp,"\t\t\t\t%s: %d\n" ,perf_env__arch_strerrno (trace->host->env, e +1 ), stats->errnos[e]); +fprintf (fp,"\t\t\t\t%s: %d\n" , +perf_env__arch_strerrno (e_machine, e +1 ), + stats->errnos[e]); } } lines++;
tools/perf/trace/beauty/Build +1 -0
@@ -36,6 +36,7 @@ perf-y += signum.o perf-y += socket_type.o perf-y += waitid_options.o perf-util-y += arch_errno_names.o + perf-y += tracepoints/ ifdef SHELLCHECK
tools/perf/trace/beauty/arch_errno_names.sh +36 -5
63 lines not on this page · raw message
tools/perf/util/env.c +4 -9
@@ -851,16 +851,11 @@ const char *perf_env__arch(struct perf_env *env)return arch; } -const char *perf_env__arch_strerrno (struct perf_env *env__maybe_unused ,int err__maybe_unused ) -{ -#if defined(HAVE_LIBTRACEEVENT ) -if (env->arch_strerrno ==NULL ) - env->arch_strerrno =arch_syscalls__strerrno_function (perf_env__arch (env)); +const char *arch_syscalls__strerrno (uint16_t e_machine,int err); -return env->arch_strerrno ? env->arch_strerrno (err) :"no arch specific strerrno function" ; -#else -return "!HAVE_LIBTRACEEVENT" ; -#endif +const char *perf_env__arch_strerrno (uint16_t e_machine,int err) +{ +return arch_syscalls__strerrno (e_machine, err); }const char *perf_env__cpuid (struct perf_env *env)
tools/perf/util/env.h +1 -5
@@ -67,8 +67,6 @@ struct cpu_domain_map {struct domain_info **domains; }; -typedef const char *(arch_syscalls__strerrno_t )(int err); -struct perf_env {char *hostname;char *os_release;
@@ -158,7 +156,6 @@ struct perf_env {*/ bool enabled; } clock; -arch_syscalls__strerrno_t *arch_strerrno; };enum perf_compress_type {
@@ -191,8 +188,7 @@ void cpu_cache_level__free(struct cpu_cache_level *cache);uint16_t perf_env__e_machine_nocache (struct perf_env *env,uint32_t *e_flags);uint16_t perf_env__e_machine (struct perf_env *env,uint32_t *e_flags);const char *perf_env__arch (struct perf_env *env); -const char *perf_env__arch_strerrno (struct perf_env *env,int err); -arch_syscalls__strerrno_t *arch_syscalls__strerrno_function (const char *arch); +const char *perf_env__arch_strerrno (uint16_t e_machine,int err);const char *perf_env__cpuid (struct perf_env *env);const char *perf_env__raw_arch (struct perf_env *env);int perf_env__nr_cpus_avail (struct perf_env *env);
Signature · 1 line
2.54.0.929.g9b7fa37559-goog
[email protected]
AI reviewRe: [PATCH v11 14/19] perf env: Refactor perf_env__arch_strerrno
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider: - [Medium] The commit message claims to hide the declaration if libtraceevent is not present, but the code…
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The commit message claims to hide the declaration if libtraceevent is not present, but the code removes the conditional compilation, exposing it unconditionally.
- [Low] Generated C code uses newer ELF machine constants (e.g., EM_LOONGARCH, EM_CSKY) without fallback definitions, breaking the build on systems with older glibc. --
commit 39cf4406b4f1694948ce536342e5558e9e7d0701
Author: Ian Rogers <[email protected]>
perf env: Refactor perf_env__arch_strerrno
This commit refactors perf_env__arch_strerrno to take an e_machine and an errno value instead of an architecture string. It updates arch_errno_names.sh to generate an e_machine to function mapping and alters the call sites in builtin-trace.c to use the newly available e_machine.
Quoted 2 lines
perf_env__arch_strerrnois only available with libtraceevent so hide the declaration if no libtraceevent.
[Severity: Medium]
The commit message mentions hiding the declaration when libtraceevent is missing, but the patch actually removes the HAVE_LIBTRACEEVENT guards. Could the commit message be more precise about the intent?
Quoted 4 lines
tools/perf/trace/beauty/arch_errno_names.sh +0
-0
[ ... ]
Quoted 14 lines
tools/perf/trace/beauty/arch_errno_names.sh +10
-0@@ -52,21 +52,50 @@ process_arch() |IFS=, create_errno_lookup_func "$arch" } +arch_to_e_machine() +{ + case "$1" in + alpha) printf '\tcase EM_ALPHA:\n' ;; + arc) printf '\tcase EM_ARC:\n' ;; + arm) printf '\tcase EM_ARM:\n' ;; + arm64) printf '\tcase EM_AARCH64:\n' ;; + csky) printf '\tcase EM_CSKY:\n' ;; + hexagon) printf '\tcase EM_HEXAGON:\n' ;; + loongarch) printf '\tcase EM_LOONGARCH:\n' ;;
[ ... ]
tools/perf/trace/beauty/arch_errno_names.sh cat <<EoHEADER · line 109
Quoted 8 lines
tools/perf/trace/beauty/arch_errno_names.sh +2
-0@@ -74,6 +103,8 @@ cat <<EoHEADER /* SPDX-License-Identifier: GPL-2.0 */ #include <string.h> +#include <stdint.h> +#include <elf.h> EoHEADER
[Severity: Low]
Can this cause a build failure on systems with older glibc versions?
The script unconditionally outputs cases for newer ELF machine constants like EM_CSKY and EM_LOONGARCH into the generated C code, relying solely on the system elf.h.
If a host has an older glibc where these constants are not yet defined, it would result in undeclared identifier errors. Is a fallback definition or internal header needed here?
Quoted 4 lines
tools/perf/util/env.c +0
-0
[ ... ]
Quoted 9 lines
tools/perf/util/env.c +0
-5@@ -851,16 +851,11 @@ const char *perf_env__arch(struct perf_env *env)return arch; } -const char *perf_env__arch_strerrno (struct perf_env *env__maybe_unused ,int err__maybe_unused ) -{ -#if defined(HAVE_LIBTRACEEVENT ) -if (env->arch_strerrno ==NULL ) - env->arch_strerrno =arch_syscalls__strerrno_function (perf_env__arch (env));
tools/perf/util/env.c const char *perf_env__arch(struct perf_env *env) · line 859
Quoted 10 lines
tools/perf/util/env.c +4
-4+const char *arch_syscalls__strerrno (uint16_t e_machine,int err); -return env->arch_strerrno ? env->arch_strerrno (err) :"no arch specific strerrno function" ; -#else -return "!HAVE_LIBTRACEEVENT" ; -#endif +const char *perf_env__arch_strerrno (uint16_t e_machine,int err) +{ +return arch_syscalls__strerrno (e_machine, err); }
[Severity: Medium]
Does this unintentionally expose perf_env__arch_strerrno unconditionally?
The commit message states the intent is to hide the declaration if there is no libtraceevent, but this code removes the HAVE_LIBTRACEEVENT guards entirely.
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=14
Ian Rogers
reviewerPATCH v11 15/19 perf env: Remove unused perf_env__raw_arch
In reply to Ian RogersThe switch to using e_machine has made the perf_env__raw_arch function unused so remove it.
--- tools/perf/util/env.c | 18 ------------------ tools/perf/util/env.h | 1 - 2 files changed, 19 deletions(-)
tools/perf/util/env.c +0 -18
@@ -470,19 +470,6 @@ int perf_env__read_cpuid(struct perf_env *env)return 0 ; } -static int perf_env__read_arch (struct perf_env *env) -{ -struct utsname uts; - -if (env->arch) -return 0 ; - -if (!uname (&uts)) - env->arch =strdup (uts.machine); - -return env->arch ?0 : -ENOMEM ; -} -static int perf_env__read_nr_cpus_avail (struct perf_env *env) {if (env->nr_cpus_avail ==0 )
@@ -601,11 +588,6 @@ int perf_env__read_core_pmu_caps(struct perf_env *env)return ret; } -const char *perf_env__raw_arch (struct perf_env *env) -{ -return env && !perf_env__read_arch (env) ? env->arch :"unknown" ; -} -int perf_env__nr_cpus_avail (struct perf_env *env) {return env && !perf_env__read_nr_cpus_avail (env) ? env->nr_cpus_avail :0 ;
tools/perf/util/env.h +0 -1
@@ -190,7 +190,6 @@ uint16_t perf_env__e_machine(struct perf_env *env, uint32_t *e_flags);const char *perf_env__arch (struct perf_env *env);const char *perf_env__arch_strerrno (uint16_t e_machine,int err);const char *perf_env__cpuid (struct perf_env *env); -const char *perf_env__raw_arch (struct perf_env *env);int perf_env__nr_cpus_avail (struct perf_env *env);void perf_env__init (struct perf_env *env);
Signature · 1 line
2.54.0.929.g9b7fa37559-goog
Ian Rogers
reviewerPATCH v11 16/19 perf env: Add mutex to protect lazy environment initialization
In reply to Ian RogersIntroduce a mutex to 'struct perf_env' to safely protect lazy metadata setup, such as os_release or e_machine resolution, preventing concurrent initialization data races and memory leaks during multi-threaded profiling or symbol loading.
--- tools/perf/util/env.c | 3 +++ tools/perf/util/env.h | 3 +++ 2 files changed, 6 insertions(+)
tools/perf/util/env.c +3 -0
@@ -250,6 +250,8 @@ void perf_env__exit(struct perf_env *env) {int i, j; +mutex_destroy (&env->lock); +perf_env__purge_bpf (env);perf_env__purge_cgroups (env);zfree (&env->hostname);
@@ -307,6 +309,7 @@ void perf_env__init(struct perf_env *env)init_rwsem (&env->bpf_progs.lock);#endif env->kernel_is_64_bit =-1 ; +mutex_init (&env->lock); }static void perf_env__init_kernel_mode (struct perf_env *env)
tools/perf/util/env.h +3 -0
@@ -6,6 +6,7 @@#include <linux/rbtree.h> #include "cpumap.h" #include "rwsem.h" +#include "mutex.h" struct perf_cpu_map ;
@@ -156,6 +157,8 @@ struct perf_env {*/ bool enabled; } clock; +/* Protects lazy environment initialization (e.g. os_release, e_machine). */ +struct mutex lock; };enum perf_compress_type {
Signature · 1 line
2.54.0.929.g9b7fa37559-goog
[email protected]
AI reviewRe: [PATCH v11 16/19] perf env: Add mutex to protect lazy environment initialization
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] Calling `mutex_destroy()` on an uninitialized mutex in `perf_env__exit()` causes undefined…
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Calling mutex_destroy() on an uninitialized mutex in perf_env__exit() causes undefined behavior, as stack-allocated struct perf_env instances in helper functions bypass perf_env__init(). --
commit 08389321a4c748339a57c5404995d5a975c79c1e
Author: Ian Rogers <[email protected]>
perf env: Add mutex to protect lazy environment initialization
Introduce a mutex to 'struct perf_env' to safely protect lazy metadata setup, such as os_release or e_machine resolution, preventing concurrent initialization data races and memory leaks during multi-threaded profiling or symbol loading.
tools/perf/util/env.c void perf_env__exit(struct perf_env *env) · line 254
Quoted 10 lines
tools/perf/util/env.c +2
-0@@ -250,6 +250,8 @@ void perf_env__exit(struct perf_env *env) {int i, j; +mutex_destroy (&env->lock); +
[Severity: Medium]
Could this trigger undefined behavior when perf_env__exit() is called on stack-allocated environments that bypassed perf_env__init()?
For example, in x86__is_amd_cpu():
tools/perf/util/env.c:x86__is_amd_cpu() {
struct perf_env env = { .total_mem = 0, };
bool is_amd;
perf_env__cpuid(&env);
is_amd = perf_env__is_x86_amd_cpu(&env);
perf_env__exit(&env);
return is_amd;
}The local env variable is zero-initialized but perf_env__init() is never called, leaving env.lock uninitialized. Calling mutex_destroy() on an uninitialized mutex triggers undefined behavior and may cause crashes under sanitizers.
This same pattern also exists in x86__is_intel_cpu().
Quoted 3 lines
tools/perf/util/env.c +0
-0perf_env__purge_bpf (env);perf_env__purge_cgroups (env);zfree (&env->hostname);
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=16
Ian Rogers
reviewerPATCH v11 17/19 perf env: Add helper to lazily compute the os_release
In reply to Ian RogersIn live mode the os_release isn't being initialized, make a lazy initialization helper that assumes when the os_release isn't initialized this is live mode.
--- tools/perf/util/data-convert-bt.c | 2 +- tools/perf/util/data-convert-json.c | 6 +++-- tools/perf/util/env.c | 38 +++++++++++++++++++++++++++++ tools/perf/util/env.h | 1 + tools/perf/util/header.c | 16 ++++++++---- tools/perf/util/symbol.c | 4 +-- 6 files changed, 57 insertions(+), 10 deletions(-)
tools/perf/util/data-convert-bt.c +1 -1
@@ -1414,7 +1414,7 @@ do { \ADD ("host" , env->hostname);ADD ("sysname" ,"Linux" ); -ADD ("release" , env->os_release); +ADD ("release" ,perf_env__os_release (env));ADD ("version" , env->version);ADD ("machine" , env->arch);ADD ("domain" ,"kernel" );
tools/perf/util/data-convert-json.c +4 -2
@@ -16,6 +16,7 @@#include "linux/err.h" #include "util/auxtrace.h" #include "util/debug.h" +#include "util/env.h" #include "util/dso.h" #include "util/event.h" #include "util/evsel.h"
@@ -272,7 +273,7 @@ static void output_headers(struct perf_session *session, struct convert_json *c) {struct stat st;const struct perf_header *header = &session->header; -const struct perf_env *env =perf_session__env (session); +struct perf_env *env =perf_session__env (session);int ret;int fd =perf_data__fd (session->data);int i;
@@ -296,7 +297,8 @@ static void output_headers(struct perf_session *session, struct convert_json *c)output_json_key_format (out, true,2 ,"feat-offset" ,"%" PRIu64, header->feat_offset);output_json_key_string (out, true,2 ,"hostname" , env->hostname); -output_json_key_string (out, true,2 ,"os-release" , env->os_release); +output_json_key_string (out, true,2 ,"os-release" , +perf_env__os_release (env));output_json_key_string (out, true,2 ,"arch" , env->arch);if (env->cpu_desc)
tools/perf/util/env.c +38 -0
@@ -361,6 +361,44 @@ bool perf_arch_is_big_endian(const char *arch)return false; } +const char *perf_env__os_release (struct perf_env *env) +{ +struct utsname uts; +int ret; +const char *release; + +if (!env) +return perf_version_string; + +mutex_lock (&env->lock); +if (env->os_release) { + release = env->os_release; + goto out; + } + +/* +* If env->arch is set, this is an offline target environment. +* If the os_release is not populated in the file, we do not want +* to poison it with the host's release which would break guest checks. +*/ +if (env->arch) { + release =NULL ; + goto out; + } + +/* +* The os_release is being accessed but wasn't initialized from a data +* file, assume this is 'live' mode and use the release from uname. If +* uname or strdup fails then use the current perf tool version. +*/ + ret =uname (&uts); + env->os_release =strdup (ret <0 ? perf_version_string : uts.release); + release = env->os_release ?: perf_version_string; +out: +mutex_unlock (&env->lock); +return release; +} +int perf_env__set_cmdline (struct perf_env *env,int argc,const char *argv[]) {int i;
tools/perf/util/env.h +1 -0
@@ -176,6 +176,7 @@ void perf_env__exit(struct perf_env *env);int perf_env__kernel_is_64_bit (struct perf_env *env);bool perf_arch_is_big_endian (const char *arch); +const char *perf_env__os_release (struct perf_env *env);int perf_env__set_cmdline (struct perf_env *env,int argc,const char *argv[]);
tools/perf/util/header.c +11 -5
@@ -432,13 +432,19 @@ static int write_osrelease(struct feat_fd *ff, struct evlist *evlist __maybe_unused) {struct utsname uts; -int ret; +const char *release =NULL ; - ret =uname (&uts); -if (ret <0 ) -return -1 ; +if (evlist->session) + release =perf_env__os_release (perf_session__env (evlist->session)); -return do_write_string (ff, uts.release); +if (!release) { +int ret =uname (&uts); + +if (ret <0 ) +return -1 ; + release = uts.release; + } +return do_write_string (ff, release); }static int write_arch (struct feat_fd *ff,struct evlist *evlist)
tools/perf/util/symbol.c +2 -2
@@ -2225,7 +2225,7 @@ static int vmlinux_path__init(struct perf_env *env) {struct utsname uts;char bf[PATH_MAX ]; -char *kernel_version; +const char *kernel_version;unsigned int i; vmlinux_path = malloc(sizeof(char *) * (ARRAY_SIZE(vmlinux_paths) +
@@ -2242,7 +2242,7 @@ static int vmlinux_path__init(struct perf_env *env)return 0 ;if (env) { - kernel_version = env->os_release; + kernel_version =perf_env__os_release (env); }else {if (uname (&uts) <0 ) goto out_fail;
Signature · 1 line
2.54.0.929.g9b7fa37559-goog
[email protected]
AI reviewRe: [PATCH v11 17/19] perf env: Add helper to lazily compute the os_release
Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
New issues:
- [High] The perf_env__os_release helper incorrectly identifies pipe mode as live mode due to uninitialized env->arch, prematurely poisoning the environment with the host's OS release.
Pre-existing issues:
- [High] Passing a NULL pointer to snprintf with a %s format specifier causes Undefined Behavior and crashes.
- [High] Destroying and locking uninitialized synchronization primitives (mutex and rwlock).
--
commit 18f3f0f76a0f321e841ef41fc691a35a33c63e31
Author: Ian Rogers <[email protected]>
perf env: Add helper to lazily compute the os_release
In live mode the os_release isn't being initialized, make a lazy initialization helper that assumes when the os_release isn't initialized this is live mode.
[ ... ]
Quoted 4 lines
tools/perf/util/env.c +0
-0
[ ... ]
Quoted 18 lines
tools/perf/util/env.c +14
-0@@ -361,6 +361,44 @@ bool perf_arch_is_big_endian(const char *arch)return false; } +const char *perf_env__os_release (struct perf_env *env) +{ +struct utsname uts; +int ret; +const char *release; + +if (!env) +return perf_version_string; + +mutex_lock (&env->lock); +if (env->os_release) { + release = env->os_release; + goto out; + }
tools/perf/util/env.c bool perf_arch_is_big_endian(const char *arch) · line 387
Quoted 10 lines
tools/perf/util/env.c +10
-0+ +/* +* If env->arch is set, this is an offline target environment. +* If the os_release is not populated in the file, we do not want +* to poison it with the host's release which would break guest checks. +*/ +if (env->arch) { + release =NULL ; + goto out; + }
[Severity: High]
Does this correctly handle pipe mode?
In pipe mode, feature events are synthesized and embedded in the event stream, so they are not parsed during perf_session__new(). When tools like perf report invoke symbol__init() and vmlinux_path__init() before processing the event stream, env->arch is strictly NULL.
This causes the helper to erroneously assume live mode and permanently populate env->os_release with the host's release, which can break guest checks and cross-platform symbol resolution.
[Severity: High]
This is a pre-existing issue, but looking at perf_env__exit() in tools/perf/util/env.c, is it safe to destroy and lock uninitialized synchronization primitives?
In functions like x86__is_amd_cpu(), a stack-allocated struct perf_env is zero-initialized and never properly set up. When perf_env__exit(&env) is called later, it blindly calls mutex_destroy(&env->lock) and invokes perf_env__purge_bpf(env), which performs down_write(&env->bpf_progs.lock).
Operating on completely zero-filled mutexes and rwlocks can lead to undefined behavior and immediate aborts on strict libc implementations.
[ ... ]
Quoted 4 lines
tools/perf/util/symbol.c +0
-0
[ ... ]
tools/perf/util/symbol.c static int vmlinux_path__init(struct perf_env *env) · line 2245
Quoted 6 lines
tools/perf/util/symbol.c +1
-1@@ -2242,7 +2242,7 @@ static int vmlinux_path__init(struct perf_env *env)return 0 ;if (env) { - kernel_version = env->os_release; + kernel_version =perf_env__os_release (env);
[Severity: High]
This isn't a bug introduced by this patch, but if perf_env__os_release(env) returns NULL (which happens intentionally for offline targets lacking the HEADER_OSRELEASE feature), kernel_version becomes NULL.
Shortly after this assignment, kernel_version is unconditionally passed into snprintf via the %s format specifier:
snprintf(bf, sizeof(bf), vmlinux_paths_upd[i], kernel_version);
Could passing a NULL pointer to %s cause undefined behavior and potential crashes in hardened builds or on strict libc implementations?
Quoted 3 lines
tools/perf/util/symbol.c +0
-0}else {if (uname (&uts) <0 ) goto out_fail;
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=17
Ian Rogers
reviewerPATCH v11 18/19 perf symbol: Add setters for bitfields sharing a byte to avoid concurrent update issues
In reply to Ian RogersA problem with putting bitfields into struct symbol is that other bits in the symbol could be updated concurrently and only one update to the underlying storage unit happen, leading to lost updates.
To avoid this, use atomics to atomically read or set part of 16-bits of flags in the symbol. Add accessors to simplify this.
The idle value has 3 values in preparation for a later change that will lazily update it.
--- tools/perf/builtin-inject.c | 10 +-- tools/perf/builtin-kwork.c | 2 +- tools/perf/builtin-report.c | 2 +- tools/perf/builtin-sched.c | 4 +- tools/perf/builtin-top.c | 7 +- tools/perf/tests/symbols.c | 2 +- tools/perf/tests/vmlinux-kallsyms.c | 2 +- tools/perf/ui/browsers/annotate.c | 2 +- tools/perf/ui/browsers/map.c | 4 +- tools/perf/util/annotate.c | 5 +- tools/perf/util/auxtrace.c | 6 +- tools/perf/util/callchain.c | 4 +- tools/perf/util/dlfilter.c | 2 +- tools/perf/util/evsel_fprintf.c | 6 +- tools/perf/util/intel-pt.c | 2 +- tools/perf/util/libdw.c | 2 +- tools/perf/util/machine.c | 2 +- tools/perf/util/probe-event.c | 4 +- .../util/scripting-engines/trace-event-perl.c | 2 +- .../scripting-engines/trace-event-python.c | 4 +- tools/perf/util/sort.c | 8 +- tools/perf/util/srcline.c | 10 +-- tools/perf/util/symbol-elf.c | 3 +- tools/perf/util/symbol.c | 86 +++++++++++++++---- tools/perf/util/symbol.h | 78 +++++++++++++---- tools/perf/util/symbol_fprintf.c | 4 +- 26 files changed, 183 insertions(+), 80 deletions(-)
tools/perf/builtin-inject.c +4 -6
@@ -549,13 +549,11 @@ static int perf_event__convert_sample_callchain(const struct perf_tool *tool, node = cursor->first;for (k =0 ; k < cursor->nr && i <PERF_MAX_STACK_DEPTH ; k++) { -if (machine->single_address_space && -machine__kernel_ip (machine, node->ip)) -/* kernel IPs were added already */ ; -else if (node->ms.sym && node->ms.sym->inlined) -/* we can't handle inlined callchains */ ; -else +if (!(machine->single_address_space && +machine__kernel_ip (machine, node->ip)) && + !(node->ms.sym &&symbol__inlined (node->ms.sym))) { inject->raw_callchain->ips[i++] = node->ip; + } node = node->next; }
tools/perf/builtin-kwork.c +1 -1
@@ -769,7 +769,7 @@ static void timehist_save_callchain(struct perf_kwork *kwork,if (sym) {if (!strcmp (sym->name,"__softirqentry_text_start" ) || !strcmp (sym->name,"__do_softirq" )) - sym->ignore =1 ; +symbol__set_ignore (sym, true); }callchain_cursor_advance (cursor);
tools/perf/builtin-report.c +1 -1
@@ -749,7 +749,7 @@ static int hists__resort_cb(struct hist_entry *he, void *arg)struct report *rep = arg;struct symbol *sym = he->ms.sym; -if (rep->symbol_ipc && sym && !sym->annotate2) { +if (rep->symbol_ipc && sym && !symbol__is_annotate2 (sym)) {struct evsel *evsel =hists_to_evsel (he->hists);symbol__annotate2 (&he->ms, evsel,NULL );
tools/perf/builtin-sched.c +2 -2
@@ -2367,7 +2367,7 @@ static void save_task_callchain(struct perf_sched *sched,if (!strcmp (sym->name,"schedule" ) || !strcmp (sym->name,"__schedule" ) || !strcmp (sym->name,"preempt_schedule" )) - sym->ignore =1 ; +symbol__set_ignore (sym, true); }callchain_cursor_advance (cursor);
@@ -3025,7 +3025,7 @@ static size_t callchain__fprintf_folded(FILE *fp, struct callchain_node *node)list_for_each_entry (chain, &node->val, list) {if (chain->ip >=PERF_CONTEXT_MAX )continue ; -if (chain->ms.sym && chain->ms.sym->ignore) +if (chain->ms.sym &&symbol__ignore (chain->ms.sym))continue ; ret += fprintf(fp, "%s%s", first ? "" : sep, callchain_list__sym_name(chain, bf, sizeof(bf),
tools/perf/builtin-top.c +4 -3
@@ -186,8 +186,8 @@ static void ui__warn_map_erange(struct map *map, struct symbol *sym, u64 ip)"Please report to [email protected]\n" , ip,dso__long_name (dso),dso__symtab_origin (dso),map__start (map),map__end (map), sym->start, sym->end, - sym->binding ==STB_GLOBAL ?'g' : - sym->binding ==STB_LOCAL ?'l' :'w' , sym->name, +symbol__binding (sym) ==STB_GLOBAL ?'g' : +symbol__binding (sym) ==STB_LOCAL ?'l' :'w' , sym->name, err ?"[unknown]" : uts.machine, err ? "[unknown]" : uts.release, perf_version_string);if (use_browser <=0 )
@@ -828,7 +828,8 @@ static void perf_event__process_sample(const struct perf_tool *tool, } } -if (al.sym ==NULL || !al.sym->idle) { +if (al.sym ==NULL || + !symbol__is_idle (al.sym, al.map ?map__dso (al.map) :NULL , machine->env)) {struct hists *hists =evsel__hists (sample->evsel);struct hist_entry_iter iter = { .sample = sample,
tools/perf/tests/symbols.c +1 -1
@@ -125,7 +125,7 @@ static int test_dso(struct dso *dso)for (nd =rb_first_cached (dso__symbols (dso)); nd; nd =rb_next (nd)) { struct symbol *sym = rb_entry(nd, struct symbol, rb_node); -if (sym->type !=STT_FUNC && sym->type !=STT_GNU_IFUNC ) +if (symbol__type (sym) !=STT_FUNC &&symbol__type (sym) !=STT_GNU_IFUNC )continue ;/* Check for overlapping function symbols */
tools/perf/tests/vmlinux-kallsyms.c +1 -1
@@ -346,7 +346,7 @@ static int test__vmlinux_matches_kallsyms(struct test_suite *test __maybe_unused* such as __indirect_thunk_end. */ continue ; - }else if (is_ignored_symbol (sym->name, sym->type)) { + }else if (is_ignored_symbol (sym->name,symbol__type (sym))) {/* * Ignore hidden symbols, see scripts/kallsyms.c for the details */
tools/perf/ui/browsers/annotate.c +1 -1
@@ -1185,7 +1185,7 @@ int __hist_entry__tui_annotate(struct hist_entry *he, struct map_symbol *ms,if (dso__annotate_warned (dso))return -1 ; -if (not_annotated || !sym->annotate2) { +if (not_annotated || !symbol__is_annotate2 (sym)) { err =symbol__annotate2 (ms, evsel, &browser.arch);if (err) {annotate_browser__symbol_annotate_error (&browser, err);
tools/perf/ui/browsers/map.c +2 -2
@@ -32,8 +32,8 @@ static void map_browser__write(struct ui_browser *browser, void *nd, int row)ui_browser__set_percent_color (browser,0 , current_entry);ui_browser__printf (browser,"%*" PRIx64" %*" PRIx64" %c " , mb->addrlen, sym->start, mb->addrlen, sym->end, - sym->binding ==STB_GLOBAL ?'g' : - sym->binding ==STB_LOCAL ?'l' :'w' ); +symbol__binding (sym) ==STB_GLOBAL ?'g' : +symbol__binding (sym) ==STB_LOCAL ?'l' :'w' ); width = browser->width - ((mb->addrlen *2 ) +4 );if (width >0 )ui_browser__write_nstring (browser, sym->name, width);
tools/perf/util/annotate.c +3 -2
@@ -236,7 +236,8 @@ static int __symbol__inc_addr_samples(struct map_symbol *ms, h =annotated_source__histogram (src, evsel);if (h ==NULL ) {pr_debug ("%s(%d): ENOMEM! sym->name=%s, start=%#" PRIx64", addr=%#" PRIx64", end=%#" PRIx64", func: %d\n" , - __func__, __LINE__, sym->name, sym->start, addr, sym->end, sym->type ==STT_FUNC ); + __func__, __LINE__, sym->name, sym->start, addr, sym->end, +symbol__type (sym) ==STT_FUNC );return -ENOMEM ; }
@@ -2223,7 +2224,7 @@ int symbol__annotate2(struct map_symbol *ms, struct evsel *evsel,annotation__init_column_widths (notes, sym);annotation__update_column_widths (notes); - sym->annotate2 =1 ; +symbol__set_annotate2 (sym, true);return 0 ; }
tools/perf/util/auxtrace.c +3 -3
@@ -2694,7 +2694,7 @@ static bool dso_sym_match(struct symbol *sym, const char *name, int *cnt, {/* Same name, and global or the n'th found or any */ return !arch__compare_symbol_names (name, sym->name) && - ((!idx && sym->binding ==STB_GLOBAL ) || + ((!idx &&symbol__binding (sym) ==STB_GLOBAL ) || (idx >0 && ++*cnt == idx) || idx <0 ); }
@@ -2712,8 +2712,8 @@ static void print_duplicate_syms(struct dso *dso, const char *sym_name)if (dso_sym_match (sym, sym_name, &cnt,-1 )) {pr_err ("#%d\t0x%" PRIx64"\t%c\t%s\n" , ++cnt, sym->start, - sym->binding ==STB_GLOBAL ?'g' : - sym->binding ==STB_LOCAL ?'l' :'w' , +symbol__binding (sym) ==STB_GLOBAL ?'g' : +symbol__binding (sym) ==STB_LOCAL ?'l' :'w' , sym->name); near = true; }else if (near) {
tools/perf/util/callchain.c +2 -2
@@ -801,7 +801,7 @@ static enum match_result match_chain(struct callchain_cursor_node *node,* symbol start. Otherwise do a faster comparison based * on the symbol start address. */ -if (cnode->ms.sym->inlined || node->ms.sym->inlined) { +if (symbol__inlined (cnode->ms.sym) ||symbol__inlined (node->ms.sym)) { match =match_chain_strings (cnode->ms.sym->name, node->ms.sym->name);if (match !=MATCH_ERROR )
@@ -1245,7 +1245,7 @@ char *callchain_list__sym_name(struct callchain_list *cl,int printed;if (cl->ms.sym) { -const char *inlined = cl->ms.sym->inlined ?" (inlined)" :"" ; +const char *inlined =symbol__inlined (cl->ms.sym) ?" (inlined)" :"" ;if (show_srcline && cl->srcline) printed = scnprintf(bf, bfsize, "%s %s%s",
tools/perf/util/dlfilter.c +1 -1
@@ -56,7 +56,7 @@ static void al_to_d_al(struct addr_location *al, struct perf_dlfilter_al *d_al) d_al->symoff = al->addr -map__start (al->map) - sym->start; else d_al->symoff = 0; - d_al->sym_binding = sym->binding; + d_al->sym_binding =symbol__binding (sym); }else { d_al->sym =NULL ; d_al->sym_start =0 ;
tools/perf/util/evsel_fprintf.c +3 -3
@@ -146,7 +146,7 @@ int sample__fprintf_callchain(struct perf_sample *sample, int left_alignment, sym = node->ms.sym; map = node->ms.map; -if (sym && sym->ignore && print_skip_ignored) +if (sym &&symbol__ignore (sym) && print_skip_ignored) goto next; printed +=fprintf (fp,"%-*.*s" , left_alignment, left_alignment," " );
@@ -182,7 +182,7 @@ int sample__fprintf_callchain(struct perf_sample *sample, int left_alignment,addr_location__exit (&node_al); } -if (print_dso && (!sym || !sym->inlined)) +if (print_dso && (!sym || !symbol__inlined (sym))) printed +=map__fprintf_dsoname_dsoff (map, print_dsoff, addr, fp);if (print_srcline) {
@@ -192,7 +192,7 @@ int sample__fprintf_callchain(struct perf_sample *sample, int left_alignment, printed +=map__fprintf_srcline (map, addr,"\n " , fp); } -if (sym && sym->inlined) +if (sym &&symbol__inlined (sym)) printed +=fprintf (fp," (inlined)" );if (!print_oneline)
tools/perf/util/intel-pt.c +1 -1
@@ -3000,7 +3000,7 @@ static u64 intel_pt_switch_ip(struct intel_pt *pt, u64 *ptss_ip) start =dso__first_symbol (map__dso (map));for (sym = start; sym; sym =dso__next_symbol (sym)) { -if (sym->binding ==STB_GLOBAL && +if (symbol__binding (sym) ==STB_GLOBAL && !strcmp (sym->name,"__switch_to" )) { ip =map__unmap_ip (map, sym->start);if (ip >=map__start (map) && ip <map__end (map)) {
tools/perf/util/libdw.c +1 -1
@@ -130,7 +130,7 @@ static int libdw_a2l_cb(Dwarf_Die *die, void *_args)return 0 ; abort_delete_sym: -if (inline_sym->inlined) +if (symbol__inlined (inline_sym))symbol__delete (inline_sym); abort_enomem: args->err = -ENOMEM ;
tools/perf/util/machine.c +1 -1
@@ -1095,7 +1095,7 @@ static u64 find_entry_trampoline(struct dso *dso)unsigned int i;for (; sym; sym =dso__next_symbol (sym)) { -if (sym->binding !=STB_GLOBAL ) +if (symbol__binding (sym) !=STB_GLOBAL )continue ;for (i =0 ; i <ARRAY_SIZE (syms); i++) {if (!strcmp (sym->name, syms[i]))
tools/perf/util/probe-event.c +2 -2
@@ -416,7 +416,7 @@ static int find_alternative_probe_point(struct debuginfo *dinfo,map__for_each_symbol_by_name (map, pp->function, sym, idx) {if (uprobes) { address = sym->start; -if (sym->type ==STT_GNU_IFUNC ) +if (symbol__type (sym) ==STT_GNU_IFUNC )pr_warning ("Warning: The probe function (%s) is a GNU indirect function.\n" "Consider identifying the final function used at run time and set the probe directly on that.\n" , pp->function);
@@ -3189,7 +3189,7 @@ static int find_probe_trace_events_from_map(struct perf_probe_event *pev,for (j =0 ; j < num_matched_functions; j++) { sym = syms[j]; -if (sym->type !=STT_FUNC ) +if (symbol__type (sym) !=STT_FUNC )continue ;/* There can be duplicated symbols in the map */
tools/perf/util/scripting-engines/trace-event-perl.c +1 -1
@@ -303,7 +303,7 @@ static SV *perl_process_callchain(struct perf_sample *sample, }if (!hv_stores (sym,"start" ,newSVuv (node->ms.sym->start)) || !hv_stores (sym,"end" ,newSVuv (node->ms.sym->end)) || - !hv_stores (sym,"binding" ,newSVuv (node->ms.sym->binding)) || + !hv_stores (sym,"binding" ,newSVuv (symbol__binding (node->ms.sym))) || !hv_stores (sym,"name" ,newSVpvn (node->ms.sym->name, node->ms.sym->namelen)) || !hv_stores (elem,"sym" ,newRV_noinc ((SV *)sym))) {
tools/perf/util/scripting-engines/trace-event-python.c +2 -2
@@ -436,7 +436,7 @@ static PyObject *python_process_callchain(struct perf_sample *sample,pydict_set_item_string_decref (pysym,"end" ,PyLong_FromUnsignedLongLong (node->ms.sym->end));pydict_set_item_string_decref (pysym,"binding" , -_PyLong_FromLong (node->ms.sym->binding)); +_PyLong_FromLong (symbol__binding (node->ms.sym)));pydict_set_item_string_decref (pysym,"name" ,_PyUnicode_FromStringAndSize (node->ms.sym->name, node->ms.sym->namelen));
@@ -1270,7 +1270,7 @@ static int python_export_symbol(struct db_export *dbe, struct symbol *sym,tuple_set_d64 (t,1 ,dso__db_id (dso));tuple_set_d64 (t,2 , sym->start);tuple_set_d64 (t,3 , sym->end); -tuple_set_s32 (t,4 , sym->binding); +tuple_set_s32 (t,4 ,symbol__binding (sym));tuple_set_string (t,5 , sym->name);call_object (tables->symbol_handler, t,"symbol_table" );
tools/perf/util/sort.c +4 -4
@@ -469,7 +469,7 @@ int64_t _sort__sym_cmp(struct symbol *sym_l, struct symbol *sym_r)if (sym_l == sym_r)return 0 ; -if (sym_l->inlined || sym_r->inlined) { +if (symbol__inlined (sym_l) ||symbol__inlined (sym_r)) {int ret =strcmp (sym_l->name, sym_r->name);if (ret)
@@ -536,7 +536,7 @@ static int _hist_entry__sym_snprintf(struct map_symbol *ms, ret +=repsep_snprintf (bf + ret, size - ret,"[%c] " , level);if (sym && map) { -if (sym->type ==STT_OBJECT ) { +if (symbol__type (sym) ==STT_OBJECT ) { ret +=repsep_snprintf (bf + ret, size - ret,"%s" , sym->name); ret +=repsep_snprintf (bf + ret, size - ret,"+0x%llx" , ip -map__unmap_ip (map, sym->start));
@@ -544,7 +544,7 @@ static int _hist_entry__sym_snprintf(struct map_symbol *ms, ret +=repsep_snprintf (bf + ret, size - ret,"%.*s" , width - ret, sym->name); -if (sym->inlined) +if (symbol__inlined (sym)) ret +=repsep_snprintf (bf + ret, size - ret," (inlined)" ); }
@@ -1483,7 +1483,7 @@ static int _hist_entry__addr_snprintf(struct map_symbol *ms, ret +=repsep_snprintf (bf + ret, size - ret,"[%c] " , level);if (sym && map) { -if (sym->type ==STT_OBJECT ) { +if (symbol__type (sym) ==STT_OBJECT ) { ret +=repsep_snprintf (bf + ret, size - ret,"%s" , sym->name); ret +=repsep_snprintf (bf + ret, size - ret,"+0x%llx" , ip -map__unmap_ip (map, sym->start));
tools/perf/util/srcline.c +5 -5
@@ -113,16 +113,16 @@ struct symbol *new_inline_sym(struct dso *dso,/* ensure that we don't alias an inlined symbol, which could * lead to double frees in inline_node__delete */ -assert (!base_sym->inlined); +assert (!symbol__inlined (base_sym)); }else {/* create a fake symbol for the inline frame */ inline_sym =symbol__new (base_sym ? base_sym->start :0 , base_sym ? (base_sym->end - base_sym->start) :0 , - base_sym ? base_sym->binding :0 , - base_sym ? base_sym->type :0 , + base_sym ?symbol__binding (base_sym) :0 , + base_sym ?symbol__type (base_sym) :0 , funcname);if (inline_sym) - inline_sym->inlined =1 ; +symbol__set_inlined (inline_sym, true); }free (demangled);
@@ -440,7 +440,7 @@ void inline_node__clear_frames(struct inline_node *node)list_del_init (&ilist->list);zfree_srcline (&ilist->srcline);/* only the inlined symbols are owned by the list */ -if (ilist->symbol && ilist->symbol->inlined) +if (ilist->symbol &&symbol__inlined (ilist->symbol))symbol__delete (ilist->symbol);free (ilist); }
tools/perf/util/symbol-elf.c +2 -1
@@ -350,7 +350,8 @@ static bool get_ifunc_name(Elf *elf, struct dso *dso, GElf_Ehdr *ehdr, sym =dso__find_symbol_nocache (dso, addr);/* Expecting the address to be an IFUNC or IFUNC alias */ -if (!sym || sym->start != addr || (sym->type !=STT_GNU_IFUNC && !sym->ifunc_alias)) +if (!sym || sym->start != addr || + (symbol__type (sym) !=STT_GNU_IFUNC && !symbol__ifunc_alias (sym)))return false;snprintf (buf, buf_sz,"%s@plt" , sym->name);
tools/perf/util/symbol.c +70 -16
153 lines not on this page · raw message
tools/perf/util/symbol.h +63 -15
114 lines not on this page · raw message
tools/perf/util/symbol_fprintf.c +2 -2
@@ -11,8 +11,8 @@ size_t symbol__fprintf(struct symbol *sym, FILE *fp) {return fprintf (fp," %" PRIx64"-%" PRIx64" %c %s\n" , sym->start, sym->end, - sym->binding ==STB_GLOBAL ?'g' : - sym->binding ==STB_LOCAL ?'l' :'w' , +symbol__binding (sym) ==STB_GLOBAL ?'g' : +symbol__binding (sym) ==STB_LOCAL ?'l' :'w' , sym->name); }
Signature · 1 line
2.54.0.929.g9b7fa37559-goog
Ian Rogers
reviewerPATCH v11 19/19 perf symbol: Lazily compute idle
In reply to Ian RogersSwitch from an idle boolean to a helper symbol__is_idle function. In the function lazily compute whether a symbol is an idle function taking into consideration the kernel version and architecture of the machine. As symbols__insert no longer needs to know if a symbol is for the kernel, remove the argument.
To protect against drop-filtering of legitimate setup, online, or hotplug management functions (such as intel_idle_init), x86 matches are strictly constrained to exact known run-loops (intel_idle, intel_idle_irq, mwait_idle, mwait_idle_with_hints).
If the target environment OS release is unresolvable (such as on guest traces), default to treating psw_idle as idle to prevent false negatives and match legacy trace behavior safely.
This change is inspired by mailing list discussion, particularly from Thomas Richter <[email protected]> and Heiko Carstens <[email protected]>:
https://lore.kernel.org/lkml/[email protected]/
--- tools/perf/util/symbol-elf.c | 2 +- tools/perf/util/symbol.c | 146 +++++++++++++++++++++++------------ tools/perf/util/symbol.h | 4 +- 3 files changed, 100 insertions(+), 52 deletions(-)
tools/perf/util/symbol-elf.c +1 -1
@@ -1734,7 +1734,7 @@ dso__load_sym_internal(struct dso *dso, struct map *map, struct symsrc *syms_ss,arch__sym_update (f, &sym); -__symbols__insert (dso__symbols (curr_dso), f,dso__kernel (dso)); +__symbols__insert (dso__symbols (curr_dso), f); nr++; }dso__put (curr_dso);
tools/perf/util/symbol.c +98 -48
215 lines not on this page · raw message
tools/perf/util/symbol.h +1 -3
@@ -76,7 +76,6 @@ enum symbol_idle_kind {#define SYMBOL_FLAG_INLINED (1 << 11)#define SYMBOL_FLAG_ANNOTATE2 (1 << 12)#define SYMBOL_FLAG_IFUNC_ALIAS (1 << 13) -/** * A symtab entry. When allocated this may be preceded by an annotation (see * symbol__annotation) and/or a browser_index (see symbol__browser_index).
@@ -257,8 +256,7 @@ int dso__synthesize_plt_symbols(struct dso *dso, struct symsrc *ss);char *dso__demangle_sym (struct dso *dso,int kmodule,const char *elf_name); -void __symbols__insert (struct rb_root_cached *symbols,struct symbol *sym, -bool kernel); +void __symbols__insert (struct rb_root_cached *symbols,struct symbol *sym);void symbols__insert (struct rb_root_cached *symbols,struct symbol *sym);void symbols__fixup_duplicate (struct rb_root_cached *symbols);void symbols__fixup_end (struct rb_root_cached *symbols,bool is_kallsyms);
Signature · 1 line
2.54.0.929.g9b7fa37559-goog
Ian Rogers
reviewerv12 cover perf: Use e_machine and lazily compute symbols
In reply to Ian RogersAdd a helper to perf_env to compute the e_machine if it is EM_NONE. Derive the value from the arch string if available. Similarly derive the arch string from the ELF machine if available, for consistency. This means perf's arch (machine type) is no longer determined by uname but set to match that of the perf ELF executable.
Migrate code away from strcmp on env->arch to using the e_machine comparisons that are more accurate and not prone to uname and other naming differences. While cleaning this up, also clean up the capstone initialization code to cover more architectures and to set the big endian flag based on ELF header information.
Refactor perf_env__arch_strerrno to take an e_machine instead of an architecture string, removing the HAVE_LIBTRACEEVENT dependency entirely and making it unconditionally available. The generated errno table includes fallback definitions for newer ELF machine constants to ensure compatibility with older host glibc versions.
Introduce a mutex in perf_env to safely protect lazy metadata setup, such as os_release or e_machine resolution, preventing concurrent initialization data races and memory leaks during multi-threaded profiling or symbol loading. Properly initialize stack-allocated perf_env instances to ensure safe mutex destruction.
Switch the idle computation to the point of use and lazily compute it, rather than computing it for every symbol. The current only user is perf top. At the point of use the perf_env is available and this can be used to make sure the idle function computation correctly accounts for architecture-specific and kernel-version-specific patterns. To prevent concurrent updates to shared symbol bitfield flags, migrate bitfield variables in struct symbol to C11 atomic flags.
Ian Rogers (19):
perf env: Add perf_env__e_machine helper and use in perf_env__arch perf tests topology: Switch env->arch use to env->e_machine perf env, dso, thread: Add _endian variants for e_machine helpers perf capstone: Determine architecture from e_machine perf print_insn: Use e_machine for fallback IP length check perf symbol: Avoid use of machine__is
perf machine: Use perf_env e_machine rather than arch perf sample-raw: Use perf_env e_machine rather than arch perf sort: Use perf_env e_machine rather than arch
perf arch common: Use perf_env e_machine rather than arch perf header: In print_pmu_caps use perf_env e_machine perf c2c: Use perf_env e_machine rather than arch
perf lock-contention: Use perf_env e_machine rather than arch perf env: Refactor perf_env__arch_strerrno
perf env: Remove unused perf_env__raw_arch
perf env: Add mutex to protect lazy environment initialization perf env: Add helper to lazily compute the os_release perf symbol: Add setters for bitfields sharing a byte to avoid
concurrent update issues
perf symbol: Lazily compute idle
tools/perf/arch/common.c | 92 +++-- tools/perf/builtin-c2c.c | 40 +- tools/perf/builtin-inject.c | 10 +- tools/perf/builtin-kwork.c | 2 +- tools/perf/builtin-report.c | 2 +- tools/perf/builtin-sched.c | 4 +- tools/perf/builtin-top.c | 7 +- tools/perf/builtin-trace.c | 7 +- tools/perf/tests/symbols.c | 2 +- tools/perf/tests/topology.c | 8 +- tools/perf/tests/vmlinux-kallsyms.c | 2 +- tools/perf/trace/beauty/Build | 1 + tools/perf/trace/beauty/arch_errno_names.sh | 53 ++- tools/perf/ui/browsers/annotate.c | 2 +- tools/perf/ui/browsers/map.c | 4 +- tools/perf/util/annotate.c | 5 +- tools/perf/util/auxtrace.c | 6 +- tools/perf/util/callchain.c | 4 +- tools/perf/util/capstone.c | 132 ++++-- tools/perf/util/data-convert-bt.c | 2 +- tools/perf/util/data-convert-json.c | 6 +- tools/perf/util/dlfilter.c | 2 +- tools/perf/util/dso.c | 19 +- tools/perf/util/dso.h | 14 +- tools/perf/util/env.c | 376 ++++++++++++++---- tools/perf/util/env.h | 14 +- tools/perf/util/evsel_fprintf.c | 6 +- tools/perf/util/header.c | 55 ++- tools/perf/util/intel-pt.c | 2 +- tools/perf/util/libdw.c | 2 +- tools/perf/util/lock-contention.c | 6 +- tools/perf/util/machine.c | 37 +- tools/perf/util/machine.h | 2 - tools/perf/util/print_insn.c | 23 +- tools/perf/util/print_insn.h | 2 + tools/perf/util/probe-event.c | 4 +- tools/perf/util/sample-raw.c | 21 +- tools/perf/util/sample-raw.h | 6 +- .../util/scripting-engines/trace-event-perl.c | 2 +- .../scripting-engines/trace-event-python.c | 4 +- tools/perf/util/session.c | 26 +- tools/perf/util/sort.c | 66 +-- tools/perf/util/srcline.c | 10 +- tools/perf/util/symbol-elf.c | 5 +- tools/perf/util/symbol.c | 238 ++++++++--- tools/perf/util/symbol.h | 80 +++- tools/perf/util/symbol_fprintf.c | 4 +- tools/perf/util/thread.c | 58 ++- tools/perf/util/thread.h | 23 +- 49 files changed, 1078 insertions(+), 420 deletions(-)
Signature · 1 line
2.54.0.929.g9b7fa37559-goog
Ian Rogers
reviewerPATCH v12 1/19 perf env: Add perf_env__e_machine helper and use in perf_env__arch
Add a helper that lazily computes the e_machine and falls back to EM_HOST. Use the perf_env's arch to compute the e_machine if available, using a binary search for efficiency while handling duplicate rules.
Switch perf_env__arch to be derived from e_machine for consistency. To support 32-bit compat binaries on 64-bit hosts during dynamic local or live operations, unpopulated arch fallback paths query uname() at runtime to dynamically resolve the correct host e_machine, safely preventing bitness misclassification regressions.
Update session and header to use the helper to safely record e_machine and flags without forcing premature thread scanning.
--- tools/perf/util/env.c | 286 ++++++++++++++++++++++++++++++++------ tools/perf/util/env.h | 2 + tools/perf/util/header.c | 32 +++-- tools/perf/util/session.c | 26 ++-- 4 files changed, 282 insertions(+), 64 deletions(-)
tools/perf/util/env.c +243 -43
@@ -1,10 +1,12 @@// SPDX-License-Identifier: GPL-2.0 #include "cpumap.h" +#include "dwarf-regs.h" #include "debug.h" #include "env.h" #include "util/header.h" #include "util/rwsem.h" #include <linux/compiler.h> +#include <linux/kernel.h> #include <linux/ctype.h> #include <linux/rbtree.h> #include <linux/string.h>
@@ -309,15 +311,27 @@ void perf_env__init(struct perf_env *env)static void perf_env__init_kernel_mode (struct perf_env *env) { -const char *arch =perf_env__raw_arch (env); +const char *arch = env->arch; -if (!strncmp (arch,"x86_64" ,6 ) || !strncmp (arch,"aarch64" ,7 ) || - !strncmp (arch,"arm64" ,5 ) || !strncmp (arch,"mips64" ,6 ) || - !strncmp (arch,"parisc64" ,8 ) || !strncmp (arch,"riscv64" ,7 ) || - !strncmp (arch,"s390x" ,5 ) || !strncmp (arch,"sparc64" ,7 )) - env->kernel_is_64_bit =1 ; -else - env->kernel_is_64_bit =0 ; +if (!arch) { +static struct utsname uts = { .machine[0 ] ='\0' , }; + +if (uts.machine[0 ] =='\0' ) +uname (&uts); +if (uts.machine[0 ] !='\0' ) + arch = uts.machine; + } + +if (arch) { +if (strstr (arch,"64" ) ||strstr (arch,"s390x" )) + env->kernel_is_64_bit =1 ; +else + env->kernel_is_64_bit =0 ; +return ; + } + +/* Fallback if completely unresolvable (assume host-bitness) */ + env->kernel_is_64_bit = (sizeof (void *) ==8 ) ?1 :0 ; }int perf_env__kernel_is_64_bit (struct perf_env *env)
@@ -588,51 +602,237 @@ void cpu_cache_level__free(struct cpu_cache_level *cache)zfree (&cache->size); } +struct arch_to_e_machine { +const char *prefix; +uint16_t e_machine; +}; +/* -* Return architecture name in a normalized form. -* The conversion logic comes from the Makefile. +* A mapping from an arch prefix string to an ELF machine that can be used in a +* bsearch. Some arch prefixes are shared an need additional processing as +* marked next to the architecture. The prefixes handle both perf's architecture +* naming and those from uname. */ -static const char *normalize_arch (char *arch) -{ -if (!strcmp (arch,"x86_64" )) -return "x86" ; -if (arch[0 ] =='i' && arch[2 ] =='8' && arch[3 ] =='6' ) -return "x86" ; -if (!strcmp (arch,"sun4u" ) || !strncmp (arch,"sparc" ,5 )) -return "sparc" ; -if (!strncmp (arch,"aarch64" ,7 ) || !strncmp (arch,"arm64" ,5 )) -return "arm64" ; -if (!strncmp (arch,"arm" ,3 ) || !strcmp (arch,"sa110" )) -return "arm" ; -if (!strncmp (arch,"s390" ,4 )) -return "s390" ; -if (!strncmp (arch,"parisc" ,6 )) -return "parisc" ; -if (!strncmp (arch,"powerpc" ,7 ) || !strncmp (arch,"ppc" ,3 )) -return "powerpc" ; -if (!strncmp (arch,"mips" ,4 )) -return "mips" ; -if (!strncmp (arch,"sh" ,2 ) &&isdigit (arch[2 ])) -return "sh" ; -if (!strncmp (arch,"loongarch" ,9 )) -return "loongarch" ; +static const struct arch_to_e_machine prefix_to_e_machine[] = { + {"aarch64" ,EM_AARCH64 }, + {"alpha" ,EM_ALPHA }, + {"arc" ,EM_ARC }, + {"arm" ,EM_ARM },/* Check also for EM_AARCH64. */ + {"avr" ,EM_AVR },/* Check also for EM_AVR32. */ + {"bfin" ,EM_BLACKFIN }, + {"blackfin" ,EM_BLACKFIN }, + {"cris" ,EM_CRIS }, + {"csky" ,EM_CSKY }, + {"hppa" ,EM_PARISC }, + {"i386" ,EM_386 }, + {"i486" ,EM_386 }, + {"i586" ,EM_386 }, + {"i686" ,EM_386 }, + {"loongarch" ,EM_LOONGARCH }, + {"m32r" ,EM_M32R }, + {"m68k" ,EM_68K }, + {"microblaze" ,EM_MICROBLAZE }, + {"mips" ,EM_MIPS }, + {"msp430" ,EM_MSP430 }, + {"parisc" ,EM_PARISC }, + {"powerpc" ,EM_PPC },/* Check also for EM_PPC64. */ + {"ppc" ,EM_PPC },/* Check also for EM_PPC64. */ + {"riscv" ,EM_RISCV }, + {"s390" ,EM_S390 }, + {"sa110" ,EM_ARM }, + {"sh" ,EM_SH }, + {"sparc" ,EM_SPARC },/* Check also for EM_SPARCV9. */ + {"sun4u" ,EM_SPARC }, + {"x86" ,EM_X86_64 },/* Check also for EM_386. */ + {"xtensa" ,EM_XTENSA }, +}; + +static int compare_prefix (const void *key,const void *element) +{ +const char *search_key = key; +const struct arch_to_e_machine *map_element = element; +size_t prefix_len =strlen (map_element->prefix); -return arch; +return strncmp (search_key, map_element->prefix, prefix_len); +} + +static uint16_t perf_arch_to_e_machine (const char *perf_arch,int is_64_bit) +{ +/* Binary search for a matching prefix. */ +const struct arch_to_e_machine *result; + +if (!perf_arch) +return EM_HOST ; + + result =bsearch (perf_arch, + prefix_to_e_machine,ARRAY_SIZE (prefix_to_e_machine), +sizeof (prefix_to_e_machine[0 ]), + compare_prefix); + +if (!result) { +pr_debug ("Unknown perf arch for ELF machine mapping: %s\n" , perf_arch); +return EM_NONE ; + } + +/* +* Handle conflicting prefixes. If the is_64_bit is unknown (-1) then +* assume 64-bit. We can't use perf_env__kernel_is_64_bit as that +* depends on the arch string. +*/ +switch (result->e_machine) { +case EM_ARM : +return !strcmp (perf_arch,"arm64" ) || !strcmp (perf_arch,"aarch64" ) + ?EM_AARCH64 :EM_ARM ; +case EM_AVR : +return !strcmp (perf_arch,"avr32" ) ?EM_AVR32 :EM_AVR ; +case EM_PPC : +if (is_64_bit ==1 ) +return EM_PPC64 ; +if (is_64_bit ==0 ) +return EM_PPC ; +return strstarts (perf_arch,"ppc64" ) ?EM_PPC64 :EM_PPC ; +case EM_SPARC : +if (is_64_bit ==1 ) +return EM_SPARCV9 ; +if (is_64_bit ==0 ) +return EM_SPARC ; +return !strcmp (perf_arch,"sparc64" ) || !strcmp (perf_arch,"sun4u" ) + ?EM_SPARCV9 :EM_SPARC ; +case EM_X86_64 : +if (is_64_bit ==1 ) +return EM_X86_64 ; +if (is_64_bit ==0 ) +return EM_386 ; +return !strcmp (perf_arch,"x86_64" ) || !strcmp (perf_arch,"x86" ) + ?EM_X86_64 :EM_386 ; +default : +return result->e_machine; + } +} + +static const char *e_machine_to_perf_arch (uint16_t e_machine) +{ +/* +* Table for if either the perf arch string differs from uname or there +* are >1 ELF machine with the prefix. +*/ +static const struct arch_to_e_machine extras[] = { + {"arm64" ,EM_AARCH64 }, + {"avr32" ,EM_AVR32 }, + {"powerpc" ,EM_PPC }, + {"powerpc" ,EM_PPC64 }, + {"sparc" ,EM_SPARCV9 }, + {"x86" ,EM_386 }, + {"x86" ,EM_X86_64 }, + {"none" ,EM_NONE }, + }; + +for (size_t i =0 ; i <ARRAY_SIZE (extras); i++) { +if (extras[i].e_machine == e_machine) +return extras[i].prefix; + } + +for (size_t i =0 ; i <ARRAY_SIZE (prefix_to_e_machine); i++) { +if (prefix_to_e_machine[i].e_machine == e_machine) +return prefix_to_e_machine[i].prefix; + + } +return "unknown" ; +} + +uint16_t perf_env__e_machine_nocache (struct perf_env *env,uint32_t *e_flags) +{ +uint16_t e_machine =EM_NONE ; +const char *arch =NULL ; +int is_64_bit =-1 ; + +if (e_flags) + *e_flags =0 ; + +if (env) { + arch = env->arch; + is_64_bit = env->kernel_is_64_bit; + } + +if (!arch) { +static struct utsname uts = { .machine[0 ] ='\0' , }; + +if (uts.machine[0 ] =='\0' ) +uname (&uts); +if (uts.machine[0 ] !='\0' ) + arch = uts.machine; + } + + e_machine =perf_arch_to_e_machine (arch, is_64_bit); + +if (e_flags) + *e_flags = (e_machine ==EM_HOST ) ?EF_HOST :0 ; + +return e_machine; +} + +uint16_t perf_env__e_machine (struct perf_env *env,uint32_t *e_flags) +{ +uint16_t e_machine; +uint32_t local_e_flags =0 ; + +if (env && env->e_machine !=EM_NONE ) { +if (e_flags) + *e_flags = env->e_flags; + +return env->e_machine; + } + e_machine =perf_env__e_machine_nocache (env, &local_e_flags); +/* +* Only cache the e_machine in perf_env if env->arch is not NULL. +* If env->arch is NULL, the e_machine is just a fallback to EM_HOST. +* Caching it permanently would prevent dynamic, more accurate +* thread-based session e_machine scanning later in +* perf_session__e_machine(). +*/ +if (env && env->arch) { + env->e_machine = e_machine; + env->e_flags = local_e_flags; + } +if (e_flags) + *e_flags = local_e_flags; + +return e_machine; }const char *perf_env__arch (struct perf_env *env) { -char *arch_name; +uint16_t e_machine; +const char *arch; -if (!env || !env->arch) {/* Assume local operation */ +if (!env) {static struct utsname uts = { .machine[0 ] ='\0' , }; -if (uts.machine[0 ] =='\0' &&uname (&uts) <0 ) -return NULL ; - arch_name = uts.machine; - }else - arch_name = env->arch; +uint16_t host_e_machine; -return normalize_arch (arch_name); +if (uts.machine[0 ] =='\0' ) +uname (&uts); +if (uts.machine[0 ] !='\0' ) { + host_e_machine =perf_arch_to_e_machine (uts.machine,-1 ); +return e_machine_to_perf_arch (host_e_machine); + } +return e_machine_to_perf_arch (EM_HOST ); + } + +/* +* Lazily compute/allocate arch. The e_machine may have been +* read from a data file and so may not be EM_HOST. +*/ + e_machine =perf_env__e_machine (env,/*e_flags=*/ NULL ); + arch =e_machine_to_perf_arch (e_machine); + +if (e_machine ==EM_RISCV &&perf_env__kernel_is_64_bit (env) ==1 ) + arch ="riscv64" ; +else if (e_machine ==EM_MIPS &&perf_env__kernel_is_64_bit (env) ==1 ) + arch ="mips64" ; +else if (e_machine ==EM_PARISC &&perf_env__kernel_is_64_bit (env) ==1 ) + arch ="parisc64" ; + +return arch; }const char *perf_env__arch_strerrno (struct perf_env *env__maybe_unused ,int err__maybe_unused )
tools/perf/util/env.h +2 -0
@@ -187,6 +187,8 @@ int perf_env__read_cpu_topology_map(struct perf_env *env);void cpu_cache_level__free (struct cpu_cache_level *cache); +uint16_t perf_env__e_machine_nocache (struct perf_env *env,uint32_t *e_flags); +uint16_t perf_env__e_machine (struct perf_env *env,uint32_t *e_flags);const char *perf_env__arch (struct perf_env *env);const char *perf_env__arch_strerrno (struct perf_env *env,int err);arch_syscalls__strerrno_t *arch_syscalls__strerrno_function (const char *arch);
tools/perf/util/header.c +22 -10
@@ -441,21 +441,25 @@ static int write_osrelease(struct feat_fd *ff,return do_write_string (ff, uts.release); } -static int write_arch (struct feat_fd *ff, -struct evlist *evlist__maybe_unused ) +static int write_arch (struct feat_fd *ff,struct evlist *evlist) {struct utsname uts; -int ret; +const char *arch =NULL ; - ret =uname (&uts); -if (ret <0 ) -return -1 ; +if (evlist->session) + arch =perf_env__arch (perf_session__env (evlist->session)); + +if (!arch) { +int ret =uname (&uts); -return do_write_string (ff, uts.machine); +if (ret <0 ) +return -1 ; + arch = uts.machine; + } +return do_write_string (ff, arch); } -static int write_e_machine (struct feat_fd *ff, -struct evlist *evlist__maybe_unused ) +static int write_e_machine (struct feat_fd *ff,struct evlist *evlist) {/* e_machine expanded from 16 to 32-bits for alignment. */ uint32_t e_flags;
@@ -2841,10 +2845,18 @@ static int process_##__feat(struct feat_fd *ff, void *data __maybe_unused) \FEAT_PROCESS_STR_FUN (hostname, hostname);FEAT_PROCESS_STR_FUN (osrelease, os_release);FEAT_PROCESS_STR_FUN (version, version); -FEAT_PROCESS_STR_FUN (arch, arch);FEAT_PROCESS_STR_FUN (cpudesc, cpu_desc);FEAT_PROCESS_STR_FUN (cpuid, cpuid); +static int process_arch (struct feat_fd *ff,void *data__maybe_unused ) +{ +free (ff->ph->env.arch); + ff->ph->env.arch =do_read_string (ff); +if (!ff->ph->env.arch) +return -ENOMEM ; +return 0 ; +} +static int process_e_machine (struct feat_fd *ff,void *data__maybe_unused ) {int ret;
tools/perf/util/session.c +15 -11
@@ -4080,14 +4080,19 @@ uint16_t perf_session__e_machine(struct perf_session *session, uint32_t *e_flagsreturn EM_HOST ; } +/* +* Is the env caching an e_machine? If not we want to compute from the +* more accurate threads. +*/ env =perf_session__env (session); -if (env && env->e_machine !=EM_NONE ) { -if (e_flags) - *e_flags = env->e_flags; - -return env->e_machine; - } +if (env && env->e_machine !=EM_NONE ) +return perf_env__e_machine (env, e_flags); +/* +* Compute from threads, note this is more accurate than +* perf_env__e_machine that falls back on EM_HOST and doesn't consider +* mixed 32-bit and 64-bit threads. +*/ machines__for_each_thread (&session->machines, perf_session__e_machine_cb, &args);
@@ -4105,10 +4110,9 @@ uint16_t perf_session__e_machine(struct perf_session *session, uint32_t *e_flags/* * Couldn't determine from the perf_env or current set of -* threads. Default to the host. +* threads. Potentially use logic that uses the arch string otherwise +* default to the host. Don't cache in the perf_env in case later +* threads indicate a better ELF machine type. */ -if (e_flags) - *e_flags =EF_HOST ; - -return EM_HOST ; +return perf_env__e_machine_nocache (env, e_flags); }
Signature · 1 line
2.54.0.929.g9b7fa37559-goog
[email protected]
AI reviewRe: [PATCH v12 01/19] perf env: Add perf_env__e_machine helper and use in perf_env__arch
Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider: - [Critical] write_arch() writes a normalized architecture string missing bitness information, causing…
Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
- [Critical] write_arch() writes a normalized architecture string missing bitness information, causing 64-bit architectures to be misclassified as 32-bit.
- [High] Premature caching of arch-derived e_machine disables dynamic thread-based e_machine scanning for older perf.data files.
- [High] Unsynchronized access to static struct utsname buffer causes data race and potential misclassification of host architecture. --
commit db9bef861f1ee88707f9b3fa27ee30444f0ff977
Author: Ian Rogers <[email protected]>
perf env: Add perf_env__e_machine helper and use in perf_env__arch
This commit adds a helper to lazily compute the e_machine and fallback to EM_HOST. It updates perf_env__arch to use this helper and modifies the session header logic to record e_machine without forcing premature thread scanning.
Quoted 3 lines
tools/perf/util/env.c +0
-0
[ ... ]
Quoted 12 lines
tools/perf/util/env.c +1
-6@@ -309,15 +311,27 @@ void perf_env__init(struct perf_env *env)static void perf_env__init_kernel_mode (struct perf_env *env) { -const char *arch =perf_env__raw_arch (env); +const char *arch = env->arch; -if (!strncmp (arch,"x86_64" ,6 ) || !strncmp (arch,"aarch64" ,7 ) || - !strncmp (arch,"arm64" ,5 ) || !strncmp (arch,"mips64" ,6 ) || - !strncmp (arch,"parisc64" ,8 ) || !strncmp (arch,"riscv64" ,7 ) || - !strncmp (arch,"s390x" ,5 ) || !strncmp (arch,"sparc64" ,7 )) - env->kernel_is_64_bit =1 ;
tools/perf/util/env.c void perf_env__init(struct perf_env *env) · line 323
Quoted 10 lines
tools/perf/util/env.c +8
-2-else - env->kernel_is_64_bit =0 ; +if (!arch) { +static struct utsname uts = { .machine[0 ] ='\0' , }; + +if (uts.machine[0 ] =='\0' ) +uname (&uts); +if (uts.machine[0 ] !='\0' ) + arch = uts.machine; + }
[Severity: High]
Is it safe to use a lockless check for this static buffer here, as well as in perf_env__e_machine_nocache() and perf_env__arch()?
If multiple threads concurrently trigger uname(&uts), could one thread observe uts.machine[0] != '\0' immediately after the kernel writes the first byte?
Since uname copies data sequentially, might a thread read a partially written string (e.g., 'x8' instead of 'x86_64'), leading to a misclassified host architecture during multi-threaded profiling?
It appears that while a subsequent commit ("perf env: Add mutex to protect lazy environment initialization") adds env->lock to perf_env for os_release, it might not protect these local static buffers.
[ ... ]
Quoted 1 line
tools/perf/util/env.c +0
-0@@ -588,51 +602,237 @@ void cpu_cache_level__free(struct cpu_cache_level *cache)
[ ... ]
Quoted 13 lines
tools/perf/util/env.c +13
-0+uint16_t perf_env__e_machine (struct perf_env *env,uint32_t *e_flags) +{ +uint16_t e_machine; +uint32_t local_e_flags =0 ; + +if (env && env->e_machine !=EM_NONE ) { +if (e_flags) + *e_flags = env->e_flags; + +return env->e_machine; + } + e_machine =perf_env__e_machine_nocache (env, &local_e_flags); +/*
tools/perf/util/env.c void cpu_cache_level__free(struct cpu_cache_level *cache) · line 796
Quoted 10 lines
tools/perf/util/env.c +10
-0+* Only cache the e_machine in perf_env if env->arch is not NULL. +* If env->arch is NULL, the e_machine is just a fallback to EM_HOST. +* Caching it permanently would prevent dynamic, more accurate +* thread-based session e_machine scanning later in +* perf_session__e_machine(). +*/ +if (env && env->arch) { + env->e_machine = e_machine; + env->e_flags = local_e_flags; + }
[Severity: High]
Could this cache the arch-derived value into env->e_machine simply because env->arch is present?
If this caches the value prematurely, might older perf.data files that lack HEADER_E_MACHINE have env->e_machine populated before the threads are scanned?
When functions like thread__insert_map() invoke thread__e_machine_endian(), they fall back to perf_env__e_machine() and perf_env__arch() if a DSO is not yet loaded. Does this lock in the arch-derived host value prematurely?
Quoted 5 lines
tools/perf/util/env.c +4
-0+if (e_flags) + *e_flags = local_e_flags; + +return e_machine; }
[ ... ]
Quoted 4 lines
tools/perf/util/header.c +0
-0@@ -441,21 +441,25 @@ static int write_osrelease(struct feat_fd *ff,
[ ... ]
Quoted 14 lines
tools/perf/util/header.c +5
-6-static int write_arch (struct feat_fd *ff, -struct evlist *evlist__maybe_unused ) +static int write_arch (struct feat_fd *ff,struct evlist *evlist) {struct utsname uts; -int ret; +const char *arch =NULL ; - ret =uname (&uts); -if (ret <0 ) -return -1 ; +if (evlist->session) + arch =perf_env__arch (perf_session__env (evlist->session)); +
tools/perf/util/header.c static int write_osrelease(struct feat_fd *ff, · line 460
Quoted 10 lines
tools/perf/util/header.c +7
-1+if (!arch) { +int ret =uname (&uts); -return do_write_string (ff, uts.machine); +if (ret <0 ) +return -1 ; + arch = uts.machine; + } +return do_write_string (ff, arch); }
[Severity: Critical]
Does this code write the normalized architecture string lacking bitness information to the perf.data header instead of the full uts.machine string?
If perf_env__arch() normalizes the architecture name (e.g., 'x86_64' to 'x86'), the resulting string will miss the '64' substring.
Later in perf_env__init_kernel_mode():
if (arch) {
if (strstr(arch, "64") || strstr(arch, "s390x"))
env->kernel_is_64_bit = 1;
else
env->kernel_is_64_bit = 0;
return;
}Could this cause kernel_is_64_bit to incorrectly evaluate to 0 for 64-bit architectures like x86, powerpc, and sparc, leading to broken kernel symbol resolution, broken dynamic architecture fallbacks, and loss of backwards compatibility for older perf versions reading newly recorded files?
[ ... ]
Quoted 4 lines
tools/perf/util/session.c +0
-0@@ -4080,14 +4080,19 @@ uint16_t perf_session__e_machine(struct perf_session *session, uint32_t *e_flags
[ ... ]
tools/perf/util/session.c uint16_t perf_session__e_machine(struct perf_session *session, uint32_t *e_flags · line 4089
Quoted 13 lines
tools/perf/util/session.c +6
-6+/* +* Is the env caching an e_machine? If not we want to compute from the +* more accurate threads. +*/ env =perf_session__env (session); -if (env && env->e_machine !=EM_NONE ) { -if (e_flags) - *e_flags = env->e_flags; - -return env->e_machine; - } +if (env && env->e_machine !=EM_NONE ) +return perf_env__e_machine (env, e_flags);
[Severity: High]
Does this early return consume the prematurely cached value from perf_env__e_machine()?
If env->e_machine was populated early because env->arch was present, would this bypass the machines__for_each_thread() scan entirely, preventing the dynamic detection of 32-bit compat tasks on a 64-bit host for older perf.data files?
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
Ian Rogers
reviewerPATCH v12 2/19 perf tests topology: Switch env->arch use to env->e_machine
In reply to Ian RogersSome arch string comparisons weren't normalized. Avoid potential issues with normalized names vs uname values by swtiching to using the e_machine.
--- tools/perf/tests/topology.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
tools/perf/tests/topology.c +6 -2
@@ -11,6 +11,7 @@#include "pmus.h" #include "target.h" #include <linux/err.h> +#include "dwarf-regs.h" #define TEMPL "/tmp/perf-test-XXXXXX"#define DATA_SIZE 10
@@ -74,6 +75,7 @@ static int check_cpu_topology(char *path, struct perf_cpu_map *map)struct aggr_cpu_id id;struct perf_cpu cpu;struct perf_env *env; +uint16_t e_machine; session =perf_session__new (&data,NULL );TEST_ASSERT_VAL ("can't get session" , !IS_ERR (session));
@@ -101,7 +103,9 @@ static int check_cpu_topology(char *path, struct perf_cpu_map *map)* condition is true (see do_core_id_test in header.c). So always * run this test on those platforms. */ -if (!env->cpu &&strncmp (env->arch,"s390" ,4 ) &&strncmp (env->arch,"aarch64" ,7 )) + e_machine =perf_env__e_machine (env,NULL ); + +if (!env->cpu && e_machine !=EM_S390 && e_machine !=EM_AARCH64 )return TEST_SKIP ;/*
@@ -110,7 +114,7 @@ static int check_cpu_topology(char *path, struct perf_cpu_map *map)* physical_package_id will be set to -1. Hence skip this * test if physical_package_id returns -1 for cpu from perf_cpu_map. */ -if (!strncmp (env->arch,"ppc64le" ,7 )) { +if (e_machine ==EM_PPC64 ) {if (cpu__get_socket_id (perf_cpu_map__cpu (map,0 )) ==-1 )return TEST_SKIP ; }
Signature · 1 line
2.54.0.929.g9b7fa37559-goog
Ian Rogers
reviewerPATCH v12 3/19 perf env, dso, thread: Add _endian variants for e_machine helpers
In reply to Ian RogersAdd perf_arch_is_big_endian(), dso__read_e_machine_endian(), dso__e_machine_endian(), and thread__e_machine_endian() to support bi-endianness and cross-architecture analysis without breaking the existing API.
These helpers allow querying the absolute endianness of a DSO or thread, which is required for tools like Capstone that need to set the correct disassembly mode.
--- tools/perf/util/dso.c | 19 ++++++++----- tools/perf/util/dso.h | 14 ++++++++-- tools/perf/util/env.c | 16 +++++++++++ tools/perf/util/env.h | 1 + tools/perf/util/thread.c | 58 ++++++++++++++++++++++++++++++---------- tools/perf/util/thread.h | 23 +++++++++++++++- 6 files changed, 108 insertions(+), 23 deletions(-)
tools/perf/util/dso.c +13 -6
@@ -1220,7 +1220,8 @@ static enum dso_swap_type dso_swap_type__from_elf_data(unsigned char eidata) }/* Reads e_machine from fd, optionally caching data in dso. */ -uint16_t dso__read_e_machine (struct dso *optional_dso,int fd,uint32_t *e_flags) +uint16_t dso__read_e_machine_endian (struct dso *optional_dso,int fd,uint32_t *e_flags, +bool *is_big_endian) {uint16_t e_machine =EM_NONE ;unsigned char e_ident[EI_NIDENT ];
@@ -1250,6 +1251,9 @@ uint16_t dso__read_e_machine(struct dso *optional_dso, int fd, uint32_t *e_flagsif (swap_type ==DSO_SWAP__UNSET )return EM_NONE ;// Bad ELF data encoding. +if (is_big_endian) + *is_big_endian = (e_ident[EI_DATA ] ==ELFDATA2MSB ); +/* Cache the need for swapping. */ if (optional_dso) { assert(dso__needs_swap(optional_dso) == DSO_SWAP__UNSET ||
@@ -1288,7 +1292,8 @@ uint16_t dso__read_e_machine(struct dso *optional_dso, int fd, uint32_t *e_flagsreturn e_machine; } -uint16_t dso__e_machine (struct dso *dso,struct machine *machine,uint32_t *e_flags) +uint16_t dso__e_machine_endian (struct dso *dso,struct machine *machine,uint32_t *e_flags, +bool *is_big_endian) {uint16_t e_machine =EM_NONE ;int fd;
@@ -1308,9 +1313,11 @@ uint16_t dso__e_machine(struct dso *dso, struct machine *machine, uint32_t *e_flcase DSO_BINARY_TYPE__BPF_IMAGE :case DSO_BINARY_TYPE__OOL :case DSO_BINARY_TYPE__JAVA_JIT : -if (e_flags) - *e_flags =EF_HOST ; -return EM_HOST ; +if (is_big_endian) { + *is_big_endian =perf_arch_is_big_endian ( + machine && machine->env ?perf_env__arch (machine->env) :NULL ); + } +return perf_env__e_machine (machine ? machine->env :NULL , e_flags);case DSO_BINARY_TYPE__DEBUGLINK :case DSO_BINARY_TYPE__BUILD_ID_CACHE :case DSO_BINARY_TYPE__BUILD_ID_CACHE_DEBUGINFO :
@@ -1338,7 +1345,7 @@ uint16_t dso__e_machine(struct dso *dso, struct machine *machine, uint32_t *e_fltry_to_open_dso (dso, machine); fd =dso__data (dso)->fd;if (fd >=0 ) - e_machine =dso__read_e_machine (dso, fd, e_flags); + e_machine =dso__read_e_machine_endian (dso, fd, e_flags, is_big_endian);else if (e_flags) *e_flags =0 ;
tools/perf/util/dso.h +12 -2
@@ -866,8 +866,18 @@ int dso__data_file_size(struct dso *dso, struct machine *machine);off_t dso__data_size (struct dso *dso,struct machine *machine);ssize_t dso__data_read_offset (struct dso *dso,struct machine *machine,u64 offset,u8 *data,ssize_t size); -uint16_t dso__read_e_machine (struct dso *optional_dso,int fd,uint32_t *e_flags); -uint16_t dso__e_machine (struct dso *dso,struct machine *machine,uint32_t *e_flags); +uint16_t dso__read_e_machine_endian (struct dso *optional_dso,int fd,uint32_t *e_flags, +bool *is_big_endian); +static inline uint16_t dso__read_e_machine (struct dso *optional_dso,int fd,uint32_t *e_flags) +{ +return dso__read_e_machine_endian (optional_dso, fd, e_flags,NULL ); +} +uint16_t dso__e_machine_endian (struct dso *dso,struct machine *machine,uint32_t *e_flags, +bool *is_big_endian); +static inline uint16_t dso__e_machine (struct dso *dso,struct machine *machine,uint32_t *e_flags) +{ +return dso__e_machine_endian (dso, machine, e_flags,NULL ); +}ssize_t dso__data_read_addr (struct dso *dso,struct map *map,struct machine *machine,u64 addr,u8 *data,ssize_t size);
tools/perf/util/env.c +16 -0
@@ -342,6 +342,22 @@ int perf_env__kernel_is_64_bit(struct perf_env *env)return env->kernel_is_64_bit; } +bool perf_arch_is_big_endian (const char *arch) +{ +if (!arch) +return __BYTE_ORDER__ == __ORDER_BIG_ENDIAN__; + +if (str_ends_with (arch,"_be" ) || !strcmp (arch,"sparc" ) || !strcmp (arch,"sparc64" ) || + !strcmp (arch,"s390" ) || !strcmp (arch,"s390x" ) || !strcmp (arch,"powerpc" ) || + !strcmp (arch,"ppc" ) || !strcmp (arch,"ppc64" ) || + !strcmp (arch,"mips" ) || !strcmp (arch,"mips64" ) || !strcmp (arch,"parisc" ) || + !strcmp (arch,"parisc64" ) || !strcmp (arch,"m68k" ) || + !strcmp (arch,"armeb" ) || !strcmp (arch,"mipseb" ) || !strcmp (arch,"mips64eb" )) +return true; + +return false; +} +int perf_env__set_cmdline (struct perf_env *env,int argc,const char *argv[]) {int i;
tools/perf/util/env.h +1 -0
@@ -175,6 +175,7 @@ void free_cpu_domain_info(struct cpu_domain_map **cd_map, u32 schedstat_version,void perf_env__exit (struct perf_env *env);int perf_env__kernel_is_64_bit (struct perf_env *env); +bool perf_arch_is_big_endian (const char *arch);int perf_env__set_cmdline (struct perf_env *env,int argc,const char *argv[]);
tools/perf/util/thread.c +44 -14
123 lines not on this page · raw message
tools/perf/util/thread.h +22 -1
@@ -69,6 +69,11 @@ DECLARE_RC_STRUCT(thread) {* computed. */ uint16_t e_machine; +/** +* @e_is_big_endian: True if the ELF architecture of the thread is big endian. +* Valid if e_machine != EM_NONE. +*/ +bool e_is_big_endian;/* LBR call stack stitch */ bool lbr_stitch_enable;struct lbr_stitch *lbr_stitch;
@@ -311,7 +316,13 @@ static inline void thread__set_filter_entry_depth(struct thread *thread, int depRC_CHK_ACCESS (thread)->filter_entry_depth = depth; } -uint16_t thread__e_machine (struct thread *thread,struct machine *machine,uint32_t *e_flags); +uint16_t thread__e_machine_endian (struct thread *thread,struct machine *machine,uint32_t *e_flags, +bool *is_big_endian); +static inline uint16_t thread__e_machine (struct thread *thread,struct machine *machine, +uint32_t *e_flags) +{ +return thread__e_machine_endian (thread, machine, e_flags,NULL ); +}static inline void thread__set_e_machine (struct thread *thread,uint16_t e_machine) {
@@ -328,6 +339,16 @@ static inline void thread__set_e_flags(struct thread *thread, uint32_t e_flags)RC_CHK_ACCESS (thread)->e_flags = e_flags; } +static inline bool thread__e_is_big_endian (const struct thread *thread) +{ +return RC_CHK_ACCESS (thread)->e_is_big_endian; +} + +static inline void thread__set_e_is_big_endian (struct thread *thread,bool is_big_endian) +{ +RC_CHK_ACCESS (thread)->e_is_big_endian = is_big_endian; +} +static inline bool thread__lbr_stitch_enable (const struct thread *thread) {
Signature · 1 line
2.54.0.929.g9b7fa37559-goog
[email protected]
AI reviewRe: [PATCH v12 03/19] perf env, dso, thread: Add _endian variants for e_machine helpers
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
Pre-existing issues:
- [High] Calling maps__machine() with a NULL maps pointer causes a segmentation fault. --
commit 53562e7c68bd480e23dc08ba72db35bfbe234752
Author: Ian Rogers <[email protected]>
Subject: perf env, dso, thread: Add _endian variants for e_machine helpers
This commit adds new _endian variants for ELF machine helpers to support cross architecture analysis and bi-endianness. These additions allow querying the absolute endianness of a DSO or thread, which is required for external tools.
Quoted 3 lines
tools/perf/util/thread.c +0
-0
[ ... ]
tools/perf/util/thread.c uint16_t thread__e_machine(struct thread *thread, struct machine *machine, uint3 · line 505
Quoted 7 lines
tools/perf/util/thread.c +1
-0@@ -483,6 +500,7 @@ uint16_t thread__e_machine(struct thread *thread, struct machine *machine, uint3struct maps *maps =thread__maps (thread); machine =maps__machine (maps); + args.machine = machine; } tid =thread__tid (thread);
[Severity: High]
This is a pre-existing issue, but could this dereference a NULL pointer if the thread lacks attached maps?
If thread__e_machine_endian is called concurrently while a new thread is being initialized (for instance, via a concurrent iteration like machines__for_each_thread), it seems the thread might be visible in the machine's thread hashmap before thread__init_maps sets up the maps.
If thread__maps returns NULL here, will maps__machine attempt to dereference the NULL pointer and trigger a segmentation fault? Should we add a check to ensure maps is valid before looking up the machine?
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=3
Ian Rogers
reviewerPATCH v12 4/19 perf capstone: Determine architecture from e_machine
In reply to Ian RogersAvoid the use of arch string that is imprecise and use the e_machine. Do more e_machine to capstone machine translations adding MIPS and RISCV. Remove unnecessary maybe_unused annotations.
--- tools/perf/util/capstone.c | 132 ++++++++++++++++++++++++------------- 1 file changed, 88 insertions(+), 44 deletions(-)
tools/perf/util/capstone.c +88 -44
@@ -1,7 +1,19 @@// SPDX-License-Identifier: GPL-2.0 #include "capstone.h" -#include "annotate.h" + +#include <errno.h> +#include <inttypes.h> +#include <string.h> + +#include <dlfcn.h> +#include <elf.h> +#include <fcntl.h> +#include <linux/ctype.h> + +#include <capstone/capstone.h> +#include "addr_location.h" +#include "annotate.h" #include "debug.h" #include "disasm.h" #include "dso.h"
@@ -11,13 +23,6 @@#include "print_insn.h" #include "symbol.h" #include "thread.h" -#include <dlfcn.h> -#include <errno.h> -#include <fcntl.h> -#include <inttypes.h> -#include <string.h> - -#include <capstone/capstone.h> #ifdef LIBCAPSTONE_DLOPEN static void *perf_cs_dll_handle (void )
@@ -137,37 +142,70 @@ static enum cs_err perf_cs_close(csh *handle)#endif } -static int capstone_init (struct machine *machine,csh *cs_handle,bool is64, +static bool e_machine_to_capstone (uint16_t e_machine,bool is64,bool is_big_endian, +enum cs_arch *arch,enum cs_mode *mode) +{ + *mode = is_big_endian ?CS_MODE_BIG_ENDIAN :CS_MODE_LITTLE_ENDIAN ; + +switch (e_machine) { +case EM_X86_64 : +case EM_386 : + *arch =CS_ARCH_X86 ; + *mode |= is64 ?CS_MODE_64 :CS_MODE_32 ; +return true; +case EM_AARCH64 : + *arch =CS_ARCH_ARM64 ; + *mode |=CS_MODE_ARM ; +return true; +case EM_ARM : + *arch =CS_ARCH_ARM ; + *mode |=CS_MODE_ARM |CS_MODE_V8 ; +return true; +case EM_S390 : + *arch =CS_ARCH_SYSZ ; +return true; +case EM_MIPS : + *arch =CS_ARCH_MIPS ; + *mode |= is64 ?CS_MODE_MIPS64 :CS_MODE_MIPS32 ; +return true; +case EM_PPC : + *arch =CS_ARCH_PPC ; +return true; +case EM_PPC64 : + *arch =CS_ARCH_PPC ; + *mode |=CS_MODE_64 ; +return true; +case EM_SPARC : + *arch =CS_ARCH_SPARC ; +return true; +case EM_SPARCV9 : + *arch =CS_ARCH_SPARC ; + *mode |=CS_MODE_V9 ; +return true; +case EM_RISCV : + *arch =CS_ARCH_RISCV ; + *mode |= (is64 ?CS_MODE_RISCV64 :CS_MODE_RISCV32 ) |CS_MODE_RISCVC ; +return true; +default : +return false; + } +} + +static int capstone_init (uint16_t e_machine,csh *cs_handle,bool is64,bool is_big_endian,bool disassembler_style) {enum cs_arch arch;enum cs_mode mode; -if (machine__is (machine,"x86_64" ) && is64) { - arch =CS_ARCH_X86 ; - mode =CS_MODE_64 ; - }else if (machine__normalized_is (machine,"x86" )) { - arch =CS_ARCH_X86 ; - mode =CS_MODE_32 ; - }else if (machine__normalized_is (machine,"arm64" )) { - arch =CS_ARCH_ARM64 ; - mode =CS_MODE_ARM ; - }else if (machine__normalized_is (machine,"arm" )) { - arch =CS_ARCH_ARM ; - mode =CS_MODE_ARM +CS_MODE_V8 ; - }else if (machine__normalized_is (machine,"s390" )) { - arch =CS_ARCH_SYSZ ; - mode =CS_MODE_BIG_ENDIAN ; - }else { +if (!e_machine_to_capstone (e_machine, is64, is_big_endian, &arch, &mode))return -1 ; - }if (perf_cs_open (arch, mode, cs_handle) !=CS_ERR_OK ) {pr_warning_once ("cs_open failed\n" );return -1 ; } -if (machine__normalized_is (machine,"x86" )) { +if (arch ==CS_ARCH_X86 ) {/* * In case of using capstone_init while symbol__disassemble * setting CS_OPT_SYNTAX_ATT depends if disassembler_style opts
@@ -211,29 +249,28 @@ static size_t print_insn_x86(struct thread *thread, u8 cpumode, struct cs_insn *return printed; } - -ssize_t capstone__fprintf_insn_asm (struct machine *machine__maybe_unused , -struct thread *thread__maybe_unused , -u8 cpumode__maybe_unused ,bool is64bit__maybe_unused , -const uint8_t *code__maybe_unused , -size_t code_size__maybe_unused , -uint64_t ip__maybe_unused ,int *lenp__maybe_unused , -int print_opts__maybe_unused ,FILE *fp__maybe_unused ) +ssize_t capstone__fprintf_insn_asm (struct machine *machine,struct thread *thread,u8 cpumode, +bool is64bit,const uint8_t *code,size_t code_size,uint64_t ip, +int *lenp,int print_opts,FILE *fp) {size_t printed;struct cs_insn *insn;csh cs_handle;size_t count; +bool is_big_endian = false; +uint16_t e_machine =thread__e_machine_endian (thread, machine, +/*e_flags=*/ NULL , &is_big_endian);int ret;/* TODO: Try to initiate capstone only once but need a proper place. */ - ret =capstone_init (machine, &cs_handle, is64bit, true); + ret =capstone_init (e_machine, &cs_handle, is64bit, is_big_endian, +/*disassembler_style=*/ true);if (ret <0 )return ret; count =perf_cs_disasm (cs_handle, code, code_size, ip,1 , &insn);if (count >0 ) { -if (machine__normalized_is (machine,"x86" )) +if (e_machine ==EM_X86_64 || e_machine ==EM_386 ) printed =print_insn_x86 (thread, cpumode, &insn[0 ], print_opts, fp);else printed =fprintf (fp,"%s %s" , insn[0 ].mnemonic, insn[0 ].op_str);
@@ -322,9 +359,8 @@ static int find_file_offset(u64 start, u64 len, u64 pgoff, void *arg)return 0 ; } -int symbol__disassemble_capstone (const char *filename__maybe_unused , -struct symbol *sym__maybe_unused , -struct annotate_args *args__maybe_unused ) +int symbol__disassemble_capstone (const char *filename,struct symbol *sym, +struct annotate_args *args) {struct annotation *notes =symbol__annotation (sym);struct map *map = args->ms->map;
@@ -344,6 +380,8 @@ int symbol__disassemble_capstone(const char *filename __maybe_unused,char disasm_buf[512 ];struct disasm_line *dl;bool disassembler_style = false; +uint16_t e_machine; +bool is_big_endian = false;if (args->options->objdump_path)return -1 ;
@@ -373,8 +411,10 @@ int symbol__disassemble_capstone(const char *filename __maybe_unused, !strcmp(args->options->disassembler_style, "att")) disassembler_style = true; -if (capstone_init (maps__machine (thread__maps (args->ms->thread)), &handle, is_64bit, - disassembler_style) <0 ) + e_machine =thread__e_machine_endian (args->ms->thread, +/*machine=*/ NULL , +/*e_flags=*/ NULL , &is_big_endian); +if (capstone_init (e_machine, &handle, is_64bit, is_big_endian, disassembler_style) <0 ) goto err; needs_cs_close = true;
@@ -466,6 +506,8 @@ int symbol__disassemble_capstone_powerpc(const char *filename __maybe_unused,struct disasm_line *dl;u32 *line;bool disassembler_style = false; +uint16_t e_machine; +bool is_big_endian = false;if (args->options->objdump_path)return -1 ;
@@ -484,8 +526,10 @@ int symbol__disassemble_capstone_powerpc(const char *filename __maybe_unused, !strcmp(args->options->disassembler_style, "att")) disassembler_style = true; -if (capstone_init (maps__machine (thread__maps (args->ms->thread)), &handle, is_64bit, - disassembler_style) <0 ) + e_machine =thread__e_machine_endian (args->ms->thread, +/*machine=*/ NULL , +/*e_flags=*/ NULL , &is_big_endian); +if (capstone_init (e_machine, &handle, is_64bit, is_big_endian, disassembler_style) <0 ) goto err; needs_cs_close = true;
Signature · 1 line
2.54.0.929.g9b7fa37559-goog
[email protected]
AI reviewRe: [PATCH v12 04/19] perf capstone: Determine architecture from e_machine
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] Unconditional use of Capstone 5.0 RISC-V constants causes compilation failures on systems with…
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Unconditional use of Capstone 5.0 RISC-V constants causes compilation failures on systems with older Capstone versions. --
commit ba329b9ae926047810786901fac5adc923ce8f30
Author: Ian Rogers <[email protected]>
perf capstone: Determine architecture from e_machine
This commit updates perf to determine the architecture for Capstone disassembly using e_machine instead of an imprecise architecture string. It also adds new machine translations for MIPS and RISCV.
Quoted 4 lines
tools/perf/util/capstone.c +0
-0
[ ... ]
Quoted 11 lines
tools/perf/util/capstone.c +6
-1@@ -137,37 +142,70 @@ static enum cs_err perf_cs_close(csh *handle)#endif } -static int capstone_init(struct machine *machine, csh *cs_handle, bool is64, +static bool e_machine_to_capstone (uint16_t e_machine,bool is64,bool is_big_endian, +enum cs_arch *arch,enum cs_mode *mode) +{ + *mode = is_big_endian ?CS_MODE_BIG_ENDIAN :CS_MODE_LITTLE_ENDIAN ; + +switch (e_machine) {
[ ... ]
tools/perf/util/capstone.c static enum cs_err perf_cs_close(csh *handle) · line 188
Quoted 8 lines
tools/perf/util/capstone.c +8
-0+case EM_SPARCV9 : + *arch =CS_ARCH_SPARC ; + *mode |=CS_MODE_V9 ; +return true; +case EM_RISCV : + *arch =CS_ARCH_RISCV ; + *mode |= (is64 ?CS_MODE_RISCV64 :CS_MODE_RISCV32 ) |CS_MODE_RISCVC ; +return true;
[Severity: Low]
Will the unconditional use of these Capstone 5.0 RISC-V constants cause compilation failures on systems with older Capstone versions?
The feature test in tools/build/feature/test-libcapstone.c only checks for basic Capstone support:
int main(void)
{
csh handle;
cs_open(CS_ARCH_X86, CS_MODE_64, &handle);
...Systems with Capstone 4.x will pass this feature test and attempt to compile util/capstone.c. However, since CS_ARCH_RISCV and the RISC-V mode constants were introduced in Capstone 5.0, compiling against older headers will fail.
Could the feature test be updated to check for Capstone 5.0, or should these new constants be guarded to maintain synchronization with the build system?
Quoted 4 lines
tools/perf/util/capstone.c +4
-0+default : +return false; + } +}
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=4
Ian Rogers
reviewerPATCH v12 5/19 perf print_insn: Use e_machine for fallback IP length check
In reply to Ian RogersAvoid string comparisons with perf_env arch, switch to using the more precise ELF machine.
Sort header files and fix missing definitions.
--- tools/perf/util/print_insn.c | 23 ++++++++++++++--------- tools/perf/util/print_insn.h | 2 ++ 2 files changed, 16 insertions(+), 9 deletions(-)
tools/perf/util/print_insn.c +14 -9
@@ -4,19 +4,24 @@* * Author(s): Changbin Du <[email protected]> */ +#include "print_insn.h" +#include <inttypes.h> -#include <string.h> #include <stdbool.h> +#include <string.h> + +#include <dwarf-regs.h> +#include "capstone.h" #include "debug.h" +#include "dso.h" +#include "dump-insn.h" +#include "env.h" +#include "machine.h" +#include "map.h" #include "sample.h" #include "symbol.h" -#include "machine.h" #include "thread.h" -#include "print_insn.h" -#include "dump-insn.h" -#include "map.h" -#include "dso.h" size_t sample__fprintf_insn_raw (struct perf_sample *sample,FILE *fp) {
@@ -33,13 +38,13 @@ size_t sample__fprintf_insn_raw(struct perf_sample *sample, FILE *fp)static bool is64bitip (struct machine *machine,struct addr_location *al) {const struct dso *dso = al->map ?map__dso (al->map) :NULL ; +uint16_t e_machine;if (dso)return dso__is_64_bit (dso); -return machine__is (machine,"x86_64" ) || -machine__normalized_is (machine,"arm64" ) || -machine__normalized_is (machine,"s390" ); + e_machine =perf_env__e_machine (machine->env,/*e_flags=*/ NULL ); +return e_machine ==EM_X86_64 || e_machine ==EM_AARCH64 || e_machine ==EM_S390 ; } ssize_t fprintf_insn_asm(struct machine *machine, struct thread *thread, u8 cpumode,
tools/perf/util/print_insn.h +2 -0
@@ -5,6 +5,8 @@#include <stddef.h> #include <stdio.h> +#include <linux/types.h> +struct addr_location ;struct machine ;struct perf_insn ;
Signature · 1 line
2.54.0.929.g9b7fa37559-goog
Ian Rogers
reviewerPATCH v12 6/19 perf symbol: Avoid use of machine__is
In reply to Ian RogersSwitch to using the ELF machine from the dso or running machine rather than the machine perf_env arch that may fall back on EM_HOST. This also avoids potentially imprecise string comparisons.
--- tools/perf/util/symbol.c | 28 ++++++++++++++++++++++------ 1 file changed, 22 insertions(+), 6 deletions(-)
tools/perf/util/symbol.c +22 -6
@@ -851,6 +851,23 @@ static int maps__split_kallsyms_for_kcore(struct maps *kmaps, struct dso *dso)return count; } +static uint16_t machine_or_dso_e_machine (struct machine *machine,struct dso *dso) +{ +uint16_t e_machine =EM_NONE ; +/* DSO should be most accurate */ +if (dso) + e_machine =dso__e_machine (dso, machine,/*e_flags=*/ NULL ); + +if (e_machine !=EM_NONE ) +return e_machine; + +/* Check the global environment next. */ +if (machine && machine->env && machine->env->e_machine !=EM_NONE ) +return machine->env->e_machine; + +return perf_env__e_machine (machine ? machine->env :NULL ,/*e_flags=*/ NULL ); +} +/* * Split the symbols into maps, making sure there are no overlaps, i.e. the * kernel range is broken in several maps, named [kernel].N, as we don't have
@@ -866,14 +883,13 @@ static int maps__split_kallsyms(struct maps *kmaps, struct dso *dso, u64 delta,struct rb_root_cached *root =dso__symbols (dso);struct rb_node *next =rb_first_cached (root);int kernel_range =0 ; -bool x86_64; +uint16_t e_machine =EM_NONE ;if (!kmaps)return -1 ; machine =maps__machine (kmaps); - - x86_64 =machine__is (machine,"x86_64" ); + e_machine =machine_or_dso_e_machine (machine, dso);while (next) {char *module;
@@ -925,7 +941,7 @@ static int maps__split_kallsyms(struct maps *kmaps, struct dso *dso, u64 delta,*/ pos->start =map__map_ip (curr_map, pos->start); pos->end =map__map_ip (curr_map, pos->end); - }else if (x86_64 &&is_entry_trampoline (pos->name)) { + }else if (e_machine ==EM_X86_64 &&is_entry_trampoline (pos->name)) {/* * These symbols are not needed anymore since the * trampoline maps refer to the text section and it's
@@ -1428,7 +1444,7 @@ static int dso__load_kcore(struct dso *dso, struct map *map,free (new_node); } -if (machine__is (machine,"x86_64" )) { +if (machine_or_dso_e_machine (machine, dso) ==EM_X86_64 ) {u64 addr;/*
@@ -1716,7 +1732,7 @@ int dso__load(struct dso *dso, struct map *map) ret =dso__load_guest_kernel_sym (dso, map); machine =maps__machine (map__kmaps (map)); -if (machine__is (machine,"x86_64" )) +if (machine &&machine_or_dso_e_machine (machine, dso) ==EM_X86_64 )machine__map_x86_64_entry_trampolines (machine, dso); goto out; }
Signature · 1 line
2.54.0.929.g9b7fa37559-goog
[email protected]
AI reviewRe: [PATCH v12 06/19] perf symbol: Avoid use of machine__is
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [High] Cross-platform analysis regression due to host architecture fallback for guest kernels --
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Cross-platform analysis regression due to host architecture fallback for guest kernels --
commit 5ffd66d0549571c3b1c8d4a0baf650be921efbdd
Author: Ian Rogers <[email protected]>
perf symbol: Avoid use of machine__is
This commit switches from using machine__is() to dynamically checking the ELF machine type via the DSO or running machine environment. This avoids imprecise string comparisons and reliance on the perf_env arch string.
Quoted 13 lines
tools/perf/util/symbol.c +5
-0@@ -851,6 +851,23 @@ static int maps__split_kallsyms_for_kcore(struct maps *kmaps, struct dso *dso)return count; } +static uint16_t machine_or_dso_e_machine (struct machine *machine,struct dso *dso) +{ +uint16_t e_machine =EM_NONE ; +/* DSO should be most accurate */ +if (dso)
tools/perf/util/symbol.c static int maps__split_kallsyms_for_kcore(struct maps *kmaps, struct dso *dso) · line 868
Quoted 10 lines
tools/perf/util/symbol.c +10
-0+ e_machine =dso__e_machine (dso, machine,/*e_flags=*/ NULL ); + +if (e_machine !=EM_NONE ) +return e_machine; + +/* Check the global environment next. */ +if (machine && machine->env && machine->env->e_machine !=EM_NONE ) +return machine->env->e_machine; + +return perf_env__e_machine (machine ? machine->env :NULL ,/*e_flags=*/ NULL );
[Severity: High]
Does this fallback logic inadvertently break cross-platform analysis for guest kernels?
When analyzing guest kernels, machine->env is NULL. If dso__e_machine() returns EM_NONE (e.g. for kernel pseudo-files, where open() fails), this falls through to call perf_env__e_machine() with a NULL environment.
A NULL environment passed to perf_env__e_machine() delegates to perf_env__e_machine_nocache(), which invokes uname() to unconditionally substitute the host's architecture. The previous code using machine__is() safely returned "unknown" for guests without falling back to the host.
Quoted 2 lines
tools/perf/util/symbol.c +2
-0+} +
[ ... ]
tools/perf/util/symbol.c int dso__load(struct dso *dso, struct map *map) · line 1735
Quoted 6 lines
tools/perf/util/symbol.c +1
-1@@ -1716,7 +1732,7 @@ int dso__load(struct dso *dso, struct map *map) ret =dso__load_guest_kernel_sym (dso, map); machine =maps__machine (map__kmaps (map)); -if (machine__is (machine,"x86_64" )) +if (machine &&machine_or_dso_e_machine (machine, dso) ==EM_X86_64 )
[Severity: High]
If an x86_64 host analyzes a cross-platform non-x86 guest kernel, will the host fallback cause EM_X86_64 to match here?
Due to the host fallback described above, this appears like it would mistakenly trigger machine__map_x86_64_entry_trampolines() for the non-x86 guest, potentially injecting bogus memory maps and corrupting the guest's layout analysis.
Quoted 3 lines
tools/perf/util/symbol.c +0
-0machine__map_x86_64_entry_trampolines (machine, dso); goto out; }
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=6
Ian Rogers
reviewerPATCH v12 7/19 perf machine: Use perf_env e_machine rather than arch
In reply to Ian RogersThe arch string is derived from uname and may be normalized causing potential differences meaning the ELF machine can be more precise. Reduce the scope of machine__is as often it is better to use a thread for the e_machine rather than the machine. Switch from string to ELF machine constant comparisons.
--- tools/perf/util/machine.c | 35 ++++++++++++++++++----------------- tools/perf/util/machine.h | 2 -- 2 files changed, 18 insertions(+), 19 deletions(-)
tools/perf/util/machine.c +18 -17
@@ -9,6 +9,7 @@#include "debug.h" #include "dso.h" #include "env.h" +#include "dwarf-regs.h" #include "event.h" #include "evsel.h" #include "hist.h"
@@ -1627,10 +1628,24 @@ static bool machine__uses_kcore(struct machine *machine)return dsos__for_each_dso (&machine->dsos, machine__uses_kcore_cb,NULL ) !=0 ? true : false; } +static bool machine__is (struct machine *machine,uint16_t e_machine) +{ +if (!machine) +return false; + +if (!machine->env) { +if (machine__is_host (machine)) +return e_machine ==EM_HOST ; +return false; + } + +return perf_env__e_machine (machine->env,NULL ) == e_machine; +} +static bool perf_event__is_extra_kernel_mmap (struct machine *machine,struct extra_kernel_map *xm) { -return machine__is (machine,"x86_64" ) && +return machine__is (machine,EM_X86_64 ) &&is_entry_trampoline (xm->name); }
@@ -2786,7 +2801,7 @@ static int find_prev_cpumode(struct ip_callchain *chain, struct thread *thread,static u64 get_leaf_frame_caller (struct perf_sample *sample,struct thread *thread,int usr_idx) { -if (machine__normalized_is (maps__machine (thread__maps (thread)),"arm64" )) +if (thread__e_machine (thread,/*machine=*/ NULL ,/*e_flags=*/ NULL ) ==EM_AARCH64 )return get_leaf_frame_caller_aarch64 (sample, thread, usr_idx);else return 0 ;
@@ -3157,20 +3172,6 @@ int machine__set_current_tid(struct machine *machine, int cpu, pid_t pid,return 0 ; } -/* -* Compares the raw arch string. N.B. see instead perf_env__arch() or -* machine__normalized_is() if a normalized arch is needed. -*/ -bool machine__is (struct machine *machine,const char *arch) -{ -return machine && !strcmp (perf_env__raw_arch (machine->env), arch); -} - -bool machine__normalized_is (struct machine *machine,const char *arch) -{ -return machine && !strcmp (perf_env__arch (machine->env), arch); -} -int machine__nr_cpus_avail (struct machine *machine) {return machine ?perf_env__nr_cpus_avail (machine->env) :0 ;
@@ -3197,7 +3198,7 @@ int machine__get_kernel_start(struct machine *machine)* start of kernel text, but still above 2^63. So leave * kernel_start = 1ULL << 63 for x86_64. */ -if (!err && !machine__is (machine,"x86_64" )) +if (!err && !machine__is (machine,EM_X86_64 )) machine->kernel_start =map__start (map); }return err;
tools/perf/util/machine.h +0 -2
@@ -224,8 +224,6 @@ static inline bool machine__is_host(struct machine *machine) }bool machine__is_lock_function (struct machine *machine,u64 addr); -bool machine__is (struct machine *machine,const char *arch); -bool machine__normalized_is (struct machine *machine,const char *arch);int machine__nr_cpus_avail (struct machine *machine);struct thread *machine__findnew_thread (struct machine *machine,pid_t pid,pid_t tid);
Signature · 1 line
2.54.0.929.g9b7fa37559-goog
Ian Rogers
reviewerPATCH v12 8/19 perf sample-raw: Use perf_env e_machine rather than arch
In reply to Ian RogersUse the e_machine rather than the arch to determine S390 and x86 types.
--- tools/perf/util/sample-raw.c | 21 +++++++++++---------- tools/perf/util/sample-raw.h | 6 +++++- 2 files changed, 16 insertions(+), 11 deletions(-)
tools/perf/util/sample-raw.c +11 -10
@@ -1,11 +1,12 @@/* SPDX-License-Identifier: GPL-2.0 */ +#include "sample-raw.h" -#include <string.h> +#include <elf.h> #include <linux/string.h> -#include "evlist.h" +#include "env.h" +#include "evlist.h" #include "header.h" -#include "sample-raw.h" #include "session.h" /*
@@ -14,14 +15,14 @@*/ void evlist__init_trace_event_sample_raw (struct evlist *evlist,struct perf_env *env) { -const char *arch_pf =perf_env__arch (env); -const char *cpuid =perf_env__cpuid (env); +uint16_t e_machine =perf_env__e_machine (env,/*e_flags=*/ NULL ); -if (arch_pf && !strcmp ("s390" , arch_pf)) +if (e_machine ==EM_S390 ) { evlist->trace_event_sample_raw = evlist__s390_sample_raw; -else if (arch_pf && !strcmp ("x86" , arch_pf) && - cpuid &&strstarts (cpuid,"AuthenticAMD" ) && -evlist__has_amd_ibs (evlist)) { - evlist->trace_event_sample_raw = evlist__amd_sample_raw; + }else if (e_machine ==EM_X86_64 || e_machine ==EM_386 ) { +const char *cpuid =perf_env__cpuid (env); + +if (cpuid &&strstarts (cpuid,"AuthenticAMD" ) &&evlist__has_amd_ibs (evlist)) + evlist->trace_event_sample_raw = evlist__amd_sample_raw; } }
tools/perf/util/sample-raw.h +5 -1
@@ -2,7 +2,10 @@#ifndef __SAMPLE_RAW_H#define __SAMPLE_RAW_H 1 +#include <stdbool.h> +struct evlist ; +struct perf_env ;union perf_event ;struct perf_sample ;
@@ -12,4 +15,5 @@ bool evlist__has_amd_ibs(struct evlist *evlist);void evlist__amd_sample_raw (struct evlist *evlist,union perf_event *event,struct perf_sample *sample);void evlist__init_trace_event_sample_raw (struct evlist *evlist,struct perf_env *env); -#endif /* __PERF_EVLIST_H */ + +#endif /* __SAMPLE_RAW_H */
Signature · 1 line
2.54.0.929.g9b7fa37559-goog
Ian Rogers
reviewerPATCH v12 9/19 perf sort: Use perf_env e_machine rather than arch
In reply to Ian RogersUse the e_machine rather than the arch to determine x86 or PPC types.
--- tools/perf/util/sort.c | 58 +++++++++++++++++++++++------------------- 1 file changed, 32 insertions(+), 26 deletions(-)
tools/perf/util/sort.c +32 -26
@@ -1,40 +1,45 @@// SPDX-License-Identifier: GPL-2.0 +#include "sort.h" +#include <ctype.h> #include <errno.h> #include <inttypes.h> -#include <regex.h> #include <stdlib.h> + +#include <elf.h> +#include <linux/kernel.h> #include <linux/mman.h> +#include <linux/string.h> #include <linux/time64.h> + +#include <regex.h> + +#include "annotate-data.h" +#include "annotate.h" +#include "branch.h" +#include "cacheline.h" +#include "cgroup.h" +#include "comm.h" #include "debug.h" #include "dso.h" -#include "sort.h" +#include "event.h" +#include "evlist.h" +#include "evsel.h" #include "hist.h" -#include "cacheline.h" -#include "comm.h" +#include "machine.h" #include "map.h" -#include "maps.h" -#include "symbol.h" #include "map_symbol.h" -#include "branch.h" -#include "thread.h" -#include "evsel.h" -#include "evlist.h" -#include "srcline.h" -#include "strlist.h" -#include "strbuf.h" +#include "maps.h" #include "mem-events.h" #include "mem-info.h" -#include "annotate.h" -#include "annotate-data.h" -#include "event.h" -#include "time-utils.h" -#include "cgroup.h" -#include "machine.h" #include "session.h" +#include "srcline.h" +#include "strbuf.h" +#include "strlist.h" +#include "symbol.h" +#include "thread.h" +#include "time-utils.h" #include "trace-event.h" -#include <linux/kernel.h> -#include <linux/string.h> #ifdef HAVE_LIBTRACEEVENT #include <event-parse.h>
@@ -2673,9 +2678,10 @@ struct sort_dimension {static int arch_support_sort_key (const char *sort_key,struct perf_env *env) { -const char *arch =perf_env__arch (env); +uint16_t e_machine =perf_env__e_machine (env,/*e_eflags=*/ NULL ); -if (!strcmp ("x86" , arch) || !strcmp ("powerpc" , arch)) { +if (e_machine ==EM_X86_64 || e_machine ==EM_386 || e_machine ==EM_PPC64 || + e_machine ==EM_PPC ) {if (!strcmp (sort_key,"p_stage_cyc" ))return 1 ;if (!strcmp (sort_key,"local_p_stage_cyc" ))
@@ -2686,14 +2692,14 @@ static int arch_support_sort_key(const char *sort_key, struct perf_env *env)static const char *arch_perf_header_entry (const char *se_header,struct perf_env *env) { -const char *arch =perf_env__arch (env); +uint16_t e_machine =perf_env__e_machine (env,/*e_eflags=*/ NULL ); -if (!strcmp ("x86" , arch)) { +if (e_machine ==EM_X86_64 || e_machine ==EM_386 ) {if (!strcmp (se_header,"Local Pipeline Stage Cycle" ))return "Local Retire Latency" ;else if (!strcmp (se_header,"Pipeline Stage Cycle" ))return "Retire Latency" ; - }else if (!strcmp ("powerpc" , arch)) { + }else if (e_machine ==EM_PPC64 || e_machine ==EM_PPC ) {if (!strcmp (se_header,"Local INSTR Latency" ))return "Finish Cyc" ;else if (!strcmp (se_header,"INSTR Latency" ))
Signature · 1 line
2.54.0.929.g9b7fa37559-goog
Ian Rogers
reviewerPATCH v12 10/19 perf arch common: Use perf_env e_machine rather than arch
In reply to Ian RogersUse the e_machine rather than arch string matching.
--- tools/perf/arch/common.c | 92 ++++++++++++++++++++++++++++++---------- 1 file changed, 69 insertions(+), 23 deletions(-)
tools/perf/arch/common.c +69 -23
@@ -1,13 +1,18 @@// SPDX-License-Identifier: GPL-2.0 +#include "common.h" +#include <limits.h> #include <stdio.h> #include <stdlib.h> #include <string.h> + +#include <linux/zalloc.h> #include <unistd.h> -#include "common.h" -#include "../util/env.h" + +#include <dwarf-regs.h> +#include "../util/debug.h" -#include <linux/zalloc.h> +#include "../util/env.h" static const char *const arc_triplets[] = {"arc-linux-" ,
@@ -141,11 +146,40 @@ static int lookup_triplets(const char *const *triplets, const char *name)return -1 ; } +static bool is_native_compatible (struct perf_env *env,uint16_t target,uint16_t host) +{ +if (target != host) { +/* A 64-bit host can natively disassemble its 32-bit compat architecture */ +if (host ==EM_X86_64 && target ==EM_386 ) +return true; +if (host ==EM_AARCH64 && target ==EM_ARM ) +return true; +if (host ==EM_PPC64 && target ==EM_PPC ) +return true; +if (host ==EM_SPARCV9 && target ==EM_SPARC ) +return true; +return false; + } + +/* target == host case */ +if (target ==EM_RISCV ) { +bool target_is_64 =perf_env__kernel_is_64_bit (env); +bool host_is_64 = (sizeof (void *) ==8 ); + +/* 32-bit host cannot natively disassemble 64-bit target */ +if (!host_is_64 && target_is_64) +return false; + } + +return true; +} +static int perf_env__lookup_binutils_path (struct perf_env *env,const char *name,char **path) {int idx; -const char *arch =perf_env__arch (env), *cross_env; +uint16_t e_machine =perf_env__e_machine (env,/*e_flags=*/ NULL ); +const char *cross_env;const char *const *path_list;char *buf =NULL ;
@@ -153,7 +187,7 @@ static int perf_env__lookup_binutils_path(struct perf_env *env,* We don't need to try to find objdump path for native system. * Just use default binutils path (e.g.: "objdump"). */ -if (!strcmp (perf_env__arch (NULL ), arch)) +if (is_native_compatible (env, e_machine,EM_HOST )) goto out; cross_env =getenv ("CROSS_COMPILE" );
@@ -170,30 +204,42 @@ static int perf_env__lookup_binutils_path(struct perf_env *env,zfree (&buf); } -if (!strcmp (arch,"arc" )) +switch (e_machine) { +case EM_ARC : path_list = arc_triplets; -else if (!strcmp (arch,"arm" )) +break ; +case EM_ARM : path_list = arm_triplets; -else if (!strcmp (arch,"arm64" )) +break ; +case EM_AARCH64 : path_list = arm64_triplets; -else if (!strcmp (arch,"powerpc" )) +break ; +case EM_PPC : +case EM_PPC64 : path_list = powerpc_triplets; -else if (!strcmp (arch,"riscv32" )) - path_list = riscv32_triplets; -else if (!strcmp (arch,"riscv64" )) - path_list = riscv64_triplets; -else if (!strcmp (arch,"sh" )) +break ; +case EM_RISCV : + path_list =perf_env__kernel_is_64_bit (env) ? riscv64_triplets : riscv32_triplets; +break ; +case EM_SH : path_list = sh_triplets; -else if (!strcmp (arch,"s390" )) +break ; +case EM_S390 : path_list = s390_triplets; -else if (!strcmp (arch,"sparc" )) +break ; +case EM_SPARC : +case EM_SPARCV9 : path_list = sparc_triplets; -else if (!strcmp (arch,"x86" )) +break ; +case EM_X86_64 : +case EM_386 : path_list = x86_triplets; -else if (!strcmp (arch,"mips" )) +break ; +case EM_MIPS : path_list = mips_triplets; -else { -ui__error ("binutils for %s not supported.\n" , arch); +break ; +default : +ui__error ("binutils for %s not supported.\n" ,perf_env__arch (env)); goto out_error; }
@@ -202,7 +248,7 @@ static int perf_env__lookup_binutils_path(struct perf_env *env,ui__error ("Please install %s for %s.\n" "You can add it to PATH, set CROSS_COMPILE or " "override the default using --%s.\n" , - name, arch, name); + name,perf_env__arch (env), name); goto out_error; }
@@ -237,7 +283,7 @@ int perf_env__lookup_objdump(struct perf_env *env, char **path)*/ bool perf_env__single_address_space (struct perf_env *env) { -const char *arch =perf_env__arch (env); +uint16_t e_machine =perf_env__e_machine (env,/*e_flags=*/ NULL ); -return strcmp (arch,"s390" ) &&strcmp (arch,"sparc" ); +return e_machine !=EM_SPARC && e_machine !=EM_SPARCV9 && e_machine !=EM_S390 ; }
Signature · 1 line
2.54.0.929.g9b7fa37559-goog
Ian Rogers
reviewerPATCH v12 11/19 perf header: In print_pmu_caps use perf_env e_machine
In reply to Ian RogersSwitch from arch to e_machine in print_pmu_caps.
--- tools/perf/util/header.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
tools/perf/util/header.c +4 -3
@@ -2461,15 +2461,16 @@ static void print_cpu_pmu_caps(struct feat_fd *ff, FILE *fp)static void print_pmu_caps (struct feat_fd *ff,FILE *fp) {struct perf_env *env = &ff->ph->env; -struct pmu_caps *pmu_caps; +uint16_t e_machine =perf_env__e_machine (env,/*e_flags=*/ NULL );for (int i =0 ; i < env->nr_pmus_with_caps; i++) { - pmu_caps = &env->pmu_caps[i]; +struct pmu_caps *pmu_caps = &env->pmu_caps[i]; +__print_pmu_caps (fp, pmu_caps->nr_caps, pmu_caps->caps, pmu_caps->pmu_name); } -if (strcmp (perf_env__arch (env),"x86" ) ==0 && +if ((e_machine ==EM_X86_64 || e_machine ==EM_386 ) &&perf_env__has_pmu_mapping (env,"ibs_op" )) {char *max_precise =perf_env__find_pmu_cap (env,"cpu" ,"max_precise" );
Signature · 1 line
2.54.0.929.g9b7fa37559-goog
Ian Rogers
reviewerPATCH v12 12/19 perf c2c: Use perf_env e_machine rather than arch
In reply to Ian RogersUse the e_machine rather than arch string matching for AARCH64.
Add include of dwarf-regs.h in case the EM_AARCH64 isn't defined, sort the headers given this include.
--- tools/perf/builtin-c2c.c | 40 ++++++++++++++++++++++------------------ 1 file changed, 22 insertions(+), 18 deletions(-)
tools/perf/builtin-c2c.c +22 -18
@@ -12,41 +12,45 @@*/ #include <errno.h> #include <inttypes.h> + +#include <asm/bug.h> #include <linux/compiler.h> #include <linux/err.h> #include <linux/kernel.h> #include <linux/stringify.h> #include <linux/zalloc.h> -#include <asm/bug.h> #include <sys/param.h> -#include "debug.h" -#include "builtin.h" + +#include <dwarf-regs.h> #include <perf/cpumap.h> #include <subcmd/pager.h> #include <subcmd/parse-options.h> -#include "map_symbol.h" -#include "mem-events.h" -#include "session.h" -#include "hist.h" -#include "sort.h" -#include "tool.h" + +#include "builtin.h" #include "cacheline.h" #include "data.h" +#include "debug.h" #include "event.h" #include "evlist.h" #include "evsel.h" -#include "ui/browsers/hists.h" -#include "thread.h" -#include "mem2node.h" +#include "hist.h" +#include "map_symbol.h" +#include "mem-events.h" #include "mem-info.h" -#include "symbol.h" -#include "ui/ui.h" -#include "ui/progress.h" +#include "mem2node.h" #include "pmus.h" +#include "session.h" +#include "sort.h" #include "string2.h" -#include "util/util.h" -#include "util/symbol.h" +#include "symbol.h" +#include "thread.h" +#include "tool.h" +#include "ui/browsers/hists.h" +#include "ui/progress.h" +#include "ui/ui.h" #include "util/annotate.h" +#include "util/symbol.h" +#include "util/util.h" struct c2c_hists {struct hists hists;
@@ -3202,7 +3206,7 @@ static int perf_c2c__report(int argc, const char **argv)* default display type. */ if (!display) { -if (!strcmp (perf_env__arch (env),"arm64" )) +if (perf_env__e_machine (env,/*e_flags=*/ NULL ) ==EM_AARCH64 ) display ="peer" ;else display ="tot" ;
Signature · 1 line
2.54.0.929.g9b7fa37559-goog
Ian Rogers
reviewerPATCH v12 13/19 perf lock-contention: Use perf_env e_machine rather than arch
In reply to Ian RogersUse the e_machine rather than arch string matching for powerpc.
--- tools/perf/util/lock-contention.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
tools/perf/util/lock-contention.c +3 -3
@@ -104,7 +104,8 @@ bool match_callstack_filter(struct machine *machine, u64 *callstack, int max_stastruct map *kmap;struct symbol *sym;u64 ip; -const char *arch =perf_env__arch (machine->env); +uint16_t e_machine =perf_env__e_machine (machine->env,/*e_flags=*/ NULL ); +bool is_powerpc = e_machine ==EM_PPC64 || e_machine ==EM_PPC ;if (list_empty (&callstack_filters))return true;
@@ -125,8 +126,7 @@ bool match_callstack_filter(struct machine *machine, u64 *callstack, int max_sta* incase first or second callstack index entry has 0 * address for powerpc. */ -if (!callstack || (!callstack[i] && (strcmp (arch,"powerpc" ) || - (i !=1 && i !=2 )))) +if (!callstack || (!callstack[i] && (!is_powerpc || (i !=1 && i !=2 ))))break ; ip = callstack[i];
Signature · 1 line
2.54.0.929.g9b7fa37559-goog
Ian Rogers
reviewerPATCH v12 14/19 perf env: Refactor perf_env__arch_strerrno
In reply to Ian RogersThe previous approach maps an architecture string to a function pointer to a function that takes an int errno value and returns a string. The new approach takes an e_machine and an errno value and returns a string.
As the only call site is in builtin-trace.c, the e_machine is already present and potentially more specific than the perf_env arch string that is a single global value.
Since the errno-to-name mapping is now generated statically and no longer depends on libtraceevent, we can remove the HAVE_LIBTRACEEVENT guards entirely, making perf_env__arch_strerrno unconditionally available.
The major complication in this approach is having the shell script that generates the C code map a linux directory name to the matching ELF machine constants. To ensure compatibility with older hosts that have older glibc versions, output fallback definitions for newer ELF machine constants (EM_AARCH64, EM_CSKY, EM_LOONGARCH) if they are not defined in the system <elf.h>.
--- tools/perf/builtin-trace.c | 7 +-- tools/perf/trace/beauty/Build | 1 + tools/perf/trace/beauty/arch_errno_names.sh | 53 +++++++++++++++++++-- tools/perf/util/env.c | 13 ++--- tools/perf/util/env.h | 6 +-- 5 files changed, 58 insertions(+), 22 deletions(-)
tools/perf/builtin-trace.c +4 -3
@@ -3032,9 +3032,8 @@ static int trace__sys_exit(struct trace *trace, }else if (ret <0 ) { errno_print: {char bf[STRERR_BUFSIZE ]; -struct perf_env *env =evsel__env (evsel) ?: &trace->host_env;const char *emsg =str_error_r (-ret, bf,sizeof (bf)); -const char *e =perf_env__arch_strerrno (env, err); +const char *e =perf_env__arch_strerrno (e_machine, err);fprintf (trace->output,"-1 %s (%s)" , e, emsg); }
@@ -4921,7 +4920,9 @@ static size_t syscall__dump_stats(struct trace *trace, int e_machine, FILE *fp,for (e =0 ; e < stats->max_errno; ++e) {if (stats->errnos[e] !=0 ) -fprintf (fp,"\t\t\t\t%s: %d\n" ,perf_env__arch_strerrno (trace->host->env, e +1 ), stats->errnos[e]); +fprintf (fp,"\t\t\t\t%s: %d\n" , +perf_env__arch_strerrno (e_machine, e +1 ), + stats->errnos[e]); } } lines++;
tools/perf/trace/beauty/Build +1 -0
@@ -36,6 +36,7 @@ perf-y += signum.o perf-y += socket_type.o perf-y += waitid_options.o perf-util-y += arch_errno_names.o + perf-y += tracepoints/ ifdef SHELLCHECK
tools/perf/trace/beauty/arch_errno_names.sh +48 -5
75 lines not on this page · raw message
tools/perf/util/env.c +4 -9
@@ -851,16 +851,11 @@ const char *perf_env__arch(struct perf_env *env)return arch; } -const char *perf_env__arch_strerrno (struct perf_env *env__maybe_unused ,int err__maybe_unused ) -{ -#if defined(HAVE_LIBTRACEEVENT ) -if (env->arch_strerrno ==NULL ) - env->arch_strerrno =arch_syscalls__strerrno_function (perf_env__arch (env)); +const char *arch_syscalls__strerrno (uint16_t e_machine,int err); -return env->arch_strerrno ? env->arch_strerrno (err) :"no arch specific strerrno function" ; -#else -return "!HAVE_LIBTRACEEVENT" ; -#endif +const char *perf_env__arch_strerrno (uint16_t e_machine,int err) +{ +return arch_syscalls__strerrno (e_machine, err); }const char *perf_env__cpuid (struct perf_env *env)
tools/perf/util/env.h +1 -5
@@ -67,8 +67,6 @@ struct cpu_domain_map {struct domain_info **domains; }; -typedef const char *(arch_syscalls__strerrno_t )(int err); -struct perf_env {char *hostname;char *os_release;
@@ -158,7 +156,6 @@ struct perf_env {*/ bool enabled; } clock; -arch_syscalls__strerrno_t *arch_strerrno; };enum perf_compress_type {
@@ -191,8 +188,7 @@ void cpu_cache_level__free(struct cpu_cache_level *cache);uint16_t perf_env__e_machine_nocache (struct perf_env *env,uint32_t *e_flags);uint16_t perf_env__e_machine (struct perf_env *env,uint32_t *e_flags);const char *perf_env__arch (struct perf_env *env); -const char *perf_env__arch_strerrno (struct perf_env *env,int err); -arch_syscalls__strerrno_t *arch_syscalls__strerrno_function (const char *arch); +const char *perf_env__arch_strerrno (uint16_t e_machine,int err);const char *perf_env__cpuid (struct perf_env *env);const char *perf_env__raw_arch (struct perf_env *env);int perf_env__nr_cpus_avail (struct perf_env *env);
Signature · 1 line
2.54.0.929.g9b7fa37559-goog
Ian Rogers
reviewerPATCH v12 15/19 perf env: Remove unused perf_env__raw_arch
In reply to Ian RogersThe switch to using e_machine has made the perf_env__raw_arch function unused so remove it.
--- tools/perf/util/env.c | 18 ------------------ tools/perf/util/env.h | 1 - 2 files changed, 19 deletions(-)
tools/perf/util/env.c +0 -18
@@ -470,19 +470,6 @@ int perf_env__read_cpuid(struct perf_env *env)return 0 ; } -static int perf_env__read_arch (struct perf_env *env) -{ -struct utsname uts; - -if (env->arch) -return 0 ; - -if (!uname (&uts)) - env->arch =strdup (uts.machine); - -return env->arch ?0 : -ENOMEM ; -} -static int perf_env__read_nr_cpus_avail (struct perf_env *env) {if (env->nr_cpus_avail ==0 )
@@ -601,11 +588,6 @@ int perf_env__read_core_pmu_caps(struct perf_env *env)return ret; } -const char *perf_env__raw_arch (struct perf_env *env) -{ -return env && !perf_env__read_arch (env) ? env->arch :"unknown" ; -} -int perf_env__nr_cpus_avail (struct perf_env *env) {return env && !perf_env__read_nr_cpus_avail (env) ? env->nr_cpus_avail :0 ;
tools/perf/util/env.h +0 -1
@@ -190,7 +190,6 @@ uint16_t perf_env__e_machine(struct perf_env *env, uint32_t *e_flags);const char *perf_env__arch (struct perf_env *env);const char *perf_env__arch_strerrno (uint16_t e_machine,int err);const char *perf_env__cpuid (struct perf_env *env); -const char *perf_env__raw_arch (struct perf_env *env);int perf_env__nr_cpus_avail (struct perf_env *env);void perf_env__init (struct perf_env *env);
Signature · 1 line
2.54.0.929.g9b7fa37559-goog
Ian Rogers
reviewerPATCH v12 16/19 perf env: Add mutex to protect lazy environment initialization
In reply to Ian RogersIntroduce a mutex to 'struct perf_env' to safely protect lazy metadata setup, such as os_release or e_machine resolution, preventing concurrent initialization data races and memory leaks during multi-threaded profiling or symbol loading.
--- tools/perf/util/env.c | 5 +++++ tools/perf/util/env.h | 3 +++ 2 files changed, 8 insertions(+)
tools/perf/util/env.c +5 -0
@@ -250,6 +250,8 @@ void perf_env__exit(struct perf_env *env) {int i, j; +mutex_destroy (&env->lock); +perf_env__purge_bpf (env);perf_env__purge_cgroups (env);zfree (&env->hostname);
@@ -307,6 +309,7 @@ void perf_env__init(struct perf_env *env)init_rwsem (&env->bpf_progs.lock);#endif env->kernel_is_64_bit =-1 ; +mutex_init (&env->lock); }static void perf_env__init_kernel_mode (struct perf_env *env)
@@ -1014,6 +1017,7 @@ bool x86__is_amd_cpu(void)struct perf_env env = { .total_mem =0 , };bool is_amd; +perf_env__init (&env);perf_env__cpuid (&env); is_amd =perf_env__is_x86_amd_cpu (&env);perf_env__exit (&env);
@@ -1036,6 +1040,7 @@ bool x86__is_intel_cpu(void)struct perf_env env = { .total_mem =0 , };bool is_intel; +perf_env__init (&env);perf_env__cpuid (&env); is_intel =perf_env__is_x86_intel_cpu (&env);perf_env__exit (&env);
tools/perf/util/env.h +3 -0
@@ -6,6 +6,7 @@#include <linux/rbtree.h> #include "cpumap.h" #include "rwsem.h" +#include "mutex.h" struct perf_cpu_map ;
@@ -156,6 +157,8 @@ struct perf_env {*/ bool enabled; } clock; +/* Protects lazy environment initialization (e.g. os_release, e_machine). */ +struct mutex lock; };enum perf_compress_type {
Signature · 1 line
2.54.0.929.g9b7fa37559-goog
[email protected]
AI reviewRe: [PATCH v12 16/19] perf env: Add mutex to protect lazy environment initialization
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] The introduced `env->lock` is not used to protect `perf_env__e_machine()`, leaving a data race…
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The introduced env->lock is not used to protect perf_env__e_machine(), leaving a data race on e_machine and e_flags initialization despite the commit message's explicit claims. --
commit 2c2484a173309974342a90986d80903317702365
Author: Ian Rogers <[email protected]>
perf env: Add mutex to protect lazy environment initialization
This commit adds a mutex to struct perf_env to protect lazy metadata initialization from concurrent data races. It includes the addition of the lock field and the mutex_init() and mutex_destroy() lifecycle calls.
Quoted 9 lines
Introduce a mutex to 'struct
perf_env' to safely protect lazy metadata setup, such asos_releaseore_machineresolution, preventing concurrent initialization data races and memory leaks during multi-threaded profiling or symbol loading.tools/perf/util/env.h +0
-0
[ ... ]
tools/perf/util/env.h struct perf_env { · line 162
Quoted 7 lines
tools/perf/util/env.h +2
-0@@ -156,6 +157,8 @@ struct perf_env {*/ bool enabled; } clock; +/* Protects lazy environment initialization (e.g. os_release, e_machine). */ +struct mutex lock; };
[Severity: Medium]
The commit message and comment state that the new mutex safely protects lazy e_machine resolution, but is the lock actually utilized for this?
Looking at tools/perf/util/env.c:perf_env__e_machine(), the caching mechanism writes to env->e_machine and env->e_flags sequentially without acquiring env->lock:
if (env && env->arch) {
env->e_machine = e_machine;
env->e_flags = local_e_flags;
}Could a data race still occur here if Thread A sets env->e_machine and context switches before setting env->e_flags, allowing Thread B to observe env->e_machine != EM_NONE and read the uninitialized env->e_flags? Should perf_env__e_machine() be updated to use the new lock?
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=16
Ian Rogers
reviewerPATCH v12 17/19 perf env: Add helper to lazily compute the os_release
In reply to Ian RogersIn live mode the os_release isn't being initialized, make a lazy initialization helper that assumes when the os_release isn't initialized this is live mode.
--- tools/perf/util/data-convert-bt.c | 2 +- tools/perf/util/data-convert-json.c | 6 +++-- tools/perf/util/env.c | 38 +++++++++++++++++++++++++++++ tools/perf/util/env.h | 1 + tools/perf/util/header.c | 16 ++++++++---- tools/perf/util/symbol.c | 4 +-- 6 files changed, 57 insertions(+), 10 deletions(-)
tools/perf/util/data-convert-bt.c +1 -1
@@ -1414,7 +1414,7 @@ do { \ADD ("host" , env->hostname);ADD ("sysname" ,"Linux" ); -ADD ("release" , env->os_release); +ADD ("release" ,perf_env__os_release (env));ADD ("version" , env->version);ADD ("machine" , env->arch);ADD ("domain" ,"kernel" );
tools/perf/util/data-convert-json.c +4 -2
@@ -16,6 +16,7 @@#include "linux/err.h" #include "util/auxtrace.h" #include "util/debug.h" +#include "util/env.h" #include "util/dso.h" #include "util/event.h" #include "util/evsel.h"
@@ -272,7 +273,7 @@ static void output_headers(struct perf_session *session, struct convert_json *c) {struct stat st;const struct perf_header *header = &session->header; -const struct perf_env *env =perf_session__env (session); +struct perf_env *env =perf_session__env (session);int ret;int fd =perf_data__fd (session->data);int i;
@@ -296,7 +297,8 @@ static void output_headers(struct perf_session *session, struct convert_json *c)output_json_key_format (out, true,2 ,"feat-offset" ,"%" PRIu64, header->feat_offset);output_json_key_string (out, true,2 ,"hostname" , env->hostname); -output_json_key_string (out, true,2 ,"os-release" , env->os_release); +output_json_key_string (out, true,2 ,"os-release" , +perf_env__os_release (env));output_json_key_string (out, true,2 ,"arch" , env->arch);if (env->cpu_desc)
tools/perf/util/env.c +38 -0
@@ -361,6 +361,44 @@ bool perf_arch_is_big_endian(const char *arch)return false; } +const char *perf_env__os_release (struct perf_env *env) +{ +struct utsname uts; +int ret; +const char *release; + +if (!env) +return perf_version_string; + +mutex_lock (&env->lock); +if (env->os_release) { + release = env->os_release; + goto out; + } + +/* +* If env->arch is set, this is an offline target environment. +* If the os_release is not populated in the file, we do not want +* to poison it with the host's release which would break guest checks. +*/ +if (env->arch) { + release =NULL ; + goto out; + } + +/* +* The os_release is being accessed but wasn't initialized from a data +* file, assume this is 'live' mode and use the release from uname. If +* uname or strdup fails then use the current perf tool version. +*/ + ret =uname (&uts); + env->os_release =strdup (ret <0 ? perf_version_string : uts.release); + release = env->os_release ?: perf_version_string; +out: +mutex_unlock (&env->lock); +return release; +} +int perf_env__set_cmdline (struct perf_env *env,int argc,const char *argv[]) {int i;
tools/perf/util/env.h +1 -0
@@ -176,6 +176,7 @@ void perf_env__exit(struct perf_env *env);int perf_env__kernel_is_64_bit (struct perf_env *env);bool perf_arch_is_big_endian (const char *arch); +const char *perf_env__os_release (struct perf_env *env);int perf_env__set_cmdline (struct perf_env *env,int argc,const char *argv[]);
tools/perf/util/header.c +11 -5
@@ -432,13 +432,19 @@ static int write_osrelease(struct feat_fd *ff, struct evlist *evlist __maybe_unused) {struct utsname uts; -int ret; +const char *release =NULL ; - ret =uname (&uts); -if (ret <0 ) -return -1 ; +if (evlist->session) + release =perf_env__os_release (perf_session__env (evlist->session)); -return do_write_string (ff, uts.release); +if (!release) { +int ret =uname (&uts); + +if (ret <0 ) +return -1 ; + release = uts.release; + } +return do_write_string (ff, release); }static int write_arch (struct feat_fd *ff,struct evlist *evlist)
tools/perf/util/symbol.c +2 -2
@@ -2225,7 +2225,7 @@ static int vmlinux_path__init(struct perf_env *env) {struct utsname uts;char bf[PATH_MAX ]; -char *kernel_version; +const char *kernel_version;unsigned int i; vmlinux_path = malloc(sizeof(char *) * (ARRAY_SIZE(vmlinux_paths) +
@@ -2242,7 +2242,7 @@ static int vmlinux_path__init(struct perf_env *env)return 0 ;if (env) { - kernel_version = env->os_release; + kernel_version =perf_env__os_release (env); }else {if (uname (&uts) <0 ) goto out_fail;
Signature · 1 line
2.54.0.929.g9b7fa37559-goog
[email protected]
AI reviewRe: [PATCH v12 17/19] perf env: Add helper to lazily compute the os_release
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [High] Premature lazy initialization in pipe mode poisons `perf_env` with the host's `os_release`…
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Premature lazy initialization in pipe mode poisons perf_env with the host's os_release, corrupting JSON/CTF exports and offline symbol resolution. --
commit 1b9df6eca5b172acf3ec3492723767468d3b5ec6
Author: Ian Rogers <[email protected]>
perf env: Add helper to lazily compute the os_release
This commit introduces a helper to lazily initialize the os_release string in the perf environment, falling back to the host's release via uname when the environment indicates live mode.
Quoted 3 lines
tools/perf/util/data-convert-json.c +0
-0
[ ... ]
tools/perf/util/data-convert-json.c static void output_headers(struct perf_session *session, struct convert_json *c) · line 301
Quoted 7 lines
tools/perf/util/data-convert-json.c +2
-1@@ -296,7 +297,8 @@ static void output_headers(struct perf_session *session, struct convert_json *c)output_json_key_format (out, true,2 ,"feat-offset" ,"%" PRIu64, header->feat_offset);output_json_key_string (out, true,2 ,"hostname" , env->hostname); -output_json_key_string (out, true,2 ,"os-release" , env->os_release); +output_json_key_string (out, true,2 ,"os-release" , +perf_env__os_release (env));
[Severity: High]
In pipe mode, feature headers are received as interleaved events in the data stream, so the environment is not fully populated until perf_session__process_events() runs.
Because output_headers() is called before the stream events are processed, will calling perf_env__os_release() here trigger the uname fallback and cause a regression that permanently writes the host's release string to the json output instead of the guest's?
Quoted 3 lines
tools/perf/util/env.c +0
-0
[ ... ]
Quoted 1 line
tools/perf/util/env.c +0
-0@@ -361,6 +361,44 @@ bool perf_arch_is_big_endian(const char *arch)
[ ... ]
Quoted 2 lines
tools/perf/util/env.c +2
-0+const char *perf_env__os_release (struct perf_env *env) +{
[ ... ]
Quoted 7 lines
tools/perf/util/env.c +7
-0+/* +* If env->arch is set, this is an offline target environment. +* If the os_release is not populated in the file, we do not want +* to poison it with the host's release which would break guest checks. +*/ +if (env->arch) { + release =NULL ;
tools/perf/util/env.c bool perf_arch_is_big_endian(const char *arch) · line 395
Quoted 10 lines
tools/perf/util/env.c +10
-0+ goto out; + } + +/* +* The os_release is being accessed but wasn't initialized from a data +* file, assume this is 'live' mode and use the release from uname. If +* uname or strdup fails then use the current perf tool version. +*/ + ret =uname (&uts); + env->os_release =strdup (ret <0 ? perf_version_string : uts.release);
[Severity: High]
Does this caching behavior cause a regression in offline symbol resolution for unparsed pipe streams?
If the architecture string is not yet set because the pipe stream hasn't been parsed yet, this helper assumes live mode and caches the host's release in the environment structure.
Could this cause early callers, such as vmlinux_path__init() during symbol initialization, to search for the host's kernel symbols instead of the target's?
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=17
Ian Rogers
reviewerPATCH v12 18/19 perf symbol: Add setters for bitfields sharing a byte to avoid concurrent update issues
In reply to Ian RogersA problem with putting bitfields into struct symbol is that other bits in the symbol could be updated concurrently and only one update to the underlying storage unit happen, leading to lost updates.
To avoid this, use atomics to atomically read or set part of 16-bits of flags in the symbol. Add accessors to simplify this.
The idle value has 3 values in preparation for a later change that will lazily update it.
--- tools/perf/builtin-inject.c | 10 +-- tools/perf/builtin-kwork.c | 2 +- tools/perf/builtin-report.c | 2 +- tools/perf/builtin-sched.c | 4 +- tools/perf/builtin-top.c | 7 +- tools/perf/tests/symbols.c | 2 +- tools/perf/tests/vmlinux-kallsyms.c | 2 +- tools/perf/ui/browsers/annotate.c | 2 +- tools/perf/ui/browsers/map.c | 4 +- tools/perf/util/annotate.c | 5 +- tools/perf/util/auxtrace.c | 6 +- tools/perf/util/callchain.c | 4 +- tools/perf/util/dlfilter.c | 2 +- tools/perf/util/evsel_fprintf.c | 6 +- tools/perf/util/intel-pt.c | 2 +- tools/perf/util/libdw.c | 2 +- tools/perf/util/machine.c | 2 +- tools/perf/util/probe-event.c | 4 +- .../util/scripting-engines/trace-event-perl.c | 2 +- .../scripting-engines/trace-event-python.c | 4 +- tools/perf/util/sort.c | 8 +- tools/perf/util/srcline.c | 10 +-- tools/perf/util/symbol-elf.c | 3 +- tools/perf/util/symbol.c | 86 +++++++++++++++---- tools/perf/util/symbol.h | 78 +++++++++++++---- tools/perf/util/symbol_fprintf.c | 4 +- 26 files changed, 183 insertions(+), 80 deletions(-)
tools/perf/builtin-inject.c +4 -6
@@ -549,13 +549,11 @@ static int perf_event__convert_sample_callchain(const struct perf_tool *tool, node = cursor->first;for (k =0 ; k < cursor->nr && i <PERF_MAX_STACK_DEPTH ; k++) { -if (machine->single_address_space && -machine__kernel_ip (machine, node->ip)) -/* kernel IPs were added already */ ; -else if (node->ms.sym && node->ms.sym->inlined) -/* we can't handle inlined callchains */ ; -else +if (!(machine->single_address_space && +machine__kernel_ip (machine, node->ip)) && + !(node->ms.sym &&symbol__inlined (node->ms.sym))) { inject->raw_callchain->ips[i++] = node->ip; + } node = node->next; }
tools/perf/builtin-kwork.c +1 -1
@@ -769,7 +769,7 @@ static void timehist_save_callchain(struct perf_kwork *kwork,if (sym) {if (!strcmp (sym->name,"__softirqentry_text_start" ) || !strcmp (sym->name,"__do_softirq" )) - sym->ignore =1 ; +symbol__set_ignore (sym, true); }callchain_cursor_advance (cursor);
tools/perf/builtin-report.c +1 -1
@@ -749,7 +749,7 @@ static int hists__resort_cb(struct hist_entry *he, void *arg)struct report *rep = arg;struct symbol *sym = he->ms.sym; -if (rep->symbol_ipc && sym && !sym->annotate2) { +if (rep->symbol_ipc && sym && !symbol__is_annotate2 (sym)) {struct evsel *evsel =hists_to_evsel (he->hists);symbol__annotate2 (&he->ms, evsel,NULL );
tools/perf/builtin-sched.c +2 -2
@@ -2367,7 +2367,7 @@ static void save_task_callchain(struct perf_sched *sched,if (!strcmp (sym->name,"schedule" ) || !strcmp (sym->name,"__schedule" ) || !strcmp (sym->name,"preempt_schedule" )) - sym->ignore =1 ; +symbol__set_ignore (sym, true); }callchain_cursor_advance (cursor);
@@ -3025,7 +3025,7 @@ static size_t callchain__fprintf_folded(FILE *fp, struct callchain_node *node)list_for_each_entry (chain, &node->val, list) {if (chain->ip >=PERF_CONTEXT_MAX )continue ; -if (chain->ms.sym && chain->ms.sym->ignore) +if (chain->ms.sym &&symbol__ignore (chain->ms.sym))continue ; ret += fprintf(fp, "%s%s", first ? "" : sep, callchain_list__sym_name(chain, bf, sizeof(bf),
tools/perf/builtin-top.c +4 -3
@@ -186,8 +186,8 @@ static void ui__warn_map_erange(struct map *map, struct symbol *sym, u64 ip)"Please report to [email protected]\n" , ip,dso__long_name (dso),dso__symtab_origin (dso),map__start (map),map__end (map), sym->start, sym->end, - sym->binding ==STB_GLOBAL ?'g' : - sym->binding ==STB_LOCAL ?'l' :'w' , sym->name, +symbol__binding (sym) ==STB_GLOBAL ?'g' : +symbol__binding (sym) ==STB_LOCAL ?'l' :'w' , sym->name, err ?"[unknown]" : uts.machine, err ? "[unknown]" : uts.release, perf_version_string);if (use_browser <=0 )
@@ -828,7 +828,8 @@ static void perf_event__process_sample(const struct perf_tool *tool, } } -if (al.sym ==NULL || !al.sym->idle) { +if (al.sym ==NULL || + !symbol__is_idle (al.sym, al.map ?map__dso (al.map) :NULL , machine->env)) {struct hists *hists =evsel__hists (sample->evsel);struct hist_entry_iter iter = { .sample = sample,
tools/perf/tests/symbols.c +1 -1
@@ -125,7 +125,7 @@ static int test_dso(struct dso *dso)for (nd =rb_first_cached (dso__symbols (dso)); nd; nd =rb_next (nd)) { struct symbol *sym = rb_entry(nd, struct symbol, rb_node); -if (sym->type !=STT_FUNC && sym->type !=STT_GNU_IFUNC ) +if (symbol__type (sym) !=STT_FUNC &&symbol__type (sym) !=STT_GNU_IFUNC )continue ;/* Check for overlapping function symbols */
tools/perf/tests/vmlinux-kallsyms.c +1 -1
@@ -346,7 +346,7 @@ static int test__vmlinux_matches_kallsyms(struct test_suite *test __maybe_unused* such as __indirect_thunk_end. */ continue ; - }else if (is_ignored_symbol (sym->name, sym->type)) { + }else if (is_ignored_symbol (sym->name,symbol__type (sym))) {/* * Ignore hidden symbols, see scripts/kallsyms.c for the details */
tools/perf/ui/browsers/annotate.c +1 -1
@@ -1185,7 +1185,7 @@ int __hist_entry__tui_annotate(struct hist_entry *he, struct map_symbol *ms,if (dso__annotate_warned (dso))return -1 ; -if (not_annotated || !sym->annotate2) { +if (not_annotated || !symbol__is_annotate2 (sym)) { err =symbol__annotate2 (ms, evsel, &browser.arch);if (err) {annotate_browser__symbol_annotate_error (&browser, err);
tools/perf/ui/browsers/map.c +2 -2
@@ -32,8 +32,8 @@ static void map_browser__write(struct ui_browser *browser, void *nd, int row)ui_browser__set_percent_color (browser,0 , current_entry);ui_browser__printf (browser,"%*" PRIx64" %*" PRIx64" %c " , mb->addrlen, sym->start, mb->addrlen, sym->end, - sym->binding ==STB_GLOBAL ?'g' : - sym->binding ==STB_LOCAL ?'l' :'w' ); +symbol__binding (sym) ==STB_GLOBAL ?'g' : +symbol__binding (sym) ==STB_LOCAL ?'l' :'w' ); width = browser->width - ((mb->addrlen *2 ) +4 );if (width >0 )ui_browser__write_nstring (browser, sym->name, width);
tools/perf/util/annotate.c +3 -2
@@ -236,7 +236,8 @@ static int __symbol__inc_addr_samples(struct map_symbol *ms, h =annotated_source__histogram (src, evsel);if (h ==NULL ) {pr_debug ("%s(%d): ENOMEM! sym->name=%s, start=%#" PRIx64", addr=%#" PRIx64", end=%#" PRIx64", func: %d\n" , - __func__, __LINE__, sym->name, sym->start, addr, sym->end, sym->type ==STT_FUNC ); + __func__, __LINE__, sym->name, sym->start, addr, sym->end, +symbol__type (sym) ==STT_FUNC );return -ENOMEM ; }
@@ -2223,7 +2224,7 @@ int symbol__annotate2(struct map_symbol *ms, struct evsel *evsel,annotation__init_column_widths (notes, sym);annotation__update_column_widths (notes); - sym->annotate2 =1 ; +symbol__set_annotate2 (sym, true);return 0 ; }
tools/perf/util/auxtrace.c +3 -3
@@ -2694,7 +2694,7 @@ static bool dso_sym_match(struct symbol *sym, const char *name, int *cnt, {/* Same name, and global or the n'th found or any */ return !arch__compare_symbol_names (name, sym->name) && - ((!idx && sym->binding ==STB_GLOBAL ) || + ((!idx &&symbol__binding (sym) ==STB_GLOBAL ) || (idx >0 && ++*cnt == idx) || idx <0 ); }
@@ -2712,8 +2712,8 @@ static void print_duplicate_syms(struct dso *dso, const char *sym_name)if (dso_sym_match (sym, sym_name, &cnt,-1 )) {pr_err ("#%d\t0x%" PRIx64"\t%c\t%s\n" , ++cnt, sym->start, - sym->binding ==STB_GLOBAL ?'g' : - sym->binding ==STB_LOCAL ?'l' :'w' , +symbol__binding (sym) ==STB_GLOBAL ?'g' : +symbol__binding (sym) ==STB_LOCAL ?'l' :'w' , sym->name); near = true; }else if (near) {
tools/perf/util/callchain.c +2 -2
@@ -801,7 +801,7 @@ static enum match_result match_chain(struct callchain_cursor_node *node,* symbol start. Otherwise do a faster comparison based * on the symbol start address. */ -if (cnode->ms.sym->inlined || node->ms.sym->inlined) { +if (symbol__inlined (cnode->ms.sym) ||symbol__inlined (node->ms.sym)) { match =match_chain_strings (cnode->ms.sym->name, node->ms.sym->name);if (match !=MATCH_ERROR )
@@ -1245,7 +1245,7 @@ char *callchain_list__sym_name(struct callchain_list *cl,int printed;if (cl->ms.sym) { -const char *inlined = cl->ms.sym->inlined ?" (inlined)" :"" ; +const char *inlined =symbol__inlined (cl->ms.sym) ?" (inlined)" :"" ;if (show_srcline && cl->srcline) printed = scnprintf(bf, bfsize, "%s %s%s",
tools/perf/util/dlfilter.c +1 -1
@@ -56,7 +56,7 @@ static void al_to_d_al(struct addr_location *al, struct perf_dlfilter_al *d_al) d_al->symoff = al->addr -map__start (al->map) - sym->start; else d_al->symoff = 0; - d_al->sym_binding = sym->binding; + d_al->sym_binding =symbol__binding (sym); }else { d_al->sym =NULL ; d_al->sym_start =0 ;
tools/perf/util/evsel_fprintf.c +3 -3
@@ -146,7 +146,7 @@ int sample__fprintf_callchain(struct perf_sample *sample, int left_alignment, sym = node->ms.sym; map = node->ms.map; -if (sym && sym->ignore && print_skip_ignored) +if (sym &&symbol__ignore (sym) && print_skip_ignored) goto next; printed +=fprintf (fp,"%-*.*s" , left_alignment, left_alignment," " );
@@ -182,7 +182,7 @@ int sample__fprintf_callchain(struct perf_sample *sample, int left_alignment,addr_location__exit (&node_al); } -if (print_dso && (!sym || !sym->inlined)) +if (print_dso && (!sym || !symbol__inlined (sym))) printed +=map__fprintf_dsoname_dsoff (map, print_dsoff, addr, fp);if (print_srcline) {
@@ -192,7 +192,7 @@ int sample__fprintf_callchain(struct perf_sample *sample, int left_alignment, printed +=map__fprintf_srcline (map, addr,"\n " , fp); } -if (sym && sym->inlined) +if (sym &&symbol__inlined (sym)) printed +=fprintf (fp," (inlined)" );if (!print_oneline)
tools/perf/util/intel-pt.c +1 -1
@@ -3000,7 +3000,7 @@ static u64 intel_pt_switch_ip(struct intel_pt *pt, u64 *ptss_ip) start =dso__first_symbol (map__dso (map));for (sym = start; sym; sym =dso__next_symbol (sym)) { -if (sym->binding ==STB_GLOBAL && +if (symbol__binding (sym) ==STB_GLOBAL && !strcmp (sym->name,"__switch_to" )) { ip =map__unmap_ip (map, sym->start);if (ip >=map__start (map) && ip <map__end (map)) {
tools/perf/util/libdw.c +1 -1
@@ -130,7 +130,7 @@ static int libdw_a2l_cb(Dwarf_Die *die, void *_args)return 0 ; abort_delete_sym: -if (inline_sym->inlined) +if (symbol__inlined (inline_sym))symbol__delete (inline_sym); abort_enomem: args->err = -ENOMEM ;
tools/perf/util/machine.c +1 -1
@@ -1095,7 +1095,7 @@ static u64 find_entry_trampoline(struct dso *dso)unsigned int i;for (; sym; sym =dso__next_symbol (sym)) { -if (sym->binding !=STB_GLOBAL ) +if (symbol__binding (sym) !=STB_GLOBAL )continue ;for (i =0 ; i <ARRAY_SIZE (syms); i++) {if (!strcmp (sym->name, syms[i]))
tools/perf/util/probe-event.c +2 -2
@@ -416,7 +416,7 @@ static int find_alternative_probe_point(struct debuginfo *dinfo,map__for_each_symbol_by_name (map, pp->function, sym, idx) {if (uprobes) { address = sym->start; -if (sym->type ==STT_GNU_IFUNC ) +if (symbol__type (sym) ==STT_GNU_IFUNC )pr_warning ("Warning: The probe function (%s) is a GNU indirect function.\n" "Consider identifying the final function used at run time and set the probe directly on that.\n" , pp->function);
@@ -3189,7 +3189,7 @@ static int find_probe_trace_events_from_map(struct perf_probe_event *pev,for (j =0 ; j < num_matched_functions; j++) { sym = syms[j]; -if (sym->type !=STT_FUNC ) +if (symbol__type (sym) !=STT_FUNC )continue ;/* There can be duplicated symbols in the map */
tools/perf/util/scripting-engines/trace-event-perl.c +1 -1
@@ -303,7 +303,7 @@ static SV *perl_process_callchain(struct perf_sample *sample, }if (!hv_stores (sym,"start" ,newSVuv (node->ms.sym->start)) || !hv_stores (sym,"end" ,newSVuv (node->ms.sym->end)) || - !hv_stores (sym,"binding" ,newSVuv (node->ms.sym->binding)) || + !hv_stores (sym,"binding" ,newSVuv (symbol__binding (node->ms.sym))) || !hv_stores (sym,"name" ,newSVpvn (node->ms.sym->name, node->ms.sym->namelen)) || !hv_stores (elem,"sym" ,newRV_noinc ((SV *)sym))) {
tools/perf/util/scripting-engines/trace-event-python.c +2 -2
@@ -436,7 +436,7 @@ static PyObject *python_process_callchain(struct perf_sample *sample,pydict_set_item_string_decref (pysym,"end" ,PyLong_FromUnsignedLongLong (node->ms.sym->end));pydict_set_item_string_decref (pysym,"binding" , -_PyLong_FromLong (node->ms.sym->binding)); +_PyLong_FromLong (symbol__binding (node->ms.sym)));pydict_set_item_string_decref (pysym,"name" ,_PyUnicode_FromStringAndSize (node->ms.sym->name, node->ms.sym->namelen));
@@ -1270,7 +1270,7 @@ static int python_export_symbol(struct db_export *dbe, struct symbol *sym,tuple_set_d64 (t,1 ,dso__db_id (dso));tuple_set_d64 (t,2 , sym->start);tuple_set_d64 (t,3 , sym->end); -tuple_set_s32 (t,4 , sym->binding); +tuple_set_s32 (t,4 ,symbol__binding (sym));tuple_set_string (t,5 , sym->name);call_object (tables->symbol_handler, t,"symbol_table" );
tools/perf/util/sort.c +4 -4
@@ -469,7 +469,7 @@ int64_t _sort__sym_cmp(struct symbol *sym_l, struct symbol *sym_r)if (sym_l == sym_r)return 0 ; -if (sym_l->inlined || sym_r->inlined) { +if (symbol__inlined (sym_l) ||symbol__inlined (sym_r)) {int ret =strcmp (sym_l->name, sym_r->name);if (ret)
@@ -536,7 +536,7 @@ static int _hist_entry__sym_snprintf(struct map_symbol *ms, ret +=repsep_snprintf (bf + ret, size - ret,"[%c] " , level);if (sym && map) { -if (sym->type ==STT_OBJECT ) { +if (symbol__type (sym) ==STT_OBJECT ) { ret +=repsep_snprintf (bf + ret, size - ret,"%s" , sym->name); ret +=repsep_snprintf (bf + ret, size - ret,"+0x%llx" , ip -map__unmap_ip (map, sym->start));
@@ -544,7 +544,7 @@ static int _hist_entry__sym_snprintf(struct map_symbol *ms, ret +=repsep_snprintf (bf + ret, size - ret,"%.*s" , width - ret, sym->name); -if (sym->inlined) +if (symbol__inlined (sym)) ret +=repsep_snprintf (bf + ret, size - ret," (inlined)" ); }
@@ -1483,7 +1483,7 @@ static int _hist_entry__addr_snprintf(struct map_symbol *ms, ret +=repsep_snprintf (bf + ret, size - ret,"[%c] " , level);if (sym && map) { -if (sym->type ==STT_OBJECT ) { +if (symbol__type (sym) ==STT_OBJECT ) { ret +=repsep_snprintf (bf + ret, size - ret,"%s" , sym->name); ret +=repsep_snprintf (bf + ret, size - ret,"+0x%llx" , ip -map__unmap_ip (map, sym->start));
tools/perf/util/srcline.c +5 -5
@@ -113,16 +113,16 @@ struct symbol *new_inline_sym(struct dso *dso,/* ensure that we don't alias an inlined symbol, which could * lead to double frees in inline_node__delete */ -assert (!base_sym->inlined); +assert (!symbol__inlined (base_sym)); }else {/* create a fake symbol for the inline frame */ inline_sym =symbol__new (base_sym ? base_sym->start :0 , base_sym ? (base_sym->end - base_sym->start) :0 , - base_sym ? base_sym->binding :0 , - base_sym ? base_sym->type :0 , + base_sym ?symbol__binding (base_sym) :0 , + base_sym ?symbol__type (base_sym) :0 , funcname);if (inline_sym) - inline_sym->inlined =1 ; +symbol__set_inlined (inline_sym, true); }free (demangled);
@@ -440,7 +440,7 @@ void inline_node__clear_frames(struct inline_node *node)list_del_init (&ilist->list);zfree_srcline (&ilist->srcline);/* only the inlined symbols are owned by the list */ -if (ilist->symbol && ilist->symbol->inlined) +if (ilist->symbol &&symbol__inlined (ilist->symbol))symbol__delete (ilist->symbol);free (ilist); }
tools/perf/util/symbol-elf.c +2 -1
@@ -350,7 +350,8 @@ static bool get_ifunc_name(Elf *elf, struct dso *dso, GElf_Ehdr *ehdr, sym =dso__find_symbol_nocache (dso, addr);/* Expecting the address to be an IFUNC or IFUNC alias */ -if (!sym || sym->start != addr || (sym->type !=STT_GNU_IFUNC && !sym->ifunc_alias)) +if (!sym || sym->start != addr || + (symbol__type (sym) !=STT_GNU_IFUNC && !symbol__ifunc_alias (sym)))return false;snprintf (buf, buf_sz,"%s@plt" , sym->name);
tools/perf/util/symbol.c +70 -16
153 lines not on this page · raw message
tools/perf/util/symbol.h +63 -15
114 lines not on this page · raw message
tools/perf/util/symbol_fprintf.c +2 -2
@@ -11,8 +11,8 @@ size_t symbol__fprintf(struct symbol *sym, FILE *fp) {return fprintf (fp," %" PRIx64"-%" PRIx64" %c %s\n" , sym->start, sym->end, - sym->binding ==STB_GLOBAL ?'g' : - sym->binding ==STB_LOCAL ?'l' :'w' , +symbol__binding (sym) ==STB_GLOBAL ?'g' : +symbol__binding (sym) ==STB_LOCAL ?'l' :'w' , sym->name); }
Signature · 1 line
2.54.0.929.g9b7fa37559-goog
Ian Rogers
reviewerPATCH v12 19/19 perf symbol: Lazily compute idle
In reply to Ian RogersSwitch from an idle boolean to a helper symbol__is_idle function. In the function lazily compute whether a symbol is an idle function taking into consideration the kernel version and architecture of the machine. As symbols__insert no longer needs to know if a symbol is for the kernel, remove the argument.
To protect against drop-filtering of legitimate setup, online, or hotplug management functions (such as intel_idle_init), x86 matches are strictly constrained to exact known run-loops (intel_idle, intel_idle_irq, mwait_idle, mwait_idle_with_hints).
If the target environment OS release is unresolvable (such as on guest traces), default to treating psw_idle as idle to prevent false negatives and match legacy trace behavior safely.
This change is inspired by mailing list discussion, particularly from Thomas Richter <[email protected]> and Heiko Carstens <[email protected]>:
https://lore.kernel.org/lkml/[email protected]/
--- tools/perf/util/symbol-elf.c | 2 +- tools/perf/util/symbol.c | 146 +++++++++++++++++++++++------------ tools/perf/util/symbol.h | 4 +- 3 files changed, 100 insertions(+), 52 deletions(-)
tools/perf/util/symbol-elf.c +1 -1
@@ -1734,7 +1734,7 @@ dso__load_sym_internal(struct dso *dso, struct map *map, struct symsrc *syms_ss,arch__sym_update (f, &sym); -__symbols__insert (dso__symbols (curr_dso), f,dso__kernel (dso)); +__symbols__insert (dso__symbols (curr_dso), f); nr++; }dso__put (curr_dso);
tools/perf/util/symbol.c +98 -48
215 lines not on this page · raw message
tools/perf/util/symbol.h +1 -3
@@ -76,7 +76,6 @@ enum symbol_idle_kind {#define SYMBOL_FLAG_INLINED (1 << 11)#define SYMBOL_FLAG_ANNOTATE2 (1 << 12)#define SYMBOL_FLAG_IFUNC_ALIAS (1 << 13) -/** * A symtab entry. When allocated this may be preceded by an annotation (see * symbol__annotation) and/or a browser_index (see symbol__browser_index).
@@ -257,8 +256,7 @@ int dso__synthesize_plt_symbols(struct dso *dso, struct symsrc *ss);char *dso__demangle_sym (struct dso *dso,int kmodule,const char *elf_name); -void __symbols__insert (struct rb_root_cached *symbols,struct symbol *sym, -bool kernel); +void __symbols__insert (struct rb_root_cached *symbols,struct symbol *sym);void symbols__insert (struct rb_root_cached *symbols,struct symbol *sym);void symbols__fixup_duplicate (struct rb_root_cached *symbols);void symbols__fixup_end (struct rb_root_cached *symbols,bool is_kallsyms);
Signature · 1 line
2.54.0.929.g9b7fa37559-goog
Ian Rogers
reviewerRe: [PATCH v12 00/19] perf: Use e_machine and lazily compute symbols
In reply to Ian RogersQuoted 25 lines · Ian Rogers
Add a helper to
perf_envto compute thee_machineif it isEM_NONE. Derive the value from the arch string if available. Similarly derive the arch string from the ELF machine if available, for consistency. This means perf's arch (machine type) is no longer determined by uname but set to match that of the perf ELF executable.Migrate code away from strcmp on
env->archto using thee_machinecomparisons that are more accurate and not prone to uname and other naming differences. While cleaning this up, also clean up the capstone initialization code to cover more architectures and to set the big endian flag based on ELF header information.Refactor
perf_env__arch_strerrnoto take ane_machineinstead of an architecture string, removing theHAVE_LIBTRACEEVENTdependency entirely and making it unconditionally available. The generated errno table includes fallback definitions for newer ELF machine constants to ensure compatibility with older host glibc versions.Introduce a mutex in
perf_envto safely protect lazy metadata setup, such asos_releaseore_machineresolution, preventing concurrent initialization data races and memory leaks during multi-threaded profiling or symbol loading. Properly initialize stack-allocatedperf_envinstances to ensure safe mutex destruction.
Quoted 7 lines
Switch the idle computation to the point of use and lazily compute it, rather than computing it for every symbol. The current only user is
perf top. At the point of use theperf_envis available and this can be used to make sure the idle function computation correctly accounts for architecture-specific and kernel-version-specific patterns. To prevent concurrent updates to shared symbol bitfield flags, migrate bitfield variables in struct symbol to C11 atomic flags.
So I think this series is at the point where Sashiko [1] is giving warnings only for out-of-scope things and pre-existing conditions. I will give a detailed explanation below, but I'd appreciate help moving this forward with human review and submission. Thanks!
Quoted 2 lines
Ian Rogers (19):
perf env: Addperf_env__e_machinehelper and use inperf_env__arch
1 critical 2 high issues.
The issues relate to existing data races, the inaccurate arch string, and normalizing the arch string stored in the data file. The existing data races don't bite us currently due to the single threaded nature of most of perf - multithreading is on the TODO list. The arch string is inaccurate and the e_machine in newer perf.data files resolves this. If we were using the arch string without the e_machine then the concerns over its use are valid, but this series is trying to remove the use of the arch string and strongly prefer the e_machine.
Quoted 1 line
perf tests topology: Switch
env->archuse toenv->e_machine
No regressions.
Quoted 1 line
perf env, dso, thread: Add
_endianvariants fore_machinehelpers
1 high issue for a potential pre-existing SEGV if a thread lacks maps. Let's hope that doesn't happen, the example given assumes a multithreaded environment and multi-threading is on the TODO list.
Quoted 1 line
perf capstone: Determine architecture from
e_machine
1 low issue. A flag only present in capstone 4.0 is used. As capstone 4.0 was released in 2018, let's just assume the flag is there rather than adding yet more complexity.
Quoted 1 line
perf
print_insn: Usee_machinefor fallback IP length check
No regressions.
Quoted 1 line
perf symbol: Avoid use of
machine__is
1 high issue. Concerns over pre-existing cross-platform analysis problems. Cross-platform analysis fully working is on the TODO list.
Quoted 9 lines
perf machine: Use
perf_enve_machinerather than arch perf sample-raw: Useperf_enve_machinerather than arch perf sort: Useperf_enve_machinerather than arch perf arch common: Useperf_enve_machinerather than arch perf header: Inprint_pmu_capsuseperf_enve_machineperf c2c: Useperf_enve_machinerather than arch perf lock-contention: Useperf_enve_machinerather than arch perf env: Refactorperf_env__arch_strerrno
perf env: Remove unusedperf_env__raw_arch
No regressions x9.
Quoted 1 line
perf env: Add mutex to protect lazy environment initialization
1 medium issue requesting more locking on more bits of perf_env. Multi-threading is on the TODO list and let's stop the feature creep here.
Quoted 1 line
perf env: Add helper to lazily compute the
os_release
1 high issue. Concern over a perf data issue in pipe mode. Addressing this would require a fairly major overhail of perf data, so let's add fixing to the TODO list.
Quoted 3 lines
perf symbol: Add setters for bitfields sharing a byte to avoid
concurrent update issues
perf symbol: Lazily compute idle
No regressions x2.
Thanks,
Ian
[1] https://sashiko.dev/#/patchset/20260602152516.2831152-1-irogers%40google.com
Quoted 55 lines
tools/perf/arch/common.c | 92 +++-- tools/perf/builtin-c2c.c | 40 +- tools/perf/builtin-inject.c | 10 +- tools/perf/builtin-kwork.c | 2 +- tools/perf/builtin-report.c | 2 +- tools/perf/builtin-sched.c | 4 +- tools/perf/builtin-top.c | 7 +- tools/perf/builtin-trace.c | 7 +- tools/perf/tests/symbols.c | 2 +- tools/perf/tests/topology.c | 8 +- tools/perf/tests/vmlinux-kallsyms.c | 2 +- tools/perf/trace/beauty/Build | 1 + tools/perf/trace/beauty/arch_errno_names.sh | 53 ++- tools/perf/ui/browsers/annotate.c | 2 +- tools/perf/ui/browsers/map.c | 4 +- tools/perf/util/annotate.c | 5 +- tools/perf/util/auxtrace.c | 6 +- tools/perf/util/callchain.c | 4 +- tools/perf/util/capstone.c | 132 ++++-- tools/perf/util/data-convert-bt.c | 2 +- tools/perf/util/data-convert-json.c | 6 +- tools/perf/util/dlfilter.c | 2 +- tools/perf/util/dso.c | 19 +- tools/perf/util/dso.h | 14 +- tools/perf/util/env.c | 376 ++++++++++++++---- tools/perf/util/env.h | 14 +- tools/perf/util/evsel_fprintf.c | 6 +- tools/perf/util/header.c | 55 ++- tools/perf/util/intel-pt.c | 2 +- tools/perf/util/libdw.c | 2 +- tools/perf/util/lock-contention.c | 6 +- tools/perf/util/machine.c | 37 +- tools/perf/util/machine.h | 2 - tools/perf/util/print_insn.c | 23 +- tools/perf/util/print_insn.h | 2 + tools/perf/util/probe-event.c | 4 +- tools/perf/util/sample-raw.c | 21 +- tools/perf/util/sample-raw.h | 6 +- .../util/scripting-engines/trace-event-perl.c | 2 +- .../scripting-engines/trace-event-python.c | 4 +- tools/perf/util/session.c | 26 +- tools/perf/util/sort.c | 66 +-- tools/perf/util/srcline.c | 10 +- tools/perf/util/symbol-elf.c | 5 +- tools/perf/util/symbol.c | 238 ++++++++--- tools/perf/util/symbol.h | 80 +++- tools/perf/util/symbol_fprintf.c | 4 +- tools/perf/util/thread.c | 58 ++- tools/perf/util/thread.h | 23 +- 49 files changed, 1078 insertions(+), 420 deletions(-)--
2.54.0.929.g9b7fa37559-goog
Re: [PATCH v12 00/19] perf: Use e_machine and lazily compute symbols
Hi Ian,
Quoted 101 lines · Ian Rogers
Quoted 25 lines · Ian Rogers
Add a helper to
perf_envto compute thee_machineif it isEM_NONE. Derive the value from the arch string if available. Similarly derive the arch string from the ELF machine if available, for consistency. This means perf's arch (machine type) is no longer determined by uname but set to match that of the perf ELF executable.Migrate code away from strcmp on
env->archto using thee_machinecomparisons that are more accurate and not prone to uname and other naming differences. While cleaning this up, also clean up the capstone initialization code to cover more architectures and to set the big endian flag based on ELF header information.Refactor
perf_env__arch_strerrnoto take ane_machineinstead of an architecture string, removing theHAVE_LIBTRACEEVENTdependency entirely and making it unconditionally available. The generated errno table includes fallback definitions for newer ELF machine constants to ensure compatibility with older host glibc versions.Introduce a mutex in
perf_envto safely protect lazy metadata setup, such asos_releaseore_machineresolution, preventing concurrent initialization data races and memory leaks during multi-threaded profiling or symbol loading. Properly initialize stack-allocatedperf_envinstances to ensure safe mutex destruction.Quoted 7 lines
Switch the idle computation to the point of use and lazily compute it, rather than computing it for every symbol. The current only user is
perf top. At the point of use theperf_envis available and this can be used to make sure the idle function computation correctly accounts for architecture-specific and kernel-version-specific patterns. To prevent concurrent updates to shared symbol bitfield flags, migrate bitfield variables in struct symbol to C11 atomic flags.So I think this series is at the point where Sashiko [1] is giving warnings only for out-of-scope things and pre-existing conditions. I will give a detailed explanation below, but I'd appreciate help moving this forward with human review and submission. Thanks!
Quoted 2 lines
Ian Rogers (19):
perf env: Addperf_env__e_machinehelper and use inperf_env__arch1 critical 2 high issues.
The issues relate to existing data races, the inaccurate arch string, and normalizing the arch string stored in the data file. The existing data races don't bite us currently due to the single threaded nature of most of perf - multithreading is on the TODO list. The arch string is inaccurate and thee_machinein newer perf.data files resolves this. If we were using the arch string without thee_machinethen the concerns over its use are valid, but this series is trying to remove the use of the arch string and strongly prefer thee_machine.Quoted 1 line
perf tests topology: Switch
env->archuse toenv->e_machineNo regressions.
Quoted 1 line
perf env, dso, thread: Add
_endianvariants fore_machinehelpers1 high issue for a potential pre-existing SEGV if a thread lacks maps. Let's hope that doesn't happen, the example given assumes a multithreaded environment and multi-threading is on the TODO list.
Quoted 1 line
perf capstone: Determine architecture from
e_machine1 low issue. A flag only present in capstone 4.0 is used. As capstone 4.0 was released in 2018, let's just assume the flag is there rather than adding yet more complexity.
Quoted 1 line
perf
print_insn: Usee_machinefor fallback IP length checkNo regressions.
Quoted 1 line
perf symbol: Avoid use of
machine__is1 high issue. Concerns over pre-existing cross-platform analysis problems. Cross-platform analysis fully working is on the TODO list.
Quoted 9 lines
perf machine: Use
perf_enve_machinerather than arch perf sample-raw: Useperf_enve_machinerather than arch perf sort: Useperf_enve_machinerather than arch perf arch common: Useperf_enve_machinerather than arch perf header: Inprint_pmu_capsuseperf_enve_machineperf c2c: Useperf_enve_machinerather than arch perf lock-contention: Useperf_enve_machinerather than arch perf env: Refactorperf_env__arch_strerrno
perf env: Remove unusedperf_env__raw_archNo regressions x9.
Quoted 1 line
perf env: Add mutex to protect lazy environment initialization
1 medium issue requesting more locking on more bits of
perf_env. Multi-threading is on the TODO list and let's stop the feature creep here.Quoted 1 line
perf env: Add helper to lazily compute the
os_release1 high issue. Concern over a perf data issue in pipe mode. Addressing this would require a fairly major overhail of perf data, so let's add fixing to the TODO list.
Quoted 5 lines
Quoted 3 lines
perf symbol: Add setters for bitfields sharing a byte to avoid
concurrent update issues
perf symbol: Lazily compute idleNo regressions x2.
Thanks,
Namhyung
Re: [PATCH v12 00/19] perf: Use e_machine and lazily compute symbols
Quoted 102 lines · Namhyung Kim
Quoted 101 lines · Ian Rogers
Quoted 25 lines · Ian Rogers
Add a helper to
perf_envto compute thee_machineif it isEM_NONE. Derive the value from the arch string if available. Similarly derive the arch string from the ELF machine if available, for consistency. This means perf's arch (machine type) is no longer determined by uname but set to match that of the perf ELF executable.Migrate code away from strcmp on
env->archto using thee_machinecomparisons that are more accurate and not prone to uname and other naming differences. While cleaning this up, also clean up the capstone initialization code to cover more architectures and to set the big endian flag based on ELF header information.Refactor
perf_env__arch_strerrnoto take ane_machineinstead of an architecture string, removing theHAVE_LIBTRACEEVENTdependency entirely and making it unconditionally available. The generated errno table includes fallback definitions for newer ELF machine constants to ensure compatibility with older host glibc versions.Introduce a mutex in
perf_envto safely protect lazy metadata setup, such asos_releaseore_machineresolution, preventing concurrent initialization data races and memory leaks during multi-threaded profiling or symbol loading. Properly initialize stack-allocatedperf_envinstances to ensure safe mutex destruction.Quoted 7 lines
Switch the idle computation to the point of use and lazily compute it, rather than computing it for every symbol. The current only user is
perf top. At the point of use theperf_envis available and this can be used to make sure the idle function computation correctly accounts for architecture-specific and kernel-version-specific patterns. To prevent concurrent updates to shared symbol bitfield flags, migrate bitfield variables in struct symbol to C11 atomic flags.So I think this series is at the point where Sashiko [1] is giving warnings only for out-of-scope things and pre-existing conditions. I will give a detailed explanation below, but I'd appreciate help moving this forward with human review and submission. Thanks!
Quoted 2 lines
Ian Rogers (19):
perf env: Addperf_env__e_machinehelper and use inperf_env__arch1 critical 2 high issues.
The issues relate to existing data races, the inaccurate arch string, and normalizing the arch string stored in the data file. The existing data races don't bite us currently due to the single threaded nature of most of perf - multithreading is on the TODO list. The arch string is inaccurate and thee_machinein newer perf.data files resolves this. If we were using the arch string without thee_machinethen the concerns over its use are valid, but this series is trying to remove the use of the arch string and strongly prefer thee_machine.Quoted 1 line
perf tests topology: Switch
env->archuse toenv->e_machineNo regressions.
Quoted 1 line
perf env, dso, thread: Add
_endianvariants fore_machinehelpers1 high issue for a potential pre-existing SEGV if a thread lacks maps. Let's hope that doesn't happen, the example given assumes a multithreaded environment and multi-threading is on the TODO list.
Quoted 1 line
perf capstone: Determine architecture from
e_machine1 low issue. A flag only present in capstone 4.0 is used. As capstone 4.0 was released in 2018, let's just assume the flag is there rather than adding yet more complexity.
Quoted 1 line
perf
print_insn: Usee_machinefor fallback IP length checkNo regressions.
Quoted 1 line
perf symbol: Avoid use of
machine__is1 high issue. Concerns over pre-existing cross-platform analysis problems. Cross-platform analysis fully working is on the TODO list.
Quoted 9 lines
perf machine: Use
perf_enve_machinerather than arch perf sample-raw: Useperf_enve_machinerather than arch perf sort: Useperf_enve_machinerather than arch perf arch common: Useperf_enve_machinerather than arch perf header: Inprint_pmu_capsuseperf_enve_machineperf c2c: Useperf_enve_machinerather than arch perf lock-contention: Useperf_enve_machinerather than arch perf env: Refactorperf_env__arch_strerrno
perf env: Remove unusedperf_env__raw_archNo regressions x9.
Quoted 1 line
perf env: Add mutex to protect lazy environment initialization
1 medium issue requesting more locking on more bits of
perf_env. Multi-threading is on the TODO list and let's stop the feature creep here.Quoted 1 line
perf env: Add helper to lazily compute the
os_release1 high issue. Concern over a perf data issue in pipe mode. Addressing this would require a fairly major overhail of perf data, so let's add fixing to the TODO list.
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
perf symbol: Add setters for bitfields sharing a byte to avoid
concurrent update issues
perf symbol: Lazily compute idleNo regressions x2.
Acked-by Namhyung Kim <[email protected]>
Thanks, applied to perf-tools-next, for v7.2.
- Arnaldo
Arnaldo Carvalho de Melo
maintainerRe: [PATCH v12 00/19] perf: Use e_machine and lazily compute symbols
Quoted 11 lines · Arnaldo Carvalho de Melo
Quoted 9 lines · Namhyung Kim
Quoted 8 lines · Ian Rogers
On Tue, Jun 2, 2026 at 8:25 AM Ian Rogers <[email protected]> wrote:
1 high issue. Concern over a perf data issue in pipe mode. Addressing this would require a fairly major overhail of perf data, so let's add fixing to the TODO list.Quoted 3 lines
perf symbol: Add setters for bitfields sharing a byte to avoid
concurrent update issues
perf symbol: Lazily compute idle
Quoted 5 lines
Quoted 3 lines
Quoted 1 line
No regressions x2.
Acked-by Namhyung Kim <[email protected]>Thanks, applied to perf-tools-next, for v7.2.
Now trying to fix this, all old distros, but if the fix is cheap enough, lets not drop support for them:
toolsbuilder@five:~$ cat dm.log/summary Subject: tools build test for http://192.168.86.5/perf/perf-7.1.0-rc5.tar.xz
1 127.96 almalinux:8 : Ok gcc (GCC) 8.5.0 20210514 (Red Hat 8.5.0-28) , clang version 21.1.8 ( 21.1.8-1.module_el8.10.0+4172+b6b13d75) flex 2.6.1
2 12.44 almalinux:9 : FAIL gcc version 11.5.0 20240719 (Red Hat 11.5.0-14) (GCC)
util/capstone.c: In function 'e_machine_to_capstone':
util/capstone.c:186:25: error: 'CS_ARCH_RISCV' undeclared (first use in this function); did you mean 'CS_ARCH_SYSZ'?
186 | *arch = CS_ARCH_RISCV;
| ^~~~~~~~~~~~~
| CS_ARCH_SYSZ
util/capstone.c:186:25: note: each undeclared identifier is reported only once for each function it appears in util/capstone.c:187:34: error: 'CS_MODE_RISCV64' undeclared (first use in this function); did you mean 'CS_MODE_MIPS64'?
187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC;
| ^~~~~~~~~~~~~~~
| CS_MODE_MIPS64
util/capstone.c:187:52: error: 'CS_MODE_RISCV32' undeclared (first use in this function); did you mean 'CS_MODE_MIPS32'?
187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC;
| ^~~~~~~~~~~~~~~
| CS_MODE_MIPS32
util/capstone.c:187:71: error: 'CS_MODE_RISCVC' undeclared (first use in this function); did you mean 'CS_MODE_MICRO'?
187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC;
| ^~~~~~~~~~~~~~
| CS_MODE_MICRO
3 17.54 almalinux:9-i386 : FAIL gcc version 11.4.1 20231218 (Red Hat 11.4.1-3) (GCC)
util/capstone.c: In function ‘e_machine_to_capstone’:
util/capstone.c:186:25: error: ‘CS_ARCH_RISCV’ undeclared (first use in this function); did you mean ‘CS_ARCH_SYSZ’?
186 | *arch = CS_ARCH_RISCV;
| ^~~~~~~~~~~~~
| CS_ARCH_SYSZ
util/capstone.c:186:25: note: each undeclared identifier is reported only once for each function it appears in util/capstone.c:187:34: error: ‘CS_MODE_RISCV64’ undeclared (first use in this function); did you mean ‘CS_MODE_MIPS64’?
187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC;
| ^~~~~~~~~~~~~~~
| CS_MODE_MIPS64
util/capstone.c:187:52: error: ‘CS_MODE_RISCV32’ undeclared (first use in this function); did you mean ‘CS_MODE_MIPS32’?
187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC;
| ^~~~~~~~~~~~~~~
| CS_MODE_MIPS32
util/capstone.c:187:71: error: ‘CS_MODE_RISCVC’ undeclared (first use in this function); did you mean ‘CS_MODE_MICRO’?
187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC;
| ^~~~~~~~~~~~~~
| CS_MODE_MICRO
4 101.24 almalinux:10 : Ok gcc (GCC) 14.3.1 20251022 (Red Hat 14.3.1-4) , clang version 21.1.8 (AlmaLinux OS Foundation 21.1.8-1.el10.alma.1) flex 2.6.4
5 21.66 alpine:3.16 : FAIL gcc version 11.2.1 20220219 (Alpine 11.2.1_git20220219)
util/capstone.c: In function 'e_machine_to_capstone':
util/capstone.c:186:25: error: 'CS_ARCH_RISCV' undeclared (first use in this function); did you mean 'CS_ARCH_SYSZ'?
186 | *arch = CS_ARCH_RISCV;
| ^~~~~~~~~~~~~
| CS_ARCH_SYSZ
util/capstone.c:186:25: note: each undeclared identifier is reported only once for each function it appears in
util/capstone.c:187:34: error: 'CS_MODE_RISCV64' undeclared (first use in this function); did you mean 'CS_MODE_MIPS64'?
187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC;
| ^~~~~~~~~~~~~~~
| CS_MODE_MIPS64
util/capstone.c:187:52: error: 'CS_MODE_RISCV32' undeclared (first use in this function); did you mean 'CS_MODE_MIPS32'?
187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC;
| ^~~~~~~~~~~~~~~
| CS_MODE_MIPS32
util/capstone.c:187:71: error: 'CS_MODE_RISCVC' undeclared (first use in this function); did you mean 'CS_MODE_MICRO'?
187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC;
| ^~~~~~~~~~~~~~
| CS_MODE_MICRO
make[3]: *** [/git/perf-7.1.0-rc5/tools/build/Makefile.build:158: util] Error 2
6 14.57 alpine:3.17 : FAIL gcc version 12.2.1 20220924 (Alpine 12.2.1_git20220924-r4)
util/capstone.c: In function 'e_machine_to_capstone':
util/capstone.c:186:25: error: 'CS_ARCH_RISCV' undeclared (first use in this function); did you mean 'CS_ARCH_SYSZ'?
186 | *arch = CS_ARCH_RISCV;
| ^~~~~~~~~~~~~
| CS_ARCH_SYSZ
util/capstone.c:186:25: note: each undeclared identifier is reported only once for each function it appears in
util/capstone.c:187:34: error: 'CS_MODE_RISCV64' undeclared (first use in this function); did you mean 'CS_MODE_MIPS64'?
187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC;
| ^~~~~~~~~~~~~~~
| CS_MODE_MIPS64
util/capstone.c:187:52: error: 'CS_MODE_RISCV32' undeclared (first use in this function); did you mean 'CS_MODE_MIPS32'?
187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC;
| ^~~~~~~~~~~~~~~
| CS_MODE_MIPS32
util/capstone.c:187:71: error: 'CS_MODE_RISCVC' undeclared (first use in this function); did you mean 'CS_MODE_MICRO'?
187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC;
| ^~~~~~~~~~~~~~
| CS_MODE_MICRO
make[3]: *** [/git/perf-7.1.0-rc5/tools/build/Makefile.build:158: util] Error 2
7 13.58 alpine:3.18 : FAIL gcc version 12.2.1 20220924 (Alpine 12.2.1_git20220924-r10)
util/capstone.c: In function 'e_machine_to_capstone':
util/capstone.c:186:25: error: 'CS_ARCH_RISCV' undeclared (first use in this function); did you mean 'CS_ARCH_SYSZ'?
186 | *arch = CS_ARCH_RISCV;
| ^~~~~~~~~~~~~
| CS_ARCH_SYSZ
util/capstone.c:186:25: note: each undeclared identifier is reported only once for each function it appears in
util/capstone.c:187:34: error: 'CS_MODE_RISCV64' undeclared (first use in this function); did you mean 'CS_MODE_MIPS64'?
187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC;
| ^~~~~~~~~~~~~~~
| CS_MODE_MIPS64
util/capstone.c:187:52: error: 'CS_MODE_RISCV32' undeclared (first use in this function); did you mean 'CS_MODE_MIPS32'?
187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC;
| ^~~~~~~~~~~~~~~
| CS_MODE_MIPS32
util/capstone.c:187:71: error: 'CS_MODE_RISCVC' undeclared (first use in this function); did you mean 'CS_MODE_MICRO'?
187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC;
| ^~~~~~~~~~~~~~
| CS_MODE_MICRO
8 127.15 alpine:3.19 : Ok gcc (Alpine 13.2.1_git20231014) 13.2.1 20231014 , Alpine clang version 17.0.5 flex 2.6.4
9 124.98 alpine:3.20 : Ok gcc (Alpine 13.2.1_git20240309) 13.2.1 20240309 , Alpine clang version 17.0.6 flex 2.6.4
10 134.36 alpine:3.22 : Ok gcc (Alpine 14.2.0) 14.2.0 , Alpine clang version 20.1.8 flex 2.6.4
11 128.47 alpine:3.23 : Ok gcc (Alpine 15.2.0) 15.2.0 , Alpine clang version 21.1.2 flex 2.6.4
12 134.59 alpine:edge : Ok gcc (Alpine 14.2.0) 14.2.0 , Alpine clang version 19.1.4 flex 2.6.4
13 13.41 amazonlinux:2023 : FAIL gcc version 11.5.0 20240719 (Red Hat 11.5.0-5) (GCC)
util/capstone.c: In function 'e_machine_to_capstone':
util/capstone.c:186:25: error: 'CS_ARCH_RISCV' undeclared (first use in this function); did you mean 'CS_ARCH_SYSZ'?
186 | *arch = CS_ARCH_RISCV;
| ^~~~~~~~~~~~~
| CS_ARCH_SYSZ
util/capstone.c:186:25: note: each undeclared identifier is reported only once for each function it appears in
util/capstone.c:187:34: error: 'CS_MODE_RISCV64' undeclared (first use in this function); did you mean 'CS_MODE_MIPS64'?
187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC;
| ^~~~~~~~~~~~~~~
| CS_MODE_MIPS64
util/capstone.c:187:52: error: 'CS_MODE_RISCV32' undeclared (first use in this function); did you mean 'CS_MODE_MIPS32'?
187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC;
| ^~~~~~~~~~~~~~~
| CS_MODE_MIPS32
util/capstone.c:187:71: error: 'CS_MODE_RISCVC' undeclared (first use in this function); did you mean 'CS_MODE_MICRO'?
187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC;
| ^~~~~~~~~~~~~~
| CS_MODE_MICRO
make[3]: *** [/git/perf-7.1.0-rc5/tools/build/Makefile.build:158: util] Error 2
14 14.14 amazonlinux:devel : FAIL gcc version 11.3.1 20221121 (Red Hat 11.3.1-4) (GCC)
util/capstone.c: In function 'e_machine_to_capstone':
util/capstone.c:186:25: error: 'CS_ARCH_RISCV' undeclared (first use in this function); did you mean 'CS_ARCH_SYSZ'?
186 | *arch = CS_ARCH_RISCV;
| ^~~~~~~~~~~~~
| CS_ARCH_SYSZ
util/capstone.c:186:25: note: each undeclared identifier is reported only once for each function it appears in
util/capstone.c:187:34: error: 'CS_MODE_RISCV64' undeclared (first use in this function); did you mean 'CS_MODE_MIPS64'?
187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC;
| ^~~~~~~~~~~~~~~
| CS_MODE_MIPS64
util/capstone.c:187:52: error: 'CS_MODE_RISCV32' undeclared (first use in this function); did you mean 'CS_MODE_MIPS32'?
187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC;
| ^~~~~~~~~~~~~~~
| CS_MODE_MIPS32
util/capstone.c:187:71: error: 'CS_MODE_RISCVC' undeclared (first use in this function); did you mean 'CS_MODE_MICRO'?
187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC;
| ^~~~~~~~~~~~~~
| CS_MODE_MICRO
make[3]: *** [/git/perf-7.1.0-rc5/tools/build/Makefile.build:158: util] Error 2
15 116.53 archlinux:base : Ok gcc (GCC) 15.2.1 20250813 , clang version 20.1.8 flex 2.6.4
16 130.36 centos:stream : Ok gcc (GCC) 8.5.0 20210514 (Red Hat 8.5.0-21) , clang version 17.0.6 (Red Hat 17.0.6-1.module_el8+767+9fa966b8) flex 2.6.1
17 123.85 clearlinux:latest : Ok gcc (Clear Linux OS for Intel Architecture) 15.1.1 20250602 releases/gcc-15.1.0-174-gc096341a08 , clang version 20.1.0 flex 2.6.4
18 12.15 debian:10 : FAIL gcc version 8.3.0 (Debian 8.3.0-6)
util/capstone.c: In function 'e_machine_to_capstone':
util/capstone.c:186:11: error: 'CS_ARCH_RISCV' undeclared (first use in this function); did you mean 'CS_ARCH_SYSZ'?
*arch = CS_ARCH_RISCV;
^~~~~~~~~~~~~
CS_ARCH_SYSZ
util/capstone.c:186:11: note: each undeclared identifier is reported only once for each function it appears in
util/capstone.c:187:20: error: 'CS_MODE_RISCV64' undeclared (first use in this function); did you mean 'CS_MODE_MIPS64'?
*mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC;
^~~~~~~~~~~~~~~
CS_MODE_MIPS64
util/capstone.c:187:38: error: 'CS_MODE_RISCV32' undeclared (first use in this function); did you mean 'CS_MODE_MIPS32'?
*mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC;
^~~~~~~~~~~~~~~
CS_MODE_MIPS32
util/capstone.c:187:57: error: 'CS_MODE_RISCVC' undeclared (first use in this function); did you mean 'CS_MODE_MICRO'?
*mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC;
^~~~~~~~~~~~~~
CS_MODE_MICRO
19 12.08 debian:11 : FAIL gcc version 10.2.1 20210110 (Debian 10.2.1-6)
util/capstone.c: In function 'e_machine_to_capstone':
util/capstone.c:186:11: error: 'CS_ARCH_RISCV' undeclared (first use in this function); did you mean 'CS_ARCH_SYSZ'?
186 | *arch = CS_ARCH_RISCV;
| ^~~~~~~~~~~~~
| CS_ARCH_SYSZ
util/capstone.c:186:11: note: each undeclared identifier is reported only once for each function it appears in
util/capstone.c:187:20: error: 'CS_MODE_RISCV64' undeclared (first use in this function); did you mean 'CS_MODE_MIPS64'?
187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC;
| ^~~~~~~~~~~~~~~
| CS_MODE_MIPS64
util/capstone.c:187:38: error: 'CS_MODE_RISCV32' undeclared (first use in this function); did you mean 'CS_MODE_MIPS32'?
187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC;
| ^~~~~~~~~~~~~~~
| CS_MODE_MIPS32
util/capstone.c:187:57: error: 'CS_MODE_RISCVC' undeclared (first use in this function); did you mean 'CS_MODE_MICRO'?
187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC;
| ^~~~~~~~~~~~~~
| CS_MODE_MICRO
20 12.30 debian:12 : FAIL gcc version 12.2.0 (Debian 12.2.0-14+deb12u1)
util/capstone.c: In function 'e_machine_to_capstone':
util/capstone.c:186:25: error: 'CS_ARCH_RISCV' undeclared (first use in this function); did you mean 'CS_ARCH_SYSZ'?
186 | *arch = CS_ARCH_RISCV;
| ^~~~~~~~~~~~~
| CS_ARCH_SYSZ
util/capstone.c:186:25: note: each undeclared identifier is reported only once for each function it appears in
util/capstone.c:187:34: error: 'CS_MODE_RISCV64' undeclared (first use in this function); did you mean 'CS_MODE_MIPS64'?
187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC;
| ^~~~~~~~~~~~~~~
| CS_MODE_MIPS64
util/capstone.c:187:52: error: 'CS_MODE_RISCV32' undeclared (first use in this function); did you mean 'CS_MODE_MIPS32'?
187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC;
| ^~~~~~~~~~~~~~~
| CS_MODE_MIPS32
util/capstone.c:187:71: error: 'CS_MODE_RISCVC' undeclared (first use in this function); did you mean 'CS_MODE_MICRO'?
187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC;
| ^~~~~~~~~~~~~~
| CS_MODE_MICRO
21 94.47 debian:13 : Ok gcc (Debian 14.2.0-19) 14.2.0 , Debian clang version 19.1.7 (3+b1) flex 2.6.4
22 104.26 debian:experimental : Ok gcc (Debian 15.2.0-17) 15.2.0 , Debian clang version 21.1.8 (7+b1) flex 2.6.4
23 26.18 debian:experimental-x-arm64 : Ok aarch64-linux-gnu-gcc (Debian 15.2.0-17) 15.2.0 flex 2.6.4
24 19.18 debian:experimental-x-mips : Ok mips-linux-gnu-gcc (Debian 14.2.0-13) 14.2.0 flex 2.6.4
25 19.94 debian:experimental-x-mips64 : Ok mips64-linux-gnuabi64-gcc (Debian 14.2.0-13) 14.2.0 flex 2.6.4
26 19.03 debian:experimental-x-mipsel : Ok mipsel-linux-gnu-gcc (Debian 14.2.0-13) 14.2.0 flex 2.6.4
27 14.16 fedora:35 : FAIL gcc version 11.3.1 20220421 (Red Hat 11.3.1-3) (GCC)
util/capstone.c: In function 'e_machine_to_capstone':
util/capstone.c:186:25: error: 'CS_ARCH_RISCV' undeclared (first use in this function); did you mean 'CS_ARCH_SYSZ'?
186 | *arch = CS_ARCH_RISCV;
| ^~~~~~~~~~~~~
| CS_ARCH_SYSZ
util/capstone.c:186:25: note: each undeclared identifier is reported only once for each function it appears in
util/capstone.c:187:34: error: 'CS_MODE_RISCV64' undeclared (first use in this function); did you mean 'CS_MODE_MIPS64'?
187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC;
| ^~~~~~~~~~~~~~~
| CS_MODE_MIPS64
util/capstone.c:187:52: error: 'CS_MODE_RISCV32' undeclared (first use in this function); did you mean 'CS_MODE_MIPS32'?
187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC;
| ^~~~~~~~~~~~~~~
| CS_MODE_MIPS32
util/capstone.c:187:71: error: 'CS_MODE_RISCVC' undeclared (first use in this function); did you mean 'CS_MODE_MICRO'?
187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC;
| ^~~~~~~~~~~~~~
| CS_MODE_MICRO
28 13.01 fedora:36 : FAIL gcc version 12.2.1 20221121 (Red Hat 12.2.1-4) (GCC)
util/capstone.c: In function 'e_machine_to_capstone':
util/capstone.c:186:25: error: 'CS_ARCH_RISCV' undeclared (first use in this function); did you mean 'CS_ARCH_SYSZ'?
186 | *arch = CS_ARCH_RISCV;
| ^~~~~~~~~~~~~
| CS_ARCH_SYSZ
util/capstone.c:186:25: note: each undeclared identifier is reported only once for each function it appears in
util/capstone.c:187:34: error: 'CS_MODE_RISCV64' undeclared (first use in this function); did you mean 'CS_MODE_MIPS64'?
187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC;
| ^~~~~~~~~~~~~~~
| CS_MODE_MIPS64
util/capstone.c:187:52: error: 'CS_MODE_RISCV32' undeclared (first use in this function); did you mean 'CS_MODE_MIPS32'?
187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC;
| ^~~~~~~~~~~~~~~
| CS_MODE_MIPS32
util/capstone.c:187:71: error: 'CS_MODE_RISCVC' undeclared (first use in this function); did you mean 'CS_MODE_MICRO'?
187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC;
| ^~~~~~~~~~~~~~
| CS_MODE_MICRO
29 11.56 fedora:37 : FAIL gcc version 12.3.1 20230508 (Red Hat 12.3.1-1) (GCC)
util/capstone.c: In function 'e_machine_to_capstone':
util/capstone.c:186:25: error: 'CS_ARCH_RISCV' undeclared (first use in this function); did you mean 'CS_ARCH_SYSZ'?
186 | *arch = CS_ARCH_RISCV;
| ^~~~~~~~~~~~~
| CS_ARCH_SYSZ
util/capstone.c:186:25: note: each undeclared identifier is reported only once for each function it appears in
util/capstone.c:187:34: error: 'CS_MODE_RISCV64' undeclared (first use in this function); did you mean 'CS_MODE_MIPS64'?
187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC;
| ^~~~~~~~~~~~~~~
| CS_MODE_MIPS64
util/capstone.c:187:52: error: 'CS_MODE_RISCV32' undeclared (first use in this function); did you mean 'CS_MODE_MIPS32'?
187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC;
| ^~~~~~~~~~~~~~~
| CS_MODE_MIPS32
util/capstone.c:187:71: error: 'CS_MODE_RISCVC' undeclared (first use in this function); did you mean 'CS_MODE_MICRO'?
187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC;
| ^~~~~~~~~~~~~~
| CS_MODE_MICRO
30 11.70 fedora:38 : FAIL gcc version 13.2.1 20231011 (Red Hat 13.2.1-4) (GCC)
util/capstone.c: In function 'e_machine_to_capstone':
util/capstone.c:186:25: error: 'CS_ARCH_RISCV' undeclared (first use in this function); did you mean 'CS_ARCH_SYSZ'?
186 | *arch = CS_ARCH_RISCV;
| ^~~~~~~~~~~~~
| CS_ARCH_SYSZ
util/capstone.c:186:25: note: each undeclared identifier is reported only once for each function it appears in
util/capstone.c:187:34: error: 'CS_MODE_RISCV64' undeclared (first use in this function); did you mean 'CS_MODE_MIPS64'?
187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC;
| ^~~~~~~~~~~~~~~
| CS_MODE_MIPS64
util/capstone.c:187:52: error: 'CS_MODE_RISCV32' undeclared (first use in this function); did you mean 'CS_MODE_MIPS32'?
187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC;
| ^~~~~~~~~~~~~~~
| CS_MODE_MIPS32
util/capstone.c:187:71: error: 'CS_MODE_RISCVC' undeclared (first use in this function); did you mean 'CS_MODE_MICRO'?
187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC;
| ^~~~~~~~~~~~~~
| CS_MODE_MICRO
31 12.18 fedora:39 : FAIL gcc version 13.3.1 20240913 (Red Hat 13.3.1-3) (GCC)
util/capstone.c: In function 'e_machine_to_capstone':
util/capstone.c:186:25: error: 'CS_ARCH_RISCV' undeclared (first use in this function); did you mean 'CS_ARCH_SYSZ'?
186 | *arch = CS_ARCH_RISCV;
| ^~~~~~~~~~~~~
| CS_ARCH_SYSZ
util/capstone.c:186:25: note: each undeclared identifier is reported only once for each function it appears in
util/capstone.c:187:34: error: 'CS_MODE_RISCV64' undeclared (first use in this function); did you mean 'CS_MODE_MIPS64'?
187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC;
| ^~~~~~~~~~~~~~~
| CS_MODE_MIPS64
util/capstone.c:187:52: error: 'CS_MODE_RISCV32' undeclared (first use in this function); did you mean 'CS_MODE_MIPS32'?
187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC;
| ^~~~~~~~~~~~~~~
| CS_MODE_MIPS32
util/capstone.c:187:71: error: 'CS_MODE_RISCVC' undeclared (first use in this function); did you mean 'CS_MODE_MICRO'?
187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC;
| ^~~~~~~~~~~~~~
| CS_MODE_MICRO
32 111.06 fedora:40 : Ok gcc (GCC) 14.2.1 20240912 (Red Hat 14.2.1-3) , clang version 18.1.8 (Fedora 18.1.8-2.fc40) flex 2.6.4
33 107.16 fedora:41 : Ok gcc (GCC) 14.3.1 20251022 (Red Hat 14.3.1-4) , clang version 19.1.7 (Fedora 19.1.7-5.fc41) flex 2.6.4
34 106.95 fedora:42 : Ok gcc (GCC) 15.2.1 20260123 (Red Hat 15.2.1-7) , clang version 20.1.8 (Fedora 20.1.8-4.fc42) flex 2.6.4
35 103.93 fedora:43 : Ok gcc (GCC) 15.2.1 20260123 (Red Hat 15.2.1-7) , clang version 21.1.8 (Fedora 21.1.8-4.fc43) flex 2.6.4
36 108.14 fedora:44 : Ok gcc (GCC) 16.1.1 20260515 (Red Hat 16.1.1-2) , clang version 22.1.6 (Fedora 22.1.6-1.fc44) flex 2.6.4
37 109.25 fedora:45 : Ok gcc (GCC) 16.1.1 20260515 (Red Hat 16.1.1-2) , clang version 22.1.6 (Fedora 22.1.6-1.fc45) flex 2.6.4
38 106.11 fedora:rawhide : Ok gcc (GCC) 16.1.1 20260515 (Red Hat 16.1.1-2) , clang version 22.1.6 (Fedora 22.1.6-1.fc45) flex 2.6.4
39 43.21 gentoo:stage3 : Ok gcc (Gentoo 13.3.1_p20240614 p17) 13.3.1 20240614 flex 2.6.4toolsbuilder@five:~$
Arnaldo Carvalho de Melo
maintainerRe: [PATCH v12 00/19] perf: Use e_machine and lazily compute symbols
Quoted 12 lines · Arnaldo Carvalho de Melo
Quoted 10 lines · Arnaldo Carvalho de Melo
Quoted 9 lines · Namhyung Kim
Quoted 8 lines · Ian Rogers
On Tue, Jun 2, 2026 at 8:25 AM Ian Rogers <[email protected]> wrote:
1 high issue. Concern over a perf data issue in pipe mode. Addressing this would require a fairly major overhail of perf data, so let's add fixing to the TODO list.Quoted 3 lines
perf symbol: Add setters for bitfields sharing a byte to avoid
concurrent update issues
perf symbol: Lazily compute idle
Quoted 8 lines
Quoted 5 lines
Quoted 3 lines
Quoted 1 line
No regressions x2.
Acked-by Namhyung Kim <[email protected]>Thanks, applied to perf-tools-next, for v7.2.
Now trying to fix this, all old distros, but if the fix is cheap enough, lets not drop support for them:
It is an enum, so too much work to cope with that, I'll disable capstone build in these systems.
- Arnaldo
Quoted 319 lines
toolsbuilder@five:~$ cat dm.log/summary Subject: tools build test for http://192.168.86.5/perf/perf-7.1.0-rc5.tar.xz1 127.96 almalinux:8 : Ok gcc (GCC) 8.5.0 20210514 (Red Hat 8.5.0-28) , clang version 21.1.8 ( 21.1.8-1.module_el8.10.0+4172+b6b13d75) flex 2.6.1 2 12.44 almalinux:9 : FAIL gcc version 11.5.0 20240719 (Red Hat 11.5.0-14) (GCC) util/capstone.c: In function 'e_machine_to_capstone': util/capstone.c:186:25: error: 'CS_ARCH_RISCV' undeclared (first use in this function); did you mean 'CS_ARCH_SYSZ'? 186 | *arch = CS_ARCH_RISCV; | ^~~~~~~~~~~~~ | CS_ARCH_SYSZ util/capstone.c:186:25: note: each undeclared identifier is reported only once for each function it appears in util/capstone.c:187:34: error: 'CS_MODE_RISCV64' undeclared (first use in this function); did you mean 'CS_MODE_MIPS64'? 187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC; | ^~~~~~~~~~~~~~~ | CS_MODE_MIPS64 util/capstone.c:187:52: error: 'CS_MODE_RISCV32' undeclared (first use in this function); did you mean 'CS_MODE_MIPS32'? 187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC; | ^~~~~~~~~~~~~~~ | CS_MODE_MIPS32 util/capstone.c:187:71: error: 'CS_MODE_RISCVC' undeclared (first use in this function); did you mean 'CS_MODE_MICRO'? 187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC; | ^~~~~~~~~~~~~~ | CS_MODE_MICRO 3 17.54 almalinux:9-i386 : FAIL gcc version 11.4.1 20231218 (Red Hat 11.4.1-3) (GCC) util/capstone.c: In function ‘e_machine_to_capstone’: util/capstone.c:186:25: error: ‘CS_ARCH_RISCV’ undeclared (first use in this function); did you mean ‘CS_ARCH_SYSZ’? 186 | *arch = CS_ARCH_RISCV; | ^~~~~~~~~~~~~ | CS_ARCH_SYSZ util/capstone.c:186:25: note: each undeclared identifier is reported only once for each function it appears in util/capstone.c:187:34: error: ‘CS_MODE_RISCV64’ undeclared (first use in this function); did you mean ‘CS_MODE_MIPS64’? 187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC; | ^~~~~~~~~~~~~~~ | CS_MODE_MIPS64 util/capstone.c:187:52: error: ‘CS_MODE_RISCV32’ undeclared (first use in this function); did you mean ‘CS_MODE_MIPS32’? 187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC; | ^~~~~~~~~~~~~~~ | CS_MODE_MIPS32 util/capstone.c:187:71: error: ‘CS_MODE_RISCVC’ undeclared (first use in this function); did you mean ‘CS_MODE_MICRO’? 187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC; | ^~~~~~~~~~~~~~ | CS_MODE_MICRO 4 101.24 almalinux:10 : Ok gcc (GCC) 14.3.1 20251022 (Red Hat 14.3.1-4) , clang version 21.1.8 (AlmaLinux OS Foundation 21.1.8-1.el10.alma.1) flex 2.6.4 5 21.66 alpine:3.16 : FAIL gcc version 11.2.1 20220219 (Alpine 11.2.1_git20220219) util/capstone.c: In function 'e_machine_to_capstone': util/capstone.c:186:25: error: 'CS_ARCH_RISCV' undeclared (first use in this function); did you mean 'CS_ARCH_SYSZ'? 186 | *arch = CS_ARCH_RISCV; | ^~~~~~~~~~~~~ | CS_ARCH_SYSZ util/capstone.c:186:25: note: each undeclared identifier is reported only once for each function it appears in util/capstone.c:187:34: error: 'CS_MODE_RISCV64' undeclared (first use in this function); did you mean 'CS_MODE_MIPS64'? 187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC; | ^~~~~~~~~~~~~~~ | CS_MODE_MIPS64 util/capstone.c:187:52: error: 'CS_MODE_RISCV32' undeclared (first use in this function); did you mean 'CS_MODE_MIPS32'? 187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC; | ^~~~~~~~~~~~~~~ | CS_MODE_MIPS32 util/capstone.c:187:71: error: 'CS_MODE_RISCVC' undeclared (first use in this function); did you mean 'CS_MODE_MICRO'? 187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC; | ^~~~~~~~~~~~~~ | CS_MODE_MICRO make[3]: *** [/git/perf-7.1.0-rc5/tools/build/Makefile.build:158: util] Error 2 6 14.57 alpine:3.17 : FAIL gcc version 12.2.1 20220924 (Alpine 12.2.1_git20220924-r4) util/capstone.c: In function 'e_machine_to_capstone': util/capstone.c:186:25: error: 'CS_ARCH_RISCV' undeclared (first use in this function); did you mean 'CS_ARCH_SYSZ'? 186 | *arch = CS_ARCH_RISCV; | ^~~~~~~~~~~~~ | CS_ARCH_SYSZ util/capstone.c:186:25: note: each undeclared identifier is reported only once for each function it appears in util/capstone.c:187:34: error: 'CS_MODE_RISCV64' undeclared (first use in this function); did you mean 'CS_MODE_MIPS64'? 187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC; | ^~~~~~~~~~~~~~~ | CS_MODE_MIPS64 util/capstone.c:187:52: error: 'CS_MODE_RISCV32' undeclared (first use in this function); did you mean 'CS_MODE_MIPS32'? 187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC; | ^~~~~~~~~~~~~~~ | CS_MODE_MIPS32 util/capstone.c:187:71: error: 'CS_MODE_RISCVC' undeclared (first use in this function); did you mean 'CS_MODE_MICRO'? 187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC; | ^~~~~~~~~~~~~~ | CS_MODE_MICRO make[3]: *** [/git/perf-7.1.0-rc5/tools/build/Makefile.build:158: util] Error 2 7 13.58 alpine:3.18 : FAIL gcc version 12.2.1 20220924 (Alpine 12.2.1_git20220924-r10) util/capstone.c: In function 'e_machine_to_capstone': util/capstone.c:186:25: error: 'CS_ARCH_RISCV' undeclared (first use in this function); did you mean 'CS_ARCH_SYSZ'? 186 | *arch = CS_ARCH_RISCV; | ^~~~~~~~~~~~~ | CS_ARCH_SYSZ util/capstone.c:186:25: note: each undeclared identifier is reported only once for each function it appears in util/capstone.c:187:34: error: 'CS_MODE_RISCV64' undeclared (first use in this function); did you mean 'CS_MODE_MIPS64'? 187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC; | ^~~~~~~~~~~~~~~ | CS_MODE_MIPS64 util/capstone.c:187:52: error: 'CS_MODE_RISCV32' undeclared (first use in this function); did you mean 'CS_MODE_MIPS32'? 187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC; | ^~~~~~~~~~~~~~~ | CS_MODE_MIPS32 util/capstone.c:187:71: error: 'CS_MODE_RISCVC' undeclared (first use in this function); did you mean 'CS_MODE_MICRO'? 187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC; | ^~~~~~~~~~~~~~ | CS_MODE_MICRO 8 127.15 alpine:3.19 : Ok gcc (Alpine 13.2.1_git20231014) 13.2.1 20231014 , Alpine clang version 17.0.5 flex 2.6.4 9 124.98 alpine:3.20 : Ok gcc (Alpine 13.2.1_git20240309) 13.2.1 20240309 , Alpine clang version 17.0.6 flex 2.6.4 10 134.36 alpine:3.22 : Ok gcc (Alpine 14.2.0) 14.2.0 , Alpine clang version 20.1.8 flex 2.6.4 11 128.47 alpine:3.23 : Ok gcc (Alpine 15.2.0) 15.2.0 , Alpine clang version 21.1.2 flex 2.6.4 12 134.59 alpine:edge : Ok gcc (Alpine 14.2.0) 14.2.0 , Alpine clang version 19.1.4 flex 2.6.4 13 13.41 amazonlinux:2023 : FAIL gcc version 11.5.0 20240719 (Red Hat 11.5.0-5) (GCC) util/capstone.c: In function 'e_machine_to_capstone': util/capstone.c:186:25: error: 'CS_ARCH_RISCV' undeclared (first use in this function); did you mean 'CS_ARCH_SYSZ'? 186 | *arch = CS_ARCH_RISCV; | ^~~~~~~~~~~~~ | CS_ARCH_SYSZ util/capstone.c:186:25: note: each undeclared identifier is reported only once for each function it appears in util/capstone.c:187:34: error: 'CS_MODE_RISCV64' undeclared (first use in this function); did you mean 'CS_MODE_MIPS64'? 187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC; | ^~~~~~~~~~~~~~~ | CS_MODE_MIPS64 util/capstone.c:187:52: error: 'CS_MODE_RISCV32' undeclared (first use in this function); did you mean 'CS_MODE_MIPS32'? 187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC; | ^~~~~~~~~~~~~~~ | CS_MODE_MIPS32 util/capstone.c:187:71: error: 'CS_MODE_RISCVC' undeclared (first use in this function); did you mean 'CS_MODE_MICRO'? 187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC; | ^~~~~~~~~~~~~~ | CS_MODE_MICRO make[3]: *** [/git/perf-7.1.0-rc5/tools/build/Makefile.build:158: util] Error 2 14 14.14 amazonlinux:devel : FAIL gcc version 11.3.1 20221121 (Red Hat 11.3.1-4) (GCC) util/capstone.c: In function 'e_machine_to_capstone': util/capstone.c:186:25: error: 'CS_ARCH_RISCV' undeclared (first use in this function); did you mean 'CS_ARCH_SYSZ'? 186 | *arch = CS_ARCH_RISCV; | ^~~~~~~~~~~~~ | CS_ARCH_SYSZ util/capstone.c:186:25: note: each undeclared identifier is reported only once for each function it appears in util/capstone.c:187:34: error: 'CS_MODE_RISCV64' undeclared (first use in this function); did you mean 'CS_MODE_MIPS64'? 187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC; | ^~~~~~~~~~~~~~~ | CS_MODE_MIPS64 util/capstone.c:187:52: error: 'CS_MODE_RISCV32' undeclared (first use in this function); did you mean 'CS_MODE_MIPS32'? 187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC; | ^~~~~~~~~~~~~~~ | CS_MODE_MIPS32 util/capstone.c:187:71: error: 'CS_MODE_RISCVC' undeclared (first use in this function); did you mean 'CS_MODE_MICRO'? 187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC; | ^~~~~~~~~~~~~~ | CS_MODE_MICRO make[3]: *** [/git/perf-7.1.0-rc5/tools/build/Makefile.build:158: util] Error 2 15 116.53 archlinux:base : Ok gcc (GCC) 15.2.1 20250813 , clang version 20.1.8 flex 2.6.4 16 130.36 centos:stream : Ok gcc (GCC) 8.5.0 20210514 (Red Hat 8.5.0-21) , clang version 17.0.6 (Red Hat 17.0.6-1.module_el8+767+9fa966b8) flex 2.6.1 17 123.85 clearlinux:latest : Ok gcc (Clear Linux OS for Intel Architecture) 15.1.1 20250602 releases/gcc-15.1.0-174-gc096341a08 , clang version 20.1.0 flex 2.6.4 18 12.15 debian:10 : FAIL gcc version 8.3.0 (Debian 8.3.0-6) util/capstone.c: In function 'e_machine_to_capstone': util/capstone.c:186:11: error: 'CS_ARCH_RISCV' undeclared (first use in this function); did you mean 'CS_ARCH_SYSZ'? *arch = CS_ARCH_RISCV; ^~~~~~~~~~~~~ CS_ARCH_SYSZ util/capstone.c:186:11: note: each undeclared identifier is reported only once for each function it appears in util/capstone.c:187:20: error: 'CS_MODE_RISCV64' undeclared (first use in this function); did you mean 'CS_MODE_MIPS64'? *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC; ^~~~~~~~~~~~~~~ CS_MODE_MIPS64 util/capstone.c:187:38: error: 'CS_MODE_RISCV32' undeclared (first use in this function); did you mean 'CS_MODE_MIPS32'? *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC; ^~~~~~~~~~~~~~~ CS_MODE_MIPS32 util/capstone.c:187:57: error: 'CS_MODE_RISCVC' undeclared (first use in this function); did you mean 'CS_MODE_MICRO'? *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC; ^~~~~~~~~~~~~~ CS_MODE_MICRO 19 12.08 debian:11 : FAIL gcc version 10.2.1 20210110 (Debian 10.2.1-6) util/capstone.c: In function 'e_machine_to_capstone': util/capstone.c:186:11: error: 'CS_ARCH_RISCV' undeclared (first use in this function); did you mean 'CS_ARCH_SYSZ'? 186 | *arch = CS_ARCH_RISCV; | ^~~~~~~~~~~~~ | CS_ARCH_SYSZ util/capstone.c:186:11: note: each undeclared identifier is reported only once for each function it appears in util/capstone.c:187:20: error: 'CS_MODE_RISCV64' undeclared (first use in this function); did you mean 'CS_MODE_MIPS64'? 187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC; | ^~~~~~~~~~~~~~~ | CS_MODE_MIPS64 util/capstone.c:187:38: error: 'CS_MODE_RISCV32' undeclared (first use in this function); did you mean 'CS_MODE_MIPS32'? 187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC; | ^~~~~~~~~~~~~~~ | CS_MODE_MIPS32 util/capstone.c:187:57: error: 'CS_MODE_RISCVC' undeclared (first use in this function); did you mean 'CS_MODE_MICRO'? 187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC; | ^~~~~~~~~~~~~~ | CS_MODE_MICRO 20 12.30 debian:12 : FAIL gcc version 12.2.0 (Debian 12.2.0-14+deb12u1) util/capstone.c: In function 'e_machine_to_capstone': util/capstone.c:186:25: error: 'CS_ARCH_RISCV' undeclared (first use in this function); did you mean 'CS_ARCH_SYSZ'? 186 | *arch = CS_ARCH_RISCV; | ^~~~~~~~~~~~~ | CS_ARCH_SYSZ util/capstone.c:186:25: note: each undeclared identifier is reported only once for each function it appears in util/capstone.c:187:34: error: 'CS_MODE_RISCV64' undeclared (first use in this function); did you mean 'CS_MODE_MIPS64'? 187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC; | ^~~~~~~~~~~~~~~ | CS_MODE_MIPS64 util/capstone.c:187:52: error: 'CS_MODE_RISCV32' undeclared (first use in this function); did you mean 'CS_MODE_MIPS32'? 187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC; | ^~~~~~~~~~~~~~~ | CS_MODE_MIPS32 util/capstone.c:187:71: error: 'CS_MODE_RISCVC' undeclared (first use in this function); did you mean 'CS_MODE_MICRO'? 187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC; | ^~~~~~~~~~~~~~ | CS_MODE_MICRO 21 94.47 debian:13 : Ok gcc (Debian 14.2.0-19) 14.2.0 , Debian clang version 19.1.7 (3+b1) flex 2.6.4 22 104.26 debian:experimental : Ok gcc (Debian 15.2.0-17) 15.2.0 , Debian clang version 21.1.8 (7+b1) flex 2.6.4 23 26.18 debian:experimental-x-arm64 : Ok aarch64-linux-gnu-gcc (Debian 15.2.0-17) 15.2.0 flex 2.6.4 24 19.18 debian:experimental-x-mips : Ok mips-linux-gnu-gcc (Debian 14.2.0-13) 14.2.0 flex 2.6.4 25 19.94 debian:experimental-x-mips64 : Ok mips64-linux-gnuabi64-gcc (Debian 14.2.0-13) 14.2.0 flex 2.6.4 26 19.03 debian:experimental-x-mipsel : Ok mipsel-linux-gnu-gcc (Debian 14.2.0-13) 14.2.0 flex 2.6.4 27 14.16 fedora:35 : FAIL gcc version 11.3.1 20220421 (Red Hat 11.3.1-3) (GCC) util/capstone.c: In function 'e_machine_to_capstone': util/capstone.c:186:25: error: 'CS_ARCH_RISCV' undeclared (first use in this function); did you mean 'CS_ARCH_SYSZ'? 186 | *arch = CS_ARCH_RISCV; | ^~~~~~~~~~~~~ | CS_ARCH_SYSZ util/capstone.c:186:25: note: each undeclared identifier is reported only once for each function it appears in util/capstone.c:187:34: error: 'CS_MODE_RISCV64' undeclared (first use in this function); did you mean 'CS_MODE_MIPS64'? 187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC; | ^~~~~~~~~~~~~~~ | CS_MODE_MIPS64 util/capstone.c:187:52: error: 'CS_MODE_RISCV32' undeclared (first use in this function); did you mean 'CS_MODE_MIPS32'? 187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC; | ^~~~~~~~~~~~~~~ | CS_MODE_MIPS32 util/capstone.c:187:71: error: 'CS_MODE_RISCVC' undeclared (first use in this function); did you mean 'CS_MODE_MICRO'? 187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC; | ^~~~~~~~~~~~~~ | CS_MODE_MICRO 28 13.01 fedora:36 : FAIL gcc version 12.2.1 20221121 (Red Hat 12.2.1-4) (GCC) util/capstone.c: In function 'e_machine_to_capstone': util/capstone.c:186:25: error: 'CS_ARCH_RISCV' undeclared (first use in this function); did you mean 'CS_ARCH_SYSZ'? 186 | *arch = CS_ARCH_RISCV; | ^~~~~~~~~~~~~ | CS_ARCH_SYSZ util/capstone.c:186:25: note: each undeclared identifier is reported only once for each function it appears in util/capstone.c:187:34: error: 'CS_MODE_RISCV64' undeclared (first use in this function); did you mean 'CS_MODE_MIPS64'? 187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC; | ^~~~~~~~~~~~~~~ | CS_MODE_MIPS64 util/capstone.c:187:52: error: 'CS_MODE_RISCV32' undeclared (first use in this function); did you mean 'CS_MODE_MIPS32'? 187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC; | ^~~~~~~~~~~~~~~ | CS_MODE_MIPS32 util/capstone.c:187:71: error: 'CS_MODE_RISCVC' undeclared (first use in this function); did you mean 'CS_MODE_MICRO'? 187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC; | ^~~~~~~~~~~~~~ | CS_MODE_MICRO 29 11.56 fedora:37 : FAIL gcc version 12.3.1 20230508 (Red Hat 12.3.1-1) (GCC) util/capstone.c: In function 'e_machine_to_capstone': util/capstone.c:186:25: error: 'CS_ARCH_RISCV' undeclared (first use in this function); did you mean 'CS_ARCH_SYSZ'? 186 | *arch = CS_ARCH_RISCV; | ^~~~~~~~~~~~~ | CS_ARCH_SYSZ util/capstone.c:186:25: note: each undeclared identifier is reported only once for each function it appears in util/capstone.c:187:34: error: 'CS_MODE_RISCV64' undeclared (first use in this function); did you mean 'CS_MODE_MIPS64'? 187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC; | ^~~~~~~~~~~~~~~ | CS_MODE_MIPS64 util/capstone.c:187:52: error: 'CS_MODE_RISCV32' undeclared (first use in this function); did you mean 'CS_MODE_MIPS32'? 187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC; | ^~~~~~~~~~~~~~~ | CS_MODE_MIPS32 util/capstone.c:187:71: error: 'CS_MODE_RISCVC' undeclared (first use in this function); did you mean 'CS_MODE_MICRO'? 187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC; | ^~~~~~~~~~~~~~ | CS_MODE_MICRO 30 11.70 fedora:38 : FAIL gcc version 13.2.1 20231011 (Red Hat 13.2.1-4) (GCC) util/capstone.c: In function 'e_machine_to_capstone': util/capstone.c:186:25: error: 'CS_ARCH_RISCV' undeclared (first use in this function); did you mean 'CS_ARCH_SYSZ'? 186 | *arch = CS_ARCH_RISCV; | ^~~~~~~~~~~~~ | CS_ARCH_SYSZ util/capstone.c:186:25: note: each undeclared identifier is reported only once for each function it appears in util/capstone.c:187:34: error: 'CS_MODE_RISCV64' undeclared (first use in this function); did you mean 'CS_MODE_MIPS64'? 187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC; | ^~~~~~~~~~~~~~~ | CS_MODE_MIPS64 util/capstone.c:187:52: error: 'CS_MODE_RISCV32' undeclared (first use in this function); did you mean 'CS_MODE_MIPS32'? 187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC; | ^~~~~~~~~~~~~~~ | CS_MODE_MIPS32 util/capstone.c:187:71: error: 'CS_MODE_RISCVC' undeclared (first use in this function); did you mean 'CS_MODE_MICRO'? 187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC; | ^~~~~~~~~~~~~~ | CS_MODE_MICRO 31 12.18 fedora:39 : FAIL gcc version 13.3.1 20240913 (Red Hat 13.3.1-3) (GCC) util/capstone.c: In function 'e_machine_to_capstone': util/capstone.c:186:25: error: 'CS_ARCH_RISCV' undeclared (first use in this function); did you mean 'CS_ARCH_SYSZ'? 186 | *arch = CS_ARCH_RISCV; | ^~~~~~~~~~~~~ | CS_ARCH_SYSZ util/capstone.c:186:25: note: each undeclared identifier is reported only once for each function it appears in util/capstone.c:187:34: error: 'CS_MODE_RISCV64' undeclared (first use in this function); did you mean 'CS_MODE_MIPS64'? 187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC; | ^~~~~~~~~~~~~~~ | CS_MODE_MIPS64 util/capstone.c:187:52: error: 'CS_MODE_RISCV32' undeclared (first use in this function); did you mean 'CS_MODE_MIPS32'? 187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC; | ^~~~~~~~~~~~~~~ | CS_MODE_MIPS32 util/capstone.c:187:71: error: 'CS_MODE_RISCVC' undeclared (first use in this function); did you mean 'CS_MODE_MICRO'? 187 | *mode |= (is64 ? CS_MODE_RISCV64 : CS_MODE_RISCV32) | CS_MODE_RISCVC; | ^~~~~~~~~~~~~~ | CS_MODE_MICRO 32 111.06 fedora:40 : Ok gcc (GCC) 14.2.1 20240912 (Red Hat 14.2.1-3) , clang version 18.1.8 (Fedora 18.1.8-2.fc40) flex 2.6.4 33 107.16 fedora:41 : Ok gcc (GCC) 14.3.1 20251022 (Red Hat 14.3.1-4) , clang version 19.1.7 (Fedora 19.1.7-5.fc41) flex 2.6.4 34 106.95 fedora:42 : Ok gcc (GCC) 15.2.1 20260123 (Red Hat 15.2.1-7) , clang version 20.1.8 (Fedora 20.1.8-4.fc42) flex 2.6.4 35 103.93 fedora:43 : Ok gcc (GCC) 15.2.1 20260123 (Red Hat 15.2.1-7) , clang version 21.1.8 (Fedora 21.1.8-4.fc43) flex 2.6.4 36 108.14 fedora:44 : Ok gcc (GCC) 16.1.1 20260515 (Red Hat 16.1.1-2) , clang version 22.1.6 (Fedora 22.1.6-1.fc44) flex 2.6.4 37 109.25 fedora:45 : Ok gcc (GCC) 16.1.1 20260515 (Red Hat 16.1.1-2) , clang version 22.1.6 (Fedora 22.1.6-1.fc45) flex 2.6.4 38 106.11 fedora:rawhide : Ok gcc (GCC) 16.1.1 20260515 (Red Hat 16.1.1-2) , clang version 22.1.6 (Fedora 22.1.6-1.fc45) flex 2.6.4 39 43.21 gentoo:stage3 : Ok gcc (Gentoo 13.3.1_p20240614 p17) 13.3.1 20240614 flex 2.6.4toolsbuilder@five:~$
Ian Rogers
reviewerPATCH v6 2/3 perf env: Add helper to lazily compute the os_release
In reply to Ian RogersIn live mode the os_release isn't being initialized, make a lazy initialization helper that assumes when the os_release isn't initialized this is live mode.
--- tools/perf/util/data-convert-bt.c | 2 +- tools/perf/util/env.c | 21 +++++++++++++++++++++ tools/perf/util/env.h | 1 + tools/perf/util/header.c | 16 +++++++++++----- tools/perf/util/symbol.c | 4 ++-- 5 files changed, 36 insertions(+), 8 deletions(-)
tools/perf/util/data-convert-bt.c +1 -1
@@ -1414,7 +1414,7 @@ do { \ADD ("host" , env->hostname);ADD ("sysname" ,"Linux" ); -ADD ("release" , env->os_release); +ADD ("release" ,perf_env__os_release (env));ADD ("version" , env->version);ADD ("machine" , env->arch);ADD ("domain" ,"kernel" );
tools/perf/util/env.c +21 -0
@@ -330,6 +330,27 @@ int perf_env__kernel_is_64_bit(struct perf_env *env)return env->kernel_is_64_bit; } +const char *perf_env__os_release (struct perf_env *env) +{ +struct utsname uts; +int ret; + +if (!env) +return perf_version_string; + +if (env->os_release) +return env->os_release; + +/* +* The os_release is being accessed but wasn't initialized from a data +* file, assume this is 'live' mode and use the release from uname. If +* uname fails then use the current perf tool version. +*/ + ret =uname (&uts); + env->os_release =strdup (ret <0 ? perf_version_string : uts.release); +return env->os_release; +} +int perf_env__set_cmdline (struct perf_env *env,int argc,const char *argv[]) {int i;
tools/perf/util/env.h +1 -0
@@ -175,6 +175,7 @@ void free_cpu_domain_info(struct cpu_domain_map **cd_map, u32 schedstat_version,void perf_env__exit (struct perf_env *env);int perf_env__kernel_is_64_bit (struct perf_env *env); +const char *perf_env__os_release (struct perf_env *env);int perf_env__set_cmdline (struct perf_env *env,int argc,const char *argv[]);
tools/perf/util/header.c +11 -5
@@ -361,13 +361,19 @@ static int write_osrelease(struct feat_fd *ff, struct evlist *evlist __maybe_unused) {struct utsname uts; -int ret; +const char *release =NULL ; - ret =uname (&uts); -if (ret <0 ) -return -1 ; +if (evlist->session) + release =perf_env__os_release (perf_session__env (evlist->session)); -return do_write_string (ff, uts.release); +if (!release) { +int ret =uname (&uts); + +if (ret <0 ) +return -1 ; + release = uts.release; + } +return do_write_string (ff, release); }static int write_arch (struct feat_fd *ff,struct evlist *evlist)
tools/perf/util/symbol.c +2 -2
@@ -2209,7 +2209,7 @@ static int vmlinux_path__init(struct perf_env *env) {struct utsname uts;char bf[PATH_MAX ]; -char *kernel_version; +const char *kernel_version;unsigned int i; vmlinux_path = malloc(sizeof(char *) * (ARRAY_SIZE(vmlinux_paths) +
@@ -2226,7 +2226,7 @@ static int vmlinux_path__init(struct perf_env *env)return 0 ;if (env) { - kernel_version = env->os_release; + kernel_version =perf_env__os_release (env); }else {if (uname (&uts) <0 ) goto out_fail;
Signature · 1 line
2.53.0.1213.gd9a14994de-goog
[email protected]
AI reviewRe: [PATCH v6 2/3] perf env: Add helper to lazily compute the os_release
Sashiko AI review found 2 potential issue(s): - [Medium] Offline traces missing the OS_RELEASE header are polluted with the host's kernel version. - [Medium] Unhandled `strdup()` memory allocation…
Sashiko AI review found 2 potential issue(s):
- [Medium] Offline traces missing the OS_RELEASE header are polluted with the host's kernel version.
- [Medium] Unhandled strdup() memory allocation failure leads to NULL pointer dereference in snprintf(). --
commit 291bf2cc1c91c985c162c953f24ca34e304792c1
Author: Ian Rogers <[email protected]>
perf env: Add helper to lazily compute the os_release
This commit adds a lazy initialization helper for the os_release string in the perf environment, falling back to uname if it is not initialized.
Quoted 3 lines
tools/perf/util/env.c +0
-0
[ ... ]
Quoted 14 lines
tools/perf/util/env.c +10
-0@@ -330,6 +330,27 @@ int perf_env__kernel_is_64_bit(struct perf_env *env)return env->kernel_is_64_bit; } +const char *perf_env__os_release (struct perf_env *env) +{ +struct utsname uts; +int ret; + +if (!env) +return perf_version_string; + +if (env->os_release) +return env->os_release;
tools/perf/util/env.c int perf_env__kernel_is_64_bit(struct perf_env *env) · line 352
Quoted 10 lines
tools/perf/util/env.c +10
-0+ +/* +* The os_release is being accessed but wasn't initialized from a data +* file, assume this is 'live' mode and use the release from uname. If +* uname fails then use the current perf tool version. +*/ + ret =uname (&uts); + env->os_release =strdup (ret <0 ? perf_version_string : uts.release); +return env->os_release; +}
If we are processing an offline perf.data file with a tool like perf report or perf data convert, and the file is missing the HEADER_OSRELEASE feature, env->os_release will legitimately be NULL.
Does this unconditional fallback to uname risk polluting the offline trace's metadata with the local analysis host's kernel version?
This could potentially cause tools to incorrectly search for the target vmlinux using the host's kernel version, or embed the host's release into exported traces as the target's release.
Quoted 3 lines
tools/perf/util/symbol.c +0
-0
[ ... ]
tools/perf/util/symbol.c static int vmlinux_path__init(struct perf_env *env) · line 2229
Quoted 6 lines
tools/perf/util/symbol.c +1
-1@@ -2226,7 +2226,7 @@ static int vmlinux_path__init(struct perf_env *env)return 0 ;if (env) { - kernel_version = env->os_release; + kernel_version =perf_env__os_release (env);
If the strdup call in perf_env__os_release fails, it will return NULL.
Since kernel_version is assigned the result directly, could this result in passing a NULL pointer to snprintf slightly further down in this function:
snprintf(bf, sizeof(bf), vmlinux_paths_upd[i], kernel_version);
Passing NULL to a %s format specifier can lead to undefined behavior and potential segmentation faults on certain C libraries like musl.
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2
Ian Rogers
reviewerPATCH v6 3/3 perf symbol: Lazily compute idle and use the perf_env
In reply to Ian RogersMove the idle boolean to a helper symbol__is_idle function. In the function lazily compute whether a symbol is an idle function taking into consideration the kernel version and architecture of the machine. As symbols__insert no longer needs to know if a symbol is for the kernel, remove the argument.
This change is inspired by mailing list discussion, particularly from Thomas Richter <[email protected]> and Heiko Carstens <[email protected]>:
https://lore.kernel.org/lkml/[email protected]/
The change switches x86 matches to use strstarts which means intel_idle_irq is matched as part of strstarts(name, "intel_idle"), a change suggested by Honglei Wang <[email protected]> in:
https://lore.kernel.org/lkml/[email protected]/
--- tools/perf/builtin-top.c | 6 +- tools/perf/util/symbol-elf.c | 2 +- tools/perf/util/symbol.c | 103 ++++++++++++++++++++++------------- tools/perf/util/symbol.h | 15 +++-- 4 files changed, 82 insertions(+), 44 deletions(-)
tools/perf/builtin-top.c +5 -1
@@ -751,6 +751,7 @@ static void perf_event__process_sample(const struct perf_tool *tool, { struct perf_top *top = container_of(tool, struct perf_top, tool);struct addr_location al; +struct dso *dso =NULL ;if (!machine && perf_guest) {static struct intlist *seen;
@@ -830,7 +831,10 @@ static void perf_event__process_sample(const struct perf_tool *tool, } } -if (al.sym ==NULL || !al.sym->idle) { +if (al.map) + dso =map__dso (al.map); + +if (al.sym ==NULL || !symbol__is_idle (al.sym, dso, machine->env)) {struct hists *hists =evsel__hists (evsel);struct hist_entry_iter iter = { .evsel = evsel,
tools/perf/util/symbol-elf.c +1 -1
@@ -1727,7 +1727,7 @@ dso__load_sym_internal(struct dso *dso, struct map *map, struct symsrc *syms_ss,arch__sym_update (f, &sym); -__symbols__insert (dso__symbols (curr_dso), f,dso__kernel (dso)); +__symbols__insert (dso__symbols (curr_dso), f); nr++; }dso__put (curr_dso);
tools/perf/util/symbol.c +65 -38
171 lines not on this page · raw message
tools/perf/util/symbol.h +11 -4
@@ -26,6 +26,7 @@ struct dso;struct map ;struct maps ;struct option ; +struct perf_env ;struct build_id ;/*
@@ -43,6 +44,12 @@ Elf_Scn *elf_section_by_name(Elf *elf, GElf_Ehdr *ep, GElf_Shdr *shp, const char *name, size_t *idx);#endif +enum symbol_idle_kind { +SYMBOL_IDLE__UNKNOWN =0 , +SYMBOL_IDLE__NOT_IDLE =1 , +SYMBOL_IDLE__IDLE =2 , +}; +/** * A symtab entry. When allocated this may be preceded by an annotation (see * symbol__annotation) and/or a browser_index (see symbol__browser_index).
@@ -58,8 +65,8 @@ struct symbol { u8 type:4;/** ELF binding type as defined for st_info. E.g. STB_WEAK or STB_GLOBAL. */ u8 binding:4; -/** Set true for kernel symbols of idle routines. */ - u8 idle:1; +/** Cache for symbol__is_idle holding enum symbol_idle_kind values. */ + u8 idle:2;/** Resolvable but tools ignore it (e.g. idle routines). */ u8 ignore:1;/** Symbol for an inlined function. */
@@ -194,8 +201,7 @@ int dso__synthesize_plt_symbols(struct dso *dso, struct symsrc *ss);char *dso__demangle_sym (struct dso *dso,int kmodule,const char *elf_name); -void __symbols__insert (struct rb_root_cached *symbols,struct symbol *sym, -bool kernel); +void __symbols__insert (struct rb_root_cached *symbols,struct symbol *sym);void symbols__insert (struct rb_root_cached *symbols,struct symbol *sym);void symbols__fixup_duplicate (struct rb_root_cached *symbols);void symbols__fixup_end (struct rb_root_cached *symbols,bool is_kallsyms);
@@ -278,5 +284,6 @@ enum { };int symbol__validate_sym_arguments (void ); +bool symbol__is_idle (struct symbol *sym,const struct dso *dso,struct perf_env *env);#endif /* __PERF_SYMBOL */
Signature · 1 line
2.53.0.1213.gd9a14994de-goog
[email protected]
AI reviewRe: [PATCH v6 3/3] perf symbol: Lazily compute idle and use the perf_env
Sashiko AI review found 1 potential issue(s): - [High] Data race and undefined behavior due to unsynchronized bitfield updates in `struct symbol`. --
Sashiko AI review found 1 potential issue(s):
- [High] Data race and undefined behavior due to unsynchronized bitfield updates in struct symbol. --
commit 2ee008011b6949869303359cb5ce16b0c47431af
Author: Ian Rogers <[email protected]>
Subject: perf symbol: Lazily compute idle and use the perf_env
This commit defers computing whether a symbol is an idle function to a lazy evaluation using symbol__is_idle. It modifies struct symbol to cache this lazily computed value using an idle:2 bitfield, checking architectural and kernel versions using the perf_env.
Quoted 4 lines
tools/perf/util/symbol.h +0
-0
[ ... ]
tools/perf/util/symbol.h struct symbol { · line 72
Quoted 11 lines
tools/perf/util/symbol.h +2
-2@@ -58,8 +65,8 @@ struct symbol { u8 type:4;/** ELF binding type as defined for st_info. E.g. STB_WEAK or STB_GLOBAL. */ u8 binding:4; -/** Set true for kernel symbols of idle routines. */ - u8 idle:1; +/** Cache for symbol__is_idle holding enum symbol_idle_kind values. */ + u8 idle:2;/** Resolvable but tools ignore it (e.g. idle routines). */ u8 ignore:1;/** Symbol for an inlined function. */
Could this lazy update of the idle bitfield cause a data race?
Because idle is a bitfield sharing a byte with ignore, inlined, annotate2, and ifunc_alias, writing to it performs a non-atomic read-modify-write on the entire byte.
Quoted 4 lines
tools/perf/util/symbol.c +0
-0
[ ... ]
Quoted 2 lines
+bool
symbol__is_idle(struct symbol *sym, const struct dso *dso, struct perf_env *env)
{
[ ... ]
tools/perf/util/symbol.c int modules__parse(const char *filename, void *arg, · line 759
Quoted 5 lines
tools/perf/util/symbol.c +5
-0+if (bsearch (name, idle_symbols,ARRAY_SIZE (idle_symbols), +sizeof (idle_symbols[0 ]), sym_name_cmp)) { + sym->idle =SYMBOL_IDLE__IDLE ; +return true; + }
In perf top, sample processing runs continuously in a background thread, calling symbol__is_idle() and writing to sym->idle:
Thread 1 (Sample processing):
sym->idle = SYMBOL_IDLE__IDLE;
Concurrently, the TUI thread processes user interactions and can set flags like annotate2:
Thread 2 (TUI / User Interaction):
sym->annotate2 = 1;
If these threads access the same symbol simultaneously, could one thread's write overwrite the other's modifications, silently corrupting the symbol state and causing features like UI annotation to break?
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=3
Ian Rogers
reviewerPATCH v2 1/1 perf tests task-analyzer: Write test files to tmpdir
In reply to Ian RogersWriting to the test output files in the current working directory can fail in various contexts such as continual test. Other tests write to a mktemp-ed file, make the "perf script task-analyszer tests" follow this convention too. Currently this isn't possible for the perf.data file due to a lack of perf script support, add a variable for when this support is available.
--- tools/perf/tests/shell/test_task_analyzer.sh | 38 +++++++++++--------- 1 file changed, 21 insertions(+), 17 deletions(-)
tools/perf/tests/shell/test_task_analyzer.sh +21 -17
@@ -3,6 +3,11 @@ # SPDX-License-Identifier: GPL-2.0 tmpdir=$(mktemp -d /tmp/perf-script-task-analyzer-XXXXX) +# TODO: perf script report only supports input from the CWD perf.data file, make +# it support input from any file. +perfdata="perf.data" +csv="$tmpdir/csv" +csvsummary="$tmpdir/csvsummary" err=0 # set PERF_EXEC_PATH to find scripts in the source directory
@@ -15,11 +20,10 @@ fi export ASAN_OPTIONS=detect_leaks=0 cleanup() { - rm -f perf.data - rm -f perf.data.old - rm -f csv - rm -f csvsummary + rm -f "${perfdata}" + rm -f "${perfdata}".old rm -rf "$tmpdir" + trap - exit term int }
@@ -61,7 +65,7 @@ skip_no_probe_record_support() { prepare_perf_data() { # 1s should be sufficient to catch at least some switches - perf record -e sched:sched_switch -a -- sleep 1 > /dev/null 2>&1 + perf record -e sched:sched_switch -a -o "${perfdata}" -- sleep 1 > /dev/null 2>&1 # check if perf data file got created in above step. if [ ! -e "perf.data" ]; then printf "FAIL: perf record failed to create \"perf.data\" \n"
@@ -130,28 +134,28 @@ test_extended_times_summary_ns() { } test_csv() { - perf script report task-analyzer --csv csv > /dev/null - check_exec_0 "perf script report task-analyzer --csv csv" - find_str_or_fail "Comm;" csv "${FUNCNAME[0]}" + perf script report task-analyzer --csv "${csv}" > /dev/null + check_exec_0 "perf script report task-analyzer --csv ${csv}" + find_str_or_fail "Comm;" "${csv}" "${FUNCNAME[0]}" } test_csv_extended_times() { - perf script report task-analyzer --csv csv --extended-times > /dev/null - check_exec_0 "perf script report task-analyzer --csv csv --extended-times" - find_str_or_fail "Out-Out;" csv "${FUNCNAME[0]}" + perf script report task-analyzer --csv "${csv}" --extended-times > /dev/null + check_exec_0 "perf script report task-analyzer --csv ${csv} --extended-times" + find_str_or_fail "Out-Out;" "${csv}" "${FUNCNAME[0]}" } test_csvsummary() { - perf script report task-analyzer --csv-summary csvsummary > /dev/null - check_exec_0 "perf script report task-analyzer --csv-summary csvsummary" - find_str_or_fail "Comm;" csvsummary "${FUNCNAME[0]}" + perf script report task-analyzer --csv-summary "${csvsummary}" > /dev/null + check_exec_0 "perf script report task-analyzer --csv-summary ${csvsummary}" + find_str_or_fail "Comm;" "${csvsummary}" "${FUNCNAME[0]}" } test_csvsummary_extended() { - perf script report task-analyzer --csv-summary csvsummary --summary-extended \ + perf script report task-analyzer --csv-summary "${csvsummary}" --summary-extended \ >/dev/null - check_exec_0 "perf script report task-analyzer --csv-summary csvsummary --summary-extended" - find_str_or_fail "Out-Out;" csvsummary "${FUNCNAME[0]}" + check_exec_0 "perf script report task-analyzer --csv-summary ${csvsummary} --summary-extended" + find_str_or_fail "Out-Out;" "${csvsummary}" "${FUNCNAME[0]}" } skip_no_probe_record_support
Signature · 1 line
2.53.0.1018.g2bb0e51243-goog
Namhyung Kim
maintainerRe: [PATCH v2] perf tests task-analyzer: Write test files to tmpdir
I'm curious why this patch is in the idle symbol thread.
Quoted 44 lines · Ian Rogers
Writing to the test output files in the current working directory can fail in various contexts such as continual test. Other tests write to a mktemp-ed file, make the "perf script task-analyszer tests" follow this convention too. Currently this isn't possible for the perf.data file due to a lack of perf script support, add a variable for when this support is available.
Signed-off-by Ian Rogers <[email protected]>--- tools/perf/tests/shell/test_task_analyzer.sh | 38 +++++++++++--------- 1 file changed, 21 insertions(+), 17 deletions(-)tools/perf/tests/shell/test_task_analyzer.sh +8
-4@@ -3,6 +3,11 @@ # SPDX-License-Identifier: GPL-2.0 tmpdir=$(mktemp -d /tmp/perf-script-task-analyzer-XXXXX) +# TODO: perf script report only supports input from the CWD perf.data file, make +# it support input from any file. +perfdata="perf.data" +csv="$tmpdir/csv" +csvsummary="$tmpdir/csvsummary" err=0 # set PERF_EXEC_PATH to find scripts in the source directory@@ -15,11 +20,10 @@ fi export ASAN_OPTIONS=detect_leaks=0 cleanup() { - rm -f perf.data - rm -f perf.data.old - rm -f csv - rm -f csvsummary + rm -f "${perfdata}" + rm -f "${perfdata}".old rm -rf "$tmpdir" + trap - exit term int }
tools/perf/tests/shell/test_task_analyzer.sh skip_no_probe_record_support() { · line 71
Quoted 8 lines
tools/perf/tests/shell/test_task_analyzer.sh +1
-1@@ -61,7 +65,7 @@ skip_no_probe_record_support() { prepare_perf_data() { # 1s should be sufficient to catch at least some switches - perf record -e sched:sched_switch -a -- sleep 1 > /dev/null 2>&1 + perf record -e sched:sched_switch -a -o "${perfdata}" -- sleep 1 > /dev/null 2>&1 # check if perf data file got created in above step. if [ ! -e "perf.data" ]; then printf "FAIL: perf record failed to create \"perf.data\" \n"
Please update this part too.
Thanks,
Namhyung
Quoted 44 lines
tools/perf/tests/shell/test_task_analyzer.sh +12
-12@@ -130,28 +134,28 @@ test_extended_times_summary_ns() { } test_csv() { - perf script report task-analyzer --csv csv > /dev/null - check_exec_0 "perf script report task-analyzer --csv csv" - find_str_or_fail "Comm;" csv "${FUNCNAME[0]}" + perf script report task-analyzer --csv "${csv}" > /dev/null + check_exec_0 "perf script report task-analyzer --csv ${csv}" + find_str_or_fail "Comm;" "${csv}" "${FUNCNAME[0]}" } test_csv_extended_times() { - perf script report task-analyzer --csv csv --extended-times > /dev/null - check_exec_0 "perf script report task-analyzer --csv csv --extended-times" - find_str_or_fail "Out-Out;" csv "${FUNCNAME[0]}" + perf script report task-analyzer --csv "${csv}" --extended-times > /dev/null + check_exec_0 "perf script report task-analyzer --csv ${csv} --extended-times" + find_str_or_fail "Out-Out;" "${csv}" "${FUNCNAME[0]}" } test_csvsummary() { - perf script report task-analyzer --csv-summary csvsummary > /dev/null - check_exec_0 "perf script report task-analyzer --csv-summary csvsummary" - find_str_or_fail "Comm;" csvsummary "${FUNCNAME[0]}" + perf script report task-analyzer --csv-summary "${csvsummary}" > /dev/null + check_exec_0 "perf script report task-analyzer --csv-summary ${csvsummary}" + find_str_or_fail "Comm;" "${csvsummary}" "${FUNCNAME[0]}" } test_csvsummary_extended() { - perf script report task-analyzer --csv-summary csvsummary --summary-extended \ + perf script report task-analyzer --csv-summary "${csvsummary}" --summary-extended \ >/dev/null - check_exec_0 "perf script report task-analyzer --csv-summary csvsummary --summary-extended" - find_str_or_fail "Out-Out;" csvsummary "${FUNCNAME[0]}" + check_exec_0 "perf script report task-analyzer --csv-summary ${csvsummary} --summary-extended" + find_str_or_fail "Out-Out;" "${csvsummary}" "${FUNCNAME[0]}" } skip_no_probe_record_supportSignature · 1 line
2.53.0.1018.g2bb0e51243-goog
Ian Rogers
reviewerRe: [PATCH v2] perf tests task-analyzer: Write test files to tmpdir
Quoted 2 lines · Namhyung Kim
I'm curious why this patch is in the idle symbol thread.
I'll separate it, I was gathering fixes. Same branch has the BPF counters test fix in it:
https://lore.kernel.org/lkml/[email protected]/
Quoted 46 lines · Ian Rogers
Quoted 45 lines
Writing to the test output files in the current working directory can fail in various contexts such as continual test. Other tests write to a mktemp-ed file, make the "perf script task-analyszer tests" follow this convention too. Currently this isn't possible for the perf.data file due to a lack of perf script support, add a variable for when this support is available.
Signed-off-by Ian Rogers <[email protected]>--- tools/perf/tests/shell/test_task_analyzer.sh | 38 +++++++++++--------- 1 file changed, 21 insertions(+), 17 deletions(-)tools/perf/tests/shell/test_task_analyzer.sh +8
-4@@ -3,6 +3,11 @@ # SPDX-License-Identifier: GPL-2.0 tmpdir=$(mktemp -d /tmp/perf-script-task-analyzer-XXXXX) +# TODO: perf script report only supports input from the CWD perf.data file, make +# it support input from any file. +perfdata="perf.data" +csv="$tmpdir/csv" +csvsummary="$tmpdir/csvsummary" err=0 # set PERF_EXEC_PATH to find scripts in the source directory@@ -15,11 +20,10 @@ fi export ASAN_OPTIONS=detect_leaks=0 cleanup() { - rm -f perf.data - rm -f perf.data.old - rm -f csv - rm -f csvsummary + rm -f "${perfdata}" + rm -f "${perfdata}".old rm -rf "$tmpdir" + trap - exit term int }@@ -61,7 +65,7 @@ skip_no_probe_record_support() {
Quoted 9 lines
tools/perf/tests/shell/test_task_analyzer.sh skip_no_probe_record_support() { · line 71
Quoted 7 lines
tools/perf/tests/shell/test_task_analyzer.sh +1
-1prepare_perf_data() { # 1s should be sufficient to catch at least some switches - perf record -e sched:sched_switch -a -- sleep 1 > /dev/null 2>&1 + perf record -e sched:sched_switch -a -o "${perfdata}" -- sleep 1 > /dev/null 2>&1 # check if perf data file got created in above step. if [ ! -e "perf.data" ]; then printf "FAIL: perf record failed to create \"perf.data\" \n"Please update this part too.
Done.
Thanks,
Ian
Quoted 48 lines
Thanks,
NamhyungQuoted 44 lines
tools/perf/tests/shell/test_task_analyzer.sh +12
-13@@ -130,28 +134,28 @@ test_extended_times_summary_ns() { } test_csv() { - perf script report task-analyzer --csv csv > /dev/null - check_exec_0 "perf script report task-analyzer --csv csv" - find_str_or_fail "Comm;" csv "${FUNCNAME[0]}" + perf script report task-analyzer --csv "${csv}" > /dev/null + check_exec_0 "perf script report task-analyzer --csv ${csv}" + find_str_or_fail "Comm;" "${csv}" "${FUNCNAME[0]}" } test_csv_extended_times() { - perf script report task-analyzer --csv csv --extended-times > /dev/null - check_exec_0 "perf script report task-analyzer --csv csv --extended-times" - find_str_or_fail "Out-Out;" csv "${FUNCNAME[0]}" + perf script report task-analyzer --csv "${csv}" --extended-times > /dev/null + check_exec_0 "perf script report task-analyzer --csv ${csv} --extended-times" + find_str_or_fail "Out-Out;" "${csv}" "${FUNCNAME[0]}" } test_csvsummary() { - perf script report task-analyzer --csv-summary csvsummary > /dev/null - check_exec_0 "perf script report task-analyzer --csv-summary csvsummary" - find_str_or_fail "Comm;" csvsummary "${FUNCNAME[0]}" + perf script report task-analyzer --csv-summary "${csvsummary}" > /dev/null + check_exec_0 "perf script report task-analyzer --csv-summary ${csvsummary}" + find_str_or_fail "Comm;" "${csvsummary}" "${FUNCNAME[0]}" } test_csvsummary_extended() { - perf script report task-analyzer --csv-summary csvsummary --summary-extended \ + perf script report task-analyzer --csv-summary "${csvsummary}" --summary-extended \ >/dev/null - check_exec_0 "perf script report task-analyzer --csv-summary csvsummary --summary-extended" - find_str_or_fail "Out-Out;" csvsummary "${FUNCNAME[0]}" + check_exec_0 "perf script report task-analyzer --csv-summary ${csvsummary} --summary-extended" + find_str_or_fail "Out-Out;" "${csvsummary}" "${FUNCNAME[0]}" } skip_no_probe_record_support --2.53.0.1018.g2bb0e51243-goog
Namhyung Kim
maintainerRe: [PATCH v2] perf tests task-analyzer: Write test files to tmpdir
Quoted 7 lines · Ian Rogers
Quoted 2 lines · Namhyung Kim
I'm curious why this patch is in the idle symbol thread.
I'll separate it, I was gathering fixes. Same branch has the BPF counters test fix in it:
https://lore.kernel.org/lkml/[email protected]/
Ok, I'll test and process it.
Thanks,
Namhyung