Skip to contentSkip to conversation

media: ipu-bridge: Add Dell 14 Premium DA14250 to upside-down DMI table

PATCH In review MaximeD 2 participants 2 messages Mar 28 – Mar 30 Media (V4L/DVB)

lore
Share & tools
lore

MaximeD

author
#0 lore raw

PATCH 1/1 media: ipu-bridge: Add Dell 14 Premium DA14250 to upside-down DMI table

From: Maxime Deraspe <[email protected]>

The Dell 14 Premium DA14250 (Lunar Lake) has its ov02c10 front camera sensor mounted upside-down, but the ACPI SSDB does not report a 180° rotation. Add a DMI quirk entry so that the ipu-bridge driver reports the correct rotation, allowing libcamera and applications to display the camera image with the proper orientation.

---
 drivers/media/pci/intel/ipu-bridge.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/media/pci/intel/ipu-bridge.c +7 -0
index b2b710094..2611a96fc 100644
@@ -118,6 +118,13 @@ static const struct dmi_system_id upside_down_sensor_dmi_ids[] = {
 		},
 		.driver_data = "OVTI02C1",
 	},
+	{
+		.matches = {
+			DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Dell 14 Premium DA14250"),
+		},
+		.driver_data = "OVTI02C1",
+	},
 	{} /* Terminating entry */
 };
 
Signature · 1 line
2.53.0
Reviewed-by on v1 1/1
#1 lore raw

Hi,

Quoted 9 lines · MaximeD

From: Maxime Deraspe <[email protected]>

The Dell 14 Premium DA14250 (Lunar Lake) has its ov02c10 front camera sensor mounted upside-down, but the ACPI SSDB does not report a 180° rotation. Add a DMI quirk entry so that the ipu-bridge driver reports the correct rotation, allowing libcamera and applications to display the camera image with the proper orientation.

Thanks, patch looks good to me:

Regards,

Hans

Quoted 22 lines
---
 drivers/media/pci/intel/ipu-bridge.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/media/pci/intel/ipu-bridge.c +7 -0
index b2b710094..2611a96fc 100644
@@ -118,6 +118,13 @@ static const struct dmi_system_id upside_down_sensor_dmi_ids[] = {
 		},
 		.driver_data = "OVTI02C1",
 	},
+	{
+		.matches = {
+			DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Dell 14 Premium DA14250"),
+		},
+		.driver_data = "OVTI02C1",
+	},
 	{} /* Terminating entry */
 };