patch "iio: adc: ade9000: fix wrong register in CALIBBIAS case for active" added to char-misc-linus
This is a note to let you know that I've just added the patch titled
iio: adc: ade9000: fix wrong register in CALIBBIAS case for active
to my char-misc git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
in the char-misc-linus branch.
The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)
The patch will hopefully also be merged in Linus's tree for the next -rc kernel release.
If you have any questions about this process, please let me know.
From 86133fb1ec36b2f5cec29d71fbae84877c3a1358 Mon Sep 17 00:00:00 2001
From: Giorgi Tchankvetadze <[email protected]>
Date: Thu, 26 Feb 2026 18:07:02 +0400
Subject: iio: adc: ade9000: fix wrong register in CALIBBIAS case for active
power
The switch statement in ade9000_write_raw() attempts to match chan->address against ADE9000_REG_AWATTOS (0x00F) to dispatch the calibration offset write for active power channels. However, chan->address is set via ADE9000_ADDR_ADJUST(ADE9000_REG_AWATT, num), so after masking the phase bits, tmp holds ADE9000_REG_AWATT (0x210), which never matches 0x00F.
As a result, writing IIO_CHAN_INFO_CALIBBIAS for IIO_POWER always falls through to the default case and returns -EINVAL, making active power offset calibration silently broken.
Fix this by matching against ADE9000_REG_AWATT instead, which is the actual base address stored in chan->address for watt channels.
Reference:ADE9000 datasheet (Rev. B), AWATTOS is the offset correction register at 0x00F (p. 44), while AWATT is the total active power register at 0x210 (p. 48).
--- drivers/iio/adc/ade9000.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/adc/ade9000.c +1 -1
@@ -1123,7 +1123,7 @@ static int ade9000_write_raw(struct iio_dev *indio_dev, tmp &= ~ADE9000_PHASE_C_POS_BIT ;switch (tmp) { -case ADE9000_REG_AWATTOS : +case ADE9000_REG_AWATT :return regmap_write (st->regmap,ADE9000_ADDR_ADJUST (ADE9000_REG_AWATTOS , chan->channel), val);
Signature · 1 line
2.53.0