Skip to contentSkip to conversation

scsi: ufs: qcom: stop ignoring hibern8 exit failures

PATCH NAK Josh Law 2 participants 2 messages Mar 29 – Mar 30

Subsystems (3)
lore
Share & tools
lore

Josh Law

author
#0 lore raw

PATCH 1/1 scsi: ufs: qcom: stop ignoring hibern8 exit failures

Right now, we're blindly returning success even if waking the link fails during clock scaling. This is a mess because the core then tries to send SCSI commands to a dead link, causing huge timeouts.

Just return the actual error so the core can catch the failure and roll back properly.

---
 drivers/ufs/host/ufs-qcom.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/ufs/host/ufs-qcom.c +2 -2
index 375fd24ba458..5d33a921a22f 100644
@@ -1750,10 +1750,10 @@ static int ufs_qcom_clk_scale_notify(struct ufs_hba *hba, bool scale_up,
 		}
 
 		ufs_qcom_icc_update_bw(host);
-		ufshcd_uic_hibern8_exit(hba);
+		err = ufshcd_uic_hibern8_exit(hba);
 	}
 
-	return 0;
+	return err;
 }
 
 static void ufs_qcom_enable_test_bus(struct ufs_qcom_host *host)
Signature · 1 line
2.34.1
#1 lore raw
Quoted 3 lines · Josh Law

Right now, we're blindly returning success even if waking the link fails during clock scaling. This is a mess because the core then tries to send SCSI commands to a dead link, causing huge timeouts.

Just return the actual error so the core can catch the failure and roll back properly.

NAK, you were asked way too many times for the same and you just ignore people's feedback.

Best regards,
Krzysztof