patch "iio: adc: ad7768-1: remove switch to one-shot mode" added to char-misc-next

PATCH [email protected] 1 participant 1 message Mar 29

Subsystems (4)

Stable branch IIO Analog Devices IIO drivers Analog devices inc AD7768-1 driver

lore

Share & tools

lore

[email protected]

author maintainer Applied

2026-03-29 13:07 UTC #0 lore raw

This is a note to let you know that I've just added the patch titled

iio: adc: ad7768-1: remove switch to one-shot mode

to my char-misc git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
in the char-misc-next branch.

The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)

The patch will also be merged in the next major kernel release during the merge window.

If you have any questions about this process, please let me know.

From 81fdc3127d013a552465c3bf9829afbed5184406 Mon Sep 17 00:00:00 2001
From: Jonathan Santos <[email protected]>
Date: Mon, 23 Feb 2026 08:59:35 -0300
Subject: iio: adc: ad7768-1: remove switch to one-shot mode

wideband low ripple FIR Filter is not available in one-shot mode. In order to make direct reads work for all filter options, remove the switch for one-shot mode and guarantee device is always in continuous conversion mode.

Fixes fb1d3b24ebf5 ("iio: adc: ad7768-1: add filter type and oversampling ratio attributes")

Signed-off-by Jonathan Santos <[email protected]>

Reviewed-by David Lechner <[email protected]>

Cc <[email protected]>

Signed-off-by Jonathan Cameron <[email protected]>

---
 drivers/iio/adc/ad7768-1.c | 21 ++++-----------------
 1 file changed, 4 insertions(+), 17 deletions(-)

drivers/iio/adc/ad7768-1.c +4 ~~-17~~

index 4cb63ab4768a..a927ae288fbb 100644
@@ -463,17 +463,8 @@ static int ad7768_scan_direct(struct iio_dev *indio_dev)
 	struct ad7768_state *st = iio_priv(indio_dev);
 	int readval, ret;
 
-	ret = ad7768_set_mode(st, AD7768_ONE_SHOT);
-	if (ret < 0)
-		return ret;
-
 	reinit_completion(&st->completion);
 
-	/* One-shot mode requires a SYNC pulse to generate a new sample */
-	ret = ad7768_send_sync_pulse(st);
-	if (ret)
-		return ret;
-
 	ret = wait_for_completion_timeout(&st->completion,
 					  msecs_to_jiffies(1000));
 	if (!ret)

@@ -492,14 +483,6 @@ static int ad7768_scan_direct(struct iio_dev *indio_dev)
 	if (st->oversampling_ratio == 8)
 		readval >>= 8;
 
-	/*
-	 * Any SPI configuration of the AD7768-1 can only be
-	 * performed in continuous conversion mode.
-	 */
-	ret = ad7768_set_mode(st, AD7768_CONTINUOUS);
-	if (ret < 0)
-		return ret;
-
 	return readval;
 }

@@ -1248,6 +1231,10 @@ static int ad7768_setup(struct iio_dev *indio_dev)
 			return ret;
 	}
 
+	ret = ad7768_set_mode(st, AD7768_CONTINUOUS);
+	if (ret)
+		return ret;
+
 	/* For backwards compatibility, try the adi,sync-in-gpios property */
 	st->gpio_sync_in = devm_gpiod_get_optional(&st->spi->dev, "adi,sync-in",
 						   GPIOD_OUT_LOW);

Signature · 1 line

2.53.0