Skip to contentSkip to conversation

wifi: ath12k: Skip adding inactive partner vdev info

PATCH Applied Roopni Devanathan 4 participants 4 messages Mar 30 – Apr 8 Qualcomm ATH12K wireless driver

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 wifi: ath12k: Skip adding inactive partner vdev info

From: Avula Sri Charan <[email protected]>

Currently, a vdev that is created is considered active for partner link population. In case of an MLD station, non-associated link vdevs can be created but not started. Yet, they are added as partner links. This leads to the creation of stale FW partner entries which accumulate and cause assertions.

To resolve this issue, check if the vdev is started and operating on a chosen frequency, i.e., arvif->is_started, instead of checking if the vdev is created, i.e., arvif->is_created. This determines if the vdev is active or not and skips adding it as a partner link if it's inactive.

Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.6-01181-QCAHKSWPL_SILICONZ-1

---
 drivers/net/wireless/ath/ath12k/mac.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/ath/ath12k/mac.c +1 -1
index 553ec28b6aaa..c1a1b220f4dd 100644
@@ -11131,7 +11131,7 @@ ath12k_mac_mlo_get_vdev_args(struct ath12k_link_vif *arvif,
 		if (arvif == arvif_p)
 			continue;
 
-		if (!arvif_p->is_created)
+		if (!arvif_p->is_started)
 			continue;
 
 		link_conf = wiphy_dereference(ahvif->ah->hw->wiphy,

base-commit: 15551ababf6d4e857f2101366a0c3eaa86dd822c

Signature · 1 line
2.43.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 35 lines · Roopni Devanathan

From: Avula Sri Charan <[email protected]>

Currently, a vdev that is created is considered active for partner link population. In case of an MLD station, non-associated link vdevs can be created but not started. Yet, they are added as partner links. This leads to the creation of stale FW partner entries which accumulate and cause assertions.

To resolve this issue, check if the vdev is started and operating on a chosen frequency, i.e., arvif->is_started, instead of checking if the vdev is created, i.e., arvif->is_created. This determines if the vdev is active or not and skips adding it as a partner link if it's inactive.

Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.6-01181-QCAHKSWPL_SILICONZ-1

---
 drivers/net/wireless/ath/ath12k/mac.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/ath/ath12k/mac.c +1 -1
index 553ec28b6aaa..c1a1b220f4dd 100644
@@ -11131,7 +11131,7 @@ ath12k_mac_mlo_get_vdev_args(struct ath12k_link_vif *arvif,
 		if (arvif == arvif_p)
 			continue;
 
-		if (!arvif_p->is_created)
+		if (!arvif_p->is_started)
 			continue;
 
 		link_conf = wiphy_dereference(ahvif->ah->hw->wiphy,
Quoted 1 line

base-commit: 15551ababf6d4e857f2101366a0c3eaa86dd822c

Reviewed-by on v1 1/1
#2 lore raw
In reply to Roopni Devanathan
Quoted 35 lines · Roopni Devanathan

From: Avula Sri Charan <[email protected]>

Currently, a vdev that is created is considered active for partner link population. In case of an MLD station, non-associated link vdevs can be created but not started. Yet, they are added as partner links. This leads to the creation of stale FW partner entries which accumulate and cause assertions.

To resolve this issue, check if the vdev is started and operating on a chosen frequency, i.e., arvif->is_started, instead of checking if the vdev is created, i.e., arvif->is_created. This determines if the vdev is active or not and skips adding it as a partner link if it's inactive.

Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.6-01181-QCAHKSWPL_SILICONZ-1

---
  drivers/net/wireless/ath/ath12k/mac.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/ath/ath12k/mac.c +1 -1
index 553ec28b6aaa..c1a1b220f4dd 100644
@@ -11131,7 +11131,7 @@ ath12k_mac_mlo_get_vdev_args(struct ath12k_link_vif *arvif,
  		if (arvif == arvif_p)
  			continue;
 
-		if (!arvif_p->is_created)
+		if (!arvif_p->is_started)
  			continue;
 
  		link_conf = wiphy_dereference(ahvif->ah->hw->wiphy,
Quoted 1 line

base-commit: 15551ababf6d4e857f2101366a0c3eaa86dd822c

Applied
#3 lore raw
In reply to Roopni Devanathan
Quoted 6 lines · Roopni Devanathan

Currently, a vdev that is created is considered active for partner link population. In case of an MLD station, non-associated link vdevs can be created but not started. Yet, they are added as partner links. This leads to the creation of stale FW partner entries which accumulate and cause assertions.

Quoted 6 lines

To resolve this issue, check if the vdev is started and operating on a chosen frequency, i.e., arvif->is_started, instead of checking if the vdev is created, i.e., arvif->is_created. This determines if the vdev is active or not and skips adding it as a partner link if it's inactive.

[...]

Applied, thanks!

[1/1] wifi: ath12k: Skip adding inactive partner vdev info

      commit: 7d7dc26f72abb7a76abb4a68ebad75d5ab7b375e

Best regards,

Signature · 1 line
Jeff Johnson <[email protected]>