Skip to contentSkip to conversation

lto: disable LTO for e2fsprogs

PATCH In review [email protected] 3 participants 3 messages Mar 30 – Apr 13

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 lto: disable LTO for e2fsprogs

From: Thomas Perrot <[email protected]>

Fat LTO objects embed original source paths in .gnu.lto_* IR sections which are not remapped by -ffile-prefix-map. This causes buildpaths QA failures for libss.a and libext2fs.a in the e2fsprogs-staticdev package.

Disable LTO for e2fsprogs to prevent TMPDIR references from leaking into the installed static libraries.

---
 meta/conf/distro/include/lto.inc | 2 ++
 1 file changed, 2 insertions(+)
meta/conf/distro/include/lto.inc +2 -0
index 2802d38ad3df..7471360236f9 100644
@@ -4,6 +4,8 @@
 #
 
 # Disable LTO for following packages
+
+LTO:pn-e2fsprogs = "" 
 LTO:pn-expect = "" 
 LTO:pn-glibc = ""
 LTO:pn-gcc-runtime = ""
Signature · 1 line
2.53.0
#1 lore raw

Thomas Perrot via lists.openembedded.org schrieb am Di 31. Mär, 01:07 (+0200):

Quoted 8 lines

From: Thomas Perrot <[email protected]>

Fat LTO objects embed original source paths in .gnu.lto_* IR sections which are not remapped by -ffile-prefix-map. This causes buildpaths QA failures for libss.a and libext2fs.a in the e2fsprogs-staticdev package.

Disable LTO for e2fsprogs to prevent TMPDIR references from leaking into the installed static libraries.

For e2fsprogs this was a patch I've used to fix the LTO problem. Feel free to take it:

recipes/e2fsprogs/e2fsprogs/lto.patch new file +38 -0
new file mode 100644
index 0000000..cf5c076
@@ -0,0 +1,38 @@
+Upstream-Status: Inappropriate [ TODO ]
+
+diff --git i/lib/ext2fs/Makefile.in w/lib/ext2fs/Makefile.in
+index e9a6ced2..998ccd19 100644
+--- i/lib/ext2fs/Makefile.in
++++ w/lib/ext2fs/Makefile.in
+@@ -262,11 +262,11 @@ all:: ext2fs.pc
+ 
+ .c.o:
+ 	$(E) "	CC $<"
+-	$(Q) $(CC) $(ALL_CFLAGS_STLIB) -c $< -o $@
++	$(Q) $(CC) $(ALL_CFLAGS_STLIB) -c ./$< -o $@
+ 	$(Q) $(CHECK_CMD) $(ALL_CFLAGS) $<
+ 	$(Q) $(CPPCHECK_CMD) $(CPPFLAGS) $<
+ @PROFILE_CMT@	$(Q) $(CC) $(ALL_CFLAGS_STLIB) -g -pg -o profiled/$*.o -c $<
+-@ELF_CMT@	$(Q) $(CC) $(ALL_CFLAGS_SHLIB) -fPIC -shared -o elfshared/$*.o -c $<
++@ELF_CMT@	$(Q) $(CC) $(ALL_CFLAGS_SHLIB) -fPIC -shared -o elfshared/$*.o -c ./$<
+ @BSDLIB_CMT@	$(Q) $(CC) $(ALL_CFLAGS_SHLIB) $(BSDLIB_PIC_FLAG) -o pic/$*.o -c $<
+ 
+ DISTFILES= Makefile *.c *.h image
+diff --git i/lib/ss/Makefile.in w/lib/ss/Makefile.in
+index bb504189..9d8ec595 100644
+--- i/lib/ss/Makefile.in
++++ w/lib/ss/Makefile.in
+@@ -34,11 +34,11 @@ COMPILE_ET=	_ET_DIR_OVERRIDE=$(srcdir)/../et ../et/compile_et
+ 
+ .c.o:
+ 	$(E) "	CC $<"
+-	$(Q) $(CC) $(ALL_CFLAGS_STLIB) -c $<
++	$(Q) $(CC) $(ALL_CFLAGS_STLIB) -c ./$<
+ 	$(Q) $(CHECK_CMD) $(ALL_CFLAGS) $<
+ 	$(Q) $(CPPCHECK_CMD) $(CPPFLAGS) $<
+ @PROFILE_CMT@	$(Q) $(CC) $(ALL_CFLAGS_STLIB) -g -pg -o profiled/$*.o -c $<
+-@ELF_CMT@	$(Q) $(CC) $(ALL_CFLAGS_SHLIB) -DSHARED_ELF_LIB -fPIC -shared -o elfshared/$*.o -c $<
++@ELF_CMT@	$(Q) $(CC) $(ALL_CFLAGS_SHLIB) -DSHARED_ELF_LIB -fPIC -shared -o elfshared/$*.o -c ./$<
+ @BSDLIB_CMT@	$(Q) $(CC) $(ALL_CFLAGS_SHLIB) $(BSDLIB_PIC_FLAG) -o pic/$*.o -c $<
+ 
+ # for the library
recipes/e2fsprogs/e2fsprogs_%.bbappend new file +5 -0
new file mode 100644
index 0000000..ee75686
@@ -0,0 +1,5 @@
+FILESEXTRAPATHS:prepend := "${THISDIR}/${BPN}:"
+
+SRC_URI += "\
+    file://lto.patch \
+"
Signature · 6 lines
Navimatix GmbH           T: 03641 - 327 99 0
Tatzendpromenade 2       F: 03641 - 526 306
07745 Jena               www.navimatix.de

Geschäftsführer: Steffen Späthe, Jan Rommeley
Registergericht: Amtsgericht Jena, HRB 501480
#2 lore raw
In reply to [email protected]
Quoted 6 lines · Thomas Perrot via lists.openembedded.org

From: Thomas Perrot <[email protected]>

Fat LTO objects embed original source paths in .gnu.lto_* IR sections which are not remapped by -ffile-prefix-map. This causes buildpaths QA failures for libss.a and libext2fs.a in the e2fsprogs-staticdev package.

As this is a GCC-specific issue, can you add a toolchain-gcc override to this too?

Thanks,
Ross