Skip to contentSkip to conversation

IB/mlx5: Fix potential NULL dereference in query_device

PATCH Prathamesh Deshpande 2 participants 3 messages Mar 31 – Apr 10 1 message not in the archive InfiniBand

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): 202603311604.GD814676@unreal

#1 lore raw
Quoted 2 lines · Leon Romanovsky

Kernel-space callers don't use uverbs path. It is solely for the user-space access.

Hi Leon,

Understood. Smatch flags this as an "inconsistent NULL check" because 'uhw' is explicitly checked at line 967 (if (uhw && ...)).

If 'uhw' is guaranteed to be non-NULL in this path, would you prefer a patch removing the redundant check at line 967 instead? This would align the logic and silence the static analysis warning.

Thanks,
Prathamesh

#2 lore raw
Quoted 4 lines · Prathamesh Deshpande
Quoted 2 lines · Leon Romanovsky

Kernel-space callers don't use uverbs path. It is solely for the user-space access.

Quoted 8 lines

Hi Leon,

Understood. Smatch flags this as an "inconsistent NULL check" because 'uhw' is explicitly checked at line 967 (if (uhw && ...)).

If 'uhw' is guaranteed to be non-NULL in this path, would you prefer a patch removing the redundant check at line 967 instead? This would align the logic and silence the static analysis warning.

uhw is not guaranteed to be non-NULL in mlx5_ib_query_device(). This function is used in both kernel and user-space paths. The only condition that cannot occur is a caller providing a non-zero 'uhw_outlen' while passing a NULL 'uhw' pointer.

If the caller provides 'uhw_outlen', then 'uhw' will always be present. The reverse, however, is not always true. See:

944 static int mlx5_ib_query_device(struct ib_device *ibdev,
945 struct ib_device_attr *props,
946 struct ib_udata *uhw)
947 {
948 size_t uhw_outlen = (uhw) ? uhw->outlen : 0;

Thanks

Quoted 4 lines

Thanks,
Prathamesh

#3 lore raw
Quoted 4 lines · Leon Romanovsky

uhw is not guaranteed to be non-NULL in mlx5_ib_query_device(). This function is used in both kernel and user-space paths. The only condition that cannot occur is a caller providing a non-zero 'uhw_outlen' while passing a NULL 'uhw' pointer.

Hi Leon,

Thanks for the explanation. Since uhw_outlen effectively guards uhw in these paths, I’ll drop this patch as a static analysis false positive.

Thanks,
Prathamesh