staging: sm750fb: constify fix_id array
PATCH v4 1/1 staging: sm750fb: constify fix_id array
Add the missing 'const' qualifier to the static fix_id array to ensure the pointer array itself is immutable.
Originally:
static const char *fix_id[2];
The strings are constant, but the pointer array itself is writable.
With the change:
static const char * const fix_id[2];
Both the strings and the pointer array are immutable, allowing the compiler to treat the object as read-only.
Verified by inspecting the generated object file with 'nm':
00000000000002b8 0000000000000010 r fix_id.3
The 'r' flag indicates the symbol is placed in a read-only section.
This does not change runtime behavior as fix_id is never modified.
Signed-off-by Hungyu Lin <[email protected]>
---
Changes in v4:
- Clarify const semantics of fix_id.
- Add compiler output showing symbol is read-only.
--- drivers/staging/sm750fb/sm750.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/sm750fb/sm750.c +1 -1
@@ -728,7 +728,7 @@ static int lynxfb_set_fbinfo(struct fb_info *info, int index) lynx750_ext, NULL, vesa_modes, };int cdb[] = {ARRAY_SIZE (lynx750_ext),0 ,VESA_MODEDB_SIZE }; -static const char *fix_id[2 ] = { +static const char *const fix_id[2 ] = {"sm750_fb1" ,"sm750_fb2" , };
Signature · 1 line
2.34.1