Skip to contentSkip to conversation

staging: most/net: remove dead code from skb_to_mamac() and skb_to_mep()

PATCH New Hadi Chokr 1 participant 1 message Apr 1

Subsystems (2)
lore
Share & tools
lore

Hadi Chokr

author
#0 lore raw

PATCH 1/1 staging: most/net: remove dead code from skb_to_mamac() and skb_to_mep()

The overflow checks in skb_to_mamac() and skb_to_mep() are always false:

mdp_len = (skb->len - ETH_HLEN) + MDP_HDR_LEN = skb->len + 2 mep_len = skb->len + MEP_HDR_LEN = skb->len + 8

Remove these checks to clean up the code.

---
 drivers/staging/most/net/net.c | 10 ----------
 1 file changed, 10 deletions(-)
drivers/staging/most/net/net.c +0 -10
index fffdb60cd230..07fd18e9096d 100644
@@ -80,11 +80,6 @@ static int skb_to_mamac(const struct sk_buff *skb, struct mbo *mbo)
 	unsigned int payload_len = skb->len - ETH_HLEN;
 	unsigned int mdp_len = payload_len + MDP_HDR_LEN;
 
-	if (mdp_len < skb->len) {
-		pr_err("drop: too large packet! (%u)\n", skb->len);
-		return -EINVAL;
-	}
-
 	if (mbo->buffer_length < mdp_len) {
 		pr_err("drop: too small buffer! (%d for %d)\n",
 		       mbo->buffer_length, mdp_len);
@@ -132,11 +127,6 @@ static int skb_to_mep(const struct sk_buff *skb, struct mbo *mbo)
 	u8 *buff = mbo->virt_address;
 	unsigned int mep_len = skb->len + MEP_HDR_LEN;
 
-	if (mep_len < skb->len) {
-		pr_err("drop: too large packet! (%u)\n", skb->len);
-		return -EINVAL;
-	}
-
 	if (mbo->buffer_length < mep_len) {
 		pr_err("drop: too small buffer! (%d for %d)\n",
 		       mbo->buffer_length, mep_len);
Signature · 1 line
2.53.0