Skip to contentSkip to conversation

power: sequencing: pcie-m2: add SERIAL_DEV_BUS dependency

PATCH Applied Arnd Bergmann 4 participants 6 messages Apr 1 – Apr 3 Power sequencing

lore
Share & tools
lore

Arnd Bergmann

author
#0 lore raw

PATCH 1/1 power: sequencing: pcie-m2: add SERIAL_DEV_BUS dependency

From: Arnd Bergmann <[email protected]>

The newly added serdev code fails to link when serdev is turned off:

arm-linux-gnueabi-ld: drivers/power/sequencing/pwrseq-pcie-m2.o: in function `pwrseq_pcie_m2_remove_serdev':
pwrseq-pcie-m2.c:(.text+0xc8): undefined reference to `serdev_device_remove'
arm-linux-gnueabi-ld: drivers/power/sequencing/pwrseq-pcie-m2.o: in function `pwrseq_m2_pcie_notify':
pwrseq-pcie-m2.c:(.text+0x69c): undefined reference to `of_find_serdev_controller_by_node'
arm-linux-gnueabi-ld: pwrseq-pcie-m2.c:(.text+0x6f8): undefined reference to `serdev_device_alloc'
arm-linux-gnueabi-ld: pwrseq-pcie-m2.c:(.text+0x724): undefined reference to `serdev_device_add'

Add another Kconfig dependency for this

Fixes 3f736aecbdc8 ("power: sequencing: pcie-m2: Create serdev device for WCN7850 bluetooth")
Signed-off-by Arnd Bergmann <[email protected]>

---
I noticed this one only after I had already sent the patch to add the other two dependency, feel free to combine the patches into one

---
 drivers/power/sequencing/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/power/sequencing/Kconfig +1 -0
index 77c6d9227251..1c5f5820f5b7 100644
@@ -39,6 +39,7 @@ config POWER_SEQUENCING_PCIE_M2
 	tristate "PCIe M.2 connector power sequencing driver"
 	depends on OF
 	depends on PCI
+	depends on SERIAL_DEV_BUS
 	select OF_DYNAMIC
 	help
 	  Say Y here to enable the power sequencing driver for PCIe M.2
Signature · 1 line
2.39.5
maintainer
#1 lore raw
Quoted 36 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

The newly added serdev code fails to link when serdev is turned off:

arm-linux-gnueabi-ld: drivers/power/sequencing/pwrseq-pcie-m2.o: in function `pwrseq_pcie_m2_remove_serdev':
pwrseq-pcie-m2.c:(.text+0xc8): undefined reference to `serdev_device_remove'
arm-linux-gnueabi-ld: drivers/power/sequencing/pwrseq-pcie-m2.o: in function `pwrseq_m2_pcie_notify':
pwrseq-pcie-m2.c:(.text+0x69c): undefined reference to `of_find_serdev_controller_by_node'
arm-linux-gnueabi-ld: pwrseq-pcie-m2.c:(.text+0x6f8): undefined reference to `serdev_device_alloc'
arm-linux-gnueabi-ld: pwrseq-pcie-m2.c:(.text+0x724): undefined reference to `serdev_device_add'

Add another Kconfig dependency for this

Fixes 3f736aecbdc8 ("power: sequencing: pcie-m2: Create serdev device for WCN7850 bluetooth")
Signed-off-by Arnd Bergmann <[email protected]>

---
I noticed this one only after I had already sent the patch to add the other two dependency, feel free to combine the patches into one

---
 drivers/power/sequencing/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/power/sequencing/Kconfig +1 -1
index 77c6d9227251..1c5f5820f5b7 100644
@@ -39,6 +39,7 @@ config POWER_SEQUENCING_PCIE_M2
        tristate "PCIe M.2 connector power sequencing driver"
        depends on OF
        depends on PCI
+       depends on SERIAL_DEV_BUS
        select OF_DYNAMIC
        help
          Say Y here to enable the power sequencing driver for PCIe M.2
--
Quoted 2 lines

2.39.5

I assume with this patch[1] from Mani, we no longer need this one?

Bart

[1] https://lore.kernel.org/all/[email protected]/

#2 lore raw
Quoted 19 lines · Bartosz Golaszewski
Quoted 13 lines · Arnd Bergmann
drivers/power/sequencing/Kconfig +1 -1
index 77c6d9227251..1c5f5820f5b7 100644
@@ -39,6 +39,7 @@ config POWER_SEQUENCING_PCIE_M2
        tristate "PCIe M.2 connector power sequencing driver"
        depends on OF
        depends on PCI
+       depends on SERIAL_DEV_BUS
        select OF_DYNAMIC
        help
          Say Y here to enable the power sequencing driver for PCIe M.2
--
Quoted 2 lines

2.39.5

I assume with this patch[1] from Mani, we no longer need this one?

Quoted 2 lines

[1]
https://lore.kernel.org/all/[email protected]/

Depends on which one you mean with 'this one'.

My patch is needed with or without Mani's, while
his patch is harmless but does not fix the issue.

Arnd

maintainer
#3 lore raw
Quoted 24 lines · Arnd Bergmann
Quoted 19 lines · Bartosz Golaszewski
Quoted 13 lines · Arnd Bergmann
drivers/power/sequencing/Kconfig +1 -1
index 77c6d9227251..1c5f5820f5b7 100644
@@ -39,6 +39,7 @@ config POWER_SEQUENCING_PCIE_M2
        tristate "PCIe M.2 connector power sequencing driver"
        depends on OF
        depends on PCI
+       depends on SERIAL_DEV_BUS
        select OF_DYNAMIC
        help
          Say Y here to enable the power sequencing driver for PCIe M.2
--
Quoted 2 lines

2.39.5

I assume with this patch[1] from Mani, we no longer need this one?

Quoted 2 lines

[1]
https://lore.kernel.org/all/[email protected]/

Quoted 6 lines

Depends on which one you mean with 'this one'.

My patch is needed with or without Mani's, while
his patch is harmless but does not fix the issue.

Arnd

Mani's patch adds stubs for the symbols that the linker couldn't find in the build error you posted above. I thought this would fix the issue?

Bart

#4 lore raw
Quoted 5 lines · Bartosz Golaszewski

On Thu, Apr 2, 2026 at 5:42 PM Arnd Bergmann <[email protected]> wrote:

Mani's patch adds stubs for the symbols that the linker couldn't find in the build error you posted above. I thought this would fix the issue?

No, when you have POWER_SEQUENCING_PCIE_M2=y and CONFIG_SERIAL_DEV_BUS=m, you still get the same build failure.

Arnd

Applied
#5 lore raw
In reply to Arnd Bergmann
Quoted 10 lines · Arnd Bergmann

The newly added serdev code fails to link when serdev is turned off:

arm-linux-gnueabi-ld: drivers/power/sequencing/pwrseq-pcie-m2.o: in function `pwrseq_pcie_m2_remove_serdev':
pwrseq-pcie-m2.c:(.text+0xc8): undefined reference to `serdev_device_remove'
arm-linux-gnueabi-ld: drivers/power/sequencing/pwrseq-pcie-m2.o: in function `pwrseq_m2_pcie_notify':
pwrseq-pcie-m2.c:(.text+0x69c): undefined reference to `of_find_serdev_controller_by_node'
arm-linux-gnueabi-ld: pwrseq-pcie-m2.c:(.text+0x6f8): undefined reference to `serdev_device_alloc'
arm-linux-gnueabi-ld: pwrseq-pcie-m2.c:(.text+0x724): undefined reference to `serdev_device_add'

[...]

Applied, thanks!

[1/1] power: sequencing: pcie-m2: add SERIAL_DEV_BUS dependency

      https://git.kernel.org/brgl/c/b4464d8f313f903ba72db06042f3958a9a1e464a

Best regards,

Signature · 1 line
Bartosz Golaszewski <[email protected]>