Skip to contentSkip to conversation

HSI: omap_ssi_port: remove set but unused variables

PATCH Applied Rosen Penev 2 participants 2 messages Apr 1 – Apr 2 HSI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 HSI: omap_ssi_port: remove set but unused variables

W=1 build warns that these are set and unused. eg:

error: variable ‘mode’ set but not used
[-Werror=unused-but-set-variable]

---
 drivers/hsi/controllers/omap_ssi_port.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)
drivers/hsi/controllers/omap_ssi_port.c +2 -5
index 73932d7257d3..99904312879b 100644
@@ -452,7 +452,6 @@ static int ssi_setup(struct hsi_client *cl)
 	void __iomem *sst = omap_port->sst_base;
 	void __iomem *ssr = omap_port->ssr_base;
 	u32 div;
-	u32 val;
 	int err = 0;
 
 	pm_runtime_get_sync(omap_port->pdev);
@@ -470,7 +469,7 @@ static int ssi_setup(struct hsi_client *cl)
 	writel_relaxed(SSI_MODE_SLEEP, sst + SSI_SST_MODE_REG);
 	writel_relaxed(SSI_MODE_SLEEP, ssr + SSI_SSR_MODE_REG);
 	/* Flush posted write */
-	val = readl(ssr + SSI_SSR_MODE_REG);
+	readl(ssr + SSI_SSR_MODE_REG);
 	/* TX */
 	writel_relaxed(31, sst + SSI_SST_FRAMESIZE_REG);
 	writel_relaxed(div, sst + SSI_SST_DIVISOR_REG);
@@ -1299,14 +1298,12 @@ static int ssi_restore_port_ctx(struct omap_ssi_port *omap_port)
 
 static int ssi_restore_port_mode(struct omap_ssi_port *omap_port)
 {
-	u32 mode;
-
 	writel_relaxed(omap_port->sst.mode,
 				omap_port->sst_base + SSI_SST_MODE_REG);
 	writel_relaxed(omap_port->ssr.mode,
 				omap_port->ssr_base + SSI_SSR_MODE_REG);
 	/* OCP barrier */
-	mode = readl(omap_port->ssr_base + SSI_SSR_MODE_REG);
+	readl(omap_port->ssr_base + SSI_SSR_MODE_REG);
 
 	return 0;
 }
Signature · 1 line
2.53.0
#1 lore raw
Quoted 6 lines · Rosen Penev

W=1 build warns that these are set and unused. eg:

error: variable ‘mode’ set but not used
[-Werror=unused-but-set-variable]

Applied, thanks!

[1/1] HSI: omap_ssi_port: remove set but unused variables

      commit: 1e7269aa6880b3d6b458b8618431292091199718

Best regards,

Signature · 1 line
Sebastian Reichel <[email protected]>